Commits · f58163447f3b593073161b2e447d9e4f9d5ec6d7 · abdullh.alsoleman / Front-End

22 Sep, 2023 16 commits

Roll Flutter Engine from 9d06c176cf98 to e97155428ad4 (1 revision) (#135306) · f5816344

engine-flutter-autoroll authored Sep 22, 2023

https://github.com/flutter/engine/compare/9d06c176cf98...e97155428ad4

2023-09-22 skia-flutter-autoroll@skia.org Roll Skia from d0f04adbec5c to a911bc1352f2 (1 revision) (flutter/engine#46194)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f5816344

Roll Flutter Engine from b642e4f4dffa to 9d06c176cf98 (2 revisions) (#135304) · 6502883a

engine-flutter-autoroll authored Sep 22, 2023

https://github.com/flutter/engine/compare/b642e4f4dffa...9d06c176cf98

2023-09-22 skia-flutter-autoroll@skia.org Roll Dart SDK from 6bde93a6e56f to 4ddff752a6b0 (1 revision) (flutter/engine#46193)
2023-09-22 whesse@google.com Re-add package tar to DEPS (flutter/engine#46190)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6502883a

Roll Flutter Engine from 2fa8dec336d0 to b642e4f4dffa (1 revision) (#135295) · 99192f83

engine-flutter-autoroll authored Sep 22, 2023

https://github.com/flutter/engine/compare/2fa8dec336d0...b642e4f4dffa

2023-09-22 skia-flutter-autoroll@skia.org Roll Skia from 8752f3ac6e99 to d0f04adbec5c (1 revision) (flutter/engine#46191)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

99192f83

Roll Flutter Engine from 3d54e44d0654 to 2fa8dec336d0 (1 revision) (#135289) · 723ba03a

engine-flutter-autoroll authored Sep 22, 2023

https://github.com/flutter/engine/compare/3d54e44d0654...2fa8dec336d0

2023-09-22 skia-flutter-autoroll@skia.org Roll Skia from 8d9e2cd32ec7 to 8752f3ac6e99 (1 revision) (flutter/engine#46186)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

723ba03a

Roll Flutter Engine from 3a2346ade2f2 to 3d54e44d0654 (2 revisions) (#135288) · 8de97ca1

engine-flutter-autoroll authored Sep 22, 2023

https://github.com/flutter/engine/compare/3a2346ade2f2...3d54e44d0654

2023-09-22 skia-flutter-autoroll@skia.org Roll Skia from a3480a62e438 to 8d9e2cd32ec7 (1 revision) (flutter/engine#46184)
2023-09-22 skia-flutter-autoroll@skia.org Roll Skia from 3ae3bb0d40df to a3480a62e438 (1 revision) (flutter/engine#46183)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8de97ca1

Added option to disable [NavigationDrawerDestination]s (#132349) · 801a1c93

Matheus Kirchesch authored Sep 22, 2023

This PR adds a new option in the NavigationDrawerDestination api allowing it to be disabled, this is very useful for role based access control, especially in the navigation drawer which is used to lay out all the app destinations

* https://github.com/flutter/flutter/issues/132348

801a1c93

Roll Flutter Engine from f8e909b88f3f to 3a2346ade2f2 (4 revisions) (#135283) · 12d761a8

engine-flutter-autoroll authored Sep 22, 2023

https://github.com/flutter/engine/compare/f8e909b88f3f...3a2346ade2f2

2023-09-22 skia-flutter-autoroll@skia.org Roll Skia from 97ec4dbabd05 to 3ae3bb0d40df (1 revision) (flutter/engine#46182)
2023-09-22 leroux_bruno@yahoo.fr [iOS] Disable spelling corrections when auto correction is disabled (flutter/engine#46144)
2023-09-22 skia-flutter-autoroll@skia.org Roll Skia from 86454ab4f3de to 97ec4dbabd05 (1 revision) (flutter/engine#46181)
2023-09-22 skia-flutter-autoroll@skia.org Roll Dart SDK from 5d33f4c85b82 to 6bde93a6e56f (1 revision) (flutter/engine#46180)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

12d761a8

Remove extra padding if a dropdown menu entry also has a leading icon (#135004) · 09f7d7c5

Qun Cheng authored Sep 22, 2023

Fixes #131350

This PR is to remove the extra padding in `DropdownMenuEntry` if both the text field and the dropdown menu entry have leading icons.

**After** fix:
<img width="300" alt="Screenshot 2023-09-19 at 4 35 24 PM" src="https://github.com/flutter/flutter/assets/36861262/ed7d92a5-3f96-4106-a03e-09258ea3709f">

**Before** fix:
<img width="300" alt="Screenshot 2023-09-19 at 4 37 58 PM" src="https://github.com/flutter/flutter/assets/36861262/fdbfef54-6c93-48fb-bd64-41fa31dde531">

09f7d7c5

Roll Flutter Engine from e0fb071ead2f to f8e909b88f3f (1 revision) (#135281) · f388559b

engine-flutter-autoroll authored Sep 22, 2023

https://github.com/flutter/engine/compare/e0fb071ead2f...f8e909b88f3f

2023-09-22 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from PXDDhlPyd9sgrWWun... to ZyajVWocCHVIuJkzM... (flutter/engine#46179)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from PXDDhlPyd9sg to ZyajVWocCHVI

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f388559b

Reland "Native assets support for Linux" (#135097) · 2def9519

Daco Harkes authored Sep 22, 2023

Reland of #134031. (Reverted in #135069.) Contains the fix for b/301051367 together with cl/567233346.

Support for FFI calls with `@Native external` functions through Native assets on Linux. This enables bundling native code without any build-system boilerplate code.

For more info see:

* https://github.com/flutter/flutter/issues/129757

### Implementation details for Linux.

Mainly follows the design of https://github.com/flutter/flutter/pull/130494.

Some differences are:

* Linux does not support cross compiling or compiling for multiple architectures, so this has not been implemented.
* Linux has no add2app.

The assets copying is done in the install-phase of the CMake build of a flutter app.
CMake requires the native assets folder to exist, so we create it also when the feature is disabled or there are no assets.

### Tests

This PR adds new tests to cover the various use cases.

* packages/flutter_tools/test/general.shard/linux/native_assets_test.dart
  * Unit tests the Linux-specific part of building native assets.

It also extends various existing tests:

* packages/flutter_tools/test/integration.shard/native_assets_test.dart
  * Runs (incl hot reload/hot restart), builds, builds frameworks for Linux and flutter-tester.

2def9519

Size CupertinoTextSelectionToolbar to children (#133386) · 0377e80d
Tomasz Gucio authored Sep 22, 2023

0377e80d

Roll Flutter Engine from e726798410af to e0fb071ead2f (2 revisions) (#135276) · 85e52d43

engine-flutter-autoroll authored Sep 22, 2023

https://github.com/flutter/engine/compare/e726798410af...e0fb071ead2f

2023-09-22 skia-flutter-autoroll@skia.org Roll Dart SDK from eaeca487c944 to 5d33f4c85b82 (1 revision) (flutter/engine#46176)
2023-09-22 skia-flutter-autoroll@skia.org Roll Skia from 5b2dae1a9b54 to 86454ab4f3de (1 revision) (flutter/engine#46175)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

85e52d43

Roll Flutter Engine from 2a33fdc4be48 to e726798410af (1 revision) (#135271) · 68d5c176

engine-flutter-autoroll authored Sep 22, 2023

https://github.com/flutter/engine/compare/2a33fdc4be48...e726798410af

2023-09-22 dnfield@google.com [Impeller] fail if software backend is chosen and Impeller is enabled on iOS (flutter/engine#46124)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

68d5c176

Roll Flutter Engine from 7a9409e12fab to 2a33fdc4be48 (3 revisions) (#135270) · 5163d814

engine-flutter-autoroll authored Sep 22, 2023

https://github.com/flutter/engine/compare/7a9409e12fab...2a33fdc4be48

2023-09-21 skia-flutter-autoroll@skia.org Roll Skia from 611f08987be3 to 5b2dae1a9b54 (2 revisions) (flutter/engine#46168)
2023-09-21 matanlurey@users.noreply.github.com Revert #46131, don't store `vkImage`, reset `vkComandPool` synchronously (flutter/engine#46166)
2023-09-21 skia-flutter-autoroll@skia.org Roll Skia from a0928a46b9c8 to 611f08987be3 (2 revisions) (flutter/engine#46165)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5163d814

Fix memory leak in NestedScrollViewState. (#135248) · 9d42ad84
Kostia Sokolovskyi authored Sep 22, 2023

9d42ad84

Roll Flutter Engine from 78c1ad249b57 to 7a9409e12fab (8 revisions) (#135266) · 5def6f2b

engine-flutter-autoroll authored Sep 22, 2023

https://github.com/flutter/engine/compare/78c1ad249b57...7a9409e12fab

2023-09-21 skia-flutter-autoroll@skia.org Roll Skia from 0cf83a86c56d to a0928a46b9c8 (19 revisions) (flutter/engine#46164)
2023-09-21 john@johnmccutchan.com Re-enable HardwareBuffer backed Platform Views on Android >= 29 (flutter/engine#46071)
2023-09-21 jonahwilliams@google.com [Impeller] Use final cmd buffer to present drawable. (flutter/engine#46023)
2023-09-21 matanlurey@users.noreply.github.com More Clang Tidy --fix[es] to header files (flutter/engine#46151)
2023-09-21 dkwingsmt@users.noreply.github.com Reland: Enforce the rule of calling FlutterView.Render (#45300) (flutter/engine#45555)
2023-09-21 yjbanov@google.com Revert "[web] fix clicks on merged semantic nodes (#43620)" (flutter/engine#46067)
2023-09-21 matanlurey@users.noreply.github.com Move `git_repo_tools` and `process_fakes` outside of `clang_tidy`. (flutter/engine#46017)
2023-09-21 godofredoc@google.com Remove linux fuchsia from recipes cq. (flutter/engine#46153)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5def6f2b

21 Sep, 2023 23 commits

Cover more test/widgets tests with leak tracking #11 (#135231) · ffecedbc
Kostia Sokolovskyi authored Sep 21, 2023

ffecedbc

remove field override, assign to super field instead (#135165) · daea6e00

Jacob MacDonald authored Sep 21, 2023

Removes an ignore about overriding fields. Instead we just assign the value to the original field in the super class.

Related to https://github.com/dart-lang/language/issues/3332 (discovered during investigations into the violation of that lint).

daea6e00

Update alwaysNeedsCompositing in RenderParagraph (#135076) · 528a281a

hangyu authored Sep 21, 2023

fix #111370

According to 

https://github.com/flutter/flutter/blob/5b47fef613e2d74ae44e1e22c2a3495294db180e/packages/flutter/lib/src/rendering/box.dart#L1259
: A [RenderBox] that uses methods on [PaintingContext] that introduce
new
/// layers should override the [alwaysNeedsCompositing] getter and set
it to
/// true.

set [alwaysNeedsCompositing] to true when RenderParagraph introduces
LeaderLayer for selection handles.



## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

528a281a

Fix a TextSpan test (#135187) · 45e4a0e5

LongCatIsLooong authored Sep 21, 2023

`TextSpan.toStringDeep()` returns a string that contains a lengthy diagnostic message instead of the plain string.

45e4a0e5

a few web tweaks for a11y assessment app (#134479) · d0664bcd

Yegor authored Sep 21, 2023

Mostly tweaks for better focus management, namely:

* Use `autofocus` throughout so the a11y focus is transferred to a logical place when overlaid content pops up (screen transitions, dialogs).
* Consolidate "enabled" and "disabled" widgets into the same screen. Otherwise, when only a disabled widget is shown, there's nothing to focus on and the screen reader is lost.

d0664bcd

Send analytics on 'build ios' and 'build ipa' for plist impeller value (#135193) · 30a9f99b

Zachary Anderson authored Sep 21, 2023

This analytics event only records the value of the plist entry on
`build` commands. This will give an idea of the proportion of users who
are disabling Impeller when shipping apps.

30a9f99b

Add `--frontend-server-starter-path` option to `flutter run` and `flutter test` (#135038) · c627dbfb
Derek Xu authored Sep 21, 2023

c627dbfb

Roll Flutter Engine from fa032d52a118 to 78c1ad249b57 (1 revision) (#135238) · da1f801f

engine-flutter-autoroll authored Sep 21, 2023

https://github.com/flutter/engine/compare/fa032d52a118...78c1ad249b57

2023-09-21 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 3DKf4d8UFviYKRI28... to PXDDhlPyd9sgrWWun... (flutter/engine#46148)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 3DKf4d8UFviY to PXDDhlPyd9sg

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

da1f801f

Fix violation of the render rule in Windows Startup Test (#134245) · 203ec67c

Tong Mu authored Sep 21, 2023

This PR fixes yet another case in the windows startup test that violates the render rule, which caused https://github.com/flutter/engine/pull/45300 to be reverted.

Although the `FlutterView.render` call is within `onBeginFrame`, there is an `await` before the call, causing the call to fall out of the synchronous scope.

I've added this problem to the documentation of `FlutterView.render` in https://github.com/flutter/engine/pull/45555.

203ec67c

Add a parameter to configure InputDecorator hint fade animations duration (#135211) · de44daf1

Bruno Leroux authored Sep 21, 2023

## Description

This PR adds a parameter to configure the input decorator hint fade transition duration.

This animation is not part of the Material specification.
Removing it was considered but it breaks internal tests (see https://github.com/flutter/flutter/pull/107406).
I also considered several ways to avoid the fade animation (setting duration to 0, removing the hint text, etc) but it breaks many existing tests that assumes the hint text to be visible.

To mitigate the issue in a non disruptive way, I set the default duration to 20ms (an arbitrary short value).

## Related Issue

Fixes https://github.com/flutter/flutter/issues/20283.

## Tests

Adds 3 tests, updates 3 tests.

de44daf1

Add RestorationManager disposals in test/services/restoration_test.dart. (#135218) · 4204f07d
Kostia Sokolovskyi authored Sep 21, 2023

4204f07d
Handle breaking changes in leak_tracker. (#135185) · 77718845
Polina Cherkasova authored Sep 21, 2023

77718845

Roll Flutter Engine from 6c1e58c86e8c to fa032d52a118 (1 revision) (#135227) · 5708b76e

engine-flutter-autoroll authored Sep 21, 2023

https://github.com/flutter/engine/compare/6c1e58c86e8c...fa032d52a118

2023-09-21 skia-flutter-autoroll@skia.org Roll Skia from 322abacca561 to 0cf83a86c56d (1 revision) (flutter/engine#46143)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5708b76e

Roll Packages from 51e74b97508a to d0411e450a8d (1 revision) (#135224) · 8f04f0c2

engine-flutter-autoroll authored Sep 21, 2023

https://github.com/flutter/packages/compare/51e74b97508a...d0411e450a8d

2023-09-20 stuartmorgan@google.com [various] Update invalid NSURL tests (flutter/packages#4959)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8f04f0c2

Roll Flutter Engine from 584861202198 to 6c1e58c86e8c (1 revision) (#135216) · 22748e3a

engine-flutter-autoroll authored Sep 21, 2023

https://github.com/flutter/engine/compare/584861202198...6c1e58c86e8c

2023-09-21 sigurdm@google.com Add package:tar to DEPS (flutter/engine#46140)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

22748e3a

Cover some cupertino tests with leak tracing (#135149) · beeb3ce9
derdilla authored Sep 21, 2023

beeb3ce9

Roll Flutter Engine from a4b1ef79596a to 584861202198 (2 revisions) (#135214) · 687f9c86

engine-flutter-autoroll authored Sep 21, 2023

https://github.com/flutter/engine/compare/a4b1ef79596a...584861202198

2023-09-21 skia-flutter-autoroll@skia.org Roll Dart SDK from d5d05146868a to eaeca487c944 (2 revisions) (flutter/engine#46138)
2023-09-21 skia-flutter-autoroll@skia.org Roll Skia from c20aeee90da9 to 322abacca561 (1 revision) (flutter/engine#46137)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

687f9c86

Roll Flutter Engine from 3e66ffa6aae6 to a4b1ef79596a (1 revision) (#135206) · 089e93a1

engine-flutter-autoroll authored Sep 21, 2023

https://github.com/flutter/engine/compare/3e66ffa6aae6...a4b1ef79596a

2023-09-21 skia-flutter-autoroll@skia.org Roll Skia from 81b9c7fd19b2 to c20aeee90da9 (3 revisions) (flutter/engine#46134)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

089e93a1

Form fields onChange callback should be called on reset (#134295) · 07cc3f7a

Bruno Leroux authored Sep 21, 2023

## Description

This PR fixes form fields in order to call the `onChange` callback when the form is reset.

This change is based on the work done in https://github.com/flutter/flutter/pull/123108.

I considered adding the `onChange` callback to the `FormField` superclass but it would break existing code because two of the three subclasses defines the `onChange` callback with `ValueChanged<String>?` type and the third one defines it with `ValueChanged<String?>?`. 

## Related Issue

Fixes https://github.com/flutter/flutter/issues/123009.

## Tests

Adds 3 tests.

07cc3f7a

Roll Flutter Engine from 88aad1056781 to 3e66ffa6aae6 (2 revisions) (#135200) · 518b7751

engine-flutter-autoroll authored Sep 21, 2023

https://github.com/flutter/engine/compare/88aad1056781...3e66ffa6aae6

2023-09-21 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from zuOP7YCHHocXuZJcD... to 3DKf4d8UFviYKRI28... (flutter/engine#46133)
2023-09-21 jonahwilliams@google.com [Impeller] temp work around for cmd pool validation issues. (flutter/engine#46131)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from zuOP7YCHHocX to 3DKf4d8UFviY

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

518b7751

Roll Flutter Engine from 76e5e35ab395 to 88aad1056781 (1 revision) (#135198) · b90a13f3

engine-flutter-autoroll authored Sep 21, 2023

https://github.com/flutter/engine/compare/76e5e35ab395...88aad1056781

2023-09-21 skia-flutter-autoroll@skia.org Roll Skia from a7bcbb9a39f3 to 81b9c7fd19b2 (1 revision) (flutter/engine#46129)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b90a13f3

Roll Flutter Engine from 89d864552acd to 76e5e35ab395 (21 revisions) (#135192) · c416aa47

engine-flutter-autoroll authored Sep 21, 2023

https://github.com/flutter/engine/compare/89d864552acd...76e5e35ab395

2023-09-21 matanlurey@users.noreply.github.com Tidy up `DlPaint` and friends. (flutter/engine#46120)
2023-09-21 skia-flutter-autoroll@skia.org Roll Skia from 86f48da2c812 to a7bcbb9a39f3 (1 revision) (flutter/engine#46128)
2023-09-21 30870216+gaaclarke@users.noreply.github.com [Impeller] removed global mutable variable for tessellation allocation function pointers (flutter/engine#46127)
2023-09-20 jonahwilliams@google.com [Impeller] Remove removal of save layer from clip. (flutter/engine#46113)
2023-09-20 jason-simmons@users.noreply.github.com [Impeller] Apply the entity transformation when rendering FramebufferBlendContents (flutter/engine#46106)
2023-09-20 matanlurey@users.noreply.github.com Clang tidy-ify `DlColor` and friends. (flutter/engine#46122)
2023-09-20 godofredoc@google.com Apply the right tag for linux fuchsia cipd packages. (flutter/engine#46123)
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from b78c91996051 to 86f48da2c812 (4 revisions) (flutter/engine#46121)
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from d923bab3d5fa to b78c91996051 (4 revisions) (flutter/engine#46119)
2023-09-20 matanlurey@users.noreply.github.com Make `dl_color_(filter|source)` tidy. (flutter/engine#46111)
2023-09-20 matanlurey@users.noreply.github.com Make `dl_(image|mask|path)_(filter|effect).h` tidy! (flutter/engine#46110)
2023-09-20 matanlurey@users.noreply.github.com Migrate from `LOG_X` to `kLogX`. (flutter/engine#46107)
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from b3c1f49821d8 to d923bab3d5fa (2 revisions) (flutter/engine#46118)
2023-09-20 matanlurey@users.noreply.github.com Make a variety of low-impact Clang tidy fixes in Impeller. (flutter/engine#46116)
2023-09-20 ychris@google.com [ios] fix asset url not found when loading app extension (flutter/engine#46073)
2023-09-20 matanlurey@users.noreply.github.com Make a variety of low-impact Clang tidy fixes. (flutter/engine#46114)
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from c19115e8f712 to b3c1f49821d8 (3 revisions) (flutter/engine#46112)
2023-09-20 skia-flutter-autoroll@skia.org Roll Skia from f4238844089f to c19115e8f712 (5 revisions) (flutter/engine#46108)
2023-09-20 mdebbar@google.com [web] Move context menu handling to its own class (flutter/engine#46042)
2023-09-20 matanlurey@users.noreply.github.com Delete `ci/lint.sh`, which is no longer used. (flutter/engine#46049)
2023-09-20 mdebbar@google.com [web] Make `PlatformViewManager` a clear singleton (flutter/engine#46044)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c416aa47

Rename `debugProfilePlatformChannels` to a constant that works in release mode (#134922) · f92884c7

Jia Hao authored Sep 21, 2023

When it comes to startup profiling, it is very helpful to look at platform channels. `debugProfilePlatformChannels` today only works in debug and profile mode. Unfortunately, using profile mode is less accurate for startup profiling, because of the service isolate introducing additional overhead.

This PR allows this toggle to work in release mode. Note that there are two parts to `debugProfilePlatformChannels`:

- Adding timeline events
- Logging statistics about platform channels

I also considered adding a separate toggle to limit the scope of this change to the former, but that seems like complexity that we might not need at this time.

Towards #102189

f92884c7

20 Sep, 2023 1 commit
- Mark ReastaurationManager not disposed (#134832) · a0406ccc
  derdilla authored Sep 20, 2023
  
  a0406ccc