Commits · efdfd96c4aaf8b14174d81f14a835656da412443 · abdullh.alsoleman / Front-End

15 Aug, 2023 13 commits

Roll Packages from 08080abd9cbb to 84218b9d834c (1 revision) (#132572) · efdfd96c

engine-flutter-autoroll authored Aug 15, 2023

https://github.com/flutter/packages/compare/08080abd9cbb...84218b9d834c

2023-08-14 stuartmorgan@google.com [file_selector] Fix default accept types on iOS (flutter/packages#4691)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

efdfd96c

Roll Flutter Engine from 2c90670171a7 to 0760b5589c71 (1 revision) (#132570) · 30f228d8

engine-flutter-autoroll authored Aug 15, 2023

https://github.com/flutter/engine/compare/2c90670171a7...0760b5589c71

2023-08-15 matej.knopp@gmail.com Reset editing delta state when replacing editing state (flutter/engine#44595)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

30f228d8

Update `flutter_tools` internals related to Gradle/XCode to set `--local-engine-host`. (#132346) · 65798445

Matan Lurey authored Aug 15, 2023

Partial work towards https://github.com/flutter/flutter/issues/132245.

I made a minor refactor to test-only code because it was too confusing
to have 2 optional parameters that are technically required together,
but otherwise all other changes *should* be pass throughs. That being
said, I can't say I totally understand the Gradle stuff so I could use a
hand double checking that.

65798445

Roll Flutter Engine from 6bd7b717e110 to 2c90670171a7 (2 revisions) (#132566) · 9526142c

engine-flutter-autoroll authored Aug 15, 2023

https://github.com/flutter/engine/compare/6bd7b717e110...2c90670171a7

2023-08-15 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from uIGMbDkXoIcpqWjgR... to 7iuIq3PsSkuCmuEMr... (flutter/engine#44721)
2023-08-15 skia-flutter-autoroll@skia.org Roll Dart SDK from d1c68769eba0 to 19c87486f0a9 (1 revision) (flutter/engine#44719)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from uIGMbDkXoIcp to 7iuIq3PsSkuC

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9526142c

Roll Flutter Engine from 9091107e594d to 6bd7b717e110 (1 revision) (#132561) · c7fb2803

engine-flutter-autoroll authored Aug 15, 2023

https://github.com/flutter/engine/compare/9091107e594d...6bd7b717e110

2023-08-15 skia-flutter-autoroll@skia.org Roll Dart SDK from d240bef060ed to d1c68769eba0 (1 revision) (flutter/engine#44715)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c7fb2803

Roll Flutter Engine from a17130ac4d49 to 9091107e594d (2 revisions) (#132553) · 69b0c034

engine-flutter-autoroll authored Aug 15, 2023

https://github.com/flutter/engine/compare/a17130ac4d49...9091107e594d

2023-08-15 skia-flutter-autoroll@skia.org Roll Skia from e137aad081a3 to 4beb6fd05f4f (3 revisions) (flutter/engine#44713)
2023-08-15 jiahaog@users.noreply.github.com Namespace imports with flutter (flutter/engine#44709)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

69b0c034

Roll Flutter Engine from 6975ee1b6de7 to a17130ac4d49 (5 revisions) (#132550) · b4842cfa

engine-flutter-autoroll authored Aug 15, 2023

https://github.com/flutter/engine/compare/6975ee1b6de7...a17130ac4d49

2023-08-15 skia-flutter-autoroll@skia.org Roll Skia from d8d880c560f8 to e137aad081a3 (1 revision) (flutter/engine#44712)
2023-08-15 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from AvjxPvh-niiyQpYoD... to -16K9GvYE3a4Bqs0G... (flutter/engine#44710)
2023-08-15 brianosman@google.com Stop using deprecated GrBackendRenderTarget constructor (flutter/engine#44694)
2023-08-15 skia-flutter-autoroll@skia.org Roll Skia from 022415d74e73 to d8d880c560f8 (1 revision) (flutter/engine#44708)
2023-08-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 8731e9796eb3 to d240bef060ed (1 revision) (flutter/engine#44707)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from AvjxPvh-niiy to -16K9GvYE3a4

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b4842cfa

Roll Flutter Engine from 21aed05ad751 to 6975ee1b6de7 (1 revision) (#132543) · 25318599

engine-flutter-autoroll authored Aug 15, 2023

https://github.com/flutter/engine/compare/21aed05ad751...6975ee1b6de7

2023-08-15 skia-flutter-autoroll@skia.org Roll Skia from f636188df4e2 to 022415d74e73 (2 revisions) (flutter/engine#44706)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

25318599

Manual roll of docker focal version. (#132536) · 29924c7c

godofredoc authored Aug 15, 2023

This manual roll is needed to update the jdk apt package.

Bug: https://github.com/flutter/flutter/issues/132531

29924c7c

Roll Flutter Engine from f1f912c0c7c7 to 21aed05ad751 (1 revision) (#132540) · 2f54ff6c

engine-flutter-autoroll authored Aug 15, 2023

https://github.com/flutter/engine/compare/f1f912c0c7c7...21aed05ad751

2023-08-14 10456171+caroqliu@users.noreply.github.com [fuchsia] Delete obsolete GFX-specific source files (flutter/engine#44594)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2f54ff6c

PaginatedDataTable improvements (#131374) · ccdf8264

Ian Hickson authored Aug 15, 2023

- slightly improved assert message when row cell counts don't match column count.
- more breadcrumbs in API documentation. more documentation in general.
- added more documentation for the direction of the "ascending" arrow.
- two samples for PaginatedDataTable.
- make PaginatedDataTable support hot reloading across changes to the number of columns.
- introduce matrix3MoreOrLessEquals. An earlier version of this PR used it in tests, but eventually it was not needed. The function seems useful to keep though.

ccdf8264

Roll Flutter Engine from 1d63eece6c37 to f1f912c0c7c7 (2 revisions) (#132538) · 668a0022

engine-flutter-autoroll authored Aug 15, 2023

https://github.com/flutter/engine/compare/1d63eece6c37...f1f912c0c7c7

2023-08-14 skia-flutter-autoroll@skia.org Roll Skia from 58397bfd9ab6 to f636188df4e2 (1 revision) (flutter/engine#44700)
2023-08-14 skia-flutter-autoroll@skia.org Roll Dart SDK from d445f5a18876 to 8731e9796eb3 (1 revision) (flutter/engine#44699)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

668a0022

[devicelab] fix name of flutter driver benchmark. (#132527) · 51a0ec00
Jonah Williams authored Aug 15, 2023
```
Missing the _test.dart
```
51a0ec00

14 Aug, 2023 23 commits

Roll Flutter Engine from 3c8852827646 to 1d63eece6c37 (1 revision) (#132534) · ef528f89

engine-flutter-autoroll authored Aug 14, 2023

https://github.com/flutter/engine/compare/3c8852827646...1d63eece6c37

2023-08-14 zanderso@users.noreply.github.com Update android_embedding_bundle CIPD instructions (flutter/engine#44644)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ef528f89

Updates `AutomatedTestWidgetsFlutterBinding.pump` to support microsecond precision (#132401) · e1ec3581

pdblasi-google authored Aug 14, 2023

* Updated `AutomatedTestWidgetsFlutterBinding.pump` to use microseconds instead of milliseconds
* Added a test to prevent regression of the microsecond precision
* Fixed a test that incorrectly assumed millisecond precision

Closes #112610

e1ec3581

Roll Flutter Engine from 785b24900a36 to 3c8852827646 (2 revisions) (#132530) · 36df9560

engine-flutter-autoroll authored Aug 14, 2023

https://github.com/flutter/engine/compare/785b24900a36...3c8852827646

2023-08-14 skia-flutter-autoroll@skia.org Roll Skia from 69ea58157190 to 58397bfd9ab6 (8 revisions) (flutter/engine#44698)
2023-08-14 matanlurey@users.noreply.github.com Update `web_ui/**` to explicitly pass `--local-engine-host` to the `flutter` tool. (flutter/engine#44613)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

36df9560

Bump github/codeql-action from 2.21.3 to 2.21.4 (#132525) · 99dd6b49

dependabot[bot] authored Aug 14, 2023

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.21.3 to 2.21.4.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>2.21.4 - 14 Aug 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.14.2. <a href="https://redirect.github.com/github/codeql-action/pull/1831">#1831</a></li>
<li>Log a warning if the amount of available disk space runs low during a code scanning run. <a href="https://redirect.github.com/github/codeql-action/pull/1825">#1825</a></li>
<li>When downloading CodeQL bundle version 2.13.4 and later, cache these bundles in the Actions tool cache using a simpler version number. <a href="https://redirect.github.com/github/codeql-action/pull/1832">#1832</a></li>
<li>Fix an issue that first appeared in CodeQL Action v2.21.2 that prevented CodeQL invocations from being logged. <a href="https://redirect.github.com/github/codeql-action/pull/1833">#1833</a></li>
<li>We are rolling out a feature in August 2023 that will improve the quality of file coverage information. <a href="https://redirect.github.com/github/codeql-action/pull/1835">#1835</a></li>
</ul>
<h2>2.21.3 - 08 Aug 2023</h2>
<ul>
<li>We are rolling out a feature in August 2023 that will improve multi-threaded performance on larger runners. <a href="https://redirect.github.com/github/codeql-action/pull/1817">#1817</a></li>
<li>We are rolling out a feature in August 2023 that adds beta support for <a href="https://projectlombok.org/">Project Lombok</a> when analyzing Java. <a href="https://redirect.github.com/github/codeql-action/pull/1809">#1809</a></li>
<li>Reduce disk space usage when downloading the CodeQL bundle. <a href="https://redirect.github.com/github/codeql-action/pull/1820">#1820</a></li>
</ul>
<h2>2.21.2 - 28 Jul 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.14.1. <a href="https://redirect.github.com/github/codeql-action/pull/1797">#1797</a></li>
<li>Avoid duplicating the analysis summary within the logs. <a href="https://redirect.github.com/github/codeql-action/pull/1811">#1811</a></li>
</ul>
<h2>2.21.1 - 26 Jul 2023</h2>
<ul>
<li>Improve the handling of fatal errors from the CodeQL CLI. <a href="https://redirect.github.com/github/codeql-action/pull/1795">#1795</a></li>
<li>Add the <code>sarif-output</code> output to the analyze action that contains the path to the directory of the generated SARIF. <a href="https://redirect.github.com/github/codeql-action/pull/1799">#1799</a></li>
</ul>
<h2>2.21.0 - 19 Jul 2023</h2>
<ul>
<li>CodeQL Action now requires CodeQL CLI 2.9.4 or later. For more information, see the corresponding changelog entry for CodeQL Action version 2.20.4. <a href="https://redirect.github.com/github/codeql-action/pull/1724">#1724</a></li>
</ul>
<h2>2.20.4 - 14 Jul 2023</h2>
<ul>
<li>This is the last release of the Action that supports CodeQL CLI versions 2.8.5 to 2.9.3. These versions of the CodeQL CLI were deprecated on June 20, 2023 alongside GitHub Enterprise Server 3.5 and will not be supported by the next release of the CodeQL Action (2.21.0).
<ul>
<li>If you are using one of these versions, please update to CodeQL CLI version 2.9.4 or later. For instance, if you have specified a custom version of the CLI using the 'tools' input to the 'init' Action, you can remove this input to use the default version.</li>
<li>Alternatively, if you want to continue using a version of the CodeQL CLI between 2.8.5 and 2.9.3, you can replace 'github/codeql-action/<em><a href="https://github.com/v2"><code>@âv2</code></a>' by 'github/codeql-action/</em><a href="https://github.com/v2"><code>@âv2</code></a>.20.4' in your code scanning workflow to ensure you continue using this version of the CodeQL Action.</li>
</ul>
</li>
<li>We are rolling out a feature in July 2023 that will slightly reduce the default amount of RAM used for query execution, in proportion to the runner's total memory. This will help to avoid out-of-memory failures on larger runners. <a href="https://redirect.github.com/github/codeql-action/pull/1760">#1760</a></li>
<li>Update default CodeQL bundle version to 2.14.0. <a href="https://redirect.github.com/github/codeql-action/pull/1762">#1762</a></li>
</ul>
<h2>2.20.3 - 06 Jul 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.13.5. <a href="https://redirect.github.com/github/codeql-action/pull/1743">#1743</a></li>
</ul>
<h2>2.20.2 - 03 Jul 2023</h2>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/a09933a12a80f87b87005513f0abb1494c27a716"><code>a09933a</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1838">#1838</a> from github/update-v2.21.4-492a68c32</li>
<li><a href="https://github.com/github/codeql-action/commit/37116fb629c389e65c52deac5e2c17af5f1a1973"><code>37116fb</code></a> Fix positioning of bundle update changelog note</li>
<li><a href="https://github.com/github/codeql-action/commit/c6139177669233a468dc4ecabe60d530b414e662"><code>c613917</code></a> Update changelog for v2.21.4</li>
<li><a href="https://github.com/github/codeql-action/commit/492a68c323360189d2f9df28532982923c71d897"><code>492a68c</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1836">#1836</a> from github/henrymercer/analysis-summary-v2-ff</li>
<li><a href="https://github.com/github/codeql-action/commit/ac49314877db8e2011c40d31eca69b48438441bf"><code>ac49314</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1834">#1834</a> from github/henrymercer/analysis-summary-v2-ff</li>
<li><a href="https://github.com/github/codeql-action/commit/ac35d7a02dee18d8dc39711483f877e5325b0b9a"><code>ac35d7a</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1835">#1835</a> from github/henrymercer/language-baseline-config</li>
<li><a href="https://github.com/github/codeql-action/commit/d03c744ad658dbbbdac1d081c6319c667a334e66"><code>d03c744</code></a> Don't pass <code>--no-</code> flag as it doesn't exist yet</li>
<li><a href="https://github.com/github/codeql-action/commit/a0407a8c60f1f2c6d417d133cda53b32030e4383"><code>a0407a8</code></a> Add changelog note for rollout</li>
<li><a href="https://github.com/github/codeql-action/commit/8a7b2e9c9bde104b1cea8524ef50c449fbaff172"><code>8a7b2e9</code></a> Enable language specific baselines via feature flag</li>
<li><a href="https://github.com/github/codeql-action/commit/9a510d9b078a207699baa4ca847d29d8a9243800"><code>9a510d9</code></a> Rename new analysis summary feature flag</li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/5b6282e01c62d02e720b81eb8a51204f527c3624...a09933a12a80f87b87005513f0abb1494c27a716">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=2.21.3&new-version=2.21.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

99dd6b49

[devicelab] fix NAN/Inf in drawPoints benchmark. (#132526) · a0771895

Jonah Williams authored Aug 14, 2023

This is causing the benchmark to not render with Skia. We probably need to CHECK this somewhere in the backend..

a0771895

Selection area should move selection word by word on a long press drag (#132518) · 9a39a5d6

Renzo Olivares authored Aug 14, 2023

On native iOS and Android when long pressing and then dragging the selection expands word by word. Before this change `SelectionArea` expanded the selection character by character on a long press drag.

Fixes #104603

9a39a5d6

Roll Flutter Engine from 56a0e2715dca to 785b24900a36 (10 revisions) (#132522) · 0a10359f

engine-flutter-autoroll authored Aug 14, 2023

https://github.com/flutter/engine/compare/56a0e2715dca...785b24900a36

2023-08-14 amirpanahandeh@yahoo.com Update CompositionAwareMixin to correctly compute composingBase in Web engine (flutter/engine#44139)
2023-08-14 stuartmorgan@google.com Add application:openURLs: forwarding on macOS (flutter/engine#44689)
2023-08-14 skia-flutter-autoroll@skia.org Roll Skia from a4377099b25a to 69ea58157190 (1 revision) (flutter/engine#44692)
2023-08-14 chillers@google.com Update embedder_semantics_update.h imports to include flutter namespace (flutter/engine#44670)
2023-08-14 skia-flutter-autoroll@skia.org Roll Dart SDK from 3295a353980a to d445f5a18876 (1 revision) (flutter/engine#44691)
2023-08-14 dnfield@google.com Revert "Make run_tests.py assert that the ios test dylib is at least as new as libFlutter.dylib" (flutter/engine#44690)
2023-08-14 skia-flutter-autoroll@skia.org Roll Skia from 1cf6f71c8120 to a4377099b25a (1 revision) (flutter/engine#44688)
2023-08-14 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from JKTVoxVrHjZjBaxG4... to uIGMbDkXoIcpqWjgR... (flutter/engine#44687)
2023-08-14 jonahwilliams@google.com [Impeller] Conditionally set command debug info. (flutter/engine#44274)
2023-08-14 kjlubick@users.noreply.github.com Migrate more GL calls of GrBackend* (flutter/engine#44682)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from JKTVoxVrHjZj to uIGMbDkXoIcp

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0a10359f

[flutter_tools] hide Skia specific rendering options. (#132509) · 5de43e20

Jonah Williams authored Aug 14, 2023

At some point in the near future, we'll start an Impeller on Android preivew - and later make it the default. Unlike Skia, Impeller does not have a fallback software rendering mode. We'd like to stop suggesting this as an option now, and in the future remove the option to force software rendering.

Once impeller is the default, asking for software rendering on Android will result in either an error or falling back to Skia.

5de43e20

Update menu examples for `SafeArea` (#132390) · 5c96642f

Taha Tesser authored Aug 14, 2023

fixes [Some of the menu examples don't contain `SafeArea`](https://github.com/flutter/flutter/issues/132388)

### Description

This fixes the menu examples for running on mobile with a safe area.

![Group 2](https://github.com/flutter/flutter/assets/48603081/0d460c00-60f5-45e0-87ee-c010ede9ee42)

5c96642f

Update `dev/bots/test.dart` (and friends) to provide `--local-engine-host`. (#132354) · 491ba230

Matan Lurey authored Aug 14, 2023

Partial work towards https://github.com/flutter/flutter/issues/132245.

As far as I can tell, this just plumbs flags downwards and has no
semantic changes.

491ba230

Roll Flutter Engine from 46c11916f8d2 to 56a0e2715dca (2 revisions) (#132508) · 5b0c7ea2

engine-flutter-autoroll authored Aug 14, 2023

https://github.com/flutter/engine/compare/46c11916f8d2...56a0e2715dca

2023-08-14 skia-flutter-autoroll@skia.org Roll Skia from a690bd1fb8b8 to 1cf6f71c8120 (1 revision) (flutter/engine#44685)
2023-08-14 jmccandless@google.com hasStrings for web (flutter/engine#43360)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5b0c7ea2

[devicelab] boot up benchmarks. (#132148) · f7bd0320

Jonah Williams authored Aug 14, 2023

Enable Impeller benchmarks for drawAtlas/drawVertices on iOS/Metal, Android/GLES, and Android/Vulkan.

Enable impeller tessellation benchmarks on iOS/Metal and Android/Vulkan - not GLES as this is measuring backend agnostic performance.

f7bd0320

Roll Packages from 9b15c2e6ab30 to 08080abd9cbb (5 revisions) (#132505) · 6d87a23b

engine-flutter-autoroll authored Aug 14, 2023

https://github.com/flutter/packages/compare/9b15c2e6ab30...08080abd9cbb

2023-08-12 66741910+mishapark@users.noreply.github.com [google_maps_flutter] removed old overrides (flutter/packages#4679)
2023-08-11 katelovett@google.com [dynamic_layouts] Refactor flaky test (flutter/packages#4681)
2023-08-11 stuartmorgan@google.com [shared_preferences] Update iOS/macOS Pigeon (flutter/packages#4668)
2023-08-11 tarrinneal@gmail.com [pigeon] skipGen (flutter/packages#4682)
2023-08-11 engine-flutter-autoroll@skia.org Roll Flutter from 685141bf to 9b6945b4 (25 revisions) (flutter/packages#4680)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6d87a23b

Roll Flutter Engine from c125e1e23d4b to 46c11916f8d2 (1 revision) (#132502) · 7f12bbc6

engine-flutter-autoroll authored Aug 14, 2023

https://github.com/flutter/engine/compare/c125e1e23d4b...46c11916f8d2

2023-08-14 skia-flutter-autoroll@skia.org Roll Skia from 8b051126be8a to a690bd1fb8b8 (1 revision) (flutter/engine#44684)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7f12bbc6

Fix log filtering and CI tests for iOS 17 physical devices (#132491) · ec0b7443

Victoria Ashworth authored Aug 14, 2023

Fixes a couple of issues introduced in new iOS 17 physical device tooling: https://github.com/flutter/flutter/pull/131865.

1) Duplicate messages were being filtered out too aggressively.

For example, if on the counter app, you printed "Increment!" on button click, it would only print once no matter how many times you clicked.

Sometimes more than one log source is used at a time and the original intention was to filter duplicates between two log sources, so it wouldn't print the same message from both logs. However, it would also filter when the same message was added more than once via the same log.

The new solution distinguishes a "primary" and a "fallback" log source and prefers to use the primary source unless it's not working, in which it'll use the fallback. If the fallback is faster than the primary, the primary will exclude the logs received by the fallback in a 1-to-1 fashion to prevent too-aggressive filtering. Once a flutter-message has been received by the primary source, fallback messages will be ignored.

Note: iOS < 17 did not regress.

2) There was a race condition between the shutdown hooks and exiting XcodeDebug that was causing a crash when deleting a file that doesn't exist. This only affects CI - for the new integration tests and when testing with iOS 17 physical devices.

ec0b7443

Roll Flutter Engine from 4e8b2b61f648 to c125e1e23d4b (1 revision) (#132496) · 8b8f262d

engine-flutter-autoroll authored Aug 14, 2023

https://github.com/flutter/engine/compare/4e8b2b61f648...c125e1e23d4b

2023-08-14 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from yr5wa34bzOBfEgzDH... to AvjxPvh-niiyQpYoD... (flutter/engine#44683)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from yr5wa34bzOBf to AvjxPvh-niiy

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8b8f262d

Unpin leak_tracker and handle breaking changes in API. (#132352) · a7b69b06
Polina Cherkasova authored Aug 14, 2023

a7b69b06

Roll Flutter Engine from 62a392f29aa5 to 4e8b2b61f648 (2 revisions) (#132490) · 87de2c5e

engine-flutter-autoroll authored Aug 14, 2023

https://github.com/flutter/engine/compare/62a392f29aa5...4e8b2b61f648

2023-08-14 skia-flutter-autoroll@skia.org Roll Dart SDK from 452c6617ee36 to 3295a353980a (1 revision) (flutter/engine#44681)
2023-08-14 skia-flutter-autoroll@skia.org Roll Skia from a4aa96331dd5 to 8b051126be8a (2 revisions) (flutter/engine#44680)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

87de2c5e

Roll Flutter Engine from f50ad637de75 to 62a392f29aa5 (1 revision) (#132487) · 8b132c0f

engine-flutter-autoroll authored Aug 14, 2023

https://github.com/flutter/engine/compare/f50ad637de75...62a392f29aa5

2023-08-14 skia-flutter-autoroll@skia.org Roll Skia from f3b22eaf86bd to a4aa96331dd5 (1 revision) (flutter/engine#44678)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8b132c0f

Roll Flutter Engine from 9cebd2015688 to f50ad637de75 (3 revisions) (#132480) · 9c214034

engine-flutter-autoroll authored Aug 14, 2023

https://github.com/flutter/engine/compare/9cebd2015688...f50ad637de75

2023-08-14 skia-flutter-autoroll@skia.org Roll Skia from efb8daa0503b to f3b22eaf86bd (1 revision) (flutter/engine#44677)
2023-08-14 skia-flutter-autoroll@skia.org Roll Skia from afec82ee6a10 to efb8daa0503b (1 revision) (flutter/engine#44676)
2023-08-14 skia-flutter-autoroll@skia.org Roll Dart SDK from 55d7c1b35902 to 452c6617ee36 (1 revision) (flutter/engine#44675)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9c214034

Roll Flutter Engine from bcaaa0e125fe to 9cebd2015688 (2 revisions) (#132477) · de84eec6

engine-flutter-autoroll authored Aug 14, 2023

https://github.com/flutter/engine/compare/bcaaa0e125fe...9cebd2015688

2023-08-14 skia-flutter-autoroll@skia.org Roll Skia from a8715028bba1 to afec82ee6a10 (1 revision) (flutter/engine#44674)
2023-08-14 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from yfMzjtavZwtK0QM4C... to JKTVoxVrHjZjBaxG4... (flutter/engine#44673)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from yfMzjtavZwtK to JKTVoxVrHjZj

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

de84eec6

Roll Flutter Engine from 7915c049a1fd to bcaaa0e125fe (1 revision) (#132473) · 427bfc66

engine-flutter-autoroll authored Aug 14, 2023

https://github.com/flutter/engine/compare/7915c049a1fd...bcaaa0e125fe

2023-08-14 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from UN2vSCJekPhDnlCRd... to yr5wa34bzOBfEgzDH... (flutter/engine#44672)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from UN2vSCJekPhD to yr5wa34bzOBf

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

427bfc66

Roll Flutter Engine from f47e864f2dcb to 7915c049a1fd (1 revision) (#132466) · d4c5e90e

engine-flutter-autoroll authored Aug 14, 2023

https://github.com/flutter/engine/compare/f47e864f2dcb...7915c049a1fd

2023-08-14 skia-flutter-autoroll@skia.org Roll Skia from 9bb236d03e63 to a8715028bba1 (1 revision) (flutter/engine#44671)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d4c5e90e

13 Aug, 2023 4 commits

Revert "Fix `PopupMenuItem` & `CheckedPopupMenuItem` has redundant `ListTile`... · 7ce2d83b

Casey Hillers authored Aug 13, 2023

Revert "Fix `PopupMenuItem` & `CheckedPopupMenuItem` has redundant `ListTile` padding and update default horizontal padding for Material 3" (#132457)

Reverts flutter/flutter#131609

b/295497265 - This broke Google Testing. We'll need the internal patch
before landing as there's a large number of customer codebases impacted.

7ce2d83b

Roll Flutter Engine from 7c9d71a464c4 to f47e864f2dcb (1 revision) (#132459) · 6b3eefc2

engine-flutter-autoroll authored Aug 13, 2023

https://github.com/flutter/engine/compare/7c9d71a464c4...f47e864f2dcb

2023-08-13 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from vHvU_OjTM5PQkRx1Y... to yfMzjtavZwtK0QM4C... (flutter/engine#44669)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from vHvU_OjTM5PQ to yfMzjtavZwtK

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6b3eefc2

Roll Flutter Engine from 6e0804f8aff3 to 7c9d71a464c4 (2 revisions) (#132458) · e6797126

engine-flutter-autoroll authored Aug 13, 2023

https://github.com/flutter/engine/compare/6e0804f8aff3...7c9d71a464c4

2023-08-13 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from tfgOFdhH6PlJyMv3V... to UN2vSCJekPhDnlCRd... (flutter/engine#44668)
2023-08-13 skia-flutter-autoroll@skia.org Roll Skia from 52eef2a16dfe to 9bb236d03e63 (1 revision) (flutter/engine#44667)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from tfgOFdhH6PlJ to UN2vSCJekPhD

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e6797126

Roll Flutter Engine from 86a1e6582c71 to 6e0804f8aff3 (1 revision) (#132447) · 28400daf

engine-flutter-autoroll authored Aug 13, 2023

https://github.com/flutter/engine/compare/86a1e6582c71...6e0804f8aff3

2023-08-13 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 1-uqfjivXAYe2ue-4... to tfgOFdhH6PlJyMv3V... (flutter/engine#44665)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 1-uqfjivXAYe to tfgOFdhH6PlJ

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

28400daf