Commits · ed2c7eda89937e926ff734f46bb1fc2aff9e43a3 · abdullh.alsoleman / Front-End

18 Mar, 2024 19 commits

Bump github/codeql-action from 3.24.7 to 3.24.8 (#145358) · ed2c7eda

dependabot[bot] authored Mar 18, 2024

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.24.7 to 3.24.8.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<p>Note that the only difference between <code>v2</code> and <code>v3</code> of the CodeQL Action is the node version they support, with <code>v3</code> running on node 20 while we continue to release <code>v2</code> to support running on node 16. For example <code>3.22.11</code> was the first <code>v3</code> release and is functionally identical to <code>2.22.11</code>. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>3.24.8 - 18 Mar 2024</h2>
<ul>
<li>Improve the ease of debugging extraction issues by increasing the verbosity of the extractor logs when running in debug mode. <a href="https://redirect.github.com/github/codeql-action/pull/2195">#2195</a></li>
</ul>
<h2>3.24.7 - 12 Mar 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.16.4. <a href="https://redirect.github.com/github/codeql-action/pull/2185">#2185</a></li>
</ul>
<h2>3.24.6 - 29 Feb 2024</h2>
<p>No user facing changes.</p>
<h2>3.24.5 - 23 Feb 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.16.3. <a href="https://redirect.github.com/github/codeql-action/pull/2156">#2156</a></li>
</ul>
<h2>3.24.4 - 21 Feb 2024</h2>
<ul>
<li>Fix an issue where an existing, but empty, <code>/sys/fs/cgroup/cpuset.cpus</code> file always resulted in a single-threaded run. <a href="https://redirect.github.com/github/codeql-action/pull/2151">#2151</a></li>
</ul>
<h2>3.24.3 - 15 Feb 2024</h2>
<ul>
<li>Fix an issue where the CodeQL Action would fail to load a configuration specified by the <code>config</code> input to the <code>init</code> Action. <a href="https://redirect.github.com/github/codeql-action/pull/2147">#2147</a></li>
</ul>
<h2>3.24.2 - 15 Feb 2024</h2>
<ul>
<li>Enable improved multi-threaded performance on larger runners for GitHub Enterprise Server users. This feature is already available to GitHub.com users. <a href="https://redirect.github.com/github/codeql-action/pull/2141">#2141</a></li>
</ul>
<h2>3.24.1 - 13 Feb 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.16.2. <a href="https://redirect.github.com/github/codeql-action/pull/2124">#2124</a></li>
<li>The CodeQL action no longer fails if it can't write to the telemetry api endpoint. <a href="https://redirect.github.com/github/codeql-action/pull/2121">#2121</a></li>
</ul>
<h2>3.24.0 - 02 Feb 2024</h2>
<ul>
<li>CodeQL Python analysis will no longer install dependencies on GitHub Enterprise Server, as is already the case for GitHub.com. See <a href="https://github.com/github/codeql-action/blob/main/#3230---08-jan-2024">release notes for 3.23.0</a> for more details. <a href="https://redirect.github.com/github/codeql-action/pull/2106">#2106</a></li>
</ul>
<h2>3.23.2 - 26 Jan 2024</h2>
<ul>
<li>On Linux, the maximum possible value for the <code>--threads</code> option now respects the CPU count as specified in <code>cgroup</code> files to more accurately reflect the number of available cores when running in containers. <a href="https://redirect.github.com/github/codeql-action/pull/2083">#2083</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/05963f47d870e2cb19a537396c1f668a348c7d8f"><code>05963f4</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2200">#2200</a> from github/update-v3.24.8-1ecc2779e</li>
<li><a href="https://github.com/github/codeql-action/commit/2b9b521560767d809d8ee77b5025b01153ffe766"><code>2b9b521</code></a> Update changelog for v3.24.8</li>
<li><a href="https://github.com/github/codeql-action/commit/1ecc2779e9e8a1005dab2bfab0c908371cd4a830"><code>1ecc277</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2198">#2198</a> from github/henrymercer/improve-tracking-autobuild-e...</li>
<li><a href="https://github.com/github/codeql-action/commit/e28ae3a84c136adc8b7e8c73705c6aa4b1cd7b60"><code>e28ae3a</code></a> Add config error for Swift build failures</li>
<li><a href="https://github.com/github/codeql-action/commit/bddfc7c6d5f02cfb909b01104ebb039eab86ed0e"><code>bddfc7c</code></a> Add config error for Gradle build failures</li>
<li><a href="https://github.com/github/codeql-action/commit/3edd1bf725dc2142b5eecac26e3cc7ddab176aa2"><code>3edd1bf</code></a> Truncate autobuild errors to 10 lines</li>
<li><a href="https://github.com/github/codeql-action/commit/88a0b7abb3b047d4c1ef5f2762ce215fb098dc06"><code>88a0b7a</code></a> Mark Maven build failures as configuration errors</li>
<li><a href="https://github.com/github/codeql-action/commit/88b28eb70de0ce90819beb741e488921e89177e1"><code>88b28eb</code></a> Surface autobuild errors from stderr stream</li>
<li><a href="https://github.com/github/codeql-action/commit/f055b5e672ed1ea4fd98a276788e4bcb5a64ad17"><code>f055b5e</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2197">#2197</a> from github/henrymercer/log-job-status</li>
<li><a href="https://github.com/github/codeql-action/commit/0d680ab61c4b566d5870b32c2b4b1e65910864be"><code>0d680ab</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2196">#2196</a> from github/henrymercer/update-packs-input-description</li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/3ab4101902695724f9365a384f86c1074d94e18c...05963f47d870e2cb19a537396c1f668a348c7d8f">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=3.24.7&new-version=3.24.8)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

ed2c7eda

Roll pub packages + update DAP tests (#145349) · 89ef73e0

Danny Tuppeny authored Mar 18, 2024

This manually rolls pub packages and updates some calls to use updated APIs that use `Uri` instead of file paths (since macro-generated sources don't exist as files on disk).

89ef73e0

Fix for issue 140372 (#144947) · 993f554e

sanni prasad authored Mar 18, 2024

*Continuing work from the PR https://github.com/flutter/flutter/pull/140373*

Add the ability to set route settings on PopupMenuButton

Fixes https://github.com/flutter/flutter/issues/140372

Added UTs as requested

993f554e

Introduce methods for computing the baseline location of a RenderBox without... · 98369bdd

LongCatIsLooong authored Mar 18, 2024

Introduce methods for computing the baseline location of a RenderBox without affecting the current layout (#144655)

Extracted from https://github.com/flutter/flutter/pull/138369

Introduces `RenderBox.{compute,get}DryBaseline` for computing the baseline location in `RenderBox.computeDryLayout`.

98369bdd

Roll Flutter Engine from 016206de75bc to 3fde3678a357 (2 revisions) (#145350) · f704560c

engine-flutter-autoroll authored Mar 18, 2024

https://github.com/flutter/engine/compare/016206de75bc...3fde3678a357

2024-03-18 jason-simmons@users.noreply.github.com Write recent logcat output to the LUCI log directory if an Android unit test fails (flutter/engine#51462)
2024-03-18 737941+loic-sharma@users.noreply.github.com [Embedder API] Remove view (flutter/engine#51400)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f704560c

Roll Flutter Engine from 90c4d64d410f to 016206de75bc (2 revisions) (#145345) · f84407ec

engine-flutter-autoroll authored Mar 18, 2024

https://github.com/flutter/engine/compare/90c4d64d410f...016206de75bc

2024-03-18 magder@google.com Support accessibility back gesture to pop route from view controller (flutter/engine#51241)
2024-03-18 yjbanov@google.com [web] remove Tappable from basic set of a11y roles; add it case by case (flutter/engine#51466)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f84407ec

Switch hot_mode_dev_cycle_linux__benchmark to run in postsubmit (#145343) · 71c1aba1

Ricardo Amador authored Mar 18, 2024

Switch hot_mode_dev_cycle_linux__benchmark to run in postsubmit.

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*
Part of https://github.com/flutter/flutter/issues/145242

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

71c1aba1

Roll Flutter Engine from 9162c8309e24 to 90c4d64d410f (1 revision) (#145342) · ca39806d

engine-flutter-autoroll authored Mar 18, 2024

https://github.com/flutter/engine/compare/9162c8309e24...90c4d64d410f

2024-03-18 jonahwilliams@google.com [Impeller] revert vestiges of submit batching. (flutter/engine#51450)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ca39806d

Add --no-dds to Mac_arm64_ios version of hot_mode_dev_cycle_ios__benchmark (#145335) · 7f368f7e
Victoria Ashworth authored Mar 18, 2024
```
Attempting to debug https://github.com/flutter/flutter/issues/142305.
```
7f368f7e

Roll Flutter Engine from 89fb886a162c to 9162c8309e24 (2 revisions) (#145336) · f4ee956d

engine-flutter-autoroll authored Mar 18, 2024

https://github.com/flutter/engine/compare/89fb886a162c...9162c8309e24

2024-03-18 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] only download fuchsia deps when necessary (flutter/engine#51439)
2024-03-18 30870216+gaaclarke@users.noreply.github.com [Impeller] make sure to render TiledTextureContents if the geometry doesn't fit in the texture's bounds. (flutter/engine#51393)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f4ee956d

Roll Flutter Engine from 86de0f75606f to 89fb886a162c (1 revision) (#145327) · e1b00053

engine-flutter-autoroll authored Mar 18, 2024

https://github.com/flutter/engine/compare/86de0f75606f...89fb886a162c

2024-03-18 skia-flutter-autoroll@skia.org Roll Skia from 9b08a3f3881c to 9950dc8ec6fd (1 revision) (flutter/engine#51490)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e1b00053

Roll Packages from 756dcc11180b to a757073ac4ea (3 revisions) (#145325) · f217fc17

engine-flutter-autoroll authored Mar 18, 2024

https://github.com/flutter/packages/compare/756dcc11180b...a757073ac4ea

2024-03-17 engine-flutter-autoroll@skia.org Roll Flutter from 71606af8 to 7c860ddf (21 revisions) (flutter/packages#6345)
2024-03-16 10687576+bparrishMines@users.noreply.github.com [pointer_interceptor_web] Skip broken semantics tests and do a manual roll (flutter/packages#6342)
2024-03-15 41930132+hellohuanlin@users.noreply.github.com [pigeon]Add hellohuanlin to pigeon iOS for code reviews (flutter/packages#6333)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f217fc17

Roll Flutter Engine from f11015e14d24 to 86de0f75606f (1 revision) (#145322) · b346eb34

engine-flutter-autoroll authored Mar 18, 2024

https://github.com/flutter/engine/compare/f11015e14d24...86de0f75606f

2024-03-18 skia-flutter-autoroll@skia.org Roll Dart SDK from d5cf2d3849ca to 47ab7cca8a83 (1 revision) (flutter/engine#51489)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b346eb34

InputDecorator M3 tests migration - Step6 - constraints (#145213) · 50e7f2b8

Bruno Leroux authored Mar 18, 2024

## Description

This PR migrates `InputDecorator.constraints` related tests to M3 and also various regression tests.

It is the fifth step for the M3 test migration for `InputDecorator`.
Step 1: https://github.com/flutter/flutter/pull/142981
Step 2: https://github.com/flutter/flutter/pull/143369
Step 3: https://github.com/flutter/flutter/pull/143520
Step 4: https://github.com/flutter/flutter/pull/144169
Step 5: https://github.com/flutter/flutter/pull/144932

## Related Issue

Related to https://github.com/flutter/flutter/issues/139076

@justinmc A somewhat small PR, I wanted to migrate the small group related to 'InputDecoration.constraints' (starting at line 2801), it adds a test checking min interactive height and two others that shows one way to bypass the standard min interactive height.

50e7f2b8

Update `inherited_theme_test.dart`, `ink_paint_test.dart`,... · 06ed849c

Taha Tesser authored Mar 18, 2024

Update `inherited_theme_test.dart`, `ink_paint_test.dart`, `ink_splash_test.dart`, `opacity_test.dart` for Material 3 (#144013)

Updated unit tests for `Tooltip` to have M2 and M3 versions.

More info in #139076

06ed849c

Roll Flutter Engine from eac9db75f902 to f11015e14d24 (2 revisions) (#145321) · 28fea594

engine-flutter-autoroll authored Mar 18, 2024

https://github.com/flutter/engine/compare/eac9db75f902...f11015e14d24

2024-03-18 skia-flutter-autoroll@skia.org Roll Skia from d32e7eda9307 to 9b08a3f3881c (1 revision) (flutter/engine#51487)
2024-03-18 skia-flutter-autoroll@skia.org Roll Skia from 666607a99603 to d32e7eda9307 (1 revision) (flutter/engine#51485)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

28fea594

Roll Flutter Engine from aebc0021cd18 to eac9db75f902 (1 revision) (#145308) · c6f2b53e

engine-flutter-autoroll authored Mar 18, 2024

https://github.com/flutter/engine/compare/aebc0021cd18...eac9db75f902

2024-03-18 skia-flutter-autoroll@skia.org Roll Skia from 38f06cbd2f37 to 666607a99603 (2 revisions) (flutter/engine#51484)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c6f2b53e

Roll Flutter Engine from 89c775963926 to aebc0021cd18 (1 revision) (#145305) · 03b5ea51

engine-flutter-autoroll authored Mar 18, 2024

https://github.com/flutter/engine/compare/89c775963926...aebc0021cd18

2024-03-18 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Ow67Jf4AHxeapVlCa... to I5fL_9DJQBS1Bydbz... (flutter/engine#51482)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Ow67Jf4AHxea to I5fL_9DJQBS1

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

03b5ea51

Roll Flutter Engine from 5c31faa15ab7 to 89c775963926 (1 revision) (#145303) · dd865ce4

engine-flutter-autoroll authored Mar 18, 2024

https://github.com/flutter/engine/compare/5c31faa15ab7...89c775963926

2024-03-17 ian@hixie.ch Minor markup tweaks in render_frame_capture.md (flutter/engine#51480)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

dd865ce4

17 Mar, 2024 3 commits

Roll Flutter Engine from 4c420dd2dfd9 to 5c31faa15ab7 (2 revisions) (#145294) · 69a3f540

engine-flutter-autoroll authored Mar 17, 2024

https://github.com/flutter/engine/compare/4c420dd2dfd9...5c31faa15ab7

2024-03-17 skia-flutter-autoroll@skia.org Roll Skia from b91914d51880 to 38f06cbd2f37 (1 revision) (flutter/engine#51481)
2024-03-17 zanderso@users.noreply.github.com Pass some missing --disable-dart-dev and --suppress-analytics to dart (flutter/engine#51473)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

69a3f540

Roll Flutter Engine from cfbf11d757d1 to 4c420dd2dfd9 (2 revisions) (#145280) · 7c860ddf

engine-flutter-autoroll authored Mar 17, 2024

https://github.com/flutter/engine/compare/cfbf11d757d1...4c420dd2dfd9

2024-03-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 6eb2bc37b91c to d5cf2d3849ca (1 revision) (flutter/engine#51478)
2024-03-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from nTth7xxzAfENAJjMH... to Ow67Jf4AHxeapVlCa... (flutter/engine#51477)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from nTth7xxzAfEN to Ow67Jf4AHxea

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7c860ddf

Factor out use of "print" in flutter_goldens (#144846) · c7123c96

Ian Hickson authored Mar 17, 2024

This is part 5 of a broken down version of the #140101 refactor.

This PR removes direct use of `print` and replaces it with a callback.

c7123c96

16 Mar, 2024 16 commits

Roll Flutter Engine from dd4050334ff3 to cfbf11d757d1 (1 revision) (#145275) · b24b6b1a

engine-flutter-autoroll authored Mar 16, 2024

https://github.com/flutter/engine/compare/dd4050334ff3...cfbf11d757d1

2024-03-16 skia-flutter-autoroll@skia.org Roll Dart SDK from cf4f757cb51e to 6eb2bc37b91c (1 revision) (flutter/engine#51476)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b24b6b1a

Roll Flutter Engine from 618ee6c8ba34 to dd4050334ff3 (1 revision) (#145270) · ed845c7a

engine-flutter-autoroll authored Mar 16, 2024

https://github.com/flutter/engine/compare/618ee6c8ba34...dd4050334ff3

2024-03-16 skia-flutter-autoroll@skia.org Roll Skia from 70bc8aad2a0a to b91914d51880 (1 revision) (flutter/engine#51472)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ed845c7a

Roll Flutter Engine from e4602aa149d8 to 618ee6c8ba34 (1 revision) (#145266) · 16d07313

engine-flutter-autoroll authored Mar 16, 2024

https://github.com/flutter/engine/compare/e4602aa149d8...618ee6c8ba34

2024-03-16 skia-flutter-autoroll@skia.org Roll Skia from 28701a2820eb to 70bc8aad2a0a (1 revision) (flutter/engine#51470)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

16d07313

Roll Flutter Engine from 91b9cf24d328 to e4602aa149d8 (1 revision) (#145259) · e7baebdc

engine-flutter-autoroll authored Mar 16, 2024

https://github.com/flutter/engine/compare/91b9cf24d328...e4602aa149d8

2024-03-16 skia-flutter-autoroll@skia.org Roll Dart SDK from 934c41c1c18e to cf4f757cb51e (1 revision) (flutter/engine#51469)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e7baebdc

Reverts "Reland #128236 "Improve build output for all platforms" (#143166)" (#145261) · 48c1c231

auto-submit[bot] authored Mar 16, 2024

Reverts: flutter/flutter#143166
Initiated by: guidezpl
Reason for reverting: breaks devicelab windows tests
Original PR Author: guidezpl

Reviewed By: {loic-sharma}

This change reverts the following previous change:
Reland #128236, reverted in https://github.com/flutter/flutter/pull/143125.

This PR contains [one additional commit](https://github.com/flutter/flutter/pull/143166/commits/199baea9a99bc905e72d2b069259498dd8f7defd), fixing the 2 failed tests.

## Original description

Improves the build output:

1. Gives confirmation that the build succeeded, in green
1. Gives the path to the built executable, without a trailing period to make it slightly easier to cmd/ctrl+open
1. Gives the size of the built executable (when the built executable is self contained) 

### `apk`, `appbundle` 

<img width="607" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ecc52abe-cd2e-4116-b22a-8385ae3e980d">

<img width="634" alt="image" src="https://github.com/flutter/flutter/assets/6655696/8af8bd33-c0bd-4215-9a06-9652ee019436">

### `macos`, `ios`, `ipa`
Build executables are self-contained and use a newly introduced `OperatingSystemUtils.getDirectorySize`.

<img width="514" alt="image" src="https://github.com/flutter/flutter/assets/6655696/b5918a69-3959-4417-9205-4f501d185257">

<img width="581" alt="image" src="https://github.com/flutter/flutter/assets/6655696/d72fd420-18cf-4470-9e4b-b6ac10fbcd50">

<img width="616" alt="image" src="https://github.com/flutter/flutter/assets/6655696/5f235ce1-252a-4c13-898f-139f6c7bc698">

### `windows`, `linux`, and `web`
Build executables aren't self-contained, and folder size can sometimes overestimate distribution size, therefore their size isn't mentioned (see discussion below).

<img width="647" alt="image" src="https://github.com/flutter/flutter/assets/6655696/7179e771-1eb7-48f6-b770-975bc073437b">

<img width="658" alt="image" src="https://github.com/flutter/flutter/assets/6655696/a6801cab-7b5a-4975-a406-f4c9fa44d7a2">

<img width="608" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ee7c4125-a273-4a65-95d7-ab441edf8ac5">

### Size reporting
When applicable, the printed size matches the OS reported size.

- macOS
    <img width="391" alt="image" src="https://github.com/flutter/flutter/assets/6655696/881cbfb1-d355-444b-ab44-c1a6343190ce">
- Windows
    <img width="338" alt="image" src="https://github.com/flutter/flutter/assets/6655696/3b806def-3d15-48a9-8a25-df200d6feef7">
- Linux   
    <img width="320" alt="image" src="https://github.com/flutter/flutter/assets/6655696/89a4aa3d-2148-4f3b-b231-f93a057fee2b">

## Related issues
Part of #120127
Fixes https://github.com/flutter/flutter/issues/121401

48c1c231

Reland #128236 "Improve build output for all platforms" (#143166) · 2fc76c78

Pierre-Louis authored Mar 16, 2024

Reland #128236, reverted in https://github.com/flutter/flutter/pull/143125.

This PR contains [one additional commit](https://github.com/flutter/flutter/pull/143166/commits/199baea9a99bc905e72d2b069259498dd8f7defd), fixing the 2 failed tests.

## Original description

Improves the build output:

1. Gives confirmation that the build succeeded, in green
1. Gives the path to the built executable, without a trailing period to make it slightly easier to cmd/ctrl+open
1. Gives the size of the built executable (when the built executable is self contained) 

### `apk`, `appbundle` 

<img width="607" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ecc52abe-cd2e-4116-b22a-8385ae3e980d">

<img width="634" alt="image" src="https://github.com/flutter/flutter/assets/6655696/8af8bd33-c0bd-4215-9a06-9652ee019436">

### `macos`, `ios`, `ipa`
Build executables are self-contained and use a newly introduced `OperatingSystemUtils.getDirectorySize`.

<img width="514" alt="image" src="https://github.com/flutter/flutter/assets/6655696/b5918a69-3959-4417-9205-4f501d185257">

<img width="581" alt="image" src="https://github.com/flutter/flutter/assets/6655696/d72fd420-18cf-4470-9e4b-b6ac10fbcd50">

<img width="616" alt="image" src="https://github.com/flutter/flutter/assets/6655696/5f235ce1-252a-4c13-898f-139f6c7bc698">

### `windows`, `linux`, and `web`
Build executables aren't self-contained, and folder size can sometimes overestimate distribution size, therefore their size isn't mentioned (see discussion below).

<img width="647" alt="image" src="https://github.com/flutter/flutter/assets/6655696/7179e771-1eb7-48f6-b770-975bc073437b">

<img width="658" alt="image" src="https://github.com/flutter/flutter/assets/6655696/a6801cab-7b5a-4975-a406-f4c9fa44d7a2">

<img width="608" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ee7c4125-a273-4a65-95d7-ab441edf8ac5">

### Size reporting
When applicable, the printed size matches the OS reported size.

- macOS
    <img width="391" alt="image" src="https://github.com/flutter/flutter/assets/6655696/881cbfb1-d355-444b-ab44-c1a6343190ce">
- Windows
    <img width="338" alt="image" src="https://github.com/flutter/flutter/assets/6655696/3b806def-3d15-48a9-8a25-df200d6feef7">
- Linux   
    <img width="320" alt="image" src="https://github.com/flutter/flutter/assets/6655696/89a4aa3d-2148-4f3b-b231-f93a057fee2b">

## Related issues
Part of #120127
Fixes https://github.com/flutter/flutter/issues/121401

2fc76c78

Introduce `Split` curve (#143130) · 3109b111

Pierre-Louis authored Mar 16, 2024

`Split` is a curve that progresses according to `beginCurve` until
`split`, then according to `endCurve`.

This curve is used with bottom sheets to allow linear finger dragging
and non-linear enter/exit animations. This PR cleans up a previously
private class I introduced and replaces it with the more customisable
`Split`.

Fixes https://github.com/flutter/flutter/issues/51627

Diagram to be added with
https://github.com/flutter/assets-for-api-docs/pull/239

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

3109b111

Roll Flutter Engine from 120e52b8a1c2 to 91b9cf24d328 (1 revision) (#145256) · 988bee80

engine-flutter-autoroll authored Mar 16, 2024

https://github.com/flutter/engine/compare/120e52b8a1c2...91b9cf24d328

2024-03-16 skia-flutter-autoroll@skia.org Roll Skia from 05e1b6675da4 to 28701a2820eb (1 revision) (flutter/engine#51468)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

988bee80

Roll Flutter Engine from 3abc25139959 to 120e52b8a1c2 (1 revision) (#145254) · 360d46fa

engine-flutter-autoroll authored Mar 16, 2024

https://github.com/flutter/engine/compare/3abc25139959...120e52b8a1c2

2024-03-16 skia-flutter-autoroll@skia.org Roll Skia from 2d46a81facd8 to 05e1b6675da4 (1 revision) (flutter/engine#51467)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

360d46fa

Roll Flutter Engine from 6f180615e6ac to 3abc25139959 (1 revision) (#145253) · 483aa35c

engine-flutter-autoroll authored Mar 16, 2024

https://github.com/flutter/engine/compare/6f180615e6ac...3abc25139959

2024-03-16 skia-flutter-autoroll@skia.org Roll Dart SDK from 2241333f69f3 to 934c41c1c18e (1 revision) (flutter/engine#51465)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

483aa35c

Platform view devicelab ad banner scroll list real ads (#145239) · a2678be7

Jenn Magder authored Mar 16, 2024

Reland https://github.com/flutter/flutter/pull/144745, which was reverted due to a the Android app ads not being set up correctly, crashing on launch: https://github.com/flutter/flutter/pull/145228

Add the missing [`com.google.android.gms.ads.APPLICATION_ID` `meta-data` tag](https://developers.google.com/admob/android/quick-start#import_the_mobile_ads_sdk) to the manifest.

Validated both `platform_views_scroll_perf__timeline_summary` and `platform_views_scroll_perf_impeller__timeline_summary` ran locally on an Android emulator.

Successful presubmit runs:
https://ci.chromium.org/ui/p/flutter/builders/try/Linux_pixel_7pro%20platform_views_scroll_perf__timeline_summary/4/overview
https://ci.chromium.org/ui/p/flutter/builders/try/Linux_pixel_7pro%20platform_views_scroll_perf_impeller__timeline_summary/4/overview

Original commit message:
_________
This benchmark is to measure the platform view performance improvement. 

It is similar to https://github.com/lucalooz/flutter_ads_list_perf

There's still a pending issue https://github.com/flutter/flutter/issues/144339

Fixes https://github.com/flutter/flutter/issues/143534
Fixes https://github.com/flutter/flutter/issues/143257

a2678be7

Roll Flutter Engine from 6ddaa40bf1a6 to 6f180615e6ac (1 revision) (#145251) · 75996665

engine-flutter-autoroll authored Mar 16, 2024

https://github.com/flutter/engine/compare/6ddaa40bf1a6...6f180615e6ac

2024-03-16 flar@google.com Silence gn warning about unused Skia flag (flutter/engine#51464)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

75996665

Roll Flutter Engine from d46c1fa17dda to 6ddaa40bf1a6 (1 revision) (#145250) · 33bf4757

engine-flutter-autoroll authored Mar 16, 2024

https://github.com/flutter/engine/compare/d46c1fa17dda...6ddaa40bf1a6

2024-03-16 flar@google.com Reland "Add DisplayList Region and Transform benchmarks to CI" (flutter/engine#51458)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

33bf4757

Roll Flutter Engine from 7f15dc1200bc to d46c1fa17dda (2 revisions) (#145248) · 2ac7b95a

engine-flutter-autoroll authored Mar 16, 2024

https://github.com/flutter/engine/compare/7f15dc1200bc...d46c1fa17dda

2024-03-16 skia-flutter-autoroll@skia.org Roll Dart SDK from 03cc4d817056 to 2241333f69f3 (2 revisions) (flutter/engine#51461)
2024-03-16 chinmaygarde@google.com Re-land "[Impeller] A toolkit for managed handles to Android NDK vended objects." (flutter/engine#51460)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2ac7b95a

Use a separate `TextPainter` for intrinsics calculation in `RenderEditable`... · cc017017

LongCatIsLooong authored Mar 16, 2024

Use a separate `TextPainter` for intrinsics calculation in `RenderEditable` and `RenderParagraph` (#144577)

Use a dedicated `TextPainter` for intrinsic size calculation in `RenderEditable` and `RenderParagraph`.

This is an implementation detail so the change should be covered by existing tests. Performance wise this shouldn't be significantly slower since SkParagraph [caches the result of slower operations across different paragraphs](https://github.com/google/skia/blob/9c62e7b382cf387195ef82895530c97ccceda690/modules/skparagraph/src/ParagraphCache.cpp#L254-L272). Existing benchmarks should be able to catch potential regressions (??).

The reason for making this change is to make sure that intrinsic size computations don't destroy text layout artifacts, so I can expose the text layout as a stream of immutable `TextLayout` objects, to signify other render objects that text-layout-dependent-cache (such as caches for `getBoxesForRange` which can be relatively slow to compute) should be invalidated and `markNeedsPaint` needs to be called if the painting logic depended on text layout.
Without this change, the intrinsics/dry layout calculations will add additional events to the text layout stream, which violates the "dry"/non-destructive contract.

cc017017

Roll Flutter Engine from 2db915c64e6e to 7f15dc1200bc (1 revision) (#145245) · 15e90ad2

engine-flutter-autoroll authored Mar 16, 2024

https://github.com/flutter/engine/compare/2db915c64e6e...7f15dc1200bc

2024-03-15 skia-flutter-autoroll@skia.org Roll Skia from 11b1a958c2ac to 2d46a81facd8 (11 revisions) (flutter/engine#51459)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

15e90ad2

15 Mar, 2024 2 commits

Roll Flutter Engine from ba1115c30381 to 2db915c64e6e (2 revisions) (#145240) · 20105db1

engine-flutter-autoroll authored Mar 15, 2024

https://github.com/flutter/engine/compare/ba1115c30381...2db915c64e6e

2024-03-15 737941+loic-sharma@users.noreply.github.com [Windows] Move to new present callback (flutter/engine#51293)
2024-03-15 matanlurey@users.noreply.github.com Log messages when an image successfully uploads to Skia Gold (flutter/engine#51455)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

20105db1

Roll Flutter Engine from c2fd5333a5d2 to ba1115c30381 (3 revisions) (#145237) · 55d8b20d

engine-flutter-autoroll authored Mar 15, 2024

https://github.com/flutter/engine/compare/c2fd5333a5d2...ba1115c30381

2024-03-15 matanlurey@users.noreply.github.com Add more explicit logging (just to `stderr`) if a try-job detects an untriaged image (flutter/engine#51454)
2024-03-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] A toolkit for managed handles to Android NDK vended objects. (#51334)" (flutter/engine#51457)
2024-03-15 chinmaygarde@google.com [Impeller] A toolkit for managed handles to Android NDK vended objects. (flutter/engine#51334)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

55d8b20d