Commits · ea455905a5e3b62cc9f387dbcef3f3918727df3a · abdullh.alsoleman / Front-End

13 Jun, 2023 3 commits

Roll Flutter Engine from d02b15ef34ef to aa1693f6aaeb (3 revisions) (#128759) · ea455905

engine-flutter-autoroll authored Jun 13, 2023

https://github.com/flutter/engine/compare/d02b15ef34ef...aa1693f6aaeb

2023-06-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 605fd026151b to 7bacb78a0db8 (1 revision) (flutter/engine#42795)
2023-06-13 jonahwilliams@google.com [Impeller] Ensure vulkan offscreen pixelformat is the same as the onscreen format (flutter/engine#42788)
2023-06-13 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from pd1VfyK_WEW6tu8WI... to r0hMbc7UJwTJkxjbt... (flutter/engine#42786)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from pd1VfyK_WEW6 to r0hMbc7UJwTJ

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ea455905

Roll Flutter Engine from f67ed35b142e to d02b15ef34ef (2 revisions) (#128754) · 5f8000aa

engine-flutter-autoroll authored Jun 13, 2023

https://github.com/flutter/engine/compare/f67ed35b142e...d02b15ef34ef

2023-06-12 jonahwilliams@google.com [Impeller] Fix text jitter on Vulkan. (flutter/engine#42792)
2023-06-12 jmccandless@google.com Predictive back breakage fix (flutter/engine#42789)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5f8000aa

Roll Flutter Engine from 1714d73e681b to f67ed35b142e (3 revisions) (#128751) · 8c7c3d3b

engine-flutter-autoroll authored Jun 13, 2023

https://github.com/flutter/engine/compare/1714d73e681b...f67ed35b142e

2023-06-12 godofredoc@google.com Reland "Move linux clang tidy to engine_v2."" (flutter/engine#42713)
2023-06-12 godofredoc@google.com Relands "Move clang tidy v2 build to prod."" (flutter/engine#42714)
2023-06-12 skia-flutter-autoroll@skia.org Roll Dart SDK from dbee3c493f5a to 605fd026151b (2 revisions) (flutter/engine#42785)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8c7c3d3b

12 Jun, 2023 13 commits

Roll Flutter Engine from 12def739b1f6 to 1714d73e681b (2 revisions) (#128738) · fc335ea5

engine-flutter-autoroll authored Jun 12, 2023

https://github.com/flutter/engine/compare/12def739b1f6...1714d73e681b

2023-06-12 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
FreETK3TrhkNzCCL-... to J-zU9HGYXYU5UWJO9... (flutter/engine#42784)
2023-06-12 jonahwilliams@google.com [Impeller] allowing enabling
Impeller on macOS. (flutter/engine#42639)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from FreETK3TrhkN to J-zU9HGYXYU5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fc335ea5

Fix paint offset in reverse for 2D (#128724) · 9e0ad4c6

Kate Lovett authored Jun 12, 2023

Fixes https://github.com/flutter/flutter/issues/128723

The paint offset was incorrectly being computed when one or both axis was in the reverse direction. Instead of using the paint extent, the child's size should be used.

9e0ad4c6

[flutter_tools] pass through enable impeller flag to macOS. (#128720) · 9af6bae6
Jonah Williams authored Jun 12, 2023
```
Allow passing through the --enable-impeller flag to macOS.
```
9af6bae6

Roll Flutter Engine from de68fba09338 to 12def739b1f6 (2 revisions) (#128726) · a70f9359

engine-flutter-autoroll authored Jun 12, 2023

https://github.com/flutter/engine/compare/de68fba09338...12def739b1f6

2023-06-12 41930132+hellohuanlin@users.noreply.github.com [floating_cursor_selection] a somewhat "design doc" for floating cursor feature (flutter/engine#42173)
2023-06-12 skia-flutter-autoroll@skia.org Roll ANGLE from 43ef50f389e9 to 21f16cb16333 (1 revision) (flutter/engine#42779)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a70f9359

Roll Flutter Engine from 33e06934daed to de68fba09338 (10 revisions) (#128721) · a98a3ce2

engine-flutter-autoroll authored Jun 12, 2023

https://github.com/flutter/engine/compare/33e06934daed...de68fba09338

2023-06-12 smartercallum@gmail.com Fix crash with CJK keyboard with emoji at end of text field (flutter/engine#42540)
2023-06-12 skia-flutter-autoroll@skia.org Roll Skia from 658b1d366758 to 6bdb0ef30cb6 (2 revisions) (flutter/engine#42778)
2023-06-12 jonahwilliams@google.com [Impeller] Correct attachment description for offscreen MSAA resolve. (flutter/engine#42753)
2023-06-12 tamird@google.com Remove dependency on memfs (flutter/engine#42773)
2023-06-12 skia-flutter-autoroll@skia.org Roll Skia from 0f974a0f8c10 to 658b1d366758 (1 revision) (flutter/engine#42776)
2023-06-12 skia-flutter-autoroll@skia.org Roll ANGLE from 3abbc4f99970 to 43ef50f389e9 (1 revision) (flutter/engine#42775)
2023-06-12 kjlubick@users.noreply.github.com Remove unnecessary #include of SkPromiseImageTexture (flutter/engine#42770)
2023-06-12 skia-flutter-autoroll@skia.org Roll Skia from 951123096e55 to 0f974a0f8c10 (5 revisions) (flutter/engine#42771)
2023-06-12 jonahwilliams@google.com [Impeller] opt all vertex shader position/uvs into highp (flutter/engine#42746)
2023-06-12 30870216+gaaclarke@users.noreply.github.com [Impeller] added debug info to frame debuggers like AGI (flutter/engine#42717)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a98a3ce2

Roll Flutter Engine from 4b022f4e871f to 33e06934daed (6 revisions) (#128706) · f430c81e

engine-flutter-autoroll authored Jun 12, 2023

https://github.com/flutter/engine/compare/4b022f4e871f...33e06934daed

2023-06-12 skia-flutter-autoroll@skia.org Roll Skia from 91f5ec62e30b to 951123096e55 (4 revisions) (flutter/engine#42767)
2023-06-12 skia-flutter-autoroll@skia.org Roll Skia from 18bd238c3db9 to 91f5ec62e30b (1 revision) (flutter/engine#42765)
2023-06-12 skia-flutter-autoroll@skia.org Roll Dart SDK from bd05ed6d5258 to dbee3c493f5a (1 revision) (flutter/engine#42763)
2023-06-12 skia-flutter-autoroll@skia.org Roll ANGLE from 10380f4ba473 to 3abbc4f99970 (1 revision) (flutter/engine#42761)
2023-06-12 skia-flutter-autoroll@skia.org Roll Dart SDK from a4611bd71a52 to bd05ed6d5258 (1 revision) (flutter/engine#42759)
2023-06-12 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from UxuMYdEq-rI5WqUKJ... to FreETK3TrhkNzCCL-... (flutter/engine#42757)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from UxuMYdEq-rI5 to FreETK3TrhkN

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f430c81e

Update button tests for Material 3 by default (#128628) · c5a81d1b
Hans Muller authored Jun 12, 2023

c5a81d1b

Roll Packages from afe2f05c1adb to c9865e8c63dc (6 revisions) (#128701) · 353b8bc8

engine-flutter-autoroll authored Jun 12, 2023

https://github.com/flutter/packages/compare/afe2f05c1adb...c9865e8c63dc

2023-06-11 engine-flutter-autoroll@skia.org Roll Flutter from da127f15 to 3df163ff (25 revisions) (flutter/packages#4183)
2023-06-10 stuartmorgan@google.com [image_picker] Add desktop support (flutter/packages#3882)
2023-06-09 tarrinneal@gmail.com [image_picker] getMedia platform changes (flutter/packages#4174)
2023-06-09 stuartmorgan@google.com [image_picker] Add desktop support - implementations (flutter/packages#4172)
2023-06-09 engine-flutter-autoroll@skia.org Roll Flutter from 6e254a3f to da127f15 (28 revisions) (flutter/packages#4170)
2023-06-09 32538273+ValentinVignal@users.noreply.github.com [go_router_builder] Include required and positional query parameters in the location (flutter/packages#4163)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

353b8bc8

Fix RangeSlider notifies start and end twice when participates in gesture arena (#128674) · ad8c9978

nt4f04uNd authored Jun 12, 2023

Fixes https://github.com/flutter/flutter/issues/128433

This PR applies the same fix as we did for Slider https://github.com/flutter/flutter/pull/82152

ad8c9978

Address leak tracker breaking changes. (#128623) · 05d1cde0
Polina Cherkasova authored Jun 12, 2023

05d1cde0

Update `ListTile` text defaults to use `ColorScheme` (#128581) · ca5aa232

Taha Tesser authored Jun 12, 2023

fixes https://github.com/flutter/flutter/issues/128569

<details> 
<summary>code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() {
  runApp(const ListTileApp());
}

class ListTileApp extends StatelessWidget {
  const ListTileApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        useMaterial3: true,
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.red).copyWith(
          onSurface: Colors.yellow,
          onSurfaceVariant: Colors.green,
        ),
      ),
      home: const Scaffold(
        body: Center(
          child: ListTile(
            title: Text('title'),
            subtitle: Text('subtitle'),
          ),
        ),
      ),
    );
  }
}

``` 
	
</details>

# Description
M3 ListTile couldn't be customized using `ColorScheme` colors. 

- This PR updates the list tile text defaults to `ColorScheme` text color tokens.
- Improved the `ListTile` template to use the token group.
- Update docs and tests.

```dart
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.red).copyWith(
          onSurface: Colors.yellow,
          onSurfaceVariant: Colors.green,
        ),
```

### Before

![Screenshot 2023-06-09 at 17 47 04](https://github.com/flutter/flutter/assets/48603081/c0130371-3c7c-428c-bb57-504822cf64b5)

### After

![Screenshot 2023-06-09 at 17 46 17](https://github.com/flutter/flutter/assets/48603081/3b4d6f8c-7fdd-4546-a6f0-00dd34cb5a96)

ca5aa232

Roll Flutter Engine from effea50196ca to 4b022f4e871f (2 revisions) (#128683) · 6f2118be

engine-flutter-autoroll authored Jun 12, 2023

https://github.com/flutter/engine/compare/effea50196ca...4b022f4e871f

2023-06-12 skia-flutter-autoroll@skia.org Roll Skia from 943f70d6f836 to 18bd238c3db9 (2 revisions) (flutter/engine#42755)
2023-06-12 skia-flutter-autoroll@skia.org Roll Skia from c4624cc7135a to 943f70d6f836 (2 revisions) (flutter/engine#42754)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6f2118be

Roll Flutter Engine from 9bb0a5907403 to effea50196ca (1 revision) (#128678) · 4f94dee8

engine-flutter-autoroll authored Jun 12, 2023

https://github.com/flutter/engine/compare/9bb0a5907403...effea50196ca

2023-06-12 skia-flutter-autoroll@skia.org Roll Dart SDK from 0c4f3ae7464c to a4611bd71a52 (1 revision) (flutter/engine#42751)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4f94dee8

11 Jun, 2023 10 commits

Roll Flutter Engine from 788437e41ee0 to 9bb0a5907403 (1 revision) (#128673) · 2b1f882e

engine-flutter-autoroll authored Jun 11, 2023

https://github.com/flutter/engine/compare/788437e41ee0...9bb0a5907403

2023-06-11 flar@google.com Reland "add non-rendering operation culling to DisplayListBuilder" (#41463) (flutter/engine#42584)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2b1f882e

Roll Flutter Engine from 5da44b9aafdd to 788437e41ee0 (2 revisions) (#128672) · 1fccad1b

engine-flutter-autoroll authored Jun 11, 2023

https://github.com/flutter/engine/compare/5da44b9aafdd...788437e41ee0

2023-06-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 46f3e816d30d to 0c4f3ae7464c (1 revision) (flutter/engine#42745)
2023-06-11 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from E7gwQ9L15jziMUKha... to UxuMYdEq-rI5WqUKJ... (flutter/engine#42744)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from E7gwQ9L15jzi to UxuMYdEq-rI5

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1fccad1b

Roll Flutter Engine from 6e2c71adccad to 5da44b9aafdd (1 revision) (#128669) · 08e595c1

engine-flutter-autoroll authored Jun 11, 2023

https://github.com/flutter/engine/compare/6e2c71adccad...5da44b9aafdd

2023-06-11 dkwingsmt@users.noreply.github.com Use ShellTest::Config struct to create Shell (flutter/engine#42332)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

08e595c1

Roll Flutter Engine from 1cca9cc6dbd1 to 6e2c71adccad (1 revision) (#128662) · d2c1cf89

engine-flutter-autoroll authored Jun 11, 2023

https://github.com/flutter/engine/compare/1cca9cc6dbd1...6e2c71adccad

2023-06-11 skia-flutter-autoroll@skia.org Roll Skia from 00cb34edb01c to c4624cc7135a (1 revision) (flutter/engine#42741)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d2c1cf89

Roll Flutter Engine from 73a7af805472 to 1cca9cc6dbd1 (1 revision) (#128658) · 3df163ff

engine-flutter-autoroll authored Jun 11, 2023

https://github.com/flutter/engine/compare/73a7af805472...1cca9cc6dbd1

2023-06-11 skia-flutter-autoroll@skia.org Roll Skia from 2bab3a2a2953 to 00cb34edb01c (1 revision) (flutter/engine#42737)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3df163ff

Roll Flutter Engine from 7c6770083e5c to 73a7af805472 (2 revisions) (#128654) · 90b1151d

engine-flutter-autoroll authored Jun 11, 2023

https://github.com/flutter/engine/compare/7c6770083e5c...73a7af805472

2023-06-11 skia-flutter-autoroll@skia.org Roll Dart SDK from ffb5a1502051 to 46f3e816d30d (1 revision) (flutter/engine#42733)
2023-06-11 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Otfnr8SATDVN_7BuI... to E7gwQ9L15jziMUKha... (flutter/engine#42732)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from Otfnr8SATDVN to E7gwQ9L15jzi

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

90b1151d

Roll Flutter Engine from 6d615bbcfccf to 7c6770083e5c (2 revisions) (#128653) · cf2ce22f

engine-flutter-autoroll authored Jun 11, 2023

https://github.com/flutter/engine/compare/6d615bbcfccf...7c6770083e5c

2023-06-11 skia-flutter-autoroll@skia.org Roll Skia from 5c9cdc4e0b61 to 2bab3a2a2953 (57 revisions) (flutter/engine#42731)
2023-06-11 zhangzhijian.123@bytedance.com [Impeller] Improved numerical stability in cubic path boundary calculations (flutter/engine#42720)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cf2ce22f

Roll Flutter Engine from b19b93de5b0a to 6d615bbcfccf (1 revision) (#128650) · 2276b547

engine-flutter-autoroll authored Jun 11, 2023

https://github.com/flutter/engine/compare/b19b93de5b0a...6d615bbcfccf

2023-06-11 skia-flutter-autoroll@skia.org Roll Skia from 8fdbbca7d35d to 5c9cdc4e0b61 (1 revision) (flutter/engine#42650)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2276b547

Roll Flutter Engine from 3d76ba6d6d5f to b19b93de5b0a (2 revisions) (#128649) · 1ff9ba64

engine-flutter-autoroll authored Jun 11, 2023

https://github.com/flutter/engine/compare/3d76ba6d6d5f...b19b93de5b0a

2023-06-11 skia-flutter-autoroll@skia.org Roll Dart SDK from ba6736de40d2 to ffb5a1502051 (1 revision) (flutter/engine#42728)
2023-06-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 9d705a5391b2 to ba6736de40d2 (4 revisions) (flutter/engine#42725)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1ff9ba64

Roll Flutter Engine from 962d78e0ae9c to 3d76ba6d6d5f (1 revision) (#128645) · 6c471d3e

engine-flutter-autoroll authored Jun 11, 2023

https://github.com/flutter/engine/compare/962d78e0ae9c...3d76ba6d6d5f

2023-06-10 jonahwilliams@google.com [Impeller] Fix vulkan gradient nan issue. (flutter/engine#42715)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6c471d3e

10 Jun, 2023 5 commits

migrate `Tooltip` to use `OverlayPortal` (#127728) · e1fdb1aa

LongCatIsLooong authored Jun 10, 2023

https://github.com/flutter/flutter/issues/7151 isn't a problem with OverlayPortal so the test is removed.
Also removed some `mounted` checks since they're no longer needed.

e1fdb1aa

Roll Flutter Engine from b037db26037f to 962d78e0ae9c (10 revisions) (#128643) · 9e8143a0

engine-flutter-autoroll authored Jun 10, 2023

https://github.com/flutter/engine/compare/b037db26037f...962d78e0ae9c

2023-06-10 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 1ODZdNPvGxBrgnCzf... to pd1VfyK_WEW6tu8WI... (flutter/engine#42723)
2023-06-10 skia-flutter-autoroll@skia.org Roll ANGLE from acdf872299ba to 10380f4ba473 (1 revision) (flutter/engine#42722)
2023-06-10 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from EInl_eQkJekqc-gfW... to Otfnr8SATDVN_7BuI... (flutter/engine#42721)
2023-06-10 skia-flutter-autoroll@skia.org Roll ANGLE from a01a566c489b to acdf872299ba (1 revision) (flutter/engine#42719)
2023-06-10 skia-flutter-autoroll@skia.org Roll Clang from 6d667d4b261e to 7f374b6902fa (flutter/engine#42718)
2023-06-10 skia-flutter-autoroll@skia.org Manual roll Dart SDK from d5b39a8385f9 to 9d705a5391b2 (7 revisions) (flutter/engine#42716)
2023-06-09 30870216+gaaclarke@users.noreply.github.com [Impeller] Added helper messaging around validation usage (flutter/engine#42708)
2023-06-09 54558023+keyonghan@users.noreply.github.com Fix an archive name in windows_host_engine config (flutter/engine#42709)
2023-06-09 skia-flutter-autoroll@skia.org Roll ANGLE from 72df42832ee4 to a01a566c489b (3 revisions) (flutter/engine#42712)
2023-06-09 dnfield@google.com Delete WeakPtrFactory from GPUSurfaceVulkanImpeller (flutter/engine#42710)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 1ODZdNPvGxBr to pd1VfyK_WEW6
fuchsia/sdk/core/mac-amd64 from EInl_eQkJekq to Otfnr8SATDVN

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9e8143a0

Bump actions/checkout from 3.5.2 to 3.5.3 (#128625) · e39ed8e8

dependabot[bot] authored Jun 10, 2023

Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.2 to 3.5.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v3.5.3</h2>
<h2>What's Changed</h2>
<ul>
<li>Fix: Checkout Issue in self hosted runner due to faulty submodule check-ins by <a href="https://github.com/megamanics"><code>@âmegamanics</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1196">actions/checkout#1196</a></li>
<li>Fix typos found by codespell by <a href="https://github.com/DimitriPapadopoulos"><code>@âDimitriPapadopoulos</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1287">actions/checkout#1287</a></li>
<li>Add support for sparse checkouts by <a href="https://github.com/dscho"><code>@âdscho</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1369">actions/checkout#1369</a></li>
<li>Release v3.5.3 by <a href="https://github.com/TingluoHuang"><code>@âTingluoHuang</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1376">actions/checkout#1376</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/megamanics"><code>@âmegamanics</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1196">actions/checkout#1196</a></li>
<li><a href="https://github.com/DimitriPapadopoulos"><code>@âDimitriPapadopoulos</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1287">actions/checkout#1287</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v3...v3.5.3">https://github.com/actions/checkout/compare/v3...v3.5.3</a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/blob/main/CHANGELOG.md">actions/checkout's changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<h2>v3.5.3</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1196">Fix: Checkout fail in self-hosted runners when faulty submodule are checked-in</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1287">Fix typos found by codespell</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1369">Add support for sparse checkouts</a></li>
</ul>
<h2>v3.5.2</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1289">Fix api endpoint for GHES</a></li>
</ul>
<h2>v3.5.1</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1246">Fix slow checkout on Windows</a></li>
</ul>
<h2>v3.5.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1237">Add new public key for known_hosts</a></li>
</ul>
<h2>v3.4.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1209">Upgrade codeql actions to v2</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1210">Upgrade dependencies</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1225">Upgrade <code>@âactions/io</code></a></li>
</ul>
<h2>v3.3.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1045">Implement branch list using callbacks from exec function</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1050">Add in explicit reference to private checkout options</a></li>
<li>[Fix comment typos (that got added in <a href="https://redirect.github.com/actions/checkout/issues/770">#770</a>)](<a href="https://redirect.github.com/actions/checkout/pull/1057">actions/checkout#1057</a>)</li>
</ul>
<h2>v3.2.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/942">Add GitHub Action to perform release</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/967">Fix status badge</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1002">Replace datadog/squid with ubuntu/squid Docker image</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/964">Wrap pipeline commands for submoduleForeach in quotes</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1029">Update <code>@âactions/io</code> to 1.1.2</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1039">Upgrading version to 3.2.0</a></li>
</ul>
<h2>v3.1.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/939">Use <code>@âactions/core</code> <code>saveState</code> and <code>getState</code></a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/922">Add <code>github-server-url</code> input</a></li>
</ul>
<h2>v3.0.2</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/770">Add input <code>set-safe-directory</code></a></li>
</ul>
<h2>v3.0.1</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/762">Fixed an issue where checkout failed to run in container jobs due to the new git setting <code>safe.directory</code></a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/744">Bumped various npm package versions</a></li>
</ul>
<h2>v3.0.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/689">Update to node 16</a></li>
</ul>
<h2>v2.3.1</h2>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/actions/checkout/commit/c85c95e3d7251135ab7dc9ce3241c5835cc595a9"><code>c85c95e</code></a> Release v3.5.3 (<a href="https://redirect.github.com/actions/checkout/issues/1376">#1376</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/d106d4669b3bfcb17f11f83f98e1cab478e9f635"><code>d106d46</code></a> Add support for sparse checkouts (<a href="https://redirect.github.com/actions/checkout/issues/1369">#1369</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/f095bcc56b7c2baf48f3ac70d6d6782f4f553222"><code>f095bcc</code></a> Fix typos found by codespell (<a href="https://redirect.github.com/actions/checkout/issues/1287">#1287</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/47fbe2df0ad0e27efb67a70beac3555f192b062f"><code>47fbe2d</code></a> Fix: Checkout fail in self-hosted runners when faulty submodule are checked-i...</li>
<li>See full diff in <a href="https://github.com/actions/checkout/compare/8e5e7e5ab8b370d6c329ec480221332ada57f0ab...c85c95e3d7251135ab7dc9ce3241c5835cc595a9">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/checkout&package-manager=github_actions&previous-version=3.5.2&new-version=3.5.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

e39ed8e8

Roll Flutter Engine from 3e90345cdca7 to b037db26037f (1 revision) (#128627) · 94a40d0a

engine-flutter-autoroll authored Jun 10, 2023

https://github.com/flutter/engine/compare/3e90345cdca7...b037db26037f

2023-06-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
xqQPG9jnWgD1Dj3FL... to 1ODZdNPvGxBrgnCzf... (flutter/engine#42707)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from xqQPG9jnWgD1 to 1ODZdNPvGxBr

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

94a40d0a

Remove unnecessary parentheses (#128620) · 65e1cb19
ZhulanovAA authored Jun 10, 2023
```
Fix unnecessary parentheses introduced in #128501

@chunhtai @HansMuller
```
65e1cb19

09 Jun, 2023 9 commits

Roll Flutter Engine from 488876ed26c6 to 3e90345cdca7 (3 revisions) (#128617) · ca11492b

engine-flutter-autoroll authored Jun 09, 2023

https://github.com/flutter/engine/compare/488876ed26c6...3e90345cdca7

2023-06-09 skia-flutter-autoroll@skia.org Roll ANGLE from 3e4f4caebcb0 to 72df42832ee4 (2 revisions) (flutter/engine#42703)
2023-06-09 skia-flutter-autoroll@skia.org Manual roll Dart SDK from bbce07ad3944 to d5b39a8385f9 (2 revisions) (flutter/engine#42702)
2023-06-09 30870216+gaaclarke@users.noreply.github.com [Impeller] Reland: Added a switch to turn on vulkan (flutter/engine#42669)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ca11492b

rename generated asset manifest file back to `AssetManifest.bin` (from... · cfe4fedc

Andrew Kolos authored Jun 09, 2023

rename generated asset manifest file back to `AssetManifest.bin` (from `AssetManifest.smcbin`) (#128529)

Closes https://github.com/flutter/flutter/issues/128456, which is now linked to in a code comment in this change.
Reopens https://github.com/flutter/flutter/issues/124883.

This effectively reverts https://github.com/flutter/flutter/pull/126077 and is intended to be cherry-picked into stable.

cfe4fedc

Add Selected semantics to IconButton (#128547) · af7a8f6b

hangyu authored Jun 09, 2023

fixes: #127145

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

---------
Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>

af7a8f6b

Roll Flutter Engine from 071e1fb21c7a to 488876ed26c6 (5 revisions) (#128612) · 9c0c611e

engine-flutter-autoroll authored Jun 09, 2023

https://github.com/flutter/engine/compare/071e1fb21c7a...488876ed26c6

2023-06-09 skia-flutter-autoroll@skia.org Roll ANGLE from a185cb8c8924 to 3e4f4caebcb0 (2 revisions) (flutter/engine#42701)
2023-06-09 bdero@google.com [Impeller] Add CPU implementations for all color filters (flutter/engine#42692)
2023-06-09 jonahwilliams@google.com [Impeller] add explicit VMA flush to device memory writes. (flutter/engine#42685)
2023-06-09 30870216+gaaclarke@users.noreply.github.com [Impeller] Makes validation layers flag work for android (flutter/engine#42625)
2023-06-09 jmccandless@google.com Platform channel for predictive back (flutter/engine#39208)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9c0c611e

Clarifies semantics long press and semantics on tap documentation (#128599) · cc6f86e6
chunhtai authored Jun 09, 2023
```
fixes https://github.com/flutter/flutter/issues/35112
```
cc6f86e6

Roll Flutter Engine from bc6e047570f6 to 071e1fb21c7a (1 revision) (#128602) · a35ae601

engine-flutter-autoroll authored Jun 09, 2023

https://github.com/flutter/engine/compare/bc6e047570f6...071e1fb21c7a

2023-06-09 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from romfKfKwgjzAXQSxt... to EInl_eQkJekqc-gfW... (flutter/engine#42698)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from romfKfKwgjzA to EInl_eQkJekq

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a35ae601

Revert "Update `chip.dart` to use set of `MaterialState`" (#128607) · d5a8fa62

Hans Muller authored Jun 09, 2023

Reverts flutter/flutter#128507

This PR caused some internal failures (Google internal link b/286503764). Will need to investigate before we can re-land these changes.

d5a8fa62

Add tooltips for `SegmentedButton` (#128501) · e84fa2ce
ZhulanovAA authored Jun 09, 2023

e84fa2ce

Ignore app.stop events received before the app.detach response in attach... · a08a2110

Jason Simmons authored Jun 09, 2023

Ignore app.stop events received before the app.detach response in attach integration tests (#128593)

The app.detach command will close the VM service connection, which yields an app.stop event in the daemon protocol. The daemon does not guarantee any ordering between this event and the response to the app.detach.

See https://github.com/flutter/flutter/issues/128546

a08a2110