- 14 Nov, 2023 11 commits
-
-
Taha Tesser authored
Reland "Update `framework_test.dart` to remove `ButtonBar` usage and remove references from other clases (#137550) (#137753) This PR removes `ButtonBar` usage from `framework_test.dart` class and update other references in preparation for `ButtonBar` deprecation related to https://github.com/flutter/flutter/issues/127955 reland https://github.com/flutter/flutter/pull/137550
-
Jackson Gardner authored
Work in progress... currently testing against presubmit.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/995ebcefb0d4...1b3fd80812c3 2023-11-14 skia-flutter-autoroll@skia.org Roll Skia from f22c71596039 to b7d581997f2b (1 revision) (flutter/engine#48018) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/17bd92e8a37d...428ba3e24532 2023-11-13 stuartmorgan@google.com [pigeon] Remove semicolons from Kotlin generation (flutter/packages#5375) 2023-11-13 stuartmorgan@google.com [tool] Add Kotlin autoformatting (flutter/packages#5374) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/712094481217...995ebcefb0d4 2023-11-14 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from UaodAPcg8HCGdDb-C... to AuDKY8ob6GrGwDlmk... (flutter/engine#48016) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from UaodAPcg8HCG to AuDKY8ob6GrG If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/2c54b5f70c94...712094481217 2023-11-14 skia-flutter-autoroll@skia.org Roll Skia from ab1b506c68a2 to f22c71596039 (3 revisions) (flutter/engine#48009) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/d100e8912eb0...2c54b5f70c94 2023-11-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 6219f11bf0fb to b3d3b381fd7b (1 revision)" (flutter/engine#48011) 2023-11-14 skia-flutter-autoroll@skia.org Roll Skia from 9a45d3d77b31 to ab1b506c68a2 (1 revision) (flutter/engine#48007) 2023-11-14 zanderso@users.noreply.github.com Move Skia to //flutter/third_party/skia (flutter/engine#47913) 2023-11-14 skia-flutter-autoroll@skia.org Roll Dart SDK from 6219f11bf0fb to b3d3b381fd7b (1 revision) (flutter/engine#48006) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/74a9de45f128...d100e8912eb0 2023-11-14 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 370145bbbd4f to 6219f11bf0fb (7 revisions) (flutter/engine#47998) 2023-11-14 matanlurey@users.noreply.github.com Make `display_list/...` compatible with `.clang_tidy`. (flutter/engine#47993) 2023-11-14 skia-flutter-autoroll@skia.org Roll Skia from c5aef650e2b2 to 9a45d3d77b31 (1 revision) (flutter/engine#47997) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/77b952f3add4...74a9de45f128 2023-11-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Make `fml/...` compatible with `.clang_tidy`." (flutter/engine#48004) 2023-11-13 matanlurey@users.noreply.github.com Make `fml/...` compatible with `.clang_tidy`. (flutter/engine#47992) 2023-11-13 skia-flutter-autoroll@skia.org Roll Skia from 9ac5cad143ec to c5aef650e2b2 (3 revisions) (flutter/engine#47991) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Peter Abraham authored
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/046ec85dffc6...77b952f3add4 2023-11-13 mdebbar@google.com [web] Cleanup touch and mouse event adapters (flutter/engine#43697) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 13 Nov, 2023 12 commits
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/db6da000a17e...046ec85dffc6 2023-11-13 godofredoc@google.com Fix fuchsia upload symbols. (flutter/engine#47938) 2023-11-13 skia-flutter-autoroll@skia.org Roll Skia from 1a39bd56cda2 to 9ac5cad143ec (3 revisions) (flutter/engine#47984) 2023-11-13 110993981+htoor3@users.noreply.github.com [web] - fix Safari textfield selection bug (flutter/engine#47917) 2023-11-13 skia-flutter-autoroll@skia.org Roll Skia from 17b6555a1551 to 1a39bd56cda2 (2 revisions) (flutter/engine#47980) 2023-11-13 jason-simmons@users.noreply.github.com Add a libcxxabi module that provides support for C++ thread-local storage (flutter/engine#47886) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Michael Goderbauer authored
ð«¡ This was terribly outdated and has long been superseded by `package:flutter_lints`. Also, as of https://github.com/dart-lang/sdk/commit/c033718da0502ed92609f8c6cee2f6a59ccc058e support for this was removed from the analyzer and this file is now even more useless, if that's even possible. Fixes https://github.com/flutter/flutter/issues/82948.
-
Kenzie Davisson authored
Mirrored change in the .github/ repo: https://github.com/flutter/.github/pull/34
-
huycozy authored
### Description This PR intends to update `DraggableScrollableSheet` docs for Web and Desktop platforms. On these platforms, the vertical dragging gesture does not provide natural behavior similar to other desktop applications. By adding a note before the sample code so users are aware that the sample code will not work as expected on Desktop and Web. Also, refer to the instructions if they still want to implement it on these platforms. ### Related issue Fixes https://github.com/flutter/flutter/issues/111372
-
Greg Spencer authored
## Description This cleans up how synonyms are calculated, and adds a reverse mapping from pseudo keys to the real keys they are synonyms of. Updates the `layout_goals.json` to include the "Space" key, since that was added in the engine without updating the generation configuration.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/74ba6c17a488...db6da000a17e 2023-11-13 jonahwilliams@google.com [Impeller] Add convex tess benchmark. (flutter/engine#47956) 2023-11-13 jonahwilliams@google.com [engine] request frame rate once per frame. (flutter/engine#47954) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/5d62f1a2392a...74ba6c17a488 2023-11-13 skia-flutter-autoroll@skia.org Roll Skia from 9c369abd687d to 17b6555a1551 (5 revisions) (flutter/engine#47975) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/7de793d2bb68...5d62f1a2392a 2023-11-13 dacoharkes@google.com Revert "[deps] Stop moving NDK folder inside Android SDK (#47454)" (flutter/engine#47905) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Polina Cherkasova authored
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/fe11f3a46bac...7de793d2bb68 2023-11-13 skia-flutter-autoroll@skia.org Roll Skia from 7b730016006e to 9c369abd687d (3 revisions) (flutter/engine#47969) 2023-11-13 skia-flutter-autoroll@skia.org Roll Skia from 3a7a6d23ab4f to 7b730016006e (1 revision) (flutter/engine#47967) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/a6821898bd5a...17bd92e8a37d 2023-11-11 15619084+vashworth@users.noreply.github.com Only run tests on macOS 12 (flutter/packages#5369) 2023-11-10 tarrinneal@gmail.com [pigeon] Channel name in flutter error. (flutter/packages#5273) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/a18ee3c7f57a...fe11f3a46bac 2023-11-13 skia-flutter-autoroll@skia.org Roll Skia from 1e9711980c61 to 3a7a6d23ab4f (1 revision) (flutter/engine#47964) 2023-11-13 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from K3jvECt7y1_-zBVw3... to UaodAPcg8HCGdDb-C... (flutter/engine#47962) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from K3jvECt7y1_- to UaodAPcg8HCG If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 12 Nov, 2023 1 commit
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/828e4dbf6693...a18ee3c7f57a 2023-11-12 zanderso@users.noreply.github.com Reverts Dart SDK to 3.3.0-120.0.dev (flutter/engine#47959) 2023-11-12 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ikCrJNCuuApNeuH-6... to K3jvECt7y1_-zBVw3... (flutter/engine#47958) 2023-11-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 6415489ae51b to 1a1b9cbc838a (1 revision) (flutter/engine#47952) 2023-11-11 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 8sk2n2-NXJ-ceyc7T... to ikCrJNCuuApNeuH-6... (flutter/engine#47950) 2023-11-11 skia-flutter-autoroll@skia.org Roll Dart SDK from a03a7b62eb4e to 6415489ae51b (1 revision) (flutter/engine#47949) 2023-11-11 skia-flutter-autoroll@skia.org Roll Skia from 290962a9d913 to 1e9711980c61 (1 revision) (flutter/engine#47940) 2023-11-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 370145bbbd4f to a03a7b62eb4e (1 revision) (flutter/engine#47945) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 8sk2n2-NXJ-c to K3jvECt7y1_- If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 11 Nov, 2023 5 commits
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/e2e07eab35ec...828e4dbf6693 2023-11-11 skia-flutter-autoroll@skia.org Roll Skia from 7eaff63b1425 to 290962a9d913 (5 revisions) (flutter/engine#47937) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/1c29ce15c528...e2e07eab35ec 2023-11-11 bdero@google.com [Flutter GPU] Add DeviceBuffer. (flutter/engine#47699) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/aa6753fdbb51...1c29ce15c528 2023-11-11 15619084+vashworth@users.noreply.github.com Only run tests on macOS 12 (flutter/engine#47933) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/00db306f6f7b...aa6753fdbb51 2023-11-10 skia-flutter-autoroll@skia.org Roll Skia from 96ce4d6f433d to 7eaff63b1425 (1 revision) (flutter/engine#47932) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/9d8a1125640d...00db306f6f7b 2023-11-10 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Bump minSdk to 19 for Android tests" (flutter/engine#47935) 2023-11-10 skia-flutter-autoroll@skia.org Roll Dart SDK from 91c4a92a64ea to 370145bbbd4f (1 revision) (flutter/engine#47930) 2023-11-10 skia-flutter-autoroll@skia.org Roll Skia from 2c43bf002b7f to 96ce4d6f433d (3 revisions) (flutter/engine#47931) 2023-11-10 flar@google.com [Impeller] implement Canvas::DrawLine to tesselate lines directly (flutter/engine#47846) 2023-11-10 skia-flutter-autoroll@skia.org Roll Skia from d06840545bff to 2c43bf002b7f (1 revision) (flutter/engine#47928) 2023-11-10 43091780+utzcoz@users.noreply.github.com Bump minSdk to 19 for Android tests (flutter/engine#47686) 2023-11-10 dnfield@google.com [Impeller] Reduce allocations for polyline generation (flutter/engine#47837) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 10 Nov, 2023 11 commits
-
-
Victoria Ashworth authored
There's an https://github.com/flutter/flutter/issues/138238 with mac_toolchain that makes Xcode installs flakey and an https://github.com/flutter/flutter/issues/138246 that makes Xcode installs more frequent on macOS 13, which is causing presubmit tests to fall frequently. In the meantime, we'll only have tests run on macOS 12.
-
Kristijan Žic authored
Fixes the #136996 Readresses the #54358 Before: ```sh [✓] VS Code (version unknown) • VS Code at /snap/code/current • Flutter extension version 3.74.0 ✗ Unable to determine VS Code version. ``` After: ```sh [✓] VS Code (version 1.83.1) • VS Code at /snap/code/current/usr/share/code • Flutter extension version 3.74.0 ``` *List which issues are fixed by this PR. You must list at least one issue.* ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat -
Ross Llewallyn authored
This is a simple, common grammar issue. See here: https://en.wikipedia.org/wiki/Comprised_of
-
Chinmoy authored
This PR deprecates `onWillAccept` and `onAccept` over `onWillAcceptWithDetails` and `onAcceptWithDetails`. Fixes: #133347
-
Chris Bracken authored
As of Xcode 15 on macOS Sonoma, the following message is (repeatedly) output to stderr during builds (repros on non-Flutter apps). It is supppressed in xcode itself, but not when run from the command-line. ``` 2023-11-10 10:44:58.031 xcodebuild[61115:1017566] [MT] DVTAssertions: Warning in /System/Volumes/Data/SWE/Apps/DT/BuildRoots/BuildRoot11/ActiveBuildRoot/Library/Caches/com.apple.xbs/Sources/IDEFrameworks/IDEFrameworks-22267/IDEFoundation/Provisioning/Capabilities Infrastructure/IDECapabilityQuerySelection.swift:103 Details: createItemModels creation requirements should not create capability item model for a capability item model that already exists. Function: createItemModels(for:itemModelSource:) Thread: <_NSMainThread: 0x6000027c0280>{number = 1, name = main} Please file a bug at https://feedbackassistant.apple.com with this warning message and any useful information you can provide. ``` This suppresses this message from stderr in our macOS build logs. Issue: https://github.com/flutter/flutter/issues/135277 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat -
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/275ddb296ec9...9d8a1125640d 2023-11-10 skia-flutter-autoroll@skia.org Roll Skia from c4af3caee55c to d06840545bff (1 revision) (flutter/engine#47926) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Kostia Sokolovskyi authored
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/5c2e16c5a95a...275ddb296ec9 2023-11-10 skia-flutter-autoroll@skia.org Roll Skia from 126c8faf6c36 to c4af3caee55c (4 revisions) (flutter/engine#47920) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/b69f54ee0358...a6821898bd5a 2023-11-09 engine-flutter-autoroll@skia.org Roll Flutter from 4b4a1feb to f6621502 (17 revisions) (flutter/packages#5361) 2023-11-09 32538273+ValentinVignal@users.noreply.github.com [go_router] Retain query parameter during refresh and first redirect (flutter/packages#5276) 2023-11-09 15619084+vashworth@users.noreply.github.com Use specific version of mac_toolchain (flutter/packages#5356) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/e5b75177ac8e...5c2e16c5a95a 2023-11-10 skia-flutter-autoroll@skia.org Roll Skia from 384f047aa0b6 to 126c8faf6c36 (4 revisions) (flutter/engine#47916) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Elias Yishak authored
Related to tracker issue: - https://github.com/flutter/flutter/issues/128251 This event was only called from one file (`flutter_command.dart`). With the previous implementation, we actually sent 2 events, one for the result of the `commandPath` and another containing the `maxRss` value from `ProcessInfo`. I have consolidated this down to just one event and used a function to safely get the `maxRss` value, or return null when if there was an error getting that integer value
-
