- 14 Jul, 2018 6 commits
-
-
amirh authored
-
Jonah Williams authored
-
Greg Spencer authored
This uses @kevmoo's completion package to do command line completion for flutter, and a new command "bash-completion" (with alias "zsh-completion") that will output the necessary shell script setup code, and adds the hidden command "completion" that does the actual completion. Because it adds a dependency, I also had to do flutter update-packages --force-upgrade. Fixes #18988.
-
Jonah Williams authored
-
Jonah Williams authored
- 13 Jul, 2018 5 commits
-
-
xster authored
-
Jonah Williams authored
-
Hans Muller authored
-
Gary Miguel authored
This reverts commit e22f9974. Adding the exit(exitCode) fixes the hang. Tested by running `fx run-host-tests` with a topaz checkout. Verified the hang before, no hang after.
-
Jonah Williams authored
-
- 12 Jul, 2018 10 commits
-
-
Alexander Aprelev authored
Revert "Revert "Roll engine to fed2ea458ed49088d33eddabc546ba56d600c717 (includes dart roll) again (#19277)" (#19295)" (#19322) This reverts commit cc122f16.
-
Zachary Anderson authored
This reverts commit 032f8cdb. The test runner hangs on exit after all tests pass when trying to roll this into Fuchsia.
-
Alexander Aprelev authored
* Preserve original kernel file for isolate spawn requests. This change gives incremental kernel files ".incremental.dill" extension thereby preserving original kernel file. Bug: https://github.com/flutter/flutter/issues/16084 Bug: https://github.com/flutter/flutter/issues/17012 Bug: https://github.com/flutter/flutter/issues/17983 * Factor out naming logic into separate function * Fix string vs uri
-
Danny Tuppeny authored
* Allow a longer timeout for app launches * Include timings in errors when waiting for events * Extract a helper that adds a timeout and includes message logging * Ensure all timeouts include messages * Ensure logs are set up before we invoke actions * Ensure all messages are logged during timeout periods This adds a new stream _allMessages that collects all output (as routed through debugPrint) and updates _timeoutWithMessages to use that instead of stdin/out of only the flutter run process (since that was missing stdin - the sends, and both input/output to the VM service).
-
Danny Tuppeny authored
-
Hans Muller authored
-
Alexander Aprelev authored
Revert "Roll engine to fed2ea458ed49088d33eddabc546ba56d600c717 (includes dart roll) again (#19277)" (#19295) This reverts commit 700cb767 as it breaks Windows tests.
-
Alexander Aprelev authored
* Revert "Revert "Roll engine to fed2ea458ed49088d33eddabc546ba56d600c717 (includes dart roll) (#19044)" (#19276)" This reverts commit cf932490 as it also includes fix for type error that broke tests. * Add type cast for dart2 type checks. * Move up to latest goldens * Make inDirectory() type-parameterized. * Add typecasting to transitions_perf_test.dart and microbenchmarks. * Add boolean flag initialization in save_catalog_screenshots.dart * Add type conversion to gallery transition test
-
Chris Bracken authored
ios-deploy relies on LLDB.framework, which relies on /usr/bin/python and the 'six' module that's installed on the system. However, it appears to use the first version of Python on PATH, rather than explicitly specifying the system install. If a user has a custom install of Python (e.g., via Homebrew or MacPorts) ahead of the system Python on their PATH, LLDB.framework will pick up that version instead. If the user hasn't installed the 'six' module, ios-deploy will fail with a relatively cryptic error message. This patch pushes /usr/bin to the front of PATH for the duration of the ios-deploy run to avoid this scenario. This patch also removes checks for package six. Neither Flutter nor any of its direct dependencies/tooling relies on package six. ios-deploy depends on LLDB.framework (included with Xcode), which relies on a Python script that imports this package but uses whichever Python is at the front of the path. Flutter now invokes ios-deploy with a PATH with /usr/bin forced to the front in order to avoid this problem. We could have retained the check out of paranoia, but this seems unnecessary since it's entirely possible LLDB.framework may one day drop this dependency, in which case I'd expect the base system install of Python would likely drop it as well.
-
xster authored
-
- 11 Jul, 2018 9 commits
-
-
jslavitz authored
* Fixed codesign error message width * Fixed mac_test * Removed snackbar code
-
Ian Hickson authored
All slivers must start with Sliver (or CupertinoSliver). All widgets must have a key argument. Also, some minor tweaks here and there to style and docs.
-
Alexander Aprelev authored
Revert "Roll engine to fed2ea458ed49088d33eddabc546ba56d600c717 (includes dart roll) (#19044)" (#19276) This reverts commit f4a038da as it breaks microbenchmark tests.
-
Alexander Aprelev authored
* Roll engine to rolled dart Add connectionTimeout property to class that extends HttpOverrides. Upgrade packages. Add more type fixes. Update goldens hash. Add more type fixes. Upgrade packages. Fix tests. Remove strong-mode from analysis options yaml file. Increase dev/devicelab timeout from 2 to 10 seconds. Added getVM to waitForViews. Fix type errors in compileExpression. * Pick up engine revision with fix for microbenchmarks regression. Increase default timeout from 20/30 to 60s.
-
Michael Goderbauer authored
Instead, if the surface is 0x0 semantics will just generate one root semantics node with size of 0x0. The node will have no children because all children are invisible and (except for the root node with this change) invisible children are dropped.
-
shrike69 authored
-
Danny Tuppeny authored
Some things require a port (eg. `flutter attach`) and will forward it on to the device, so we shouldn't force clients to parse it out of a uri.
-
Greg Spencer authored
This adds a call to 'pub get' if the pubspec.yaml is out of date wrt the .packages file when a hot reload is requested. Fixes #15879
-
Alexander Aprelev authored
-
- 10 Jul, 2018 10 commits
-
-
Chris Bracken authored
…30)" Causes microbenchmarks to start failing. This included the following engine PR, which appears to be the culprit: * Remove vmservice_io.main from entry points. (flutter/engine#5625) This reverts commit 36437904.
-
Ian Hickson authored
They should fail, because we don't have real support yet. Also, make the debug override work in release builds, so that people on those platforms have a workaround.
-
Chris Bracken authored
Includes: * Remove vmservice_io.main from entry points. (flutter/engine#5625) * Roll src/third_party/skia 7e2327b133db..723b1f6ef941 (1 commits) (flutter/engine#5642) * Roll src/third_party/skia 24d18ced1ad7..7e2327b133db (6 commits) (flutter/engine#5641) * Roll src/third_party/skia a1e5630183c1..24d18ced1ad7 (7 commits) (flutter/engine#5639)
-
liyuqian authored
This should fix #18952 and #813
-
Chris Bracken authored
* ensure a11y state is communicated back to flutter (flutter/engine#5631) * Roll src/third_party/skia b1b87d9df81e..a1e5630183c1 (10 commits) (flutter/engine#5637) * Roll src/third_party/skia 385804514edf..b1b87d9df81e (6 commits) (flutter/engine#5636) * Roll src/third_party/skia e97bb26893a1..385804514edf (1 commits) (flutter/engine#5635) * Roll src/third_party/skia e2e52e46ca63..e97bb26893a1 (1 commits) (flutter/engine#5634) * Roll src/third_party/skia 14de25dfc7c4..e2e52e46ca63 (2 commits) (flutter/engine#5633) * Roll src/third_party/skia 551dc3e91143..14de25dfc7c4 (2 commits) (flutter/engine#5630) * libtxt: apply an offset to drawing operations instead of translating the canvas (flutter/engine#5628) * Roll src/third_party/skia 059a9ab4bcd0..551dc3e91143 (5 commits) (flutter/engine#5629) * Roll src/third_party/skia 45c9dab4c3ec..059a9ab4bcd0 (8 commits) (flutter/engine#5627) * Remove some unused code from the Android host (flutter/engine#5619) * Roll src/third_party/skia 37b7e4714558..45c9dab4c3ec (1 commits) (flutter/engine#5626) * Roll src/third_party/skia c421ca1d6e41..37b7e4714558 (2 commits) (flutter/engine#5624) * Roll src/third_party/skia 5b201e3b0ba8..c421ca1d6e41 (3 commits) (flutter/engine#5623) * Roll src/third_party/skia d47fe095cf88..5b201e3b0ba8 (6 commits) (flutter/engine#5622) * Roll src/third_party/skia 9c0ce41cf711..d47fe095cf88 (12 commits) (flutter/engine#5618 * Roll src/third_party/skia d4b2adeaa929..9c0ce41cf711 (7 commits) (flutter/engine#5617) * Roll src/third_party/skia f46710802ad5..d4b2adeaa929 (1 commits) (flutter/engine#5616)
-
Chris Bracken authored
This appears to trigger an error during AOT snapshot of the gallery as follows: ``` stdout: [ +6 ms] Building AOT snapshot in release mode (ios-release)... stdout: [ +15 ms] Extra gen_snapshot options: [--print_snapshot_sizes] stdout: [ +7 ms] /usr/bin/arch -x86_64 /Users/flutter/.cocoon/flutter/bin/cache/artifacts/engine/ios-release/gen_snapshot --await_is_keyword --causal_async_stacks --packages=.packages --url_mapping=dart:ui,/Users/flutter/.cocoon/flutter/bin/cache/pkg/sky_engine/lib/ui/ui.dart --url_mapping=dart:vmservice_io,/Users/flutter/.cocoon/flutter/bin/cache/pkg/sky_engine/sdk_ext/vmservice_io.dart --embedder_entry_points_manifest=/Users/flutter/.cocoon/flutter/bin/cache/artifacts/engine/ios-release/dart_vm_entry_points.txt --embedder_entry_points_manifest=/Users/flutter/.cocoon/flutter/bin/cache/artifacts/engine/ios-release/dart_io_entries.txt --print_snapshot_sizes --snapshot_kind=app-aot-assembly --assembly=build/aot/arm64/snapshot_assembly.S /Users/flutter/.cocoon/flutter/examples/flutter_gallery/lib/main.dart stderr: [+9324 ms] Error: 'file:///Users/flutter/.cocoon/flutter/examples/flutter_gallery/lib/demo/cupertino/cupertino_segmented_control_demo.dart': error: line 19 pos 1: circular dependency for function _CupertinoSegmentedControlDemoState stderr: [ ] class _CupertinoSegmentedControlDemoState extends State { stderr: [ ] ^ stderr: [ +33 ms] Dart snapshot generator failed with exit code 254 stderr: [ ] Snapshotting (IOSArch.arm64) exited with non-zero exit code: 254 stdout: [ ] Built to build/aot/. stdout: [ +10 ms] "flutter aot" took 9,485ms. ``` This reverts commit 9d49ee3b.
-
Natalie Sampsell authored
* Adding segmented control to gallery
-
Leaf Petersen authored
* Fix use of Future<void> as a Future<bool>
-
Danny Tuppeny authored
This should make it more obvious from the error what's gone wrong if we see a repeat of #19096 (previously the error was something like "Bad state: future already completed").
-
Danny Tuppeny authored
* Rename util -> test_utils * Rename flutter_test_driver -> test_driver * Switch testWithContext -> test * Remove unused import * Move test project into a class to make it easier to have multiple of these Each "TestProject" class can contain its files and things like named breakpoint locations. * Split expression evaluation tests into own file * Include last response in error messages * Update expectations based on current bugs * Fix async-ness in tests * Fix incorrect expectation in test * Fix incorrect evaluations * Remove skips for tests that are now passing on master * Expect pass on Linux
🤷 ♂️ * Call the code * Skip expression evaluation tests on Windows * Skip whole group, not just one test * Remove duplicated method from merge * Fix misplaced close of group * Remove code that was duplicated from test we copied Not sure how this ended up in here? * Re-fix typo
-