Commits · e127f7191bc6a8d50a89e4a9f44d1448835d6fa5 · abdullh.alsoleman / Front-End

09 Oct, 2023 16 commits

[web] Fix `page up` `page down` `home` `end` shortcut behavior on web (#135454) · e127f719

Hassan authored Oct 09, 2023

We delegate page up / page down actions to the browser. However, we don't let the browser scroll the underlying `<textarea>` - the framework handles scrolling, so page up/down don't end up doing anything. Since the framework handles scrolling for text inputs and textareas, we should let it also handle the actions for `page up`, `page down`, `home`, `end`, and their modifiers. 

fixes https://github.com/flutter/flutter/issues/121867

e127f719

Update `MediaQuery` documentation to highlight asynchronous nature of size (#135719) · a5e3e785

Greg Spencer authored Oct 09, 2023

## Description

This updates the documentation for `MediaQuery` and `Overlay` to include the following:

- That `MediaQueryData.size` is set asynchronously, and doesn't necessarily reflect the size of the current frame.
- That the specific `MediaQuery.sizeOf` and related methods are preferred over the more generic `MediaQuery.of`.
- That the size of the `Overlay` isn't necessarily the size returned by `MediaQueryData.size`

As well as adding some symbol links, and fixing some error in documentation.

## Tests
 - Documentation only

a5e3e785

Reland "Adds a parent scope TraversalEdgeBehavior and fixes modal rou… (#134554) · ff73448f

chunhtai authored Oct 09, 2023

…… (#134550)"

fixes https://github.com/flutter/flutter/issues/112567

This reverts commit 5900c4ba.

The internal test needs migration. cl/564746935

This is the same of original pr, no new change

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

ff73448f

Roll Flutter Engine from 429a242b0db6 to 22ce5c6a45e2 (1 revision) (#136205) · 51f1a464

engine-flutter-autoroll authored Oct 09, 2023

https://github.com/flutter/engine/compare/429a242b0db6...22ce5c6a45e2

2023-10-09 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from nN0l08yRbt0zE3R7a... to YDaOfbTjc-WMEZXZx... (flutter/engine#46675)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from nN0l08yRbt0z to YDaOfbTjc-WM

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

51f1a464

Roll Packages from e578a16580c7 to 7de08ecd1cba (4 revisions) (#136202) · 44f936f3

engine-flutter-autoroll authored Oct 09, 2023

https://github.com/flutter/packages/compare/e578a16580c7...7de08ecd1cba

2023-10-09 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.9 to 2.22.0 (flutter/packages#5092)
2023-10-09 nbosch@google.com Add a `skip` to an empty test group (flutter/packages#5080)
2023-10-07 engine-flutter-autoroll@skia.org Roll Flutter from ad200896 to 5207a309 (20 revisions) (flutter/packages#5086)
2023-10-06 engine-flutter-autoroll@skia.org Roll Flutter from fe0275f9 to ad200896 (10 revisions) (flutter/packages#5084)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

44f936f3

Roll Flutter Engine from 664f5e833871 to 429a242b0db6 (2 revisions) (#136201) · 44540105

engine-flutter-autoroll authored Oct 09, 2023

https://github.com/flutter/engine/compare/664f5e833871...429a242b0db6

2023-10-09 skia-flutter-autoroll@skia.org Roll Dart SDK from a88ed8cafd27 to a6e43b0b9e0c (1 revision) (flutter/engine#46674)
2023-10-09 skia-flutter-autoroll@skia.org Roll Skia from 3b83cd44d9ee to c5541e2bd213 (2 revisions) (flutter/engine#46673)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

44540105

[leak-tracking] Add leak tracking in test/painting #2 (#136169) · f52fe4f7
droidbg authored Oct 09, 2023

f52fe4f7

Roll Flutter Engine from 2886353ee612 to 664f5e833871 (1 revision) (#136195) · 6dce1425

engine-flutter-autoroll authored Oct 09, 2023

https://github.com/flutter/engine/compare/2886353ee612...664f5e833871

2023-10-09 skia-flutter-autoroll@skia.org Roll Skia from 871c976c0ecc to 3b83cd44d9ee (1 revision) (flutter/engine#46669)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6dce1425

Fix `flutter drive` instructions in `Macrobenchmark` README (#135990) · e5d45753
Taha Tesser authored Oct 09, 2023
```
fixes [Macrobenchmark `README.md` is out-of-date](https://github.com/flutter/flutter/issues/132703)
```
e5d45753
Update `CircleAvatar` & `DataTable` tests for Material 3 (#135901) · 9ab091f9
Taha Tesser authored Oct 09, 2023
```
Updated unit tests for `CircleAvatar` & `DataTable` to have M2 and M3 versions.

More info in #127064
```
9ab091f9

Roll Flutter Engine from 69ffbd18ab5e to 2886353ee612 (1 revision) (#136187) · c899ce3e

engine-flutter-autoroll authored Oct 09, 2023

https://github.com/flutter/engine/compare/69ffbd18ab5e...2886353ee612

2023-10-09 skia-flutter-autoroll@skia.org Roll Skia from 9fd74b688561 to 871c976c0ecc (1 revision) (flutter/engine#46666)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c899ce3e

Roll Flutter Engine from 53da096c0c38 to 69ffbd18ab5e (2 revisions) (#136186) · b6d8b4cd

engine-flutter-autoroll authored Oct 09, 2023

https://github.com/flutter/engine/compare/53da096c0c38...69ffbd18ab5e

2023-10-09 skia-flutter-autoroll@skia.org Roll Skia from c844143823fb to 9fd74b688561 (1 revision) (flutter/engine#46665)
2023-10-09 skia-flutter-autoroll@skia.org Roll Skia from 0507cc73ca2a to c844143823fb (1 revision) (flutter/engine#46664)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b6d8b4cd

Roll Flutter Engine from e58a9b3c54b6 to 53da096c0c38 (2 revisions) (#136182) · 6ddeec2a

engine-flutter-autoroll authored Oct 09, 2023

https://github.com/flutter/engine/compare/e58a9b3c54b6...53da096c0c38

2023-10-09 skia-flutter-autoroll@skia.org Roll Skia from fedfbe6383f0 to 0507cc73ca2a (1 revision) (flutter/engine#46663)
2023-10-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from TTQty3yF7hRg2UFT8... to 0ObCmDD14Cel45cU-... (flutter/engine#46662)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from TTQty3yF7hRg to 0ObCmDD14Cel

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6ddeec2a

Update BottomSheet test for M3 + fix an issue in elevation resolution (#136071) · a6d71249

Bruno Leroux authored Oct 09, 2023

This PR updates unit tests from bottom sheet tests for M3 migration.

More info in https://github.com/flutter/flutter/issues/127064

It also contains in bottom_sheet.dart where a default value took precedence over a theme attribute.

a6d71249

Roll Flutter Engine from 7b8f5d4297c6 to e58a9b3c54b6 (1 revision) (#136175) · e27dc0a3

engine-flutter-autoroll authored Oct 09, 2023

https://github.com/flutter/engine/compare/7b8f5d4297c6...e58a9b3c54b6

2023-10-09 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from gaFsjQCR8UjK8EX-b... to nN0l08yRbt0zE3R7a... (flutter/engine#46661)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from gaFsjQCR8UjK to nN0l08yRbt0z

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e27dc0a3

Roll Flutter Engine from d5485d67b9f9 to 7b8f5d4297c6 (1 revision) (#136168) · ef5b2092

engine-flutter-autoroll authored Oct 09, 2023

https://github.com/flutter/engine/compare/d5485d67b9f9...7b8f5d4297c6

2023-10-08 skia-flutter-autoroll@skia.org Roll Skia from ac67f4882568 to fedfbe6383f0 (1 revision) (flutter/engine#46660)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ef5b2092

08 Oct, 2023 5 commits

Roll Flutter Engine from 34ffdf06ca93 to d5485d67b9f9 (1 revision) (#136158) · 10a128de

engine-flutter-autoroll authored Oct 08, 2023

https://github.com/flutter/engine/compare/34ffdf06ca93...d5485d67b9f9

2023-10-08 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 8ri3ggb_SASX6KpNn... to TTQty3yF7hRg2UFT8... (flutter/engine#46659)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 8ri3ggb_SASX to TTQty3yF7hRg

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

10a128de

Roll Flutter Engine from 0785e3c69f7c to 34ffdf06ca93 (1 revision) (#136156) · f9ee41e7

engine-flutter-autoroll authored Oct 08, 2023

https://github.com/flutter/engine/compare/0785e3c69f7c...34ffdf06ca93

2023-10-08 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from qf94AgyANg4i0Supy... to gaFsjQCR8UjK8EX-b... (flutter/engine#46658)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from qf94AgyANg4i to gaFsjQCR8UjK

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f9ee41e7

Roll Flutter Engine from 03c8c7724873 to 0785e3c69f7c (2 revisions) (#136150) · 901077bf

engine-flutter-autoroll authored Oct 08, 2023

https://github.com/flutter/engine/compare/03c8c7724873...0785e3c69f7c

2023-10-08 skia-flutter-autoroll@skia.org Roll Skia from a04f2cfaf4d4 to ac67f4882568 (1 revision) (flutter/engine#46657)
2023-10-08 skia-flutter-autoroll@skia.org Roll Skia from 3d77b5de5984 to a04f2cfaf4d4 (1 revision) (flutter/engine#46656)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

901077bf

Roll Flutter Engine from eb88bb5b5c4b to 03c8c7724873 (1 revision) (#136147) · edf6625d

engine-flutter-autoroll authored Oct 08, 2023

https://github.com/flutter/engine/compare/eb88bb5b5c4b...03c8c7724873

2023-10-08 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from nX88TgPdoM6PK1wBq... to 8ri3ggb_SASX6KpNn... (flutter/engine#46655)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from nX88TgPdoM6P to 8ri3ggb_SASX

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

edf6625d

Roll Flutter Engine from 46b05f69187d to eb88bb5b5c4b (1 revision) (#136145) · 0fef7a5e

engine-flutter-autoroll authored Oct 08, 2023

https://github.com/flutter/engine/compare/46b05f69187d...eb88bb5b5c4b

2023-10-08 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from NRLsjEUCmIz2f1Wox... to qf94AgyANg4i0Supy... (flutter/engine#46654)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from NRLsjEUCmIz2 to qf94AgyANg4i

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0fef7a5e

07 Oct, 2023 11 commits

Roll Flutter Engine from a18c52768bbc to 46b05f69187d (1 revision) (#136142) · a672b016

engine-flutter-autoroll authored Oct 07, 2023

https://github.com/flutter/engine/compare/a18c52768bbc...46b05f69187d

2023-10-07 skia-flutter-autoroll@skia.org Roll Skia from 99d9d571f4dd to 3d77b5de5984 (1 revision) (flutter/engine#46653)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a672b016

Roll Flutter Engine from 8711c1fd2191 to a18c52768bbc (6 revisions) (#136141) · 7008520d

engine-flutter-autoroll authored Oct 07, 2023

https://github.com/flutter/engine/compare/8711c1fd2191...a18c52768bbc

2023-10-07 jonahwilliams@google.com [Impeller] Add IMPELLER_DEBUG around group. (flutter/engine#46642)
2023-10-07 skia-flutter-autoroll@skia.org Roll Skia from 6ce883877068 to 99d9d571f4dd (1 revision) (flutter/engine#46652)
2023-10-07 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from a-BbzDtY3w8UXYgbK... to nX88TgPdoM6PK1wBq... (flutter/engine#46651)
2023-10-07 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from GXgrnmetc14RPdheo... to NRLsjEUCmIz2f1Wox... (flutter/engine#46649)
2023-10-07 skia-flutter-autoroll@skia.org Roll Skia from 15de5cc6a095 to 6ce883877068 (1 revision) (flutter/engine#46648)
2023-10-07 skia-flutter-autoroll@skia.org Roll Dart SDK from 7ba556c43d35 to a88ed8cafd27 (1 revision) (flutter/engine#46647)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from a-BbzDtY3w8U to nX88TgPdoM6P
fuchsia/sdk/core/mac-amd64 from GXgrnmetc14R to NRLsjEUCmIz2

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7008520d

Allow leaks around tap down/up, while flackiness is not fixed. (#136133) · 74f8b4f7
Polina Cherkasova authored Oct 07, 2023

74f8b4f7

Roll Flutter Engine from 40024059b09e to 8711c1fd2191 (1 revision) (#136110) · 5207a309

engine-flutter-autoroll authored Oct 07, 2023

https://github.com/flutter/engine/compare/40024059b09e...8711c1fd2191

2023-10-07 skia-flutter-autoroll@skia.org Roll Dart SDK from 46bad70d0f7e to 7ba556c43d35 (1 revision) (flutter/engine#46645)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5207a309

Roll Flutter Engine from eaac056b63a4 to 40024059b09e (1 revision) (#136108) · 2e90a247

engine-flutter-autoroll authored Oct 07, 2023

https://github.com/flutter/engine/compare/eaac056b63a4...40024059b09e

2023-10-07 skia-flutter-autoroll@skia.org Roll Skia from 2f67f1f18562 to 15de5cc6a095 (1 revision) (flutter/engine#46644)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2e90a247

Roll Flutter Engine from f71778651333 to eaac056b63a4 (1 revision) (#136107) · 50f1afe5

engine-flutter-autoroll authored Oct 07, 2023

https://github.com/flutter/engine/compare/f71778651333...eaac056b63a4

2023-10-07 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from K7K76tME-CSGhYlFm... to a-BbzDtY3w8UXYgbK... (flutter/engine#46641)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from K7K76tME-CSG to a-BbzDtY3w8U

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

50f1afe5

bottom_sheet: Clarify doc about behavior when useSafeArea is false (#134793) · a88a2503

Chris Bobbe authored Oct 07, 2023

As discussed at https://github.com/flutter/flutter/pull/122225#issuecomment-1690729628, this is a docs change meant to help people in the absence of a fix for #121752, which is being closed as WONTFIX.

a88a2503

Roll Flutter Engine from 356ab2a54862 to f71778651333 (1 revision) (#136106) · 77779d36

engine-flutter-autoroll authored Oct 07, 2023

https://github.com/flutter/engine/compare/356ab2a54862...f71778651333

2023-10-07 skia-flutter-autoroll@skia.org Roll Dart SDK from 368fd3846df0 to 46bad70d0f7e (7 revisions) (flutter/engine#46639)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

77779d36

Roll Flutter Engine from 1f79667fb860 to 356ab2a54862 (1 revision) (#136104) · 8b9d52bb

engine-flutter-autoroll authored Oct 07, 2023

https://github.com/flutter/engine/compare/1f79667fb860...356ab2a54862

2023-10-06 skia-flutter-autoroll@skia.org Roll Skia from d86da2a029d8 to 2f67f1f18562 (36 revisions) (flutter/engine#46636)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8b9d52bb

Simplify assertion in `AsyncSnapshot` (#135899) · dcd24ef0
Mateus Felipe C. C. Pinto authored Oct 07, 2023
```
Simplify assertion in `AsyncSnapshot`.

Fixes #135731.
```
dcd24ef0

Roll Flutter Engine from b28032c157ee to 1f79667fb860 (1 revision) (#136103) · 90ea6eef

engine-flutter-autoroll authored Oct 07, 2023

https://github.com/flutter/engine/compare/b28032c157ee...1f79667fb860

2023-10-06 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 14dOVccxXOO5RPJJB... to GXgrnmetc14RPdheo... (flutter/engine#46634)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 14dOVccxXOO5 to GXgrnmetc14R

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

90ea6eef

06 Oct, 2023 8 commits

Roll Flutter Engine from 7bf93bb919d9 to b28032c157ee (1 revision) (#136101) · e3ef94bc

engine-flutter-autoroll authored Oct 06, 2023

https://github.com/flutter/engine/compare/7bf93bb919d9...b28032c157ee

2023-10-06 skia-flutter-autoroll@skia.org Roll Skia from 0f2af25f15ee to d86da2a029d8 (7 revisions) (flutter/engine#46587)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e3ef94bc

Roll Flutter Engine from eb5d5c66a83e to 7bf93bb919d9 (2 revisions) (#136098) · 58b47f92

engine-flutter-autoroll authored Oct 06, 2023

https://github.com/flutter/engine/compare/eb5d5c66a83e...7bf93bb919d9

2023-10-06 aam@google.com [fuchsia] Remove hardcoded fuchsia-imported packages 2.12 sdk version (flutter/engine#46629)
2023-10-06 kjlubick@users.noreply.github.com Add Base64::EncodedSize to tidy up allocations (flutter/engine#46624)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

58b47f92

[Windows] Add first Arm64 plugin tests (#135512) · 39b9d8fd

Loïc Sharma authored Oct 06, 2023

Part of: https://github.com/flutter/flutter/issues/129806

Test runs kicked off using `led`:
* â [plugin_test_windows](https://ci.chromium.org/raw/build/logs.chromium.org/flutter/led/loicsharma_google.com/277ffb2c7bdaad579b7598706ebc4009797211bea6b3fd175f0a2e9ad8fe03b1/+/build.proto?server=chromium-swarm.appspot.com)
* â ï¸ [plugin_test](https://ci.chromium.org/raw/build/logs.chromium.org/flutter/led/loicsharma_google.com/c9daccd5b3c6b33763fdb36da30cd55949c7e98539041726bd659d19e1d49112/+/build.proto?server=chromium-swarm.appspot.com) - This test fails as no existing Windows Arm64 builder install the `android_sdk` and `open_jdk` dependencies

I will add `plugin_dependencies_test` and `gradle_plugin_bundle_test` in a follow-up pull request. These tests also depend on `android_sdk` and `open_jdk`, I'll be able to test them manually using the new `plugin_test` builder added by this pull request. 

/cc @pbo-linaro

39b9d8fd

Roll Flutter Engine from 1bb228dfedfa to eb5d5c66a83e (2 revisions) (#136094) · e1308e1f

engine-flutter-autoroll authored Oct 06, 2023

https://github.com/flutter/engine/compare/1bb228dfedfa...eb5d5c66a83e

2023-10-06 jonahwilliams@google.com [Impeller] Ensure known geometry has simple bounds computation. (flutter/engine#46623)
2023-10-06 jonahwilliams@google.com [Impeller] Refactor CapabilitiesGLES into a Capabilties. (flutter/engine#46621)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e1308e1f

Bump github/codeql-action from 2.21.6 to 2.22.0 (#136095) · bc315144

dependabot[bot] authored Oct 06, 2023

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.21.6 to 2.22.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>2.22.0 - 06 Oct 2023</h2>
<ul>
<li>The CodeQL Action now requires CodeQL version 2.10.5 or later. For more information, see the corresponding changelog entry for CodeQL Action version 2.21.8. <a href="https://redirect.github.com/github/codeql-action/pull/1907">#1907</a></li>
<li>The CodeQL Action no longer runs ML-powered queries. For more information, including details on our investment in AI-powered security technology, see <a href="https://github.blog/changelog/2023-09-29-codeql-code-scanning-deprecates-ml-powered-alerts/">&quot;CodeQL code scanning deprecates ML-powered alerts.&quot;</a> <a href="https://redirect.github.com/github/codeql-action/pull/1910">#1910</a></li>
<li>Fix a bug which prevented tracing of projects using Go 1.21 and above on Linux. <a href="https://redirect.github.com/github/codeql-action/pull/1909">#1909</a></li>
</ul>
<h2>2.21.9 - 27 Sep 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.14.6. <a href="https://redirect.github.com/github/codeql-action/pull/1897">#1897</a></li>
<li>We are rolling out a feature in October 2023 that will improve the success rate of C/C++ autobuild. <a href="https://redirect.github.com/github/codeql-action/pull/1889">#1889</a></li>
<li>We are rolling out a feature in October 2023 that will provide specific file coverage information for C and C++, Java and Kotlin, and JavaScript and TypeScript. Currently file coverage information for each of these pairs of languages is grouped together. <a href="https://redirect.github.com/github/codeql-action/pull/1903">#1903</a></li>
<li>Add a warning to help customers avoid inadvertently analyzing the same CodeQL language in multiple matrix jobs. <a href="https://redirect.github.com/github/codeql-action/pull/1901">#1901</a></li>
</ul>
<h2>2.21.8 - 19 Sep 2023</h2>
<ul>
<li>Add a deprecation warning for customers using CodeQL version 2.10.4 and earlier. These versions of CodeQL were discontinued on 12 September 2023 alongside GitHub Enterprise Server 3.6, and will be unsupported by the next minor release of the CodeQL Action. <a href="https://redirect.github.com/github/codeql-action/pull/1884">#1884</a>
<ul>
<li>If you are using one of these versions, please update to CodeQL CLI version 2.10.5 or later. For instance, if you have specified a custom version of the CLI using the 'tools' input to the 'init' Action, you can remove this input to use the default version.</li>
<li>Alternatively, if you want to continue using a version of the CodeQL CLI between 2.9.5 and 2.10.4, you can replace <code>github/codeql-action/*@v2</code> by <code>github/codeql-action/*@v2.21.7</code> in your code scanning workflow to ensure you continue using this version of the CodeQL Action.</li>
</ul>
</li>
<li>Enable the following language aliases when using CodeQL 2.14.4 and later: <code>c-cpp</code> for C/C++ analysis, <code>java-kotlin</code> for Java/Kotlin analysis, and <code>javascript-typescript</code> for JavaScript/TypeScript analysis. <a href="https://redirect.github.com/github/codeql-action/pull/1883">#1883</a></li>
</ul>
<h2>2.21.7 - 14 Sep 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.14.5. <a href="https://redirect.github.com/github/codeql-action/pull/1882">#1882</a></li>
</ul>
<h2>2.21.6 - 13 Sep 2023</h2>
<ul>
<li>Better error message when there is a failure to determine the merge base of the code to analysis. <a href="https://redirect.github.com/github/codeql-action/pull/1860">#1860</a></li>
<li>Improve the calculation of default amount of RAM used for query execution on GitHub Enterprise Server. This now reduces in proportion to the runner's total memory to better account for system memory usage, helping to avoid out-of-memory failures on larger runners. This feature is already available to GitHub.com users. <a href="https://redirect.github.com/github/codeql-action/pull/1866">#1866</a></li>
<li>Enable improved file coverage information for GitHub Enterprise Server users. This feature is already available to GitHub.com users. <a href="https://redirect.github.com/github/codeql-action/pull/1867">#1867</a></li>
<li>Update default CodeQL bundle version to 2.14.4. <a href="https://redirect.github.com/github/codeql-action/pull/1873">#1873</a></li>
</ul>
<h2>2.21.5 - 28 Aug 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.14.3. <a href="https://redirect.github.com/github/codeql-action/pull/1845">#1845</a></li>
<li>Fixed a bug in CodeQL Action 2.21.3 onwards that affected beta support for <a href="https://projectlombok.org/">Project Lombok</a> when analyzing Java. The environment variable <code>CODEQL_EXTRACTOR_JAVA_RUN_ANNOTATION_PROCESSORS</code> will now be respected if it was manually configured in the workflow. <a href="https://redirect.github.com/github/codeql-action/pull/1844">#1844</a></li>
<li>Enable support for Kotlin 1.9.20 when running with CodeQL CLI v2.13.4 through v2.14.3. <a href="https://redirect.github.com/github/codeql-action/pull/1853">#1853</a></li>
</ul>
<h2>2.21.4 - 14 Aug 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.14.2. <a href="https://redirect.github.com/github/codeql-action/pull/1831">#1831</a></li>
<li>Log a warning if the amount of available disk space runs low during a code scanning run. <a href="https://redirect.github.com/github/codeql-action/pull/1825">#1825</a></li>
<li>When downloading CodeQL bundle version 2.13.4 and later, cache these bundles in the Actions tool cache using a simpler version number. <a href="https://redirect.github.com/github/codeql-action/pull/1832">#1832</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/2cb752a87e96af96708ab57187ab6372ee1973ab"><code>2cb752a</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1924">#1924</a> from github/update-v2.22.0-3f7850a17</li>
<li><a href="https://github.com/github/codeql-action/commit/e50f53baa18da7571fefe4e56edeba46be9f183b"><code>e50f53b</code></a> Add changelog note for tracing Go 1.21</li>
<li><a href="https://github.com/github/codeql-action/commit/0a65c007f6b702f7d53f89a44248406aae709942"><code>0a65c00</code></a> Update changelog for v2.22.0</li>
<li><a href="https://github.com/github/codeql-action/commit/3f7850a17964ee76fbc058c4cf3360bfd6840486"><code>3f7850a</code></a> Improve downloading log message (<a href="https://redirect.github.com/github/codeql-action/issues/1920">#1920</a>)</li>
<li><a href="https://github.com/github/codeql-action/commit/27235304e07da3d62be5a72ef5df0f30d8a4e137"><code>2723530</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1923">#1923</a> from github/henrymercer/fix-resolve-environment-aliases</li>
<li><a href="https://github.com/github/codeql-action/commit/8f0e8b0890952ad94f9d4f1a44170b0f27723054"><code>8f0e8b0</code></a> Tweak language parsing to improve clarity</li>
<li><a href="https://github.com/github/codeql-action/commit/f243294ab74b285a547a838884ca660a740ce2a6"><code>f243294</code></a> Extend PR check to test <code>resolve-environment</code> works with language alias</li>
<li><a href="https://github.com/github/codeql-action/commit/1ea6a10947dbce58fd4e0ff685cdec23e7f50145"><code>1ea6a10</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1909">#1909</a> from github/mbg/go-1.21-workaround</li>
<li><a href="https://github.com/github/codeql-action/commit/e26ed57a228512338332f937ef0f121a739d548c"><code>e26ed57</code></a> Defer language aliasing to CLI when appropriate</li>
<li><a href="https://github.com/github/codeql-action/commit/0ac7669167fa236dc2e1eec93d82674b1a265327"><code>0ac7669</code></a> Fix using <code>resolve-environment</code> Action with language aliases</li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/701f152f28d4350ad289a5e31435e9ab6169a7ca...2cb752a87e96af96708ab57187ab6372ee1973ab">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=2.21.6&new-version=2.22.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

bc315144

Call `markNeedsPaint` when adding overlayChild to `Overlay` (#135941) · ebe72d3f

LongCatIsLooong authored Oct 06, 2023

Fixes https://github.com/flutter/flutter/issues/134656

`_skipMarkNeesLayout` was meant to only skip `markNeedsLayout` calls. Re-painting is still needed when a child gets added/removed from the `Overlay`.

ebe72d3f

Revert "Marks Linux_samsung_a02 new_gallery__transition_perf to be unflaky" (#136097) · 68d47e55
Zachary Anderson authored Oct 06, 2023
```
Reverts flutter/flutter#135566
```
68d47e55

Marks Linux_samsung_a02 new_gallery__transition_perf to be unflaky (#135566) · 420ec92e

Flutter GitHub Bot authored Oct 06, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_samsung_a02 new_gallery__transition_perf"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_samsung_a02%20new_gallery__transition_perf%22).
This test can be marked as unflaky.

420ec92e