- 05 Mar, 2024 6 commits
-
-
Matej Knopp authored
Previously the name was shortened to 15 characters, which doesn't seem to be necessary. [CFBundleName](https://developer.apple.com/documentation/bundleresources/information_property_list/cfbundlename) documentation mentions 15 character length, but that does not seem to be relevant to framework bundles. Flutter plugins already have framework bundles with names longer than 15 characters and it is not causing any issues. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat [Data Driven Fixes]: https://github.com/flutter/flutter/wiki/Data-driven-Fixes
-
Bruno Leroux authored
## Description This PR makes `CupertinoTextFormFieldRow` restorable. The implementation is based on https://github.com/flutter/flutter/pull/78835 which made `FormField` and `TextFormField` restorable. ## Related Issue Fixes https://github.com/flutter/flutter/issues/144504. ## Tests Adds 4 tests.
-
Hans Muller authored
Updated the "smiley" TextButton example with new images from Nancy Hu @google. I also made the example a little more complicated, per the new artwork: now it displays a different image while the button's action pretends to run for a second. https://github.com/flutter/flutter/assets/1377460/b631a484-4b4f-4e01-ad52-a877fb46ef72
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/728aa4ef05d4...d514a302cdff 2024-03-04 jason-simmons@users.noreply.github.com [Impeller] Fix string comparison in MockGLES.CanInitialize test (flutter/engine#51181) 2024-03-04 34871572+gmackall@users.noreply.github.com [Re-land] Remove WindowManager reflection in SingleViewPresentation.java (flutter/engine#50890) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/62cf93be60b2...728aa4ef05d4 2024-03-04 ianloic@google.com [fuchsia] Prepare for @transitional removal (flutter/engine#51185) 2024-03-04 skia-flutter-autoroll@skia.org Roll Skia from 9ab297bf1c34 to 9c62e7b382cf (1 revision) (flutter/engine#51182) 2024-03-04 skia-flutter-autoroll@skia.org Roll Skia from f65ecbdfb09c to 9ab297bf1c34 (4 revisions) (flutter/engine#51178) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Jonah Williams authored
Until we figure out why this is unstable on Impeller swiftshader, disable it.
-
- 04 Mar, 2024 17 commits
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/40018811ec0e...62cf93be60b2 2024-03-04 bdero@google.com [Impeller] Fix the clip replay mechanism. (flutter/engine#51173) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/0d8588b1de7a...40018811ec0e 2024-03-04 matej.knopp@gmail.com Reland: [macOS] Use CVDisplayLink to drive repaint (flutter/engine#51126) 2024-03-04 jason-simmons@users.noreply.github.com Support gtest-parallel when running Impeller unit tests (flutter/engine#51079) 2024-03-04 matanlurey@users.noreply.github.com Scenario App: Adds a `run_{count}.{backend}.` file prefix to every run (on CI) (flutter/engine#51102) 2024-03-04 matanlurey@users.noreply.github.com Use Instrumentation.waitForIdleSync() after rotation requests. (flutter/engine#51169) 2024-03-04 skia-flutter-autoroll@skia.org Roll Skia from 9c7d13c05e77 to f65ecbdfb09c (1 revision) (flutter/engine#51170) 2024-03-04 dnfield@google.com Guard against API 22 (flutter/engine#51167) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Jenn Magder authored
Explicitly handle the case where the iOS device is not paired. On `flutter run` show an error and bail instead of trying and failing to launch on the device. On this PR: ``` $ flutter run -d 00008110-0009588C2651401E 'iPhone' is not paired. Open Xcode and trust this computer when prompted. $ ``` Fixes https://github.com/flutter/flutter/issues/144447 Closes https://github.com/flutter/flutter/pull/144095
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/a31209171949...0d8588b1de7a 2024-03-04 30870216+gaaclarke@users.noreply.github.com [Impeller] implements blur styles inner and outer (flutter/engine#51018) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
LongCatIsLooong authored
Nobody calls it except for `markNeedsLayout`, and the render object is a guaranteed relayout boundary.
-
Bruno Leroux authored
## Description This PR fix the text color for the default action in a CupertiniContextMenu. Previously the dynamic color was not resolved which leads to text being blacks when theme brightness was dark. | Before | After | |--------|--------| | ![Capture dâeÌcran 2024-03-04 aÌ 14 58 45](https://github.com/flutter/flutter/assets/840911/6a06715d-b2b8-49e1-b6de-37c03b96b627) | ![Capture dâeÌcran 2024-03-04 aÌ 15 00 27](https://github.com/flutter/flutter/assets/840911/ed7c71ec-96f2-46ca-a5f6-ba3890732e33) | ## Related Issue Fixes https://github.com/flutter/flutter/issues/144492. ## Tests Adds 1 test, updates 1.
-
Nate authored
Originally, my aim was just to refactor (as per usual), but while messing around with the `TableBorder.symmetric` constructor, I realized that `borderRadius` was missing! This pull request makes a few class constructors more efficient, and it fixes #144277 by adding the missing parameter. <br>
-
Matej Knopp authored
This fixes bug where build mode is hardcoded to debug while building native assets for Android. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat [Data Driven Fixes]: https://github.com/flutter/flutter/wiki/Data-driven-Fixes
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/a9c68b83356b...06258277070f 2024-03-02 engine-flutter-autoroll@skia.org Roll Flutter from ba719bc5 to 65cd84b5 (5 revisions) (flutter/packages#6239) 2024-03-01 engine-flutter-autoroll@skia.org Roll Flutter from e92bca3f to ba719bc5 (37 revisions) (flutter/packages#6235) 2024-03-01 sergeydesenko@gmail.com [camera_avfoundation] Set highest available resolution for ResolutionPreset.Max (flutter/packages#5245) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/afd2d9f9421d...a31209171949 2024-03-04 skia-flutter-autoroll@skia.org Roll Skia from ff3199348aab to 9c7d13c05e77 (5 revisions) (flutter/engine#51168) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Qun Cheng authored
Fixes https://github.com/flutter/flutter/issues/144135 This PR is just a doc fix.
-
Tirth authored
Fix Small Typo in Skia_Client Doc Comment.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/2338a557e018...afd2d9f9421d 2024-03-04 skia-flutter-autoroll@skia.org Roll Skia from 4b98d7b3ff2d to ff3199348aab (1 revision) (flutter/engine#51162) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Loïc Sharma authored
Updates link to the new location. No tests as this only changes a comment.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/9cbca80e2196...2338a557e018 2024-03-04 skia-flutter-autoroll@skia.org Roll Skia from dfd933f9930c to 4b98d7b3ff2d (2 revisions) (flutter/engine#51160) 2024-03-04 skia-flutter-autoroll@skia.org Roll Skia from a57372ca2e66 to dfd933f9930c (1 revision) (flutter/engine#51158) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/c52b3033eca6...9cbca80e2196 2024-03-04 liama@google.com Experimental platform isolates API (flutter/engine#48551) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/024ea680ceed...c52b3033eca6 2024-03-04 robert.ancell@canonical.com Fix custom FlValue API not being exported (flutter/engine#51154) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 03 Mar, 2024 1 commit
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/2706c732b22a...024ea680ceed 2024-03-03 zanderso@users.noreply.github.com Fold the GN dart_pkg template into its only use (flutter/engine#51151) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 02 Mar, 2024 2 commits
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/8ef8543d6001...2706c732b22a 2024-03-01 jason-simmons@users.noreply.github.com [Impeller] ASAN/LSAN fixes for the mock Vulkan implementation (flutter/engine#51115) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Xilai Zhang authored
Context: @godofredoc pointed out that the fields in the PR template could be simplified and redesigned. Synced with @itsjustkevin and Kevin come up with [changes in this doc](https://docs.google.com/document/d/1Slppqq32toSwwxUyYTX1t6dGUQpyi0xEWxw4niGWspc/edit?resourcekey=0-v6U_9XVsMFSx0Fvx1rANhg&tab=t.0) which would improve the cherry pick template. Github only supports a limited number of formatting options. This PR uses some workarounds and makes the following changes: 1. use divider to replace text area since Github markdown doesn't support text area 2. remove \<pre\> tags so texts can wrap around 3. use headings over bold 4. use task lists to identify the starting points of user answers An example cherry pick template would [look like this](https://github.com/flutter/flutter/pull/143785) after the change.
-
- 01 Mar, 2024 14 commits
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/2a5a9a6dead0...8ef8543d6001 2024-03-01 skia-flutter-autoroll@skia.org Roll Skia from b44ad3d40f54 to a57372ca2e66 (1 revision) (flutter/engine#51122) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/6d02f0359368...a9c68b83356b 2024-03-01 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.5 to 3.24.6 (flutter/packages#6234) 2024-02-29 stuartmorgan@google.com [various] Standardize Obj-C doc comment style (flutter/packages#6232) 2024-02-29 joonas.kerttula@codemate.com [google_maps_flutter] Add support for marker clustering - platform interface (flutter/packages#6158) 2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter (stable) from abb292a07e20 to 7482962148e8 (1 revision) (flutter/packages#6230) 2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter from d00bfe82 to e92bca3f (15 revisions) (flutter/packages#6227) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Taha Tesser authored
fixes [`showDateRangePicker` interactive sample not loading](https://github.com/flutter/flutter/issues/144474) ### Description This fixes `showDateRangePicker` example not loading in Dartpad. Similar fix was made for `showDatePicker` in https://github.com/flutter/flutter/pull/99401
-
Taha Tesser authored
fixes [`DatePickerDialog` date entry hover background and ink splash have different radius](https://github.com/flutter/flutter/issues/141350) fixes [Ability to customize DatePicker day selection background and overlay shape](https://github.com/flutter/flutter/issues/144220) ### Code sample <details> <summary>expand to view the code sample</summary> ```dart import 'package:flutter/material.dart'; void main() { runApp(const MyApp()); } class MyApp extends StatelessWidget { const MyApp({super.key}); @override Widget build(BuildContext context) { return MaterialApp( home: Scaffold( body: Center( child: Builder(builder: (context) { return FilledButton( onPressed: () { showDatePicker( context: context, initialDate: DateTime.now(), firstDate: DateTime.utc(2010), lastDate: DateTime.utc(2030), ); }, child: const Text('Show Date picker'), ); }), ), ), ); } } ``` </details> ### Material DatePicker states specs ![overlay_specs](https://github.com/flutter/flutter/assets/48603081/45ce16cf-7ee9-41e1-a4fa-327de07b78d1) ### Day selection overlay | Before | After | | --------------- | --------------- | | <img src="https://github.com/flutter/flutter/assets/48603081/b529d38d-0232-494b-8bf2-55d28420a245" /> | <img src="https://github.com/flutter/flutter/assets/48603081/c4799559-a7ef-45fd-aed9-aeb386370580" /> | ### Hover, pressed, highlight preview | Before | After | | --------------- | --------------- | | <video src="https://github.com/flutter/flutter/assets/48603081/8edde82a-7f39-4482-afab-183e1bce5991" /> | <video src="https://github.com/flutter/flutter/assets/48603081/04e1502e-67a4-4b33-973d-463067d70151" /> | ### Using `DatePickerThemeData.dayShape` to customize day selection background and overlay shape | Before | After | | --------------- | --------------- | | <img src="https://github.com/flutter/flutter/assets/48603081/a0c85f58-a69b-4e14-a45d-41e580ceedce" /> | <img src="https://github.com/flutter/flutter/assets/48603081/db67cee1-d28d-4168-98b8-fd7a9cb70cda" /> | ### Example preview ![Screenshot 2024-02-29 at 15 07 50](https://github.com/flutter/flutter/assets/48603081/3770ed5c-28bf-4d0a-9514-87e1cd2ce515)
-
Taha Tesser authored
fixes [Chips delete button hover style is square, not circular](https://github.com/flutter/flutter/issues/141335) ### Code sample <details> <summary>expand to view the code sample</summary> ```dart import 'package:flutter/material.dart'; void main() { runApp(MyApp()); } class MyApp extends StatelessWidget { @override Widget build(BuildContext context) { return MaterialApp( home: Scaffold( body: Center( child: RawChip( label: const Text('Test'), onPressed: null, deleteIcon: const Icon(Icons.clear, size: 18), onDeleted: () {}, ), ), ), ); } } ``` </details> ### Preview | Before | After | | --------------- | --------------- | | <img src="https://github.com/flutter/flutter/assets/48603081/c5d62c57-97b3-4f94-b83d-df13559ee3a8" /> | <img src="https://github.com/flutter/flutter/assets/48603081/b76edaab-73e0-4aa9-8ca2-127eedd77814" /> |
-
Bruno Leroux authored
## Description This PR migrate hint related tests to M3 and adds some missing tests. It is the fourth step for the M3 test migration for `InputDecorator`. Step 1: https://github.com/flutter/flutter/pull/142981 Step 2: https://github.com/flutter/flutter/pull/143369 Step 3: https://github.com/flutter/flutter/pull/143520 ## Related Issue Related to https://github.com/flutter/flutter/issues/139076
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/f0037d4fbd67...2a5a9a6dead0 2024-03-01 skia-flutter-autoroll@skia.org Roll Skia from d672d0fe2f0d to b44ad3d40f54 (1 revision) (flutter/engine#51121) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/16e04d264145...f0037d4fbd67 2024-03-01 skia-flutter-autoroll@skia.org Roll Skia from 002f4366e473 to d672d0fe2f0d (2 revisions) (flutter/engine#51119) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/1dff89788b18...16e04d264145 2024-03-01 skia-flutter-autoroll@skia.org Roll Skia from 5961ed9c1d99 to 002f4366e473 (1 revision) (flutter/engine#51117) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Bruno Leroux authored
## Description This PR expands the items displayed in the overflow menu of a `TextSelectionToolbar` making buttons clickable in the blank area. | Before | After | |--------|--------| | Each item has its own width | All items expand horizontally | | ![Capture dâeÌcran 2024-02-29 aÌ 14 43 57](https://github.com/flutter/flutter/assets/840911/f7379eef-9185-4cc4-bf14-e4c916c432b1) | ![Capture dâeÌcran 2024-02-29 aÌ 14 40 47](https://github.com/flutter/flutter/assets/840911/bff272cd-9fe2-4f07-adaf-61edef03d26e) | ## Related Issue Fixes https://github.com/flutter/flutter/issues/144089. ## Tests Adds 1 tests.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/f68cc57cbe12...1dff89788b18 2024-03-01 jason-simmons@users.noreply.github.com [Impeller] Fix string search in CompilerTest.SkSLTextureLookUpOrderOfOperations (flutter/engine#51109) 2024-03-01 jason-simmons@users.noreply.github.com [Impeller] Fix vertex counts in some display list tests (flutter/engine#51111) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/76140bc9cec9...f68cc57cbe12 2024-03-01 jason-simmons@users.noreply.github.com [Impeller] Fix leak of rectangle packer in typographer tests (flutter/engine#51113) 2024-03-01 skia-flutter-autoroll@skia.org Roll Skia from 01d9566c4db8 to 5961ed9c1d99 (13 revisions) (flutter/engine#51106) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/f300ced56a4e...76140bc9cec9 2024-03-01 zanderso@users.noreply.github.com Run apple SDK finders as gclient hooks (flutter/engine#50957) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/34cf95c7bd82...f300ced56a4e 2024-03-01 matanlurey@users.noreply.github.com Add a basic e2e-test for `skia_gold_client`. (flutter/engine#51078) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-