- 20 Apr, 2023 17 commits
-
-
Nate Bosch authored
Most of these imports were never appropriate. The `test_api` package was never intended for use in `_test.dart` files. Where possible move imports to `matcher`, otherwise move them to `test` or `flutter_test`. Leave uses of `test_api` from `flutter_test` library code.
-
Ian Hickson authored
I don't know what I was thinking when I wrote this code back in 2017 but this is so trivially fixable...
-
Tae Hyung Kim authored
Going to make some changes to the implementation so I'll revert in the meantime. Reverts flutter/flutter#124337
-
9oya authored
-
Flutter GitHub Bot authored
This PR was generated by `flutter update-packages --force-upgrade`.
-
chunhtai authored
as title
-
Justin McCandless authored
Even in TextField using the Material library, iOS devices will still show the iOS-style spell check toolbar by default when using spell check.
-
Ben Konyi authored
`flutter test` wasn't awaiting the `_serveObservatory` request which was causing a race condition in the `flutter test should respect --serve-observatory` test in `test/integration.general/test_test.dart`. Related to https://github.com/flutter/flutter/issues/123516
-
Flutter GitHub Bot authored
This PR was generated by `flutter update-packages --force-upgrade`.
-
Christopher Fujino authored
use `containsAllInOrder` so that pub output doesn't cause htis test to fail, as in https://ci.chromium.org/p/flutter/builders/try/Linux%20tool_tests_general/22929?
-
chunhtai authored
fixes https://github.com/flutter/flutter/issues/107615 ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/88591becfb3f...746750ecef78 2023-04-20 stuartmorgan@google.com [pigeon] Add an initial example app (flutter/packages#3761) 2023-04-20 imagipioneer@gmail.com [google_maps_flutter_web] Allow marker position updates (flutter/packages#3697) 2023-04-19 tarrinneal@gmail.com [Tool] [Code Excerpt] allow excerpts in example readme (flutter/packages#3758) 2023-04-19 47866232+chunhtai@users.noreply.github.com [go_router] migrates test for route information.location deprecation (flutter/packages#3763) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Reid Baker authored
- Update gradle and AGP version for abstract_method_smoke_test #125138 part 1/N To update successfully: 1. Update gradle to a version supported by jdk 17 2. Uncommented the lockfile lines in android/build.gradle 3. Then ran the AGP update assistant from AndroidStudio -> tools 4. From android ran `./gradlew dependencies --write-locks` 5. From android/app ran `./gradlew dependencies --write-locks` 6. Re enabled the lockfiles section of android/build.gradle 7. Ensured `flutter build apk` passed -
xubaolin authored
Fixes https://github.com/flutter/flutter/issues/120567
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/d726345bf230...2db85cbe6a01 2023-04-20 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from suSuT9F8zuP-pBg-E... to OcPCdaE17MAihaCrD... (flutter/engine#41352) 2023-04-19 skia-flutter-autoroll@skia.org Roll Dart SDK from fe8bb0565a30 to 88a3b66b50d6 (2 revisions) (flutter/engine#41349) 2023-04-19 bdero@google.com Add missing header guards (flutter/engine#41322) 2023-04-19 joshualitt@google.com [web] Fix trivial type issue. (flutter/engine#40956) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from suSuT9F8zuP- to OcPCdaE17MAi If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Qun Cheng authored
Fixes #124426 This PR is to make the search view shape clip the view content. Before: the highlight and the "i" of "item 9" are not clipped by the shape. <img width="350" alt="Screenshot 2023-04-19 at 12 09 48 PM" src="https://user-images.githubusercontent.com/36861262/233201222-468820a9-8717-4b6c-8528-8125a40fc161.png"> After: <img width="350" alt="Screenshot 2023-04-19 at 2 13 52 PM" src="https://user-images.githubusercontent.com/36861262/233201609-81f5a942-2390-4081-a9c7-c9523a7f9e72.png">
-
Renzo Olivares authored
This change shows the magnifier on touch drag gestures for Android and iOS and hides it when the drag ends. Fixes #118268
-
- 19 Apr, 2023 20 commits
-
-
Kevin Moore authored
Fixes https://github.com/flutter/flutter/issues/125085
-
Andrew Kolos authored
Allows use of APIs such as `Iterable.firstOrNull`.
-
Andrew Kolos authored
Adds `todo` link in code for #125155.
-
xubaolin authored
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/0a53cf6f7a4e...d726345bf230 2023-04-19 bdero@google.com [Impeller] Comprehensively label snapshots (flutter/engine#41325) 2023-04-19 bdero@google.com [Impeller] Fix transform regressions for chained filters (flutter/engine#41332) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Victoria Ashworth authored
Rename variables, update comments, etc from `network` to `wireless` to keep it more uniform. Also, move non-overriden messages related to device selection into the file they're used. Part 7 in breakdown of https://github.com/flutter/flutter/pull/121262.
-
chunhtai authored
The regression was caused by the previous pr https://github.com/flutter/flutter/pull/124624 changes postframecallback to scheduleframecallback. The reason is that if a new postframecallback was scheduled when running a postframecallback. The newly added postframecallback will be execute on the next frame. However, adding postframecallback will not schedule a new frame. So if there isn't other widget that schedule a new frame, the newly added postframecallback will never gets run. After changing to scheduleframecallback, it causes an issue that transient callback may be called when rendering tree contains dirty layout information that are waiting to be rebuilt. Therefore, I use microtask to get around of the postframecallback issue instead of scheduleframecallback. fixes https://github.com/flutter/flutter/issues/125065
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/faf53fb3998c...88591becfb3f 2023-04-19 engine-flutter-autoroll@skia.org Roll Flutter from 42fb0b23 to 3476b966 (20 revisions) (flutter/packages#3760) 2023-04-19 49699333+dependabot[bot]@users.noreply.github.com Bump cirrusci/flutter from `794fbbc` to `d99b1ba` in /.ci (flutter/packages#3724) 2023-04-18 10687576+bparrishMines@users.noreply.github.com [webview_flutter] Adds support to listen to url changes (flutter/packages#3313) 2023-04-18 engine-flutter-autoroll@skia.org Roll Flutter from 15cb1f84 to 42fb0b23 (19 revisions) (flutter/packages#3756) 2023-04-18 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump com.android.tools.build:gradle from 7.2.2 to 8.0.0 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#3739) 2023-04-18 stuartmorgan@google.com [local_auth] Convert Android to Pigeon (flutter/packages#3748) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/d626f16cb9a3...0a53cf6f7a4e 2023-04-19 chinmaygarde@google.com [Impeller] Make //impeller/display_list TU naming consistent. (flutter/engine#41174) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Elias Yishak authored
Relanding: https://github.com/flutter/flutter/pull/124810 Fixes: https://github.com/flutter/flutter/issues/124808
-
Qun Cheng authored
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/609f9d536494...d626f16cb9a3 2023-04-19 mdebbar@google.com [web] Remove non-ShadowDom mode (flutter/engine#39915) 2023-04-19 30870216+gaaclarke@users.noreply.github.com [impeller] added moltenvk notice (flutter/engine#41317) 2023-04-19 skia-flutter-autoroll@skia.org Roll Skia from 8af1dd9659f0 to ad90b6bd4760 (3 revisions) (flutter/engine#41337) 2023-04-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 27e71f19c144 to fe8bb0565a30 (2 revisions) (flutter/engine#41336) 2023-04-19 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from yD5a3QBJHUFM4nVou... to suSuT9F8zuP-pBg-E... (flutter/engine#41334) 2023-04-19 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Cy5LG4U2InaFLkJGz... to Tun7i4VLz6ncx8JJJ... (flutter/engine#41331) 2023-04-19 skia-flutter-autoroll@skia.org Roll Skia from 85d9e67653b1 to 8af1dd9659f0 (1 revision) (flutter/engine#41333) 2023-04-19 skia-flutter-autoroll@skia.org Roll Skia from 5a718d9e9c06 to 85d9e67653b1 (4 revisions) (flutter/engine#41330) 2023-04-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 1f224df52bee to 27e71f19c144 (3 revisions) (flutter/engine#41329) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from Cy5LG4U2InaF to Tun7i4VLz6nc fuchsia/sdk/core/mac-amd64 from yD5a3QBJHUFM to suSuT9F8zuP- If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Bartek Pacia authored
Refactor Flutter Gradle Plugin so it can be applied using the declarative `plugins {}` block (#123511) This PR aims to resolve #121552. Resources used: - [Developing Plugins](https://docs.gradle.org/current/userguide/custom_plugins.html) - [Using Gradle Plugins](https://docs.gradle.org/current/userguide/plugins.html#sec:plugins_block) - [Composite Builds Plugin Development Sample](https://docs.gradle.org/current/samples/sample_composite_builds_plugin_development.html) This PR also paves way for #121541, because apps will no longer have: ```groovy apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle" ``` hardcoded. Instead, they'll use: ```groovy plugins { // ... id "dev.flutter.flutter-gradle-plugin" // the exact name is tentative } ``` -
chunhtai authored
as title ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
-
godofredoc authored
Reverts flutter/flutter#124810
-
Elias Yishak authored
Fixes: https://github.com/flutter/flutter/issues/124808
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/8b7cdb02f7f3...609f9d536494 2023-04-19 bdero@google.com [Impeller] Add buffer-to-texture blit capability check; fix GL+VK playgrounds on macOS (flutter/engine#41320) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/099ed6c62d04...8b7cdb02f7f3 2023-04-19 aam@google.com Roll dart, zlib, emscripten, tweak license script for rolled zlib (flutter/engine#41299) 2023-04-19 skia-flutter-autoroll@skia.org Roll Skia from 84630c3c18b2 to 5a718d9e9c06 (3 revisions) (flutter/engine#41318) 2023-04-19 bdero@google.com [Impeller] Provide an opaque interface for color sources in Aiks (flutter/engine#41315) 2023-04-18 yjbanov@google.com [web:canvaskit] remove unnecessary instrumentation from picture (flutter/engine#41313) 2023-04-18 skia-flutter-autoroll@skia.org Roll Skia from 476ee3fd54cc to 84630c3c18b2 (5 revisions) (flutter/engine#41316) 2023-04-18 godofredoc@google.com Double zip FlutterMacOS.framework.zip. (flutter/engine#41306) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/5fcc7b719029...099ed6c62d04 2023-04-18 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from qZHSvkpAU1-YYGvYc... to yD5a3QBJHUFM4nVou... (flutter/engine#41314) 2023-04-18 yjbanov@google.com [web:canvaskit] clean up the rest of skia_object_cache usages (flutter/engine#41259) 2023-04-18 skia-flutter-autoroll@skia.org Roll Skia from f80ee1088861 to 476ee3fd54cc (2 revisions) (flutter/engine#41309) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from qZHSvkpAU1-Y to yD5a3QBJHUFM If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Justin McCandless authored
Fixes https://github.com/flutter/flutter/issues/124247 | Native | Flutter before | Flutter after | | --- | --- | --- | | <img width="248" alt="Screenshot 2023-04-05 at 9 26 16 AM" src="https://user-images.githubusercontent.com/389558/230177116-154999e8-eef3-441d-9fe9-7063839a6b99.png"> | <img width="240" alt="Screenshot 2023-04-05 at 11 18 01 AM" src="https://user-images.githubusercontent.com/389558/230177125-1680e851-223e-4956-b5b6-1a24e11dc22a.png"> | <img width="226" alt="Screenshot 2023-04-05 at 11 17 36 AM" src="https://user-images.githubusercontent.com/389558/230177123-bde82134-67e1-4ce2-8eec-719eeb779bf4.png"> | Also, it's now possible for anyone to create disabled buttons like this by setting ContextMenuButtonItem.onPressed to `null`.
-
- 18 Apr, 2023 3 commits
-
-
Mitchell Goodwin authored
Fixes #102811. Adds an adaptive constructor to AlertDialog, along with the adaptive function showAdaptiveDialog. <img width="357" alt="Screenshot 2023-04-06 at 10 40 18 AM" src="https://user-images.githubusercontent.com/58190796/230455412-31100922-cfc5-4252-b8c6-6f076353f29e.png"> <img width="350" alt="Screenshot 2023-04-06 at 10 42 50 AM" src="https://user-images.githubusercontent.com/58190796/230455454-363dd37e-c44e-4aca-b6a0-cfa1d959f606.png">
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/6d263ea56a62...5fcc7b719029 2023-04-18 dnfield@google.com [Impeller] Gpu model information to Skia gold (flutter/engine#41216) 2023-04-18 30870216+gaaclarke@users.noreply.github.com [Impeller] faster glyph atlas generation by removing data copies (flutter/engine#41290) 2023-04-18 godofredoc@google.com Migrate android AOT to engine_v2. (flutter/engine#41229) 2023-04-18 skia-flutter-autoroll@skia.org Roll Skia from 5bd4bdc0d8e2 to f80ee1088861 (8 revisions) (flutter/engine#41302) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Srujan Gaddam authored
dart:js_interop and package:js will start conflicting, since they both have an `@JS` annotation. Until we're ready to only use dart:js_interop (which will require updating the SDK constraints of every package), we should hide the `@JS` annotation from dart:js_interop. Due to shadowing, this is the behavior today, so there should be no functional change. Unblocks https://dart-review.googlesource.com/c/sdk/+/294130/8 and prevents confusing shadowing of dart:js_interop annotations like we do today. - [Mentioned CL that is unblocked] I listed at least one issue that this PR fixes in the description above. - [Need test-exemption] I added new tests to check the change I am making, or this PR is [test-exempt]. - [Need to run] All existing and new tests are passing.
-
