Commits · d4608046cdb8933526dde5fdc46dbfd7ff05e2fe · abdullh.alsoleman / Front-End

22 Jul, 2023 4 commits

Roll Flutter Engine from 6344b17a2e03 to 481684a6e276 (2 revisions) (#131118) · d4608046

engine-flutter-autoroll authored Jul 22, 2023

https://github.com/flutter/engine/compare/6344b17a2e03...481684a6e276

2023-07-22 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from rMFZIJYvVmXEBGCay... to UgZ9epS2Jkz7Yrymp... (flutter/engine#43922)
2023-07-22 skia-flutter-autoroll@skia.org Roll Skia from 80e101dc5813 to 85e8d8403b45 (1 revision) (flutter/engine#43921)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from rMFZIJYvVmXE to UgZ9epS2Jkz7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d4608046

Roll Flutter Engine from b47cf14fda0e to 6344b17a2e03 (1 revision) (#131114) · fd2e6b8c

engine-flutter-autoroll authored Jul 22, 2023

https://github.com/flutter/engine/compare/b47cf14fda0e...6344b17a2e03

2023-07-22 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from gpjF3QRGg_KH0guW5... to LZJYHQeLdXALTMMmj... (flutter/engine#43917)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from gpjF3QRGg_KH to LZJYHQeLdXAL

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fd2e6b8c

Roll Flutter Engine from 840bcc3449ff to b47cf14fda0e (3 revisions) (#131109) · 6b97716d

engine-flutter-autoroll authored Jul 22, 2023

https://github.com/flutter/engine/compare/840bcc3449ff...b47cf14fda0e

2023-07-22 jonahwilliams@google.com [Impeller] size command pools to npot of command count. (flutter/engine#43903)
2023-07-22 skia-flutter-autoroll@skia.org Roll Skia from c79c781a3ce3 to 80e101dc5813 (1 revision) (flutter/engine#43914)
2023-07-22 skia-flutter-autoroll@skia.org Roll Skia from 359d4726e423 to c79c781a3ce3 (2 revisions) (flutter/engine#43913)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6b97716d

Roll Flutter Engine from 2d8cff44261b to 840bcc3449ff (11 revisions) (#131101) · 3e67e199

engine-flutter-autoroll authored Jul 22, 2023

https://github.com/flutter/engine/compare/2d8cff44261b...840bcc3449ff

2023-07-21 skia-flutter-autoroll@skia.org Roll ANGLE from f586ec98d924 to 938ee1e80fc8 (1 revision) (flutter/engine#43912)
2023-07-21 skia-flutter-autoroll@skia.org Roll ANGLE from 085f25bbb1e3 to f586ec98d924 (1 revision) (flutter/engine#43908)
2023-07-21 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from WH3AaCa4DtVERww1v... to rMFZIJYvVmXEBGCay... (flutter/engine#43907)
2023-07-21 jason-simmons@users.noreply.github.com [Impeller] Do not use clear color optimization if the subpass is being collapsed into its parent (flutter/engine#43878)
2023-07-21 skia-flutter-autoroll@skia.org Roll Skia from 2e28fe9de378 to 359d4726e423 (1 revision) (flutter/engine#43906)
2023-07-21 bdero@google.com [Impeller] Disable color attachment removal for clips on VK (flutter/engine#43905)
2023-07-21 bdero@google.com [Impeller] Add a way to query the gfx backend type. (flutter/engine#43837)
2023-07-21 skia-flutter-autoroll@skia.org Roll ANGLE from 82d68c577b1d to 085f25bbb1e3 (1 revision) (flutter/engine#43904)
2023-07-21 skia-flutter-autoroll@skia.org Roll ANGLE from 2e190280f5c5 to 82d68c577b1d (1 revision) (flutter/engine#43901)
2023-07-21 skia-flutter-autoroll@skia.org Roll Skia from 497326dc66cd to 2e28fe9de378 (2 revisions) (flutter/engine#43900)
2023-07-21 skia-flutter-autoroll@skia.org Roll Skia from 1f84e9d51bba to 497326dc66cd (1 revision) (flutter/engine#43899)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from WH3AaCa4DtVE to rMFZIJYvVmXE

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3e67e199

21 Jul, 2023 17 commits

Remove obsolete work around for shadow drawing (#131066) · 9a726e85
Michael Goderbauer authored Jul 21, 2023
```
Fixes https://github.com/flutter/flutter/issues/130737.
```
9a726e85

Manual roll Flutter Engine from acb5d0640b6c to 2d8cff44261b (3 revisions) (#131092) · 99a4f7e1

engine-flutter-autoroll authored Jul 21, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/acb5d0640b6c...2d8cff44261b

2023-07-21 ychris@google.com Refactor: fix typo "setup" -> "set up" (flutter/engine#43824)
2023-07-21 jonahwilliams@google.com [engine] disable picture complexity raster caching (flutter/engine#43897)
2023-07-21 skia-flutter-autoroll@skia.org Roll Skia from e3d13d1b1c42 to 1f84e9d51bba (1 revision) (flutter/engine#43896)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

99a4f7e1

Upgrade to newer leak_tracker. (#131085) · 30c005f7
Polina Cherkasova authored Jul 21, 2023

30c005f7

Manual roll Flutter Engine from f5c1650c7acc to acb5d0640b6c (10 revisions) (#131070) · 65c77f48

engine-flutter-autoroll authored Jul 21, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/f5c1650c7acc...acb5d0640b6c

2023-07-21 zanderso@users.noreply.github.com Revert Dart (flutter/engine#43895)
2023-07-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from CWNVmH6f_iryKU05E... to gpjF3QRGg_KH0guW5... (flutter/engine#43894)
2023-07-21 skia-flutter-autoroll@skia.org Roll Skia from 8388ec4d242c to e3d13d1b1c42 (1 revision) (flutter/engine#43893)
2023-07-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 6e79151ce988 to 921613a055ff (1 revision) (flutter/engine#43892)
2023-07-21 skia-flutter-autoroll@skia.org Roll Skia from 3dd45617581b to 8388ec4d242c (1 revision) (flutter/engine#43891)
2023-07-21 skia-flutter-autoroll@skia.org Roll ANGLE from b60068009dca to 2e190280f5c5 (2 revisions) (flutter/engine#43890)
2023-07-21 skia-flutter-autoroll@skia.org Roll ANGLE from f2e0f8a0b236 to b60068009dca (1 revision) (flutter/engine#43887)
2023-07-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 8662af7d9aa3 to 6e79151ce988 (2 revisions) (flutter/engine#43885)
2023-07-21 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from -SaPL-46jpiYbnCAu... to WH3AaCa4DtVERww1v... (flutter/engine#43884)
2023-07-21 skia-flutter-autoroll@skia.org Roll Skia from 4857e876d8cf to 3dd45617581b (1 revision) (flutter/engine#43883)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from CWNVmH6f_iry to gpjF3QRGg_KH
fuchsia/sdk/core/mac-amd64 from -SaPL-46jpiY to WH3AaCa4DtVE

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

65c77f48

Suggest a potential valid name for the flutter project when using `flutter create` (#130900) · be7c7e3e

Valentin Vignal authored Jul 21, 2023

Fixes https://github.com/flutter/flutter/issues/109775

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

be7c7e3e

[CI/FTL] Oriole to Panther, presubmit false (#130912) · 764095ce

Dan Field authored Jul 21, 2023

Alternative to https://github.com/flutter/flutter/pull/130868

Oriole is the Pixel 6, Panther is the Pixel 7. Panther is more available in FTL at this point.

There's less value in running this on presubmit, since those can spawn many jobs multiple times over as people push new commits to branches. Let's just run it post submit to avoid overloading the capacity of FTL.

764095ce

Improve handling of certain icons in RTL (#130979) · 0919fb86

Pierre-Louis authored Jul 21, 2023

Fixes https://github.com/flutter/flutter/issues/130978 

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

0919fb86

Roll Packages from 674179f97bda to 2266a7618ee3 (6 revisions) (#131058) · 9cfbf6b9

engine-flutter-autoroll authored Jul 21, 2023

https://github.com/flutter/packages/compare/674179f97bda...2266a7618ee3

2023-07-21 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.20.4 to 2.21.0 (flutter/packages#4525)
2023-07-20 34871572+gmackall@users.noreply.github.com [url_launcher_android] Set `buildFeatures.buildConfig` to true for compatibility with AGP 8.0+ (flutter/packages#4535)
2023-07-20 59682979+utamori@users.noreply.github.com [go_router] fix error handling page link (flutter/packages#4296)
2023-07-20 stuartmorgan@google.com [plugin_platform_interface] Adopt code-excerpts (flutter/packages#4534)
2023-07-20 stuartmorgan@google.com [ci] Simplify Dockerfile (flutter/packages#4530)
2023-07-20 stuartmorgan@google.com [ci] Enable Windows Dart unit test sharding (flutter/packages#4528)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9cfbf6b9

Add tests for navigation_drawer_theme_test.dart (#130465) · aafdbc6d
hangyu authored Jul 21, 2023
```
fixes: https://github.com/flutter/flutter/issues/129618
```
aafdbc6d

Roll Flutter Engine from f812cf373b6b to f5c1650c7acc (1 revision) (#131037) · d67d2c3d

engine-flutter-autoroll authored Jul 21, 2023

https://github.com/flutter/engine/compare/f812cf373b6b...f5c1650c7acc

2023-07-21 skia-flutter-autoroll@skia.org Roll Skia from 3dce2d4ee4f3 to 4857e876d8cf (1 revision) (flutter/engine#43882)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d67d2c3d

Roll Flutter Engine from 264685f0aecb to f812cf373b6b (1 revision) (#131032) · 9e8ee306

engine-flutter-autoroll authored Jul 21, 2023

https://github.com/flutter/engine/compare/264685f0aecb...f812cf373b6b

2023-07-21 skia-flutter-autoroll@skia.org Roll Skia from 31b0ed0c0054 to 3dce2d4ee4f3 (1 revision) (flutter/engine#43880)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9e8ee306

Roll Flutter Engine from 8ff10f5a7667 to 264685f0aecb (1 revision) (#131031) · f6298099

engine-flutter-autoroll authored Jul 21, 2023

https://github.com/flutter/engine/compare/8ff10f5a7667...264685f0aecb

2023-07-21 skia-flutter-autoroll@skia.org Roll Skia from bae54bbf49bd to 31b0ed0c0054 (1 revision) (flutter/engine#43879)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f6298099

Roll Flutter Engine from b5a6b1c9cba5 to 8ff10f5a7667 (5 revisions) (#131029) · 5c86e4d7

engine-flutter-autoroll authored Jul 21, 2023

https://github.com/flutter/engine/compare/b5a6b1c9cba5...8ff10f5a7667

2023-07-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from hVAAd2NqYOjUF_I99... to CWNVmH6f_iryKU05E... (flutter/engine#43877)
2023-07-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 1df95f328d0c to 8662af7d9aa3 (1 revision) (flutter/engine#43876)
2023-07-21 ian@hixie.ch Add a breadcrumb for people who want to run the web tests (flutter/engine#43865)
2023-07-21 skia-flutter-autoroll@skia.org Roll Skia from 049f389db75b to bae54bbf49bd (2 revisions) (flutter/engine#43875)
2023-07-21 skia-flutter-autoroll@skia.org Roll Skia from 6f2b2e94ebbd to 049f389db75b (1 revision) (flutter/engine#43873)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from hVAAd2NqYOjU to CWNVmH6f_iry

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5c86e4d7

Roll Flutter Engine from 218b71cd7a45 to b5a6b1c9cba5 (1 revision) (#131025) · 83e5aca1

engine-flutter-autoroll authored Jul 21, 2023

https://github.com/flutter/engine/compare/218b71cd7a45...b5a6b1c9cba5

2023-07-20 dnfield@google.com [Impeller] [Vulkan] Add reset command buffer bit to command pools. (flutter/engine#43867)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

83e5aca1

Roll Flutter Engine from ab7d424d4467 to 218b71cd7a45 (2 revisions) (#131024) · a6750235

engine-flutter-autoroll authored Jul 21, 2023

https://github.com/flutter/engine/compare/ab7d424d4467...218b71cd7a45

2023-07-20 skia-flutter-autoroll@skia.org Roll Skia from 981146e6305d to 6f2b2e94ebbd (3 revisions) (flutter/engine#43871)
2023-07-20 skia-flutter-autoroll@skia.org Roll Skia from 100d0f858f02 to 981146e6305d (3 revisions) (flutter/engine#43866)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a6750235

Use downgraded analyze for flutter/packages (#130878) · 273441ee

stuartmorgan authored Jul 21, 2023

Add the `--downgrade` flag to the flutter/packages analyze test, so that it won't get the latest version of dependencies, avoiding out-of-band failures in flutter/flutter due to package publishing events.

Fixes https://github.com/flutter/flutter/issues/129633

273441ee

Roll pub packages (#131022) · 0df683c0
flutter-pub-roller-bot authored Jul 21, 2023
```
This PR was generated by `flutter update-packages --force-upgrade`.
```
0df683c0

20 Jul, 2023 19 commits

Roll Flutter Engine from 9b2ebf2afe00 to ab7d424d4467 (4 revisions) (#131015) · f17f7483

engine-flutter-autoroll authored Jul 20, 2023

https://github.com/flutter/engine/compare/9b2ebf2afe00...ab7d424d4467

2023-07-20 jonahwilliams@google.com [Impeller] Provide fragment uniform data through varyings for solid color, glyph atlas, texture shaders. (flutter/engine#43838)
2023-07-20 skia-flutter-autoroll@skia.org Roll ANGLE from a4c283be741f to f2e0f8a0b236 (2 revisions) (flutter/engine#43864)
2023-07-20 skia-flutter-autoroll@skia.org Roll Skia from 18e834916f47 to 100d0f858f02 (7 revisions) (flutter/engine#43863)
2023-07-20 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from SmAtKPfGzPllC9gfO... to -SaPL-46jpiYbnCAu... (flutter/engine#43862)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from SmAtKPfGzPll to -SaPL-46jpiY

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f17f7483

Add applyFocusChangeIfNeeded, have menus restore focus before activating (#130536) · e4a39fa2

Greg Spencer authored Jul 20, 2023

## Description

This modifies the `MenuAnchor` `onPressed` activation to delay until after the current frame is built, and resolve any focus changes before it invokes the `onPressed`, so that actions that operate on the `primaryFocus` can have a chance of working on the focused item they were meant to work on.

## Related Issues
 - Fixes https://github.com/flutter/flutter/issues/118731

## Tests
 - No tests yet (hence draft still)

e4a39fa2

Migrate more integration tests to process result matcher (#130994) · d457287f
Christopher Fujino authored Jul 20, 2023
```
Part of https://github.com/flutter/flutter/issues/127135
```
d457287f

Roll Flutter Engine from 062079ba30b6 to 9b2ebf2afe00 (2 revisions) (#131013) · 773b667b

engine-flutter-autoroll authored Jul 20, 2023

https://github.com/flutter/engine/compare/062079ba30b6...9b2ebf2afe00

2023-07-20 skia-flutter-autoroll@skia.org Roll Skia from a3aca7ae523e to 18e834916f47 (1 revision) (flutter/engine#43860)
2023-07-20 mdebbar@google.com Add url to get GoogleFonts API key (flutter/engine#43857)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

773b667b

Trivial grammar and wrapping fix for docs (#130955) · 14c2153b
Ian Hickson authored Jul 20, 2023

14c2153b
Updated the ThemeData API example (#130954) · 93f7dc32
Hans Muller authored Jul 20, 2023

93f7dc32

Roll Flutter Engine from a3fc18514cd6 to 062079ba30b6 (3 revisions) (#131010) · 038e57c0

engine-flutter-autoroll authored Jul 20, 2023

https://github.com/flutter/engine/compare/a3fc18514cd6...062079ba30b6

2023-07-20 dnfield@google.com More validation logs for CommandEncoderVK submission (flutter/engine#43859)
2023-07-20 skia-flutter-autoroll@skia.org Roll Dart SDK from 857c9a2ae14a to 1df95f328d0c (1 revision) (flutter/engine#43858)
2023-07-20 mdebbar@google.com [web] Preserve correct CanvasKit Variant during test initialization (flutter/engine#43854)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

038e57c0

Roll Flutter Engine from 6d7842d25f81 to a3fc18514cd6 (2 revisions) (#131007) · de26ad0a

engine-flutter-autoroll authored Jul 20, 2023

https://github.com/flutter/engine/compare/6d7842d25f81...a3fc18514cd6

2023-07-20 skia-flutter-autoroll@skia.org Roll Skia from b8133dda3a8c to a3aca7ae523e (1 revision) (flutter/engine#43855)
2023-07-20 skia-flutter-autoroll@skia.org Roll Skia from 401c85ab1e21 to b8133dda3a8c (4 revisions) (flutter/engine#43853)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

de26ad0a

Update `TextSelectionTheme`, `ThemeData`, `TimePicker`, and `TimePickerTheme`... · 0ed17dd5

Qun Cheng authored Jul 20, 2023

Update `TextSelectionTheme`, `ThemeData`, `TimePicker`, and `TimePickerTheme` tests for M2/M3 (#130547)

Updated unit tests for `TextSelectionTheme`, `ThemeData`, `TimePicker` and `TimePickerTheme` to have M2 and M3 versions.

More info in #127064

0ed17dd5

Roll Flutter Engine from c645eb6da8a9 to 6d7842d25f81 (1 revision) (#130992) · d4005a87

engine-flutter-autoroll authored Jul 20, 2023

https://github.com/flutter/engine/compare/c645eb6da8a9...6d7842d25f81

2023-07-20 skia-flutter-autoroll@skia.org Roll Dart SDK from 603aacd8400f to 857c9a2ae14a (1 revision) (flutter/engine#43851)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d4005a87

Update AutoComplete test for M3 migration (#130883) · 56da3710

Bruno Leroux authored Jul 20, 2023

This PR updates unit tests from autocomplete_test.dart for M3 migration.

More info in https://github.com/flutter/flutter/issues/127064

I replaced magic numbers (64.0 and 187.0) and found ways to compute them without relying on the Material version.

56da3710

Update about tests for M3 (#130970) · 2afe8aa5

Bruno Leroux authored Jul 20, 2023

This PR updates unit tests in `about_test.dart` for M3 migration.

More info in https://github.com/flutter/flutter/issues/127064

- Two tests were failing in M3 due to a memory leak. As the memory leak is now fixed, see https://github.com/flutter/flutter/pull/130720, this two tests does not depend anymore on the Material version.

- Created several M3 tests related to typography and rendering changes.

2afe8aa5

Roll Packages from 209db219ad73 to 674179f97bda (4 revisions) (#130989) · 67e0e878

engine-flutter-autoroll authored Jul 20, 2023

https://github.com/flutter/packages/compare/209db219ad73...674179f97bda

2023-07-19 stuartmorgan@google.com [image_picker] Deprecate platform interface methods (flutter/packages#4520)
2023-07-19 47866232+chunhtai@users.noreply.github.com [go_router] Adds a parentNavigatorKey parameter to ShellRouteData. (flutter/packages#4409)
2023-07-19 stuartmorgan@google.com [ci] Shard Windows Dart unit tests (flutter/packages#4519)
2023-07-19 engine-flutter-autoroll@skia.org Roll Flutter from 6f09064e to d07e8aec (60 revisions) (flutter/packages#4522)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

67e0e878

Roll Flutter Engine from e40995da7869 to c645eb6da8a9 (1 revision) (#130988) · 1a804207

engine-flutter-autoroll authored Jul 20, 2023

https://github.com/flutter/engine/compare/e40995da7869...c645eb6da8a9

2023-07-20 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ZwCUlo28olVzLlqTl... to hVAAd2NqYOjUF_I99... (flutter/engine#43850)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from ZwCUlo28olVz to hVAAd2NqYOjU

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1a804207

Upgrade leak_tracker. (#130951) · e8a975e8
Polina Cherkasova authored Jul 20, 2023

e8a975e8

Roll Flutter Engine from 2df3b9c4b2a4 to e40995da7869 (2 revisions) (#130985) · 98e9a73c

engine-flutter-autoroll authored Jul 20, 2023

https://github.com/flutter/engine/compare/2df3b9c4b2a4...e40995da7869

2023-07-20 skia-flutter-autoroll@skia.org Roll ANGLE from 5e38a31bd76a to a4c283be741f (1 revision) (flutter/engine#43849)
2023-07-20 skia-flutter-autoroll@skia.org Roll Skia from 65a83c4de7f2 to 401c85ab1e21 (1 revision) (flutter/engine#43848)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

98e9a73c

Roll Flutter Engine from b494143fb0bc to 2df3b9c4b2a4 (3 revisions) (#130973) · f212b101

engine-flutter-autoroll authored Jul 20, 2023

https://github.com/flutter/engine/compare/b494143fb0bc...2df3b9c4b2a4

2023-07-20 skia-flutter-autoroll@skia.org Roll Skia from d09e9869f84c to 65a83c4de7f2 (2 revisions) (flutter/engine#43847)
2023-07-20 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 7kGBjmX-zBXcg1svE... to SmAtKPfGzPllC9gfO... (flutter/engine#43845)
2023-07-20 skia-flutter-autoroll@skia.org Roll Skia from b238c09fe959 to d09e9869f84c (1 revision) (flutter/engine#43842)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 7kGBjmX-zBXc to SmAtKPfGzPll

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f212b101

Fix chip delete button tap target spilling into the label. (#130896) · f92637d7

Taha Tesser authored Jul 20, 2023

fixes [Chip's delete button tap target is too big](https://github.com/flutter/flutter/issues/129986)

### Description 

This PR fixes the issue where the chip delete button is tappable within the label. 

### Code sample

<details> 
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(useMaterial3: true),
      home: const Example(),
    );
  }
}

class Example extends StatelessWidget {
  const Example({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Sample'),
      ),
      body: Center(
        child: Chip(
          label: const Text('Really Long Label'),
          onDeleted: () {},
        ),
      ),
    );
  }
}
``` 
	
</details>

### Before

https://github.com/flutter/flutter/assets/48603081/14b369c5-c740-4dfc-a512-779bd3a1a46b

### After

https://github.com/flutter/flutter/assets/48603081/08c6e232-0237-4ab2-9829-66ee8e5cead2

f92637d7

Fix IconButton leaks its internal MaterialStatesController (#130720) · 0aba94f4

Bruno Leroux authored Jul 20, 2023

## Description

This PR adds a call to dispose the internal `MaterialStatesController` instantiated by `_SelectableIconButtonState`.

I found this memory leak while working on M2/M3 test update for `about_test.dart`. This memory leak only happens when using M3 because `IconButton` relies on `_SelectableIconButton` only when useMaterial3 is true:

https://github.com/flutter/flutter/blob/3a1190a5a85c3e6a0cf3a9c30f34548fdd48ac1e/packages/flutter/lib/src/material/icon_button.dart#L671-L721

## Related Issue

Fixes https://github.com/flutter/flutter/issues/130708

## Tests

Adds 1 test.

0aba94f4