Commits · d0482116e77994122a7e8596f4a6b7078f08e190 · abdullh.alsoleman / Front-End

06 Jan, 2024 5 commits

Roll Flutter Engine from 8d1789a43319 to 7f872b265733 (1 revision) (#141056) · d0482116

engine-flutter-autoroll authored Jan 06, 2024

https://github.com/flutter/engine/compare/8d1789a43319...7f872b265733

2024-01-06 skia-flutter-autoroll@skia.org Roll Skia from 514dd58cabfc to 3547cf9793f4 (1 revision) (flutter/engine#49577)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d0482116

Roll Flutter Engine from fcb40168f159 to 8d1789a43319 (1 revision) (#141053) · e0f94412

engine-flutter-autoroll authored Jan 06, 2024

https://github.com/flutter/engine/compare/fcb40168f159...8d1789a43319

2024-01-06 skia-flutter-autoroll@skia.org Roll Skia from 38c029ddd665 to 514dd58cabfc (1 revision) (flutter/engine#49575)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e0f94412

Roll Flutter Engine from 89ecf7503012 to fcb40168f159 (1 revision) (#141047) · c6ddb73f

engine-flutter-autoroll authored Jan 06, 2024

https://github.com/flutter/engine/compare/89ecf7503012...fcb40168f159

2024-01-05 skia-flutter-autoroll@skia.org Roll Skia from 2345b9f2c943 to 38c029ddd665 (1 revision) (flutter/engine#49570)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c6ddb73f

Remove codesign command from conductor. (#141044) · f18e61a5
godofredoc authored Jan 06, 2024
```
Codesigning is now automated and the codesigning tests have been migrated to shard tests.
```
f18e61a5

Roll Flutter Engine from 470b604b9abf to 89ecf7503012 (2 revisions) (#141045) · 4d97bd77

engine-flutter-autoroll authored Jan 06, 2024

https://github.com/flutter/engine/compare/470b604b9abf...89ecf7503012

2024-01-05 skia-flutter-autoroll@skia.org Roll Skia from 2cae982f7f2f to 2345b9f2c943 (1 revision) (flutter/engine#49568)
2024-01-05 skia-flutter-autoroll@skia.org Roll Skia from c59cb89f8d15 to 2cae982f7f2f (3 revisions) (flutter/engine#49567)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4d97bd77

05 Jan, 2024 18 commits

Roll Flutter Engine from 3fd9c4ee4fc0 to 470b604b9abf (1 revision) (#141041) · d97fafa6

engine-flutter-autoroll authored Jan 05, 2024

https://github.com/flutter/engine/compare/3fd9c4ee4fc0...470b604b9abf

2024-01-05 skia-flutter-autoroll@skia.org Roll Skia from 9ec012033c2b to c59cb89f8d15 (1 revision) (flutter/engine#49565)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d97fafa6

Manual pub roll pinning web socket channel (#141040) · 6edbce9e

Christopher Fujino authored Jan 05, 2024

Work around https://github.com/flutter/flutter/issues/141032

Otherwise a re-land of https://github.com/flutter/flutter/pull/140979

Fixes https://github.com/flutter/flutter/issues/137163 & https://github.com/flutter/flutter/issues/139181

6edbce9e

in `flutter run`, throw tool exit when `--flavor` is provided but is not... · e90e4888

Andrew Kolos authored Jan 05, 2024

in `flutter run`, throw tool exit when `--flavor` is provided but is not supported on the target device (#139045)

Fixes https://github.com/flutter/flutter/issues/134197

e90e4888

add flavor-conditional asset bundling support to `flutter test` (#140944) · 8c11aa03
Andrew Kolos authored Jan 05, 2024
```
Fixes https://github.com/flutter/flutter/issues/140932
```
8c11aa03

Roll Flutter Engine from f3496a7185c2 to 3fd9c4ee4fc0 (4 revisions) (#141037) · 1a8de105

engine-flutter-autoroll authored Jan 05, 2024

https://github.com/flutter/engine/compare/f3496a7185c2...3fd9c4ee4fc0

2024-01-05 skia-flutter-autoroll@skia.org Roll Skia from 548827f77466 to 9ec012033c2b (1 revision) (flutter/engine#49564)
2024-01-05 skia-flutter-autoroll@skia.org Roll Skia from a006922df1c5 to 548827f77466 (1 revision) (flutter/engine#49561)
2024-01-05 skia-flutter-autoroll@skia.org Roll Skia from 52be1b25c3a2 to a006922df1c5 (4 revisions) (flutter/engine#49559)
2024-01-05 dnfield@google.com Allow spawning additional UI isolates in flutter_tester (flutter/engine#48706)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1a8de105

Gen l10n add named argument option (#138663) · e8436970
TabooSun authored Jan 05, 2024
```
Add an option to use named argument for generated method.

Fix #116308
```
e8436970

Fix refresh cancelation (#139535) · 0d6927cb

Luke Hutchison authored Jan 05, 2024

Changes drag release logic so that an armed refresh is only canceled if the user has scrolled back up beyond the point where the refresh indicator was armed. (Fixes https://github.com/flutter/flutter/issues/138848.)

This is the minimal change I found could be made to restore something like the behavior that I would expect.

This may still need a bit of work, because it only masks the second issue I mentioned, that releasing a drag can cause the scroll position to be animated back up from the release point. There is actually a bug about that: https://github.com/flutter/flutter/issues/6052. I would like to see that bug fixed too. This PR doesn't address that, but makes it harder to hit that issue.

@Piinks this is a recreation of #139015 (since I couldn't figure out some issue with a git detached branch, so I fixed the PR and I'm re-submitting it). This version includes one line that was somehow accidentally dropped from the original PR. This will hopefully fix the test failures.

However, I don't have a clue how to write a test for a Flutter UI widget. I'll try to figure that out, but also I don't have a lot of time to work on this. I would appreciate at least some user testing to verify that the new behavior is much more intuitive than the old behavior.

- [?] All existing and new tests are passing.

0d6927cb

Reverts "manual pub roll to pick up dds fixes" (#141033) · c2286a76

auto-submit[bot] authored Jan 05, 2024

Reverts flutter/flutter#140979
Initiated by: loic-sharma
This change reverts the following previous change:
Original Description:
Fixes https://github.com/flutter/flutter/issues/137163
Fixes https://github.com/flutter/flutter/issues/139181

c2286a76

Roll Flutter Engine from ec987365e63c to f3496a7185c2 (1 revision) (#141027) · e33ad055

engine-flutter-autoroll authored Jan 05, 2024

https://github.com/flutter/engine/compare/ec987365e63c...f3496a7185c2

2024-01-05 zoujunhua86@gmail.com Add build dependencies for Android Embedder (flutter/engine#48397)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e33ad055

Shift some macOS Android tests from Moto G4 to Pixel 7 Pro (#140912) · f1114596
Zachary Anderson authored Jan 05, 2024
```
Related https://github.com/flutter/flutter/issues/140893
```
f1114596

Roll Flutter Engine from c3189d767194 to ec987365e63c (1 revision) (#141023) · 344fcda9

engine-flutter-autoroll authored Jan 05, 2024

https://github.com/flutter/engine/compare/c3189d767194...ec987365e63c

2024-01-05 skia-flutter-autoroll@skia.org Roll Skia from 75e2f75aaa20 to 52be1b25c3a2 (2 revisions) (flutter/engine#49556)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

344fcda9

Roll Packages from 31fc7b5dd000 to b9b6d38e012b (8 revisions) (#141021) · 1fb12a13

engine-flutter-autoroll authored Jan 05, 2024

https://github.com/flutter/packages/compare/31fc7b5dd000...b9b6d38e012b

2024-01-05 engine-flutter-autoroll@skia.org Manual roll Flutter from 11def8ef to cc40425d (118 revisions) (flutter/packages#5806)
2024-01-05 magder@google.com [ci] Run 'flutter build --config-only for iOS and macOS during fetch deps (flutter/packages#5804)
2024-01-05 amirpanahandeh@yahoo.com [image_picker] Remove input element after completion (flutter/packages#5654)
2024-01-05 stuartmorgan@google.com [video_player] Fix initial frame on macOS (flutter/packages#5781)
2024-01-05 tarrinneal@gmail.com [pigeon] java non null void (flutter/packages#5786)
2024-01-04 10687576+bparrishMines@users.noreply.github.com [file_selector_android] Attempt to close system dialogs before integration tests run (flutter/packages#5805)
2024-01-04 stuartmorgan@google.com [tool] Handle Flutter dev dependencies (flutter/packages#5775)
2024-01-04 40719830+Alex-Usmanov@users.noreply.github.com [url_launcher] Add `InAppBrowserConfiguration` parameter (flutter/packages#5758)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1fb12a13

Roll Flutter Engine from 7e6348640940 to c3189d767194 (2 revisions) (#141016) · 81ae08df

engine-flutter-autoroll authored Jan 05, 2024

https://github.com/flutter/engine/compare/7e6348640940...c3189d767194

2024-01-05 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 0Q4I0x-Kt7T6DOE1b... to l0zn1BQFRjNyaZb-v... (flutter/engine#49552)
2024-01-05 skia-flutter-autoroll@skia.org Roll Skia from bdd1e88f3b83 to 75e2f75aaa20 (4 revisions) (flutter/engine#49551)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 0Q4I0x-Kt7T6 to l0zn1BQFRjNy

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

81ae08df

Fix scrollable `TabBar` expands to full width when the divider is removed (#140963) · 88016c11

Taha Tesser authored Jan 05, 2024

fixes [TabBar Expands to full width of the screen isScrollable: true after upgrading to flutter 3.16.4](https://github.com/flutter/flutter/issues/140338)

---

## Description

Fixes the scrollable `TabBar` width when the divider is removed. (when the divider height is set to `0` or divider color is set to `Colors.transparent`)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    const int tabsCount = 2;

    return MaterialApp(
      home: DefaultTabController(
        initialIndex: 1,
        length: tabsCount,
        child: Scaffold(
          appBar: AppBar(
            title: const Text('TabBar Sample'),
            bottom: PreferredSize(
              preferredSize: const Size.fromHeight(48.0),
              child: ColoredBox(
                color: Theme.of(context).colorScheme.secondaryContainer,
                child:  TabBar(
                  // dividerColor: Theme.of(context).colorScheme.onSurface,
                  dividerColor: Colors.transparent, // remove divider
                  // dividerHeight: 0, // remove divider
                  isScrollable: true,
                  tabAlignment: TabAlignment.center,
                  tabs: <Widget>[
                    for (int i = 0; i < tabsCount; i++)
                      Tab(
                        text: 'Tab $i',
                      ),
                  ],
                ),
              ),
            ),
          ),
        ),
      ),
    );
  }
}
```

</details>

### Before
![Simulator Screenshot - iPhone 15 Pro - 2024-01-04 at 15 16 15](https://github.com/flutter/flutter/assets/48603081/b776e7e6-e5f0-49df-8a79-55032eaad631)

### After
![Simulator Screenshot - iPhone 15 Pro - 2024-01-04 at 15 16 23](https://github.com/flutter/flutter/assets/48603081/9ad13793-43a9-4ae8-977e-7cf84cb59bb1)

88016c11

Roll Flutter Engine from 8c951851b14f to 7e6348640940 (1 revision) (#141004) · 89809bef

engine-flutter-autoroll authored Jan 05, 2024

https://github.com/flutter/engine/compare/8c951851b14f...7e6348640940

2024-01-05 skia-flutter-autoroll@skia.org Roll Skia from da75878a3aea to bdd1e88f3b83 (1 revision) (flutter/engine#49547)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

89809bef

Roll Flutter Engine from f2f00a438e40 to 8c951851b14f (1 revision) (#140997) · 43016dd1

engine-flutter-autoroll authored Jan 05, 2024

https://github.com/flutter/engine/compare/f2f00a438e40...8c951851b14f

2024-01-05 skia-flutter-autoroll@skia.org Roll Skia from dab831e8dcec to da75878a3aea (1 revision) (flutter/engine#49546)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

43016dd1

Roll Flutter Engine from f60d9a9a3395 to f2f00a438e40 (1 revision) (#140995) · 4ff2396b

engine-flutter-autoroll authored Jan 05, 2024

https://github.com/flutter/engine/compare/f60d9a9a3395...f2f00a438e40

2024-01-04 flar@google.com [Impeller] RenderPass now provides the Orthographic matrix (flutter/engine#49544)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4ff2396b

Roll Flutter Engine from 0bbb4d61ce82 to f60d9a9a3395 (1 revision) (#140993) · cc40425d

engine-flutter-autoroll authored Jan 05, 2024

https://github.com/flutter/engine/compare/0bbb4d61ce82...f60d9a9a3395

2024-01-04 30870216+gaaclarke@users.noreply.github.com [Impeller] migrate blur to calculating coefficients on the cpu (flutter/engine#49512)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cc40425d

04 Jan, 2024 17 commits

Roll Flutter Engine from b2a9ce88a19e to 0bbb4d61ce82 (3 revisions) (#140990) · 4db3bbe2

engine-flutter-autoroll authored Jan 04, 2024

https://github.com/flutter/engine/compare/b2a9ce88a19e...0bbb4d61ce82

2024-01-04 58190796+MitchellGoodwin@users.noreply.github.com Get the correct iOS system font for each weight (flutter/engine#48937)
2024-01-04 43054281+camsim99@users.noreply.github.com [Android] Re-land "Re-land 'Add target to have linux_android_emulator_tests run on AVDs with Android 33 & 34'" (flutter/engine#49101)
2024-01-04 godofredoc@google.com Use Mac M1s or x86 wherever possible. (flutter/engine#49540)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4db3bbe2

[web] Fix and unskip a few more CanvasKit tests (#140821) · 1fb95ba4

Yegor authored Jan 04, 2024

Fix and unskip the following CanvasKit tests:

- `test/painting/decoration_test.dart`
- `test/rendering/layers_test.dart`
- `test/widgets/app_overrides_test.dart`

1fb95ba4

Roll Flutter Engine from bd175aa5e0b6 to b2a9ce88a19e (1 revision) (#140986) · 4593e703

engine-flutter-autoroll authored Jan 04, 2024

https://github.com/flutter/engine/compare/bd175aa5e0b6...b2a9ce88a19e

2024-01-04 skia-flutter-autoroll@skia.org Roll Skia from 48ba1246efdf to dab831e8dcec (1 revision) (flutter/engine#49538)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4593e703

Pin package:vm_service (#140972) · 2d3166b7

Danny Tuppeny authored Jan 04, 2024

vm_service 14 should not be used yet (see
https://github.com/flutter/flutter/pull/140916#issuecomment-1877383354)
but when trying to unpin pkg:test it was upgraded. This pins it to
v13.0.0.

2d3166b7

Add scrollbar for menus (#140941) · be8a1eac

Qun Cheng authored Jan 04, 2024

Fixes #140162

This PR is to add a scrollbar for MenuAnchor and DropdownMenu for all platforms when height is limited. Previously, a scrollbar only shows on desktop platforms. This PR also disabled scrollbar's overscroll for MenuAnchor and DropdownMenu.

<img src="https://github.com/flutter/flutter/assets/36861262/9ca3d4d0-415f-43bf-9d2b-df96a42db620" width="250"/><img src="https://github.com/flutter/flutter/assets/36861262/18da8d02-586b-4aa4-b647-927691542429" width="350"/>

be8a1eac

manual pub roll to pick up dds fixes (#140979) · e256d491

Christopher Fujino authored Jan 04, 2024

Fixes https://github.com/flutter/flutter/issues/137163
Fixes https://github.com/flutter/flutter/issues/139181

e256d491

Roll Flutter Engine from b81023eb71c9 to bd175aa5e0b6 (2 revisions) (#140980) · 690b19c9

engine-flutter-autoroll authored Jan 04, 2024

https://github.com/flutter/engine/compare/b81023eb71c9...bd175aa5e0b6

2024-01-04 skia-flutter-autoroll@skia.org Roll Skia from e8e426f1429a to 48ba1246efdf (2 revisions) (flutter/engine#49537)
2024-01-04 skia-flutter-autoroll@skia.org Roll Skia from 9c2e9a2b06f3 to e8e426f1429a (11 revisions) (flutter/engine#49536)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

690b19c9

Temporarily remove env variable for leak tracking bots. (#140978) · b2f53e0c

Polina Cherkasova authored Jan 04, 2024

For some reasons there are [failures](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8759809744202981089/+/u/run_test.dart_for_framework_tests_shard_and_subshard_misc/test_stdout) in leak tracking bots, that do not relate to leak tracking.

There are two differences between leak tracking bots and 'normal' windows framework bots:

1. The flag "LEAK_TRACKING": "true". First failures happened before consumption of the flag "LEAK_TRACKING": "true" by testWidgets. Hypothesis: the failures may be caused by mechanisms that sets the env variable. This mechanism is used only by leak tracking bots.
2. bringup: true.

This PR removes the leak tracking env variable to isolate the first difference and verify if the bots will start passing.

b2f53e0c

Add Flutter CI status to README (#140513) · 49edbc74

Casey Hillers authored Jan 04, 2024

https://github.com/flutter/flutter/issues/140460

Follow up to https://github.com/flutter/flutter/pull/140461

49edbc74

Reland "integrate testWidgets with leak tracking" (#140521) (#140928) · 3ed03996
Polina Cherkasova authored Jan 04, 2024

3ed03996

Run half of iOS devicelab tests with Xcode 15 (#140927) · c9f23d05

Victoria Ashworth authored Jan 04, 2024

Since 50% of devicelab bots are on macOS 13, we can upgrade 50% of devicelab tests to Xcode 15.

There are 52 Mac_ios non-bringup tests, this PR updates 26 of them.

There are 4 Mac_arm64_ios non-bringup tests, this PR updates 2 of them.

Part of https://github.com/flutter/flutter/issues/140975

c9f23d05

Fix `SegmentedButton` states update logic (#140772) · 2ae39c0c
Sharabiddin Ahmayev authored Jan 04, 2024
```
This PR fixes: #140746

Desc: Style state update logic fix on SegmentedButton
```
2ae39c0c

Roll Flutter Engine from f539acfb8c5a to b81023eb71c9 (1 revision) (#140973) · 9ad47585

engine-flutter-autoroll authored Jan 04, 2024

https://github.com/flutter/engine/compare/f539acfb8c5a...b81023eb71c9

2024-01-04 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 7e9f7eab80d3 to 7f2523c2fa9a (3 revisions) (flutter/engine#49534)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9ad47585

[Fix] Consistency in ButtonStyleButton related Tests (#140610) · 64a73274

Tirth authored Jan 04, 2024

[Fix] Consistency in ButtonStyleButton related Tests:
- Replaced the usage of ElevatedButton with FilledButton in FilledButton's test.
- Replaced the usage of TextButton.styleFrom with FilledButton.styleFrom in FilledButton's test.
- Replaced the usage of TextButton.styleFrom with ElevatedButton.styleFrom in ElevatedButton's test.

64a73274

Roll Packages from bbb41347518e to 31fc7b5dd000 (6 revisions) (#140967) · 6ad032b7

engine-flutter-autoroll authored Jan 04, 2024

https://github.com/flutter/packages/compare/bbb41347518e...31fc7b5dd000

2024-01-04 christopherfujino@gmail.com bump mockito across repo to 5.4.4 (flutter/packages#5794)
2024-01-03 goderbauer@google.com [various] Sync lints with flutter/flutter (flutter/packages#5717)
2024-01-03 ditman@gmail.com [pointer_interceptor_web] Update package APIs and tests. (flutter/packages#5785)
2024-01-03 stuartmorgan@google.com [google_sign_in] Correct method channel `clearAuthCache` declaration (flutter/packages#5787)
2024-01-03 stuartmorgan@google.com [google_sign_in] Correct clearAuthCache declarations (flutter/packages#5693)
2024-01-03 15619084+vashworth@users.noreply.github.com Unpin mac_toolchain version (flutter/packages#5683)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6ad032b7

Fix local engine use in macOS plugins (#140222) · 24e06232

stuartmorgan authored Jan 04, 2024

Currently podhelper.rb will always point plugin builds at the cached engine artifacts, even when using `--local-engine`. In most cases this is fine, since when the final build actually runs it will be using the engine bundled into the app build, which will be the correct local engine build. When trying to test a local engine build with API additions against a local plugin modified to use those additions to ensure that they are working as expected, however, compilation will fail, because the new APIs won't be present in the plugin build.

This fixes that for macOS, and adds a TODO for iOS (which is more complicated to fix due to the host vs target build distinction).

macOS portion of https://github.com/flutter/flutter/issues/132228

24e06232

Roll Flutter Engine from 7d5a120a601b to f539acfb8c5a (2 revisions) (#140959) · a7035829

engine-flutter-autoroll authored Jan 04, 2024

https://github.com/flutter/engine/compare/7d5a120a601b...f539acfb8c5a

2024-01-04 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Wgogr8K1YZdo7yOnn... to 0Q4I0x-Kt7T6DOE1b... (flutter/engine#49529)
2024-01-04 mbrase@google.com [fuchsia] Remove LoggingSocketTest.UseSyslogOnFuchsia test (flutter/engine#49524)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Wgogr8K1YZdo to 0Q4I0x-Kt7T6

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a7035829