Commits · ce952e9aa8fafcbe2f95ba59561e60d3b97ff57d · abdullh.alsoleman / Front-End

03 Nov, 2023 13 commits

Roll Flutter Engine from 43653c5a3ec8 to 8531c5935356 (1 revision) (#137845) · ce952e9a

engine-flutter-autoroll authored Nov 03, 2023

https://github.com/flutter/engine/compare/43653c5a3ec8...8531c5935356

2023-11-03 matej.knopp@gmail.com Reland: [web] Ensure handled key event is not propagated to IME (flutter/engine#47099)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ce952e9a

Roll Packages from 33c2b4e53ad7 to cccf5d24d703 (6 revisions) (#137841) · 9d67f9ea

engine-flutter-autoroll authored Nov 03, 2023

https://github.com/flutter/packages/compare/33c2b4e53ad7...cccf5d24d703

2023-11-02 47866232+chunhtai@users.noreply.github.com [go_router] Fixes crashes when dynamically updates routing tables witâ¦ (flutter/packages#5242)
2023-11-02 43054281+camsim99@users.noreply.github.com [camerax] Fix `_getResolutionSelectorFromPreset` NPE (flutter/packages#5287)
2023-11-02 ybz975218925@live.com [go_router]Fixes the problem what pathParameters is null in redirect when the Router is recreated. (flutter/packages#5258)
2023-11-02 stuartmorgan@google.com [google_sign_in] Fix Obj-C formatting bug (flutter/packages#5310)
2023-11-02 goderbauer@google.com Fix mounted checks (flutter/packages#5305)
2023-11-02 srawlins@google.com [flutter_image] [flutter_markdown] Do not use dynamic in an == operator override (flutter/packages#5298)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9d67f9ea

[web] dispatch corresponding keyup events in text editing integrations (#136874) · 62bd4874

Matej Knopp authored Nov 03, 2023

https://github.com/flutter/engine/pull/46829 changed event handling
sequence on web so that KeyboardBinding/RawKeyboard handles the text
event first before it reaches IME. That means when dispatching
synthetised events to IME every keydown event must have a corresponding
keyup, otherwise consistency assertions in `KeyboardBindings` are
triggered.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

62bd4874

[leak-tracking] Add more leak tracking in test/painting #3 (#136170) · 8e7fce98
Binni Goel authored Nov 03, 2023

8e7fce98
Upgrade leak_tracker and remove some deps in allow list. (#137806) · e1b420cd
Polina Cherkasova authored Nov 03, 2023

e1b420cd

Roll Flutter Engine from fc7c3f70c076 to 43653c5a3ec8 (1 revision) (#137827) · 9c4d1554

engine-flutter-autoroll authored Nov 03, 2023

https://github.com/flutter/engine/compare/fc7c3f70c076...43653c5a3ec8

2023-11-03 skia-flutter-autoroll@skia.org Roll Skia from 3db534b066e0 to e5a6f9e79b0a (1 revision) (flutter/engine#47642)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9c4d1554

Roll Flutter Engine from d1b29a1bea0b to fc7c3f70c076 (1 revision) (#137826) · daad9455

engine-flutter-autoroll authored Nov 03, 2023

https://github.com/flutter/engine/compare/d1b29a1bea0b...fc7c3f70c076

2023-11-03 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from bhSlAQy4VM3Plrlh4... to y-hqwYkPPVT6RwmAS... (flutter/engine#47641)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from bhSlAQy4VM3P to y-hqwYkPPVT6

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

daad9455

Roll Flutter Engine from 78e8475ddbd7 to d1b29a1bea0b (2 revisions) (#137825) · 35ec26b0

engine-flutter-autoroll authored Nov 03, 2023

https://github.com/flutter/engine/compare/78e8475ddbd7...d1b29a1bea0b

2023-11-03 skia-flutter-autoroll@skia.org Roll Skia from 745825a18444 to 3db534b066e0 (1 revision) (flutter/engine#47640)
2023-11-03 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from YS7vrarYI-cHvhuBT... to ho9FqsUD0hxh0b8to... (flutter/engine#47638)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from YS7vrarYI-cH to ho9FqsUD0hxh

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

35ec26b0

Roll Flutter Engine from e3f81ed27cc7 to 78e8475ddbd7 (1 revision) (#137820) · ef8deb5d

engine-flutter-autoroll authored Nov 03, 2023

https://github.com/flutter/engine/compare/e3f81ed27cc7...78e8475ddbd7

2023-11-03 skia-flutter-autoroll@skia.org Roll Skia from 525a1487e501 to 745825a18444 (1 revision) (flutter/engine#47636)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ef8deb5d

Roll Flutter Engine from dff66925dcfa to e3f81ed27cc7 (3 revisions) (#137819) · 284abe2b

engine-flutter-autoroll authored Nov 03, 2023

https://github.com/flutter/engine/compare/dff66925dcfa...e3f81ed27cc7

2023-11-03 skia-flutter-autoroll@skia.org Roll Skia from 9f6022736b14 to 525a1487e501 (1 revision) (flutter/engine#47635)
2023-11-03 skia-flutter-autoroll@skia.org Roll Skia from 5b6d295cc39b to 9f6022736b14 (1 revision) (flutter/engine#47633)
2023-11-03 jonahwilliams@google.com [Impeller] Use specialization constant for blur pipelines decal feature. (flutter/engine#47617)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

284abe2b

Roll Flutter Engine from 57768e18ed74 to dff66925dcfa (1 revision) (#137813) · 0b591f2c

engine-flutter-autoroll authored Nov 03, 2023

https://github.com/flutter/engine/compare/57768e18ed74...dff66925dcfa

2023-11-03 skia-flutter-autoroll@skia.org Roll Skia from 3b8e2b391d03 to 5b6d295cc39b (1 revision) (flutter/engine#47630)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0b591f2c

Roll Flutter Engine from dd620fcf9af7 to 57768e18ed74 (2 revisions) (#137811) · 7802ae11

engine-flutter-autoroll authored Nov 03, 2023

https://github.com/flutter/engine/compare/dd620fcf9af7...57768e18ed74

2023-11-02 skia-flutter-autoroll@skia.org Roll Skia from 86d15e651ae0 to 3b8e2b391d03 (1 revision) (flutter/engine#47627)
2023-11-02 31859944+LongCatIsLooong@users.noreply.github.com Reland "Expose more methods on ui.Paragraph: lines" (#47584) (flutter/engine#47623)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7802ae11

[flutter_tools] do not try to build tool from dart.sh (#129186) · b0bc023f
Christopher Fujino authored Nov 03, 2023
```
Fixes https://github.com/flutter/flutter/issues/121894
```
b0bc023f

02 Nov, 2023 27 commits

Roll Flutter Engine from d9b6245d3748 to dd620fcf9af7 (2 revisions) (#137803) · 1c8c5336

engine-flutter-autoroll authored Nov 02, 2023

https://github.com/flutter/engine/compare/d9b6245d3748...dd620fcf9af7

2023-11-02 flar@google.com [Impeller] Deprecate the exposed Rect fields (flutter/engine#47592)
2023-11-02 skia-flutter-autoroll@skia.org Manual roll Dart SDK from e6df03a57636 to 3c45f68cd7c2 (4 revisions) (flutter/engine#47620)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1c8c5336

Roll Flutter Engine from ef4ce9294299 to d9b6245d3748 (2 revisions) (#137799) · 6821cc6b

engine-flutter-autoroll authored Nov 02, 2023

https://github.com/flutter/engine/compare/ef4ce9294299...d9b6245d3748

2023-11-02 skia-flutter-autoroll@skia.org Roll Skia from 66e06117294e to 86d15e651ae0 (1 revision) (flutter/engine#47619)
2023-11-02 skia-flutter-autoroll@skia.org Roll Skia from 94000281b7d6 to 66e06117294e (1 revision) (flutter/engine#47616)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6821cc6b

[Android] Support Android 34 (#137191) · 675fec80

Camille Simon authored Nov 02, 2023

Adds support for Android 34 in the following ways:

- Bumps integration tests compile SDK versions 33 --> 34
- Bumps template compile SDK version 33 --> 34
- Also changes deprecated `compileSdkVersion` to `compileSdk`

Part of https://github.com/flutter/flutter/issues/134220

675fec80

Roll Flutter Engine from 1e2eee05855f to ef4ce9294299 (3 revisions) (#137795) · 15451e49

engine-flutter-autoroll authored Nov 02, 2023

https://github.com/flutter/engine/compare/1e2eee05855f...ef4ce9294299

2023-11-02 skia-flutter-autoroll@skia.org Roll Skia from 306543797674 to 94000281b7d6 (1 revision) (flutter/engine#47614)
2023-11-02 godofredoc@google.com Remove mirroring workflow from engine. (flutter/engine#47603)
2023-11-02 athom@google.com Add a temporary fallback to move run_binary_file_analysis.py (flutter/engine#47598)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

15451e49

Protect flutter analyze --suggestions from erroring on missing AGP value. (#137719) · 4d21a026

Reid Baker authored Nov 02, 2023

Fixes #137600
Protect flutter analyze --suggestions from null error when AGP value is missing
Update template with a reference to new agp definition location
Look for AGP version being set in settings.gradle (change to templates happened in https://github.com/flutter/flutter/commit/dbe0ccd8853dabdcb0f94ce2cdef892a1b10e48a#diff-20537fb84ee37894a3f3d9723a06bcf2674290ee25aa83332c2524a1f7546a6d

4d21a026

Provide more information in 'unsupported class file' gradle error (#136756) · 969a8750

Gray Mackall authored Nov 02, 2023

Fixes https://github.com/flutter/flutter/issues/130808. Short context is that the migration guide doesn't help when a user has a newer java version than 17, and this tells them how to fix the error in that situation.

This is an alternative to https://github.com/flutter/flutter/pull/131354, because I think it is a bad idea to introduce branching in how we handle this error with some specialized regexp.

969a8750

Roll Flutter Engine from b11e318b3690 to 1e2eee05855f (4 revisions) (#137789) · 474a8561

engine-flutter-autoroll authored Nov 02, 2023

https://github.com/flutter/engine/compare/b11e318b3690...1e2eee05855f

2023-11-02 skia-flutter-autoroll@skia.org Roll Skia from 2b3472da9888 to 306543797674 (5 revisions) (flutter/engine#47610)
2023-11-02 15619084+vashworth@users.noreply.github.com Run tests on either macOS 12 or 13 (flutter/engine#47606)
2023-11-02 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 32ukjtetQl4pbXfTw... to bhSlAQy4VM3Plrlh4... (flutter/engine#47611)
2023-11-02 dnfield@google.com [Impeller] Skia gold for flutter_tester dart tests. (flutter/engine#47066)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 32ukjtetQl4p to bhSlAQy4VM3P

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

474a8561

Avoid passing a nullable value to potentially non-nullable parameters (#137359) · d796b013

Sam Rawlins authored Nov 02, 2023

Also ignore one case where it is hard to fix.

The code with out the null assertion is legal as per the type signature,
but will throw a runtime exception if the nullable value is null. To
make this exception more explicit, the value must be null-checked before
completing the completer with the value.

The analyzer will soon enforce such checks. See
https://github.com/dart-lang/sdk/issues/53253.

Fixes https://github.com/flutter/flutter/issues/137294

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

d796b013

Chore/gradle remove redundant apply (#135348) · 3bc64e8f

Bartek Pacia authored Nov 02, 2023

I'm removing an unneded block of configuration from the `settings.gradle` template. It was introduced by me in #123511. At that time, I did not know that it's unnecessary, and did not test removing it â sorry about that.

I learned that it's unnecessary recently, when [I asked a question on StackOverflow](https://stackoverflow.com/questions/77073596/whats-the-difference-between-plugins-and-pluginmanagement-plugins-in). More context there.

3bc64e8f

Roll Flutter Engine from 2ec0f74a1e8a to b11e318b3690 (2 revisions) (#137785) · 5a0ef34d

engine-flutter-autoroll authored Nov 02, 2023

https://github.com/flutter/engine/compare/2ec0f74a1e8a...b11e318b3690

2023-11-02 skia-flutter-autoroll@skia.org Roll Skia from 70634da5c783 to 2b3472da9888 (5 revisions) (flutter/engine#47608)
2023-11-02 jonahwilliams@google.com [Impeller] add support for specialization constants. (flutter/engine#47432)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5a0ef34d

Migrate api docs from master to main. (#137726) · 90c73055

godofredoc authored Nov 02, 2023

This is the first of a series of changes to migrate to remove master-docs-flutter-dev GCP project.

Bug: https://github.com/flutter/flutter/issues/133877

90c73055

Roll Flutter Engine from 16d54bda1613 to 2ec0f74a1e8a (1 revision) (#137777) · 92ea5e0a

engine-flutter-autoroll authored Nov 02, 2023

https://github.com/flutter/engine/compare/16d54bda1613...2ec0f74a1e8a

2023-11-02 skia-flutter-autoroll@skia.org Roll Skia from 8299245af8a8 to 70634da5c783 (1 revision) (flutter/engine#47604)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

92ea5e0a

Fix mounted checks (#137778) · b09c70a9

Michael Goderbauer authored Nov 02, 2023

Fixes in preparation for https://dart-review.googlesource.com/c/sdk/+/330561.

The change referenced above tightens the `use_build_context_synchronously` to ensure that `mounted` is checked on the appropriate `BuildContext` or `State`. This change fixes up the flutter/flutter in preparation of this new enforcement.

b09c70a9

Fixes `DragTarget` crash if `Draggable.data` is `null` (#133136) · f15f2313

Valentin Vignal authored Nov 02, 2023

Makes the `data` parameter of `Draggable` non-nullable.

Fixes https://github.com/flutter/flutter/issues/84816

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

f15f2313

Cupertino date picker should dispose scroll controllers it created. (#135355) · 7646430c
derdilla authored Nov 02, 2023

7646430c

Roll Flutter Engine from be49d6595ddd to 16d54bda1613 (1 revision) (#137774) · 24adfe1c

engine-flutter-autoroll authored Nov 02, 2023

https://github.com/flutter/engine/compare/be49d6595ddd...16d54bda1613

2023-11-02 15619084+vashworth@users.noreply.github.com Fix race condition in Platform View Scenario tests (flutter/engine#47575)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

24adfe1c

Update `IconButton.iconSize` documentation (#137741) · 615dd968

Qun Cheng authored Nov 02, 2023

fixes https://github.com/flutter/flutter/issues/137580

---

This PR is just to add two sentences for `IconButton.iconSize`'s documentation.

615dd968

Remove duplicate padding on CupertinoFormSection (#137039) · 55eb5e11

Jasper van Riet authored Nov 02, 2023

Fixes #128419, removes the duplicate padding that exists around the header and footer on `CupertinoFormSection`. This PR takes the implementation in #129065 and adds tests. I added the ones suggested in the PR review, as well as one more to test that `margin` is passed correctly from `CupertinoFormSection` to `CupertinoListSection`.

Note: I can't quite figure out if this is also a fix to #121543.

Potential review questions:

- Is the use of `offsetMoreOrLessEquals` here correct? I used it because of the vertical positioning. The horizontal positioning is always exact.

### Screenshots
<details>
  <summary>Before</summary>
  
![image](https://github.com/flutter/flutter/assets/5138348/1bce10c9-706a-40c8-a581-2dcb574ed937)
</details>
<details>
  <summary>After</summary>
  
![image](https://github.com/flutter/flutter/assets/5138348/cd1d529b-7be5-45df-af31-0f7760dc3fe9)
</details>

55eb5e11

Roll Flutter Engine from 4ba585b2ad91 to be49d6595ddd (2 revisions) (#137767) · 06a66670

engine-flutter-autoroll authored Nov 02, 2023

https://github.com/flutter/engine/compare/4ba585b2ad91...be49d6595ddd

2023-11-02 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from pvAbHwPJtOuEpHJN7... to YS7vrarYI-cHvhuBT... (flutter/engine#47602)
2023-11-02 jason-simmons@users.noreply.github.com Update DisplayList tests to explicitly select the Roboto font (flutter/engine#47493)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from pvAbHwPJtOuE to YS7vrarYI-cH

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

06a66670

Roll Flutter Engine from bd23e33a05a0 to 4ba585b2ad91 (1 revision) (#137764) · 2cca5762

engine-flutter-autoroll authored Nov 02, 2023

https://github.com/flutter/engine/compare/bd23e33a05a0...4ba585b2ad91

2023-11-02 skia-flutter-autoroll@skia.org Roll Skia from 54be0f6f205b to 8299245af8a8 (2 revisions) (flutter/engine#47601)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2cca5762

Roll Packages from 6ad40b9a07d3 to 33c2b4e53ad7 (3 revisions) (#137763) · 8d2fe7dc

engine-flutter-autoroll authored Nov 02, 2023

https://github.com/flutter/packages/compare/6ad40b9a07d3...33c2b4e53ad7

2023-11-02 ditman@gmail.com [google_sign_in] Enable FedCM for web. Use token expiration. (flutter/packages#5225)
2023-11-01 ditman@gmail.com [video_player_web] Listen to loadedmetadata event from video element. (flutter/packages#5289)
2023-11-01 stuartmorgan@google.com [local_auth] Update iOS to Pigeon 13 (flutter/packages#5269)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8d2fe7dc

Marks Windows build_tests_1_6 to be unflaky (#137673) · 87c8e241

Flutter GitHub Bot authored Nov 02, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows build_tests_1_6"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20build_tests_1_6%22).
This test can be marked as unflaky.

87c8e241

Marks Windows build_tests_4_6 to be unflaky (#137674) · 41e92351

Flutter GitHub Bot authored Nov 02, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows build_tests_4_6"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20build_tests_4_6%22).
This test can be marked as unflaky.

41e92351

Roll Flutter Engine from 0dd251e7ef6d to bd23e33a05a0 (1 revision) (#137762) · cb3191ec

engine-flutter-autoroll authored Nov 02, 2023

https://github.com/flutter/engine/compare/0dd251e7ef6d...bd23e33a05a0

2023-11-02 skia-flutter-autoroll@skia.org Roll Skia from ff5e220c57e4 to 54be0f6f205b (1 revision) (flutter/engine#47599)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cb3191ec

Instrument ImageStreamCompleterHandle for LeakTracking (#137482) · 39f29741
Binni Goel authored Nov 02, 2023

39f29741
Instrumented PipelineOwner for leak tracking (#137494) · e2d5e8fd
Binni Goel authored Nov 02, 2023

e2d5e8fd

Roll Flutter Engine from 3c1e8f457e3d to 0dd251e7ef6d (2 revisions) (#137759) · 7308207c

engine-flutter-autoroll authored Nov 02, 2023

https://github.com/flutter/engine/compare/3c1e8f457e3d...0dd251e7ef6d

2023-11-02 skia-flutter-autoroll@skia.org Roll Skia from 86ce6e04fddf to ff5e220c57e4 (1 revision) (flutter/engine#47593)
2023-11-02 skia-flutter-autoroll@skia.org Roll Skia from 8a5e27e4607c to 86ce6e04fddf (1 revision) (flutter/engine#47591)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7308207c