Commits · ce39d01d520951b97ea19c3b375c55aa040d1ed4 · abdullh.alsoleman / Front-End

12 Sep, 2023 16 commits

Roll Flutter Engine from 25be03186d82 to 8a8ddaeecf8a (1 revision) (#134545) · ce39d01d

engine-flutter-autoroll authored Sep 12, 2023

https://github.com/flutter/engine/compare/25be03186d82...8a8ddaeecf8a

2023-09-12 skia-flutter-autoroll@skia.org Roll Skia from a1ff98bebf89 to 7e9b94634911 (2 revisions) (flutter/engine#45707)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ce39d01d

Roll Packages from ef0c65ea4ccd to e04ba886a85e (5 revisions) (#134546) · f9aef4f2

engine-flutter-autoroll authored Sep 12, 2023

https://github.com/flutter/packages/compare/ef0c65ea4ccd...e04ba886a85e

2023-09-12 stuartmorgan@google.com [tool] Add a package inclusion filter (flutter/packages#4904)
2023-09-12 me@nils.re [flutter_markdown] Fix changelog regarding minimum supported SDK version (flutter/packages#4851)
2023-09-12 stuartmorgan@google.com [ios_platform_images] Add integration tests (flutter/packages#4899)
2023-09-12 robert@odrowaz.dev [image_picker] Copy exif tags in categories II and III (flutter/packages#4738)
2023-09-11 233583+mossmana@users.noreply.github.com [google_maps_flutter_android] Fix for testToggleInfoWindow persistently flaky (flutter/packages#4768)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f9aef4f2

Revert "Adds a parent scope TraversalEdgeBehavior and fixes modal rou… (#134550) · 5900c4ba

chunhtai authored Sep 12, 2023

…te to no… (#130841)"

This reverts commit 0f3bd90d.

Internal test needs migration

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

5900c4ba

Marks Windows_android channels_integration_test_win to be unflaky (#133129) · bdd96032

Flutter GitHub Bot authored Sep 12, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows_android channels_integration_test_win"
}
-->
The issue https://github.com/flutter/flutter/issues/130732 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_android%20channels_integration_test_win%22).
This test can be marked as unflaky.

bdd96032

Roll Flutter Engine from 4091167e402d to 25be03186d82 (1 revision) (#134536) · 9e891f2d

engine-flutter-autoroll authored Sep 12, 2023

https://github.com/flutter/engine/compare/4091167e402d...25be03186d82

2023-09-12 skia-flutter-autoroll@skia.org Roll Skia from 55c9c377f0b0 to a1ff98bebf89 (1 revision) (flutter/engine#45706)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9e891f2d

Roll Flutter Engine from 54175da7ba90 to 4091167e402d (1 revision) (#134532) · 127c76b9

engine-flutter-autoroll authored Sep 12, 2023

https://github.com/flutter/engine/compare/54175da7ba90...4091167e402d

2023-09-12 skia-flutter-autoroll@skia.org Roll Skia from 8d11fcb3068a to 55c9c377f0b0 (1 revision) (flutter/engine#45705)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

127c76b9

Roll Flutter Engine from 85f3f02e5c37 to 54175da7ba90 (2 revisions) (#134531) · 278b145a

engine-flutter-autoroll authored Sep 12, 2023

https://github.com/flutter/engine/compare/85f3f02e5c37...54175da7ba90

2023-09-12 skia-flutter-autoroll@skia.org Roll Skia from 5b94fc73a36e to 8d11fcb3068a (1 revision) (flutter/engine#45703)
2023-09-12 skia-flutter-autoroll@skia.org Roll Skia from 72e5b5c8d5f0 to 5b94fc73a36e (1 revision) (flutter/engine#45701)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

278b145a

Roll Flutter Engine from 1369ab35aaa7 to 85f3f02e5c37 (1 revision) (#134519) · ac79c846

engine-flutter-autoroll authored Sep 12, 2023

https://github.com/flutter/engine/compare/1369ab35aaa7...85f3f02e5c37

2023-09-12 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from fSmVaZwp41ZGp5hKn... to QgAHx3BtJfN3TmodS... (flutter/engine#45700)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from fSmVaZwp41ZG to QgAHx3BtJfN3

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ac79c846

Roll Flutter Engine from 2f1efe5967f3 to 1369ab35aaa7 (1 revision) (#134512) · bb079949

engine-flutter-autoroll authored Sep 12, 2023

https://github.com/flutter/engine/compare/2f1efe5967f3...1369ab35aaa7

2023-09-12 skia-flutter-autoroll@skia.org Roll Skia from 9f92b15074a6 to 72e5b5c8d5f0 (1 revision) (flutter/engine#45696)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bb079949

Roll Flutter Engine from 4d8265cbc133 to 2f1efe5967f3 (3 revisions) (#134511) · 6f96d5eb

engine-flutter-autoroll authored Sep 12, 2023

https://github.com/flutter/engine/compare/4d8265cbc133...2f1efe5967f3

2023-09-12 skia-flutter-autoroll@skia.org Roll Skia from ba5d081cd448 to 9f92b15074a6 (1 revision) (flutter/engine#45695)
2023-09-12 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 3.1.2 to 3.1.3 (flutter/engine#45694)
2023-09-12 skia-flutter-autoroll@skia.org Roll Skia from 62aa41ee8135 to ba5d081cd448 (3 revisions) (flutter/engine#45692)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6f96d5eb

Roll Flutter Engine from ee7215553deb to 4d8265cbc133 (1 revision) (#134506) · c7f38599

engine-flutter-autoroll authored Sep 12, 2023

https://github.com/flutter/engine/compare/ee7215553deb...4d8265cbc133

2023-09-12 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from cUKimo52R-2EIfHh5... to vGleXqh2SRUNJM7JN... (flutter/engine#45691)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from cUKimo52R-2E to vGleXqh2SRUN

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c7f38599

Roll Flutter Engine from 6ddee4423d2c to ee7215553deb (2 revisions) (#134505) · e95c745b

engine-flutter-autoroll authored Sep 12, 2023

https://github.com/flutter/engine/compare/6ddee4423d2c...ee7215553deb

2023-09-12 skia-flutter-autoroll@skia.org Roll Skia from c4e94d5febdc to 62aa41ee8135 (2 revisions) (flutter/engine#45690)
2023-09-12 matanlurey@users.noreply.github.com [Impeller] Fix thread leak in ResourceManagerVK. (flutter/engine#45686)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e95c745b

Roll Flutter Engine from a98348946d61 to 6ddee4423d2c (1 revision) (#134490) · bc594bd4

engine-flutter-autoroll authored Sep 12, 2023

https://github.com/flutter/engine/compare/a98348946d61...6ddee4423d2c

2023-09-12 matej.knopp@gmail.com [Web] Properly report inverted selection (flutter/engine#44806)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bc594bd4

[New feature] Allowing the `ListView` slivers to have different extents while... · a9fac733

xubaolin authored Sep 12, 2023

[New feature] Allowing the `ListView` slivers to have different extents while still having scrolling performance (#131393)

Fixes https://github.com/flutter/flutter/issues/113431

Currently we only support specifying all slivers to have the same extent.
This patch introduces an `itemExtentBuilder` property for `ListView`, allowing the slivers to have different extents while still having scrolling performance, especially when the scroll position changes drastically(such as scrolling by the scrollbar or controller.jumpTo()).

@Piinks Hi, Any thoughts about this?  :)

a9fac733

Roll Flutter Engine from 8389ad914b21 to a98348946d61 (4 revisions) (#134487) · e645fb7d

engine-flutter-autoroll authored Sep 12, 2023

https://github.com/flutter/engine/compare/8389ad914b21...a98348946d61

2023-09-12 jason-simmons@users.noreply.github.com Roll libwebp to 1.3.1 (flutter/engine#45675)
2023-09-11 skia-flutter-autoroll@skia.org Roll Skia from 0b8d2203ab35 to c4e94d5febdc (5 revisions) (flutter/engine#45679)
2023-09-11 chinmaygarde@google.com Pipe VMA asserts to FML. (flutter/engine#45661)
2023-09-11 skia-flutter-autoroll@skia.org Roll Skia from e6225224fb4e to 0b8d2203ab35 (9 revisions) (flutter/engine#45671)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e645fb7d

ScaleGestureRecognizer: make pointerCount public (#127310) · 82cb7493

Kohei Seino authored Sep 12, 2023

make `pointCount` in `ScaleGestureRecognizer` public to handle pointer event depending on the number of pointers.

https://github.com/flutter/flutter/issues/127309

82cb7493

11 Sep, 2023 17 commits

Fix DataTable example not being scrollable (#131556) · 4a3ab682
Chinmay Kabi authored Sep 11, 2023

4a3ab682

Roll Flutter Engine from 06696e768c1b to 8389ad914b21 (2 revisions) (#134469) · 0770c60a

engine-flutter-autoroll authored Sep 11, 2023

https://github.com/flutter/engine/compare/06696e768c1b...8389ad914b21

2023-09-11 109111084+yaakovschectman@users.noreply.github.com Merge `Window` into `FlutterWindow` (flutter/engine#45542)
2023-09-11 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 7Zk_dvFh301kgQte4... to fSmVaZwp41ZGp5hKn... (flutter/engine#45665)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 7Zk_dvFh301k to fSmVaZwp41ZG

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0770c60a

[flutter_tools] disallow -O0 for flutter build web (#134185) · b76b82aa

Christopher Fujino authored Sep 11, 2023

Fixes https://github.com/flutter/flutter/issues/133404.

Per the dart2js team on the linked issue, `-O0` is not intended for end users, but more for actual debugging/development of the compiler.

b76b82aa

Cover focus tests with leak tracking (#134457) · adaf78a6
Kostia Sokolovskyi authored Sep 11, 2023

adaf78a6

Roll Flutter Engine from 0774ddcda9b0 to 06696e768c1b (4 revisions) (#134462) · b90c1a87

engine-flutter-autoroll authored Sep 11, 2023

https://github.com/flutter/engine/compare/0774ddcda9b0...06696e768c1b

2023-09-11 jacksongardner@google.com Revert "Remove some of our hacks around JSPromise now that we have better APIs." (flutter/engine#45660)
2023-09-11 skia-flutter-autoroll@skia.org Roll Skia from 3ed290acb65f to e6225224fb4e (2 revisions) (flutter/engine#45658)
2023-09-11 kjlubick@users.noreply.github.com Update skwasm build to use safer flush call (flutter/engine#45652)
2023-09-11 jacksongardner@google.com Remove some of our hacks around JSPromise now that we have better APIs. (flutter/engine#45591)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b90c1a87

Fix memory leak in RenderAnimatedSize (#133653) · e7058f56

Kostia Sokolovskyi authored Sep 11, 2023

`AnimationController` and `CurvedAnimation` objects were not disposed in `RenderAnimatedSize`.

### Description
- Fixes https://github.com/flutter/flutter/issues/133903;
- Adds the missing `dispose()` calls for `AnimationController` and `CurvedAnimation` in `RenderAnimatedSize`.

### Tests
- Updates `animated_size_test.dart` to test that `AnimationController` and `CurvedAnimation` are disposed after `RenderSize` disposal.

e7058f56

Roll Flutter Engine from e42fd367adcb to 0774ddcda9b0 (1 revision) (#134447) · 969911d1

engine-flutter-autoroll authored Sep 11, 2023

https://github.com/flutter/engine/compare/e42fd367adcb...0774ddcda9b0

2023-09-11 skia-flutter-autoroll@skia.org Roll Skia from 2fa311521fb2 to 3ed290acb65f (1 revision) (flutter/engine#45653)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

969911d1

Roll Flutter Engine from d593002b7159 to e42fd367adcb (1 revision) (#134444) · 9dbbd5b4

engine-flutter-autoroll authored Sep 11, 2023

https://github.com/flutter/engine/compare/d593002b7159...e42fd367adcb

2023-09-11 30870216+gaaclarke@users.noreply.github.com Revert "Makes Skia's vkQueueSubmit threadsafe." (flutter/engine#45650)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9dbbd5b4

Roll Packages from aaae5ef97a45 to ef0c65ea4ccd (6 revisions) (#134445) · b831c9f4

engine-flutter-autoroll authored Sep 11, 2023

https://github.com/flutter/packages/compare/aaae5ef97a45...ef0c65ea4ccd

2023-09-11 engine-flutter-autoroll@skia.org Roll Flutter from 7c28e8eb to 219efce7 (16 revisions) (flutter/packages#4901)
2023-09-11 chris.langham32@gmail.com [url_launcher] migrating iOS tests from objc to swift (flutter/packages#4758)
2023-09-09 engine-flutter-autoroll@skia.org Roll Flutter from da676f79 to 7c28e8eb (20 revisions) (flutter/packages#4879)
2023-09-09 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 3.1.2 to 3.1.3 (flutter/packages#4863)
2023-09-08 engine-flutter-autoroll@skia.org Roll Flutter from aea4552a to da676f79 (28 revisions) (flutter/packages#4874)
2023-09-08 48349434+paulppn@users.noreply.github.com [webview_flutter_android] Added the functionality to fullscreen html5 video (flutter/packages#3879)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b831c9f4

Roll Flutter Engine from 2b5961cbc40d to d593002b7159 (3 revisions) (#134439) · 6562d526

engine-flutter-autoroll authored Sep 11, 2023

https://github.com/flutter/engine/compare/2b5961cbc40d...d593002b7159

2023-09-11 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from SFM4ele7RYnVMhr7S... to cUKimo52R-2EIfHh5... (flutter/engine#45647)
2023-09-11 kjlubick@users.noreply.github.com Use safer GrDirectContext APIs (flutter/engine#45644)
2023-09-11 skia-flutter-autoroll@skia.org Roll Skia from 787b61f00100 to 2fa311521fb2 (1 revision) (flutter/engine#45642)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from SFM4ele7RYnV to cUKimo52R-2E

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6562d526

Mark leak: instances of OpacityLayer, created by _RenderChip, should be disposed. (#134395) · 0844726a
Polina Cherkasova authored Sep 11, 2023

0844726a
Cover more tests with leak tracking. (#134363) · 219efce7
Polina Cherkasova authored Sep 11, 2023

219efce7

Roll Flutter Engine from e9f1696e5060 to 2b5961cbc40d (1 revision) (#134424) · 6de4e169

engine-flutter-autoroll authored Sep 11, 2023

https://github.com/flutter/engine/compare/e9f1696e5060...2b5961cbc40d

2023-09-11 skia-flutter-autoroll@skia.org Roll Skia from 4c50e0870461 to 787b61f00100 (1 revision) (flutter/engine#45639)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6de4e169

Roll Flutter Engine from ac6be4dbf821 to e9f1696e5060 (1 revision) (#134410) · c6fa2616

engine-flutter-autoroll authored Sep 11, 2023

https://github.com/flutter/engine/compare/ac6be4dbf821...e9f1696e5060

2023-09-11 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 6PrTSjMiSCsSb0muF... to 7Zk_dvFh301kgQte4... (flutter/engine#45636)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 6PrTSjMiSCsS to 7Zk_dvFh301k

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c6fa2616

Roll Flutter Engine from 1aa11b644855 to ac6be4dbf821 (1 revision) (#134407) · 954444a0

engine-flutter-autoroll authored Sep 11, 2023

https://github.com/flutter/engine/compare/1aa11b644855...ac6be4dbf821

2023-09-11 skia-flutter-autoroll@skia.org Roll Skia from 2e80ffb2ebea to 4c50e0870461 (1 revision) (flutter/engine#45635)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

954444a0

Roll Flutter Engine from 7e41b064eb23 to 1aa11b644855 (2 revisions) (#134404) · ffe1ebd2

engine-flutter-autoroll authored Sep 11, 2023

https://github.com/flutter/engine/compare/7e41b064eb23...1aa11b644855

2023-09-11 skia-flutter-autoroll@skia.org Roll Skia from 5aff628b1c47 to 2e80ffb2ebea (1 revision) (flutter/engine#45634)
2023-09-11 skia-flutter-autoroll@skia.org Roll Skia from 947f91dcacf5 to 5aff628b1c47 (1 revision) (flutter/engine#45633)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ffe1ebd2

Roll Flutter Engine from 04d836f69571 to 7e41b064eb23 (1 revision) (#134396) · 69f6e7d1

engine-flutter-autoroll authored Sep 11, 2023

https://github.com/flutter/engine/compare/04d836f69571...7e41b064eb23

2023-09-11 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from a024p4HJVVgmCW5Jo... to SFM4ele7RYnVMhr7S... (flutter/engine#45632)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from a024p4HJVVgm to SFM4ele7RYnV

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

69f6e7d1

10 Sep, 2023 7 commits

Roll Flutter Engine from 2acd60d6baed to 04d836f69571 (1 revision) (#134392) · 0d9ea627

engine-flutter-autoroll authored Sep 10, 2023

https://github.com/flutter/engine/compare/2acd60d6baed...04d836f69571

2023-09-10 skia-flutter-autoroll@skia.org Roll Skia from 4eea73a072d3 to 947f91dcacf5 (1 revision) (flutter/engine#45629)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0d9ea627

Roll Flutter Engine from 59b08263f7cc to 2acd60d6baed (1 revision) (#134391) · 44131ae4

engine-flutter-autoroll authored Sep 10, 2023

https://github.com/flutter/engine/compare/59b08263f7cc...2acd60d6baed

2023-09-10 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from VciXahwZgiusifyh8... to 6PrTSjMiSCsSb0muF... (flutter/engine#45626)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from VciXahwZgius to 6PrTSjMiSCsS

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

44131ae4

Roll Flutter Engine from a2af0c6965be to 59b08263f7cc (1 revision) (#134384) · de25def7

engine-flutter-autoroll authored Sep 10, 2023

https://github.com/flutter/engine/compare/a2af0c6965be...59b08263f7cc

2023-09-10 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from U70-bvYinYjKdGGSt... to a024p4HJVVgmCW5Jo... (flutter/engine#45624)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from U70-bvYinYjK to a024p4HJVVgm

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

de25def7

Roll Flutter Engine from 47d1a045d140 to a2af0c6965be (1 revision) (#134375) · 2da03e54

engine-flutter-autoroll authored Sep 10, 2023

https://github.com/flutter/engine/compare/47d1a045d140...a2af0c6965be

2023-09-10 skia-flutter-autoroll@skia.org Roll Skia from 1bb0f15f2cff to 4eea73a072d3 (1 revision) (flutter/engine#45623)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2da03e54

Native assets support for MacOS and iOS (#130494) · aa36db1d

Daco Harkes authored Sep 10, 2023

Support for FFI calls with `@Native external` functions through Native assets on MacOS and iOS. This enables bundling native code without any build-system boilerplate code.

For more info see:

* https://github.com/flutter/flutter/issues/129757

### Implementation details for MacOS and iOS.

Dylibs are bundled by (1) making them fat binaries if multiple architectures are targeted, (2) code signing these, and (3) copying them to the frameworks folder. These steps are done manual rather than via CocoaPods. CocoaPods would have done the same steps, but (a) needs the dylibs to be there before the `xcodebuild` invocation (we could trick it, by having a minimal dylib in the place and replace it during the build process, that works), and (b) can't deal with having no dylibs to be bundled (we'd have to bundle a dummy dylib or include some dummy C code in the build file).

The dylibs are build as a new target inside flutter assemble, as that is the moment we know what build-mode and architecture to target.

The mapping from asset id to dylib-path is passed in to every kernel compilation path. The interesting case is hot-restart where the initial kernel file is compiled by the "inner" flutter assemble, while after hot restart the "outer" flutter run compiled kernel file is pushed to the device. Both kernel files need to contain the mapping. The "inner" flutter assemble gets its mapping from the NativeAssets target which builds the native assets. The "outer" flutter run get its mapping from a dry-run invocation. Since this hot restart can be used for multiple target devices (`flutter run -d all`) it contains the mapping for all known targets.

### Example vs template

The PR includes a new template that uses the new native assets in a package and has an app importing that. Separate discussion in: https://github.com/flutter/flutter/issues/131209.

### Tests

This PR adds new tests to cover the various use cases.

* dev/devicelab/bin/tasks/native_assets_ios.dart
* Runs an example app with native assets in all build modes, doing hot reload and hot restart in debug mode.
* dev/devicelab/bin/tasks/native_assets_ios_simulator.dart
* Runs an example app with native assets, doing hot reload and hot restart.
* packages/flutter_tools/test/integration.shard/native_assets_test.dart
* Runs (incl hot reload/hot restart), builds, builds frameworks for iOS, MacOS and flutter-tester.
* packages/flutter_tools/test/general.shard/build_system/targets/native_assets_test.dart
* Unit tests the new Target in the backend.
* packages/flutter_tools/test/general.shard/ios/native_assets_test.dart
* packages/flutter_tools/test/general.shard/macos/native_assets_test.dart
* Unit tests the native assets being packaged on a iOS/MacOS build.

It also extends various existing tests:

* dev/devicelab/bin/tasks/module_test_ios.dart
* Exercises the add2app scenario.
* packages/flutter_tools/test/general.shard/features_test.dart
* Unit test the new feature flag.

aa36db1d

Roll Flutter Engine from feea98d6d0ae to 47d1a045d140 (1 revision) (#134368) · 690800bc

engine-flutter-autoroll authored Sep 10, 2023

https://github.com/flutter/engine/compare/feea98d6d0ae...47d1a045d140

2023-09-10 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 51fG0shrG6fW64BtN... to VciXahwZgiusifyh8... (flutter/engine#45620)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 51fG0shrG6fW to VciXahwZgius

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

690800bc

Roll Flutter Engine from 4edbefa5e8f7 to feea98d6d0ae (1 revision) (#134365) · 8919140c

engine-flutter-autoroll authored Sep 10, 2023

https://github.com/flutter/engine/compare/4edbefa5e8f7...feea98d6d0ae

2023-09-10 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from i9IPFS-XpkPjlH235... to U70-bvYinYjKdGGSt... (flutter/engine#45618)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from i9IPFS-XpkPj to U70-bvYinYjK

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8919140c