Commits · c881808ed2ffa57af8f9957178d6dcd24d76e900 · abdullh.alsoleman / Front-End

19 Oct, 2023 1 commit

Reverts "Use Layer.toImage for golden tests on CanvasKit" (#136860) · c881808e

auto-submit[bot] authored Oct 19, 2023

Reverts flutter/flutter#135249
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
Changes golden tests on CanvasKit to use Layer.toImage instead of browser APIs for screenshots. This brings it more in line with other platforms and should also fix some async timing bugs with tests.

c881808e

18 Oct, 2023 33 commits

Bump flutter_lints to 3.0 (#136841) · 571039f6
Michael Goderbauer authored Oct 18, 2023
```
Follow-up to https://github.com/flutter/packages/pull/5177
```
571039f6

Add code for updating `focusedChild` when removing grandchildren from scope (#136771) · 24922425

Greg Spencer authored Oct 18, 2023

## Description

This adds code to make sure that grandchildren are removed from the `focusedChild` of a scope when the child is detached.

## Related Issues
 - Fixes https://github.com/flutter/flutter/issues/136758

## Tests
 - Added regression test.

24922425

Use Layer.toImage for golden tests on CanvasKit (#135249) · 747128ff

Harry Terkelsen authored Oct 18, 2023

Changes golden tests on CanvasKit to use Layer.toImage instead of
browser APIs for screenshots. This brings it more in line with other
platforms and should also fix some async timing bugs with tests.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

747128ff

Roll Flutter Engine from b67edb05d3f7 to 8d51b64e9440 (4 revisions) (#136846) · 9391a88b

engine-flutter-autoroll authored Oct 18, 2023

https://github.com/flutter/engine/compare/b67edb05d3f7...8d51b64e9440

2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from d46a3697d3c5 to d561b276b5d9 (1 revision) (flutter/engine#47074)
2023-10-18 skia-flutter-autoroll@skia.org Roll Dart SDK from b423d5753fdc to d9b1e60fe442 (1 revision) (flutter/engine#47073)
2023-10-18 dkwingsmt@users.noreply.github.com Reland 2 (part 1): Enforce the rule of calling `FlutterView.Render` (flutter/engine#47062)
2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from ef0e93524e7d to d46a3697d3c5 (2 revisions) (flutter/engine#47072)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9391a88b

Roll Flutter Engine from 6caee3236d37 to b67edb05d3f7 (5 revisions) (#136844) · d9fdbd3d

engine-flutter-autoroll authored Oct 18, 2023

https://github.com/flutter/engine/compare/6caee3236d37...b67edb05d3f7

2023-10-18 31859944+LongCatIsLooong@users.noreply.github.com [iOS TextInputPlugin] adjust the markedTextRange when replacing text. (flutter/engine#46603)
2023-10-18 zanderso@users.noreply.github.com Reland: Remove the frontend server wrapper (flutter/engine#47010)
2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from 9880c4006735 to ef0e93524e7d (1 revision) (flutter/engine#47069)
2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from 523f04f1a898 to 9880c4006735 (1 revision) (flutter/engine#47067)
2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from ccd07c6f5042 to 523f04f1a898 (1 revision) (flutter/engine#47065)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d9fdbd3d

Null-assert the value given to a Completer expecting a non-null value (#136776) · 25d2cdaa

Sam Rawlins authored Oct 18, 2023

The code with out the null assertion is legal as per the type signature, but will throw a runtime exception if the nullable value is null. To make this exception more explicit, the value must be null-checked before completing the completer with the value.

The analyzer will soon enforce such checks. See https://github.com/dart-lang/sdk/issues/53253.

Fixes https://github.com/flutter/flutter/issues/136775

25d2cdaa

Roll Flutter Engine from ab86c53c19cd to 6caee3236d37 (2 revisions) (#136834) · 189196d1

engine-flutter-autoroll authored Oct 18, 2023

https://github.com/flutter/engine/compare/ab86c53c19cd...6caee3236d37

2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from b8c989df901a to ccd07c6f5042 (3 revisions) (flutter/engine#47063)
2023-10-18 matanlurey@users.noreply.github.com Add `--lint-all=<regex>` as an option for `clang_tidy`, refactor lint targets (flutter/engine#46522)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

189196d1

Reverts "[Reland] Skip injecting Bonjour settings when port publication is disabled" (#136839) · c32ffa65

auto-submit[bot] authored Oct 18, 2023

Reverts flutter/flutter#136751
Initiated by: vashworth
This change reverts the following previous change:
Original Description:
Reland of https://github.com/flutter/flutter/pull/136562 with fixes.

c32ffa65

Convert menus to use OverlayPortal (#130534) · 13a0d475

Greg Spencer authored Oct 18, 2023

## Description

This converts the `MenuAnchor` class to use `OverlayPortal` instead of directly using the overlay.

## Related Issues
 - Fixes https://github.com/flutter/flutter/issues/124830

## Tests
 - No tests yet (hence it is a draft)

13a0d475

[Reland] Skip injecting Bonjour settings when port publication is disabled (#136751) · 1599cbeb
Victoria Ashworth authored Oct 18, 2023
```
Reland of https://github.com/flutter/flutter/pull/136562 with fixes.
```
1599cbeb

Roll Flutter Engine from 0eff5d191856 to ab86c53c19cd (1 revision) (#136832) · 697242c9

engine-flutter-autoroll authored Oct 18, 2023

https://github.com/flutter/engine/compare/0eff5d191856...ab86c53c19cd

2023-10-18 skia-flutter-autoroll@skia.org Roll Dart SDK from da48c75b73b1 to b423d5753fdc (5 revisions) (flutter/engine#47061)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

697242c9

Fixes ability to call nextFocus() on a node to focus its descendant (#136773) · 24530b80
chunhtai authored Oct 18, 2023
```
fixes https://github.com/flutter/flutter/issues/134854
```
24530b80

Roll Flutter Engine from b778a07f8ae9 to 0eff5d191856 (6 revisions) (#136829) · f847346d

engine-flutter-autoroll authored Oct 18, 2023

https://github.com/flutter/engine/compare/b778a07f8ae9...0eff5d191856

2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from 5857f5f05b35 to b8c989df901a (5 revisions) (flutter/engine#47060)
2023-10-18 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from OudOcFarQhQQzKDBx... to 2HSBpWikGWvPJlHOP... (flutter/engine#47059)
2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from a52d2a9e2b01 to 5857f5f05b35 (1 revision) (flutter/engine#47057)
2023-10-18 jiahaog@users.noreply.github.com Add missing source file (flutter/engine#47046)
2023-10-18 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Kp2wNpzRlAtbME0R4... to PxJM5ivbnbYoVkqBg... (flutter/engine#47056)
2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from 5172e904def7 to a52d2a9e2b01 (2 revisions) (flutter/engine#47055)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from OudOcFarQhQQ to 2HSBpWikGWvP
fuchsia/sdk/core/mac-amd64 from Kp2wNpzRlAtb to PxJM5ivbnbYo

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f847346d

Implement GApplication:shutdown so a Flutter developer knows where to put code... · fe9d9a9d

Robert Ancell authored Oct 18, 2023

Implement GApplication:shutdown so a Flutter developer knows where to put code that should occur on application shutdown. (#136780)

This was added because the dispose method doesn't seem to be called - something must still have a reference to the application after shutdown.

Solution for https://github.com/flutter/flutter/issues/136582

fe9d9a9d

Roll Flutter Engine from 7f37c9b181af to b778a07f8ae9 (1 revision) (#136818) · 07d081b2

engine-flutter-autoroll authored Oct 18, 2023

https://github.com/flutter/engine/compare/7f37c9b181af...b778a07f8ae9

2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from 8132e3356d63 to 5172e904def7 (4 revisions) (flutter/engine#47052)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

07d081b2

Fix `Slider` `onChanged` callback order & never calls `onChangeStart` on ... · 4f959b97

Taha Tesser authored Oct 18, 2023

Fix `Slider` `onChanged` callback order & never calls `onChangeStart` on  `SliderInteraction.slideOnly` allowed interaction (#136720)

fixes [Slider will call onChanged before onChangeStart when sliding.](https://github.com/flutter/flutter/issues/136707)

This fixes a regression from https://github.com/flutter/flutter/pull/121483

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Example(),
    );
  }
}

class Example extends StatefulWidget {
  const Example({super.key});

  @override
  State<Example> createState() => _ExampleState();
}

class _ExampleState extends State<Example> {
  double _sliderValue = 0.5;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: Slider(
          // allowedInteraction: SliderInteraction.tapAndSlide,
          // allowedInteraction: SliderInteraction.tapOnly,
          // allowedInteraction: SliderInteraction.slideOnly
          // allowedInteraction: SliderInteraction.slideThumb,
          value: _sliderValue,
          onChangeStart: (newValue) {
            print("onChangeStart ......");
          },
          onChanged: (newValue) {
            print("onChanged ......");
            setState(() {
              _sliderValue = newValue;
            });
          },
          onChangeEnd: (newValue) {
            print("onChangeEnd ......");
          },
        ),
      ),
    );
  }
}
```

</details>

4f959b97

Roll Flutter Engine from 78026b4003fe to 7f37c9b181af (1 revision) (#136817) · d195d90d

engine-flutter-autoroll authored Oct 18, 2023

https://github.com/flutter/engine/compare/78026b4003fe...7f37c9b181af

2023-10-18 zanderso@users.noreply.github.com Revert "Roll buildroot to pull in removal of //tools." (flutter/engine#47053)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d195d90d

[Feat] Stroke color for Slider value indicator (#135986) · a9567313

Arash authored Oct 18, 2023

Consider a scenario where the background color and indicator's background color are the same. 

Adding a stroke color to the value indicator would be a valuable for the following reasons:
- **Visual Clarity:** It would allow developers to make the value indicator stand out more against the background, making it easier for users to notice.
- **Customization:** It would provide more flexibility in customizing the appearance of the sliding widget, allowing developers to match the design requirements of their apps.
- **Accessibility:** Improved visual distinction can enhance the accessibility of the sliding widget for users with various needs.

*List which issues are fixed by this PR. You must list at least one issue.*

Fixes #135984

a9567313

Fixed : Empty Rows shown at last page in Paginated data table (#132646) · 941897f6

Aakash Pamnani authored Oct 18, 2023

Fixed empty rows at the last page in paginated data table

BEFORE:
![Before](https://github.com/flutter/flutter/assets/76067278/1f1e364c-df38-462f-b9fb-868554ce04a5)

AFTER:
![After](https://github.com/flutter/flutter/assets/76067278/80648a25-e9e6-4873-805f-b18c7c6a00af)

Issues resolves : #80421

941897f6

Roll Flutter Engine from 46923fd39032 to 78026b4003fe (1 revision) (#136814) · 8e4292b1

engine-flutter-autoroll authored Oct 18, 2023

https://github.com/flutter/engine/compare/46923fd39032...78026b4003fe

2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from fed09695a0b9 to 8132e3356d63 (2 revisions) (flutter/engine#47050)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8e4292b1

Roll Packages from d4390624a624 to 14aa69e2e54c (1 revision) (#136813) · 553088f6

engine-flutter-autoroll authored Oct 18, 2023

https://github.com/flutter/packages/compare/d4390624a624...14aa69e2e54c

2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter from afc39160 to 6eea6e27 (27 revisions) (flutter/packages#5165)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

553088f6

Don't build native assets in `flutter build bundle` (#136641) · 402a5455
Daco Harkes authored Oct 18, 2023
```
Closes: https://github.com/flutter/flutter/issues/136547
```
402a5455

Roll Flutter Engine from c9c9684e03a3 to 46923fd39032 (1 revision) (#136795) · 4b7b4d41

engine-flutter-autoroll authored Oct 18, 2023

https://github.com/flutter/engine/compare/c9c9684e03a3...46923fd39032

2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from 212da8293790 to fed09695a0b9 (1 revision) (flutter/engine#47045)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4b7b4d41

Roll Flutter Engine from 0c1c29271e8b to c9c9684e03a3 (1 revision) (#136792) · e1fc37d8

engine-flutter-autoroll authored Oct 18, 2023

https://github.com/flutter/engine/compare/0c1c29271e8b...c9c9684e03a3

2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from 3d938d4b00ee to 212da8293790 (1 revision) (flutter/engine#47043)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e1fc37d8

Roll Flutter Engine from 1de09d13e708 to 0c1c29271e8b (3 revisions) (#136789) · 552360e3

engine-flutter-autoroll authored Oct 18, 2023

https://github.com/flutter/engine/compare/1de09d13e708...0c1c29271e8b

2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from 8796ee7d1c66 to 3d938d4b00ee (3 revisions) (flutter/engine#47042)
2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from 13694b8c64aa to 8796ee7d1c66 (1 revision) (flutter/engine#47041)
2023-10-18 matej.knopp@gmail.com [macOS] Fix tests failing on Sonoma (flutter/engine#46461)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

552360e3

Roll Flutter Engine from 6fc36e61a99a to 1de09d13e708 (1 revision) (#136785) · 8a4c81b5

engine-flutter-autoroll authored Oct 18, 2023

https://github.com/flutter/engine/compare/6fc36e61a99a...1de09d13e708

2023-10-18 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from VtEx0R7lepGAvwAMU... to OudOcFarQhQQzKDBx... (flutter/engine#47039)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from VtEx0R7lepGA to OudOcFarQhQQ

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8a4c81b5

Roll Flutter Engine from 3f818efff3c5 to 6fc36e61a99a (1 revision) (#136781) · de492293

engine-flutter-autoroll authored Oct 18, 2023

https://github.com/flutter/engine/compare/3f818efff3c5...6fc36e61a99a

2023-10-18 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from E0Ui7KmD3u5JSKEk5... to Kp2wNpzRlAtbME0R4... (flutter/engine#47037)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from E0Ui7KmD3u5J to Kp2wNpzRlAtb

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

de492293

Roll Flutter Engine from 2eef9b43cfb4 to 3f818efff3c5 (3 revisions) (#136777) · 911c4789

engine-flutter-autoroll authored Oct 18, 2023

https://github.com/flutter/engine/compare/2eef9b43cfb4...3f818efff3c5

2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from f62b4dce5e55 to 13694b8c64aa (2 revisions) (flutter/engine#47033)
2023-10-18 chinmaygarde@google.com Roll buildroot to pull in removal of //tools. (flutter/engine#47032)
2023-10-18 jonahwilliams@google.com Disable threading test that fails on CI (flutter/engine#47034)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

911c4789

Roll Flutter Engine from 5df7af34a718 to 2eef9b43cfb4 (4 revisions) (#136774) · 4cf73ca5

engine-flutter-autoroll authored Oct 18, 2023

https://github.com/flutter/engine/compare/5df7af34a718...2eef9b43cfb4

2023-10-17 chris@bracken.jp Move imgui from buildroot to flutter third_party (flutter/engine#47031)
2023-10-17 jonahwilliams@google.com [Impeller] Rework Vulkan GPUTracker to decorate existing cmd buffers. (flutter/engine#46963)
2023-10-17 chris@bracken.jp [fml][embedder] Improve thread-check logging (flutter/engine#47020)
2023-10-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 99ce477503f8 to da48c75b73b1 (1 revision) (flutter/engine#47027)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4cf73ca5

Flutter preview device (#135639) · 8a31a3a2

Christopher Fujino authored Oct 18, 2023

Fixes https://github.com/flutter/flutter/issues/130277

This PR does two things:

1. introduce a hidden `flutter build _preview` command, that will build a debug windows desktop app and copy it into the SDK's binary cache. This command is only intended to be run during packaging.
2. introduce a new device type, called `PreviewDevice`, which relies on the prebuilt desktop debug app from step 1, copies it into the target app's assets build folder, and then hot reloads their dart code into it.

8a31a3a2

Add findChildIndexCallback examples (#133469) · 492b6f7d

Gildásio Filho authored Oct 18, 2023

The documentation for using `findChildIndexCallback` recommends using `indexOf`, but that causes [this line](https://github.com/flutter/flutter/blob/05259ca938c9ea27aa551048b690d5a06371a6c0/packages/flutter/lib/src/rendering/sliver_multi_box_adaptor.dart#L259) to throw in debug mode, and when using `SliverList`, it breaks the render.

This PR changes the usage to check if the index is not negative before using it, and changes to return `null` instead if the child wasn't able to be found.

There's the related issue #107123, but this doesn't actually fix it.

-----

This PR has been updated to add the snippets that were used in the `findChildIndexCallback` comment as examples with proper tests, as well as updating the comment to reference the new examples.

492b6f7d

Adds API for performing semantics actions in tests (#132598) · 52a1a318

pdblasi-google authored Oct 18, 2023

* Added `performAction` to `SemanticsController` as well as specific methods for specific actions
* Added a `scrollable` finder to `find.semantics` as a convenience method for `findAny(<all scrollable actions>)`
* Updated `containsSemantics` and `matchSemantics` matchers to also work on `FinderBase<Semantics>`

Closes #112413

52a1a318

Roll Flutter Engine from e57b5bac4244 to 5df7af34a718 (2 revisions) (#136772) · 11a2bc0b

engine-flutter-autoroll authored Oct 18, 2023

https://github.com/flutter/engine/compare/e57b5bac4244...5df7af34a718

2023-10-17 chinmaygarde@google.com Roll buildroot to pull in //gpu removal. (flutter/engine#47014)
2023-10-17 skia-flutter-autoroll@skia.org Roll Skia from b524e0af7d3a to f62b4dce5e55 (4 revisions) (flutter/engine#47029)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

11a2bc0b

17 Oct, 2023 6 commits

Roll Flutter Engine from f9f937e51080 to e57b5bac4244 (3 revisions) (#136768) · 23d3b1e4

engine-flutter-autoroll authored Oct 17, 2023

https://github.com/flutter/engine/compare/f9f937e51080...e57b5bac4244

2023-10-17 jason-simmons@users.noreply.github.com Workaround for a clang-tidy warning in CPUSpeedTracker (flutter/engine#47024)
2023-10-17 skia-flutter-autoroll@skia.org Roll Skia from a9caf3c19792 to b524e0af7d3a (1 revision) (flutter/engine#47017)
2023-10-17 jason-simmons@users.noreply.github.com Manual roll of Clang from 576b184d6e3b to 00396e6a1a0b (flutter/engine#46980)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

23d3b1e4

clean up `--dart-define-from-file` option tests (#135980) · cdc40b52

Andrew Kolos authored Oct 17, 2023

Fixes https://github.com/flutter/flutter/issues/134279.

Changes:
* Moves all tests of `--dart-define-from-file` behavior from `build_bundle_test.dart` and `assemble_test.dart` to `flutter_command_test.dart`.
* Deletes a duplicate test of malformed JSON detection behavior.
* Renames the `useDartDefineFromFileOption` method of `FlutterCommand` to `_usesDartDefineFromFileOption`. This 1) makes the name more consistent with the other `uses*Option` methods and 2) hides the method since it is not used outside of the file.
* Renames several tests to better articulate what is under test and what the expected result is.
* Adds a test for the case where a `.env` file with a malformed line is provided to `--dart-define-from-file`.

cdc40b52

GoldenFileComparators should dispose created Image objects. (#136716) · 22f593e5
Kostia Sokolovskyi authored Oct 17, 2023

22f593e5

make integration_test_driver_extended.dart support writeResponseData--(done) (#128382) · 3d1d4532

LinChen authored Oct 17, 2023

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue.*
- https://github.com/flutter/flutter/issues/128381

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

3d1d4532

Bump actions/checkout from 3.6.0 to 4.1.1 (#136762) · 380520d4

dependabot[bot] authored Oct 17, 2023

Bumps [actions/checkout](https://github.com/actions/checkout) from 3.6.0 to 4.1.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v4.1.1</h2>
<h2>What's Changed</h2>
<ul>
<li>Update CODEOWNERS to Launch team by <a href="https://github.com/joshmgross"><code>@âjoshmgross</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1510">actions/checkout#1510</a></li>
<li>Correct link to GitHub Docs by <a href="https://github.com/peterbe"><code>@âpeterbe</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1511">actions/checkout#1511</a></li>
<li>Link to release page from what's new section by <a href="https://github.com/cory-miller"><code>@âcory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1514">actions/checkout#1514</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/joshmgross"><code>@âjoshmgross</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1510">actions/checkout#1510</a></li>
<li><a href="https://github.com/peterbe"><code>@âpeterbe</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1511">actions/checkout#1511</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v4...v4.1.1">https://github.com/actions/checkout/compare/v4...v4.1.1</a></p>
<h2>v4.1.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Update README.md for V4 by <a href="https://github.com/sivapalan"><code>@âsivapalan</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1452">actions/checkout#1452</a></li>
<li>Add support for partial checkout filters by <a href="https://github.com/finleygn"><code>@âfinleygn</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1396">actions/checkout#1396</a></li>
<li>Prepare 4.1.0 release by <a href="https://github.com/cory-miller"><code>@âcory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1496">actions/checkout#1496</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/sivapalan"><code>@âsivapalan</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1452">actions/checkout#1452</a></li>
<li><a href="https://github.com/finleygn"><code>@âfinleygn</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1396">actions/checkout#1396</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v4.0.0...v4.1.0">https://github.com/actions/checkout/compare/v4.0.0...v4.1.0</a></p>
<h2>v4.0.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Update default runtime to node20 by <a href="https://github.com/takost"><code>@âtakost</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1436">actions/checkout#1436</a></li>
<li>Support fetching without the --progress option by <a href="https://github.com/simonbaird"><code>@âsimonbaird</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1067">actions/checkout#1067</a></li>
<li>Release 4.0.0 by <a href="https://github.com/takost"><code>@âtakost</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1447">actions/checkout#1447</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/takost"><code>@âtakost</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1436">actions/checkout#1436</a></li>
<li><a href="https://github.com/simonbaird"><code>@âsimonbaird</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1067">actions/checkout#1067</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v3...v4.0.0">https://github.com/actions/checkout/compare/v3...v4.0.0</a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/blob/main/CHANGELOG.md">actions/checkout's changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<h2>v4.1.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1396">Add support for partial checkout filters</a></li>
</ul>
<h2>v4.0.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1067">Support fetching without the --progress option</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1436">Update to node20</a></li>
</ul>
<h2>v3.6.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1377">Fix: Mark test scripts with Bash'isms to be run via Bash</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/579">Add option to fetch tags even if fetch-depth &gt; 0</a></li>
</ul>
<h2>v3.5.3</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1196">Fix: Checkout fail in self-hosted runners when faulty submodule are checked-in</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1287">Fix typos found by codespell</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1369">Add support for sparse checkouts</a></li>
</ul>
<h2>v3.5.2</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1289">Fix api endpoint for GHES</a></li>
</ul>
<h2>v3.5.1</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1246">Fix slow checkout on Windows</a></li>
</ul>
<h2>v3.5.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1237">Add new public key for known_hosts</a></li>
</ul>
<h2>v3.4.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1209">Upgrade codeql actions to v2</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1210">Upgrade dependencies</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1225">Upgrade <code>@âactions/io</code></a></li>
</ul>
<h2>v3.3.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1045">Implement branch list using callbacks from exec function</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1050">Add in explicit reference to private checkout options</a></li>
<li>[Fix comment typos (that got added in <a href="https://redirect.github.com/actions/checkout/issues/770">#770</a>)](<a href="https://redirect.github.com/actions/checkout/pull/1057">actions/checkout#1057</a>)</li>
</ul>
<h2>v3.2.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/942">Add GitHub Action to perform release</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/967">Fix status badge</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1002">Replace datadog/squid with ubuntu/squid Docker image</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/964">Wrap pipeline commands for submoduleForeach in quotes</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1029">Update <code>@âactions/io</code> to 1.1.2</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1039">Upgrading version to 3.2.0</a></li>
</ul>
<h2>v3.1.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/939">Use <code>@âactions/core</code> <code>saveState</code> and <code>getState</code></a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/922">Add <code>github-server-url</code> input</a></li>
</ul>
<h2>v3.0.2</h2>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/actions/checkout/commit/b4ffde65f46336ab88eb53be808477a3936bae11"><code>b4ffde6</code></a> Link to release page from what's new section (<a href="https://redirect.github.com/actions/checkout/issues/1514">#1514</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/8530928916aaef40f59e6f221989ccb31f5759e7"><code>8530928</code></a> Correct link to GitHub Docs (<a href="https://redirect.github.com/actions/checkout/issues/1511">#1511</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/7cdaf2fbc075e6f3b9ca94cfd6cec5adc8a75622"><code>7cdaf2f</code></a> Update CODEOWNERS to Launch team (<a href="https://redirect.github.com/actions/checkout/issues/1510">#1510</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/8ade135a41bc03ea155e62e844d188df1ea18608"><code>8ade135</code></a> Prepare 4.1.0 release (<a href="https://redirect.github.com/actions/checkout/issues/1496">#1496</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/c533a0a4cfc4962971818edcfac47a2899e69799"><code>c533a0a</code></a> Add support for partial checkout filters (<a href="https://redirect.github.com/actions/checkout/issues/1396">#1396</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/72f2cec99f417b1a1c5e2e88945068983b7965f9"><code>72f2cec</code></a> Update README.md for V4 (<a href="https://redirect.github.com/actions/checkout/issues/1452">#1452</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/3df4ab11eba7bda6032a0b82a6bb43b11571feac"><code>3df4ab1</code></a> Release 4.0.0 (<a href="https://redirect.github.com/actions/checkout/issues/1447">#1447</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/8b5e8b768746b50394015010d25e690bfab9dfbc"><code>8b5e8b7</code></a> Support fetching without the --progress option (<a href="https://redirect.github.com/actions/checkout/issues/1067">#1067</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/97a652b80035363df47baee5031ec8670b8878ac"><code>97a652b</code></a> Update default runtime to node20 (<a href="https://redirect.github.com/actions/checkout/issues/1436">#1436</a>)</li>
<li>See full diff in <a href="https://github.com/actions/checkout/compare/f43a0e5ff2bd294095638e18286ca9a3d1956744...b4ffde65f46336ab88eb53be808477a3936bae11">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/checkout&package-manager=github_actions&previous-version=3.6.0&new-version=4.1.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

380520d4

Roll Flutter Engine from 289f29b1ad00 to f9f937e51080 (1 revision) (#136755) · cdb2304c

engine-flutter-autoroll authored Oct 17, 2023

https://github.com/flutter/engine/compare/289f29b1ad00...f9f937e51080

2023-10-17 skia-flutter-autoroll@skia.org Roll Skia from 1a332d2b35d9 to a9caf3c19792 (1 revision) (flutter/engine#47013)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cdb2304c