Commits · c84b10474c35e85d3b2a7e06ebf789fa9b6919c0 · abdullh.alsoleman / Front-End

23 May, 2023 19 commits

modal bottom sheet barrier label (#126431) · c84b1047
NikolajHarderNota authored May 23, 2023
```
Adds barrierLabel as optional param in showModalBottomSheet

Fixes #83180
```
c84b1047

Fix the breaking of multi-code-unit characters in obscure mode (#123366) · 4341ed42

Justin McCandless authored May 23, 2023

This PR changes the character boundary behavior of obscured fields to be based on code points instead of code units.

So it used to be possible to traverse and delete obscured text inside of code points (and breaking a code point like that would cause a crash):

![output2](https://github.com/flutter/flutter/assets/389558/674c89a4-c47d-4cdc-a402-4cadb5d2f73b)

But now moving the cursor and deleting is based on code points:

![output1](https://github.com/flutter/flutter/assets/389558/e46301f7-b5af-48d2-812a-0ad649f1383b)

### Native behavior

Native iOS deletes part of the emoji, native Mac deletes the whole emoji.  See https://github.com/flutter/flutter/issues/122381#issuecomment-1482042620.  So it's unclear what the desired behavior should actually be.

### Resources

Fixes https://github.com/flutter/flutter/issues/122381

I thought this might not fix the case where a broken emoji is directly pasted into the field, but it seems to work by trying this:  ï¿½âð©âð¦âð¦

CC @LongCatIsLooong

4341ed42

Roll Flutter Engine from 168b0bf3f70d to a6e37bde65fd (1 revision) (#127397) · ffbeb723

engine-flutter-autoroll authored May 23, 2023

https://github.com/flutter/engine/compare/168b0bf3f70d...a6e37bde65fd

2023-05-23 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from DzmjiSg6XC0JUfbKP... to aAjEDVse7qfMt0NqE... (flutter/engine#42245)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from DzmjiSg6XC0J to aAjEDVse7qfM

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ffbeb723

Revert "Log all output of ios-deploy" (#127405) · d452ce96
Victoria Ashworth authored May 23, 2023
```
Reverts flutter/flutter#127222
```
d452ce96

Roll Packages from 83959fb7de37 to d449a17f8706 (6 revisions) (#127394) · 20ccf090

engine-flutter-autoroll authored May 23, 2023

https://github.com/flutter/packages/compare/83959fb7de37...d449a17f8706

2023-05-22 stuartmorgan@google.com [various] Remove unnecessary null checks (flutter/packages#4060)
2023-05-22 stuartmorgan@google.com [ci] Add a legacy Android build-all test (flutter/packages#4005)
2023-05-22 engine-flutter-autoroll@skia.org Roll Flutter from ab573048 to 34371894 (5 revisions) (flutter/packages#4062)
2023-05-22 tobias@leafnode.se [go_router] Nested stateful navigation with ShellRoute (flutter/packages#2650)
2023-05-22 tobias@leafnode.se [go_router] Nested stateful navigation with ShellRoute (flutter/packages#2650)
2023-05-22 tobias@leafnode.se [go_router] Nested stateful navigation with ShellRoute (flutter/packages#2650)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

20ccf090

Log all output of ios-deploy (#127222) · 7fa45ea4

Victoria Ashworth authored May 23, 2023

Log all output of `ios-deploy` to try and determine if the issue of https://github.com/flutter/flutter/issues/121231 is with stream or with `ios-deploy`.

Note: This will cause some duplicate logs like example below but only in verbose mode

```
(lldb) 2023-05-19 13:48:19.107935-0500 Runner[2521:390363] [VERBOSE-2:FlutterDarwinContextMetalImpeller.mm(35)] Using the Impeller rendering backend.
(lldb) 2023-05-19 13:48:19.107935-0500 Runner[2521:390363] [VERBOSE-2:FlutterDarwinContextMetalImpeller.mm(35)] Using the Impeller rendering backend.
2023-05-19 13:48:19.156866-0500 Runner[2521:390612] flutter: The Dart VM service is listening on http://127.0.0.1:63508/IsFnhXJykCM=/
VM Service URL on device: http://127.0.0.1:63508/IsFnhXJykCM=/
```

7fa45ea4

Roll Flutter Engine from 431ed51c6415 to 168b0bf3f70d (1 revision) (#127382) · f86c529b

engine-flutter-autoroll authored May 23, 2023

https://github.com/flutter/engine/compare/431ed51c6415...168b0bf3f70d

2023-05-23 skia-flutter-autoroll@skia.org Roll Skia from 4d0166106722 to 3ded22186598 (2 revisions) (flutter/engine#42242)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f86c529b

Roll Flutter Engine from cc79ae858591 to 431ed51c6415 (1 revision) (#127381) · 8e3319fd

engine-flutter-autoroll authored May 23, 2023

https://github.com/flutter/engine/compare/cc79ae858591...431ed51c6415

2023-05-23 whesse@google.com Add leak_tracker package from Dart DEPS to DEPS (flutter/engine#42241)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8e3319fd

Roll Flutter Engine from 311438399a45 to cc79ae858591 (1 revision) (#127377) · b83c82f7

engine-flutter-autoroll authored May 23, 2023

https://github.com/flutter/engine/compare/311438399a45...cc79ae858591

2023-05-23 skia-flutter-autoroll@skia.org Roll Dart SDK from 1ca8f8368ecc to 90b4df96e9dc (2 revisions) (flutter/engine#42239)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b83c82f7

Roll Flutter Engine from c284cd10e7ab to 311438399a45 (1 revision) (#127376) · 18118280

engine-flutter-autoroll authored May 23, 2023

https://github.com/flutter/engine/compare/c284cd10e7ab...311438399a45

2023-05-23 skia-flutter-autoroll@skia.org Roll Skia from 1c3d1e200d72 to 4d0166106722 (2 revisions) (flutter/engine#42238)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

18118280

Roll Flutter Engine from 8d6602b030be to c284cd10e7ab (2 revisions) (#127372) · fca152f2

engine-flutter-autoroll authored May 23, 2023

https://github.com/flutter/engine/compare/8d6602b030be...c284cd10e7ab

2023-05-23 bdero@google.com [Impeller] Place Entity Geometry classes in separate TUs (flutter/engine#42236)
2023-05-23 skia-flutter-autoroll@skia.org Roll Skia from fc369d15070f to 1c3d1e200d72 (1 revision) (flutter/engine#42235)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fca152f2

Add M3 date picker tests and fix divider (#127197) · fe32675b

Taha Tesser authored May 23, 2023

partial fix https://github.com/flutter/flutter/issues/126826 (date range picker is another PR)
fixes https://github.com/flutter/flutter/issues/126597

### Description

1. This PR adds a bunch of M3 date picker tests
2. Fixes divider taking more space than it should
3. Added dividerColor  theme value to allow users to customise divider color just for the date pickers from date picker theme 

<details> 
<summary>code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData(
        datePickerTheme: DatePickerThemeData(
          headerBackgroundColor: Colors.amber,
        ),
        useMaterial3: true,
      ),
      home: Scaffold(
        body: Builder(builder: (BuildContext context) {
          return Center(
            child: ElevatedButton(
              onPressed: () async {
                showDatePicker(
                  context: context,
                  initialDate: DateTime(2016, DateTime.january, 15),
                  firstDate: DateTime(2001),
                  lastDate: DateTime(2031, DateTime.december, 31),
                );
              },
              child: const Text('Show Date Picker'),
            ),
          );
        }),
      ),
    );
  }
}
``` 
	
</details>

### Before
![Screenshot 2023-05-19 at 17 32 19](https://github.com/flutter/flutter/assets/48603081/4463de1a-fb94-4930-a6ab-8245331a8134)

### After
![Screenshot 2023-05-19 at 17 51 15](https://github.com/flutter/flutter/assets/48603081/296276f0-cf13-4a59-8542-a46da774153b)

fe32675b

Roll Flutter Engine from 2586cbeeae37 to 8d6602b030be (2 revisions) (#127370) · d9045f02

engine-flutter-autoroll authored May 23, 2023

https://github.com/flutter/engine/compare/2586cbeeae37...8d6602b030be

2023-05-23 skia-flutter-autoroll@skia.org Roll Skia from 6a57876d0e44 to fc369d15070f (1 revision) (flutter/engine#42234)
2023-05-23 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from LrfeC0dLk8ToJVik5... to Zbd3haNY2Idcdu1Fj... (flutter/engine#42232)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from LrfeC0dLk8To to Zbd3haNY2Idc

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d9045f02

Manual roll Flutter Engine from a342a9186e69 to 2586cbeeae37 (14 revisions) (#127369) · dd07c61e

engine-flutter-autoroll authored May 23, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/a342a9186e69...2586cbeeae37

2023-05-23 zanderso@users.noreply.github.com Revert "[ios_platform_view]
only recycle maskView when the view is applying mutators #41573"
(flutter/engine#42231)
2023-05-23 skia-flutter-autoroll@skia.org Roll Skia from ac87929b3d2e to
6a57876d0e44 (2 revisions) (flutter/engine#42230)
2023-05-23 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
QAwORJOkyNl4J3x4Y... to DzmjiSg6XC0JUfbKP... (flutter/engine#42227)
2023-05-23 skia-flutter-autoroll@skia.org Manual roll Dart SDK from
b3e1eeda4918 to 1ca8f8368ecc (5 revisions) (flutter/engine#42229)
2023-05-23 skia-flutter-autoroll@skia.org Roll Skia from d448fe07ea46 to
ac87929b3d2e (8 revisions) (flutter/engine#42226)
2023-05-23 dnfield@google.com Make FML_LOG safe from static
initialization (flutter/engine#42219)
2023-05-23 uysalere@gmail.com [fuchsia] Bind ChildViewWatcher on
platform thread (flutter/engine#42222)
2023-05-22 skia-flutter-autoroll@skia.org Roll Dart SDK from
b3e1eeda4918 to 1ca8f8368ecc (5 revisions) (flutter/engine#42224)
2023-05-22 jason-simmons@users.noreply.github.com [Impeller] Return
image decoder error messages to the Dart API (flutter/engine#42175)
2023-05-22 5236035+fzyzcjy@users.noreply.github.com Again a two-word
super tiny typo (flutter/engine#42181)
2023-05-22 ychris@google.com Reland "[ios_platform_view] only recycle
maskView when the view is applying mutators #41573"
(flutter/engine#42115)
2023-05-22 jason-simmons@users.noreply.github.com [Impeller] Use
untransformed text bounds to calculate the size of
ColorSourceTextContents (flutter/engine#42142)
2023-05-22 jonahwilliams@google.com [Impeller] Add UV compute shader.
(flutter/engine#42192)
2023-05-22 jonahwilliams@google.com [Impeller] remove final cmd buffer
waitUntilScheduled on physical iOS (flutter/engine#42160)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from QAwORJOkyNl4 to DzmjiSg6XC0J

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

dd07c61e

[Android] Adds `namespace` to module build file templates (#126963) · 31a665c3
Camille Simon authored May 23, 2023
```
Adds `namespace` to module `build.gradle` file templates.

Fixes https://github.com/flutter/flutter/issues/126403.
```
31a665c3

Revert Engine to a342a9186e69 (#127368) · bc14fedb

Zachary Anderson authored May 23, 2023

Reverts Engine rolls for bad commit in
https://github.com/flutter/engine/pull/42115


https://github.com/flutter/flutter/commit/6549765296241146265b6705f57923b1a7df2b87

https://github.com/flutter/flutter/commit/194d30a8cd34b0a5f6400704f9725750a7505e9e

Engine commit is being reverted in
https://github.com/flutter/engine/pull/42231

bc14fedb

Roll Flutter Engine from 2a325eed77d0 to 41e8d52a006a (2 revisions) (#127365) · 65497652

engine-flutter-autoroll authored May 23, 2023

https://github.com/flutter/engine/compare/2a325eed77d0...41e8d52a006a

2023-05-23 dnfield@google.com Make FML_LOG safe from static initialization (flutter/engine#42219)
2023-05-23 uysalere@gmail.com [fuchsia] Bind ChildViewWatcher on platform thread (flutter/engine#42222)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

65497652

Roll Flutter Engine from a342a9186e69 to 2a325eed77d0 (7 revisions) (#127364) · 194d30a8

engine-flutter-autoroll authored May 23, 2023

https://github.com/flutter/engine/compare/a342a9186e69...2a325eed77d0

2023-05-22 skia-flutter-autoroll@skia.org Roll Dart SDK from b3e1eeda4918 to 1ca8f8368ecc (5 revisions) (flutter/engine#42224)
2023-05-22 jason-simmons@users.noreply.github.com [Impeller] Return image decoder error messages to the Dart API (flutter/engine#42175)
2023-05-22 5236035+fzyzcjy@users.noreply.github.com Again a two-word super tiny typo (flutter/engine#42181)
2023-05-22 ychris@google.com Reland "[ios_platform_view] only recycle maskView when the view is applying mutators #41573" (flutter/engine#42115)
2023-05-22 jason-simmons@users.noreply.github.com [Impeller] Use untransformed text bounds to calculate the size of ColorSourceTextContents (flutter/engine#42142)
2023-05-22 jonahwilliams@google.com [Impeller] Add UV compute shader. (flutter/engine#42192)
2023-05-22 jonahwilliams@google.com [Impeller] remove final cmd buffer waitUntilScheduled on physical iOS (flutter/engine#42160)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

194d30a8

Remove null-safety argument from DartPad doc samples (#127345) · c313083a

Parker Lougheed authored May 23, 2023

Removes the `null_safety=true` query parameter from DartPad samples in the API docs, since all DartPad channels only support null safety now and the parameter does nothing.

## Test

Removing code, but updates the check in the dartdoc tool for the removal.

c313083a

22 May, 2023 14 commits

Support keeping a bottom sheet with a DraggableScrollableSheet from closing on... · a6d62ca8
Daniel Iglesia authored May 22, 2023
```
Support keeping a bottom sheet with a DraggableScrollableSheet from closing on drag/fling to min extent (#127339)
```
a6d62ca8
Fix wasm-opt location when using local_web_sdk (#127355) · 758ea6c0
Jackson Gardner authored May 22, 2023
```
We were looking up the wrong path for `wasm-opt` previously when using the `local-web-sdk` flag.
```
758ea6c0

Roll Flutter Engine from 1ed9fc0caf55 to a342a9186e69 (3 revisions) (#127352) · 7a12d825

engine-flutter-autoroll authored May 22, 2023

https://github.com/flutter/engine/compare/1ed9fc0caf55...a342a9186e69

2023-05-22 skia-flutter-autoroll@skia.org Roll Skia from 2612bb159848 to d448fe07ea46 (5 revisions) (flutter/engine#42213)
2023-05-22 aam@google.com Skip and ignore boringssl/src/rust when looking for the licenses. (flutter/engine#42210)
2023-05-22 jonahwilliams@google.com [Impeller] Create reusable prefix sum. (flutter/engine#42167)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7a12d825

Show warning when attempting to flutter run on an ios device with developer... · e345a830

LouiseHsu authored May 22, 2023

Show warning when attempting to flutter run on an ios device with developer mode turned off (#125710)

This PR adds a warning when a user attempt to `flutter run -d <device id>` on a device without developer mode enabled.
<img width="738" alt="Screenshot 2023-05-09 at 3 53 18 AM" src="https://github.com/flutter/flutter/assets/36148254/6f473a6a-5a0d-438b-9e6f-06d09eb1f3a9">

Also handles multiple partial matches.
<img width="788" alt="Screenshot 2023-05-09 at 3 52 24 AM" src="https://github.com/flutter/flutter/assets/36148254/60c82b3c-d501-4a01-95ad-d6309fe39576">

Fixes https://github.com/flutter/flutter/issues/111988

e345a830

Suggest that people move to "beta" when they upgrade on "master" (#127146) · 487ed573

Ian Hickson authored May 22, 2023

Similar to https://github.com/flutter/flutter/pull/126972 but for master
upgrades.
Co-authored-by: Tim Sneath <timsneath@google.com>

487ed573

add test for setting JAVA_HOME and PATH when invoking `sdkmanager --licenses` (#127344) · 46a742f0
Andrew Kolos authored May 22, 2023
```
#126086 inadvertently fixed https://github.com/flutter/flutter/issues/124776

This follow-up PR gets the fix under test.
```
46a742f0

Roll Flutter Engine from e04c14786d5a to 1ed9fc0caf55 (1 revision) (#127343) · 6e1caadc

engine-flutter-autoroll authored May 22, 2023

https://github.com/flutter/engine/compare/e04c14786d5a...1ed9fc0caf55

2023-05-22 skia-flutter-autoroll@skia.org Roll Skia from ef226c5a7930 to 2612bb159848 (1 revision) (flutter/engine#42209)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6e1caadc

fix: Search anchor box location when used on nested navigator (#127198) · 7e3f1df3

Victor Ohashi authored May 22, 2023

This PR is to fix the position of `SearchAnchor` when used with nested navigator. This solution is based on what `DropdownButton` internally do, looking to the closest `Navigator` to proper calculate the where to render `SearchViewRoute`.

Fixes: https://github.com/flutter/flutter/issues/126435

<details>
<summary>Test case</summary>

```dart
void main() => runApp(const NestedSearchBarApp());

class NestedSearchBarApp extends StatefulWidget {
  const NestedSearchBarApp({super.key});

  @override
  State<NestedSearchBarApp> createState() => _NestedSearchBarAppState();
}

class _NestedSearchBarAppState extends State<NestedSearchBarApp> {
  final SearchController controller = SearchController();

  @override
  Widget build(BuildContext context) {
    final ThemeData themeData = ThemeData(useMaterial3: true);

    return MaterialApp(
      theme: themeData,
      builder: (BuildContext context, Widget? child) {
        return Scaffold(
          body: Row(
            children: <Widget>[
              NavigationRail(
                selectedIndex: 1,
                destinations: const <NavigationRailDestination>[
                  NavigationRailDestination(
                    icon: Icon(Icons.favorite_border),
                    selectedIcon: Icon(Icons.favorite),
                    label: Text('First'),
                  ),
                  NavigationRailDestination(
                    icon: Icon(Icons.bookmark_border),
                    selectedIcon: Icon(Icons.book),
                    label: Text('Second'),
                  ),
                ],
              ),
              const VerticalDivider(thickness: 1, width: 1),
              Expanded(child: child!)
            ],
          ),
        );
      },
      home: Scaffold(
        appBar: AppBar(title: const Text('Search Anchor Sample')),
        body: Column(
          children: <Widget>[
            SearchAnchor(
                searchController: controller,
                builder: (BuildContext context, SearchController controller) {
                  return IconButton(
                    icon: const Icon(Icons.search),
                    onPressed: () {
                      controller.openView();
                    },
                  );
                },
                suggestionsBuilder:
                    (BuildContext context, SearchController controller) {
                  return List<ListTile>.generate(5, (int index) {
                    final String item = 'item $index';
                    return ListTile(
                      title: Text(item),
                      onTap: () {
                        setState(() {
                          controller.closeView(item);
                        });
                      },
                    );
                  });
                }),
            Center(
              child: controller.text.isEmpty
                  ? const Text('No item selected')
                  : Text('Selected item: ${controller.value.text}'),
            ),
          ],
        ),
      ),
    );
  }
}
```
</details>

<details>
<summary>Before fix:</summary>

![Screenshot 2023-05-19 at 11 55 53](https://github.com/flutter/flutter/assets/38299943/c86747e5-6716-4e87-b3fd-ce7f0f943b92)
</details>

<details>
<summary>After fix:</summary>

![Screenshot 2023-05-19 at 11 53 30](https://github.com/flutter/flutter/assets/38299943/d790ee49-e047-485c-87f4-7254acbdddfa)
</details>

7e3f1df3

[flutter_tools] delete entitlements files after copying to macos build dir (#126875) · 7e1a0d40
Christopher Fujino authored May 22, 2023
```
Fixes https://github.com/flutter/flutter/issues/126705
```
7e1a0d40

Roll Flutter Engine from f0f3fe729a91 to e04c14786d5a (10 revisions) (#127325) · 34371894

engine-flutter-autoroll authored May 22, 2023

https://github.com/flutter/engine/compare/f0f3fe729a91...e04c14786d5a

2023-05-22 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
NE_eTA29vOHN4goJL... to LrfeC0dLk8ToJVik5... (flutter/engine#42208)
2023-05-22 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
HPZKiLZlLCR6moOCE... to QAwORJOkyNl4J3x4Y... (flutter/engine#42207)
2023-05-22 skia-flutter-autoroll@skia.org Roll Skia from 16c60e5bebfc to
ef226c5a7930 (1 revision) (flutter/engine#42206)
2023-05-22 skia-flutter-autoroll@skia.org Roll Skia from 79088c6b7a33 to
16c60e5bebfc (1 revision) (flutter/engine#42205)
2023-05-22 skia-flutter-autoroll@skia.org Roll Skia from 76303a5498e9 to
79088c6b7a33 (2 revisions) (flutter/engine#42204)
2023-05-22 skia-flutter-autoroll@skia.org Roll Skia from 2d4ea9542e83 to
76303a5498e9 (1 revision) (flutter/engine#42203)
2023-05-22 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
88pzkUAkSKsJrNG38... to NE_eTA29vOHN4goJL... (flutter/engine#42202)
2023-05-21 dkwingsmt@users.noreply.github.com [macOS] Clean up unused
methods in FlutterRenderer (flutter/engine#42196)
2023-05-21 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
JU-dKW3CQIUzhbqWE... to HPZKiLZlLCR6moOCE... (flutter/engine#42201)
2023-05-21 skia-flutter-autoroll@skia.org Roll Skia from 5b2005e47bf3 to
2d4ea9542e83 (1 revision) (flutter/engine#42200)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 88pzkUAkSKsJ to LrfeC0dLk8To
  fuchsia/sdk/core/mac-amd64 from JU-dKW3CQIUz to QAwORJOkyNl4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

34371894

Fix bug in Autocomplete example (#127219) · f6f5bb90

Justin McCandless authored May 22, 2023

This example was incorrectly throwing away results from a query when multiple queries were pending at once.   Thanks to @sun-jiao in https://github.com/flutter/flutter/pull/127019#issuecomment-1552347037 for pointing this out.

I also added a quick  `Text` widget explaining what to do to use the examples.  Since there are only three small possible `options`, it's easy to type into the field and not get any results and wonder what's wrong.

f6f5bb90

Roll Packages from 1e214d716ed4 to 83959fb7de37 (9 revisions) (#127322) · 5b0615c6

engine-flutter-autoroll authored May 22, 2023

https://github.com/flutter/packages/compare/1e214d716ed4...83959fb7de37

2023-05-22 JeroenWeener@users.noreply.github.com [in_app_purchases] Fix mismatching method signature strings (flutter/packages#4040)
2023-05-22 tobias@leafnode.se [go_router] Nested stateful navigation with ShellRoute (flutter/packages#2650)
2023-05-22 tobias@leafnode.se [go_router] Nested stateful navigation with ShellRoute (flutter/packages#2650)
2023-05-22 tobias@leafnode.se [go_router] Nested stateful navigation with ShellRoute (flutter/packages#2650)
2023-05-22 engine-flutter-autoroll@skia.org Roll Flutter from 077d644b to ab573048 (18 revisions) (flutter/packages#4051)
2023-05-19 engine-flutter-autoroll@skia.org Roll Flutter from 5ae64381 to 077d644b (23 revisions) (flutter/packages#4043)
2023-05-19 stuartmorgan@google.com [local_auth] Migrate iOS to Pigeon (flutter/packages#3974)
2023-05-19 hamadyalghanim@gmail.com [go_router] fix context extension for replaceNamed (flutter/packages#3927)
2023-05-19 JeroenWeener@users.noreply.github.com [image_picker] Fix crash due to `SecurityException` (flutter/packages#4004)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5b0615c6

Roll Flutter Engine from aac09195688d to f0f3fe729a91 (16 revisions) (#127292) · fdc6c135

engine-flutter-autoroll authored May 22, 2023

https://github.com/flutter/engine/compare/aac09195688d...f0f3fe729a91

2023-05-21 skia-flutter-autoroll@skia.org Roll Skia from 7c7dff949a27 to
5b2005e47bf3 (1 revision) (flutter/engine#42199)
2023-05-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
gQ989rlKAuTJHQR-C... to 88pzkUAkSKsJrNG38... (flutter/engine#42198)
2023-05-21 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
868_67npyO8nD_JCx... to JU-dKW3CQIUzhbqWE... (flutter/engine#42197)
2023-05-21 skia-flutter-autoroll@skia.org Roll Skia from a60bfcb01af9 to
7c7dff949a27 (1 revision) (flutter/engine#42195)
2023-05-20 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
c_fRDyBVZX-MwW5fS... to gQ989rlKAuTJHQR-C... (flutter/engine#42194)
2023-05-20 skia-flutter-autoroll@skia.org Roll Skia from f3e9cb7d37fd to
a60bfcb01af9 (1 revision) (flutter/engine#42193)
2023-05-20 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
sfLkc5VBFU6UkljF6... to 868_67npyO8nD_JCx... (flutter/engine#42191)
2023-05-20 kjlubick@users.noreply.github.com Move SkSurface::MakeNull to
SkSurfaces::Null (flutter/engine#42158)
2023-05-20 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
TWjmvLCOnYAUgAzvT... to c_fRDyBVZX-MwW5fS... (flutter/engine#42189)
2023-05-20 skia-flutter-autoroll@skia.org Roll Skia from b4a4782cf89d to
f3e9cb7d37fd (1 revision) (flutter/engine#42188)
2023-05-20 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
pwdDQgM88sqLmZczj... to sfLkc5VBFU6UkljF6... (flutter/engine#42187)
2023-05-20 skia-flutter-autoroll@skia.org Roll Skia from 7202b405f061 to
b4a4782cf89d (19 revisions) (flutter/engine#42185)
2023-05-20 dnfield@google.com [Impeller] avoid creating multiple
concurrent message loops for Andorid Vulkan (flutter/engine#42146)
2023-05-20 jacksongardner@google.com Implement
`ImageFilter`/`ColorFilter`/`MaskFilter` in Skwasm
(flutter/engine#42088)
2023-05-20 30870216+gaaclarke@users.noreply.github.com [Impeller] Made
other vulkan objects cleanup properly. (flutter/engine#42113)
2023-05-19 coldpalelight@gmail.com [Impeller] Fix the issue that
'coverage_coords' is incorrectly calculated in
'FillPathGeometry::GetPositionUVBuffer' (flutter/engine#42155)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from TWjmvLCOnYAU to 88pzkUAkSKsJ
  fuchsia/sdk/core/mac-amd64 from pwdDQgM88sqL to JU-dKW3CQIUz

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fdc6c135

Add myself to AUTHORS (#127298) · 883b0666

林洵锋 authored May 22, 2023

I made a few contributions.
-
[flutter/flutter](https://github.com/flutter/flutter/issues?q=author%3ALinXunFeng)
-
[flutter/engine](https://github.com/flutter/engine/pulls?q=author%3ALinXunFeng)

883b0666

20 May, 2023 3 commits

Roll Flutter Engine from 482c99af9c69 to aac09195688d (1 revision) (#127241) · ab573048

engine-flutter-autoroll authored May 20, 2023

https://github.com/flutter/engine/compare/482c99af9c69...aac09195688d

2023-05-19 47866232+chunhtai@users.noreply.github.com Overrides accessibilityScrollToVisible (flutter/engine#42047)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ab573048

Reland "[tool] Move Java functions to their own file" (#126577) · 80a4f9b1
Andrew Kolos authored May 20, 2023
```
Relands #126086, which was reverted by #126569.
```
80a4f9b1

Roll Flutter Engine from f0c02aee69db to 482c99af9c69 (1 revision) (#127240) · 0a6e1375

engine-flutter-autoroll authored May 20, 2023

https://github.com/flutter/engine/compare/f0c02aee69db...482c99af9c69

2023-05-19 skia-flutter-autoroll@skia.org Roll Dart SDK from f5716102efe8 to b3e1eeda4918 (1 revision) (flutter/engine#42172)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0a6e1375

19 May, 2023 4 commits

Do not animate `TabBarView` if controller is invalid (#123442) · 7b16cbcb
Gil Nobrega authored May 19, 2023

7b16cbcb

Run Mac intel only targets on both intel and arm (#127230) · 784ebdf2

keyonghan authored May 19, 2023

The slowness issue was resolved with latest xcode: https://github.com/flutter/flutter/issues/119750, and all these targets should resume on both platforms as before. This will help mitigate high queue time on intel bots.

This PR updates these targets:

- Mac plugin_test_ios: https://github.com/flutter/flutter/issues/119764
- Mac build_tests: https://github.com/flutter/flutter/pull/120620
- Mac plugin_test: https://github.com/flutter/flutter/pull/120714
- Mac plugin_test_macos: https://github.com/flutter/flutter/pull/122212
- Mac framework_tests_misc: https://github.com/flutter/flutter/pull/122618

784ebdf2

[Windows] Ensure window is shown (#127046) · ce61eda7

Loïc Sharma authored May 19, 2023

## Background

The Windows runner has a race at startup:

1. **Platform thread**: creates a hidden window
2. **Platform thread**: launches the Flutter engine
3. **UI/Raster threads**: renders the first frame
4. **Platform thread**: Registers a callback to show the window once the next frame has been rendered.

Steps 3 and 4 happen in parallel and it is possible for step 3 to complete before step 4 starts. In this scenario, the next frame callback is never called and the window is never shown.

As a result the `windows_startup_test`'s test, which [verifies that the "show window" callback is called](https://github.com/flutter/flutter/blob/1f09a8662dad3bb1959b24e9124e05e2b9dbff1d/dev/integration_tests/windows_startup_test/windows/runner/flutter_window.cpp#L60-L64), can flake if the first frame is rendered before the show window callback has been registered.

## Solution

This change makes the runner schedule a frame after it registers the next frame callback. If step 3 hasn't completed yet, this no-ops as a frame is already scheduled. If step 3 has already completed, a new frame will be rendered, which will call the next frame callback and show the window.

Part of https://github.com/flutter/flutter/issues/119415

See this thread for alternatives that were considered: https://github.com/flutter/engine/pull/42061#issuecomment-1550080722

ce61eda7

Roll Flutter Engine from 3267fa29491a to f0c02aee69db (4 revisions) (#127233) · 41e4c586

engine-flutter-autoroll authored May 19, 2023

https://github.com/flutter/engine/compare/3267fa29491a...f0c02aee69db

2023-05-19 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from eal6a4HeaQon_Y4ml... to TWjmvLCOnYAUgAzvT... (flutter/engine#42168)
2023-05-19 chris@bracken.jp [macOS] Extract PlatformView mutator clip updating (flutter/engine#42164)
2023-05-19 110993981+htoor3@users.noreply.github.com [web] Fix event offset for transformed widgets (and text input nodes). (flutter/engine#41870)
2023-05-19 zanderso@users.noreply.github.com Roll goldctl to f808dcff91b221ae313e540c09d79696cd08b8de (flutter/engine#42166)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from eal6a4HeaQon to TWjmvLCOnYAU

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

41e4c586