Commits · c7da629cbbb910300defa346452b9e094b534701 · abdullh.alsoleman / Front-End

11 Jul, 2023 16 commits

Roll Flutter Engine from 417c50199e14 to 5e9f0d61a42a (1 revision) (#130330) · c7da629c

engine-flutter-autoroll authored Jul 11, 2023

https://github.com/flutter/engine/compare/417c50199e14...5e9f0d61a42a

2023-07-11 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from bb8HXP6JZ60Unjk-W... to qVHNy9nU6cQKtR_IB... (flutter/engine#43552)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from bb8HXP6JZ60U to qVHNy9nU6cQK

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c7da629c

Roll Flutter Engine from bfda8f173fea to 417c50199e14 (2 revisions) (#130324) · 2fb9a3cc

engine-flutter-autoroll authored Jul 11, 2023

https://github.com/flutter/engine/compare/bfda8f173fea...417c50199e14

2023-07-11 skia-flutter-autoroll@skia.org Roll Skia from 5c8ed590d4f3 to 57cf27703ab7 (1 revision) (flutter/engine#43551)
2023-07-11 flar@google.com remove include of SkPicture files from non-Fuchsia sources (flutter/engine#43542)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2fb9a3cc

Add `Badge` widget to `NavigationBar` and `NavigationRail` examples (#129834) · 476e2d51

Taha Tesser authored Jul 11, 2023

fixes [Showcase `Badge` widget in `NavigationBar` and `NavigationRail` examples
](https://github.com/flutter/flutter/issues/129832)

| Preview | Preview | Preview |
| --------------- | --------------- | --------------- |
| <img src="https://github.com/flutter/flutter/assets/48603081/808c9577-c6b4-465f-b9fe-100d422dd408" /> | <img src="https://github.com/flutter/flutter/assets/48603081/c9b3ee03-56d7-4220-94cf-06e235631714" /> | <img src="https://github.com/flutter/flutter/assets/48603081/43fab47b-25e8-4412-92d2-6d4868e43ff8"  /> |

476e2d51

Roll Flutter Engine from 2139c8a90822 to bfda8f173fea (2 revisions) (#130321) · eaf01a9a

engine-flutter-autoroll authored Jul 11, 2023

https://github.com/flutter/engine/compare/2139c8a90822...bfda8f173fea

2023-07-11 skia-flutter-autoroll@skia.org Roll Skia from eb1cdb6bd87f to 5c8ed590d4f3 (1 revision) (flutter/engine#43549)
2023-07-11 skia-flutter-autoroll@skia.org Roll Dart SDK from f9d33db51927 to b3e9621a423e (2 revisions) (flutter/engine#43547)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

eaf01a9a

Update labeler for recent changes (#130168) · 2bf8414a
Ian Hickson authored Jul 11, 2023
```
'team' is going away, and 'tech debt' got renamed.
```
2bf8414a

fix: `ExpansionTileTheme.shape` assignment in `ExpansionTile` (#127749) · af2e2823

Darshan Rander authored Jul 11, 2023

The ExpansionTile was not following `shape` from ExpansionTileTheme as it was assigning wrong parameter to the tween.

fixes #129785

af2e2823

Roll Flutter Engine from 12aa98177cf2 to 2139c8a90822 (2 revisions) (#130316) · 74491fc7

engine-flutter-autoroll authored Jul 11, 2023

https://github.com/flutter/engine/compare/12aa98177cf2...2139c8a90822

2023-07-11 skia-flutter-autoroll@skia.org Roll Skia from 77267bf1e7b3 to eb1cdb6bd87f (2 revisions) (flutter/engine#43548)
2023-07-11 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 4.2.0 to 4.3.0 (flutter/engine#43546)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

74491fc7

Roll Flutter Engine from 767f2fb8ab03 to 12aa98177cf2 (1 revision) (#130315) · 1b756bc5

engine-flutter-autoroll authored Jul 11, 2023

https://github.com/flutter/engine/compare/767f2fb8ab03...12aa98177cf2

2023-07-11 skia-flutter-autoroll@skia.org Roll Skia from 6a5c4b0c0fcb to 77267bf1e7b3 (1 revision) (flutter/engine#43545)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1b756bc5

Implement preferPaintInterior correctly for _CompoundBorder (#129851) · d71bbfb4
Ian Hickson authored Jul 11, 2023

d71bbfb4

Roll Flutter Engine from 153d9e1d598a to 767f2fb8ab03 (1 revision) (#130313) · 81d7297d

engine-flutter-autoroll authored Jul 11, 2023

https://github.com/flutter/engine/compare/153d9e1d598a...767f2fb8ab03

2023-07-11 dnfield@google.com [Impeller] Improve resolution of text scaling. (flutter/engine#43533)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

81d7297d

Roll Flutter Engine from 2c82dd7ec54b to 153d9e1d598a (2 revisions) (#130311) · 2d951ac2

engine-flutter-autoroll authored Jul 11, 2023

https://github.com/flutter/engine/compare/2c82dd7ec54b...153d9e1d598a

2023-07-11 skia-flutter-autoroll@skia.org Roll Skia from d0991c6af2d6 to 6a5c4b0c0fcb (1 revision) (flutter/engine#43544)
2023-07-11 chinmaygarde@google.com [Impeller] Refactor barriers and add documentation. (flutter/engine#43540)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2d951ac2

Roll Flutter Engine from 312e4813a880 to 2c82dd7ec54b (1 revision) (#130309) · 901d44f2

engine-flutter-autoroll authored Jul 11, 2023

https://github.com/flutter/engine/compare/312e4813a880...2c82dd7ec54b

2023-07-11 skia-flutter-autoroll@skia.org Roll Skia from bbe71d71e576 to d0991c6af2d6 (1 revision) (flutter/engine#43543)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

901d44f2

Roll Flutter Engine from 95316fbc25a7 to 312e4813a880 (2 revisions) (#130307) · ad74a4f7

engine-flutter-autoroll authored Jul 11, 2023

https://github.com/flutter/engine/compare/95316fbc25a7...312e4813a880

2023-07-11 skia-flutter-autoroll@skia.org Roll Skia from 76daa2a33fa5 to bbe71d71e576 (1 revision) (flutter/engine#43541)
2023-07-11 flar@google.com Use full 4x4 matrix transforms in TransformLayer (flutter/engine#43536)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ad74a4f7

Add Linux implementation of the platform view example (#123731) · 8ee019d5
Robert Ancell authored Jul 11, 2023

8ee019d5

Roll Flutter Engine from daecd616f5a7 to 95316fbc25a7 (4 revisions) (#130305) · 3163306d

engine-flutter-autoroll authored Jul 11, 2023

https://github.com/flutter/engine/compare/daecd616f5a7...95316fbc25a7

2023-07-11 jonahwilliams@google.com [Impeller] Unconditionally cache swapchain msaa texture. (flutter/engine#43529)
2023-07-11 skia-flutter-autoroll@skia.org Roll Skia from c3d39bed2830 to 76daa2a33fa5 (1 revision) (flutter/engine#43539)
2023-07-11 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 4fmJ_PQoaE2L9vdx0... to cgcxIe8D4wb8hQWCV... (flutter/engine#43538)
2023-07-11 skia-flutter-autoroll@skia.org Roll Skia from 2db628aa1181 to c3d39bed2830 (1 revision) (flutter/engine#43537)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 4fmJ_PQoaE2L to cgcxIe8D4wb8

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3163306d

Roll Flutter Engine from 2a0dd9d2f28e to daecd616f5a7 (3 revisions) (#130298) · 488ad384

engine-flutter-autoroll authored Jul 11, 2023

https://github.com/flutter/engine/compare/2a0dd9d2f28e...daecd616f5a7

2023-07-10 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from raXixVs2pKxD9ZasB... to bb8HXP6JZ60Unjk-W... (flutter/engine#43532)
2023-07-10 skia-flutter-autoroll@skia.org Roll Dart SDK from 3778952664e0 to f9d33db51927 (1 revision) (flutter/engine#43531)
2023-07-10 skia-flutter-autoroll@skia.org Roll Skia from aad8fbb17d69 to 2db628aa1181 (1 revision) (flutter/engine#43530)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from raXixVs2pKxD to bb8HXP6JZ60U

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

488ad384

10 Jul, 2023 20 commits

Roll Flutter Engine from 7d054abf842c to 2a0dd9d2f28e (4 revisions) (#130296) · 829d1482

engine-flutter-autoroll authored Jul 10, 2023

https://github.com/flutter/engine/compare/7d054abf842c...2a0dd9d2f28e

2023-07-10 chinmaygarde@google.com [Impeller] Fix Vulkan validation error when there is a blit directed at a swapchain image. (flutter/engine#43527)
2023-07-10 skia-flutter-autoroll@skia.org Roll Skia from 89313a8cadab to aad8fbb17d69 (3 revisions) (flutter/engine#43526)
2023-07-10 skia-flutter-autoroll@skia.org Roll Skia from c06d7ef5c276 to 89313a8cadab (2 revisions) (flutter/engine#43521)
2023-07-10 jonahwilliams@google.com [Impeller] Don't decompress into device buffer for Vulkan/GLES. (flutter/engine#43493)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

829d1482

Bump actions/labeler from 4.2.0 to 4.3.0 (#130291) · 6865bb4c

dependabot[bot] authored Jul 10, 2023

Bumps [actions/labeler](https://github.com/actions/labeler) from 4.2.0 to 4.3.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/labeler/releases">actions/labeler's releases</a>.</em></p>
<blockquote>
<h2>v4.3.0</h2>
<h2>What's Changed</h2>
<p>In scope of this release, the ability to specify pull request number(s) was added by <a href="https://github.com/credfeto"><code>@âcredfeto</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/349">actions/labeler#349</a>.</p>
<p>Support for reading from the configuration file presented on the runner was added by <a href="https://github.com/lrstanley"><code>@âlrstanley</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/394">actions/labeler#394</a>. It allows you to use a configuration file generated during workflow run or uploaded from a separate repository.</p>
<p>Please refer to the <a href="https://github.com/actions/labeler#inputs">action documentation</a> for more information.</p>
<p>This release also includes the following changes:</p>
<ul>
<li>Improved Error message for missing config file by <a href="https://github.com/Gornoka"><code>@âGornoka</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/475">actions/labeler#475</a></li>
<li>Early exit when no files are changed by <a href="https://github.com/nathanhammond"><code>@ânathanhammond</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/456">actions/labeler#456</a></li>
<li>Add examples to match all repo files by <a href="https://github.com/MaksimZhukov"><code>@âMaksimZhukov</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/600">actions/labeler#600</a></li>
<li>Fix a typo in the example about using the action outputs by <a href="https://github.com/MaksimZhukov"><code>@âMaksimZhukov</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/606">actions/labeler#606</a></li>
<li>Bump eslint from 8.43.0 to 8.44.0 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/601">actions/labeler#601</a></li>
<li>Bump <code>@âtypescript-eslint/parser</code> from 5.60.1 to 5.61.0 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/602">actions/labeler#602</a></li>
<li>Bump <code>@âtypescript-eslint/eslint-plugin</code> from 5.60.1 to 5.61.0 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/604">actions/labeler#604</a></li>
<li>Bump tough-cookie from 4.1.2 to 4.1.3 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/609">actions/labeler#609</a></li>
<li>Bump <code>@âoctokit/plugin-retry</code> from 5.0.4 to 5.0.5 by <a href="https://github.com/MaksimZhukov"><code>@âMaksimZhukov</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/610">actions/labeler#610</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/credfeto"><code>@âcredfeto</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/349">actions/labeler#349</a></li>
<li><a href="https://github.com/lrstanley"><code>@âlrstanley</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/394">actions/labeler#394</a></li>
<li><a href="https://github.com/nathanhammond"><code>@ânathanhammond</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/456">actions/labeler#456</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/labeler/compare/v4...v4.3.0">https://github.com/actions/labeler/compare/v4...v4.3.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/actions/labeler/commit/ac9175f8a1f3625fd0d4fb234536d26811351594"><code>ac9175f</code></a> Bump <code>@âoctokit/plugin-retry</code> from 5.0.4 to 5.0.5 (<a href="https://redirect.github.com/actions/labeler/issues/610">#610</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/7542ec79bbc4b2df8fc6983f925b7d2c4cee14bf"><code>7542ec7</code></a> Bump tough-cookie from 4.1.2 to 4.1.3 (<a href="https://redirect.github.com/actions/labeler/issues/609">#609</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/be13bbd1b71393037c1fca23f8dd890c37314acb"><code>be13bbd</code></a> Early exit when no files are changed. (<a href="https://redirect.github.com/actions/labeler/issues/456">#456</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/994304c5d5eaa3767a8d1b4b28b05fcb357b09cf"><code>994304c</code></a> feat(config): support reading from local file if it exists (<a href="https://redirect.github.com/actions/labeler/issues/394">#394</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/327d35fdca04144f9c5921602b72567e46a3df4d"><code>327d35f</code></a> Added ability to pass in an optional PR number as a parameter (<a href="https://redirect.github.com/actions/labeler/issues/349">#349</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/65f306b6dd0b8a09b1b328b60fd3ac0569042bf1"><code>65f306b</code></a> Fix a typo in the example about using the action outputs (<a href="https://redirect.github.com/actions/labeler/issues/606">#606</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/b669025b7ce59f25f82f9c71a432c15232ccb9ae"><code>b669025</code></a> Bump <code>@âtypescript-eslint/eslint-plugin</code> from 5.60.1 to 5.61.0 (<a href="https://redirect.github.com/actions/labeler/issues/604">#604</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/52979ba0af23b8aa1272d83a62fbf9d4e13c8a24"><code>52979ba</code></a> Bump <code>@âtypescript-eslint/parser</code> from 5.60.1 to 5.61.0 (<a href="https://redirect.github.com/actions/labeler/issues/602">#602</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/5bea1458bb4447df9047383f3c51225b82cda3ba"><code>5bea145</code></a> Bump eslint from 8.43.0 to 8.44.0 (<a href="https://redirect.github.com/actions/labeler/issues/601">#601</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/a2124851476f3021a479b14e553878efba8cd0dc"><code>a212485</code></a> Add examples to match all repo files (<a href="https://redirect.github.com/actions/labeler/issues/600">#600</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/actions/labeler/compare/0967ca812e7fdc8f5f71402a1b486d5bd061fe20...ac9175f8a1f3625fd0d4fb234536d26811351594">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/labeler&package-manager=github_actions&previous-version=4.2.0&new-version=4.3.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

6865bb4c

Roll Flutter Engine from b328b034f07b to 7d054abf842c (3 revisions) (#130287) · f30e6f45

engine-flutter-autoroll authored Jul 10, 2023

https://github.com/flutter/engine/compare/b328b034f07b...7d054abf842c

2023-07-10 bdero@google.com [Impeller] Add matrix backdrop filter golden. (flutter/engine#43484)
2023-07-10 skia-flutter-autoroll@skia.org Roll Skia from 03e689a0fa32 to c06d7ef5c276 (1 revision) (flutter/engine#43520)
2023-07-10 robert.ancell@canonical.com Use better method of ensuring that *_get_type() functions are exported (flutter/engine#43395)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f30e6f45

Roll Flutter Engine from 71c5674a44a5 to b328b034f07b (1 revision) (#130282) · 38e568e0

engine-flutter-autoroll authored Jul 10, 2023

https://github.com/flutter/engine/compare/71c5674a44a5...b328b034f07b

2023-07-10 skia-flutter-autoroll@skia.org Roll Skia from 7e45a9fbca5f to 03e689a0fa32 (2 revisions) (flutter/engine#43517)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

38e568e0

Roll Flutter Engine from 3beba397ca4d to 71c5674a44a5 (1 revision) (#130278) · cb91ba11

engine-flutter-autoroll authored Jul 10, 2023

https://github.com/flutter/engine/compare/3beba397ca4d...71c5674a44a5

2023-07-10 skia-flutter-autoroll@skia.org Roll Dart SDK from 4998bf65f91c to 3778952664e0 (6 revisions) (flutter/engine#43516)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cb91ba11

re-enable "Linux packages_autoroller" (#130088) · b89bfd8e

Christopher Fujino authored Jul 10, 2023

Fixes https://github.com/flutter/flutter/issues/129744

This change:

1. re-enables the Linux packages_autoroller
2. ensures we redact the token from appearing in any logs (in local testing I realized some failure logs might still expose the token)

What actually fixed authentication however was creating and uploading a new GitHub personal access token, not this change.

It's currently failing post-submit because being marked `bringup` it is running in the try pool, which does not have permissions to access the cloud KMS. However, I ran a LED build in the prod pool that succeeded:

https://ci.chromium.org/raw/build/logs.chromium.org/flutter/led/fujino_google.com/3a8f128c352fca53a9a29f1e7eab6c3ed24f3bb2a5feb196ea1a69127540e8a6/+/build.proto?server=chromium-swarm.appspot.com

b89bfd8e

Roll Flutter Engine from 1de141c6a6e7 to 3beba397ca4d (1 revision) (#130276) · 613bc890

engine-flutter-autoroll authored Jul 10, 2023

https://github.com/flutter/engine/compare/1de141c6a6e7...3beba397ca4d

2023-07-10 skia-flutter-autoroll@skia.org Roll Skia from 320f01ac1de7 to 7e45a9fbca5f (3 revisions) (flutter/engine#43515)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

613bc890

Throw error on unexpected positional arguments (#130274) · dabd7b3b

Tae Hyung Kim authored Jul 10, 2023

This PR fixes ignoring when random positional arguments added to the
`flutter gen-l10n`.

So we are no longer able to call `flutter gen-l10n hello world` or
`flutter gen-l10n --format false`.

Fixes https://github.com/flutter/flutter/issues/118203

dabd7b3b

Roll Flutter Engine from 7b826a78e73c to 1de141c6a6e7 (2 revisions) (#130275) · f731af63

engine-flutter-autoroll authored Jul 10, 2023

https://github.com/flutter/engine/compare/7b826a78e73c...1de141c6a6e7

2023-07-10 skia-flutter-autoroll@skia.org Roll Skia from 1c9e2588b577 to 320f01ac1de7 (6 revisions) (flutter/engine#43514)
2023-07-10 2539699336@qq.com [iOS][Keyboard] Reland wait vsync on UI thread and update viewport inset to avoid jitter (flutter/engine#43463)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f731af63

Change resultBundlePath representation from File to Directory (#130156) · 6c202316

Victoria Ashworth authored Jul 10, 2023

`resultBundlePath` is meant to be a directory. In the `xcodebuild --help`, it describes it as a directory: 
```
-resultBundlePath PATH     specifies the directory where a result bundle describing what occurred will be placed
```

This PR changes our usage of it from a file to a directory so that it gets deleted correctly between reruns.

Fixes https://github.com/flutter/flutter/issues/129954.

6c202316

Roll Flutter Engine from 168b68c304a5 to 7b826a78e73c (1 revision) (#130273) · 99a47c84

engine-flutter-autoroll authored Jul 10, 2023

https://github.com/flutter/engine/compare/168b68c304a5...7b826a78e73c

2023-07-10 skia-flutter-autoroll@skia.org Roll Skia from 17686918fa1f to 1c9e2588b577 (3 revisions) (flutter/engine#43513)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

99a47c84

Roll Packages from b61eea12dbf9 to 4469c5e95dd8 (15 revisions) (#130266) · 2eaec8f5

engine-flutter-autoroll authored Jul 10, 2023

https://github.com/flutter/packages/compare/b61eea12dbf9...4469c5e95dd8

2023-07-08 engine-flutter-autoroll@skia.org Roll Flutter from d55a7d89 to 65ff3cb9 (21 revisions) (flutter/packages#4413)
2023-07-08 stuartmorgan@google.com [tool] Update Dart SDK version (flutter/packages#4402)
2023-07-08 stuartmorgan@google.com [url_lancher] Don't use `canLaunchUrl` in Link (flutter/packages#4400)
2023-07-08 32242716+ricardoamador@users.noreply.github.com Remove unused autosubmit configuration file (flutter/packages#4410)
2023-07-07 49699333+dependabot[bot]@users.noreply.github.com [file_selector]: Bump androidx.annotation:annotation from 1.5.0 to 1.6.0 in /packages/file_selector/file_selector_android/android (flutter/packages#4312)
2023-07-07 engine-flutter-autoroll@skia.org Roll Flutter from bc49cd1b to d55a7d89 (17 revisions) (flutter/packages#4403)
2023-07-07 tarrinneal@gmail.com [shared_preferences] Variable binding in a condition requires an initializer fix (flutter/packages#4407)
2023-07-07 jhy03261997@gmail.com [go_router] implemented helpers for StatefulShellRoute (flutter/packages#4228)
2023-07-07 34871572+gmackall@users.noreply.github.com [in_app_purchase_android] Bump com.android.billingclient:billing from 5.2.0 to 6.0.0. (flutter/packages#4390)
2023-07-07 stuartmorgan@google.com [tool] Use 'flutter pub get' for Flutter packages (flutter/packages#4397)
2023-07-07 stuartmorgan@google.com [ci] Enable LUCI stable custom Linux tests (flutter/packages#4404)
2023-07-07 stuartmorgan@google.com [tool] Fix --current-package for app-facing packages (flutter/packages#4399)
2023-07-07 stuartmorgan@google.com [ci] Switch some tests to LUCI (flutter/packages#4395)
2023-07-07 tarrinneal@gmail.com [flutter_markdown] Pass parent TextStyle down to MarkdownElementBuilder.visitElementAfter (flutter/packages#4393)
2023-07-07 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.3.3 to 2.20.3 (flutter/packages#4394)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2eaec8f5

Fix default icon color constants reversed brightness documentation (#130231) · b828846f

Rydmike authored Jul 10, 2023

Fixes the reversed default icon color constants brightness documentation for `kDefaultIconLightColor` and `kDefaultIconDarkColor`.

FIX: https://github.com/flutter/flutter/issues/130230

b828846f

Roll Flutter Engine from 27f121896356 to 168b68c304a5 (2 revisions) (#130265) · bde20211

engine-flutter-autoroll authored Jul 10, 2023

https://github.com/flutter/engine/compare/27f121896356...168b68c304a5

2023-07-10 skia-flutter-autoroll@skia.org Roll Skia from cf3f3d048122 to 17686918fa1f (1 revision) (flutter/engine#43511)
2023-07-10 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from eRSQn0XKuI7byK2i_... to 4fmJ_PQoaE2L9vdx0... (flutter/engine#43510)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from eRSQn0XKuI7b to 4fmJ_PQoaE2L

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bde20211

Roll Flutter Engine from 49c6dcdac5ad to 27f121896356 (2 revisions) (#130255) · 4ca4464b

engine-flutter-autoroll authored Jul 10, 2023

https://github.com/flutter/engine/compare/49c6dcdac5ad...27f121896356

2023-07-10 skia-flutter-autoroll@skia.org Roll Skia from 0a1e7aeb29b5 to cf3f3d048122 (1 revision) (flutter/engine#43509)
2023-07-10 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from aQqgcKf1EwSoRWDet... to raXixVs2pKxD9ZasB... (flutter/engine#43508)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from aQqgcKf1EwSo to raXixVs2pKxD

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4ca4464b

Roll Flutter Engine from 074135bbcc61 to 49c6dcdac5ad (1 revision) (#130252) · 2fd4f8bf

engine-flutter-autoroll authored Jul 10, 2023

https://github.com/flutter/engine/compare/074135bbcc61...49c6dcdac5ad

2023-07-10 robert.ancell@canonical.com Fix leak when switching channels (flutter/engine#41827)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2fd4f8bf

Roll Flutter Engine from e193c7c61bdb to 074135bbcc61 (1 revision) (#130246) · 9e76d54e

engine-flutter-autoroll authored Jul 10, 2023

https://github.com/flutter/engine/compare/e193c7c61bdb...074135bbcc61

2023-07-10 skia-flutter-autoroll@skia.org Roll Skia from a72649f13420 to 0a1e7aeb29b5 (1 revision) (flutter/engine#43505)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9e76d54e

Roll Flutter Engine from ed3c5534ac6c to e193c7c61bdb (1 revision) (#130240) · 1f2998e2

engine-flutter-autoroll authored Jul 10, 2023

https://github.com/flutter/engine/compare/ed3c5534ac6c...e193c7c61bdb

2023-07-10 skia-flutter-autoroll@skia.org Roll Skia from ab7f95f52ea6 to a72649f13420 (3 revisions) (flutter/engine#43504)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1f2998e2

Roll Flutter Engine from 09c6ce42436b to ed3c5534ac6c (1 revision) (#130238) · c565cff9

engine-flutter-autoroll authored Jul 10, 2023

https://github.com/flutter/engine/compare/09c6ce42436b...ed3c5534ac6c

2023-07-10 dan@mindstab.net [linux] Allow overriding aot_library_path (flutter/engine#42555)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c565cff9

Roll Flutter Engine from 382a0be57584 to 09c6ce42436b (1 revision) (#130233) · 53452217

engine-flutter-autoroll authored Jul 10, 2023

https://github.com/flutter/engine/compare/382a0be57584...09c6ce42436b

2023-07-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from E9CEA-wZJ9VgSP80c... to eRSQn0XKuI7byK2i_... (flutter/engine#43498)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from E9CEA-wZJ9Vg to eRSQn0XKuI7b

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

53452217

09 Jul, 2023 4 commits

Roll Flutter Engine from 111051e4f517 to 382a0be57584 (1 revision) (#130232) · 899ebe35

engine-flutter-autoroll authored Jul 09, 2023

https://github.com/flutter/engine/compare/111051e4f517...382a0be57584

2023-07-09 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from UKVzvetd5M4SA_ufb... to aQqgcKf1EwSoRWDet... (flutter/engine#43497)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from UKVzvetd5M4S to aQqgcKf1EwSo

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

899ebe35

Roll Flutter Engine from 9ae623328d28 to 111051e4f517 (1 revision) (#130225) · 3ec96a8a

engine-flutter-autoroll authored Jul 09, 2023

https://github.com/flutter/engine/compare/9ae623328d28...111051e4f517

2023-07-09 skia-flutter-autoroll@skia.org Roll Skia from 05ce4af04609 to ab7f95f52ea6 (1 revision) (flutter/engine#43496)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3ec96a8a

Roll Flutter Engine from 594701beda2c to 9ae623328d28 (1 revision) (#130223) · bc5ba6bf

engine-flutter-autoroll authored Jul 09, 2023

https://github.com/flutter/engine/compare/594701beda2c...9ae623328d28

2023-07-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 8X61T1htYuHQtWtFv... to E9CEA-wZJ9VgSP80c... (flutter/engine#43495)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 8X61T1htYuHQ to E9CEA-wZJ9Vg

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bc5ba6bf

Roll Flutter Engine from 958591a1c0e8 to 594701beda2c (1 revision) (#130218) · a35e42a8

engine-flutter-autoroll authored Jul 09, 2023

https://github.com/flutter/engine/compare/958591a1c0e8...594701beda2c

2023-07-09 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from TSpkNWkgR0F7xl8q5... to UKVzvetd5M4SA_ufb... (flutter/engine#43494)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from TSpkNWkgR0F7 to UKVzvetd5M4S

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a35e42a8