- 15 Feb, 2024 16 commits
-
-
Bartek Pacia authored
This PR will make it easier for future Flutter-Android apps/plugins/modules etc. to migrate to Gradle Kotlin DSL. This PR is similar to #140452 but concerns public Gradle templates instead of Flutter's internal Gradle code. It should be a no-op change. **before** ![before](https://github.com/flutter/flutter/assets/40357511/5d0cb2bb-a693-43bc-aa10-b8f431e0c68c) **after** ![after](https://github.com/flutter/flutter/assets/40357511/e4a945a5-866f-42f7-813b-b08b26bb89dc)
-
godofredoc authored
The Windows arm64 builds were all moved to bringup because new test beds not properly provisioned were added to the production pool. Those new test beds are now fully validated but still running on staging pool to ensure they are not introducing noise in the prod pools. Bug: https://github.com/flutter/flutter/issues/143180
-
Jake authored
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
-
Jonah Williams authored
This is the next step in archiving flutter/gallery - move devicelab tests to use the local copy.
-
dependabot[bot] authored
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.24.1 to 3.24.3. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p> <blockquote> <h1>CodeQL Action Changelog</h1> <p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p> <p>Note that the only difference between <code>v2</code> and <code>v3</code> of the CodeQL Action is the node version they support, with <code>v3</code> running on node 20 while we continue to release <code>v2</code> to support running on node 16. For example <code>3.22.11</code> was the first <code>v3</code> release and is functionally identical to <code>2.22.11</code>. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers.</p> <h2>[UNRELEASED]</h2> <p>No user facing changes.</p> <h2>3.24.3 - 15 Feb 2024</h2> <ul> <li>Fix an issue where the CodeQL Action would fail to load a configuration specified by the <code>config</code> input to the <code>init</code> Action. <a href="https://redirect.github.com/github/codeql-action/pull/2147">#2147</a></li> </ul> <h2>3.24.2 - 15 Feb 2024</h2> <ul> <li>Enable improved multi-threaded performance on larger runners for GitHub Enterprise Server users. This feature is already available to GitHub.com users. <a href="https://redirect.github.com/github/codeql-action/pull/2141">#2141</a></li> </ul> <h2>3.24.1 - 13 Feb 2024</h2> <ul> <li>Update default CodeQL bundle version to 2.16.2. <a href="https://redirect.github.com/github/codeql-action/pull/2124">#2124</a></li> <li>The CodeQL action no longer fails if it can't write to the telemetry api endpoint. <a href="https://redirect.github.com/github/codeql-action/pull/2121">#2121</a></li> </ul> <h2>3.24.0 - 02 Feb 2024</h2> <ul> <li>CodeQL Python analysis will no longer install dependencies on GitHub Enterprise Server, as is already the case for GitHub.com. See <a href="https://github.com/github/codeql-action/blob/main/#3230---08-jan-2024">release notes for 3.23.0</a> for more details. <a href="https://redirect.github.com/github/codeql-action/pull/2106">#2106</a></li> </ul> <h2>3.23.2 - 26 Jan 2024</h2> <ul> <li>On Linux, the maximum possible value for the <code>--threads</code> option now respects the CPU count as specified in <code>cgroup</code> files to more accurately reflect the number of available cores when running in containers. <a href="https://redirect.github.com/github/codeql-action/pull/2083">#2083</a></li> <li>Update default CodeQL bundle version to 2.16.1. <a href="https://redirect.github.com/github/codeql-action/pull/2096">#2096</a></li> </ul> <h2>3.23.1 - 17 Jan 2024</h2> <ul> <li>Update default CodeQL bundle version to 2.16.0. <a href="https://redirect.github.com/github/codeql-action/pull/2073">#2073</a></li> <li>Change the retention period for uploaded debug artifacts to 7 days. Previously, this was whatever the repository default was. <a href="https://redirect.github.com/github/codeql-action/pull/2079">#2079</a></li> </ul> <h2>3.23.0 - 08 Jan 2024</h2> <ul> <li>We are rolling out a feature in January 2024 that will disable Python dependency installation by default for all users. This improves the speed of analysis while having only a very minor impact on results. You can override this behavior by setting <code>CODEQL_ACTION_DISABLE_PYTHON_DEPENDENCY_INSTALLATION=false</code> in your workflow, however we plan to remove this ability in future versions of the CodeQL Action. <a href="https://redirect.github.com/github/codeql-action/pull/2031">#2031</a></li> <li>The CodeQL Action now requires CodeQL version 2.11.6 or later. For more information, see <a href="https://github.com/github/codeql-action/blob/main/#2227---16-nov-2023">the corresponding changelog entry for CodeQL Action version 2.22.7</a>. <a href="https://redirect.github.com/github/codeql-action/pull/2009">#2009</a></li> </ul> <h2>3.22.12 - 22 Dec 2023</h2> <ul> <li>Update default CodeQL bundle version to 2.15.5. <a href="https://redirect.github.com/github/codeql-action/pull/2047">#2047</a></li> </ul> <h2>3.22.11 - 13 Dec 2023</h2> <ul> <li>[v3+ only] The CodeQL Action now runs on Node.js v20. <a href="https://redirect.github.com/github/codeql-action/pull/2006">#2006</a></li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/github/codeql-action/commit/379614612a29c9e28f31f39a59013eb8012a51f0"><code>3796146</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2148">#2148</a> from github/update-v3.24.3-3a7796d6a</li> <li><a href="https://github.com/github/codeql-action/commit/01d302a04eea70ce81e7926c05c80a4dd30f9d2c"><code>01d302a</code></a> Update changelog for v3.24.3</li> <li><a href="https://github.com/github/codeql-action/commit/3a7796d6ad0e2a3b9d7480095a365f27bc6452d1"><code>3a7796d</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2147">#2147</a> from github/henrymercer/fix-config-outside-workspace...</li> <li><a href="https://github.com/github/codeql-action/commit/56b93f29ebc6b37e35f050c9ed056fbe82c78060"><code>56b93f2</code></a> Add changelog note</li> <li><a href="https://github.com/github/codeql-action/commit/381e65f460073fc12b3dac08ba3f62b2b2e7ba46"><code>381e65f</code></a> Allow generated user config file to be outside the workspace</li> <li><a href="https://github.com/github/codeql-action/commit/d88d538126113b4fe52fe9ba17f9dc19ba505d12"><code>d88d538</code></a> Add PR check for specifying configuration using the <code>config</code> input</li> <li><a href="https://github.com/github/codeql-action/commit/dc983b33c32da66f1acc44a1d5ed69d94e9ffb64"><code>dc983b3</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2143">#2143</a> from github/mergeback/v3.24.2-to-main-ece8414c</li> <li><a href="https://github.com/github/codeql-action/commit/66a4732f1d8a89e7232232a4bdd1a4d16ee73eb5"><code>66a4732</code></a> Update checked-in dependencies</li> <li><a href="https://github.com/github/codeql-action/commit/e62fb8e891989ac0311b4082acf0b45cac614f2a"><code>e62fb8e</code></a> Update changelog and version after v3.24.2</li> <li><a href="https://github.com/github/codeql-action/commit/ece8414c725e29de2e18c0859fda9e7280df9488"><code>ece8414</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2142">#2142</a> from github/update-v3.24.2-1a41e5519</li> <li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/e675ced7a7522a761fc9c8eb26682c8b27c42b2b...379614612a29c9e28f31f39a59013eb8012a51f0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=3.24.1&new-version=3.24.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
-
Danny Tuppeny authored
Builds can be slow and the legacy debug adapter would handle Flutter's `app.progress` events to update the toast notification during builds. This was lost in the new adapters - we should only a single "Launching.." notification for the whole progress. This change listens to `app.progress` events and forwards those with `finished=false` to the client if the launch progress is still active. Fixes https://github.com/Dart-Code/Dart-Code/issues/4938 https://github.com/flutter/flutter/assets/1078012/8c60cf08-e034-4a72-b31e-9c61dca388bf
-
Matan Lurey authored
Closes https://github.com/flutter/flutter/issues/142178.
-
auto-submit[bot] authored
Reverts flutter/flutter#143517 Initiated by: dnfield Reason for reverting: broke CI, see https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_benchmarks_skwasm/3446/overview Original PR Author: mkustermann Reviewed By: {eyebrowsoffire} This change reverts the following previous change: Original Description: * Make `flutter build web` have one option that determins the optimization level: `-O<level>` / `--optimization-level=<level>` => Defaulting to -O4 => Will apply to both dart2js and dart2wasm * Deprecate `--dart2js-optimization=O<level>` * Disentagle concept of optimization from concept of static symbols => Add a `--strip-wasm` / `--no-strip-wasm` flag that determins whether static symbols are kept in the resulting wasm file. * Remove copy&past'ed code in the tests for wasm build tests * Cleanup some artifacts code, now that we no longer use `wasm-opt` inside flutter tools
-
Kate Lovett authored
Relands https://github.com/flutter/flutter/pull/143386 Which was reverted in https://github.com/flutter/flutter/pull/143523 Fixes https://github.com/flutter/flutter/issues/143173 Unblocks https://github.com/flutter/flutter/pull/143485 â â¡ï¸ Update from the revert is in this commit: https://github.com/flutter/flutter/pull/143527/commits/1e6853291eba42ee7005f284265118be33c99673
-
Martin Kustermann authored
* Make `flutter build web` have one option that determins the optimization level: `-O<level>` / `--optimization-level=<level>` => Defaulting to -O4 => Will apply to both dart2js and dart2wasm * Deprecate `--dart2js-optimization=O<level>` * Disentagle concept of optimization from concept of static symbols => Add a `--strip-wasm` / `--no-strip-wasm` flag that determins whether static symbols are kept in the resulting wasm file. * Remove copy&past'ed code in the tests for wasm build tests * Cleanup some artifacts code, now that we no longer use `wasm-opt` inside flutter tools
-
Jonah Williams authored
Fixes https://github.com/flutter/flutter/issues/143482 This brings in the gallery more or less as is: * Removed localizations * Ensure tests still run (locally verified, will switch CI later). * Removed deferred components * Fixup pubspec
-
godofredoc authored
The dependency was added as temporary workaround and was never removed. Bug: https://github.com/flutter/flutter/issues/143489 Bug: https://github.com/flutter/flutter/issues/143490
-
auto-submit[bot] authored
Reverts flutter/flutter#143386 Initiated by: Piinks Reason for reverting: This broke a customer test. Original PR Author: Piinks Reviewed By: {goderbauer} This change reverts the following previous change: Original Description: Fixes https://github.com/flutter/flutter/issues/143173 The `start` and `end` parameters of `SemanticsController.simulatedAccessibilityTraversal` were deprecated in https://github.com/flutter/flutter/issues/112413, but no tests were added that verified the new API.
😳 This change - fixes a typo in an error message - fixes the new `startNode` and `endNode` not being accounted for in setting the traversal range - adds dart fixes for the deprecations - adds tests for the new API that is meant to replace the deprecated one. - Filed https://github.com/flutter/flutter/issues/143405 to follow up on the new API not working in multiple views. -
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/a8642544730a...ef349bec8ee9 2024-02-15 stuartmorgan@google.com [url_launcher] Replace deprecated RouteInformation APIs (flutter/packages#6127) 2024-02-15 stuartmorgan@google.com [rfw] Replace deprecated `textScaleFactor` (flutter/packages#6130) 2024-02-15 stuartmorgan@google.com [flutter_adaptive_scaffold] Replace deprecated APIs (flutter/packages#6129) 2024-02-14 engine-flutter-autoroll@skia.org Roll Flutter from eb5d0a43 to a628814e (72 revisions) (flutter/packages#6118) 2024-02-14 stuartmorgan@google.com [flutter_migrate] Replace deprecated APIs (flutter/packages#6128) 2024-02-14 stuartmorgan@google.com [flutter_image] Replace deprecated APIs (flutter/packages#6126) 2024-02-14 stuartmorgan@google.com [tools] Ignore analysis options files in .symlinks (flutter/packages#6119) 2024-02-14 stuartmorgan@google.com [various] Clean up `deprecated_member_use` ignores (flutter/packages#6123) 2024-02-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.0 to 3.24.1 (flutter/packages#6121) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Hossein Yousefi authored
* Use `dart run` instead of `flutter pub run` in the documentation as it is now deprecated. * Use `int64_t` instead of `intptr_t` for `sum` examples.
-
godofredoc authored
The certs dependency was added in 2020 as a workaround for missing certificates in win 10 images. These dependency is not required for windows arm64 builds because they are running on win 11.
-
- 14 Feb, 2024 22 commits
-
-
auto-submit[bot] authored
Reverts flutter/flutter#143334 Initiated by: hangyujin Reason for reverting: broke g3 tests Original PR Author: hangyujin Reviewed By: {LongCatIsLooong} This change reverts the following previous change: Original Description: Add a semantics flag to text field to fix https://github.com/flutter/flutter/issues/143337 (in IOS the disabled text field is not read `dimmed`) internal: b/322345393
-
auto-submit[bot] authored
Reverts flutter/flutter#143117 Initiated by: dnfield Reason for reverting: made the tree red. Original PR Author: hangyujin Reviewed By: {QuncCccccc} This change reverts the following previous change: Original Description: fixes: https://github.com/flutter/flutter/issues/143116 fixes: https://github.com/flutter/flutter/issues/141992 https://b.corp.google.com/issues/322173632
-
hangyu authored
fixes: [DatePicker edit field](https://github.com/flutter/flutter/issues/143116) https://b.corp.google.com/issues/322173632
-
Michael Goderbauer authored
Follow-up to https://github.com/flutter/flutter/pull/143347.
-
Kate Lovett authored
Fixes https://github.com/flutter/flutter/issues/143173 The `start` and `end` parameters of `SemanticsController.simulatedAccessibilityTraversal` were deprecated in https://github.com/flutter/flutter/issues/112413, but no tests were added that verified the new API. ð³ This change - fixes a typo in an error message - fixes the new `startNode` and `endNode` not being accounted for in setting the traversal range - adds dart fixes for the deprecations - adds tests for the new API that is meant to replace the deprecated one. - Filed https://github.com/flutter/flutter/issues/143405 to follow up on the new API not working in multiple views.
-
Michael Goderbauer authored
Follow-up to https://github.com/flutter/flutter/pull/143347. As https://github.com/flutter/flutter/pull/143403 uncovered, deprecation warnings were still enabled for the mega_gallery because it doesn't use the analysis_options.yaml file from the flutter root. This change injects a analysis_options.yaml file for the mega_gallery that disables those warnings. Submitting this separately from https://github.com/flutter/flutter/pull/143403 in case it affects the mega_gallery benchmark to get a clean new baseline before removing all the `deprecated_member_use` ignores.
-
Qun Cheng authored
Fixes #142895 With the change of #143121, this PR is to add auto scroll to `PopupMenuButton` so when we open the menu, it will automatically scroll to the selected item. https://github.com/flutter/flutter/assets/36861262/c2bc0395-0641-4e7a-a54d-57a8e62ee26f
-
Daco Harkes authored
Roll of https://github.com/dart-lang/native/pull/964, which separates the `KernelAsset`s (the asset information embedded in the Dart kernel snapshot) from `Asset`s (the assets in the `build.dart` protocol). See the linked issue for why they ought to be different instead of shared. This PR does not change any functionality in Flutter. (Now that https://github.com/flutter/flutter/pull/143055 has landed, we can land breaking changes.) For reference, the same roll in the Dart SDK: https://dart-review.googlesource.com/c/sdk/+/352642
-
Bruno Leroux authored
## Description This PR is the second step for the M3 test migration for `InputDecorator` (step 1 was https://github.com/flutter/flutter/pull/142981). This PR migrate the two first tests of the M2 section. Those were big tests. I splitted them in several testsn organized in groups, and I narrowed their scope when possible. @justinmc I did not move yet the M2 tests to a separate file (I move them to a group) because it would mean we loss the line history which is useful during the migration. In the next step, I will focus on moving out some tests that are in the 'Material2' group (the ones that are ok with both M2 and M3). ## Related Issue Related to https://github.com/flutter/flutter/issues/139076 ## Tests Adds several tests for M3.
-
Bruno Leroux authored
## Description This PR adds more documentation for `TextEditingController(String text)` constructor and it adds one example. https://github.com/flutter/flutter/pull/96245 was a first improvement to the documentation. https://github.com/flutter/flutter/issues/79495 tried to hide the cursor when an invalid selection is set but it was reverted. https://github.com/flutter/flutter/pull/123777 mitigated the issue of having a default invalid selection: it takes care of setting a proper selection when a text field is focused and its controller selection is not initialized. I will try changing the initial selection in another PR, but It will probably break several existing tests. ## Related Issue Fixes https://github.com/flutter/flutter/issues/95978 ## Tests Adds 1 test for the new example.
-
Gray Mackall authored
Entire pr generated with [ktlint](https://github.com/pinterest/ktlint) --format. First step before enabling linting as part of presubmit for kotlin changes.
-
Flutter GitHub Bot authored
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Linux_pixel_7pro integration_ui_keyboard_resize" } --> The issue https://github.com/flutter/flutter/issues/140645 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_pixel_7pro%20integration_ui_keyboard_resize%22). This test can be marked as unflaky.
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/9385bbb3cf46...a8642544730a 2024-02-14 matanlurey@users.noreply.github.com Allow deprecated members from the Dart SDK/Flutter Framework to roll in (flutter/packages#6111) 2024-02-14 43054281+camsim99@users.noreply.github.com [google_maps_flutter][iOS 12] Skip `testTakeSnapshot` (flutter/packages#6120) 2024-02-13 stuartmorgan@google.com [ci] Allow dependencies on local_auth_ios (flutter/packages#6116) 2024-02-13 40719830+Alex-Usmanov@users.noreply.github.com [url_launcher] Add `InAppBrowserConfiguration` parameter in implementations (flutter/packages#5759) 2024-02-13 16229121+leiatfly@users.noreply.github.com [flutter_markdown] Use Text.rich to replace RichText in Flutter Markdown (flutter/packages#6062) 2024-02-13 97943118+GavrielRosendorn74@users.noreply.github.com [google_maps_flutter][iOS 17] takeSnapshot FIX (flutter/packages#5823) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Anas authored
Add column information as table header for `flutter emulators` command. **Before:** ``` 2 available emulators: Pixel_3_API_30 ⢠Pixel 3 API 30 ⢠Google ⢠android Resizable_API_33 ⢠Resizable API 33 ⢠Google ⢠android To run an emulator, run 'flutter emulators --launch <emulator id>'. To create a new emulator, run 'flutter emulators --create [--name xyz]'. You can find more information on managing emulators at the links below: https://developer.android.com/studio/run/managing-avds https://developer.android.com/studio/command-line/avdmanager ``` **After:** ``` 2 available emulators: Id ⢠Name ⢠Manufacturer ⢠Platform Pixel_3_API_30 ⢠Pixel 3 API 30 ⢠Google ⢠android Resizable_API_33 ⢠Resizable API 33 ⢠Google ⢠android To run an emulator, run 'flutter emulators --launch <emulator id>'. To create a new emulator, run 'flutter emulators --create [--name xyz]'. You can find more information on managing emulators at the links below: https://developer.android.com/studio/run/managing-avds https://developer.android.com/studio/command-line/avdmanager ``` fixes #140656
-
Martin Kustermann authored
* Flags to `dart compile wasm` Some options are not relevant to a standalone user of `dart compile wasm` (e.g. specyfing dart-sdk, platform file etc). => Those aren't offered by the `dart compile wasm` tool directly. => We use the `--extra-compiler-option=` instead which passes through arbitrary options to the dart2wasm compiler. => We don't maintain compatibility of those options, if we update them we'll ensure to also update flutter tools * Binaryen optimization passes This change will mean we use the binaryen flags from Dart SDK which are slightly different from the ones in flutter. * Optimization configuration This change will also start using the more standardized `-O` flag for determining optimization levels. The meaning of those flags have been mostly aligned with dart2js (with some differences remaining). * Minimization Using the new optimization flags, namely `-O4` for `--wasm-opt=full`, will automatically enable the new `--minify` support. Minification is Dart semantics preserving but changes the `<obj>.runtimeType.toString()` to use minified names (just as in dart2js). * Code size changes Overall this change will reduce wonderous code size by around 10%. Issue https://github.com/dart-lang/sdk/issues/54675
-
Jonah Williams authored
Part of https://github.com/flutter/flutter/issues/143404 We currently drop the first N frames of all benchmarks. For the app based benchmarks (not microbenchmarks) this is harmful as we miss first time initialization costs in our CI. Still need to do this with flutter/gallery, but that lives in a different repo.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/0849250a1419...3af336bfb2df 2024-02-14 jason-simmons@users.noreply.github.com In run_tests, use the regular path to the Vulkan library if lib.unstripped does not exist (flutter/engine#50629) 2024-02-14 skia-flutter-autoroll@skia.org Roll Dart SDK from a8303c0bf1b4 to 032323fa534b (1 revision) (flutter/engine#50631) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/215d55f4f82d...0849250a1419 2024-02-14 30870216+gaaclarke@users.noreply.github.com [Impeller] replaces golden file count with a golden diff file (flutter/engine#50621) 2024-02-14 bdero@google.com [Impeller] Migrate all ColorSourceContents to use a shared rendering routine. (flutter/engine#50261) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/c0607a0313a3...215d55f4f82d 2024-02-14 matanlurey@users.noreply.github.com Run Skia and Impeller OpenGLES on APIv28. (flutter/engine#50583) 2024-02-14 34871572+gmackall@users.noreply.github.com Make Android Studio depend on the android_embedding_dependencies (flutter/engine#50612) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/abb51c48e261...c0607a0313a3 2024-02-14 31859944+LongCatIsLooong@users.noreply.github.com Temporarily change canvaskit kitchensink test to unblock the skia roll (flutter/engine#50617) 2024-02-13 flar@google.com [Impeller] add benchmarks for the stroke geometry entity code (flutter/engine#50616) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/9b183870ff6c...abb51c48e261 2024-02-13 737941+loic-sharma@users.noreply.github.com [Windows] Refactor window destroyed app lifecycle event (flutter/engine#50565) 2024-02-13 jonahwilliams@google.com [Impeller] fix cmd buffer recycling bug in test. (flutter/engine#50615) 2024-02-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 04caefbfa60f to a8303c0bf1b4 (1 revision) (flutter/engine#50614) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Andrew Kolos authored
In service of https://github.com/flutter/flutter/issues/143348. **Issue.** The `equals` implementation of `AssetsEntry` is incorrect. It compares `flavors` lists using reference equality. This PR addresses this. This also adds a test to make sure valid asset `flavors` declarations are parsed correctly. While we are here, this PR also includes a couple of refactorings: * `flutter_manifest_test.dart` is a bit large. To better match our style guide, I've factored out some related tests into their own file. * A couple of changes to the `_validateListType` function in `flutter_manifest.dart`: * The function now returns a list of errors instead of accepting a list to append onto. This is more readable and also allows callers to know which errors were found by the call. * The function is renamed to `_validateList` and now accepts an `Object?` instead of an `YamlList`. If the argument is null, an appropriate error message is contained in the output. This saves callers that are only interested in validation from having to write their own null-check, which they all did before. * Some error strings were tweaked for increased readability and/or grammatical correctness.
-
- 13 Feb, 2024 2 commits
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/0091a4914dc6...9b183870ff6c 2024-02-13 30870216+gaaclarke@users.noreply.github.com [Impeller] Turn on golden tests that use the ImGui widgets functions (flutter/engine#50606) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Nate authored
fixes #87061 It doesn't matter whether I'm using Google Chrome, VS Code, Discord, or a Terminal window: any time a text cursor is blinking, it means that the characters I type will show up there. And this isn't limited to text fields: if I repeatedly press `Tab` to navigate through a website, there's a visual indicator that goes away if I click away from the window, and it comes back if I click or `Alt+Tab` back into it. <details open> <summary>Example (Chrome):</summary> ![focus node](https://github.com/flutter/flutter/assets/10457200/bef42cd9-28e5-4214-b071-b7ef56b26609) </details> <details open> <summary>This PR adds the same functionality to Flutter apps:</summary> ![Flutter demo](https://github.com/flutter/flutter/assets/10457200/6eb34c44-5fb0-4b27-aa10-6606a1eb187e) </details>
-