- 17 Feb, 2024 1 commit
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/c4fe6f01e0f5...afb270929a6c 2024-02-16 skia-flutter-autoroll@skia.org Roll Skia from 6ae5032133d0 to e4e234d412ee (1 revision) (flutter/engine#50733) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 16 Feb, 2024 24 commits
-
-
Brian Quinlan authored
https://dart-review.googlesource.com/c/sdk/+/326761/24/sdk/lib/io/stdio.dart#380 added a `lineTerminator` field to `Stdout`. Add that field to the fake in packages/test. Fixes https://github.com/flutter/flutter/issues/143614 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/2eed3fbb293a...c4fe6f01e0f5 2024-02-16 30870216+gaaclarke@users.noreply.github.com Pulled out dir contents golden tool (flutter/engine#50703) 2024-02-16 skia-flutter-autoroll@skia.org Roll Dart SDK from 21b9ee6f0a52 to fa66195a3814 (3 revisions) (flutter/engine#50732) 2024-02-16 skia-flutter-autoroll@skia.org Roll Skia from 2919d86cad12 to 6ae5032133d0 (8 revisions) (flutter/engine#50729) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
LongCatIsLooong authored
Fixes https://github.com/flutter/flutter/issues/79495 This is basically a reland of https://github.com/flutter/flutter/pull/79607. Currently when the cursor is invalid, arrow key navigation / typing / backspacing doesn't work since the cursor position is unknown. Showing the cursor when the selection is invalid gives the user the wrong information about the current insert point in the text. This is going to break internal golden tests.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/13dc857bf2ef...2eed3fbb293a 2024-02-16 jacksongardner@google.com Temporarily disable goldens for Safari. (flutter/engine#50724) 2024-02-16 kustermann@google.com [web] Remove unused `allowInterop` usage in flutter web code (flutter/engine#50718) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Michael Goderbauer authored
Work towards https://github.com/dart-lang/linter/issues/4859 There are libraries outside a `lib/` directory, which violate `implementation_imports`. Supersedes https://github.com/flutter/flutter/pull/143560.
-
Andrew Kolos authored
In service of https://github.com/flutter/flutter/issues/143348. This PR enables parsing of the pubspec yaml schemes for assets with transformations as described in #143348.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/5fd5ccf32d08...13dc857bf2ef 2024-02-16 jonahwilliams@google.com [Impeller] use fewer threads for shader bootstrap workers on low core machines. (flutter/engine#50726) 2024-02-16 goderbauer@google.com Fix implementation imports outside of lib (flutter/engine#50727) 2024-02-16 skia-flutter-autoroll@skia.org Roll Skia from 87e8e9c8f42b to 2919d86cad12 (8 revisions) (flutter/engine#50723) 2024-02-16 skia-flutter-autoroll@skia.org Roll Dart SDK from 947c8c487e28 to 21b9ee6f0a52 (2 revisions) (flutter/engine#50717) 2024-02-16 skia-flutter-autoroll@skia.org Roll Skia from c89a4cd72308 to 87e8e9c8f42b (3 revisions) (flutter/engine#50716) 2024-02-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from fXqP_YC4zTp9G2hA5... to YN5KCfom7Ax0Z69s_... (flutter/engine#50719) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from fXqP_YC4zTp9 to YN5KCfom7Ax0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Michael Goderbauer authored
Fixes https://github.com/flutter/flutter/issues/143405. It was counter-intuitive that a SemanticsFinder without specifying a FlutterView would only search the nodes in the default view. This change makes it so that when no view is specified the semantics trees of all known FlutterViews are searched.
-
Andrew Kolos authored
Fixes https://github.com/flutter/flutter/issues/143513 Should be cherry-picked to beta.
-
Tirth authored
Added Missing Field Name in Doc Comment in SnackBarThemeData.
-
Nate authored
This PR is the 8áµÊ° step in the journey to solve issue #136139 and make the entire Flutter repo more readable. (previous pull requests: #139048, #139882, #141591, #142279, #142634, #142793, #143293) I did a pass through all of `packages/flutter/lib/src/` and found a whole bunch of `switch` statements to improve: most of them were really simple, but many involved some thorough refactoring. This pull request is just the complicated stuff. ð I'll make comments to describe the changes, and then in the future there will be another PR (and it'll be much easier to review than this one).
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/dd530f1556df...5fd5ccf32d08 2024-02-16 jason-simmons@users.noreply.github.com Use the Pixel 7/API 33 device in the Firebase test lab script (flutter/engine#50721) 2024-02-16 leroux_bruno@yahoo.fr [Web] Ignore invalid keyboard events related to autofill (flutter/engine#50590) 2024-02-16 jason-simmons@users.noreply.github.com Add the web package to the set of Dart third_party packages in DEPS (flutter/engine#50714) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/ef349bec8ee9...c56c12dd51ef 2024-02-16 10687576+bparrishMines@users.noreply.github.com [tool] Add support for using a Kotlin test runner file (flutter/packages#6131) 2024-02-16 louisehsu@google.com [in_app_purchase] fix skerror nullability (flutter/packages#6139) 2024-02-15 jacksongardner@google.com Explicitly pass the web renderer into the tests. (flutter/packages#6140) 2024-02-15 stuartmorgan@google.com [google_sign_in] Clean up pre-Pigeon code (flutter/packages#6141) 2024-02-15 stuartmorgan@google.com [local_auth] Add compatibility with latest `intl` (flutter/packages#6138) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Taha Tesser authored
fixes [Calling `setState` in a `MaterialStatesController` listener and `MaterialStateController.update` causes Exception](https://github.com/flutter/flutter/issues/138986) ### Description `MaterialStatesController` listener calls `setState` during build when `MaterialStatesController.update` listener calls `notifyListeners`. I tried fixing this issue by putting `notifyListeners` in a post-frame callback. However, this breaks existing customer tests (particularly super editor tests). A safer approach would be to document that the listener's `setState` call should be in a post-frame callback to delay it and not call this during the build phase triggered by the `MaterialStatesController.update` in the widgets such as InkWell or buttons.
-
Taha Tesser authored
fixes [[`DataTable`] Data row does not respond to `MaterialState.hovered`](https://github.com/flutter/flutter/issues/138968)
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/b7103bc8b374...dd530f1556df 2024-02-16 skia-flutter-autoroll@skia.org Roll Dart SDK from 9bbac4d40725 to 947c8c487e28 (1 revision) (flutter/engine#50709) 2024-02-16 skia-flutter-autoroll@skia.org Roll Skia from 3cbb5d6a71fe to c89a4cd72308 (2 revisions) (flutter/engine#50708) 2024-02-16 737941+loic-sharma@users.noreply.github.com [Windows] Improve `FlutterWindow` unit tests (flutter/engine#50676) 2024-02-16 zanderso@users.noreply.github.com [et] Adds a logger (flutter/engine#50693) 2024-02-15 matanlurey@users.noreply.github.com Update README.md (flutter/engine#50702) 2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 078b316e0563 to 3cbb5d6a71fe (2 revisions) (flutter/engine#50704) 2024-02-15 tugorez@users.noreply.github.com Move the accesibility placeholder to the platform dispatcher. (flutter/engine#50608) 2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from a8e4db1afac5 to 078b316e0563 (4 revisions) (flutter/engine#50700) 2024-02-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 5e442dc80903 to 9bbac4d40725 (2 revisions) (flutter/engine#50699) 2024-02-15 26625149+0xZOne@users.noreply.github.com [Android] Remove the unnecessary parent interface. (flutter/engine#50677) 2024-02-15 bdero@google.com [Impeller] Add an error message when failing to write golden screenshot. (flutter/engine#50698) 2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 6ee2b5f61ae5 to a8e4db1afac5 (5 revisions) (flutter/engine#50696) 2024-02-15 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Run arm64 tests on terminal.qemu-arm64 on x64 hosts (flutter/engine#50657) 2024-02-15 30870216+gaaclarke@users.noreply.github.com [Impeller] Updated benchmarks (flutter/engine#50694) 2024-02-15 godofredoc@google.com Documentation for test timeouts. (flutter/engine#50687) 2024-02-15 zanderso@users.noreply.github.com Shift some Linux builders from Goma to RBE (flutter/engine#50653) 2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 12d0b7fac4c3 to 6ee2b5f61ae5 (1 revision) (flutter/engine#50691) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Jason Simmons authored
2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from a8e4db1afac5 to 078b316e0563 (4 revisions) (flutter/engine#50700) 2024-02-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 5e442dc80903 to 9bbac4d40725 (2 revisions) (flutter/engine#50699) 2024-02-15 26625149+0xZOne@users.noreply.github.com [Android] Remove the unnecessary parent interface. (flutter/engine#50677) 2024-02-15 bdero@google.com [Impeller] Add an error message when failing to write golden screenshot. (flutter/engine#50698) 2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 6ee2b5f61ae5 to a8e4db1afac5 (5 revisions) (flutter/engine#50696) 2024-02-15 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Run arm64 tests on terminal.qemu-arm64 on x64 hosts (flutter/engine#50657) 2024-02-15 30870216+gaaclarke@users.noreply.github.com [Impeller] Updated benchmarks (flutter/engine#50694) 2024-02-15 godofredoc@google.com Documentation for test timeouts. (flutter/engine#50687) 2024-02-15 zanderso@users.noreply.github.com Shift some Linux builders from Goma to RBE (flutter/engine#50653) 2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 12d0b7fac4c3 to 6ee2b5f61ae5 (1 revision) (flutter/engine#50691)
-
Jason Simmons authored
2024-02-15 30870216+gaaclarke@users.noreply.github.com Added tool to easily check golden diffs locally. (flutter/engine#50654) 2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 4bbf2060b008 to 12d0b7fac4c3 (2 revisions) (flutter/engine#50689) 2024-02-15 johnoneil@users.noreply.github.com Provide a matrix inverse shim for GLES 2.0. (flutter/engine#50545) 2024-02-15 jonahwilliams@google.com [iOS] Ensure FlutterMetalLayer has correct backpressure. (flutter/engine#50486) 2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 682f0e1e7e77 to 4bbf2060b008 (3 revisions) (flutter/engine#50686) 2024-02-15 103135467+sealesj@users.noreply.github.com Pin OSV-Scanner reusable workflow (flutter/engine#50649) 2024-02-15 whesse@google.com Add support for dart_src GN variable to flutter_frontend_server build (flutter/engine#50685) 2024-02-15 6718144+renancaraujo@users.noreply.github.com fix: consider array size on canvaskit shader data (flutter/engine#49754) 2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 1277910beec9 to 682f0e1e7e77 (1 revision) (flutter/engine#50683) 2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 85ab600a9519 to 1277910beec9 (2 revisions) (flutter/engine#50682)
-
Jason Simmons authored
2024-02-15 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from mZP8LxbhYHstUxmxd... to fXqP_YC4zTp9G2hA5... (flutter/engine#50680) 2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from b6201d9c2f73 to 85ab600a9519 (1 revision) (flutter/engine#50679) 2024-02-15 skia-flutter-autoroll@skia.org Roll Dart SDK from f1b1fa85a1be to 5e442dc80903 (1 revision) (flutter/engine#50678) 2024-02-15 chinmaygarde@google.com Use a GN variable (dart_src) to reference the location of the Dart checkout. (flutter/engine#50624) 2024-02-15 matanlurey@users.noreply.github.com Add a &right_filter=params to the Skia Gold links. (flutter/engine#50675) 2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 2d5cf67614d0 to b6201d9c2f73 (2 revisions) (flutter/engine#50674) 2024-02-15 matanlurey@users.noreply.github.com Disable Android API v28 tests on CI. (flutter/engine#50672) 2024-02-15 matanlurey@users.noreply.github.com Use modern concurrency constructs. (flutter/engine#50671) 2024-02-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 322e34dc53f6 to f1b1fa85a1be (1 revision) (flutter/engine#50670) 2024-02-15 matanlurey@users.noreply.github.com Move boringssl to flutter/third_party. (flutter/engine#50601)
-
Jason Simmons authored
2024-02-15 26625149+0xZOne@users.noreply.github.com [Android] Minor refactor: Remove redundant methods. (flutter/engine#50647) 2024-02-15 flar@google.com [Impeller] consolidate transforms in PositionUVWriter (flutter/engine#50635) 2024-02-15 ditman@gmail.com [web] Add dynamic view sizing (v2) (flutter/engine#50271) 2024-02-14 matanlurey@users.noreply.github.com Add useful default options to scenario_app/bin/android_integration_tests.dart (flutter/engine#50667) 2024-02-14 34871572+gmackall@users.noreply.github.com Fix github md "Note" and "Tip" blocks in Android shell README (flutter/engine#50664) 2024-02-14 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Run run_with_dart_aot test on fuchsia_profile_x64 (flutter/engine#50613) 2024-02-14 matanlurey@users.noreply.github.com Make all Android scenario_app activities full-screen, even on older Android versions. (flutter/engine#50666) 2024-02-14 skia-flutter-autoroll@skia.org Roll Skia from eae42ea9f7bc to 2d5cf67614d0 (6 revisions) (flutter/engine#50660) 2024-02-14 matanlurey@users.noreply.github.com Add a comment explaining the lifecycle of tls_command_pool_map. (flutter/engine#50623) 2024-02-14 mdebbar@google.com [web] Increase tolerance for golden diffs on Safari (flutter/engine#50655)
-
Jason Simmons authored
Run engine_tool tests (flutter/engine#50662) Refactor, update, and move around `testing/scenario_app/README.md` (flutter/engine#50659) Starts a command line tool for assisting engine dev workflows (flutter/engine#50642) macOS: add stubs for PlatformView gesture handling (flutter/engine#50630) [Impeller] Conditionally use A8 or R8 format glyph atlas based on capabilities. (flutter/engine#50534) Roll Dart SDK from e7cfba13d375 to 322e34dc53f6 (1 revision) (flutter/engine#50651) Roll Skia from 4235c0421a48 to eae42ea9f7bc (2 revisions) (flutter/engine#50650) Roll Skia from ea2fd25220cb to 4235c0421a48 (1 revision) (flutter/engine#50648) Roll Dart SDK from 9982d96cebb0 to e7cfba13d375 (1 revision) (flutter/engine#50646) Roll Skia from 1e6e2114f15e to ea2fd25220cb (1 revision) (flutter/engine#50643) Roll Dart SDK from 032323fa534b to 9982d96cebb0 (1 revision) (flutter/engine#50644) Roll Skia from 2aec75cda46e to 1e6e2114f15e (2 revisions) (flutter/engine#50641) Roll Skia from b8acfa559db0 to 2aec75cda46e (1 revision) (flutter/engine#50639) Roll Fuchsia Linux SDK from l6mWjvlO1xJg5ZFKK... to mZP8LxbhYHstUxmxd... (flutter/engine#50638) Roll Skia from 79ec267090bd to b8acfa559db0 (1 revision) (flutter/engine#50636) Roll Skia from d650dcaf4b49 to 79ec267090bd (1 revision) (flutter/engine#50634)
-
Jonah Williams authored
Capture first frames in gallery benchmarks Calling https://github.com/flutter/flutter/issues/143404 fixed, since all the full app benchmarks capture the start now. Fixes https://github.com/flutter/flutter/issues/143404
-
Martin Kustermann authored
Update: Accidentally use `--O4` instead of `-O4` in `dev/devicelab/lib/tasks/web_benchmarks.dart` update. Original description: * Make `flutter build web` have one option that determins the optimization level: `-O<level>` / `--optimization-level=<level>` => Defaulting to -O4 => Will apply to both dart2js and dart2wasm * Deprecate `--dart2js-optimization=O<level>` * Disentagle concept of optimization from concept of static symbols => Add a `--strip-wasm` / `--no-strip-wasm` flag that determins whether static symbols are kept in the resulting wasm file. * Remove copy&past'ed code in the tests for wasm build tests * Cleanup some artifacts code, now that we no longer use `wasm-opt` inside flutter tools
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/3af336bfb2df...15a358bbaf71 2024-02-14 skia-flutter-autoroll@skia.org Roll Skia from f7e3a5395fe1 to d650dcaf4b49 (8 revisions) (flutter/engine#50632) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 15 Feb, 2024 15 commits
-
-
Bartek Pacia authored
This PR will make it easier for future Flutter-Android apps/plugins/modules etc. to migrate to Gradle Kotlin DSL. This PR is similar to #140452 but concerns public Gradle templates instead of Flutter's internal Gradle code. It should be a no-op change. **before** ![before](https://github.com/flutter/flutter/assets/40357511/5d0cb2bb-a693-43bc-aa10-b8f431e0c68c) **after** ![after](https://github.com/flutter/flutter/assets/40357511/e4a945a5-866f-42f7-813b-b08b26bb89dc)
-
godofredoc authored
The Windows arm64 builds were all moved to bringup because new test beds not properly provisioned were added to the production pool. Those new test beds are now fully validated but still running on staging pool to ensure they are not introducing noise in the prod pools. Bug: https://github.com/flutter/flutter/issues/143180
-
Jake authored
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
-
Jonah Williams authored
This is the next step in archiving flutter/gallery - move devicelab tests to use the local copy.
-
dependabot[bot] authored
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.24.1 to 3.24.3. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p> <blockquote> <h1>CodeQL Action Changelog</h1> <p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p> <p>Note that the only difference between <code>v2</code> and <code>v3</code> of the CodeQL Action is the node version they support, with <code>v3</code> running on node 20 while we continue to release <code>v2</code> to support running on node 16. For example <code>3.22.11</code> was the first <code>v3</code> release and is functionally identical to <code>2.22.11</code>. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers.</p> <h2>[UNRELEASED]</h2> <p>No user facing changes.</p> <h2>3.24.3 - 15 Feb 2024</h2> <ul> <li>Fix an issue where the CodeQL Action would fail to load a configuration specified by the <code>config</code> input to the <code>init</code> Action. <a href="https://redirect.github.com/github/codeql-action/pull/2147">#2147</a></li> </ul> <h2>3.24.2 - 15 Feb 2024</h2> <ul> <li>Enable improved multi-threaded performance on larger runners for GitHub Enterprise Server users. This feature is already available to GitHub.com users. <a href="https://redirect.github.com/github/codeql-action/pull/2141">#2141</a></li> </ul> <h2>3.24.1 - 13 Feb 2024</h2> <ul> <li>Update default CodeQL bundle version to 2.16.2. <a href="https://redirect.github.com/github/codeql-action/pull/2124">#2124</a></li> <li>The CodeQL action no longer fails if it can't write to the telemetry api endpoint. <a href="https://redirect.github.com/github/codeql-action/pull/2121">#2121</a></li> </ul> <h2>3.24.0 - 02 Feb 2024</h2> <ul> <li>CodeQL Python analysis will no longer install dependencies on GitHub Enterprise Server, as is already the case for GitHub.com. See <a href="https://github.com/github/codeql-action/blob/main/#3230---08-jan-2024">release notes for 3.23.0</a> for more details. <a href="https://redirect.github.com/github/codeql-action/pull/2106">#2106</a></li> </ul> <h2>3.23.2 - 26 Jan 2024</h2> <ul> <li>On Linux, the maximum possible value for the <code>--threads</code> option now respects the CPU count as specified in <code>cgroup</code> files to more accurately reflect the number of available cores when running in containers. <a href="https://redirect.github.com/github/codeql-action/pull/2083">#2083</a></li> <li>Update default CodeQL bundle version to 2.16.1. <a href="https://redirect.github.com/github/codeql-action/pull/2096">#2096</a></li> </ul> <h2>3.23.1 - 17 Jan 2024</h2> <ul> <li>Update default CodeQL bundle version to 2.16.0. <a href="https://redirect.github.com/github/codeql-action/pull/2073">#2073</a></li> <li>Change the retention period for uploaded debug artifacts to 7 days. Previously, this was whatever the repository default was. <a href="https://redirect.github.com/github/codeql-action/pull/2079">#2079</a></li> </ul> <h2>3.23.0 - 08 Jan 2024</h2> <ul> <li>We are rolling out a feature in January 2024 that will disable Python dependency installation by default for all users. This improves the speed of analysis while having only a very minor impact on results. You can override this behavior by setting <code>CODEQL_ACTION_DISABLE_PYTHON_DEPENDENCY_INSTALLATION=false</code> in your workflow, however we plan to remove this ability in future versions of the CodeQL Action. <a href="https://redirect.github.com/github/codeql-action/pull/2031">#2031</a></li> <li>The CodeQL Action now requires CodeQL version 2.11.6 or later. For more information, see <a href="https://github.com/github/codeql-action/blob/main/#2227---16-nov-2023">the corresponding changelog entry for CodeQL Action version 2.22.7</a>. <a href="https://redirect.github.com/github/codeql-action/pull/2009">#2009</a></li> </ul> <h2>3.22.12 - 22 Dec 2023</h2> <ul> <li>Update default CodeQL bundle version to 2.15.5. <a href="https://redirect.github.com/github/codeql-action/pull/2047">#2047</a></li> </ul> <h2>3.22.11 - 13 Dec 2023</h2> <ul> <li>[v3+ only] The CodeQL Action now runs on Node.js v20. <a href="https://redirect.github.com/github/codeql-action/pull/2006">#2006</a></li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/github/codeql-action/commit/379614612a29c9e28f31f39a59013eb8012a51f0"><code>3796146</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2148">#2148</a> from github/update-v3.24.3-3a7796d6a</li> <li><a href="https://github.com/github/codeql-action/commit/01d302a04eea70ce81e7926c05c80a4dd30f9d2c"><code>01d302a</code></a> Update changelog for v3.24.3</li> <li><a href="https://github.com/github/codeql-action/commit/3a7796d6ad0e2a3b9d7480095a365f27bc6452d1"><code>3a7796d</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2147">#2147</a> from github/henrymercer/fix-config-outside-workspace...</li> <li><a href="https://github.com/github/codeql-action/commit/56b93f29ebc6b37e35f050c9ed056fbe82c78060"><code>56b93f2</code></a> Add changelog note</li> <li><a href="https://github.com/github/codeql-action/commit/381e65f460073fc12b3dac08ba3f62b2b2e7ba46"><code>381e65f</code></a> Allow generated user config file to be outside the workspace</li> <li><a href="https://github.com/github/codeql-action/commit/d88d538126113b4fe52fe9ba17f9dc19ba505d12"><code>d88d538</code></a> Add PR check for specifying configuration using the <code>config</code> input</li> <li><a href="https://github.com/github/codeql-action/commit/dc983b33c32da66f1acc44a1d5ed69d94e9ffb64"><code>dc983b3</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2143">#2143</a> from github/mergeback/v3.24.2-to-main-ece8414c</li> <li><a href="https://github.com/github/codeql-action/commit/66a4732f1d8a89e7232232a4bdd1a4d16ee73eb5"><code>66a4732</code></a> Update checked-in dependencies</li> <li><a href="https://github.com/github/codeql-action/commit/e62fb8e891989ac0311b4082acf0b45cac614f2a"><code>e62fb8e</code></a> Update changelog and version after v3.24.2</li> <li><a href="https://github.com/github/codeql-action/commit/ece8414c725e29de2e18c0859fda9e7280df9488"><code>ece8414</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2142">#2142</a> from github/update-v3.24.2-1a41e5519</li> <li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/e675ced7a7522a761fc9c8eb26682c8b27c42b2b...379614612a29c9e28f31f39a59013eb8012a51f0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=3.24.1&new-version=3.24.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
-
Danny Tuppeny authored
Builds can be slow and the legacy debug adapter would handle Flutter's `app.progress` events to update the toast notification during builds. This was lost in the new adapters - we should only a single "Launching.." notification for the whole progress. This change listens to `app.progress` events and forwards those with `finished=false` to the client if the launch progress is still active. Fixes https://github.com/Dart-Code/Dart-Code/issues/4938 https://github.com/flutter/flutter/assets/1078012/8c60cf08-e034-4a72-b31e-9c61dca388bf
-
Matan Lurey authored
Closes https://github.com/flutter/flutter/issues/142178.
-
auto-submit[bot] authored
Reverts flutter/flutter#143517 Initiated by: dnfield Reason for reverting: broke CI, see https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_benchmarks_skwasm/3446/overview Original PR Author: mkustermann Reviewed By: {eyebrowsoffire} This change reverts the following previous change: Original Description: * Make `flutter build web` have one option that determins the optimization level: `-O<level>` / `--optimization-level=<level>` => Defaulting to -O4 => Will apply to both dart2js and dart2wasm * Deprecate `--dart2js-optimization=O<level>` * Disentagle concept of optimization from concept of static symbols => Add a `--strip-wasm` / `--no-strip-wasm` flag that determins whether static symbols are kept in the resulting wasm file. * Remove copy&past'ed code in the tests for wasm build tests * Cleanup some artifacts code, now that we no longer use `wasm-opt` inside flutter tools
-
Kate Lovett authored
Relands https://github.com/flutter/flutter/pull/143386 Which was reverted in https://github.com/flutter/flutter/pull/143523 Fixes https://github.com/flutter/flutter/issues/143173 Unblocks https://github.com/flutter/flutter/pull/143485 â â¡ï¸ Update from the revert is in this commit: https://github.com/flutter/flutter/pull/143527/commits/1e6853291eba42ee7005f284265118be33c99673
-
Martin Kustermann authored
* Make `flutter build web` have one option that determins the optimization level: `-O<level>` / `--optimization-level=<level>` => Defaulting to -O4 => Will apply to both dart2js and dart2wasm * Deprecate `--dart2js-optimization=O<level>` * Disentagle concept of optimization from concept of static symbols => Add a `--strip-wasm` / `--no-strip-wasm` flag that determins whether static symbols are kept in the resulting wasm file. * Remove copy&past'ed code in the tests for wasm build tests * Cleanup some artifacts code, now that we no longer use `wasm-opt` inside flutter tools
-
Jonah Williams authored
Fixes https://github.com/flutter/flutter/issues/143482 This brings in the gallery more or less as is: * Removed localizations * Ensure tests still run (locally verified, will switch CI later). * Removed deferred components * Fixup pubspec
-
godofredoc authored
The dependency was added as temporary workaround and was never removed. Bug: https://github.com/flutter/flutter/issues/143489 Bug: https://github.com/flutter/flutter/issues/143490
-
auto-submit[bot] authored
Reverts flutter/flutter#143386 Initiated by: Piinks Reason for reverting: This broke a customer test. Original PR Author: Piinks Reviewed By: {goderbauer} This change reverts the following previous change: Original Description: Fixes https://github.com/flutter/flutter/issues/143173 The `start` and `end` parameters of `SemanticsController.simulatedAccessibilityTraversal` were deprecated in https://github.com/flutter/flutter/issues/112413, but no tests were added that verified the new API.
😳 This change - fixes a typo in an error message - fixes the new `startNode` and `endNode` not being accounted for in setting the traversal range - adds dart fixes for the deprecations - adds tests for the new API that is meant to replace the deprecated one. - Filed https://github.com/flutter/flutter/issues/143405 to follow up on the new API not working in multiple views. -
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/a8642544730a...ef349bec8ee9 2024-02-15 stuartmorgan@google.com [url_launcher] Replace deprecated RouteInformation APIs (flutter/packages#6127) 2024-02-15 stuartmorgan@google.com [rfw] Replace deprecated `textScaleFactor` (flutter/packages#6130) 2024-02-15 stuartmorgan@google.com [flutter_adaptive_scaffold] Replace deprecated APIs (flutter/packages#6129) 2024-02-14 engine-flutter-autoroll@skia.org Roll Flutter from eb5d0a43 to a628814e (72 revisions) (flutter/packages#6118) 2024-02-14 stuartmorgan@google.com [flutter_migrate] Replace deprecated APIs (flutter/packages#6128) 2024-02-14 stuartmorgan@google.com [flutter_image] Replace deprecated APIs (flutter/packages#6126) 2024-02-14 stuartmorgan@google.com [tools] Ignore analysis options files in .symlinks (flutter/packages#6119) 2024-02-14 stuartmorgan@google.com [various] Clean up `deprecated_member_use` ignores (flutter/packages#6123) 2024-02-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.0 to 3.24.1 (flutter/packages#6121) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Hossein Yousefi authored
* Use `dart run` instead of `flutter pub run` in the documentation as it is now deprecated. * Use `int64_t` instead of `intptr_t` for `sum` examples.
-