- 29 Jun, 2023 12 commits
-
-
Ricardo Amador authored
Remove use of any. This reverts to a previous change. Without any and the newest version this put us back to before the version change. Restores to this change: https://github.com/flutter/flutter/commit/2be476d4015db8f6c442eefa3e9a897975407d4c Apparently any is the cause. I will make a separate issue to track updating of the labeler documentation. *List which issues are fixed by this PR. You must list at least one issue.* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
-
Martin Kustermann authored
To avoid analyzer warnings when utf8.encode() will return the more precise Uint8List type, we use const Utf8Encoder().convert() which already returns Uint8List See https://github.com/dart-lang/sdk/issues/52801
-
lsaudon authored
Some files are supposed to ignore, but don't. - **/windows/flutter/generated_plugins.cmake - **/linux/flutter/generated_plugin_registrant.cc - **/linux/flutter/generated_plugin_registrant.h - **/linux/flutter/generated_plugins.cmake - **/windows/flutter/generated_plugin_registrant.cc - **/windows/flutter/generated_plugin_registrant.h - **/ios/Runner/GeneratedPluginRegistrant.h - **/ios/Runner/GeneratedPluginRegistrant.m *List which issues are fixed by this PR. You must list at least one issue.* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
-
Christopher Fujino authored
Fixes https://github.com/flutter/flutter/issues/129782 Linux flutter_plugins is currently broken https://ci.chromium.org/p/flutter/builders/prod/Linux%20flutter_plugins/12884 On an analysis error that was ignored upstream in https://github.com/flutter/packages/commit/5d6e48c3e099fa6c24f45b778f5b7cab82a7e1e8
-
Tae Hyung Kim authored
Based on the [message format syntax](https://unicode-org.github.io/icu/userguide/format_parse/messages/#examples) for [ICU4J](https://unicode-org.github.io/icu-docs/apidoc/released/icu4j/com/ibm/icu/text/MessageFormat.html). This adds new syntax to the current Flutter messageFormat parser which should allow developers to add locale-specific date formatting. ## Usage example ``` "datetimeTest": "Today is {today, date, ::yMd}", "@datetimeTest": { "placeholders": { "today": { "description": "The date placeholder", "type": "DateTime" } } } ``` compiles to ``` String datetimeTest(DateTime today) { String _temp0 = intl.DateFormat.yMd(localeName).format(today); return 'Today is $_temp0'; } ``` Fixes https://github.com/flutter/flutter/issues/127304.
-
Taha Tesser authored
This updates the `RadioListTile` test which was modified in https://github.com/flutter/flutter/pull/128839 ### Description - Update the layout to the proper order `MaterialApp` -> `Material` -> `RadioListTile` - Add M3 overlay test. (fixed problem faced in https://github.com/flutter/flutter/pull/128839) - Separate the M2 overlay test.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/7fd0e9522ea1...eabb22900b44 2023-06-29 skia-flutter-autoroll@skia.org Roll Skia from 21feae4f3d8b to 2b30565d0173 (1 revision) (flutter/engine#43330) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/d5c25ead07e9...7fd0e9522ea1 2023-06-29 skia-flutter-autoroll@skia.org Roll Skia from 26fa4b343fd3 to 21feae4f3d8b (17 revisions) (flutter/engine#43329) 2023-06-29 skia-flutter-autoroll@skia.org Roll Dart SDK from a7151d73b88d to 656201921b30 (1 revision) (flutter/engine#43328) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Jia Tan authored
Fix typos. *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/4e49b9deb72d...d5c25ead07e9 2023-06-29 jason-simmons@users.noreply.github.com [Impeller] Add a missing method to the Context mock (flutter/engine#43326) 2023-06-29 30870216+gaaclarke@users.noreply.github.com [Impeller] Collapse DrawRects into clear colors optimization (flutter/engine#43168) 2023-06-29 chinmaygarde@google.com [Impeller] Add trace events to Vulkan texture and buffer lifecycle events. (flutter/engine#43321) 2023-06-29 skia-flutter-autoroll@skia.org Roll Dart SDK from 5a59cd06e49d to a7151d73b88d (2 revisions) (flutter/engine#43318) 2023-06-28 bdero@google.com [Impeller] Fix advanced CPU blend modes (flutter/engine#43294) 2023-06-28 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 10hNrVMjnCypybnz2... to fxCNy4QivAngZXkvM... (flutter/engine#43314) 2023-06-28 skia-flutter-autoroll@skia.org Roll Skia from 0b4f472a8c44 to 26fa4b343fd3 (2 revisions) (flutter/engine#43306) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 10hNrVMjnCyp to fxCNy4QivAng If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/241ca5c1d6be...4e49b9deb72d 2023-06-28 jonahwilliams@google.com [Impeller] remove redundant highp modifiers in vertex shaders. (flutter/engine#43305) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Jackson Gardner authored
This enables benchmarks for the Skwasm renderer, compiled with dart2wasm. Platform views aren't supported in Skwasm yet, so we are skipping those benchmarks for now.
-
- 28 Jun, 2023 18 commits
-
-
Justin McCandless authored
Fixes InputDecoration (TextField) layout when 1. RTL 2. prefixIcon and 3. left/right contentPadding is asymmetric.
-
Christopher Fujino authored
Unblock tree while I investigate: https://github.com/flutter/flutter/issues/129744
-
Flutter GitHub Bot authored
This PR was generated by `flutter update-packages --force-upgrade`.
-
pdblasi-google authored
Removes deprecated APIs from AnimationBuilder. Resolves #129653
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/e8a1c23d66ba...241ca5c1d6be 2023-06-28 skia-flutter-autoroll@skia.org Roll Skia from 5209dc7702d0 to 0b4f472a8c44 (58 revisions) (flutter/engine#43304) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Parker Lougheed authored
Contributes to https://github.com/dart-lang/linter/issues/4460 and https://github.com/dart-lang/site-www/issues/4499
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/be1073aa352f...e8a1c23d66ba 2023-06-28 skia-flutter-autoroll@skia.org Roll Dart SDK from e164fdc1a3ad to 5a59cd06e49d (1 revision) (flutter/engine#43302) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Hans Muller authored
Updated tests in dev, examples/api, and tests/widgets to ensure that they continue to pass when the default for `ThemeData.useMaterial3` is changed to true. This is the final set of changes required for https://github.com/flutter/flutter/issues/127064.
-
Taha Tesser authored
-
Jonah Williams authored
This was missing the actual opacity rendering, oops
-
Bruno Leroux authored
## Description This PR is a fork of https://github.com/flutter/flutter/pull/118610 with some changes (mainly applying @justinmc comments). ~~This can be used by KishanBusa8 to update https://github.com/flutter/flutter/pull/118610 or can become a non WIP PR if KishanBusa8 does not respond or can not work on the update.~~ ## Related Issue fixes https://github.com/flutter/flutter/issues/11068 ## Tests Adds 3 tests.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/b388e852be44...be1073aa352f 2023-06-28 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from sBFKkha8HNLZpTNwv... to cytps4RRhs8-wbcVJ... (flutter/engine#43300) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from sBFKkha8HNLZ to cytps4RRhs8- If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/17173994a8c2...b388e852be44 2023-06-28 skia-flutter-autoroll@skia.org Roll Dart SDK from 3233ec5b6862 to e164fdc1a3ad (1 revision) (flutter/engine#43299) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Xilai Zhang authored
[flutter roll] Revert "Fix `AnimatedList` & `AnimatedGrid` doesn't apply `MediaQuery` padding" (#129645) Reverts flutter/flutter#129556. Context: b/288993600 quoting, "the failure (in internal tests) appears to be due to a workaround for the issue fixed by this pr".
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/2f4fc4872699...17173994a8c2 2023-06-28 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Bvv7TyHm_VHUkndFx... to 10hNrVMjnCypybnz2... (flutter/engine#43297) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from Bvv7TyHm_VHU to 10hNrVMjnCyp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/a6d9d12c440f...2f4fc4872699 2023-06-28 skia-flutter-autoroll@skia.org Roll Dart SDK from abfa59f66c42 to 3233ec5b6862 (2 revisions) (flutter/engine#43296) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/25a5850f8b5b...a6d9d12c440f 2023-06-28 jason-simmons@users.noreply.github.com Include the SkRTreeFactory headers in the skwasm picture recorder (flutter/engine#43292) 2023-06-28 skia-flutter-autoroll@skia.org Roll Dart SDK from 7a233f843402 to abfa59f66c42 (3 revisions) (flutter/engine#43291) 2023-06-27 bdero@google.com [Impeller] Correct advanced blending behavior. (flutter/engine#43283) 2023-06-27 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 81cdbe69a16b to 7a233f843402 (4 revisions) (flutter/engine#43288) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/7c7c45d53bec...25a5850f8b5b 2023-06-27 58529443+srujzs@users.noreply.github.com Revert "Refactor JSNumber.toDart and Object.toJS" (flutter/engine#43286) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 27 Jun, 2023 10 commits
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/f320b8c36fee...7c7c45d53bec 2023-06-27 flar@google.com Update skia includes to be more specific (flutter/engine#43284) 2023-06-27 yjbanov@google.com [web:a11y] introduce primary role responsible for ARIA roles (flutter/engine#43159) 2023-06-27 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from ytzCCSvHY1lHWEDM9... to sBFKkha8HNLZpTNwv... (flutter/engine#43277) 2023-06-27 skia-flutter-autoroll@skia.org Roll ANGLE from 9faf7059f9ef to 113f847be69f (2 revisions) (flutter/engine#43278) 2023-06-27 jacksongardner@google.com Initialize skwasm codecs before handing them back to the user. (flutter/engine#43274) 2023-06-27 skia-flutter-autoroll@skia.org Roll ANGLE from 02292814a9d3 to 9faf7059f9ef (7 revisions) (flutter/engine#43272) 2023-06-27 15619084+vashworth@users.noreply.github.com Update Xcode to 14.3.1 (flutter/engine#42930) 2023-06-27 jonahwilliams@google.com [Impeller] Add Vulkan allocator traces. (flutter/engine#43215) 2023-06-27 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from bj_X2Se1zObk_l_CC... to Bvv7TyHm_VHUkndFx... (flutter/engine#43270) 2023-06-27 chinmaygarde@google.com [Impeller] Report pipeline creation feedback to logs and traces. (flutter/engine#43227) 2023-06-27 jonahwilliams@google.com [Impeller] Give Impeller a dedicated raster priority level worker loop. (flutter/engine#43166) 2023-06-27 jason-simmons@users.noreply.github.com [Impeller] Fixes for GLES color mask setup (flutter/engine#43225) 2023-06-27 skia-flutter-autoroll@skia.org Roll ANGLE from cba77bceb26c to 02292814a9d3 (1 revision) (flutter/engine#43224) 2023-06-27 skia-flutter-autoroll@skia.org Roll Skia from 370132bcadb1 to 5209dc7702d0 (1 revision) (flutter/engine#43223) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from bj_X2Se1zObk to Bvv7TyHm_VHU fuchsia/sdk/core/mac-amd64 from ytzCCSvHY1lH to sBFKkha8HNLZ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Ricardo Amador authored
Update the labeler yaml to correct syntax and whitespace. *List which issues are fixed by this PR. You must list at least one issue.* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
-
Ricardo Amador authored
Reverts flutter/flutter#129670
-
Ricardo Amador authored
Reverts flutter/flutter#129672
-
Ricardo Amador authored
Reverts flutter/flutter#129617
-
Ricardo Amador authored
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* *List which issues are fixed by this PR. You must list at least one issue.* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
-
Ricardo Amador authored
Something reformatted the labeler file and removed the any formatter conditions on the label matchers. *List which issues are fixed by this PR. You must list at least one issue.* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
-
Loïc Sharma authored
https://github.com/flutter/flutter/pull/122446 was a breaking change in Flutter 3.10 that made the `ClipboardData` constructor's `text` argument a required non-nullable argument. This leverages `dart fix`'s new automatic migration to, well, automatically migrate affected users. Manual migration docs: https://docs.flutter.dev/release/breaking-changes/clipboard-data-required Follow-up to https://github.com/flutter/flutter/pull/122446 Part of https://github.com/flutter/flutter/issues/121976
-
Tomasz Gucio authored
-
Ben Konyi authored
Reland "Fix issue where DevTools would not be immediately available when using --start-paused (#126698)" (#129368) **Original Description:** > Service extensions are unable to handle requests when the isolate they were registered on is paused. The DevTools launcher logic was waiting for some service extension invocations to complete before advertising the already active DevTools instance, but when --start-paused was provided these requests would never complete, preventing users from using DevTools to resume the paused isolate. > > Fixes https://github.com/flutter/flutter/issues/126691 **Additional changes in this PR:** The failures listed in https://github.com/flutter/flutter/pull/128117 appear to be related to a shutdown race. It's possible for the test to complete while the tool is in the process of starting and advertising DevTools, so we need to perform a check of `_shutdown` in `FlutterResidentDevtoolsHandler` before advertising DevTools. Before the original fix, this check was being performed immediately after invoking the service extensions, which creates an asynchronous gap in execution. With #126698, the callsite of the service extensions was moved and the `_shutdown` check wasn't, allowing for the tool to attempt to advertise DevTools after the DevTools server had been cleaned up. --------- Co-authored-by:
Zachary Anderson <zanderso@users.noreply.github.com>
-
