Commits · bd836cc63ae016a98c6a4ef054e05fdf40e1f498 · abdullh.alsoleman / Front-End

23 Aug, 2023 7 commits

Roll Packages from c730a90f2fcc to 3060b1aec99c (4 revisions) (#133149) · bd836cc6

engine-flutter-autoroll authored Aug 23, 2023

https://github.com/flutter/packages/compare/c730a90f2fcc...3060b1aec99c

2023-08-23 ian@hixie.ch [rfw] Support web (as JS) (flutter/packages#4650)
2023-08-22 84124091+opxdelwin@users.noreply.github.com [webview_flutter] Update sample code. (flutter/packages#4727)
2023-08-22 ctrysbita@outlook.com [flutter_adaptive_scaffold] Fix top padding for NavigationBar (flutter/packages#4661)
2023-08-22 31859944+LongCatIsLooong@users.noreply.github.com Remove deprecated `ImageProvider` methods (flutter/packages#4725)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bd836cc6

Roll Flutter Engine from 7d56840865d2 to 72a06427bd37 (8 revisions) (#133139) · 575fd7ee

engine-flutter-autoroll authored Aug 23, 2023

https://github.com/flutter/engine/compare/7d56840865d2...72a06427bd37

2023-08-23 skia-flutter-autoroll@skia.org Roll Skia from ee7404db8273 to d0c369eaa637 (1 revision) (flutter/engine#44997)
2023-08-23 skia-flutter-autoroll@skia.org Roll Skia from d0d2b7042bb9 to ee7404db8273 (1 revision) (flutter/engine#44995)
2023-08-23 skia-flutter-autoroll@skia.org Roll Skia from eac8f8ea2660 to d0d2b7042bb9 (1 revision) (flutter/engine#44994)
2023-08-23 zanderso@users.noreply.github.com Revert "FontVariation.lerp, custom FontVariation constructors, and more documentation" (flutter/engine#44993)
2023-08-23 skia-flutter-autoroll@skia.org Roll Skia from aa208c8a2d60 to eac8f8ea2660 (1 revision) (flutter/engine#44992)
2023-08-23 dkwingsmt@users.noreply.github.com Move Rasterizer::Draw's discard_callback to Delegate (flutter/engine#44813)
2023-08-23 ian@hixie.ch FontVariation.lerp, custom FontVariation constructors, and more documentation (flutter/engine#43750)
2023-08-23 ian@hixie.ch Make web tests start with an empty title (flutter/engine#43846)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

575fd7ee

Manual roll Flutter Engine from b190f9015049 to 7d56840865d2 (15 revisions) (#133106) · 4bbcb780

engine-flutter-autoroll authored Aug 23, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/b190f9015049...7d56840865d2

2023-08-23 zanderso@users.noreply.github.com Revert "Roll Dart SDK from
ab417bc74bb1 to c162b4979562 (1 revision)" (flutter/engine#44989)
2023-08-23 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
G25oJMO5jbUi-UN4F... to DoQ8KUxSk-5EU6VQ1... (flutter/engine#44988)
2023-08-23 zanderso@users.noreply.github.com Revert "Make `FontWeight`
an enum, Remove unused text classes" (flutter/engine#44987)
2023-08-23 skia-flutter-autoroll@skia.org Roll Dart SDK from
ab417bc74bb1 to c162b4979562 (1 revision) (flutter/engine#44986)
2023-08-23 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
kKI09su99b0AKs8b3... to VSvpNFoFjqXIQTcs6... (flutter/engine#44984)
2023-08-23 matanlurey@users.noreply.github.com Enable clang-tidy for
pre-push (opt-out), exclude `performance-unnecessary-value-param`
(flutter/engine#44936)
2023-08-22 john@johnmccutchan.com Restore old SurfaceTextureExternal
drawing code (flutter/engine#44979)
2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from d0918de21c1a to
aa208c8a2d60 (2 revisions) (flutter/engine#44981)
2023-08-22 jason-simmons@users.noreply.github.com Initialize the texture
destruction callback in the Metal embedder test harness
(flutter/engine#44973)
2023-08-22 matanlurey@users.noreply.github.com Further filter/clear
`<SkPaint>.setDither(true)`, this time in `DlSkPaintDispatchHelper`
(flutter/engine#44912)
2023-08-22 skia-flutter-autoroll@skia.org Roll Dart SDK from
3ebf0fedfceb to ab417bc74bb1 (1 revision) (flutter/engine#44977)
2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from bf6019be75ef to
d0918de21c1a (3 revisions) (flutter/engine#44975)
2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from c675298ddeda to
bf6019be75ef (3 revisions) (flutter/engine#44974)
2023-08-22 31859944+LongCatIsLooong@users.noreply.github.com Make
`FontWeight` an enum, Remove unused text classes (flutter/engine#44960)
2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from 9f4b81aac175 to
c675298ddeda (2 revisions) (flutter/engine#44971)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from kKI09su99b0A to VSvpNFoFjqXI
  fuchsia/sdk/core/mac-amd64 from G25oJMO5jbUi to DoQ8KUxSk-5E

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4bbcb780

Reference AppLifecycleListener from widgets library (#132995) · 88290989
Ian Hickson authored Aug 23, 2023

88290989
Support disabling animations in the CLI (#132239) · 487bd690
Ian Hickson authored Aug 23, 2023

487bd690
Don't run on Samsung S10, shift to Pixel 7 Pro (#133085) · d8470f71
Zachary Anderson authored Aug 23, 2023

d8470f71
Add test to mark recording as leaking. (#133073) · 2afded61
Polina Cherkasova authored Aug 23, 2023

2afded61

22 Aug, 2023 28 commits

Revert "[gallery] roll gallery to ecfb9e5352bd12032301b12b30d5853d83d89bda" (#133095) · 5e9e959d

Jonah Williams authored Aug 22, 2023

Reverts flutter/flutter#133083

failing on cocoapods:

```
[2023-08-22 16:28:37.783355] [STDOUT] stdout: [        ] Error output from CocoaPods:
[2023-08-22 16:28:37.783379] [STDOUT] stdout:            â³
[2023-08-22 16:28:37.783402] [STDOUT] stdout: [        ]     [!] The version of CocoaPods used to generate the lockfile (1.12.1) is higher than the version of the current executable (1.11.3). Incompatibility issues may arise.
[2023-08-22 16:28:37.783423] [STDOUT] stdout: 
[2023-08-22 16:28:37.783445] [STDOUT] stdout:                [!] Automatically assigning platform `iOS` with version `11.0` on target `Runner` because no platform was specified. Please specify a platform for this target in your Podfile. See `https://guides.cocoapods.org/syntax/podfile.html#platform`.
[2023-08-22 16:28:37.783469] [STDOUT] stdout: 
[2023-08-22 16:28:37.784059] [STDOUT] stderr: [        ] Error: CocoaPods's specs repository is too out-of-date to satisfy dependencies.
[2023-08-22 16:28:37.784102] [STDOUT] stderr:            To update the CocoaPods specs, run:
[2023-08-22 16:28:37.784126] [STDOUT] stderr:              pod repo update
[2023-08-22 16:28:37.784147] [STDOUT] stderr: 
```

https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20new_gallery_ios__transition_perf/10590/overview

5e9e959d

[gallery] roll gallery to ecfb9e5352bd12032301b12b30d5853d83d89bda (#133083) · 00a99d3b

Jonah Williams authored Aug 22, 2023

This shrinks the size of the reply image attachments which should make it easier to find the actionable issues in https://github.com/flutter/flutter/issues/132690

00a99d3b

Update default menu text styles for Material 3 (#131930) · 1bc79169

Taha Tesser authored Aug 22, 2023

Related https://github.com/flutter/flutter/issues/131676

## Description

#### Fix default input text style for `DropdownMenu`

![dropdown_input](https://github.com/flutter/flutter/assets/48603081/301f8243-155a-4b8f-84a8-5e6b7bebb3bc)

### Fix default text style for  `MenuAnchor`'s menu items (which `DropdownMenu` uses for menu items)

![dropdown_item](https://github.com/flutter/flutter/assets/48603081/6b5be81a-72fc-4705-a577-074c7a4cad8f)

###  Default  `DropdownMenu` Input text style 

![Screenshot 2023-08-04 at 16 48 28](https://github.com/flutter/flutter/assets/48603081/bcd9da98-e74d-491e-ae64-6268ae0b3893)

### Default `DropdownMenu` menu item text style

![Screenshot 2023-08-04 at 16 50 19](https://github.com/flutter/flutter/assets/48603081/9592ca43-2854-45b5-8648-203ab65d9745)

### Default `MenuAnchor` menu item text style

![Screenshot 2023-08-04 at 14 34 28](https://github.com/flutter/flutter/assets/48603081/e87e1073-05f8-4dc7-a435-d864e9cce6ab)

### Code sample

<details> 
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

/// Flutter code sample for [DropdownMenu]s. The first dropdown menu has an outlined border.

void main() => runApp(const DropdownMenuExample());

class DropdownMenuExample extends StatefulWidget {
  const DropdownMenuExample({super.key});

  @override
  State<DropdownMenuExample> createState() => _DropdownMenuExampleState();
}

class _DropdownMenuExampleState extends State<DropdownMenuExample> {
  final TextEditingController colorController = TextEditingController();
  final TextEditingController iconController = TextEditingController();
  ColorLabel? selectedColor;
  IconLabel? selectedIcon;

  @override
  Widget build(BuildContext context) {
    final List<DropdownMenuEntry<ColorLabel>> colorEntries =
        <DropdownMenuEntry<ColorLabel>>[];
    for (final ColorLabel color in ColorLabel.values) {
      colorEntries.add(
        DropdownMenuEntry<ColorLabel>(
            value: color, label: color.label, enabled: color.label != 'Grey'),
      );
    }

    final List<DropdownMenuEntry<IconLabel>> iconEntries =
        <DropdownMenuEntry<IconLabel>>[];
    for (final IconLabel icon in IconLabel.values) {
      iconEntries
          .add(DropdownMenuEntry<IconLabel>(value: icon, label: icon.label));
    }

    return MaterialApp(
      theme: ThemeData(
        useMaterial3: true,
        colorSchemeSeed: Colors.green,
        // textTheme: const TextTheme(
        //   bodyLarge: TextStyle(
        //     fontWeight: FontWeight.bold,
        //     fontStyle: FontStyle.italic,
        //     decoration: TextDecoration.underline,
        //   ),
        // ),
      ),
      home: Scaffold(
        body: SafeArea(
          child: Column(
            children: <Widget>[
              const Text('DropdownMenus'),
              Padding(
                padding: const EdgeInsets.symmetric(vertical: 20),
                child: Row(
                  mainAxisAlignment: MainAxisAlignment.center,
                  children: <Widget>[
                    DropdownMenu<ColorLabel>(
                      controller: colorController,
                      label: const Text('Color'),
                      dropdownMenuEntries: colorEntries,
                      onSelected: (ColorLabel? color) {
                        setState(() {
                          selectedColor = color;
                        });
                      },
                    ),
                    const SizedBox(width: 20),
                    DropdownMenu<IconLabel>(
                      controller: iconController,
                      enableFilter: true,
                      leadingIcon: const Icon(Icons.search),
                      label: const Text('Icon'),
                      dropdownMenuEntries: iconEntries,
                      inputDecorationTheme: const InputDecorationTheme(
                        filled: true,
                        contentPadding: EdgeInsets.symmetric(vertical: 5.0),
                      ),
                      onSelected: (IconLabel? icon) {
                        setState(() {
                          selectedIcon = icon;
                        });
                      },
                    ),
                  ],
                ),
              ),
              const Text('Plain TextFields'),
              Padding(
                padding: const EdgeInsets.symmetric(vertical: 20),
                child: Row(
                  mainAxisAlignment: MainAxisAlignment.center,
                  children: <Widget>[
                    SizedBox(
                      width: 150,
                      child: TextField(
                          controller: TextEditingController(text: 'Blue'),
                          decoration: const InputDecoration(
                            suffixIcon: Icon(Icons.arrow_drop_down),
                            labelText: 'Color',
                            border: OutlineInputBorder(),
                          )),
                    ),
                    const SizedBox(width: 20),
                    SizedBox(
                      width: 150,
                      child: TextField(
                          controller: TextEditingController(text: 'Smile'),
                          decoration: const InputDecoration(
                            prefixIcon: Icon(Icons.search),
                            suffixIcon: Icon(Icons.arrow_drop_down),
                            filled: true,
                            labelText: 'Icon',
                          )),
                    ),
                  ],
                ),
              ),
              if (selectedColor != null && selectedIcon != null)
                Row(
                  mainAxisAlignment: MainAxisAlignment.center,
                  children: <Widget>[
                    Text(
                        'You selected a ${selectedColor?.label} ${selectedIcon?.label}'),
                    Padding(
                      padding: const EdgeInsets.symmetric(horizontal: 5),
                      child: Icon(
                        selectedIcon?.icon,
                        color: selectedColor?.color,
                      ),
                    )
                  ],
                )
              else
                const Text('Please select a color and an icon.')
            ],
          ),
        ),
      ),
    );
  }
}

enum ColorLabel {
  blue('Blue', Colors.blue),
  pink('Pink', Colors.pink),
  green('Green', Colors.green),
  yellow('Yellow', Colors.yellow),
  grey('Grey', Colors.grey);

  const ColorLabel(this.label, this.color);
  final String label;
  final Color color;
}

enum IconLabel {
  smile('Smile', Icons.sentiment_satisfied_outlined),
  cloud(
    'Cloud',
    Icons.cloud_outlined,
  ),
  brush('Brush', Icons.brush_outlined),
  heart('Heart', Icons.favorite);

  const IconLabel(this.label, this.icon);
  final String label;
  final IconData icon;
}

``` 
	
</details>

1bc79169

Roll Flutter Engine from 28b8bd5d5d91 to b190f9015049 (3 revisions) (#133078) · 469c6c33

engine-flutter-autoroll authored Aug 22, 2023

https://github.com/flutter/engine/compare/28b8bd5d5d91...b190f9015049

2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from 50814d9ca5bb to 9f4b81aac175 (1 revision) (flutter/engine#44969)
2023-08-22 mdebbar@google.com [web] Move remaining web-only APIs to `dart:ui_web` (flutter/engine#44516)
2023-08-22 flar@google.com Revert "Split DisplayListBuilder into DlCanvas optimizer and DlOp recorder classes" (flutter/engine#44968)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

469c6c33

Fix `FlexibleSpaceBar.title` doesn't respect the leading widget (#132573) · db89df51

Taha Tesser authored Aug 22, 2023

fixes [Long `FlexibleSpaceBar.title` doesn't respect the leading widget 
](https://github.com/flutter/flutter/issues/132030)

### Description

- This adds `FlexibleSpaceBarSettings.hasLeading` for the `FlexibleSpaceBar`'s title to respect the leading widget.
- Use the new `FlexibleSpaceBarSettings.hasLeading` property in the  `SliverAppBar` for its `FlexibleSpaceBar`.

### Code sample

<details> 
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(
        useMaterial3: true,
        brightness: Brightness.dark,
      ),
      home: const Example(),
    );
  }
}

class Example extends StatelessWidget {
  const Example({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Column(
        mainAxisAlignment: MainAxisAlignment.center,
        children: [
          const Text('TargetPlatform.Android'),
          Theme(
            data: Theme.of(context).copyWith(
              platform: TargetPlatform.android,
            ),
            child: Container(
              height: 250,
              padding: const EdgeInsets.all(8),
              decoration: BoxDecoration(
                border: Border.all(
                  color: Colors.amber,
                  width: 4,
                ),
              ),
              child: const AppBarLeading(
                showLeading: true,
                showTitle: false,
              ),
            ),
          ),
          const Text('TargetPlatform.iOS'),
          Theme(
            data: Theme.of(context).copyWith(
              platform: TargetPlatform.iOS,
            ),
            child: Container(
              height: 250,
              padding: const EdgeInsets.all(8),
              decoration: BoxDecoration(
                border: Border.all(
                  color: Colors.amber,
                  width: 2,
                ),
              ),
              child: const AppBarLeading(
                showLeading: true,
                showTitle: false,
              ),
            ),
          ),
        ],
      ),
    );
  }
}

class AppBarLeading extends StatelessWidget {
  const AppBarLeading({
    super.key,
    required this.showLeading,
    required this.showTitle,
  });

  final bool showLeading;
  final bool showTitle;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      drawer: const Drawer(),
      body: CustomScrollView(
        slivers: [
          SliverAppBar(
            automaticallyImplyLeading: showLeading,
            iconTheme: const IconThemeData(
              color: Colors.amber,
            ),
            title: showTitle ? const Text('AppBar') : null,
            flexibleSpace: FlexibleSpaceBar(
              title: Text('Title ' * 15),
              // centerTitle: true,
            ),
            toolbarHeight: showTitle ? 170 : 100,
          ),
        ],
      ),
    );
  }
}
``` 
	
</details>

### Before 

![Screenshot 2023-08-15 at 18 11 34](https://github.com/flutter/flutter/assets/48603081/4b798998-8549-43aa-b564-933ea14f494c)

### After

![Screenshot 2023-08-15 at 18 11 45](https://github.com/flutter/flutter/assets/48603081/b085a33a-db7d-40d4-8a12-ee37197b5bd4)

db89df51

Roll Flutter Engine from 21437d384b56 to 28b8bd5d5d91 (1 revision) (#133075) · 0283d8a8

engine-flutter-autoroll authored Aug 22, 2023

https://github.com/flutter/engine/compare/21437d384b56...28b8bd5d5d91

2023-08-22 reidbaker@google.com i82973 scroll mouse wheel support (flutter/engine#44724)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0283d8a8

Roll Flutter Engine from 090754879679 to 21437d384b56 (1 revision) (#133072) · ee7788cf

engine-flutter-autoroll authored Aug 22, 2023

https://github.com/flutter/engine/compare/090754879679...21437d384b56

2023-08-22 30870216+gaaclarke@users.noreply.github.com [Impeller] Tiny optimizations for text rendering (avoiding extra ops and copies). (flutter/engine#44822)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ee7788cf

Add support for `Future<List<int>?>` to `MatchesGoldenFile` (#132965) · 5665655d

Ivan Inozemtsev authored Aug 22, 2023

Otherwise when tests use `expectLater(getBytesOrNull(), matchesGoldenFile(...))`, they may fail in sound null safety mode and pass in weak null safety mode.

Fixes https://github.com/flutter/flutter/issues/132964

5665655d

Roll Packages from e26f3b9374d0 to c730a90f2fcc (3 revisions) (#133067) · 18432377

engine-flutter-autoroll authored Aug 22, 2023

https://github.com/flutter/packages/compare/e26f3b9374d0...c730a90f2fcc

2023-08-22 engine-flutter-autoroll@skia.org Roll Flutter from 5e6d88d7 to 54c98d74 (24 revisions) (flutter/packages#4754)
2023-08-22 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump io.mockk:mockk from 1.13.5 to 1.13.7 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#4736)
2023-08-21 engine-flutter-autoroll@skia.org Roll Flutter from 6f227c07 to 5e6d88d7 (8 revisions) (flutter/packages#4751)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

18432377

Roll Flutter Engine from ff375bf5d8eb to 090754879679 (1 revision) (#133066) · 43facd14

engine-flutter-autoroll authored Aug 22, 2023

https://github.com/flutter/engine/compare/ff375bf5d8eb...090754879679

2023-08-22 skia-flutter-autoroll@skia.org Roll Dart SDK from ecb1e3aecfbb to 3ebf0fedfceb (1 revision) (flutter/engine#44962)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

43facd14

Increase heap size for examples/flutter_view gradle build (#133064) · 6a2d1b94

Zachary Anderson authored Aug 22, 2023

For the engine roll presubmit failure in https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20build_tests_3_3/10805/overview

6a2d1b94

Roll Flutter Engine from c5e0152b01f4 to ff375bf5d8eb (4 revisions) (#133062) · c475409b

engine-flutter-autoroll authored Aug 22, 2023

https://github.com/flutter/engine/compare/c5e0152b01f4...ff375bf5d8eb

2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from eff8446c42f8 to 50814d9ca5bb (1 revision) (flutter/engine#44958)
2023-08-22 brianosman@google.com Add missing GrVkTypes include (flutter/engine#44957)
2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from a548d28072ce to eff8446c42f8 (2 revisions) (flutter/engine#44955)
2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from b3b8f3332cce to a548d28072ce (3 revisions) (flutter/engine#44953)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c475409b

Fix memory leak in Form (#132987) · 0278671b
Justin McCandless authored Aug 22, 2023
```
Diposes some restorable variables that weren't disposed before.
```
0278671b

Re-enable Xcode Debug tests (#132523) · b3005a31

Victoria Ashworth authored Aug 22, 2023

Re-enables Xcode Debug tests (still in bringup). It also has them use an older version of Xcode that is compatible with the host OS.

Fixes https://github.com/flutter/flutter/issues/132309.

b3005a31

Increase heap for gradle in examples/platform_view (#133052) · 10b7712b
Zachary Anderson authored Aug 22, 2023
```
Fixes https://github.com/flutter/flutter/issues/133051
```
10b7712b
Cover more tests with leak tracking. (#132806) · 4e6da2dc
Polina Cherkasova authored Aug 22, 2023
```
This PR replaces some `testWidgets` with `testWidgestsWithLeakTracking`.
```
4e6da2dc

Roll Flutter Engine from f5f099a4a5e3 to c5e0152b01f4 (4 revisions) (#133049) · c00bdc83

engine-flutter-autoroll authored Aug 22, 2023

https://github.com/flutter/engine/compare/f5f099a4a5e3...c5e0152b01f4

2023-08-22 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from DA_PryqcVU6Um3j2k... to G25oJMO5jbUi-UN4F... (flutter/engine#44951)
2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from bf08da24a261 to b3b8f3332cce (1 revision) (flutter/engine#44952)
2023-08-22 skia-flutter-autoroll@skia.org Roll Dart SDK from 00f6f69187df to ecb1e3aecfbb (1 revision) (flutter/engine#44950)
2023-08-22 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from RVhmZNTYsaIiTyjwP... to kKI09su99b0AKs8b3... (flutter/engine#44949)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from RVhmZNTYsaIi to kKI09su99b0A
fuchsia/sdk/core/mac-amd64 from DA_PryqcVU6U to G25oJMO5jbUi

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c00bdc83

Roll Flutter Engine from 447981acbf36 to f5f099a4a5e3 (1 revision) (#133035) · 54c98d74

engine-flutter-autoroll authored Aug 22, 2023

https://github.com/flutter/engine/compare/447981acbf36...f5f099a4a5e3

2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from f13ee6ee5433 to bf08da24a261 (1 revision) (flutter/engine#44946)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

54c98d74

Roll Flutter Engine from 5e84d733ef67 to 447981acbf36 (2 revisions) (#133031) · 7171c9b3

engine-flutter-autoroll authored Aug 22, 2023

https://github.com/flutter/engine/compare/5e84d733ef67...447981acbf36

2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from 399e90397a07 to f13ee6ee5433 (1 revision) (flutter/engine#44944)
2023-08-22 leroux_bruno@yahoo.fr [Linux] Expose channel buffers 'resize' and 'overflow' control commands (flutter/engine#44636)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7171c9b3

Roll Flutter Engine from e183e8a94093 to 5e84d733ef67 (1 revision) (#133030) · f238211e

engine-flutter-autoroll authored Aug 22, 2023

https://github.com/flutter/engine/compare/e183e8a94093...5e84d733ef67

2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from 14e7b3b2d660 to 399e90397a07 (1 revision) (flutter/engine#44943)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f238211e

Roll Flutter Engine from 454e0e35f8e4 to e183e8a94093 (2 revisions) (#133026) · e085e613

engine-flutter-autoroll authored Aug 22, 2023

https://github.com/flutter/engine/compare/454e0e35f8e4...e183e8a94093

2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from 9ecdc9265aaa to 14e7b3b2d660 (1 revision) (flutter/engine#44942)
2023-08-22 bdero@google.com [Impeller] Supply a text backend to the AiksContext at runtime. (flutter/engine#44884)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e085e613

Roll Flutter Engine from 857840db5574 to 454e0e35f8e4 (1 revision) (#133020) · 5b209884

engine-flutter-autoroll authored Aug 22, 2023

https://github.com/flutter/engine/compare/857840db5574...454e0e35f8e4

2023-08-22 matanlurey@users.noreply.github.com Disallow using ./tools/gn --enable-unittests --android (or --ios) (flutter/engine#44930)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5b209884

Roll Flutter Engine from 1ab054967c1d to 857840db5574 (2 revisions) (#133018) · fedf0a8a

engine-flutter-autoroll authored Aug 22, 2023

https://github.com/flutter/engine/compare/1ab054967c1d...857840db5574

2023-08-22 skia-flutter-autoroll@skia.org Roll Skia from 40442138ec94 to 9ecdc9265aaa (1 revision) (flutter/engine#44939)
2023-08-22 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from aXDvHIK6XMKTHieu_... to DA_PryqcVU6Um3j2k... (flutter/engine#44938)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from aXDvHIK6XMKT to DA_PryqcVU6U

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fedf0a8a

Roll Flutter Engine from 5a292e42a593 to 1ab054967c1d (1 revision) (#133014) · 8e7304bb

engine-flutter-autoroll authored Aug 22, 2023

https://github.com/flutter/engine/compare/5a292e42a593...1ab054967c1d

2023-08-22 chinmaygarde@google.com [Impeller] Document rendering backend selection on Android. (flutter/engine#44933)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8e7304bb

Fix visual overflow for SliverMainAxisGroup (#132989) · a5b06f15

Kate Lovett authored Aug 22, 2023

Fixes https://github.com/flutter/flutter/issues/132788

The SliverGeometry was not set properly for SliverMainAxisGroup. Omitting hasVisualOverflow affected the Viewport's choice to apply a clip, leading to the sliver being rendered outside of the bounds of the viewport.

a5b06f15

Roll Flutter Engine from e5929d83e9b7 to 5a292e42a593 (3 revisions) (#133010) · 1cf3925d

engine-flutter-autoroll authored Aug 22, 2023

https://github.com/flutter/engine/compare/e5929d83e9b7...5a292e42a593

2023-08-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from lDn2QLh1I7rtNu01y... to RVhmZNTYsaIiTyjwP... (flutter/engine#44932)
2023-08-21 skia-flutter-autoroll@skia.org Roll Skia from da6b74568ece to 40442138ec94 (3 revisions) (flutter/engine#44931)
2023-08-21 31859944+LongCatIsLooong@users.noreply.github.com Reland "Implementing TextScaler for nonlinear text scaling (#42062)" (flutter/engine#44907)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from lDn2QLh1I7rt to RVhmZNTYsaIi

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1cf3925d

Always require `--local-engine-host` if `--local-engine` (#133003) · a021015e
Matan Lurey authored Aug 22, 2023
```
Closes #132245.
```
a021015e

Roll Flutter Engine from 55b84268f2a6 to e5929d83e9b7 (3 revisions) (#133005) · 97e434f8

engine-flutter-autoroll authored Aug 22, 2023

https://github.com/flutter/engine/compare/55b84268f2a6...e5929d83e9b7

2023-08-21 dnfield@google.com [Impeller] Disable Impeller on Fuchsia (flutter/engine#44925)
2023-08-21 30870216+gaaclarke@users.noreply.github.com [Impeller] Added recycled command buffers. (flutter/engine#44904)
2023-08-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 1859f7202bba to 00f6f69187df (1 revision) (flutter/engine#44922)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

97e434f8

21 Aug, 2023 5 commits

Roll Flutter Engine from e5f690b829e5 to 55b84268f2a6 (1 revision) (#133000) · 5a847b09

engine-flutter-autoroll authored Aug 21, 2023

https://github.com/flutter/engine/compare/e5f690b829e5...55b84268f2a6

2023-08-21 godofredoc@google.com Use arm64 machines for ios_debug_sim_arm64 test. (flutter/engine#44920)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5a847b09

Add deleteBackwardByDecomposingPreviousCharacter mapping for tests (#132919) · f9b91734

Angelo Silvestre authored Aug 21, 2023

In `MacOSTestTextInputKeyHandler`, there are some mappings from shortcuts to generate macOS selectors. However, `ctrl + backspace` isn't mapped to `deleteBackwardByDecomposingPreviousCharacter:`.

This PR adds the mapping for `deleteBackwardByDecomposingPreviousCharacter:`.

Fixes: https://github.com/flutter/flutter/issues/132917

f9b91734

Roll Flutter Engine from fc75109c3a1e to e5f690b829e5 (1 revision) (#132996) · 254f235c

engine-flutter-autoroll authored Aug 21, 2023

https://github.com/flutter/engine/compare/fc75109c3a1e...e5f690b829e5

2023-08-21 skia-flutter-autoroll@skia.org Roll Skia from ca891e495da1 to da6b74568ece (3 revisions) (flutter/engine#44917)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

254f235c

Roll Flutter Engine from 2388b9db2be7 to fc75109c3a1e (3 revisions) (#132992) · 7f5de98a

engine-flutter-autoroll authored Aug 21, 2023

https://github.com/flutter/engine/compare/2388b9db2be7...fc75109c3a1e

2023-08-21 brianosman@google.com Include GrVkTypes where necessary (flutter/engine#44916)
2023-08-21 skia-flutter-autoroll@skia.org Roll Skia from af4ecc4cd3e9 to ca891e495da1 (1 revision) (flutter/engine#44914)
2023-08-21 godofredoc@google.com Remove explicit mac cpu dimensions (flutter/engine#44836)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7f5de98a

Roll Flutter Engine from 210f5a8aa245 to 2388b9db2be7 (6 revisions) (#132986) · f05dcafd

engine-flutter-autoroll authored Aug 21, 2023

https://github.com/flutter/engine/compare/210f5a8aa245...2388b9db2be7

2023-08-21 john@johnmccutchan.com [Impeller] Initial Android Impeller docs on backend selection and platform views. (flutter/engine#44815)
2023-08-21 skia-flutter-autoroll@skia.org Roll Skia from da3bb89a5d88 to af4ecc4cd3e9 (1 revision) (flutter/engine#44911)
2023-08-21 skia-flutter-autoroll@skia.org Roll Skia from 7e5a3009a8d4 to da3bb89a5d88 (9 revisions) (flutter/engine#44906)
2023-08-21 zanderso@users.noreply.github.com Don't run clang_tidy --lint-all in presubmit (flutter/engine#44833)
2023-08-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 7dd53a3df4cf to 1859f7202bba (1 revision) (flutter/engine#44903)
2023-08-21 gspencergoog@users.noreply.github.com Change Doxyfile options to not create subdirs (flutter/engine#44855)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f05dcafd