Commits · bc254ce3f5e0c145709ecbcc300e1ae86735458d · abdullh.alsoleman / Front-End

19 Jan, 2024 20 commits

Roll Flutter Engine from 517fc2bbfa51 to d00e55f7f8ed (1 revision) (#141909) · bc254ce3

engine-flutter-autoroll authored Jan 19, 2024

https://github.com/flutter/engine/compare/517fc2bbfa51...d00e55f7f8ed

2024-01-19 737941+loic-sharma@users.noreply.github.com [Windows] Refactor EGL initialization (flutter/engine#49895)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bc254ce3

Roll Flutter Engine from f2b441a26416 to 517fc2bbfa51 (2 revisions) (#141904) · cd6fe510

engine-flutter-autoroll authored Jan 19, 2024

https://github.com/flutter/engine/compare/f2b441a26416...517fc2bbfa51

2024-01-19 skia-flutter-autoroll@skia.org Roll Skia from fabb71dcf9b7 to 61a2dcff4194 (1 revision) (flutter/engine#49904)
2024-01-19 skia-flutter-autoroll@skia.org Roll Skia from c09908c48f14 to fabb71dcf9b7 (3 revisions) (flutter/engine#49902)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cd6fe510

Fix "Delete" tooltip is shown disabled on chips with `onDeleted` callback (#141770) · 788614d1

Taha Tesser authored Jan 19, 2024

fixes [Disabled chips with `onDeleted` callback shows "Delete" tooltip on hover](https://github.com/flutter/flutter/issues/141336)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Example(),
    );
  }
}

class Example extends StatefulWidget {
  const Example({super.key});

  @override
  State<Example> createState() => _ExampleState();
}

class _ExampleState extends State<Example> {
  bool _isEnable = false;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.spaceEvenly,
          children: <Widget>[
            RawChip(
              label: const Text('RawChip'),
              onPressed: () {},
              isEnabled: _isEnable,
              onDeleted: () {},
            ),
            FilterChip(
              label: const Text('FilterChip'),
              selected: false,
              onSelected: _isEnable ? (bool value) {} : null,
              onDeleted: () {},
            ),
            InputChip(
              label: const Text('InputChip'),
              isEnabled: _isEnable,
              onDeleted: () {},
            ),
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton.extended(
        onPressed: () {
          setState(() {
            _isEnable = !_isEnable;
          });
        },
        label: Text(_isEnable ? 'Disable' : 'Enable'),
      ),
    );
  }
}
```

</details>

### Preview

| Before | After |
| --------------- | --------------- |
| <img src="https://github.com/flutter/flutter/assets/48603081/f80ae5f7-0a6d-4041-ade3-cbc2b5c78188" height="450" /> | <img src="https://github.com/flutter/flutter/assets/48603081/04e62854-e3f1-4b65-9753-183d288f3cfe" height="450" /> |

788614d1

Run module_test_ios on arm and x64 (#141815) · 6f7aed59
godofredoc authored Jan 19, 2024
```
This will ensure the test runs on the supported platforms.
```
6f7aed59
`SearchAnchor` search view clear button only shows up when text input is not empty (#141755) · 05854afa
Qun Cheng authored Jan 19, 2024

05854afa

Use Integer instead of int in map in flutter.groovy (#141895) · 684247a3

Reid Baker authored Jan 19, 2024

packages Roller breakage 
https://ci.chromium.org/ui/p/flutter/builders/try/Linux_android%20android_build_all_packages%20master/5504/overview
Fixes flutter/flutter/issues/141897
```
FAILURE: Build failed with an exception.

* Where:
Script '/b/s/w/ir/x/w/flutter/packages/flutter_tools/gradle/src/main/groovy/flutter.groovy' line: 168

* What went wrong:
Could not compile script '/b/s/w/ir/x/w/flutter/packages/flutter_tools/gradle/src/main/groovy/flutter.groovy'.
> startup failed:
  script '/b/s/w/ir/x/w/flutter/packages/flutter_tools/gradle/src/main/groovy/flutter.groovy': 168: primitive type parameters not allowed here;
     solution: use the corresponding wrapper type, such as Integer for int @ line 168, column 41.
     e static final Map<String, int> ABI_VERS
```

Covered by tests in packages.

684247a3

Roll Flutter Engine from c953c83112ba to f2b441a26416 (4 revisions) (#141894) · f0e9d232

engine-flutter-autoroll authored Jan 19, 2024

https://github.com/flutter/engine/compare/c953c83112ba...f2b441a26416

2024-01-19 jonahwilliams@google.com Reland: Encode directly to command buffer. (flutter/engine#49821)
2024-01-19 skia-flutter-autoroll@skia.org Roll Skia from 2536dc6fef1d to c09908c48f14 (6 revisions) (flutter/engine#49899)
2024-01-19 dnfield@google.com [Impeller] Documentation for SurfaceContextVK (flutter/engine#49882)
2024-01-19 32242716+ricardoamador@users.noreply.github.com Adding ignore paths to cache test (flutter/engine#49874)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f0e9d232

Native assets: package in framework on iOS and MacOS (#140907) · 2e229be2

Daco Harkes authored Jan 19, 2024

Packages the native assets for iOS and MacOS in frameworks.

Issue:

* https://github.com/flutter/flutter/issues/140544
* https://github.com/flutter/flutter/issues/129757

## Details

* [x] This packages dylibs from the native assets feature in frameworks. It packages every dylib in a separate framework.
* [x] The dylib name is updated to use `@rpath` instead of `@executable_path`.
* [x] The dylibs for flutter-tester are no longer modified to change the install name. (Previously it was wrongly updating the install name to the location the dylib would have once deployed in an app.)
* [x] Use symlinking on MacOS.

2e229be2

Revert "Make tests more resilient to Skia gold failures and refactor... · 77c3807c

Ian Hickson authored Jan 19, 2024

Revert "Make tests more resilient to Skia gold failures and refactor flutter_goldens for extensive technical debt removal (#140101)" (#141814)

Reverts https://github.com/flutter/flutter/pull/140101

That PR somehow made non-matching gold tests not fail at HEAD.

Fixes https://github.com/flutter/flutter/issues/141880
- Blocked by https://github.com/flutter/flutter/issues/140169
  - https://github.com/flutter/flutter/pull/141427

77c3807c

Roll Flutter Engine from 538975f2511b to c953c83112ba (3 revisions) (#141886) · 49447fc6

engine-flutter-autoroll authored Jan 19, 2024

https://github.com/flutter/engine/compare/538975f2511b...c953c83112ba

2024-01-19 flar@google.com [Impeller] switch Rect fields to LTRB implementation (flutter/engine#49816)
2024-01-19 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Redo - Use chromium test-scripts to download images and execute tests (flutter/engine#49847)
2024-01-19 skia-flutter-autoroll@skia.org Roll Skia from fb3f61d932e6 to 2536dc6fef1d (2 revisions) (flutter/engine#49892)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

49447fc6

Add `showDragHandle` to `showBottomSheet` (#141754) · ba4a11da
Qun Cheng authored Jan 19, 2024

ba4a11da

Roll Flutter Engine from 9a6c64de8a46 to 538975f2511b (8 revisions) (#141881) · 3563372f

engine-flutter-autoroll authored Jan 19, 2024

https://github.com/flutter/engine/compare/9a6c64de8a46...538975f2511b

2024-01-19 skia-flutter-autoroll@skia.org Roll Skia from 0a78d1f0ef48 to fb3f61d932e6 (1 revision) (flutter/engine#49891)
2024-01-19 skia-flutter-autoroll@skia.org Roll Skia from 961ad2c3fcf5 to 0a78d1f0ef48 (1 revision) (flutter/engine#49890)
2024-01-19 103135467+sealesj@users.noreply.github.com Re-enable osv-scanner on pushes to main (flutter/engine#49729)
2024-01-19 skia-flutter-autoroll@skia.org Roll Skia from 273b0628a969 to 961ad2c3fcf5 (1 revision) (flutter/engine#49889)
2024-01-19 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from dTy8CK4YxnUsW305O... to geXIwPzzJiSXrZEEb... (flutter/engine#49888)
2024-01-19 skia-flutter-autoroll@skia.org Roll Skia from b6fa819eb54c to 273b0628a969 (1 revision) (flutter/engine#49887)
2024-01-19 skia-flutter-autoroll@skia.org Roll Skia from e073a4fad57a to b6fa819eb54c (1 revision) (flutter/engine#49886)
2024-01-19 leroux_bruno@yahoo.fr [Android] Fix KeyEmbedderResponder throws a NullPointerException (flutter/engine#49860)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from dTy8CK4YxnUs to geXIwPzzJiSX

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3563372f

Make pumpWidget's arguments named (#141728) · cc544169

Michael Goderbauer authored Jan 19, 2024

Much nicer calling API and simplifies evolving this API in the future.

I wish we could write a dart fix for this, but that's blocked on https://github.com/dart-lang/sdk/issues/54668.

cc544169

Tiny fix inaccurate documentations about bindings (#140282) · 9e024fdf

fzyzcjy authored Jan 19, 2024

The old doc says that, AutomatedTestWidgetsFlutterBinding for `flutter test` and LiveTestWidgetsFlutterBinding for `flutter run`. However, suppose we `flutter test integration_test/simple_test.dart` with the following code:

```
void main() {
  testWidgets('hi', (WidgetTester tester) async {
    print('hi ${TestWidgetsFlutterBinding.instance} ${Platform.operatingSystem}');
  });
}
```

We will see: `hi <IntegrationTestWidgetsFlutterBinding> ios`. Therefore, we see `IntegrationTestWidgetsFlutterBinding` is used in a `flutter test` command, which is contrary to the documentation.

9e024fdf

Roll engine to 9a6c64de8a4694cef59a338cd33ac1a9e7d23d9d (#141870) · d4707d12

Zachary Anderson authored Jan 19, 2024

Includes the Engine roll from
https://github.com/flutter/flutter/pull/141841

A new version of Dart is having trouble with the tool integration test
test `passing one file with errors are detected`:
https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20tool_integration_tests_2_4/31851/overview.

However the analysis server emits the expected errors when we give it
both the file without issues and the file with issues.

My guess is that the analysis server has changed it's behavior slightly
when supplied with a single malformed file.

Since the Dart roll is >20 dev versions behind, and this is the only
failing presubmit test, and it's testing something a bit weird, I
suggest we investigate the right way to test the thing that test was
attempting to cover as a follow-up.

d4707d12

Roll Packages from 83c2c4da97c5 to 129e08c1dff1 (13 revisions) (#141865) · 0487931a

engine-flutter-autoroll authored Jan 19, 2024

https://github.com/flutter/packages/compare/83c2c4da97c5...129e08c1dff1

2024-01-19 magder@google.com [pigeon] Run swift-format on ungenerated example app Swift files (flutter/packages#5934)
2024-01-19 magder@google.com [path_provider_foundation] Run swift-format on Swift files (flutter/packages#5935)
2024-01-19 magder@google.com [shared_preferences_foundation] Run swift-format on Swift files (flutter/packages#5933)
2024-01-19 magder@google.com [various] Run swift-format on example app Swift files (flutter/packages#5931)
2024-01-19 magder@google.com [camera_avfoundation] Remove development team from Xcode example app (flutter/packages#5930)
2024-01-18 jsharp83@gmail.com [webview_flutter_wkwebview] Add javascript panel interface for wkwebview (flutter/packages#5795)
2024-01-18 amirpanahandeh@yahoo.com [two_dimensional_scrollables] Fix must_call_super (flutter/packages#5921)
2024-01-18 cedvandenbosch@gmail.com [pointer_interceptor] fix width and height unset warning on web platform (flutter/packages#5864)
2024-01-18 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.23.0 to 3.23.1 (flutter/packages#5922)
2024-01-18 stuartmorgan@google.com [google_maps_flutter] Clean up iOS example project (flutter/packages#5925)
2024-01-18 magder@google.com [ci] Add flags to formatter command to decide which formatters to run (flutter/packages#5905)
2024-01-18 15619084+vashworth@users.noreply.github.com Update tests to Xcode 15 and iOS 17 simulator (flutter/packages#5914)
2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter from def6af0b to f77f8243 (25 revisions) (flutter/packages#5924)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0487931a

Add mac_x64_ios configuration. (#141828) · c95bb6fb

godofredoc authored Jan 19, 2024

This is in preparation to allow tests to run on x64 and arm64 if they rely only on the ios phone.

c95bb6fb

Roll Flutter Engine from 90be25d8aac3 to d1afda52d254 (1 revision) (#141825) · 70a4a5de

engine-flutter-autoroll authored Jan 19, 2024

https://github.com/flutter/engine/compare/90be25d8aac3...d1afda52d254

2024-01-19 skia-flutter-autoroll@skia.org Roll Skia from c71519e854d1 to dd24bd11d79e (1 revision) (flutter/engine#49878)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

70a4a5de

Move the requestKeyboard up to the widgets layer (#141655) · 8ff0af0c

Ian Hickson authored Jan 19, 2024

Turns out all implementations of this method made this call, so it seems like it should belong in the superclass.

8ff0af0c

Roll Flutter Engine from dde3ebf6551a to 90be25d8aac3 (1 revision) (#141817) · 46bbf402

engine-flutter-autoroll authored Jan 19, 2024

https://github.com/flutter/engine/compare/dde3ebf6551a...90be25d8aac3

2024-01-18 skia-flutter-autoroll@skia.org Roll Skia from da3bfb25fb84 to c71519e854d1 (1 revision) (flutter/engine#49875)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

46bbf402

18 Jan, 2024 20 commits

enable more tests in web mode (#141791) · 5987563e

Yegor authored Jan 18, 2024

- Unskip `text_style_test` for CanvasKit.
- Remove no longer necessary `kIsWeb` checks in a few tests.

This PR depends on https://github.com/flutter/engine/pull/49786, which rolled into the framework. If the engine PR needs to be reverted, this PR will need to be reverted too.

5987563e

Roll Flutter Engine from 9dded186bcff to dde3ebf6551a (2 revisions) (#141811) · cdf82b28

engine-flutter-autoroll authored Jan 18, 2024

https://github.com/flutter/engine/compare/9dded186bcff...dde3ebf6551a

2024-01-18 737941+loic-sharma@users.noreply.github.com [Windows] Refactor logic when window resize completes (flutter/engine#49872)
2024-01-18 skia-flutter-autoroll@skia.org Roll Skia from 40200ceca00e to da3bfb25fb84 (1 revision) (flutter/engine#49873)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cdf82b28

Update margin between label and icon in Tab to better reflect Material specs (#140698) · 197cd4d6

David Martos authored Jan 18, 2024

This PR improves the distance between the label and the icon in the Tab widget. 
I updated the margin to 2 pixels, taken from the Figma design page for Material 3. On Material 2 I left the default value of 10 pixels.

Related to #128696 (In particular, the distance between label and icon)

Here are some screenshots for comparison. I looked a bit into the other mentioned issue of the tab height not following the M3 spec. Flutter uses 72 and the spec uses 64. But because Tab is a PreferredSizeWidget, I don't think there is an easy way to provide a different size depending on `ThemeData.useMaterial3`, because there is no `BuildContext` available.
I provide a sample image for the 64 height as well for context on the linked issue, even though it's not part of the PR changes.

The screenshots are taken side by side with the image at: https://m3.material.io/components/tabs/guidelines

## Original

![original](https://github.com/flutter/flutter/assets/22084723/f52d46bb-eaf9-4519-976e-9ea07c021e14)

## New (tab height = 72, Flutter default for 8 years)

![new_72](https://github.com/flutter/flutter/assets/22084723/8c9d3510-eaca-4b7d-92d8-0d06a7e75136)

## New (tab height = 64, M3 spec)

![new_64](https://github.com/flutter/flutter/assets/22084723/f8811b70-766f-4a4f-b069-33673b1e3744)

197cd4d6

Roll Flutter Engine from 3106e08e1219 to 9dded186bcff (2 revisions) (#141807) · c1b01ec1

engine-flutter-autoroll authored Jan 18, 2024

https://github.com/flutter/engine/compare/3106e08e1219...9dded186bcff

2024-01-18 fmil@google.com [fuchsia] Wire through the tzdata-icu capability (flutter/engine#48907)
2024-01-18 skia-flutter-autoroll@skia.org Roll Skia from 31fae9f0cdd1 to 40200ceca00e (1 revision) (flutter/engine#49871)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c1b01ec1

Reverts "Enable native compilation for windows-arm64 " (#141809) · 1901d6fa

auto-submit[bot] authored Jan 18, 2024

Reverts flutter/flutter#137618
Initiated by: Jasguerrero
This change reverts the following previous change:
Original Description:
It's now possible to natively compile a flutter app for
windows-arm64. Cross-compilation is not yet implemented.

Uses arm64 artifacts now available for Dart/Flutter.
Platform detection is based on Abi class, provided by Dart. Depending if
Dart is an arm64 or x64 binary, the Abi is set accordingly.
Initial bootstrap of dart artifacts (update_dart_sdk.ps1) is checking
PROCESSOR_ARCHITECTURE environment variable, which is the way to detect
host architecture on Windows.

This is available only for master channel (on other channels, it
fallbacks to windows-x64).

On windows-x64, it produces an x64 app. On windows-arm64, it produces an
arm64 app.

1901d6fa

Run framework_tests_misc in arm64 and x64. (#141797) · 9d9bd884
godofredoc authored Jan 18, 2024
```
This is to ensure coverage in both platforms.
```
9d9bd884

Roll Flutter Engine from f4a4f046b173 to 3106e08e1219 (1 revision) (#141802) · 0dc066b7

engine-flutter-autoroll authored Jan 18, 2024

https://github.com/flutter/engine/compare/f4a4f046b173...3106e08e1219

2024-01-18 skia-flutter-autoroll@skia.org Roll Skia from 1064eeedac09 to 31fae9f0cdd1 (1 revision) (flutter/engine#49869)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0dc066b7

Bump actions/upload-artifact from 4.1.0 to 4.2.0 (#141803) · fac26c57

dependabot[bot] authored Jan 18, 2024

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.1.0 to 4.2.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases">actions/upload-artifact's releases</a>.</em></p>
<blockquote>
<h2>v4.2.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Ability to overwrite an Artifact by <a href="https://github.com/robherley"><code>@ârobherley</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/501">actions/upload-artifact#501</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v4...v4.2.0">https://github.com/actions/upload-artifact/compare/v4...v4.2.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/actions/upload-artifact/commit/694cdabd8bdb0f10b2cea11669e1bf5453eed0a6"><code>694cdab</code></a> Merge pull request <a href="https://redirect.github.com/actions/upload-artifact/issues/501">#501</a> from actions/robherley/overwrite-artifact</li>
<li><a href="https://github.com/actions/upload-artifact/commit/05d4fe67025ed6d5b746e3502573715a2c37e318"><code>05d4fe6</code></a> run licensed against version that matches ci</li>
<li><a href="https://github.com/actions/upload-artifact/commit/40b305282182ab3d3265c0c45fd82dee1e605ace"><code>40b3052</code></a> update readme</li>
<li><a href="https://github.com/actions/upload-artifact/commit/49552fcb82fc92c668b492a7d36fc7860a20c81d"><code>49552fc</code></a> add overwrite tests to workflow</li>
<li><a href="https://github.com/actions/upload-artifact/commit/79615904cc1dfafb77b85c0d3a21f89dba2a38c2"><code>7961590</code></a> licensed cache</li>
<li><a href="https://github.com/actions/upload-artifact/commit/11ff42c7b1b52130283d8a02bc960d1e1de95000"><code>11ff42c</code></a> add new overwrite input &amp; docs</li>
<li>See full diff in <a href="https://github.com/actions/upload-artifact/compare/1eb3cb2b3e0f29609092a73eb033bb759a334595...694cdabd8bdb0f10b2cea11669e1bf5453eed0a6">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/upload-artifact&package-manager=github_actions&previous-version=4.1.0&new-version=4.2.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

fac26c57

Update labeler.yml (#141697) · d6a7f346

Michael Goderbauer authored Jan 18, 2024

* `flutter_web_plugins` didn't have a label that would make PRs show up for team triage, now they are assigned to the web team so they don't fall through the cracks
* `flutter_goldens_client` doesn't exist anymore, deleted
* `integration_test` PRs should be treated like `flutter_test` or `flutter_driver` PRs and get the `a: tests` label.

d6a7f346

Roll Flutter Engine from 75400c49fa0b to f4a4f046b173 (2 revisions) (#141800) · c92b634e

engine-flutter-autoroll authored Jan 18, 2024

https://github.com/flutter/engine/compare/75400c49fa0b...f4a4f046b173

2024-01-18 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Fall back to multi-context rendering on Firefox and Safari (flutter/engine#49572)
2024-01-18 godofredoc@google.com Use any mac machine available for orchestrator run. (flutter/engine#49845)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c92b634e

Reland "Remove hack from PageView." (#141533) · 2cd44857

Polina Cherkasova authored Jan 18, 2024

Fixes https://github.com/flutter/flutter/issues/141119
Original PR: https://github.com/flutter/flutter/pull/141138
Revert: https://github.com/flutter/flutter/pull/141479
Reason for revert: https://fusion2.corp.google.com/presubmit/597877179/OCL:597877179:BASE:597883748:1705084754455:88d992fc/targets
Fix: cl/599347719

2cd44857

ScaleGestureRecognizer pointerCount=2 for trackpad gestures (#140745) · e05d0dd2

Callum Moffat authored Jan 18, 2024

Now trackpad gestures will count as pointerCount=2 instead of 1. It makes it easier for people who want to have different behaviour for single-finger drag vs two-finger pan/zoom. Also fixed up `scale_test.dart` to verify `pointerCount` in more places.

Related: https://github.com/flutter/flutter/issues/13102
Fixes https://github.com/flutter/flutter/issues/140730

e05d0dd2

Roll Flutter Engine from de68e7612948 to 75400c49fa0b (2 revisions) (#141796) · b0c5fc91

engine-flutter-autoroll authored Jan 18, 2024

https://github.com/flutter/engine/compare/de68e7612948...75400c49fa0b

2024-01-18 103135467+sealesj@users.noreply.github.com Simplify osv-scanner workflow (flutter/engine#49807)
2024-01-18 skia-flutter-autoroll@skia.org Roll Skia from b1611add5939 to 1064eeedac09 (6 revisions) (flutter/engine#49867)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b0c5fc91

Run `flutter_gallery_ios__start_up` test on Mac-14 in staging (#141795) · c92b20ba
Victoria Ashworth authored Jan 18, 2024
```
Attempting to debug https://github.com/flutter/flutter/issues/141383.
```
c92b20ba

Roll Flutter Engine from d80fe1cb5854 to de68e7612948 (1 revision) (#141789) · 41cc84c0

engine-flutter-autoroll authored Jan 18, 2024

https://github.com/flutter/engine/compare/d80fe1cb5854...de68e7612948

2024-01-18 dnfield@google.com [Impeller] Eliminate some shared_ptr copying from EntityPass::Render (flutter/engine#49855)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

41cc84c0

Enable native compilation for windows-arm64 (#137618) · 54055920

Pierrick Bouvier authored Jan 18, 2024

It's now possible to natively compile a flutter app for
windows-arm64. Cross-compilation is not yet implemented.

Uses arm64 artifacts now available for Dart/Flutter.
Platform detection is based on Abi class, provided by Dart. Depending if
Dart is an arm64 or x64 binary, the Abi is set accordingly.
Initial bootstrap of dart artifacts (update_dart_sdk.ps1) is checking
PROCESSOR_ARCHITECTURE environment variable, which is the way to detect
host architecture on Windows.

This is available only for master channel (on other channels, it
fallbacks to windows-x64).

On windows-x64, it produces an x64 app. On windows-arm64, it produces an
arm64 app.

54055920

[github actions] Fix token issue on actions/checkout package (#141652) · 6e39eb75

Xilai Zhang authored Jan 18, 2024

revision 01/17: instead of removing actions/checkout, keep actions/checkout but remove the `token` field and add `persist-credentials` field. tested with a [mirror script](https://github.com/XilaiZhang/miscellaneous-side-project/blob/master/.github/workflows/easy-cp.yml) and creates [expected pull request](https://github.com/flutter/flutter/pull/141730)

Issue: when running github actions, the [tokens not found error](https://github.com/actions/checkout/issues/298) still happens( `Input required and not supplied: token`). We are not using fork PR or dependabot, and it's flaky when the well defined token isn't find in the inputs. We hit this error when invoking [market place actions/checkout](https://github.com/actions/checkout): [example failed run 1](https://github.com/flutter/flutter/actions/runs/7546108771/job/20543199801), [example failed run 2](https://github.com/flutter/flutter/actions/runs/7546141972/job/20543265842)

In this PR, Remove the dependency on marketplace actions  to make our workflow more reliable and less flaky.

other changes to remove actions/checkout dependency:
1. embedded token url for git push
Tried a number of ways and this is the only / best workaround I found to resolve [the notorious problem of pushing without ssh key](https://stackoverflow.com/questions/22147574/github-fatal-could-not-read-username-for-https-github-com-no-such-file-o). 
2. added back `--head`
`--head` is now needed to avoid [abort](https://github.com/XilaiZhang/miscellaneous-side-project/actions/runs/7548409479/job/20550397014)

Test: a [replicate of the actions file](https://github.com/XilaiZhang/miscellaneous-side-project/blob/master/.github/workflows/easy-cp.yml) is [tested](https://github.com/XilaiZhang/miscellaneous-side-project/actions/runs/7548448024/job/20550521341) on my personal repo, and it creates the [expected PR](https://github.com/flutter/flutter/pull/141647)

6e39eb75

Roll Flutter Engine from b75d6d80d813 to d80fe1cb5854 (2 revisions) (#141785) · c12d0068

engine-flutter-autoroll authored Jan 18, 2024

https://github.com/flutter/engine/compare/b75d6d80d813...d80fe1cb5854

2024-01-18 15619084+vashworth@users.noreply.github.com Update tests to Xcode 15 and iOS 17 simulator (flutter/engine#49833)
2024-01-18 skia-flutter-autoroll@skia.org Roll Skia from 7b3d788ba978 to b1611add5939 (1 revision) (flutter/engine#49863)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c12d0068

Revert "Native assets: roll deps" (#141748) · 1997bec6
Jesús S Guerrero authored Jan 18, 2024
```
b/320767653

Reverts flutter/flutter#141684
```
1997bec6

Deprecate M2 curves (#134417) · ef5beece

Pierre-Louis authored Jan 18, 2024

These have 1:1 replacements with a new name, introduced in
https://github.com/flutter/flutter/pull/129942

Land after https://github.com/flutter/packages/pull/4898

Part of https://github.com/flutter/flutter/issues/116525

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

ef5beece