Commits · b840a60d7d3fa8ec93bb1a0a4f3ad4467bfd634d · abdullh.alsoleman / Front-End

10 Jan, 2024 13 commits

Roll Flutter Engine from 3269fd84460d to b361a60ae224 (1 revision) (#141271) · b840a60d

engine-flutter-autoroll authored Jan 10, 2024

https://github.com/flutter/engine/compare/3269fd84460d...b361a60ae224

2024-01-10 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Migrate to Flutter mirrors for Google-owned Github repositories" (flutter/engine#49671)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b840a60d

Roll Flutter Engine from a5d446da5495 to 3269fd84460d (1 revision) (#141264) · b73b460e

engine-flutter-autoroll authored Jan 10, 2024

https://github.com/flutter/engine/compare/a5d446da5495...3269fd84460d

2024-01-10 skia-flutter-autoroll@skia.org Roll Skia from 51a0ad17b147 to 9271dcdade42 (1 revision) (flutter/engine#49669)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b73b460e

Roll Flutter Engine from 3ccf66bed335 to a5d446da5495 (2 revisions) (#141252) · 2df75b73

engine-flutter-autoroll authored Jan 10, 2024

https://github.com/flutter/engine/compare/3ccf66bed335...a5d446da5495

2024-01-10 skia-flutter-autoroll@skia.org Roll Dart SDK from d4b1939dffa6 to efd053daa2a6 (1 revision) (flutter/engine#49666)
2024-01-10 skia-flutter-autoroll@skia.org Roll Skia from ae30afc7b79a to 51a0ad17b147 (1 revision) (flutter/engine#49665)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2df75b73

Roll Flutter Engine from e57e418c02ae to 3ccf66bed335 (1 revision) (#141241) · 3d5b2009

engine-flutter-autoroll authored Jan 10, 2024

https://github.com/flutter/engine/compare/e57e418c02ae...3ccf66bed335

2024-01-10 skia-flutter-autoroll@skia.org Roll Skia from 2a77dffd384f to ae30afc7b79a (1 revision) (flutter/engine#49663)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3d5b2009

Roll Flutter Engine from 7e6f3d847e01 to e57e418c02ae (1 revision) (#141240) · b23cf316

engine-flutter-autoroll authored Jan 10, 2024

https://github.com/flutter/engine/compare/7e6f3d847e01...e57e418c02ae

2024-01-10 matanlurey@users.noreply.github.com Follow various best practices in `FlutterRenderer` (flutter/engine#49651)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b23cf316

Roll Flutter Engine from 1cf2e0a603c7 to 7e6f3d847e01 (1 revision) (#141237) · a1030024

engine-flutter-autoroll authored Jan 10, 2024

https://github.com/flutter/engine/compare/1cf2e0a603c7...7e6f3d847e01

2024-01-10 skia-flutter-autoroll@skia.org Roll Skia from 0e8023dc0a1a to 2a77dffd384f (1 revision) (flutter/engine#49662)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a1030024

Roll Flutter Engine from 32bbf8be8d2c to 1cf2e0a603c7 (1 revision) (#141232) · eeebee62

engine-flutter-autoroll authored Jan 10, 2024

https://github.com/flutter/engine/compare/32bbf8be8d2c...1cf2e0a603c7

2024-01-10 skia-flutter-autoroll@skia.org Roll Dart SDK from 727ea68c62d8 to d4b1939dffa6 (1 revision) (flutter/engine#49657)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

eeebee62

Roll Flutter Engine from 5b9d2132b7cd to 32bbf8be8d2c (1 revision) (#141229) · 3bcf779f

engine-flutter-autoroll authored Jan 10, 2024

https://github.com/flutter/engine/compare/5b9d2132b7cd...32bbf8be8d2c

2024-01-10 skia-flutter-autoroll@skia.org Roll Skia from 4ef1837c2958 to 0e8023dc0a1a (1 revision) (flutter/engine#49655)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3bcf779f

Roll Flutter Engine from 941f268fc8bb to 5b9d2132b7cd (1 revision) (#141228) · 9c3e6ef2

engine-flutter-autoroll authored Jan 10, 2024

https://github.com/flutter/engine/compare/941f268fc8bb...5b9d2132b7cd

2024-01-10 jacksongardner@google.com Refactor flutter.js to do dart2wasm bootstrapping and CanvasKit/Skwasm preloading. (flutter/engine#49037)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9c3e6ef2

Roll Flutter Engine from 542fea9edae4 to 941f268fc8bb (3 revisions) (#141224) · 92f2df56

engine-flutter-autoroll authored Jan 10, 2024

https://github.com/flutter/engine/compare/542fea9edae4...941f268fc8bb

2024-01-09 30870216+gaaclarke@users.noreply.github.com [Impeller] made sure to scale the blur radius by the effect transform (flutter/engine#49645)
2024-01-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Refactors RBE support" (flutter/engine#49654)
2024-01-09 zanderso@users.noreply.github.com Refactors RBE support (flutter/engine#49416)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

92f2df56

`NestedScrollView`'s outer scrollable jumping with `BouncingScrollPhysics` due... · 7efed85b

Igor Hnízdo authored Jan 10, 2024

`NestedScrollView`'s outer scrollable jumping with `BouncingScrollPhysics` due to `double` precision errors (#138319)

This PR fixes scrolling issues with `NestedScrollView` using the `BouncingScrollPhysics`. In one of the steps of the calculation, we can reach a state where the position of the inner scrollable is set to a `double` value that falls within `precisionErrorTolerance` of `0` but we were using `==` with `0` rather than checking for a precision. My posts in the linked issue show the current behavior, and how I reached to conclusion (the code in this PR). This PR only addresses the "jumping" of the outer scrollable.  

Fixes #136199

I have not finished a test for this since I have never done so and therefore have 0 experience writing tests in Flutter, so any help there would be appreciated. I am also not sure how to test double precision errors in general. I did run all the nested_scroll_view_tests.dart locally and there are no failures.

7efed85b

Roll Flutter Engine from 8c1501f3956d to 542fea9edae4 (1 revision) (#141217) · 34e8890e

engine-flutter-autoroll authored Jan 10, 2024

https://github.com/flutter/engine/compare/8c1501f3956d...542fea9edae4

2024-01-09 31859944+LongCatIsLooong@users.noreply.github.com Fix macOS text composing (flutter/engine#49314)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

34e8890e

Fix or except leaks. (#141081) · 0f2618ff
Polina Cherkasova authored Jan 10, 2024
```
Contributes to https://github.com/flutter/devtools/issues/6909.
```
0f2618ff

09 Jan, 2024 27 commits

Roll Flutter Engine from 693af0c699c5 to 8c1501f3956d (1 revision) (#141215) · e58f43fb

engine-flutter-autoroll authored Jan 09, 2024

https://github.com/flutter/engine/compare/693af0c699c5...8c1501f3956d

2024-01-09 matanlurey@users.noreply.github.com Make `shell/platform/android` IDE-friendly, and add documentation (flutter/engine#49612)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e58f43fb

TextStyle: In copyWith, stop ignoring debugLabel when receiver has none (#141141) · 8d2aca38

Chris Bobbe authored Jan 09, 2024

Fixes #141140.

This ensures that if you call `.copyWith` and pass a `debugLabel`, the `debugLabel` won't be ignored, even if the receiver (the TextStyle you're calling `.copyWith` on) doesn't have a `debugLabel`.

The debugLabel field was added in #12552. I skimmed the discussion there and didn't find anything indicating that the param was being ignored on purpose.

I added a test case that passes with the new code and fails with the old code.

8d2aca38

Roll Flutter Engine from a35e3b026e1d to 693af0c699c5 (5 revisions) (#141209) · 84e1086c

engine-flutter-autoroll authored Jan 09, 2024

https://github.com/flutter/engine/compare/a35e3b026e1d...693af0c699c5

2024-01-09 skia-flutter-autoroll@skia.org Roll Dart SDK from 721fccffc708 to 727ea68c62d8 (1 revision) (flutter/engine#49647)
2024-01-09 skia-flutter-autoroll@skia.org Roll Skia from 77534b672363 to 4ef1837c2958 (1 revision) (flutter/engine#49643)
2024-01-09 skia-flutter-autoroll@skia.org Roll Skia from 8c8be76a62c0 to 77534b672363 (1 revision) (flutter/engine#49641)
2024-01-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 6z4cZ6HUidtgmhvdk... to pUQrgMfXgU8RmLuL4... (flutter/engine#49640)
2024-01-09 bdero@google.com [Flutter GPU] Track HostBuffer emplacements by offset. (flutter/engine#49618)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 6z4cZ6HUidtg to pUQrgMfXgU8R

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

84e1086c

Replace deprecated `exists` in podhelper.rb (#141169) · 32fd2cbf

stuartmorgan authored Jan 09, 2024

The recently landed https://github.com/flutter/flutter/pull/140222 accidentally used the deprecated `exists?` instead of the non-deprecated `exist?` (which other code in this file is already, correctly, using).

Fixes https://github.com/flutter/flutter/issues/141167

32fd2cbf

Correctly handle null case in ProcessText.queryTextActions (#141205) · 0cef3f16

Kevin Moore authored Jan 09, 2024

Replace `as Map<Object?, Object?>` to handle nullable case
Fixes runtime issue in Wasm

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

0cef3f16

Add environment variable to leak tracking bots. (#141137) · 988d1a06
Polina Cherkasova authored Jan 09, 2024

988d1a06

Reapply "Dynamic view sizing" (#140165) (#140918) · 4534a24c

Michael Goderbauer authored Jan 09, 2024

This reverts commit
https://github.com/flutter/flutter/commit/d24c01bd0c41331bd17165e0173b24c5d05d7c0a.

The original change was reverted because it caused some apps to get
stuck on the splash screen on some phones.

An investigation determined that this was due to a rounding error.
Example: The device reports a physical size of 1008.0 x 2198.0 with a
dpr of 1.912500023841858. Flutter would translate that to a logical size
of 527.0588169589221 x 1149.2810314243163 and use that as the input for
its layout algorithm. Since the constraints here are tight, the layout
algorithm would determine that the resulting logical size of the root
render object must be 527.0588169589221 x 1149.2810314243163.
Translating this back to physical pixels by applying the dpr resulted in
a physical size of 1007.9999999999999 x 2198.0 for the frame. Android
now rejected that frame because it didn't match the expected size of
1008.0 x 2198.0 and since no frame had been rendered would never take
down the splash screen.

Prior to dynamically sized views, this wasn't an issue because we would
hard-code the frame size to whatever the requested size was.

Changes in this PR over the original PR:

* The issue has been fixed now by constraining the calculated physical
size to the input physical constraints which makes sure that we always
end up with a size that is acceptable to the operating system.
* The `ViewConfiguration` was refactored to use the slightly more
convenient `BoxConstraints` over the `ViewConstraints` to represent
constraints. Both essentially represent the same thing, but
`BoxConstraints` are more powerful and we avoid a couple of translations
between the two by translating the` ViewConstraints` from the
`FlutterView` to `BoxConstraints` directly when the `ViewConfiguration`
is created.

All changes over the original PR are contained in the second commit of
this PR.

Fixes b/316813075
Part of https://github.com/flutter/flutter/issues/134501.

4534a24c

Introduce new Form validation method (#135578) · 0c40f21f

SharbelOkzan authored Jan 09, 2024

Introduced `validateGranually` which, apart from announcing the errors to the UI, returns a `Map<Key, bool>` providing more granular validation details: The results of calling `validate` on each `FormField` and their corresponding widget keys.

* related issue: #135363

0c40f21f

Update `RouteObserver` example and fix an error thrown (#141166) · 536de5ed

Taha Tesser authored Jan 09, 2024

fixes [`RouteObserver` example throws an error](https://github.com/flutter/flutter/issues/141078)

### Description
This updates the `RouteObserver` example from snippet to Dartpad example and fixes the error when running the code snippet

536de5ed

Upgrade leak_tracker. (#141153) · 1f3103e5
Polina Cherkasova authored Jan 09, 2024

1f3103e5

[ci.yaml] Do not run packaging test on presubmit (#141192) · 51af82d3

Casey Hillers authored Jan 09, 2024

This test doesn't support presubmit as runs a separate git clone, which won't contain the presubmit hash.

Fixes https://github.com/flutter/flutter/issues/141188

51af82d3

Roll Flutter Engine from 036b39fa47fa to a35e3b026e1d (6 revisions) (#141191) · 88341867

engine-flutter-autoroll authored Jan 09, 2024

https://github.com/flutter/engine/compare/036b39fa47fa...a35e3b026e1d

2024-01-09 john@johnmccutchan.com Simplify PlatformViewRenderTarget interface (flutter/engine#49639)
2024-01-09 skia-flutter-autoroll@skia.org Roll Skia from 05039d6ed8d8 to 8c8be76a62c0 (3 revisions) (flutter/engine#49638)
2024-01-09 zanderso@users.noreply.github.com Skip flaky test on mac in http_disallow_http_connections_test.dart (flutter/engine#49635)
2024-01-09 john@johnmccutchan.com Resize the RenderTarget before creating and passing its Surface to the VirtualDisplay (flutter/engine#49619)
2024-01-09 103135467+sealesj@users.noreply.github.com Migrate to Flutter mirrors for Google-owned Github repositories (flutter/engine#49203)
2024-01-09 skia-flutter-autoroll@skia.org Roll Skia from ee263c34e03d to 05039d6ed8d8 (2 revisions) (flutter/engine#49636)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

88341867

Run tests on iOS 16 or iOS 17 (#141178) · 1ec9daa9
Victoria Ashworth authored Jan 09, 2024
```
Fixes https://github.com/flutter/flutter/issues/141177
```
1ec9daa9
Remove conditions that depend on order. (#141183) · 188d4d1f
Polina Cherkasova authored Jan 09, 2024

188d4d1f

Roll Flutter Engine from b3c8597df0e2 to 036b39fa47fa (1 revision) (#141179) · 7bf375b5

engine-flutter-autoroll authored Jan 09, 2024

https://github.com/flutter/engine/compare/b3c8597df0e2...036b39fa47fa

2024-01-09 skia-flutter-autoroll@skia.org Roll Skia from f9f73082740e to ee263c34e03d (3 revisions) (flutter/engine#49631)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7bf375b5

resolved the issue of indeterminate CircularProgressIndicator.adaptive on Darwin (#140947) · 83cf44ed
Nishant Kumar authored Jan 09, 2024
```
Fixes #140574

Passes the value from `CircularProgressIndicator` to the Cupertino version so that functionality is not lost on Apple devices.
```
83cf44ed

Roll Flutter Engine from 820645dbcc69 to b3c8597df0e2 (5 revisions) (#141175) · 126302df

engine-flutter-autoroll authored Jan 09, 2024

https://github.com/flutter/engine/compare/820645dbcc69...b3c8597df0e2

2024-01-09 skia-flutter-autoroll@skia.org Roll Skia from 665f7d51ef25 to f9f73082740e (1 revision) (flutter/engine#49630)
2024-01-09 skia-flutter-autoroll@skia.org Roll Skia from 360944e3175f to 665f7d51ef25 (2 revisions) (flutter/engine#49628)
2024-01-09 skia-flutter-autoroll@skia.org Roll Skia from 92b84715ba73 to 360944e3175f (2 revisions) (flutter/engine#49622)
2024-01-09 skia-flutter-autoroll@skia.org Roll Skia from 06404ed554e7 to 92b84715ba73 (1 revision) (flutter/engine#49620)
2024-01-09 skia-flutter-autoroll@skia.org Roll Dart SDK from e8aa66f435ae to 721fccffc708 (5 revisions) (flutter/engine#49616)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

126302df

Roll Packages from 5aef49b1c1d8 to 09205ca19bd2 (2 revisions) (#141173) · d2d32b58

engine-flutter-autoroll authored Jan 09, 2024

https://github.com/flutter/packages/compare/5aef49b1c1d8...09205ca19bd2

2024-01-09 stuartmorgan@google.com Re-land: Enable prefer_mixin and bump plugin_platform_interface to 2.1.7 (flutter/packages#5841)
2024-01-09 stuartmorgan@google.com [ci] Exclude quick_actions from Android emulators (flutter/packages#5847)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d2d32b58

[Android] Add custom system-wide text selection toolbar buttons for SelectableRegion (#141103) · 5f17badf

Bruno Leroux authored Jan 09, 2024

## Description

This PR adds custom system-wide text selection toolbar buttons on Android for `SelectableRegion` and `SelectionArea`.

https://github.com/flutter/flutter/pull/139738 adds those buttons for `EditableText` (which is used by `TextField` and `SelectableText` but not by `SelectionArea`).

## Related Issue

Step 5 for https://github.com/flutter/flutter/issues/139361

## Tests

Adds 2 tests.

5f17badf

Update Chips and `ChipTheme` tests and for Material 3 (#141022) · f7f437ce
Taha Tesser authored Jan 09, 2024
```
Updated unit tests for `Tooltip` to have M2 and M3 versions.

More info in #139076
```
f7f437ce
Update `chip_test.dart` tests for Material 3 (#140964) · 649877d2
Taha Tesser authored Jan 09, 2024
```
Updated unit tests for `Tooltip` to have M2 and M3 versions.

More info in #139076
```
649877d2

Fix spell check throws when text contains regex reserved characters (#140384) · 2e6aac6e

Bruno Leroux authored Jan 09, 2024

## Description

This PR fixes an issue related to the spell check implementation usage of Regex (searched text should be escaped).

## Related Issue

Fixes https://github.com/flutter/flutter/issues/136032.

## Tests

Adds 1 test.

2e6aac6e

Native assets support for Android Add2app (#140802) · b2ef2802

Daco Harkes authored Jan 09, 2024

Support for FFI calls with @Native external functions through Native assets on Android add to app. This enables bundling native code without any build-system boilerplate code.

For more info see:

*  https://github.com/flutter/flutter/issues/129757

## Implementation details for Android add2app

The `.so` files are bundled with the same mechanism that bundles `libapp.so`.

b2ef2802

Roll Flutter Engine from d13479968b8f to 820645dbcc69 (3 revisions) (#141152) · 29db9dbd

engine-flutter-autoroll authored Jan 09, 2024

https://github.com/flutter/engine/compare/d13479968b8f...820645dbcc69

2024-01-09 skia-flutter-autoroll@skia.org Roll Skia from e3af4a11007d to 06404ed554e7 (1 revision) (flutter/engine#49614)
2024-01-09 magder@google.com Roll buildroot to pick up iOS 12 (flutter/engine#49542)
2024-01-09 skia-flutter-autoroll@skia.org Roll Skia from f4626a2e3293 to e3af4a11007d (1 revision) (flutter/engine#49613)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

29db9dbd

Bump github/codeql-action from 3.22.11 to 3.23.0 (#141132) · a18ca800

dependabot[bot] authored Jan 09, 2024

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.22.11 to 3.23.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<p>Note that the only difference between <code>v2</code> and <code>v3</code> of the CodeQL Action is the node version they support, with <code>v3</code> running on node 20 while we continue to release <code>v2</code> to support running on node 16. For example <code>3.22.11</code> was the first <code>v3</code> release and is functionally identical to <code>2.22.11</code>. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>3.23.0 - 08 Jan 2024</h2>
<ul>
<li>We are rolling out a feature in January 2024 that will disable Python dependency installation by default for all users. This improves the speed of analysis while having only a very minor impact on results. You can override this behavior by setting <code>CODEQL_ACTION_DISABLE_PYTHON_DEPENDENCY_INSTALLATION=false</code> in your workflow, however we plan to remove this ability in future versions of the CodeQL Action. <a href="https://redirect.github.com/github/codeql-action/pull/2031">#2031</a></li>
<li>The CodeQL Action now requires CodeQL version 2.11.6 or later. For more information, see <a href="https://github.com/github/codeql-action/blob/main/#2227---16-nov-2023">the corresponding changelog entry for CodeQL Action version 2.22.7</a>. <a href="https://redirect.github.com/github/codeql-action/pull/2009">#2009</a></li>
</ul>
<h2>3.22.12 - 22 Dec 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.5. <a href="https://redirect.github.com/github/codeql-action/pull/2047">#2047</a></li>
</ul>
<h2>3.22.11 - 13 Dec 2023</h2>
<ul>
<li>[v3+ only] The CodeQL Action now runs on Node.js v20. <a href="https://redirect.github.com/github/codeql-action/pull/2006">#2006</a></li>
</ul>
<h2>2.22.10 - 12 Dec 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.4. <a href="https://redirect.github.com/github/codeql-action/pull/2016">#2016</a></li>
</ul>
<h2>2.22.9 - 07 Dec 2023</h2>
<p>No user facing changes.</p>
<h2>2.22.8 - 23 Nov 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.3. <a href="https://redirect.github.com/github/codeql-action/pull/2001">#2001</a></li>
</ul>
<h2>2.22.7 - 16 Nov 2023</h2>
<ul>
<li>Add a deprecation warning for customers using CodeQL version 2.11.5 and earlier. These versions of CodeQL were discontinued on 8 November 2023 alongside GitHub Enterprise Server 3.7, and will be unsupported by CodeQL Action v2.23.0 and later. <a href="https://redirect.github.com/github/codeql-action/pull/1993">#1993</a>
<ul>
<li>If you are using one of these versions, please update to CodeQL CLI version 2.11.6 or later. For instance, if you have specified a custom version of the CLI using the 'tools' input to the 'init' Action, you can remove this input to use the default version.</li>
<li>Alternatively, if you want to continue using a version of the CodeQL CLI between 2.10.5 and 2.11.5, you can replace <code>github/codeql-action/*@v2</code> by <code>github/codeql-action/*@v2.22.7</code> in your code scanning workflow to ensure you continue using this version of the CodeQL Action.</li>
</ul>
</li>
</ul>
<h2>2.22.6 - 14 Nov 2023</h2>
<ul>
<li>Customers running Python analysis on macOS using version 2.14.6 or earlier of the CodeQL CLI should upgrade to CodeQL CLI version 2.15.0 or later. If you do not wish to upgrade the CodeQL CLI, ensure that you are using Python version 3.11 or earlier, as CodeQL version 2.14.6 and earlier do not support Python 3.12. You can achieve this by adding a <a href="https://github.com/actions/setup-python"><code>setup-python</code></a> step to your code scanning workflow before the step that invokes <code>github/codeql-action/init</code>.</li>
<li>Update default CodeQL bundle version to 2.15.2. <a href="https://redirect.github.com/github/codeql-action/pull/1978">#1978</a></li>
</ul>
<h2>2.22.5 - 27 Oct 2023</h2>
<p>No user facing changes.</p>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/e5f05b81d5b6ff8cfa111c80c22c5fd02a384118"><code>e5f05b8</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2066">#2066</a> from github/update-v3.23.0-fd55bb0b0</li>
<li><a href="https://github.com/github/codeql-action/commit/48e7b8b751b457ccde050d587c85ce3defc30555"><code>48e7b8b</code></a> Update changelog for v3.23.0</li>
<li><a href="https://github.com/github/codeql-action/commit/fd55bb0b00b5802fdceb93f76b498f105e0edbe1"><code>fd55bb0</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2065">#2065</a> from github/henrymercer/further-run-queries-cleanup</li>
<li><a href="https://github.com/github/codeql-action/commit/838a0229829cd641a4a60fc3c95e12a673b5fcdb"><code>838a022</code></a> Clean up running queries workflow now that the queries are determined by the CLI</li>
<li><a href="https://github.com/github/codeql-action/commit/8516954d603e47049b34f3da4dfac83009fcd450"><code>8516954</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2062">#2062</a> from github/henrymercer/remove-action-config-parsing</li>
<li><a href="https://github.com/github/codeql-action/commit/a533ec62b3aeb59c7467569705b9edaca021df43"><code>a533ec6</code></a> Merge branch 'main' into henrymercer/remove-action-config-parsing</li>
<li><a href="https://github.com/github/codeql-action/commit/08ae9bf4d0d441bd9dcf6c2d80742c9fd2bf3cf0"><code>08ae9bf</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2063">#2063</a> from github/henrymercer/remove-ml-powered-queries-repo</li>
<li><a href="https://github.com/github/codeql-action/commit/58ff74adc38e087ca7f6670dfe24cd319aea5f11"><code>58ff74a</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2031">#2031</a> from github/rasmuswl/no-dep-inst-default</li>
<li><a href="https://github.com/github/codeql-action/commit/9926570d4c48228ba780bd02a18a4e05dbb1bbe7"><code>9926570</code></a> Generate JS</li>
<li><a href="https://github.com/github/codeql-action/commit/2e27b3c56bdb1864f5dd58da25fee61f6cd7bb81"><code>2e27b3c</code></a> Create helper <code>isPythonDependencyInstallationDisabled</code></li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/b374143c1149a9115d881581d29b8390bbcbb59c...e5f05b81d5b6ff8cfa111c80c22c5fd02a384118">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=3.22.11&new-version=3.23.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

a18ca800

Shift mac Pixel 7 Pro tests to prod (#141142) · e94a2c04
Zachary Anderson authored Jan 09, 2024
```
Related https://github.com/flutter/flutter/issues/140893
```
e94a2c04

Roll Flutter Engine from 3f0f8913169e to d13479968b8f (2 revisions) (#141147) · 7a5cc2a0

engine-flutter-autoroll authored Jan 09, 2024

https://github.com/flutter/engine/compare/3f0f8913169e...d13479968b8f

2024-01-09 skia-flutter-autoroll@skia.org Roll Skia from cb8e8fa79132 to f4626a2e3293 (3 revisions) (flutter/engine#49610)
2024-01-09 bdero@google.com [Impeller] Document mip bias. (flutter/engine#49602)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7a5cc2a0