1. 13 Nov, 2015 26 commits
  2. 12 Nov, 2015 14 commits
    • Ian Hickson's avatar
      Merge pull request #346 from Hixie/analyze-bugs · 91fb1f13
      Ian Hickson authored
      Make the analyzer actually work.
      91fb1f13
    • Hixie's avatar
      Make the analyzer actually work. · 8ab229f8
      Hixie authored
      Turns out that ignoring all error lines that match the empty string is a
      poor way to go.
      
      Also, we have to update all the example packages now too, since we
      analyze them. So just have travis use our update script.
      
      Also, remove flutter_tools' old travis stuff. It's now part of a bigger
      repo.
      
      Also, make travis use the dev Dart SDK, since we need the new analyzer.
      Stable is way too out of date, e.g. it still complains about libraries
      not having names and mixins using 'super', and the strong mode hints are
      even more aggressive than on dev.
      8ab229f8
    • Ian Hickson's avatar
      Merge pull request #341 from Hixie/analyzer-trash · 5109dd51
      Ian Hickson authored
      Delete analyzer temporary directories
      5109dd51
    • Devon Carew's avatar
      49b7fee4
    • Hixie's avatar
      Delete analyzer temporary directories · 4a5713ac
      Hixie authored
      4a5713ac
    • Ian Hickson's avatar
      Merge pull request #340 from Hixie/fewer-constructor-tearoffs · 05d94b5a
      Ian Hickson authored
      Remove constructor tear-offs
      05d94b5a
    • Hixie's avatar
      Remove constructor tear-offs · 9c6e96a3
      Hixie authored
      Some of our workflows have no way to silence analyzer warnings, and the
      analyzer doesn't yet support constructor tear-offs, so pretend that we
      can't use them for now.
      9c6e96a3
    • Ian Hickson's avatar
      Merge pull request #332 from Hixie/flutter-analyze · 4a71f382
      Ian Hickson authored
      flutter analyze command
      4a71f382
    • Adam Barth's avatar
      Merge pull request #336 from abarth/builder_index · 7939ec5d
      Adam Barth authored
      ItemBuilder should also get the index of the item
      7939ec5d
    • Hixie's avatar
      flutter analyze command · a0227cab
      Hixie authored
      Other changes in this patch:
      - Make the 'flutter' tool say "Updating flutter tool..." when it calls
        pub get, to avoid confusion about what the pub get output is about.
      - Make the bash flutter tool call pub get when the revision has
        changed. (This was already happening on Windows.)
      - Fix a raft of bugs found by the analyzer.
      - Fix some style nits in various bits of code that happened to be near
        things the analyzer noticed.
      - Remove the logic in "flutter test" that would run "pub get", since
        upon further reflexion it was determined it didn't work anyway.
        We'll probably have to add better diagnostics here and say to run the
        updater script.
      - Remove the native velocity tracker script, since it was testing code
        that has since been removed.
      
      Notes on ignored warnings:
      - We ignore warnings in any packages that are not in the Flutter repo or
        in the author's current directory.
      - We ignore various irrelevant Strong Mode warnings. We still enable
        strong mode because even though it's not really relevant to our needs,
        it does (more or less accidentally) catch a few things that are
        helpful to us.
      - We allow CONSTANTS_LIKE_THIS, since we get some of those from other
        platforms that we are copying for sanity and consistency.
      - We allow one-member abstract classes since we have a number of them
        where it's perfectly reasonable.
      - We unfortunately still ignore warnings in mojom.dart autogenerated
        files. We should really fix those but that's a separate patch.
      - We verify the actual source file when we see the 'Name non-constant
        identifiers using lowerCamelCase.' lint, to allow one-letter variables
        that use capital letters (e.g. for physics expressions) and to allow
        multiple-underscore variable names.
      - We ignore all errors on lines that contain the following magic
        incantation and a "#" character:
          // analyzer doesn't like constructor tear-offs
      - For all remaining errors, if the line contains a comment of the form
          // analyzer says "..."
        ...then we ignore any errors that have that "..." string in them.
      a0227cab
    • Adam Barth's avatar
      ItemBuilder should also get the index of the item · 0259ad81
      Adam Barth authored
      This seems useful for numbering the entries in the list, for example.
      
      Fixes #328
      0259ad81
    • Adam Barth's avatar
      Merge pull request #334 from abarth/rev_engine · 0758fea1
      Adam Barth authored
      Update to a newer sky_engine and sky_services
      0758fea1
    • Adam Barth's avatar
      Update to a newer sky_engine and sky_services · 1bc06c80
      Adam Barth authored
      1bc06c80
    • Adam Barth's avatar
      Merge pull request #331 from abarth/flutter_upgrade · c428c825
      Adam Barth authored
      Add a `flutter upgrade` command
      c428c825