1. 29 May, 2019 3 commits
    • stuartmorgan's avatar
      Use vswhere to find Visual Studio (#33448) · aecf053e
      stuartmorgan authored
      Rather than hard-coding a set of locations to check, use vswhere (which
      is installed by VS 2017 and later), and construct the vcvars64.bat path
      relative to that. This will allow Windows builds to work without special
      configuration for people who have VS installed at a custom path.
      
      Also adds error logging with different messages for each failure point,
      so that rather than the not-very-informative 'failed to find
      vcvars64.bat' message, the failure will provide feedback about what to
      do.
      
      This is an interim solution; later this will be replaced by a
      VisualStudio class with associated validator to match the structure of
      the other toolchains.
      
      Fixes #33249
      aecf053e
    • stuartmorgan's avatar
      Wrap Windows build invocation in a batch script (#33443) · e1a784ae
      stuartmorgan authored
      Invoking msbuild with runInShell makes handling path escaping more
      error-prone, and substantially increases the chances of running into
      maximum path limits. This replaces the direct call with a .bat wrapper
      that calls vsvars64.bat then msbuild, and uses relative paths within the
      script to keep command lengths short.
      
      Fixes https://github.com/flutter/flutter/issues/32792
      e1a784ae
    • Jonah Williams's avatar
      c56b4551
  2. 28 May, 2019 13 commits
  3. 27 May, 2019 2 commits
  4. 26 May, 2019 2 commits
  5. 25 May, 2019 3 commits
    • stuartmorgan's avatar
      Implement macOS support in `flutter doctor` (#33277) · 81c38b22
      stuartmorgan authored
      Splits Xcode validation out of the iOS validator and into a stand-alone
      validator, and groups the CocoaPods validator with that top-level
      validator instead of the iOS validator. iOS now validates only the
      iOS-specific tools (e.g., ideviceinstaller).
      
      Reorganizes many of the associated clases so that those that are used by
      both macOS and iOS live in macos/ rather than ios/. Moves some
      validators to their own files as part of the restructuring.
      
      This is the macOS portion of #31368
      81c38b22
    • Chris Bracken's avatar
      Americanise spellings (#33323) · 156b4220
      Chris Bracken authored
      Updates documentation and non-public API to use American spellings for
      consistency with the rest of the codebase.
      
      No changes to behaviour... other than how it's spelt.
      156b4220
    • Chris Bracken's avatar
      Correct typos (#33322) · 4d992320
      Chris Bracken authored
      Corects a bnuch of typeos throuhgout teh Fluter codebsae.
      
      Made use of the `misspell` tool:
      https://github.com/client9/misspell
      4d992320
  6. 24 May, 2019 9 commits
  7. 23 May, 2019 8 commits