Commits · a4f7906692ffeefe13b4a8f1db2b04d4a6d644d2 · abdullh.alsoleman / Front-End

26 Jul, 2023 3 commits

Reorders menu item button shortcuts on Mac-like platforms (#129309) · a4f79066

Caffeinix authored Jul 26, 2023

The Apple Human Interface Guidelines give a specific ordering of the symbols
used as modifier keys in menu shortcuts. These guidelines are encoded into
the native Cocoa or UIKit menu classes, and are intended to ensure that symbols
are always aligned into columns of like symbols and do not move around in the
case of dynamic menu items (for example, holding Option will transform certain
menu items into different versions that take the Option key, so the Option key
symbol appears to the left of most other symbols to avoid reordering).

The Material spec says to use symbols for modifier keys on Mac and iOS, as this
is what users there are familiar with. It stands to reason that we should
follow the platform guidelines fully, so this changes the MenuItemButton class
to honor the HIG-compliant symbol ordering on Mac and iOS.

Fixed: #129308

a4f79066

Roll Flutter Engine from 9e00c11eb519 to db711f14842b (3 revisions) (#131307) · 76fe7e86

engine-flutter-autoroll authored Jul 26, 2023

https://github.com/flutter/engine/compare/9e00c11eb519...db711f14842b

2023-07-26 matanlurey@users.noreply.github.com [Impeller] ToColor should produce a DlColor, not SkColor. (flutter/engine#43987)
2023-07-26 skia-flutter-autoroll@skia.org Roll ANGLE from b0b71d59391c to 84f5295c9782 (3 revisions) (flutter/engine#44025)
2023-07-25 smartercallum@gmail.com Uncap framerate for `iOSAppOnMac` (flutter/engine#43840)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

76fe7e86

Ignore unused parameters in snippet code (#131068) · aab5747f

Sam Rawlins authored Jul 26, 2023

Add `unused_element_parameter` to the codes ignored while analyzing snippets.

Fixes https://github.com/flutter/flutter/issues/131067

aab5747f

25 Jul, 2023 18 commits

Roll Flutter Engine from 3fff7316dc8d to 9e00c11eb519 (1 revision) (#131299) · 548aa6fa

engine-flutter-autoroll authored Jul 25, 2023

https://github.com/flutter/engine/compare/3fff7316dc8d...9e00c11eb519

2023-07-25 skia-flutter-autoroll@skia.org Roll ANGLE from 2d5fb09d7f0a to b0b71d59391c (2 revisions) (flutter/engine#44009)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

548aa6fa

Add example for locking screen orientation in a letterboxing environment (#131266) · efa69ba9

Dan Field authored Jul 25, 2023

Android may choose to letterbox applications that lock orientation. This gets particularly bad on foldable devices, where a developer may want to lock orientation when the devices is folded and unlock when unfolded. However, if the app is letterboxed when unfolded, the `MediaQuery.of(context).size` will never report the full display size, only the letterboxed window size. This may result in an application getting "stuck" in portrait mode.

/cc @TytaniumDev

efa69ba9

Update BottomAppBar and BottomAppBarTheme tests for M3 (#130983) · eb489122

Bruno Leroux authored Jul 25, 2023

This PR updates `BottomAppBar` and `BottomAppBarTheme` tests for M3 migration.

More info in https://github.com/flutter/flutter/issues/127064

- Some tests are M2 or M3 only.
- Added several M3 tests.
- One golden change.

eb489122

Roll Flutter Engine from f5fbfa859b63 to 3fff7316dc8d (4 revisions) (#131286) · 147e12d1

engine-flutter-autoroll authored Jul 25, 2023

https://github.com/flutter/engine/compare/f5fbfa859b63...3fff7316dc8d

2023-07-25 skia-flutter-autoroll@skia.org Roll Skia from 7cec4e4e6f6e to 12d41b6f66ed (2 revisions) (flutter/engine#44008)
2023-07-25 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 8662af7d9aa3 to 61ab5422fb7b (12 revisions) (flutter/engine#44007)
2023-07-25 skia-flutter-autoroll@skia.org Roll Skia from eb5b5bc4fb86 to 7cec4e4e6f6e (1 revision) (flutter/engine#44003)
2023-07-25 kjlubick@users.noreply.github.com Reland "Remove more calls to SkCanvas::flush() and SkSurface::flush()" (flutter/engine#43965)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

147e12d1

Add Sabin Neupane to AUTHORS (#131237) · 0a092daa
Sabin Neupane authored Jul 25, 2023
```
Reference: [author:sabin26](https://github.com/flutter/flutter/issues?q=author%3Asabin26)
```
0a092daa

Roll Packages from 8028cafa1f0c to 406eac1ad976 (4 revisions) (#131285) · fb7a763c

engine-flutter-autoroll authored Jul 25, 2023

https://github.com/flutter/packages/compare/8028cafa1f0c...406eac1ad976

2023-07-25 engine-flutter-autoroll@skia.org Roll Flutter from d7ed5dc2 to 9def8f6b (21 revisions) (flutter/packages#4561)
2023-07-25 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android][webview_flutter_wkwebview] Fixes bug where `PlatformWebViewWidget` doesn't rebuild when the controller changes (flutter/packages#4533)
2023-07-24 stuartmorgan@google.com [ci] Enable Android emulator-based tests (flutter/packages#4494)
2023-07-24 rexios@rexios.dev [google_maps_flutter_web] Options to disable tilt controls and configure gesture handling (flutter/packages#3258)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fb7a763c

Roll Flutter Engine from 0a5c6cdd5d02 to f5fbfa859b63 (8 revisions) (#131283) · 35a6fc8a

engine-flutter-autoroll authored Jul 25, 2023

https://github.com/flutter/engine/compare/0a5c6cdd5d02...f5fbfa859b63

2023-07-25 jonahwilliams@google.com [Impeller] round scale for glyph atlas cache to 2 decimal places. (flutter/engine#43752)
2023-07-25 skia-flutter-autoroll@skia.org Roll ANGLE from 7ae6458b664f to 2d5fb09d7f0a (2 revisions) (flutter/engine#44002)
2023-07-25 skia-flutter-autoroll@skia.org Roll Skia from 04ab62b4f8c9 to eb5b5bc4fb86 (2 revisions) (flutter/engine#44001)
2023-07-25 skia-flutter-autoroll@skia.org Roll ANGLE from e8c8c5651223 to 7ae6458b664f (1 revision) (flutter/engine#43999)
2023-07-25 bdero@google.com [Impeller] Use basis of effect transform in MatrixFilter. (flutter/engine#43990)
2023-07-25 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from DO73K2Twew-a51xHm... to 0StTjIqUxGkc3nOWT... (flutter/engine#43996)
2023-07-25 skia-flutter-autoroll@skia.org Roll ANGLE from 1b17c91e4231 to e8c8c5651223 (2 revisions) (flutter/engine#43997)
2023-07-25 skia-flutter-autoroll@skia.org Roll Skia from 81ea617ee386 to 04ab62b4f8c9 (1 revision) (flutter/engine#43994)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from DO73K2Twew-a to 0StTjIqUxGkc

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

35a6fc8a

🚀

Expose `scrollControlDisabledMaxHeightRatio` to the modal bottom sheet (#129688) · 9f374f12

Alex Li authored Jul 25, 2023

Adding the `scrollControlDisabledMaxHeightRatio` parameter for modal bottom sheet widgets, and using the default value `9.0 / 16.0` to avoid breaking.

Resolves #129690.

9f374f12

Revert "Proposal to add barrier configs for showDatePicker, showTimePicker and... · 300c5d82

Loïc Sharma authored Jul 25, 2023

Revert "Proposal to add barrier configs for showDatePicker, showTimePicker and showAboutDialog." (#131278)

Reverts flutter/flutter#130484. /cc @ronnnnn

Example failure: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20framework_tests_libraries/12185/overview

<details>
<summary>Failure logs...</summary>

```
04:51 +5379 ~18: /Volumes/Work/s/w/ir/x/w/flutter/packages/flutter/test/material/about_test.dart: Barrier dismissible Barrier is dismissible with default parameter                                    
âââ¡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK âââââââââââââââââââââââââââââââââââââââââââââââââââââ
The following TestFailure was thrown running a test:
Expected: <1>
  Actual: <2>

When the exception was thrown, this was the stack:
#4      main.<anonymous closure>.<anonymous closure> (file:///Volumes/Work/s/w/ir/x/w/flutter/packages/flutter/test/material/about_test.dart:776:7)
<asynchronous suspension>
#5      testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:165:15)
<asynchronous suspension>
#6      TestWidgetsFlutterBinding._runTestBody (package:flutter_test/src/binding.dart:1008:5)
<asynchronous suspension>
<asynchronous suspension>
(elided one frame from package:stack_trace)

This was caught by the test expectation on the following line:
  file:///Volumes/Work/s/w/ir/x/w/flutter/packages/flutter/test/material/about_test.dart line 776
The test description was:
  Barrier is dismissible with default parameter
ââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââ

04:51 +5379 ~18 -1: /Volumes/Work/s/w/ir/x/w/flutter/packages/flutter/test/material/about_test.dart: Barrier dismissible Barrier is dismissible with default parameter [E]                             
  Test failed. See exception logs above.
  The test description was: Barrier is dismissible with default parameter
  
To run this test again: /Volumes/Work/s/w/ir/x/w/flutter/bin/cache/dart-sdk/bin/dart test /Volumes/Work/s/w/ir/x/w/flutter/packages/flutter/test/material/about_test.dart -p vm --plain-name 'Barrier dismissible Barrier is dismissible with default parameter'
```

</details>

300c5d82

Roll Flutter Engine from 036c58f79307 to 0a5c6cdd5d02 (1 revision) (#131256) · 2da3bdd4

engine-flutter-autoroll authored Jul 25, 2023

https://github.com/flutter/engine/compare/036c58f79307...0a5c6cdd5d02

2023-07-25 skia-flutter-autoroll@skia.org Roll ANGLE from 2d999f744809 to 1b17c91e4231 (1 revision) (flutter/engine#43993)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2da3bdd4

Fix `RawChip` doesn't use `ChipTheme.showCheckmark` value (#131257) · 62adfcf7

Taha Tesser authored Jul 25, 2023

fixes [`RawChip` doesn't use `ChipThemeData.showCheckmark` value](https://github.com/flutter/flutter/issues/119163)

### Description

`RawChip.showCheckmark` is nullable yet the constructor falsely assigns a default which breaks `ChipTheme` support. This PR removes the falsely assigned default value.

### Code sample

<details> 
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(useMaterial3: true,
        chipTheme: const ChipThemeData(
          showCheckmark: false,
        )
      ),
      home: const Example(),
    );
  }
}

class Example extends StatelessWidget {
  const Example({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Sample'),
      ),
      body: Center(
        child: Row(
          mainAxisAlignment: MainAxisAlignment.spaceEvenly,
          children: <Widget>[
            const RawChip(
              selected: true,
              label: Text('RawChip'),
            ),
            FilterChip(
              selected: true,
              label: const Text('RawChip'), onSelected: (bool value) {  },
            ),
          ],
        ),
      ),
    );
  }
}

``` 
	
</details>

### Before
![before](https://github.com/flutter/flutter/assets/48603081/c8050c28-d988-4c72-8e0a-6455aa02d119)

### After

![after](https://github.com/flutter/flutter/assets/48603081/d5e83e81-6c12-4594-a2fd-8f113d6c9b54)

62adfcf7

Proposal to add barrier configs for showDatePicker, showTimePicker and showAboutDialog. (#130484) · 9def8f6b

Seiya Kokushi authored Jul 25, 2023

### Overview

Add `barrierDismissible`, `barrierColor` and `barrierLabel` parameters to  `showDatePicker`, `showTimePicker` and `showAboutDialog` which calls `showDialog` internally.
We can change these parameters with `showDialog` and Dialog widgets (like `DatePickerDialog`, `TimePickerDialog` or `AboutDialog`) directly. But, I think it is prefer to provide interfaces same as `showDialog` to keep application wide unified looks if it is used internally.

Fixes #130971

9def8f6b

Roll Flutter Engine from a7a842ee9ccd to 036c58f79307 (1 revision) (#131244) · c8b9b15e

engine-flutter-autoroll authored Jul 25, 2023

https://github.com/flutter/engine/compare/a7a842ee9ccd...036c58f79307

2023-07-25 skia-flutter-autoroll@skia.org Roll Skia from 1d55f968ca23 to 81ea617ee386 (1 revision) (flutter/engine#43992)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c8b9b15e

Roll Flutter Engine from 3baca2fe55c8 to a7a842ee9ccd (1 revision) (#131243) · e8e10b14

engine-flutter-autoroll authored Jul 25, 2023

https://github.com/flutter/engine/compare/3baca2fe55c8...a7a842ee9ccd

2023-07-25 skia-flutter-autoroll@skia.org Roll Skia from 4bfaf9944a68 to 1d55f968ca23 (1 revision) (flutter/engine#43991)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e8e10b14

Roll Flutter Engine from 9a0192d965e0 to 3baca2fe55c8 (1 revision) (#131241) · 01887663

engine-flutter-autoroll authored Jul 25, 2023

https://github.com/flutter/engine/compare/9a0192d965e0...3baca2fe55c8

2023-07-25 skia-flutter-autoroll@skia.org Roll Skia from e99aea2cffef to 4bfaf9944a68 (2 revisions) (flutter/engine#43989)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

01887663

Roll Flutter Engine from ceb2674e82b4 to 9a0192d965e0 (3 revisions) (#131230) · 0733c96e

engine-flutter-autoroll authored Jul 25, 2023

https://github.com/flutter/engine/compare/ceb2674e82b4...9a0192d965e0

2023-07-25 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from hUgYN9tEps515M1lg... to DO73K2Twew-a51xHm... (flutter/engine#43981)
2023-07-25 skia-flutter-autoroll@skia.org Roll Skia from 4554d1b35b6e to e99aea2cffef (2 revisions) (flutter/engine#43980)
2023-07-25 bdero@google.com [Impeller] Skip rect clips that do nothing. (flutter/engine#43948)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from hUgYN9tEps51 to DO73K2Twew-a

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0733c96e

Roll Flutter Engine from 4fded78e5a01 to ceb2674e82b4 (2 revisions) (#131229) · 9c6ee77f

engine-flutter-autoroll authored Jul 25, 2023

https://github.com/flutter/engine/compare/4fded78e5a01...ceb2674e82b4

2023-07-24 jonahwilliams@google.com [Impeller] presentKHR from background worker. (flutter/engine#43976)
2023-07-24 bdero@google.com Revert "[Impeller] Fix MatrixFilter multiplication ordering for subpasses." (flutter/engine#43978)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9c6ee77f

Roll Flutter Engine from ff02fa72acce to 4fded78e5a01 (2 revisions) (#131225) · b1a25bd4

engine-flutter-autoroll authored Jul 25, 2023

https://github.com/flutter/engine/compare/ff02fa72acce...4fded78e5a01

2023-07-24 skia-flutter-autoroll@skia.org Roll Skia from 6c219acc30a5 to 4554d1b35b6e (4 revisions) (flutter/engine#43973)
2023-07-24 bdero@google.com [Impeller] Fix MatrixFilter multiplication ordering for subpasses. (flutter/engine#43943)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b1a25bd4

24 Jul, 2023 19 commits

Roll Flutter Engine from a489c7496268 to ff02fa72acce (1 revision) (#131221) · e06c0238

engine-flutter-autoroll authored Jul 24, 2023

https://github.com/flutter/engine/compare/a489c7496268...ff02fa72acce

2023-07-24 233583+mossmana@users.noreply.github.com Replace deprecated [UIScreen mainScreen] in FlutterViewController.mm and FlutterViewControllerTest.mm (flutter/engine#43690)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e06c0238

Roll Flutter Engine from 815b97157dc7 to a489c7496268 (3 revisions) (#131218) · 660ce07b

engine-flutter-autoroll authored Jul 24, 2023

https://github.com/flutter/engine/compare/815b97157dc7...a489c7496268

2023-07-24 skia-flutter-autoroll@skia.org Roll Skia from 99e8dc51ba53 to 6c219acc30a5 (4 revisions) (flutter/engine#43970)
2023-07-24 ian@hixie.ch add ColorFilter.toString to web_ui (flutter/engine#43874)
2023-07-24 skia-flutter-autoroll@skia.org Roll ANGLE from 5e21d7f02425 to 2d999f744809 (1 revision) (flutter/engine#43968)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

660ce07b

Roll Flutter Engine from 2b8d83fa20e3 to 815b97157dc7 (5 revisions) (#131214) · 2efd0719

engine-flutter-autoroll authored Jul 24, 2023

https://github.com/flutter/engine/compare/2b8d83fa20e3...815b97157dc7

2023-07-24 findyou795@gmail.com Fix missing dispose VirtualDisplayController (flutter/engine#43807)
2023-07-24 jonahwilliams@google.com [Impeller] provide cull rect to Canvas in GL/Vulakn impeller backend. (flutter/engine#43961)
2023-07-24 bdero@google.com [Impeller] Fix clip pipeline validation failure; add dedicated clip shaders. (flutter/engine#43946)
2023-07-24 skia-flutter-autoroll@skia.org Roll ANGLE from e28575f66ae5 to 5e21d7f02425 (4 revisions) (flutter/engine#43964)
2023-07-24 skia-flutter-autoroll@skia.org Roll Skia from a56bc23bfec7 to 99e8dc51ba53 (5 revisions) (flutter/engine#43963)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2efd0719

Use toStringAsFixed in DecorationImage.toString (#131026) · 8a01c9b7
Ian Hickson authored Jul 24, 2023
```
This makes the output less sensitive on JS int vs double shenanigans.
```
8a01c9b7

Roll Flutter Engine from aa876f6bec69 to 2b8d83fa20e3 (3 revisions) (#131207) · c53cfc55

engine-flutter-autoroll authored Jul 24, 2023

https://github.com/flutter/engine/compare/aa876f6bec69...2b8d83fa20e3

2023-07-24 zanderso@users.noreply.github.com Revert "Remove more calls to SkCanvas::flush() and SkSurface::flush()" (flutter/engine#43957)
2023-07-24 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from A02P1GsGg001-Mpn3... to DOxjABQZ-mA_9Lllw... (flutter/engine#43953)
2023-07-24 kjlubick@users.noreply.github.com Remove more calls to SkCanvas::flush() and SkSurface::flush() (flutter/engine#43902)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from A02P1GsGg001 to DOxjABQZ-mA_

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c53cfc55

Fix M3 TimePicker dial background uses incorrect color (#131045) · 5554b0ee

Taha Tesser authored Jul 24, 2023

fixes [Material3: TimePicker clock dial use wrong spec color and its web spec has a mistake](https://github.com/flutter/flutter/issues/118657)

### Description 

This PR fixes the default color used for the Material 3 dial background.

### Code sample

<details> 
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    final ThemeData theme = ThemeData(useMaterial3: true);

    return MaterialApp(
      debugShowCheckedModeBanner: false,
      // theme: theme,
      theme: theme.copyWith(
        colorScheme: theme.colorScheme.copyWith(
          surfaceVariant: const Color(0xffffbf00),
        ),
      ),
      home: const Example(),
    );
  }
}

class Example extends StatelessWidget {
  const Example({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Sample'),
      ),
      body: Center(
        child: ElevatedButton(
          onPressed: () {
            showTimePicker(
              context: context,
              initialTime: TimeOfDay.now(),
            );
          },
          child: const Text('Open Time Picker'),
        ),
      ),
    );
  }
}
``` 
	
</details>

### Default dial background color 
| Before | After |
| --------------- | --------------- |
| <img src="https://github.com/flutter/flutter/assets/48603081/59514586-60c6-489f-b024-f659a26fa1e7"  /> | <img src="https://github.com/flutter/flutter/assets/48603081/75c3c360-df2b-47c8-8187-136ff6d963b6"  /> |

### Custom color scheme
| Before | After |
| --------------- | --------------- |
| <img src="https://github.com/flutter/flutter/assets/48603081/666dd2fc-7ee2-4268-9af0-923019adfccd"  /> | <img src="https://github.com/flutter/flutter/assets/48603081/f32dc39e-a43f-4a63-a6e4-9df479b723ed"  /> |

5554b0ee

Fix floating SnackBar throws when FAB is on the top (#129274) · 97e0a058

Bruno Leroux authored Jul 24, 2023

## Description

This PR updates how a floating snack bar is positionned when a `Scaffold` defines a FAB with `Scaffold.floatingActionButtonLocation` sets to one of the top locations.

**Before this PR:**
- When a FAB location is set to the top of the `Scaffold`, a floating `SnackBar` can't be displayed and an assert throws in debug mode.

**After this PR:**
- When a FAB location is set to the top of the `Scaffold`, a floating `SnackBar` will be displayed at the bottom of the screen, above a `NavigationBar` for instance (the top FAB is ignored when computing the floating snack bar position).

![image](https://github.com/flutter/flutter/assets/840911/08fcee6c-b286-4749-ad0b-ba09e653bd94)

## Motivation

This is a edge case related to a discrepancy between the Material spec and the Flutter `Scaffold` customizability:
- Material spec states that a floating `SnackBar` should be displayed above a FAB. But, in Material spec, FABs are expected to be on the bottom.
- Since https://github.com/flutter/flutter/issues/51465, Flutter `Scaffold` makes it valid to show a FAB on the top of the `Scaffold`.

## Related Issue

fixes https://github.com/flutter/flutter/issues/128150

## Tests

Adds 1 test.

97e0a058

Update link to unbounded constraints error (#131205) · 283437a2
Michael Goderbauer authored Jul 24, 2023
```
Fixes https://github.com/flutter/flutter/issues/130805.
```
283437a2

Optimize SliverMainAxisGroup/SliverCrossAxisGroup paint function (#129310) · 8a37b8ba

Tae Hyung Kim authored Jul 24, 2023

This PR changes the paint functions for SliverMainAxisGroup and SliverCrossAxisGroup so that only visible slivers are painted.

Fixes https://github.com/flutter/flutter/issues/129214.

8a37b8ba

[DropdownMenu] Close menu after editing is complete (#130710) · c65cab8f

Sabin Neupane authored Jul 24, 2023

Fixes: #130674 

Before: The dropdown menu was not closed if empty text was provided

After: The dropdown menu is closed even if empty text is provided

https://github.com/flutter/flutter/assets/61322712/fccac501-9fca-4f60-8a94-abfc50552ec9

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

c65cab8f

Reduce usage of testUsingContext (#131078) · 43afac1e
Christopher Fujino authored Jul 24, 2023
```
Part of https://github.com/flutter/flutter/issues/47161
```
43afac1e

Roll Packages from 2266a7618ee3 to 8028cafa1f0c (13 revisions) (#131196) · f2ba0a2b

engine-flutter-autoroll authored Jul 24, 2023

https://github.com/flutter/packages/compare/2266a7618ee3...8028cafa1f0c

2023-07-24 engine-flutter-autoroll@skia.org Roll Flutter from a8c8c559 to d7ed5dc2 (7 revisions) (flutter/packages#4556)
2023-07-23 engine-flutter-autoroll@skia.org Roll Flutter from e8b397ca to a8c8c559 (11 revisions) (flutter/packages#4552)
2023-07-22 engine-flutter-autoroll@skia.org Roll Flutter from 9cfbf6b9 to e8b397ca (12 revisions) (flutter/packages#4550)
2023-07-21 stuartmorgan@google.com [ci] Clean up except exclusion list (flutter/packages#4547)
2023-07-21 47866232+chunhtai@users.noreply.github.com [go_router] Replaces uri related properties in GoRouterState (flutter/packages#4392)
2023-07-21 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Updates pigeon version to `10.1.4` (flutter/packages#4548)
2023-07-21 tarrinneal@gmail.com [pigeon] Adds package name to method channel. (flutter/packages#4443)
2023-07-21 stuartmorgan@google.com [ci] Migrate remaing unblocked repo checks to LUCI (flutter/packages#4543)
2023-07-21 stuartmorgan@google.com [go_router] Remove unused dependency (flutter/packages#4545)
2023-07-21 engine-flutter-autoroll@skia.org Roll Flutter from d07e8aec to 9cfbf6b9 (58 revisions) (flutter/packages#4544)
2023-07-21 43640732+dancamdev@users.noreply.github.com Adding myself and Michele to AUTHORS (flutter/packages#4527)
2023-07-21 32538273+ValentinVignal@users.noreply.github.com [go_router_builder] Removes `path_to_regexp` from the dependencies (flutter/packages#4524)
2023-07-21 rexios@rexios.dev [google_maps_flutter_web] Adds options for gesture handling and tilt controls. (flutter/packages#4521)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f2ba0a2b

Fix material date picker behavior when changing year (#130486) · 2a1f26c4

Lexycon authored Jul 24, 2023

This PR changes the material date picker behavior when changing the year so that it matches the native picker and the material component guideline. (#81547)

See material component guideline for the date picker: [Material component date-picker behavior](https://m3.material.io/components/date-pickers/guidelines#1531a81f-4052-4a75-a20d-228c7e110156)
See also: [Material components android discussion](https://github.com/material-components/material-components-android/issues/1723)

When selecting another year in the native picker, the same day will be selected (by respecting the boundaries of the date picker). The current material date picker does not select any day when changing the year. This will lead to confusion if the user presses OK and the year does not get updated.

So here is my suggestion:
It will try to preselect the day like the native picker:
 - respecting the boundaries of the date picker (firstDate, lastDate)
 - changing from leapyear 29th february will set 28th february if not a leapyear is selected
 - only set the day if it is selectable (selectableDayPredicate)

The calendar shown in the recording was setup with this parameters:
```
firstDate: DateTime(2016, DateTime.june, 9),
initialDate: DateTime(2018, DateTime.may, 4),
lastDate: DateTime(2021, DateTime.january, 15),
```
 
https://github.com/flutter/flutter/assets/13588771/3041c296-b9d0-4078-88cd-d1135fc343b3

Fixes #81547

2a1f26c4

Update Gallery demo app themes for Material3 compatibility (#131093) · 9690ef58
Jason Simmons authored Jul 24, 2023

9690ef58

Roll Flutter Engine from 4734a709cbf2 to aa876f6bec69 (2 revisions) (#131190) · d7ed5dc2

engine-flutter-autoroll authored Jul 24, 2023

https://github.com/flutter/engine/compare/4734a709cbf2...aa876f6bec69

2023-07-24 skia-flutter-autoroll@skia.org Roll ANGLE from 430a4f559cbc to e28575f66ae5 (1 revision) (flutter/engine#43951)
2023-07-24 skia-flutter-autoroll@skia.org Roll Skia from 860f12775838 to a56bc23bfec7 (1 revision) (flutter/engine#43950)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d7ed5dc2

Use utf8.encode() instead of longer const Utf8Encoder.convert() (#130567) · 9c101515

Martin Kustermann authored Jul 24, 2023

The change in [0] has propagated now everywhere, so we can use
`utf8.encode()` instead of the longer `const Utf8Encoder.convert()`.

Also it cleans up code like

```
  TypedData bytes;
  bytes.buffer.asByteData();
```

as that is not guaranteed to be correct, the correct version would be

```
  TypedData bytes;
  bytes.buffer.asByteData(bytes.offsetInBytes, bytes.lengthInBytes);
```

a shorter hand for that is:

```
  TypedData bytes;
  ByteData.sublistView(bytes);
```

[0] https://github.com/dart-lang/sdk/issues/52801

9c101515

Roll Flutter Engine from 402bceec81f4 to 4734a709cbf2 (2 revisions) (#131175) · acdd96b2

engine-flutter-autoroll authored Jul 24, 2023

https://github.com/flutter/engine/compare/402bceec81f4...4734a709cbf2

2023-07-24 skia-flutter-autoroll@skia.org Roll Skia from db314e2867bc to 860f12775838 (1 revision) (flutter/engine#43947)
2023-07-24 skia-flutter-autoroll@skia.org Roll Skia from f512e7eedaef to db314e2867bc (1 revision) (flutter/engine#43945)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

acdd96b2

Roll Flutter Engine from c2c54f6406df to 402bceec81f4 (1 revision) (#131174) · e57c0eff

engine-flutter-autoroll authored Jul 24, 2023

https://github.com/flutter/engine/compare/c2c54f6406df...402bceec81f4

2023-07-24 skia-flutter-autoroll@skia.org Roll Skia from ce49fc71bc7c to f512e7eedaef (1 revision) (flutter/engine#43944)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e57c0eff

Roll Flutter Engine from 35eab1bcf335 to c2c54f6406df (2 revisions) (#131173) · 47315808

engine-flutter-autoroll authored Jul 24, 2023

https://github.com/flutter/engine/compare/35eab1bcf335...c2c54f6406df

2023-07-24 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Xm1-SWnXPhSRxNol-... to hUgYN9tEps515M1lg... (flutter/engine#43941)
2023-07-24 chinmaygarde@google.com [Impeller] Fix typo in help for compiler switches. (flutter/engine#43937)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from Xm1-SWnXPhSR to hUgYN9tEps51

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

47315808