Commits · 9c1665355d9b0deeec1be60b9e9137037defa877 · abdullh.alsoleman / Front-End

30 Jan, 2024 1 commit

Roll Flutter Engine from e21208583956 to c9268c7db03c (1 revision) (#142492) · 9c166535

engine-flutter-autoroll authored Jan 30, 2024

https://github.com/flutter/engine/compare/e21208583956...c9268c7db03c

2024-01-29 skia-flutter-autoroll@skia.org Roll Skia from 0327d5b319fc to c1899b2586da (3 revisions) (flutter/engine#50152)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9c166535

29 Jan, 2024 25 commits

Roll Flutter Engine from bedafa8794b6 to e21208583956 (1 revision) (#142483) · 8d14d319

engine-flutter-autoroll authored Jan 29, 2024

https://github.com/flutter/engine/compare/bedafa8794b6...e21208583956

2024-01-29 skia-flutter-autoroll@skia.org Roll Skia from 3680286e6bf4 to 0327d5b319fc (1 revision) (flutter/engine#50150)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8d14d319

Revert "Reland: "Fix how Gradle resolves Android plugin" (#137115)" (#142464) · 995e3fad

Camille Simon authored Jan 29, 2024

This reverts commit f5ac225c, i.e. https://github.com/flutter/flutter/pull/137115.

This is a continuation of https://github.com/flutter/flutter/pull/142266 that was redone based on feedback to make this easier to revert in the future. The exact steps I took to create this revert:

1. Revert commit noted above
2. Fix merge conflicts, that notably involved reverting some changes in https://github.com/flutter/flutter/pull/140744 ~and https://github.com/flutter/flutter/pull/141417~ (fixed my merge to avoid the second PR from being affected)
3. Delete `packages/flutter_tools/test/integration.shard/android_plugin_skip_unsupported_test.dart` as this was added in the commit noted above

cc @Gustl22 since I couldn't tag as a reviewer

995e3fad

Marks Mac_pixel_7pro native_assets_android to be unflaky (#141675) · 9207b85d

Flutter GitHub Bot authored Jan 29, 2024

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_pixel_7pro native_assets_android"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_pixel_7pro%20native_assets_android%22).
This test can be marked as unflaky.

9207b85d

Roll Flutter Engine from 9c3ebf67b5da to bedafa8794b6 (4 revisions) (#142478) · ace91811

engine-flutter-autoroll authored Jan 29, 2024

https://github.com/flutter/engine/compare/9c3ebf67b5da...bedafa8794b6

2024-01-29 skia-flutter-autoroll@skia.org Roll Skia from f3b9e80d262a to 3680286e6bf4 (2 revisions) (flutter/engine#50149)
2024-01-29 jason-simmons@users.noreply.github.com Handle construction/destruction of GObject private data containing C++ objects in Linux embedder tests (flutter/engine#50022)
2024-01-29 aam@google.com Include dart vm internal sources into flutter distro. (flutter/engine#50116)
2024-01-29 matanlurey@users.noreply.github.com Manually revert TLHC optimizations, holding on to width/height changes. (flutter/engine#50144)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ace91811

onNavigationNotification for *App.router (#142190) · ade8af27

Justin McCandless authored Jan 29, 2024

onNavigationNotification was not being passed through when using the router in MaterialApp and CupertinoApp. I believe this was just an oversight on my part when I wrote https://github.com/flutter/flutter/pull/120385. This PR passes them through.

Fixes https://github.com/flutter/flutter/issues/139903

@maRci0002 Would this totally fix your issue https://github.com/flutter/flutter/issues/139903?

ade8af27

Marks Mac_x64 framework_tests_misc to be unflaky (#142118) · 1af09dde

Flutter GitHub Bot authored Jan 29, 2024

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_x64 framework_tests_misc"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_x64%20framework_tests_misc%22).
This test can be marked as unflaky.

1af09dde

Roll Flutter Engine from 3e2b8975bd5b to 9c3ebf67b5da (1 revision) (#142472) · 58a9ee5e

engine-flutter-autoroll authored Jan 29, 2024

https://github.com/flutter/engine/compare/3e2b8975bd5b...9c3ebf67b5da

2024-01-29 skia-flutter-autoroll@skia.org Roll Skia from 18e440859275 to f3b9e80d262a (1 revision) (flutter/engine#50145)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

58a9ee5e

Feat: TextField can scroll when disabled (#140922) · 1d5c2c51

Bryan Olivares authored Jan 29, 2024

This PR is adding a flag parameter to the `TextField` widget. This flag controls whether the TextField ignores pointers. The flag takes priority over other TextField behaviors such as enabled, so it can be useful when trying to have a disabled TextField that can be scrolled (behavior observed using TextArea on the web).

Adding a flag parameter to `TextField` helps with more customization and flexibility to the widget which can improve user experience. I am open to other ideas.   

Fixes issue #140147 

Before: 

https://github.com/flutter/flutter/assets/66151079/293e5b4e-3126-4a00-824d-1530aeaa494b

After:

https://github.com/flutter/flutter/assets/66151079/08c1af09-3bf9-4b49-b684-dda4dd920503

Usage:
```dart
child: TextField(
  ignorePointer: false,
  enabled: false,
),
```

1d5c2c51

Roll Flutter Engine from 436f91f3b06b to 3e2b8975bd5b (2 revisions) (#142466) · 21ca59e7

engine-flutter-autoroll authored Jan 29, 2024

https://github.com/flutter/engine/compare/436f91f3b06b...3e2b8975bd5b

2024-01-29 skia-flutter-autoroll@skia.org Roll Skia from 675e69e83129 to 18e440859275 (2 revisions) (flutter/engine#50143)
2024-01-29 skia-flutter-autoroll@skia.org Roll Skia from eaae6d12a547 to 675e69e83129 (1 revision) (flutter/engine#50141)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

21ca59e7

Marks Mac_arm64 framework_tests_misc to be unflaky (#142119) · 259c72a8

Flutter GitHub Bot authored Jan 29, 2024

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_arm64 framework_tests_misc"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_arm64%20framework_tests_misc%22).
This test can be marked as unflaky.

259c72a8

Fix InputDecorationTheme copyWith fallback for iconColor (#142462) · c576f003
Michael Goderbauer authored Jan 29, 2024
```
Same as https://github.com/flutter/flutter/pull/138914, but with a test.
```
c576f003
Add `SingleChildScrollView` for `NavigationRail` (#137415) · fd7f45a8
Mohammad Bagher Fakouri authored Jan 29, 2024
```
## Description
Add `SingleChildScrollView` to `NavigationRail` for scrolling.
Closes: #89167
```
fd7f45a8

[Windows Arm64] Run plugin test post-submit (#141987) · f727948f

Loïc Sharma authored Jan 29, 2024

The Flutter try pool does not have any Windows Arm64 machines. Thus, any Windows Arm64 pre-submit tests will fail as there's no machines to run them.

This converts the only Windows Arm64 pre-submit test, the plugin test, to run post-submit.

See: https://github.com/flutter/flutter/issues/141986

f727948f

Catch file system exceptions when trying to parse user-provided asset file paths (#142214) · 83bdde2b
Andrew Kolos authored Jan 29, 2024
```
Fixes #141211
```
83bdde2b

Implementing `switch` expressions in `foundation/` and `material/` (#142279) · 38879dae

Nate authored Jan 29, 2024

This PR is the fourth step in the journey to solve issue #136139 and make the entire Flutter repo more readable.

(previous pull requests: #139048, #139882, #141591)

This one is covering files in `packages/flutter/lib/src/foundation/` and `packages/flutter/lib/src/material/`.  
The `material/` directory is pretty big though, so for now I just did the files that start with `a`, `b`, and `c`.

38879dae

Roll Flutter Engine from bff1e46c0d65 to 436f91f3b06b (1 revision) (#142455) · 5ee1460b

engine-flutter-autoroll authored Jan 29, 2024

https://github.com/flutter/engine/compare/bff1e46c0d65...436f91f3b06b

2024-01-29 skia-flutter-autoroll@skia.org Roll Skia from c699bb0d86fd to eaae6d12a547 (1 revision) (flutter/engine#50140)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5ee1460b

Opt out test from leak tracking. (#142417) · 96c322d6
Polina Cherkasova authored Jan 29, 2024

96c322d6

Update Android minSdkVersion to 21 (#142267) · 6a6874ec

Zachary Anderson authored Jan 29, 2024

This PR increases Android's `minSdkVersion` to 21.

There are two changes in this PR aside from simply increasing the number
from 19 to 21 everywhere.

First, tests using `flutter_gallery` fail without updating the
lockfiles. The changes in the PR are the results of running
`dev/tools/bin/generate_gradle_lockfiles.dart` on that app.

Second, from
[here](https://developer.android.com/build/multidex#mdex-pre-l):
> if your minSdkVersion is 21 or higher, multidex is enabled by default
and you don't need the multidex library.

As a result, the `multidex` option everywhere is obsolete. This PR
removes all logic and tests related to that option that I could find.
`Google testing` and `customer_tests` pass on this PR, so it seems like
this won't be too breaking if it is at all. If needed I'll give this
some time to bake in the framework before landing the flutter/engine
PRs.

Context: https://github.com/flutter/flutter/issues/138117,
https://github.com/flutter/flutter/issues/141277, b/319373605

6a6874ec

Roll Flutter Engine from 3d87470655b1 to bff1e46c0d65 (1 revision) (#142446) · bdb71b8f

engine-flutter-autoroll authored Jan 29, 2024

https://github.com/flutter/engine/compare/3d87470655b1...bff1e46c0d65

2024-01-29 103135467+sealesj@users.noreply.github.com Remove ockmock GitHub reference (flutter/engine#50086)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bdb71b8f

Roll Packages from cbe810031b88 to 516648afb6be (3 revisions) (#142445) · 88624474

engine-flutter-autoroll authored Jan 29, 2024

https://github.com/flutter/packages/compare/cbe810031b88...516648afb6be

2024-01-28 19920697+getBoolean@users.noreply.github.com [go_router] Add `topRoute` to `GoRouterState` (flutter/packages#5736)
2024-01-27 stuartmorgan@google.com Add Kotlin to CONTRIBUTING.md (flutter/packages#5970)
2024-01-26 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 67457e669f79 to 41456452f29d (1 revision) (flutter/packages#5979)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

88624474

Roll Flutter Engine from 1405cb7b6e74 to 3d87470655b1 (1 revision) (#142444) · 65652d5b

engine-flutter-autoroll authored Jan 29, 2024

https://github.com/flutter/engine/compare/1405cb7b6e74...3d87470655b1

2024-01-29 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 5aijurFz23iIuRaMQ... to Hqi_x_A9lYsY58VSn... (flutter/engine#50137)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 5aijurFz23iI to Hqi_x_A9lYsY

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

65652d5b

Roll Flutter Engine from 3e65f1720a6f to 1405cb7b6e74 (1 revision) (#142432) · 44ce0bf9

engine-flutter-autoroll authored Jan 29, 2024

https://github.com/flutter/engine/compare/3e65f1720a6f...1405cb7b6e74

2024-01-29 skia-flutter-autoroll@skia.org Roll Skia from 8c9f983ee600 to c699bb0d86fd (3 revisions) (flutter/engine#50136)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

44ce0bf9

Roll Flutter Engine from 210ed1dfb8cf to 3e65f1720a6f (1 revision) (#142429) · 38ac3de4

engine-flutter-autoroll authored Jan 29, 2024

https://github.com/flutter/engine/compare/210ed1dfb8cf...3e65f1720a6f

2024-01-29 skia-flutter-autoroll@skia.org Roll Skia from a26e0b3ca4df to 8c9f983ee600 (1 revision) (flutter/engine#50134)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

38ac3de4

Roll Flutter Engine from f15cb86d31c3 to 210ed1dfb8cf (1 revision) (#142426) · 7e463941

engine-flutter-autoroll authored Jan 29, 2024

https://github.com/flutter/engine/compare/f15cb86d31c3...210ed1dfb8cf

2024-01-29 skia-flutter-autoroll@skia.org Roll Skia from d81204e28dcb to a26e0b3ca4df (1 revision) (flutter/engine#50132)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7e463941

Roll Flutter Engine from f3d48be76630 to f15cb86d31c3 (11 revisions) (#142425) · e743df8b

engine-flutter-autoroll authored Jan 29, 2024

https://github.com/flutter/engine/compare/f3d48be76630...f15cb86d31c3

2024-01-29 zanderso@users.noreply.github.com Revert Dart to Version 3.4.0-82.0.dev (flutter/engine#50131)
2024-01-28 skia-flutter-autoroll@skia.org Roll Dart SDK from 639cf51f4472 to 1d0b890287a4 (1 revision) (flutter/engine#50129)
2024-01-28 skia-flutter-autoroll@skia.org Roll Skia from 40205cafdb4e to d81204e28dcb (1 revision) (flutter/engine#50127)
2024-01-28 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from GBTh3gOOgmndwT70X... to 5aijurFz23iIuRaMQ... (flutter/engine#50126)
2024-01-28 bdero@google.com [Impeller] Fix alpha management issues for advanced blends. (flutter/engine#50070)
2024-01-28 skia-flutter-autoroll@skia.org Roll Skia from 0c1e352e87aa to 40205cafdb4e (1 revision) (flutter/engine#50124)
2024-01-27 skia-flutter-autoroll@skia.org Roll Dart SDK from 422d048880a8 to 639cf51f4472 (1 revision) (flutter/engine#50123)
2024-01-27 737941+loic-sharma@users.noreply.github.com Revert "[Windows] Introduce `egl::Surface` and `egl::WindowSurface`" (flutter/engine#50104)
2024-01-27 skia-flutter-autoroll@skia.org Roll Dart SDK from d0b48a008559 to 422d048880a8 (1 revision) (flutter/engine#50121)
2024-01-27 skia-flutter-autoroll@skia.org Roll Skia from b9b80230c87b to 0c1e352e87aa (1 revision) (flutter/engine#50120)
2024-01-27 skia-flutter-autoroll@skia.org Roll Dart SDK from 141ab6c14cd1 to d0b48a008559 (1 revision) (flutter/engine#50119)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from GBTh3gOOgmnd to 5aijurFz23iI

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e743df8b

27 Jan, 2024 9 commits

Roll Flutter Engine from 95e9a15fd909 to f3d48be76630 (1 revision) (#142370) · efb13467

engine-flutter-autoroll authored Jan 27, 2024

https://github.com/flutter/engine/compare/95e9a15fd909...f3d48be76630

2024-01-27 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 7ae508ee09a3 to 141ab6c14cd1 (1 revision) (flutter/engine#50115)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

efb13467

Add no-shuffle to language_version_test.dart (#142378) · 4601341b
Zachary Anderson authored Jan 27, 2024

4601341b

Roll Flutter Engine from 2687ddb2655c to 95e9a15fd909 (8 revisions) (#142369) · db828a83

engine-flutter-autoroll authored Jan 27, 2024

https://github.com/flutter/engine/compare/2687ddb2655c...95e9a15fd909

2024-01-27 flar@google.com Cache Impeller paths in the DisplayList to amortize conversion (flutter/engine#50076)
2024-01-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Android] Cache GPU resources using HardwareBuffer's id as key" (flutter/engine#50114)
2024-01-27 skia-flutter-autoroll@skia.org Roll Dart SDK from 58665e3dee42 to 7ae508ee09a3 (1 revision) (flutter/engine#50112)
2024-01-27 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from WHlwlOwznFknNm5IS... to GBTh3gOOgmndwT70X... (flutter/engine#50111)
2024-01-27 skia-flutter-autoroll@skia.org Roll Skia from 6279c88b9e29 to b9b80230c87b (4 revisions) (flutter/engine#50110)
2024-01-27 jonahwilliams@google.com [Impeller] add missing barrier to compute tessellator. (flutter/engine#50108)
2024-01-27 jonahwilliams@google.com [Android] Cache GPU resources using HardwareBuffer's id as key (flutter/engine#50028)
2024-01-27 54558023+keyonghan@users.noreply.github.com Move Mac builder_cache to prod (flutter/engine#50044)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from WHlwlOwznFkn to GBTh3gOOgmnd

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

db828a83

Reverts "Roll Flutter Engine from 2687ddb2655c to 2adad88a39f4 (4 revisions)" (#142366) · 7a910d67

auto-submit[bot] authored Jan 27, 2024

Reverts flutter/flutter#142362
Initiated by: jonahwilliams
This change reverts the following previous change:
Original Description:

https://github.com/flutter/engine/compare/2687ddb2655c...2adad88a39f4

2024-01-27 skia-flutter-autoroll@skia.org Roll Skia from 6279c88b9e29 to b9b80230c87b (4 revisions) (flutter/engine#50110)
2024-01-27 jonahwilliams@google.com [Impeller] add missing barrier to compute tessellator. (flutter/engine#50108)
2024-01-27 jonahwilliams@google.com [Android] Cache GPU resources using HardwareBuffer's id as key (flutter/engine#50028)
2024-01-27 54558023+keyonghan@users.noreply.github.com Move Mac builder_cache to prod (flutter/engine#50044)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7a910d67

Roll Flutter Engine from 2687ddb2655c to 2adad88a39f4 (4 revisions) (#142362) · 5b7072fa

engine-flutter-autoroll authored Jan 27, 2024

https://github.com/flutter/engine/compare/2687ddb2655c...2adad88a39f4

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5b7072fa

Roll Flutter Engine from 45c06c22d5c7 to 2687ddb2655c (1 revision) (#142359) · 3c22b1c7

engine-flutter-autoroll authored Jan 27, 2024

https://github.com/flutter/engine/compare/45c06c22d5c7...2687ddb2655c

2024-01-27 matanlurey@users.noreply.github.com Enable `header_guard_check` (and `--fix`) in `ci/format` (flutter/engine#50102)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3c22b1c7

Remove suspicious constant from input decorator layout (#142342) · 62037e9a

LongCatIsLooong authored Jan 27, 2024

Maybe fixes https://github.com/flutter/flutter/issues/124852. @justinmc do you remember what the constant 2 is for when computing the outline baseline?

62037e9a

Roll Flutter Engine from 2e32acf4c31a to 45c06c22d5c7 (2 revisions) (#142353) · 20b59875

engine-flutter-autoroll authored Jan 27, 2024

https://github.com/flutter/engine/compare/2e32acf4c31a...45c06c22d5c7

2024-01-26 dnfield@google.com Followups to screenshot patch (flutter/engine#50096)
2024-01-26 matanlurey@users.noreply.github.com Delete `ci/docker`, assuming it is not used. (flutter/engine#50103)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

20b59875

Roll Flutter Engine from a65a1b55e06a to 2e32acf4c31a (1 revision) (#142351) · c841dc6d

engine-flutter-autoroll authored Jan 27, 2024

https://github.com/flutter/engine/compare/a65a1b55e06a...2e32acf4c31a

2024-01-26 aam@google.com Roll dart to 3.4.0-79.0.dev (flutter/engine#50100)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c841dc6d

26 Jan, 2024 5 commits

Roll Flutter Engine from 525bd7dcf7f3 to a65a1b55e06a (11 revisions) (#142347) · 560c6301

engine-flutter-autoroll authored Jan 26, 2024

https://github.com/flutter/engine/compare/525bd7dcf7f3...a65a1b55e06a

2024-01-26 skia-flutter-autoroll@skia.org Roll Skia from c32aa37effcc to 6279c88b9e29 (1 revision) (flutter/engine#50098)
2024-01-26 jonahwilliams@google.com [Impeller] add compute pass API for memory barriers, re-enable for Vulkan. (flutter/engine#49946)
2024-01-26 matanlurey@users.noreply.github.com Introduce a prototype of a "header guard enforcement" tool (flutter/engine#48903)
2024-01-26 skia-flutter-autoroll@skia.org Roll Skia from e24124912cc3 to c32aa37effcc (1 revision) (flutter/engine#50094)
2024-01-26 ditman@gmail.com [web] Do not wipe the PlatformViewManager when disposing of a view. (flutter/engine#49991)
2024-01-26 matanlurey@users.noreply.github.com Finish landing missing/incorrect header guards across `flutter/engine` (flutter/engine#50069)
2024-01-26 skia-flutter-autoroll@skia.org Roll Skia from 32f6bff0f193 to e24124912cc3 (2 revisions) (flutter/engine#50093)
2024-01-26 skia-flutter-autoroll@skia.org Roll Skia from cbdf09d69efc to 32f6bff0f193 (3 revisions) (flutter/engine#50092)
2024-01-26 skia-flutter-autoroll@skia.org Roll Dart SDK from 5636e338e0b9 to 7337995bc851 (1 revision) (flutter/engine#50087)
2024-01-26 dnfield@google.com Fix Shell::Screenshot for Impeller (flutter/engine#50072)
2024-01-26 skia-flutter-autoroll@skia.org Roll Skia from ae73baacb793 to cbdf09d69efc (1 revision) (flutter/engine#50085)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

560c6301

Relands "Add runWidget to bootstrap a widget tree without a default View" (#142344) · 671d8eaf

Michael Goderbauer authored Jan 26, 2024

Reverts flutter/flutter#142339

In the original change one of the tests included the same view twice which resulted in a different failure than the expected one. The second commit contains the fix for this. I don't understand how this wasn't caught presubmit on CI.

671d8eaf

Fix assertion failure when reordering two dimensional children (#141504) · a5ad088f

Amir Panahandeh authored Jan 26, 2024

It fixes assertion failure due to unstable state of children list during reordering in `RenderTwoDimensionalViewport.parentDataOf`. This changes the assertion to check debug orphan list and `keepAlive` bucket in addition to children list to determine whether child belongs to this render object or not.

- Fixes #141101

a5ad088f

Limit `fuchsia_precache` in presubmit to engine rolls (#142333) · aaa3eba1

Jenn Magder authored Jan 26, 2024

This doesn't need to run on every PR in presubmit.  Limit to engine rolls to validate the artifacts have been published.

Fixes https://github.com/flutter/flutter/issues/142330

aaa3eba1

Bump github/codeql-action from 3.23.1 to 3.23.2 (#142345) · a386473e

dependabot[bot] authored Jan 26, 2024

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.23.1 to 3.23.2.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<p>Note that the only difference between <code>v2</code> and <code>v3</code> of the CodeQL Action is the node version they support, with <code>v3</code> running on node 20 while we continue to release <code>v2</code> to support running on node 16. For example <code>3.22.11</code> was the first <code>v3</code> release and is functionally identical to <code>2.22.11</code>. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>3.23.2 - 26 Jan 2024</h2>
<ul>
<li>On Linux, the maximum possible value for the <code>--threads</code> option now respects the CPU count as specified in <code>cgroup</code> files to more accurately reflect the number of available cores when running in containers. <a href="https://redirect.github.com/github/codeql-action/pull/2083">#2083</a></li>
<li>Update default CodeQL bundle version to 2.16.1. <a href="https://redirect.github.com/github/codeql-action/pull/2096">#2096</a></li>
</ul>
<h2>3.23.1 - 17 Jan 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.16.0. <a href="https://redirect.github.com/github/codeql-action/pull/2073">#2073</a></li>
<li>Change the retention period for uploaded debug artifacts to 7 days. Previously, this was whatever the repository default was. <a href="https://redirect.github.com/github/codeql-action/pull/2079">#2079</a></li>
</ul>
<h2>3.23.0 - 08 Jan 2024</h2>
<ul>
<li>We are rolling out a feature in January 2024 that will disable Python dependency installation by default for all users. This improves the speed of analysis while having only a very minor impact on results. You can override this behavior by setting <code>CODEQL_ACTION_DISABLE_PYTHON_DEPENDENCY_INSTALLATION=false</code> in your workflow, however we plan to remove this ability in future versions of the CodeQL Action. <a href="https://redirect.github.com/github/codeql-action/pull/2031">#2031</a></li>
<li>The CodeQL Action now requires CodeQL version 2.11.6 or later. For more information, see <a href="https://github.com/github/codeql-action/blob/main/#2227---16-nov-2023">the corresponding changelog entry for CodeQL Action version 2.22.7</a>. <a href="https://redirect.github.com/github/codeql-action/pull/2009">#2009</a></li>
</ul>
<h2>3.22.12 - 22 Dec 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.5. <a href="https://redirect.github.com/github/codeql-action/pull/2047">#2047</a></li>
</ul>
<h2>3.22.11 - 13 Dec 2023</h2>
<ul>
<li>[v3+ only] The CodeQL Action now runs on Node.js v20. <a href="https://redirect.github.com/github/codeql-action/pull/2006">#2006</a></li>
</ul>
<h2>2.22.10 - 12 Dec 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.4. <a href="https://redirect.github.com/github/codeql-action/pull/2016">#2016</a></li>
</ul>
<h2>2.22.9 - 07 Dec 2023</h2>
<p>No user facing changes.</p>
<h2>2.22.8 - 23 Nov 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.3. <a href="https://redirect.github.com/github/codeql-action/pull/2001">#2001</a></li>
</ul>
<h2>2.22.7 - 16 Nov 2023</h2>
<ul>
<li>Add a deprecation warning for customers using CodeQL version 2.11.5 and earlier. These versions of CodeQL were discontinued on 8 November 2023 alongside GitHub Enterprise Server 3.7, and will be unsupported by CodeQL Action v2.23.0 and later. <a href="https://redirect.github.com/github/codeql-action/pull/1993">#1993</a>
<ul>
<li>If you are using one of these versions, please update to CodeQL CLI version 2.11.6 or later. For instance, if you have specified a custom version of the CLI using the 'tools' input to the 'init' Action, you can remove this input to use the default version.</li>
<li>Alternatively, if you want to continue using a version of the CodeQL CLI between 2.10.5 and 2.11.5, you can replace <code>github/codeql-action/*@v2</code> by <code>github/codeql-action/*@v2.22.7</code> in your code scanning workflow to ensure you continue using this version of the CodeQL Action.</li>
</ul>
</li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/b7bf0a3ed3ecfa44160715d7c442788f65f0f923"><code>b7bf0a3</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2099">#2099</a> from github/update-v3.23.2-61bf02577</li>
<li><a href="https://github.com/github/codeql-action/commit/33e354b34bc9d95d28ae4f055fa1faeb59e59ae5"><code>33e354b</code></a> Changelog: Add missing PR link</li>
<li><a href="https://github.com/github/codeql-action/commit/f4cfe8904c929c35f9612da0c754f121a3422d7e"><code>f4cfe89</code></a> Update changelog for v3.23.2</li>
<li><a href="https://github.com/github/codeql-action/commit/61bf02577c801b30a708abc6f2164763e4e1d0cd"><code>61bf025</code></a> Send overall job status in init-post status report (<a href="https://redirect.github.com/github/codeql-action/issues/2097">#2097</a>)</li>
<li><a href="https://github.com/github/codeql-action/commit/16150320c5db0d4942ea2bd4974fc365d6324737"><code>1615032</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2096">#2096</a> from github/update-bundle/codeql-bundle-v2.16.1</li>
<li><a href="https://github.com/github/codeql-action/commit/bd67d8d6b2096e4b46db15ed108e563c4447d608"><code>bd67d8d</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2098">#2098</a> from github/henrymercer/update-internal-queries</li>
<li><a href="https://github.com/github/codeql-action/commit/a2619f68c8432b9a500ecc7aafd4816667379bed"><code>a2619f6</code></a> Internal queries: Replace deprecated predicates</li>
<li><a href="https://github.com/github/codeql-action/commit/666e2f9edfd29789e9f46f2cce092d18622dcb74"><code>666e2f9</code></a> Internal queries: Replace deprecated predicates</li>
<li><a href="https://github.com/github/codeql-action/commit/d43ae36a631248dea35da2f8da5e28687255da31"><code>d43ae36</code></a> Add changelog note</li>
<li><a href="https://github.com/github/codeql-action/commit/75af1f5948eef4f82d80db69296c55a9bc5ba26e"><code>75af1f5</code></a> Update default bundle to codeql-bundle-v2.16.1</li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/0b21cf2492b6b02c465a3e5d7c473717ad7721ba...b7bf0a3ed3ecfa44160715d7c442788f65f0f923">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=3.23.1&new-version=3.23.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

a386473e