Commits · 9ae8a6b7d54efd1efa6ceff935ceab02701b4c8e · abdullh.alsoleman / Front-End

23 Mar, 2024 9 commits

Reland #128236 "Improve build output for all platforms" (#145495) · 9ae8a6b7

Pierre-Louis authored Mar 23, 2024

Reland #128236, reverted in https://github.com/flutter/flutter/pull/143125, https://github.com/flutter/flutter/pull/145261, and https://github.com/flutter/flutter/pull/145487.

The errors were raised in post-submit tests on Windows. I have finally obtained a Windows machine to reproduce the errors locally and adjust the test (remove size expectation and rename output `.exe`).

## Original description

Improves the build output:

1. Gives confirmation that the build succeeded, in green
1. Gives the path to the built executable, without a trailing period to make it slightly easier to cmd/ctrl+open
1. Gives the size of the built executable (when the built executable is self contained) 

### `apk`, `appbundle` 

<img width="607" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ecc52abe-cd2e-4116-b22a-8385ae3e980d">

<img width="634" alt="image" src="https://github.com/flutter/flutter/assets/6655696/8af8bd33-c0bd-4215-9a06-9652ee019436">

### `macos`, `ios`, `ipa`
Build executables are self-contained and use a newly introduced `OperatingSystemUtils.getDirectorySize`.

<img width="514" alt="image" src="https://github.com/flutter/flutter/assets/6655696/b5918a69-3959-4417-9205-4f501d185257">

<img width="581" alt="image" src="https://github.com/flutter/flutter/assets/6655696/d72fd420-18cf-4470-9e4b-b6ac10fbcd50">

<img width="616" alt="image" src="https://github.com/flutter/flutter/assets/6655696/5f235ce1-252a-4c13-898f-139f6c7bc698">

### `windows`, `linux`, and `web`
Build executables aren't self-contained, and folder size can sometimes overestimate distribution size, therefore their size isn't mentioned (see discussion below).

<img width="647" alt="image" src="https://github.com/flutter/flutter/assets/6655696/7179e771-1eb7-48f6-b770-975bc073437b">

<img width="658" alt="image" src="https://github.com/flutter/flutter/assets/6655696/a6801cab-7b5a-4975-a406-f4c9fa44d7a2">

<img width="608" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ee7c4125-a273-4a65-95d7-ab441edf8ac5">

### Size reporting
When applicable, the printed size matches the OS reported size.

- macOS
    <img width="391" alt="image" src="https://github.com/flutter/flutter/assets/6655696/881cbfb1-d355-444b-ab44-c1a6343190ce">
- Windows
    <img width="338" alt="image" src="https://github.com/flutter/flutter/assets/6655696/3b806def-3d15-48a9-8a25-df200d6feef7">
- Linux   
    <img width="320" alt="image" src="https://github.com/flutter/flutter/assets/6655696/89a4aa3d-2148-4f3b-b231-f93a057fee2b">

## Related issues
Part of #120127
Fixes https://github.com/flutter/flutter/issues/121401

9ae8a6b7

Roll Flutter Engine from 7690eb12ded5 to 42d4262b4b20 (1 revision) (#145635) · 09b1afbd

engine-flutter-autoroll authored Mar 23, 2024

https://github.com/flutter/engine/compare/7690eb12ded5...42d4262b4b20

2024-03-23 skia-flutter-autoroll@skia.org Roll Skia from 2e99e3a5445c to 755ca0094a77 (1 revision) (flutter/engine#51639)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

09b1afbd

Roll Flutter Engine from 8a51e124fbf1 to 7690eb12ded5 (1 revision) (#145634) · c7dc2ce6

engine-flutter-autoroll authored Mar 23, 2024

https://github.com/flutter/engine/compare/8a51e124fbf1...7690eb12ded5

2024-03-23 skia-flutter-autoroll@skia.org Roll Dart SDK from ad26f4885bf4 to 45169152b424 (2 revisions) (flutter/engine#51638)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c7dc2ce6

Roll Flutter Engine from bc4fa4367edb to 8a51e124fbf1 (4 revisions) (#145630) · 085dbd85

engine-flutter-autoroll authored Mar 23, 2024

https://github.com/flutter/engine/compare/bc4fa4367edb...8a51e124fbf1

2024-03-22 skia-flutter-autoroll@skia.org Roll Skia from 10a460af3308 to 2e99e3a5445c (1 revision) (flutter/engine#51632)
2024-03-22 skia-flutter-autoroll@skia.org Roll Dart SDK from a959c7def805 to ad26f4885bf4 (1 revision) (flutter/engine#51631)
2024-03-22 1961493+harryterkelsen@users.noreply.github.com [web] Add ability to customize font fallback download URL (flutter/engine#51569)
2024-03-22 jacksongardner@google.com [skwasm] Use test fonts while in debugEmulateFlutterTesterEnvironment mode (flutter/engine#51630)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

085dbd85

Bump github/codeql-action from 3.24.8 to 3.24.9 (#145627) · 5b6a121d

dependabot[bot] authored Mar 23, 2024

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.24.8 to 3.24.9.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<p>Note that the only difference between <code>v2</code> and <code>v3</code> of the CodeQL Action is the node version they support, with <code>v3</code> running on node 20 while we continue to release <code>v2</code> to support running on node 16. For example <code>3.22.11</code> was the first <code>v3</code> release and is functionally identical to <code>2.22.11</code>. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>3.24.9 - 22 Mar 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.16.5. <a href="https://redirect.github.com/github/codeql-action/pull/2203">#2203</a></li>
</ul>
<h2>3.24.8 - 18 Mar 2024</h2>
<ul>
<li>Improve the ease of debugging extraction issues by increasing the verbosity of the extractor logs when running in debug mode. <a href="https://redirect.github.com/github/codeql-action/pull/2195">#2195</a></li>
</ul>
<h2>3.24.7 - 12 Mar 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.16.4. <a href="https://redirect.github.com/github/codeql-action/pull/2185">#2185</a></li>
</ul>
<h2>3.24.6 - 29 Feb 2024</h2>
<p>No user facing changes.</p>
<h2>3.24.5 - 23 Feb 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.16.3. <a href="https://redirect.github.com/github/codeql-action/pull/2156">#2156</a></li>
</ul>
<h2>3.24.4 - 21 Feb 2024</h2>
<ul>
<li>Fix an issue where an existing, but empty, <code>/sys/fs/cgroup/cpuset.cpus</code> file always resulted in a single-threaded run. <a href="https://redirect.github.com/github/codeql-action/pull/2151">#2151</a></li>
</ul>
<h2>3.24.3 - 15 Feb 2024</h2>
<ul>
<li>Fix an issue where the CodeQL Action would fail to load a configuration specified by the <code>config</code> input to the <code>init</code> Action. <a href="https://redirect.github.com/github/codeql-action/pull/2147">#2147</a></li>
</ul>
<h2>3.24.2 - 15 Feb 2024</h2>
<ul>
<li>Enable improved multi-threaded performance on larger runners for GitHub Enterprise Server users. This feature is already available to GitHub.com users. <a href="https://redirect.github.com/github/codeql-action/pull/2141">#2141</a></li>
</ul>
<h2>3.24.1 - 13 Feb 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.16.2. <a href="https://redirect.github.com/github/codeql-action/pull/2124">#2124</a></li>
<li>The CodeQL action no longer fails if it can't write to the telemetry api endpoint. <a href="https://redirect.github.com/github/codeql-action/pull/2121">#2121</a></li>
</ul>
<h2>3.24.0 - 02 Feb 2024</h2>
<ul>
<li>CodeQL Python analysis will no longer install dependencies on GitHub Enterprise Server, as is already the case for GitHub.com. See <a href="https://github.com/github/codeql-action/blob/main/#3230---08-jan-2024">release notes for 3.23.0</a> for more details. <a href="https://redirect.github.com/github/codeql-action/pull/2106">#2106</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/1b1aada464948af03b950897e5eb522f92603cc2"><code>1b1aada</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2208">#2208</a> from github/update-v3.24.9-09d4101d2</li>
<li><a href="https://github.com/github/codeql-action/commit/6505708f955e212b674980b47a03f34f6d1d9776"><code>6505708</code></a> Update changelog for v3.24.9</li>
<li><a href="https://github.com/github/codeql-action/commit/09d4101d2b9ab56005e4d4b429fcd66b33f86488"><code>09d4101</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2203">#2203</a> from github/update-bundle/codeql-bundle-v2.16.5</li>
<li><a href="https://github.com/github/codeql-action/commit/a3ab02e6453e6d2d2f6bd77317c51c10ea973420"><code>a3ab02e</code></a> Merge branch 'main' into update-bundle/codeql-bundle-v2.16.5</li>
<li><a href="https://github.com/github/codeql-action/commit/9cf4574790094ee1d65a5c79713238216ad8b8db"><code>9cf4574</code></a> Add changelog note</li>
<li><a href="https://github.com/github/codeql-action/commit/964f5e781137c77436cb7c1230cdab297670d8d8"><code>964f5e7</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2207">#2207</a> from github/henrymercer/more-processing-error-catego...</li>
<li><a href="https://github.com/github/codeql-action/commit/9c0c35b370686be5728dec35cd1c3282773a0778"><code>9c0c35b</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2206">#2206</a> from github/henrymercer/improved-autobuild-error-wit...</li>
<li><a href="https://github.com/github/codeql-action/commit/c84e4c8e7b99e8c51d759338dfcffa926d58fa6f"><code>c84e4c8</code></a> Mark some more processing errors as invalid SARIF upload requests</li>
<li><a href="https://github.com/github/codeql-action/commit/4aca720110e11498c0c68f71b4078b27b782534d"><code>4aca720</code></a> Improve error message when using build modes and autobuild fails</li>
<li><a href="https://github.com/github/codeql-action/commit/7f375aeb76b6f1b81401407aeb7de808dd5f814c"><code>7f375ae</code></a> Wrap configuration errors for all CLI commands</li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/05963f47d870e2cb19a537396c1f668a348c7d8f...1b1aada464948af03b950897e5eb522f92603cc2">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=3.24.8&new-version=3.24.9)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

5b6a121d

Add workaround for bug adding unicode strings to test reports. (#145607) · 716f8276

godofredoc authored Mar 23, 2024

When print is used inside tests its content is added to the test report as a string of unicode \u0000 making the test reporting parser fail. This PR cleans removes non json content every line of the report.

Bug: https://github.com/flutter/flutter/issues/145553

716f8276

Roll Flutter Engine from 52142e428760 to bc4fa4367edb (1 revision) (#145626) · 42d6f719

engine-flutter-autoroll authored Mar 23, 2024

https://github.com/flutter/engine/compare/52142e428760...bc4fa4367edb

2024-03-22 skia-flutter-autoroll@skia.org Roll Skia from eb6976fc57cc to 10a460af3308 (3 revisions) (flutter/engine#51629)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

42d6f719

[web][docs] Improve HtmlElementView widget docs. (#145192) · df75d249

David Iglesias authored Mar 23, 2024

This PR expands the `HtmlElementView` widget DartDocs, with the following sections:

* Usage: How to use the widget, two ways:
  * The `HtmlElementView.fromTagName` constructor
  * The `PlatformViewRegistry` way
* Lifecycle: There's an `onCreated` callback on the widget. When does it get called?
* HTML Lifecycle: How to listen to events coming from the DOM.
* Visibility: what is the `isVisible` property for?

Small additional tweaks here and there to mention common pitfalls of using HtmlElementView on the web, and mentions to workarounds, like `package:pointer_interceptor`.

## Issues

* Fixes: https://github.com/flutter/flutter/issues/143922
* Fixes: https://github.com/flutter/flutter/issues/49634
* Related: https://github.com/flutter/website/issues/5063

df75d249

Disable flaky text_editing_integration tests temporarily. (#145629) · 6836b044

Jackson Gardner authored Mar 23, 2024

I did some local debugging but couldn't get an exact root cause on the flakiness of these tests. Running them locally, there are a lot of assertions and exceptions being thrown in console, so I think we need to figure out what's going on there, but we should disable these for now to unblock the tree.

6836b044

22 Mar, 2024 17 commits

Roll Flutter Engine from cc8f752b81e5 to 52142e428760 (4 revisions) (#145625) · 233dd97f

engine-flutter-autoroll authored Mar 22, 2024

https://github.com/flutter/engine/compare/cc8f752b81e5...52142e428760

2024-03-22 jacksongardner@google.com [Skwasm] Respect the `debugDisableFallbackFonts` flag. (flutter/engine#51626)
2024-03-22 skia-flutter-autoroll@skia.org Roll Skia from 6484a450c457 to eb6976fc57cc (1 revision) (flutter/engine#51627)
2024-03-22 jacksongardner@google.com [skwasm] Throw when gradient color stops are invalid in debug mode. (flutter/engine#51624)
2024-03-22 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from AW70sjrQKy2sSXpUA... to _uuBNUJ6KbprCDWmC... (flutter/engine#51625)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from AW70sjrQKy2s to _uuBNUJ6Kbpr

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

233dd97f

Fix skipping golden comparator for CI environments (#145619) · 4820e0cd

Kate Lovett authored Mar 22, 2024

Fixes https://github.com/flutter/flutter/issues/145618

The local file comparator was being used in post submit for the Linux coverage shard. This corrects it to choose the skipping comparator.

4820e0cd

Roll Flutter Engine from 68301f268278 to cc8f752b81e5 (1 revision) (#145621) · de68c938

engine-flutter-autoroll authored Mar 22, 2024

https://github.com/flutter/engine/compare/68301f268278...cc8f752b81e5

2024-03-22 jason-simmons@users.noreply.github.com [Impeller] Check for empty sizes when creating render targets in RenderTargetCache (flutter/engine#51597)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

de68c938

Roll Packages from b7fbe68d4ec2 to 611aea1657fb (4 revisions) (#145615) · 7009b926

engine-flutter-autoroll authored Mar 22, 2024

https://github.com/flutter/packages/compare/b7fbe68d4ec2...611aea1657fb

2024-03-21 engine-flutter-autoroll@skia.org Roll Flutter from b96c13d1 to 18340ea1 (26 revisions) (flutter/packages#6370)
2024-03-21 engine-flutter-autoroll@skia.org Roll Flutter (stable) from ba3931984302 to 68bfaea22488 (2 revisions) (flutter/packages#6368)
2024-03-21 stuartmorgan@google.com [flutter_adaptive_scaffold] Remove broken link from README (flutter/packages#6364)
2024-03-21 38110731+aliasgar4558@users.noreply.github.com [adaptive_scaffold] : ð : #110902 : Assertion added when try with less that 2 destinations. (flutter/packages#6360)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7009b926

Roll Flutter Engine from 63ff0dedd8e6 to 68301f268278 (2 revisions) (#145613) · e9a0c354

engine-flutter-autoroll authored Mar 22, 2024

https://github.com/flutter/engine/compare/63ff0dedd8e6...68301f268278

2024-03-22 skia-flutter-autoroll@skia.org Roll Skia from 14c5a8540691 to 6484a450c457 (19 revisions) (flutter/engine#51623)
2024-03-22 skia-flutter-autoroll@skia.org Roll Dart SDK from b89d2de510d1 to a959c7def805 (4 revisions) (flutter/engine#51622)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e9a0c354

Roll Flutter Engine from 09dadce76828 to 63ff0dedd8e6 (2 revisions) (#145611) · 26909e0a

engine-flutter-autoroll authored Mar 22, 2024

https://github.com/flutter/engine/compare/09dadce76828...63ff0dedd8e6

2024-03-22 737941+loic-sharma@users.noreply.github.com [Embedder API] Add helper to create viewport metrics (flutter/engine#51562)
2024-03-22 737941+loic-sharma@users.noreply.github.com [Windows] Allow view controllers to not own the engine (flutter/engine#51570)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

26909e0a

2DScrollView - Fix drag when one axis does not have enough content (#145566) · c5047e0a

Kate Lovett authored Mar 22, 2024

Fixes https://github.com/flutter/flutter/issues/144982
For reference, may have to do with #138442 when we reworked the gesture handling. The adjustments to the comments here were certainly from #138442 not updating them. Confused myself for a minute or two. ð

c5047e0a

Roll Flutter Engine from eba6e31498b8 to 09dadce76828 (1 revision) (#145603) · 14774b95

engine-flutter-autoroll authored Mar 22, 2024

https://github.com/flutter/engine/compare/eba6e31498b8...09dadce76828

2024-03-22 kjlubick@users.noreply.github.com Update one more use of deprecated GrDirectContext::MakeMetal (flutter/engine#51619)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

14774b95

Roll Flutter Engine from f9a34ae0b14f to eba6e31498b8 (1 revision) (#145598) · 7ad647ab

engine-flutter-autoroll authored Mar 22, 2024

https://github.com/flutter/engine/compare/f9a34ae0b14f...eba6e31498b8

2024-03-22 jason-simmons@users.noreply.github.com Post Dart message handling tasks directly to the platform task runner for isolates running on the platform thread (flutter/engine#51573)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7ad647ab

Intensive `if` chain refactoring (#145194) · 7fb35db6

Nate authored Mar 22, 2024

This pull request refactors if-statements into switch expressions, as part of the effort to solve issue #144903.

Making changes beyond just swapping syntax is more difficult (and also more difficult to review, I apologize), but much more satisfying too.

7fb35db6

Adds numpad navigation shortcuts for Linux (#145464) · 859eb2ed

Bruno Leroux authored Mar 22, 2024

## Description

This PR adds shortcuts related to numpad keys on Linux.

## Related Issue

Linux side for https://github.com/flutter/flutter/issues/144936

## Tests

Adds 2 tests.

859eb2ed

Roll Flutter Engine from 5a12de1beab7 to f9a34ae0b14f (1 revision) (#145581) · 5fab92f0

engine-flutter-autoroll authored Mar 22, 2024

https://github.com/flutter/engine/compare/5a12de1beab7...f9a34ae0b14f

2024-03-22 26625149+0xZOne@users.noreply.github.com [Android] Fix the issue of blank or frozen pages in shared engine scenarios (flutter/engine#50947)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5fab92f0

Roll Flutter Engine from e2f324beac3b to 5a12de1beab7 (1 revision) (#145578) · 5058c268

engine-flutter-autoroll authored Mar 22, 2024

https://github.com/flutter/engine/compare/e2f324beac3b...5a12de1beab7

2024-03-21 41930132+hellohuanlin@users.noreply.github.com [ios][platform_view][performance] overlay intersection (flutter/engine#50637)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5058c268

Replace `RenderBox.compute*` with `RenderBox.get*` and add `@visibleForOverriding` (#145503) · d755bc22

LongCatIsLooong authored Mar 22, 2024

`@visibleForOverriding` + `@protected` unfortunately does not catch the case where a `compute*` method was overridden in a subtype and the overide was called in that same type's implementation.

I did not add a `flutter_ignore` for this because it doesn't seem there will be false positives.

d755bc22

Add some cross references in the docs, move an example to a dartpad example (#145571) · 0f685f88

Greg Spencer authored Mar 22, 2024

## Description

This adds some "See also" links to some docs for `TweenAnimationBuilder` and `ValueListenableBuilder`.

Also, moved a "snippet" example in `ValueListenableBuilder` into the examples directory as a Dartpad example.

## Tests
 - Added test for the example.

0f685f88

Fix `BorderSide.none` requiring explicit transparent color for `UnderlineInputBorder` (#145329) · 784f19c4

Bernardo Ferrari authored Mar 22, 2024

Fix could have been "paint transparent when Border none" but, following other Borders, we will just not paint anything.

Fix https://github.com/flutter/flutter/issues/143746

784f19c4

Roll Flutter Engine from a46a7b273a5b to e2f324beac3b (1 revision) (#145576) · e1c64454

engine-flutter-autoroll authored Mar 22, 2024

https://github.com/flutter/engine/compare/a46a7b273a5b...e2f324beac3b

2024-03-21 34871572+gmackall@users.noreply.github.com Make the et feature request link properly add the github label (flutter/engine#51594)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e1c64454

21 Mar, 2024 14 commits

Fix nullability of getFullHeightForCaret (#145554) · 11c034f0

Michael Goderbauer authored Mar 21, 2024

Fixes https://github.com/flutter/flutter/issues/145507.

Looks like this was accidentally migrated to nullable all the way back when we switched to NNBD.

11c034f0

Add a `--no-gradle-generation` mode to the `generate_gradle_lockfiles.dart` script (#145568) · 3b390c52

Gray Mackall authored Mar 21, 2024

The script currently overwrites existing `settings.gradle`, `build.gradle`, and `gradle-wrapper.properties` files in the directories it processes. This mode makes it not do that, and just generate the lockfiles themselves.

Related to https://github.com/flutter/flutter/pull/145564#r1371888460

3b390c52

Roll Flutter Engine from 1b842ae58b3d to a46a7b273a5b (2 revisions) (#145569) · a36569d1

engine-flutter-autoroll authored Mar 21, 2024

https://github.com/flutter/engine/compare/1b842ae58b3d...a46a7b273a5b

2024-03-21 737941+loic-sharma@users.noreply.github.com [Fuchsia] Assert renders are only to the implicit view (flutter/engine#51559)
2024-03-21 737941+loic-sharma@users.noreply.github.com [Embedder API] Fix test helper's present callback registration (flutter/engine#51560)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a36569d1

Fixed race condition in PollingDeviceDiscovery. (#145506) · c759c22e

Lau Ching Jun authored Mar 21, 2024

There are two issues in the previous implementation:
1. `_populateDevices` will return the devices from `deviceNotifier` if it had been initialized, assuming that once it's initialized, it has been properly populated. That assumption is not true because calling getters like `onAdded` would initialize `deviceNotifier` without populating it.
2. `deviceNotifier` instance might be replaced in some cases, causing `onAdded` subscribers to lose any future updates.

To fix (1), this commit added the `isPopulated` field in `deviceNotifier` as a more accurate flag to determine if we need to populate it.

To fix (2), this commit made `deviceNotifier` a final member in `PolingDeviceDiscovery`.

c759c22e

Roll Flutter Engine from a2ed373fa70f to 1b842ae58b3d (1 revision) (#145565) · d69833ce

engine-flutter-autoroll authored Mar 21, 2024

https://github.com/flutter/engine/compare/a2ed373fa70f...1b842ae58b3d

2024-03-21 ian@hixie.ch Add a breadcrumb from FlutterView to PlatformDispatcher. (flutter/engine#51504)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d69833ce

Clarify AutomaticKeepAliveClientMixin semantics in build method (#145297) · afe01503
Ian Hickson authored Mar 21, 2024
```
This should help folks who trace the code before reading the documentation.
```
afe01503
Eliminate more window singleton usages (#145560) · eaf509aa
Michael Goderbauer authored Mar 21, 2024
```
These usages in strings slipped through the initial clean-up.
```
eaf509aa

`flutter test --wasm` support (#145347) · 31209d04

Jackson Gardner authored Mar 21, 2024

* Adds support for `flutter test --wasm`.
  * The test compilation flow is a bit different now, so that it supports compilers other than DDC. Specifically, when we run a set of unit tests, we generate a "switchboard" main function that imports each unit test and runs the main function for a specific one based off of a value set by the JS bootstrapping code. This way, there is one compile step and the same compile output is invoked for each unit test file.
* Also, removes all references to `dart:html` from flutter/flutter.
* Adds CI steps for running the framework unit tests with dart2wasm+skwasm
  * These steps are marked as `bringup: true`, so we don't know what kind of failures they will result in. Any failures they have will not block the tree at all yet while we're still in `bringup: true`. Once this PR is merged, I plan on looking at any failures and either fixing them or disabling them so we can get these CI steps running on presubmit.

This fixes https://github.com/flutter/flutter/issues/126692

31209d04

Roll Flutter Engine from eb262e9c34db to a2ed373fa70f (2 revisions) (#145556) · 98d10b62

engine-flutter-autoroll authored Mar 21, 2024

https://github.com/flutter/engine/compare/eb262e9c34db...a2ed373fa70f

2024-03-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 5724c0dc7846 to b89d2de510d1 (1 revision) (flutter/engine#51584)
2024-03-21 skia-flutter-autoroll@skia.org Roll Skia from 72875d47dbc3 to 14c5a8540691 (1 revision) (flutter/engine#51583)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

98d10b62

Roll Flutter Engine from bad4a30e1c75 to eb262e9c34db (1 revision) (#145555) · 06466008

engine-flutter-autoroll authored Mar 21, 2024

https://github.com/flutter/engine/compare/bad4a30e1c75...eb262e9c34db

2024-03-21 jason-simmons@users.noreply.github.com Move //buildtools to //flutter/buildtools (flutter/engine#51526)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

06466008

Roll Flutter Engine from 7cdb240c4a16 to bad4a30e1c75 (2 revisions) (#145551) · 18340ea1

engine-flutter-autoroll authored Mar 21, 2024

https://github.com/flutter/engine/compare/7cdb240c4a16...bad4a30e1c75

2024-03-21 skia-flutter-autoroll@skia.org Roll Skia from 2ed0d31938e3 to 72875d47dbc3 (1 revision) (flutter/engine#51582)
2024-03-21 skia-flutter-autoroll@skia.org Roll Skia from 5f32b063a869 to 2ed0d31938e3 (1 revision) (flutter/engine#51581)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

18340ea1

Roll Packages from 23e56af4a622 to b7fbe68d4ec2 (3 revisions) (#145547) · dbf06373

engine-flutter-autoroll authored Mar 21, 2024

https://github.com/flutter/packages/compare/23e56af4a622...b7fbe68d4ec2

2024-03-21 38110731+aliasgar4558@users.noreply.github.com [adaptive_scaffold] : ð #141938 - Drawer stays open even on destination tap. (flutter/packages#6289)
2024-03-20 43054281+camsim99@users.noreply.github.com [camera_android] Update README to encourage users to use CameraX implementation (flutter/packages#6353)
2024-03-20 engine-flutter-autoroll@skia.org Roll Flutter from d31a85ba to b96c13d1 (19 revisions) (flutter/packages#6359)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

dbf06373

Add WidgetsApp.debugShowWidgetInspectorOverride again (deprecated) (#145334) · 4bbe6d59

Pascal Welsch authored Mar 21, 2024

`WidgetsApp.debugShowWidgetInspectorOverride` was replaced with ` WidgetsBinding.instance.debugShowWidgetInspectorOverrideNotifier` in https://github.com/flutter/flutter/pull/144029.

The old API was removed, not deprecated.

It is used by some [open-source projects](https://github.com/search?q=WidgetsApp.debugShowWidgetInspectorOverride&type=code), thus I'm making the effort of bringing the API back as deprecated.

Fixes https://github.com/flutter/flutter/issues/145333

4bbe6d59

Reverts "Roll pub packages (#145509)" (#145550) · fd18e5ce

auto-submit[bot] authored Mar 21, 2024

Reverts: flutter/flutter#145509
Initiated by: yusuf-goog
Reason for reverting: Failing builds, blocking tree.
Original PR Author: flutter-pub-roller-bot

Reviewed By: {fluttergithubbot}

This change reverts the following previous change:
This PR was generated by `flutter update-packages --force-upgrade`.

fd18e5ce