Commits · 934d20864d075768e1456c1c0769eebd9cffd641 · abdullh.alsoleman / Front-End

14 Jul, 2023 21 commits

Roll Flutter Engine from 805162c18b32 to c8dbd8a45f79 (2 revisions) (#130596) · 934d2086

engine-flutter-autoroll authored Jul 14, 2023

https://github.com/flutter/engine/compare/805162c18b32...c8dbd8a45f79

2023-07-14 skia-flutter-autoroll@skia.org Roll Skia from b4b9c76206f3 to de6099518f90 (4 revisions) (flutter/engine#43687)
2023-07-14 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from J0oxaSt651gKgDreU... to Z-1lzZAOYHvVrdjQ8... (flutter/engine#43685)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from J0oxaSt651gK to Z-1lzZAOYHvV

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

934d2086

Test cover some leak-free code. (#130543) · d5e7f407
Polina Cherkasova authored Jul 14, 2023

d5e7f407

Add an android migrator to upgrade minSdkVersions 16,17,18 to flutter.minSdkVersion (#129729) · 93919232

gmackall authored Jul 14, 2023

This migrator will upgrade the minSdkVersion used in the [module-level build.gradle](https://developer.android.com/build#module-level) file to flutter.minSdkVersion.

The PR also makes a small refactor to `AndroidProject` to add a getter for the module level build.gradle file, and uses that getter in places where we were getting that file (previously it was being gotten directly via `hostAppGradleRoot.childDirectory('app').childFile('build.gradle')`.

Part of the work for deprecating support for the Jelly Bean android apis.

93919232

Add verbose engine logs for iOS start up tests (#130511) · a903f1de

Victoria Ashworth authored Jul 14, 2023

Added to be able to view logs from https://github.com/flutter/engine/pull/43616.

Added to debug https://github.com/flutter/flutter/issues/129836

a903f1de

Roll Flutter Engine from 6df061859ac7 to 805162c18b32 (1 revision) (#130589) · 79119dfc

engine-flutter-autoroll authored Jul 14, 2023

https://github.com/flutter/engine/compare/6df061859ac7...805162c18b32

2023-07-14 skia-flutter-autoroll@skia.org Roll Skia from 7990401d716a to b4b9c76206f3 (1 revision) (flutter/engine#43681)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

79119dfc

Fix StateError during hot reload when no Dart isolates found (#130537) · b91aedb1
Christopher Fujino authored Jul 14, 2023
```
Fixes https://github.com/flutter/flutter/issues/116262
```
b91aedb1

Roll Flutter Engine from 3a1b12a2fa09 to 6df061859ac7 (2 revisions) (#130583) · f5a5581f

engine-flutter-autoroll authored Jul 14, 2023

https://github.com/flutter/engine/compare/3a1b12a2fa09...6df061859ac7

2023-07-14 skia-flutter-autoroll@skia.org Roll Dart SDK from 8e4eac435b49 to 3701605e0abf (1 revision) (flutter/engine#43679)
2023-07-14 skia-flutter-autoroll@skia.org Roll Skia from 8192de1efc1b to 7990401d716a (1 revision) (flutter/engine#43678)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f5a5581f

Roll Flutter Engine from 427ceaf089bd to 3a1b12a2fa09 (1 revision) (#130577) · 5cbccc4d

engine-flutter-autoroll authored Jul 14, 2023

https://github.com/flutter/engine/compare/427ceaf089bd...3a1b12a2fa09

2023-07-14 kustermann@google.com Use utf8.encode() instead of longer const Utf8Encoder.convert() (flutter/engine#43675)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5cbccc4d

Fix finish translation for tab labels (#130333) · ef312048

Bruno Leroux authored Jul 14, 2023

## Description

This PR update the finnish translations for tab label.

## Related Issue

fixes https://github.com/flutter/flutter/issues/110451

## Tests

Adds 2 tests.

ef312048

Revert "Update `DialogTheme` tests for M2/M3" (#130578) · b8fa9233

Zachary Anderson authored Jul 14, 2023

Reverts flutter/flutter#130414

Skia gold failures https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20framework_tests_libraries/11972/overview

b8fa9233

Roll Flutter Engine from fcecec871aae to 427ceaf089bd (3 revisions) (#130563) · a65e7394

engine-flutter-autoroll authored Jul 14, 2023

https://github.com/flutter/engine/compare/fcecec871aae...427ceaf089bd

2023-07-14 skia-flutter-autoroll@skia.org Roll Skia from 2848267f631d to 8192de1efc1b (1 revision) (flutter/engine#43672)
2023-07-14 skia-flutter-autoroll@skia.org Roll Dart SDK from 8f49edfb6989 to 8e4eac435b49 (1 revision) (flutter/engine#43671)
2023-07-14 skia-flutter-autoroll@skia.org Roll Skia from ffed127e8974 to 2848267f631d (3 revisions) (flutter/engine#43670)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a65e7394

Update `DialogTheme` tests for M2/M3 (#130414) · feab8545

Taha Tesser authored Jul 14, 2023

Updated unit tests for `DialogTheme` to have M2 and M3 versions.

More info in https://github.com/flutter/flutter/pull/128725

feab8545

Roll Flutter Engine from 0428c9d53e99 to fcecec871aae (1 revision) (#130561) · 4320abbd

engine-flutter-autoroll authored Jul 14, 2023

https://github.com/flutter/engine/compare/0428c9d53e99...fcecec871aae

2023-07-14 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from -csWUV7Dv3hETOoDw... to LZPMbHnVPFdbXndcX... (flutter/engine#43669)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from -csWUV7Dv3hE to LZPMbHnVPFdb

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4320abbd

Tap on button behind snack bar defined by margin (#127959) · c3cd0166

lsaudon authored Jul 14, 2023

If the margin is used, set the `HitTestBehavior` to `deferToChild`. 

*List which issues are fixed by this PR. You must list at least one issue.*
#78537 
#114810 

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

c3cd0166

Roll Flutter Engine from 8d14461f7bc3 to 0428c9d53e99 (1 revision) (#130556) · e90f980f

engine-flutter-autoroll authored Jul 14, 2023

https://github.com/flutter/engine/compare/8d14461f7bc3...0428c9d53e99

2023-07-14 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from rRUd41Mv9NI0n3Iyc... to J0oxaSt651gKgDreU... (flutter/engine#43667)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from rRUd41Mv9NI0 to J0oxaSt651gK

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e90f980f

Roll Flutter Engine from 2262a871c10a to 8d14461f7bc3 (1 revision) (#130555) · 4c0c8c30

engine-flutter-autoroll authored Jul 14, 2023

https://github.com/flutter/engine/compare/2262a871c10a...8d14461f7bc3

2023-07-14 skia-flutter-autoroll@skia.org Roll Skia from 9e4f5cc3aeb4 to ffed127e8974 (1 revision) (flutter/engine#43666)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4c0c8c30

Roll Flutter Engine from 77d8ec0a096c to 2262a871c10a (1 revision) (#130551) · a6fb2e0a

engine-flutter-autoroll authored Jul 14, 2023

https://github.com/flutter/engine/compare/77d8ec0a096c...2262a871c10a

2023-07-14 skia-flutter-autoroll@skia.org Roll Dart SDK from 9506d0c9f5ef to 8f49edfb6989 (1 revision) (flutter/engine#43665)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a6fb2e0a

Roll Flutter Engine from 601f0c173b8e to 77d8ec0a096c (2 revisions) (#130549) · 90ed1dfa

engine-flutter-autoroll authored Jul 14, 2023

https://github.com/flutter/engine/compare/601f0c173b8e...77d8ec0a096c

2023-07-14 ian@hixie.ch Add more points to [MediaQuery]. (flutter/engine#43649)
2023-07-14 ian@hixie.ch Remove unimplemented API call saveCompilationTrace (flutter/engine#43656)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

90ed1dfa

Mention saveLayer in the CustomPainter docs. (#130520) · 46125d07
Ian Hickson authored Jul 14, 2023
```
Fixes https://github.com/flutter/flutter/issues/11002
```
46125d07

Roll Flutter Engine from 8a42bfc80e3a to 601f0c173b8e (1 revision) (#130544) · c01d2b7f

engine-flutter-autoroll authored Jul 14, 2023

https://github.com/flutter/engine/compare/8a42bfc80e3a...601f0c173b8e

2023-07-13 jason-simmons@users.noreply.github.com Fix a clang-tidy warning about a potentially nil value in the editingState dictionary (flutter/engine#43660)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c01d2b7f

Roll Flutter Engine from 0f0436b28430 to 8a42bfc80e3a (6 revisions) (#130538) · a7a353ca

engine-flutter-autoroll authored Jul 14, 2023

https://github.com/flutter/engine/compare/0f0436b28430...8a42bfc80e3a

2023-07-13 skia-flutter-autoroll@skia.org Roll Skia from 52613fcc0780 to 9e4f5cc3aeb4 (1 revision) (flutter/engine#43659)
2023-07-13 jonahwilliams@google.com [Impeller] no-op fragment program on Android until it works. (flutter/engine#43657)
2023-07-13 31859944+LongCatIsLooong@users.noreply.github.com Reland #43118 "Add a flag to ParagraphBuilder for rounding hack migration" (flutter/engine#43647)
2023-07-13 ychris@google.com Unmerge threads if the current merger is the only one that's merged. (flutter/engine#43652)
2023-07-13 dnfield@google.com Revert https://github.com/flutter/engine/pull/43533 (flutter/engine#43654)
2023-07-13 skia-flutter-autoroll@skia.org Roll Skia from 743ad92f5de2 to 52613fcc0780 (9 revisions) (flutter/engine#43655)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a7a353ca

13 Jul, 2023 19 commits

Fix `timeOfDayFormat` for Danish (#130437) · bd18e78c

Tae Hyung Kim authored Jul 13, 2023

See title. According to
[CLDR](https://icu4c-demos.unicode.org/icu-bin/locexp?_=da_DK&d_=en&_l=da),
proper time of day format should be `HH.mm`.

Fixes https://github.com/flutter/flutter/issues/130234.

bd18e78c

Upgrade leak_tracker. (#130528) · 26a17a4c
Polina Cherkasova authored Jul 13, 2023

26a17a4c

Roll Flutter Engine from 1867efbf2936 to 0f0436b28430 (1 revision) (#130526) · 7abdb866

engine-flutter-autoroll authored Jul 13, 2023

https://github.com/flutter/engine/compare/1867efbf2936...0f0436b28430

2023-07-13 jason-simmons@users.noreply.github.com Fix a Fuchsia formatter type mismatch flagged by the pending Clang roll (flutter/engine#43651)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7abdb866

Always escape when writing pubspec.yaml's 'description' field. (#130096) · 03749051

Matan Lurey authored Jul 13, 2023

Closes https://github.com/flutter/flutter/issues/80013.

**Before**:

```
$ flutter create test1 --description "a: b"
Creating project test1...
Error detected in pubspec.yaml:
Error on line 2, column 15: Mapping values are not allowed here. Did you miss a colon earlier?
  â·
2 â description: a: b
  â               ^
  âµ
Please correct the pubspec.yaml file at /Users/matan/Developer/scratch/test1/pubspec.yaml
```

**After**:

```
$ flutter create test1 --description "a: b"
Creating project test1...
Resolving dependencies in test1... 
Got dependencies in test1.
Wrote 129 files.

All done!
You can find general documentation for Flutter at: https://docs.flutter.dev/
Detailed API documentation is available at: https://api.flutter.dev/
If you prefer video documentation, consider: https://www.youtube.com/c/flutterdev

In order to run your application, type:

  $ cd test1
  $ flutter run

Your application code is in test1/lib/main.dart.
```

---

It's worth noting that this _always_ escapes a non-empty project description, which means that descriptions that were not previously wrapped in `"`s' will be. I'm not sure how worth it is to do a _conditional_ escape (i.e. only escape if not escaping would cause a problem), but willing to change.

Side-note: I had no idea where to list this test in the (very large) `create_test.dart`, so I did my best :)

03749051

Update `CardTheme`, `DrawerTheme`, `NavigationBar`, and `NavigationRailTheme`... · 7fc49906

Qun Cheng authored Jul 13, 2023

Update `CardTheme`, `DrawerTheme`, `NavigationBar`, and `NavigationRailTheme` tests for M2/M3 (#130047)

Updated unit tests for `CardTheme`, `DrawerTheme`, `NavigationBar`, and `NavigationRailTheme` to have M2 and M3 versions.

More info in https://github.com/flutter/flutter/issues/127064

7fc49906

Move straggling Android Impeller test to staging. (#130529) · e1d025ae
Zachary Anderson authored Jul 13, 2023

e1d025ae

Roll Flutter Engine from c31cfc517274 to 1867efbf2936 (1 revision) (#130517) · f8c91165

engine-flutter-autoroll authored Jul 13, 2023

https://github.com/flutter/engine/compare/c31cfc517274...1867efbf2936

2023-07-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 16ddfe8d08e0 to 9506d0c9f5ef (1 revision) (flutter/engine#43646)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f8c91165

Fix .env regex constants (#130072) · 99efd1b5

Piotr FLEURY authored Jul 13, 2023

Set `.env` regex list as constants.

This pull request fixes the nit related in this comment: https://github.com/flutter/flutter/pull/128668#discussion_r1253377454

99efd1b5

Inspector should not hold callback from garbage collection. (#130436) · 3c2cd015
Polina Cherkasova authored Jul 13, 2023

3c2cd015
mark android impeller tests as bringup (#130525) · 0e543889
Jonah Williams authored Jul 13, 2023
```
These should not close the tree as this backend is a WIP.
```
0e543889
[web] Migrate web-only initialization APIs (#129856) · 87d5214d
Mouad Debbar authored Jul 13, 2023
```
- `ui_web.warmupEngine`
- `ui_web.setPluginHandler`
- `ui_web.debugEmulateFlutterTesterEnvironment`
```
87d5214d
Change the default for`ThemeData.useMaterial3` to true (#129724) · 157660af
Hans Muller authored Jul 13, 2023
```
Changes the default for `ThemeData.useMaterial3` to true.

See https://github.com/flutter/flutter/issues/127064
```
157660af

Roll Flutter Engine from 081fbab5f277 to c31cfc517274 (5 revisions) (#130512) · 360ca44e

engine-flutter-autoroll authored Jul 13, 2023

https://github.com/flutter/engine/compare/081fbab5f277...c31cfc517274

2023-07-13 jonahwilliams@google.com [Impeller] Switch back to using explicit flush for device buffers. (flutter/engine#43644)
2023-07-13 15619084+vashworth@users.noreply.github.com Add logs to debug VM Service Publication (flutter/engine#43616)
2023-07-13 31859944+LongCatIsLooong@users.noreply.github.com Revert "Add a flag to `ParagraphBuilder` for rounding hack migration" (flutter/engine#43642)
2023-07-13 47866232+chunhtai@users.noreply.github.com [web] TextField a11y focus should call didGain/didLose a11y focus action (flutter/engine#43279)
2023-07-13 john@johnmccutchan.com Improve Stencil Playground test (flutter/engine#43641)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

360ca44e

Reland "Print pretty error when xcodebuild fails due to missing simulator #130286" (#130506) · 2892b575

Victoria Ashworth authored Jul 13, 2023

Reland https://github.com/flutter/flutter/pull/130286 with fix.

It failed the first time because of a discrepancy between the master branch and my branch (see https://github.com/flutter/flutter/pull/130504#issue-1803449182 for more info).

2892b575

PlatformRouteInformationProvider does not push new entry if query par… (#130457) · 315ebafe

chunhtai authored Jul 13, 2023

â¦ameter is semanticsally the same

The URI compare does not taking into account that query parameter may or may not be encoded, or the parameters' order can be different. However, they are all semantically the same.

This pr makes PlatformRouteInformationProvider to take those into account when deciding whether it should push/replace the browser history entry.

315ebafe

Upgrade leak_tracker. (#130507) · 5870159e
Polina Cherkasova authored Jul 13, 2023

5870159e

Roll Flutter Engine from 88b858151685 to 081fbab5f277 (3 revisions) (#130508) · a3ca2677

engine-flutter-autoroll authored Jul 13, 2023

https://github.com/flutter/engine/compare/88b858151685...081fbab5f277

2023-07-13 skia-flutter-autoroll@skia.org Roll Skia from c2d28b15c246 to 743ad92f5de2 (4 revisions) (flutter/engine#43640)
2023-07-13 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from xBJq6PsO5ebblODMe... to -csWUV7Dv3hETOoDw... (flutter/engine#43639)
2023-07-13 skia-flutter-autoroll@skia.org Roll Skia from 56b68ce6196c to c2d28b15c246 (1 revision) (flutter/engine#43638)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from xBJq6PsO5ebb to -csWUV7Dv3hE

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a3ca2677

Mark leak in text_form_field_test.dart. (#130468) · 8e806636
Polina Cherkasova authored Jul 13, 2023

8e806636

Roll Flutter Engine from b4080361f2f9 to 88b858151685 (3 revisions) (#130502) · 7179ca96

engine-flutter-autoroll authored Jul 13, 2023

https://github.com/flutter/engine/compare/b4080361f2f9...88b858151685

2023-07-13 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 3C7P0w8ySmtqpyi3S... to rRUd41Mv9NI0n3Iyc... (flutter/engine#43635)
2023-07-13 skia-flutter-autoroll@skia.org Roll Dart SDK from ade4dae923f3 to 16ddfe8d08e0 (1 revision) (flutter/engine#43634)
2023-07-13 jason-simmons@users.noreply.github.com Apply the transform of an image filter layer to paint bounds in the CanvasKit backend (flutter/engine#43353)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 3C7P0w8ySmtq to rRUd41Mv9NI0

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7179ca96