Skip to content

F
Front-End
Switch branch/tag
  1. 08 Feb, 2023 8 commits
    • Mouad Debbar's avatar
      Revert "Stop recursively including assets from asset folders (#120167)" (#120283) · 7f578fb0
      Mouad Debbar authored 
      This reverts commit da36bd6f.
      7f578fb0
    • Qun Cheng's avatar
      Add trackOutlineColor for Switch and SwitchListTile (#120140) · 3f98c0f8
      Qun Cheng authored 
      * Add trackOutlineColor for Switch and SwitchListTile

* Update tests

* Update test

* Clean up unnecessary StatefulBUilder in tests

* Fix failed test

---------
Co-authored-by: 's avatarQun Cheng <quncheng@google.com>
      3f98c0f8
    • xubaolin's avatar
      fix a TextFormField bug (#120182) · 6e7f5803
      xubaolin authored 
      * fix a TextFormField bug

* review feedback
      6e7f5803
    • Zachary Anderson's avatar
      Revert "Roll Flutter Engine from f310ffd1461a to 7098858dc0a5 (9 revisions) (#120251)" (#120257) · 1e6e6d41
      Zachary Anderson authored 
      This reverts commit f94fa7ea.
      1e6e6d41
    • Renzo Olivares's avatar
      Add support for extending selection to paragraph on ctrl + shift + arrow... · 99b6bd8c
      Renzo Olivares authored 
      Add support for extending selection to paragraph on ctrl + shift + arrow up/down on Non-Apple platforms (#120151)

* Add support for extending selection to paragraph on ctrl + shift + arrow up/down for common keyboard actions

* Add ctrl + shift + arrow up/down common text editing shortcuts/actions

* fix analyzer

---------
Co-authored-by: 's avatarRenzo Olivares <roliv@google.com>
      99b6bd8c
    • engine-flutter-autoroll's avatar
      Roll Flutter Engine from f310ffd1461a to 7098858dc0a5 (9 revisions) (#120251) · f94fa7ea
      engine-flutter-autoroll authored 
      * 0e25c0a1c [impeller] ensure full glyphs respect alpha (flutter/engine#39377)

* 684cfe292 Add helpers for updating arm tools in CIPD (flutter/engine#39458)

* e6cf1c532 Roll Skia from 87dbc81b421f to bd48f82dcabb (8 revisions) (flutter/engine#39459)

* bf8547dd9 Override _accessibilityHitTest to fix IOS 16 semantics issues  (flutter/engine#38794)

* 2e225eb6b Manual roll Dart SDK from a507a9057730 to 5c74c8b64dec (9 revisions) (flutter/engine#39462)

* ca05af79e [Windows] Remove accessibility root assumptions (flutter/engine#39441)

* 3e9eb95ea Roll Skia from bd48f82dcabb to f30529658275 (7 revisions) (flutter/engine#39463)

* 85958c2ea Update malioc analysis golden file (flutter/engine#39461)

* 7098858dc Roll Fuchsia Mac SDK from zYEsaCaA1cokDUU43... to uYw6cCpJIpQa42G4O... (flutter/engine#39466)
      f94fa7ea
    • Greg Price's avatar
      Add test for RenderProxyBoxMixin; clarify doc, resolve TODO (#117664) · cd125e1f
      Greg Price authored 
      * Add test for RenderProxyBoxMixin; clarify doc, resolve TODO

The TODO comment suggested this mixin would no longer be needed once
a Dart issue on inherited constructors was fixed:
  https://github.com/dart-lang/sdk/issues/31543
That issue is now long since fixed, so I went to go carry out the TODO.

But in doing so, I realized that the mixin's documentation was more
right than the TODO comment: even with that issue fixed, there is a
legitimate use case for this mixin, namely to reuse the implementation
of RenderProxyBox in a class that also inherits from some other base
class.  Moreover, searching GitHub I found an example of a library
that makes real use of that capability.

So I think the right resolution is to accept that this separation
is useful and delete the TODO.

Then, add a test with an extremely simplified sketch of that
real-world example.  In case someone in the future attempts to
simplify this mixin away, the test will point us at the use case
that would be broken by such a change.

Also remove the only in-tree use of the mixin, which was redundant;
and expand the mixin's documentation to advise about that case.

* Tweak formatting
Co-authored-by: 's avatarMichael Goderbauer <goderbauer@google.com>

* Cut comments

---------
Co-authored-by: 's avatarMichael Goderbauer <goderbauer@google.com>
      cd125e1f
    • Greg Price's avatar
      Fix hang on successful dev/bots/analyze.dart (#117660) · 98b3e48e
      Greg Price authored 
      Fixes #117659

It turns out this was due to the output-suppression timer introduced
recently as part of cleaning up the output (#109206); on success, the
script would wait 10 minutes for the timeout to expire.  This didn't
affect CI because this feature doesn't apply in CI (as detected by
lack of color on stdout.)

Fix the issue by cleaning up the timer on success in the same way
as on failure.

While here, clean up the final summary messages slightly,
and also cut the trailing space that printProgress was leaving
on each line.
      98b3e48e
  3. 07 Feb, 2023 20 commits
  5. 06 Feb, 2023 9 commits
  7. 05 Feb, 2023 3 commits

HIAST - GitLab