Commits · 7aa01f53f84103063c9cb5e120d3b0803bdd03cf · abdullh.alsoleman / Front-End

21 Apr, 2023 3 commits

Roll Flutter Engine from 2db85cbe6a01 to 122c3b382012 (22 revisions) (#125271) · 7aa01f53

engine-flutter-autoroll authored Apr 21, 2023

https://github.com/flutter/engine/compare/2db85cbe6a01...122c3b382012

2023-04-21 737941+loic-sharma@users.noreply.github.com [Windows] Don't
block raster thread until v-blank (flutter/engine#41231)
2023-04-21 chillers@google.com Manual roll skia to d5b4acfb4
(flutter/engine#41378)
2023-04-21 magder@google.com Run mac unopt arm builds with arm toolchain
(flutter/engine#41353)
2023-04-20 zanderso@users.noreply.github.com Revert "re-land "Migrate
mac_host_engine to engine v2 builds." (#41233)"" (flutter/engine#41380)
2023-04-20 skia-flutter-autoroll@skia.org Roll Dart SDK from
df05e451b79a to 50b96abe9f6f (1 revision) (flutter/engine#41379)
2023-04-20 109111084+yaakovschectman@users.noreply.github.com Move
ownership of `AccessibilityBridgeWindows` to `FlutterWindowsView`
(flutter/engine#41308)
2023-04-20 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
AoPEjX8Xfq1v0h4kx... to PqBDstaESE_l77k1e... (flutter/engine#41373)
2023-04-20 godofredoc@google.com Revert "Upload windows arm artifacts to
production bucket." (flutter/engine#41372)
2023-04-20 godofredoc@google.com re-land "Migrate mac_host_engine to
engine v2 builds." (#41233)" (flutter/engine#41323)
2023-04-20 godofredoc@google.com Upload windows arm artifacts to
production bucket. (flutter/engine#41324)
2023-04-20 jason-simmons@users.noreply.github.com [Impeller] Change the
default color format for the GLES backend to RGBA (flutter/engine#41342)
2023-04-20 maRci002@users.noreply.github.com [web] change status bar
color based on SystemUiOverlayStyle (flutter/engine#40599)
2023-04-20 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
OcPCdaE17MAihaCrD... to 4OrPF9lzqCKGwBLRh... (flutter/engine#41367)
2023-04-20 skia-flutter-autoroll@skia.org Roll Skia from fc09f9b2fb27 to
f4609aa2eaba (1 revision) (flutter/engine#41366)
2023-04-20 skia-flutter-autoroll@skia.org Roll Dart SDK from
7d165bd0bb5e to df05e451b79a (2 revisions) (flutter/engine#41365)
2023-04-20 skia-flutter-autoroll@skia.org Roll Skia from 80c38970791e to
fc09f9b2fb27 (1 revision) (flutter/engine#41362)
2023-04-20 skia-flutter-autoroll@skia.org Roll Skia from c50081c62219 to
80c38970791e (2 revisions) (flutter/engine#41360)
2023-04-20 skia-flutter-autoroll@skia.org Roll Skia from c21e7df194c3 to
c50081c62219 (11 revisions) (flutter/engine#41358)
2023-04-20 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
Tun7i4VLz6ncx8JJJ... to AoPEjX8Xfq1v0h4kx... (flutter/engine#41357)
2023-04-20 skia-flutter-autoroll@skia.org Roll Dart SDK from
88a3b66b50d6 to 7d165bd0bb5e (1 revision) (flutter/engine#41356)
2023-04-20 jason-simmons@users.noreply.github.com Manual Skia roll from
ad90b6bd4760 to c21e7df194c3 (flutter/engine#41341)
2023-04-20 jonahwilliams@google.com [impeller] convert src over to src
for solid color (flutter/engine#41351)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from Tun7i4VLz6nc to PqBDstaESE_l
  fuchsia/sdk/core/mac-amd64 from OcPCdaE17MAi to 4OrPF9lzqCKG

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7aa01f53

When searching for the JDK bundled with an unrecognized version of Android... · cf76b24d

Andrew Kolos authored Apr 21, 2023

When searching for the JDK bundled with an unrecognized version of Android Studio, assume the version to be the latest (#125247)

Fixes #125246 by restoring the intended behavior of #101862. That is, when searching for a JDK and we encounter an Android Studio version we don't recognize, assume it to be the latest version `flutter` is aware of.

Also does some light refactoring in the tests, like using test objects instead of referencing `globals`.

cf76b24d

[ci.yaml] Remove unnecessary use of { (#125058) · 7d2669b8

Casey Hillers authored Apr 21, 2023

In yaml, indented blocks indicate the following fields are children of the parent indent. The use of curly brackets is unnecessary here

7d2669b8

20 Apr, 2023 21 commits

Updated the BottomNavigationBar API doc to link to NavigationBar (#125240) · 5d3c1ca8

Hans Muller authored Apr 20, 2023

The BottomNavigationBar API doc now makes it clear that NavigationBar is preferred in new M3 applications.

Fixes https://github.com/flutter/flutter/issues/124687

5d3c1ca8

Bump codecov/codecov-action from 3.1.2 to 3.1.3 (#125253) · a6ea22c2

dependabot[bot] authored Apr 20, 2023

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3.1.2 to 3.1.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/codecov/codecov-action/releases">codecov/codecov-action's releases</a>.</em></p>
<blockquote>
<h2>3.1.3</h2>
<h2>What's Changed</h2>
<ul>
<li>build(deps-dev): bump jest-junit from 15.0.0 to 16.0.0 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/957">codecov/codecov-action#957</a></li>
<li>build(deps): bump openpgp from 5.7.0 to 5.8.0 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/958">codecov/codecov-action#958</a></li>
<li>build(deps-dev): bump <code>@âtypes/node</code> from 18.15.10 to 18.15.12 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/959">codecov/codecov-action#959</a></li>
<li>fix: allow for aarch64 build by <a href="https://github.com/thomasrockhu-codecov"><code>@âthomasrockhu-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/960">codecov/codecov-action#960</a></li>
<li>chore(release): bump to 3.1.3 by <a href="https://github.com/thomasrockhu-codecov"><code>@âthomasrockhu-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/961">codecov/codecov-action#961</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/codecov/codecov-action/compare/v3.1.2...v3.1.3">https://github.com/codecov/codecov-action/compare/v3.1.2...v3.1.3</a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md">codecov/codecov-action's changelog</a>.</em></p>
<blockquote>
<h2>3.1.3</h2>
<h3>Fixes</h3>
<ul>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/960">#960</a> fix: allow for aarch64 build</li>
</ul>
<h3>Dependencies</h3>
<ul>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/957">#957</a> build(deps-dev): bump jest-junit from 15.0.0 to 16.0.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/958">#958</a> build(deps): bump openpgp from 5.7.0 to 5.8.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/959">#959</a> build(deps-dev): bump <code>@âtypes/node</code> from 18.15.10 to 18.15.12</li>
</ul>
<h2>3.1.2</h2>
<h3>Fixes</h3>
<ul>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/718">#718</a> Update README.md</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/851">#851</a> Remove unsupported path_to_write_report argument</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/898">#898</a> codeql-analysis.yml</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/901">#901</a> Update README to contain correct information - inputs and negate feature</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/955">#955</a> fix: add in all the extra arguments for uploader</li>
</ul>
<h3>Dependencies</h3>
<ul>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/819">#819</a> build(deps): bump openpgp from 5.4.0 to 5.5.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/835">#835</a> build(deps): bump node-fetch from 3.2.4 to 3.2.10</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/840">#840</a> build(deps): bump ossf/scorecard-action from 1.1.1 to 2.0.4</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/841">#841</a> build(deps): bump <code>@âactions/core</code> from 1.9.1 to 1.10.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/843">#843</a> build(deps): bump <code>@âactions/github</code> from 5.0.3 to 5.1.1</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/869">#869</a> build(deps): bump node-fetch from 3.2.10 to 3.3.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/872">#872</a> build(deps-dev): bump jest-junit from 13.2.0 to 15.0.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/879">#879</a> build(deps): bump decode-uri-component from 0.2.0 to 0.2.2</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/889">#889</a> build(deps): bump ossf/scorecard-action from 1.1.1 to 2.1.2</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/895">#895</a> build(deps): bump json5 from 2.2.1 to 2.2.3</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/896">#896</a> build(deps): bump actions/upload-artifact from 3.1.0 to 3.1.2</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/900">#900</a> build(deps-dev): bump <code>@âvercel/ncc</code> from 0.34.0 to 0.36.1</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/905">#905</a> build(deps-dev): bump typescript from 4.7.4 to 4.9.5</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/911">#911</a> build(deps-dev): bump <code>@âtypes/node</code> from 16.11.40 to 18.13.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/922">#922</a> build(deps-dev): bump <code>@âtypes/node</code> from 18.13.0 to 18.14.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/924">#924</a> build(deps): bump openpgp from 5.5.0 to 5.7.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/927">#927</a> build(deps-dev): bump <code>@âtypes/node</code> from 18.14.0 to 18.14.2</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/933">#933</a> build(deps-dev): bump <code>@âtypes/node</code> from 18.14.2 to 18.14.6</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/937">#937</a> build(deps-dev): bump <code>@âtypes/node</code> from 18.14.6 to 18.15.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/938">#938</a> build(deps): bump node-fetch from 3.3.0 to 3.3.1</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/945">#945</a> build(deps-dev): bump <code>@âtypes/node</code> from 18.15.0 to 18.15.5</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/946">#946</a> build(deps-dev): bump <code>@âtypes/node</code> from 18.15.5 to 18.15.6</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/947">#947</a> build(deps-dev): bump <code>@âtypes/node</code> from 18.15.6 to 18.15.10</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/951">#951</a> build(deps): bump ossf/scorecard-action from 2.1.2 to 2.1.3</li>
</ul>
<h2>3.1.1</h2>
<h3>Fixes</h3>
<ul>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/661">#661</a> Update deprecation warning</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/593">#593</a> Create codeql-analysis.yml</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/712">#712</a> README: fix typo</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/725">#725</a> fix: Remove a blank row</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/726">#726</a> Update README.md with correct badge version</li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/codecov/codecov-action/commit/894ff025c7b54547a9a2a1e9f228beae737ad3c2"><code>894ff02</code></a> chore(release): bump to 3.1.3 (<a href="https://redirect.github.com/codecov/codecov-action/issues/961">#961</a>)</li>
<li><a href="https://github.com/codecov/codecov-action/commit/f539f977d5cdbb5a53de48bb2c00ae0dbf703e69"><code>f539f97</code></a> fix: allow for aarch64 build (<a href="https://redirect.github.com/codecov/codecov-action/issues/960">#960</a>)</li>
<li><a href="https://github.com/codecov/codecov-action/commit/6757614f24a05cb3f8641137b1ed46ed44d19fbc"><code>6757614</code></a> build(deps-dev): bump <code>@âtypes/node</code> from 18.15.10 to 18.15.12 (<a href="https://redirect.github.com/codecov/codecov-action/issues/959">#959</a>)</li>
<li><a href="https://github.com/codecov/codecov-action/commit/cdee249da5411c0de7550d8f03ba0ca2902f3de7"><code>cdee249</code></a> build(deps): bump openpgp from 5.7.0 to 5.8.0 (<a href="https://redirect.github.com/codecov/codecov-action/issues/958">#958</a>)</li>
<li><a href="https://github.com/codecov/codecov-action/commit/ce548e935a76bfa6d8d3d8ed7c23270a154efc82"><code>ce548e9</code></a> build(deps-dev): bump jest-junit from 15.0.0 to 16.0.0 (<a href="https://redirect.github.com/codecov/codecov-action/issues/957">#957</a>)</li>
<li>See full diff in <a href="https://github.com/codecov/codecov-action/compare/40a12dcee2df644d47232dde008099a3e9e4f865...894ff025c7b54547a9a2a1e9f228beae737ad3c2">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=codecov/codecov-action&package-manager=github_actions&previous-version=3.1.2&new-version=3.1.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

a6ea22c2

BottomAppBar doc: Fix doc about surfaceTintColor (#124563) · 58e30852
Chris Bobbe authored Apr 20, 2023

58e30852

Toolbar should re-appear on drag end (#125165) · 01b4dd5e

Renzo Olivares authored Apr 20, 2023

#125151 introduced the magnifier on touch drag gestures, but when showing the magnifier the toolbar is implicitly hidden, this change makes the toolbar re-appear on drag end for double tap + drag.

01b4dd5e

Remove uses of deprecated test_api imports (#124732) · dcfd35f8

Nate Bosch authored Apr 20, 2023

Most of these imports were never appropriate. The `test_api` package was never intended for use in `_test.dart` files.
Where possible move imports to `matcher`, otherwise move them to `test` or `flutter_test`.

Leave uses of `test_api` from `flutter_test` library code.

dcfd35f8

Remove dynamic calls (#125238) · 55825f16

Ian Hickson authored Apr 20, 2023

I don't know what I was thinking when I wrote this code back in 2017 but this is so trivially fixable...

55825f16

Revert "Sliver Constrained Cross Axis" (#125233) · 9caabdd2

Tae Hyung Kim authored Apr 20, 2023

Going to make some changes to the implementation so I'll revert in the meantime.

Reverts flutter/flutter#124337

9caabdd2

Implement CheckmarkableChipAttributes on ChoiceChip (#124743) · 0c7bc2f9
9oya authored Apr 20, 2023

0c7bc2f9
Roll pub packages (#125225) · d85e2fb8
Flutter GitHub Bot authored Apr 20, 2023
```
This PR was generated by `flutter update-packages --force-upgrade`.
```
d85e2fb8
fix localization typo for expansionTileExpandedHint (#125212) · 5764404f
chunhtai authored Apr 20, 2023
```
as title
```
5764404f

Show iOS menu on iOS for TextField by default (#124895) · 13f4fe40

Justin McCandless authored Apr 20, 2023

Even in TextField using the Material library, iOS devices will still show the iOS-style spell check toolbar by default when using spell check.

13f4fe40

Fix race condition in flutter test when passing --serve-observatory (#123556) · 0d023144

Ben Konyi authored Apr 20, 2023

`flutter test` wasn't awaiting the `_serveObservatory` request which was
causing a race condition in the `flutter test should respect
--serve-observatory` test in `test/integration.general/test_test.dart`.

Related to https://github.com/flutter/flutter/issues/123516

0d023144

Roll pub packages (#125050) · a573d1ae
Flutter GitHub Bot authored Apr 20, 2023
```
This PR was generated by `flutter update-packages --force-upgrade`.
```
a573d1ae

[flutter_tools] make overall_experience_test resilient to extraneous pub output (#125172) · 800175af

Christopher Fujino authored Apr 20, 2023

use `containsAllInOrder` so that pub output doesn't cause htis test to fail, as in https://ci.chromium.org/p/flutter/builders/try/Linux%20tool_tests_general/22929?

800175af

MinimumTapTargetGuideline skips nodes at scrollable boundaries (#124615) · 8ac94c16

chunhtai authored Apr 20, 2023

fixes https://github.com/flutter/flutter/issues/107615

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

8ac94c16

Roll Packages from 88591becfb3f to 746750ecef78 (4 revisions) (#125208) · 70ca4697

engine-flutter-autoroll authored Apr 20, 2023

https://github.com/flutter/packages/compare/88591becfb3f...746750ecef78

2023-04-20 stuartmorgan@google.com [pigeon] Add an initial example app (flutter/packages#3761)
2023-04-20 imagipioneer@gmail.com [google_maps_flutter_web] Allow marker position updates (flutter/packages#3697)
2023-04-19 tarrinneal@gmail.com [Tool] [Code Excerpt] allow excerpts in example readme (flutter/packages#3758)
2023-04-19 47866232+chunhtai@users.noreply.github.com [go_router] migrates test for route information.location deprecation (flutter/packages#3763)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

70ca4697

i125138 abstract method smoke agp update (#125139) · 64591356

Reid Baker authored Apr 20, 2023

- Update gradle and AGP version for abstract_method_smoke_test
#125138 part 1/N

 To update successfully:
    1. Update gradle to a version supported by jdk 17
    2. Uncommented the lockfile lines in android/build.gradle
    3. Then ran the AGP update assistant from AndroidStudio -> tools
    4. From android ran `./gradlew dependencies --write-locks`
    5. From android/app ran `./gradlew dependencies --write-locks`
    6. Re enabled the lockfiles section of android/build.gradle
    7. Ensured `flutter build apk` passed

64591356

`DropdownMenu.width` should support updating at runtime (#124847) · 9f2e7088
xubaolin authored Apr 20, 2023
```
Fixes https://github.com/flutter/flutter/issues/120567
```
9f2e7088

Roll Flutter Engine from d726345bf230 to 2db85cbe6a01 (4 revisions) (#125183) · b04efe4e

engine-flutter-autoroll authored Apr 20, 2023

https://github.com/flutter/engine/compare/d726345bf230...2db85cbe6a01

2023-04-20 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from suSuT9F8zuP-pBg-E... to OcPCdaE17MAihaCrD... (flutter/engine#41352)
2023-04-19 skia-flutter-autoroll@skia.org Roll Dart SDK from fe8bb0565a30 to 88a3b66b50d6 (2 revisions) (flutter/engine#41349)
2023-04-19 bdero@google.com Add missing header guards (flutter/engine#41322)
2023-04-19 joshualitt@google.com [web] Fix trivial type issue. (flutter/engine#40956)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from suSuT9F8zuP- to OcPCdaE17MAi

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b04efe4e

Make search view shape clip the view content (#125161) · 3315b257

Qun Cheng authored Apr 20, 2023

Fixes #124426

This PR is to make the search view shape clip the view content.

Before: the highlight and the "i" of "item 9" are not clipped by the shape.

<img width="350" alt="Screenshot 2023-04-19 at 12 09 48 PM" src="https://user-images.githubusercontent.com/36861262/233201222-468820a9-8717-4b6c-8528-8125a40fc161.png">

After:

<img width="350" alt="Screenshot 2023-04-19 at 2 13 52 PM" src="https://user-images.githubusercontent.com/36861262/233201609-81f5a942-2390-4081-a9c7-c9523a7f9e72.png">

3315b257

Show magnifier on touch drag gestures (#125151) · 8ed26d8b

Renzo Olivares authored Apr 20, 2023

This change shows the magnifier on touch drag gestures for Android and iOS and hides it when the drag ends.

Fixes #118268

8ed26d8b

19 Apr, 2023 16 commits

Report web compiler used with `buildEventSettings` (#125092) · f5b0f0a2
Kevin Moore authored Apr 19, 2023
```
Fixes https://github.com/flutter/flutter/issues/125085
```
f5b0f0a2
[flutter_tools] bump min sdk version from 3.0.0-0 to 3.0.0 (#125158) · c74cf4ba
Andrew Kolos authored Apr 19, 2023
```
Allows use of APIs such as `Iterable.firstOrNull`.
```
c74cf4ba
[flutter_tools] add todo for userMessages (#125156) · fa43a93b
Andrew Kolos authored Apr 19, 2023
```
Adds `todo` link in code for #125155.
```
fa43a93b
fix DropdownMenu crash when resize window during menu showing (#124855) · 73f7945b
xubaolin authored Apr 19, 2023

73f7945b

Roll Flutter Engine from 0a53cf6f7a4e to d726345bf230 (2 revisions) (#125157) · ea34f7df

engine-flutter-autoroll authored Apr 19, 2023

https://github.com/flutter/engine/compare/0a53cf6f7a4e...d726345bf230

2023-04-19 bdero@google.com [Impeller] Comprehensively label snapshots (flutter/engine#41325)
2023-04-19 bdero@google.com [Impeller] Fix transform regressions for chained filters (flutter/engine#41332)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ea34f7df

Use term wireless instead of network (#124232) · 48bb3c0b

Victoria Ashworth authored Apr 19, 2023

Rename variables, update comments, etc from `network` to `wireless` to keep it more uniform.

Also, move non-overriden messages related to device selection into the file they're used.

Part 7 in breakdown of https://github.com/flutter/flutter/pull/121262.

48bb3c0b

Revert selectable update back to be a postframecallback or microtask (#125140) · 14e191fa

chunhtai authored Apr 19, 2023

The regression was caused by the previous pr https://github.com/flutter/flutter/pull/124624 changes postframecallback to scheduleframecallback. The reason is that if a new postframecallback was scheduled when running a postframecallback. The newly added postframecallback will be execute on the next frame. However, adding postframecallback will not schedule a new frame. So if there isn't other widget that schedule a new frame, the newly added postframecallback will never gets run.

After changing to scheduleframecallback, it causes an issue that transient callback may be called when rendering tree contains dirty layout information that are waiting to be rebuilt.

Therefore, I use microtask to get around of the postframecallback issue instead of scheduleframecallback.

fixes https://github.com/flutter/flutter/issues/125065

14e191fa

Roll Packages from faf53fb3998c to 88591becfb3f (6 revisions) (#125153) · 898767f9

engine-flutter-autoroll authored Apr 19, 2023

https://github.com/flutter/packages/compare/faf53fb3998c...88591becfb3f

2023-04-19 engine-flutter-autoroll@skia.org Roll Flutter from 42fb0b23 to 3476b966 (20 revisions) (flutter/packages#3760)
2023-04-19 49699333+dependabot[bot]@users.noreply.github.com Bump cirrusci/flutter from `794fbbc` to `d99b1ba` in /.ci (flutter/packages#3724)
2023-04-18 10687576+bparrishMines@users.noreply.github.com [webview_flutter] Adds support to listen to url changes (flutter/packages#3313)
2023-04-18 engine-flutter-autoroll@skia.org Roll Flutter from 15cb1f84 to 42fb0b23 (19 revisions) (flutter/packages#3756)
2023-04-18 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump com.android.tools.build:gradle from 7.2.2 to 8.0.0 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#3739)
2023-04-18 stuartmorgan@google.com [local_auth] Convert Android to Pigeon (flutter/packages#3748)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

898767f9

Roll Flutter Engine from d626f16cb9a3 to 0a53cf6f7a4e (1 revision) (#125152) · 481ac3ce

engine-flutter-autoroll authored Apr 19, 2023

https://github.com/flutter/engine/compare/d626f16cb9a3...0a53cf6f7a4e

2023-04-19 chinmaygarde@google.com [Impeller] Make //impeller/display_list TU naming consistent. (flutter/engine#41174)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

481ac3ce

[reland] Update helper message for `--suppress-analytics` (#125145) · ca3a900d

Elias Yishak authored Apr 19, 2023

Relanding: https://github.com/flutter/flutter/pull/124810

Fixes: https://github.com/flutter/flutter/issues/124808

ca3a900d

Dismiss the docked search view when the window size is changed (#125071) · 4c6929d4
Qun Cheng authored Apr 19, 2023

4c6929d4

Roll Flutter Engine from 609f9d536494 to d626f16cb9a3 (9 revisions) (#125150) · 44738995

engine-flutter-autoroll authored Apr 19, 2023

https://github.com/flutter/engine/compare/609f9d536494...d626f16cb9a3

2023-04-19 mdebbar@google.com [web] Remove non-ShadowDom mode (flutter/engine#39915)
2023-04-19 30870216+gaaclarke@users.noreply.github.com [impeller] added moltenvk notice (flutter/engine#41317)
2023-04-19 skia-flutter-autoroll@skia.org Roll Skia from 8af1dd9659f0 to ad90b6bd4760 (3 revisions) (flutter/engine#41337)
2023-04-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 27e71f19c144 to fe8bb0565a30 (2 revisions) (flutter/engine#41336)
2023-04-19 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from yD5a3QBJHUFM4nVou... to suSuT9F8zuP-pBg-E... (flutter/engine#41334)
2023-04-19 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Cy5LG4U2InaFLkJGz... to Tun7i4VLz6ncx8JJJ... (flutter/engine#41331)
2023-04-19 skia-flutter-autoroll@skia.org Roll Skia from 85d9e67653b1 to 8af1dd9659f0 (1 revision) (flutter/engine#41333)
2023-04-19 skia-flutter-autoroll@skia.org Roll Skia from 5a718d9e9c06 to 85d9e67653b1 (4 revisions) (flutter/engine#41330)
2023-04-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 1f224df52bee to 27e71f19c144 (3 revisions) (flutter/engine#41329)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Cy5LG4U2InaF to Tun7i4VLz6nc
fuchsia/sdk/core/mac-amd64 from yD5a3QBJHUFM to suSuT9F8zuP-

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

44738995

Refactor Flutter Gradle Plugin so it can be applied using the declarative... · 51251f2e

Bartek Pacia authored Apr 19, 2023

Refactor Flutter Gradle Plugin so it can be applied using the declarative `plugins {}` block (#123511)

This PR aims to resolve #121552.

Resources used:
- [Developing Plugins](https://docs.gradle.org/current/userguide/custom_plugins.html)
- [Using Gradle Plugins](https://docs.gradle.org/current/userguide/plugins.html#sec:plugins_block)
- [Composite Builds Plugin Development Sample](https://docs.gradle.org/current/samples/sample_composite_builds_plugin_development.html)

This PR also paves way for #121541, because apps will no longer have:

```groovy
apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle"
```

hardcoded. Instead, they'll use:

```groovy
plugins {
    // ...
    id "dev.flutter.flutter-gradle-plugin" // the exact name is tentative
}
```

51251f2e

fix SliverReorderableList test to use correct custom action id (#125144) · 122dacfa

chunhtai authored Apr 19, 2023

as title

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

122dacfa

Revert "Update helper message for `--suppress-analytics`" (#125141) · 03d72562
godofredoc authored Apr 19, 2023
```
Reverts flutter/flutter#124810
```
03d72562
Update helper message for `--suppress-analytics` (#124810) · 3476b966
Elias Yishak authored Apr 19, 2023
```
Fixes: https://github.com/flutter/flutter/issues/124808
```
3476b966