Commits · 7a9adfd1c792753ad29fe8dc6c82fec85d24944a · abdullh.alsoleman / Front-End

05 Dec, 2023 8 commits

Send an event when proxied DDS creates a connection. (#139530) · 7a9adfd1
Lau Ching Jun authored Dec 05, 2023
```
The event allows tools to listen and connect to the original DDS port.
```
7a9adfd1

Roll Flutter Engine from 2923201bc337 to 72d6a42f74b1 (3 revisions) (#139547) · c396011e

engine-flutter-autoroll authored Dec 05, 2023

https://github.com/flutter/engine/compare/2923201bc337...72d6a42f74b1

2023-12-05 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 4.3.0 to 5.0.0 (flutter/engine#48662)
2023-12-05 skia-flutter-autoroll@skia.org Roll Skia from de49aeaa8224 to a998afefb1b0 (1 revision) (flutter/engine#48660)
2023-12-05 skia-flutter-autoroll@skia.org Roll Skia from d37625f80ac0 to de49aeaa8224 (1 revision) (flutter/engine#48658)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c396011e

Make `handleJsonEvent` public so that it can be overridden internally. (#139531) · 63c58a33
Lau Ching Jun authored Dec 05, 2023

63c58a33

Roll Flutter Engine from f43ef6cbddb0 to 2923201bc337 (2 revisions) (#139540) · 2c613504

engine-flutter-autoroll authored Dec 05, 2023

https://github.com/flutter/engine/compare/f43ef6cbddb0...2923201bc337

2023-12-05 chinmaygarde@google.com [Impeller] Remove duplicate entity test suite instantiations. (flutter/engine#48654)
2023-12-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 9c74645153ca to 21574eae3a69 (1 revision) (flutter/engine#48655)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2c613504

Roll Flutter Engine from de0ba840339c to f43ef6cbddb0 (5 revisions) (#139536) · bfaacd5e

engine-flutter-autoroll authored Dec 05, 2023

https://github.com/flutter/engine/compare/de0ba840339c...f43ef6cbddb0

2023-12-05 skia-flutter-autoroll@skia.org Roll Dart SDK from a1b67665b3a3 to 9c74645153ca (1 revision) (flutter/engine#48648)
2023-12-05 jonahwilliams@google.com [Impeller] Remove impeller::Path copy constructor. (flutter/engine#48616)
2023-12-04 jonahwilliams@google.com [Impeller] Move BufferView/Texture/Sampler when binding. (flutter/engine#48628)
2023-12-04 skia-flutter-autoroll@skia.org Roll Skia from cbd2cf40d63b to d37625f80ac0 (1 revision) (flutter/engine#48643)
2023-12-04 jiahaog@users.noreply.github.com Add `flutter` prefix to import (flutter/engine#48617)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bfaacd5e

Reverts "Bump actions/labeler from 4.3.0 to 5.0.0" (#139534) · b278f0f1

auto-submit[bot] authored Dec 05, 2023

Reverts flutter/flutter#139506
Initiated by: godofredoc
This change reverts the following previous change:
Original Description:
Bumps [actions/labeler](https://github.com/actions/labeler) from 4.3.0 to 5.0.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/labeler/releases">actions/labeler's releases</a>.</em></p>
<blockquote>
<h2>v5.0.0</h2>
<h2>What's Changed</h2>
<p>This release contains the following breaking changes:</p>
<ol>
<li>
<p>The ability to apply labels based on the names of base and/or head branches was added (<a href="https://redirect.github.com/actions/labeler/issues/186">#186</a> and <a href="https://redirect.github.com/actions/labeler/issues/54">#54</a>). The match object for changed files was expanded with new combinations in order to make it more intuitive and flexible (<a href="https://redirect.github.com/actions/labeler/issues/423">#423</a> and <a href="https://redirect.github.com/actions/labeler/issues/101">#101</a>). As a result, the configuration file structure was significantly redesigned and is not compatible with the structure of the previous version. Please read the <a href="https://github.com/actions/labeler/tree/main#pull-request-labeler">action documentation</a> to find out how to adapt your configuration files for use with the new action version.</p>
</li>
<li>
<p>The bug related to the <code>sync-labels</code> input was fixed (<a href="https://redirect.github.com/actions/labeler/issues/112">#112</a>). Now the input value is read correctly.</p>
</li>
<li>
<p>By default, <code>dot</code> input is set to <code>true</code>. Now, paths starting with a dot (e.g. <code>.github</code>) are matched by default.</p>
</li>
<li>
<p>Version 5 of this action updated the <a href="https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#runs-for-javascript-actions">runtime to Node.js 20</a>. All scripts are now run with Node.js 20 instead of Node.js 16 and are affected by any breaking changes between Node.js 16 and 20.</p>
</li>
</ol>
<p>For more information, please read the <a href="https://github.com/actions/labeler/tree/main#pull-request-labeler">action documentation</a>.</p>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/joshdales"><code>@joshdales</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/203">actions/labeler#203</a></li>
<li><a href="https://github.com/dusan-trickovic"><code>@dusan-trickovic</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/626">actions/labeler#626</a></li>
<li><a href="https://github.com/sungh0lim"><code>@sungh0lim</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/630">actions/labeler#630</a></li>
<li><a href="https://github.com/TrianguloY"><code>@TrianguloY</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/629">actions/labeler#629</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/labeler/compare/v4...v5.0.0">https://github.com/actions/labeler/compare/v4...v5.0.0</a></p>
<h2>v5.0.0-beta.1</h2>
<h2>What's Changed</h2>
<p>In scope of this beta release, the structure of the configuration file (<code>.github/labeler.yml</code>) was changed from</p>
<pre lang="yml"><code>LabelName:
- any:
  - changed-files: ['list', 'of', 'globs']
  - base-branch: ['list', 'of', 'regexps']
  - head-branch: ['list', 'of', 'regexps']
- all:
  - changed-files: ['list', 'of', 'globs']
  - base-branch: ['list', 'of', 'regexps']
  - head-branch: ['list', 'of', 'regexps']
</code></pre>
<p>to</p>
<pre lang="yml"><code>LabelName:
- any:
  - changed-files: 
    - AnyGlobToAnyFile: ['list', 'of', 'globs']
    - AnyGlobToAllFiles: ['list', 'of', 'globs']
    - AllGlobsToAnyFile: ['list', 'of', 'globs']
    - AllGlobsToAllFiles: ['list', 'of', 'globs']
  - base-branch: ['list', 'of', 'regexps']
  - head-branch: ['list', 'of', 'regexps']
- all:
  - changed-files:
    - AnyGlobToAnyFile: ['list', 'of', 'globs']
    - AnyGlobToAllFiles: ['list', 'of', 'globs']
    - AllGlobsToAnyFile: ['list', 'of', 'globs']
&lt;/tr&gt;&lt;/table&gt; 
</code></pre>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/actions/labeler/commit/8558fd74291d67161a8a78ce36a881fa63b766a9"><code>8558fd7</code></a> Merge pull request <a href="https://redirect.github.com/actions/labeler/issues/709">#709</a> from actions/v5.0.0-beta</li>
<li><a href="https://github.com/actions/labeler/commit/000ca75fe6c5838c790ca73b764419065c1594a6"><code>000ca75</code></a> Merge pull request <a href="https://redirect.github.com/actions/labeler/issues/700">#700</a> from MaksimZhukov/apply-suggestions-and-update-docume...</li>
<li><a href="https://github.com/actions/labeler/commit/cb66c2f0788d382da1dabd06a094c0bc6ed3e26a"><code>cb66c2f</code></a> Update dist</li>
<li><a href="https://github.com/actions/labeler/commit/9181355e36dc8e434c93ba5aaa33f699c4162f38"><code>9181355</code></a> Apply suggestions for the beta vesrion and update the documentation</li>
<li><a href="https://github.com/actions/labeler/commit/efe4c1c90edf0ec238b5ee13e66e1abcbbe7446e"><code>efe4c1c</code></a> Merge pull request <a href="https://redirect.github.com/actions/labeler/issues/699">#699</a> from MaksimZhukov/update-node-runtime-and-dependencies</li>
<li><a href="https://github.com/actions/labeler/commit/c0957ad7c30fb0638e275122d51df2330459854a"><code>c0957ad</code></a> Run Prettier</li>
<li><a href="https://github.com/actions/labeler/commit/8dc8d1842f2f3ed1cf6f4190490ad02e0a755f0c"><code>8dc8d18</code></a> Update Node.js version in reusable workflows</li>
<li><a href="https://github.com/actions/labeler/commit/d0d0bbebfbe119c8403a0e2724c5fa5b555c78b9"><code>d0d0bbe</code></a> Update documentation</li>
<li><a href="https://github.com/actions/labeler/commit/1375c42512e0b855687040307d6dcaf403da9a4e"><code>1375c42</code></a> 5.0.0</li>
<li><a href="https://github.com/actions/labeler/commit/ab7411ec21ea67102994adc0fa01b3f5cf63509f"><code>ab7411e</code></a> Change version of Node.js runtime to node20</li>
<li>Additional commits viewable in <a href="https://github.com/actions/labeler/compare/ac9175f8a1f3625fd0d4fb234536d26811351594...8558fd74291d67161a8a78ce36a881fa63b766a9">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/labeler&package-manager=github_actions&previous-version=4.3.0&new-version=5.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

b278f0f1

Reverts "Update sync-labels to use boolean" (#139533) · 5422af74

auto-submit[bot] authored Dec 05, 2023

Reverts flutter/flutter#139516
Initiated by: godofredoc
This change reverts the following previous change:
Original Description:
https://github.com/actions/labeler/issues/112 has been fixed, and now requires boolean to be used. 

Related infra issue that this fixes: https://github.com/flutter/flutter/issues/139511

5422af74

Fix `DropdownMenu` throwing `TextEditingController` disposed error on select (#139385) · 8ec4c59e

Greg Spencer authored Dec 05, 2023

## Description

When a DropdownMenu exists within another menu and a MenuItem is selected, the `TextEditingController` of the DropdownMenu is used after it has been disposed.

This PR manages the local `TextController` instance better, making sure that the one used when building is the current one, and handling the case where the `controller` is set on the widget after initial creation.

Also, places where we were setting the text and selection separately were converted to use `TextEditingValue` and set the value atomically.

## Related Issues
 - Fixes https://github.com/flutter/flutter/issues/139266

## Tests
 - Added tests (Created by @josh-burton  in https://github.com/flutter/flutter/pull/139268 - Thanks Josh!)

8ec4c59e

04 Dec, 2023 18 commits

increase sharding of windows build tests (#139503) · 79d6781b
Christopher Fujino authored Dec 04, 2023
```
Fixes https://github.com/flutter/flutter/issues/139502
```
79d6781b

Update sync-labels to use boolean (#139516) · e1a2bb37

Drew Roen authored Dec 04, 2023

https://github.com/actions/labeler/issues/112 has been fixed, and now requires boolean to be used. 

Related infra issue that this fixes: https://github.com/flutter/flutter/issues/139511

e1a2bb37

Roll Flutter Engine from c6395d920786 to de0ba840339c (6 revisions) (#139507) · 1567a9d6

engine-flutter-autoroll authored Dec 04, 2023

https://github.com/flutter/engine/compare/c6395d920786...de0ba840339c

2023-12-04 skia-flutter-autoroll@skia.org Roll Skia from 0fe76d9ce79e to cbd2cf40d63b (1 revision) (flutter/engine#48638)
2023-12-04 dnfield@google.com Remove some trivial forward declares from Impeller (flutter/engine#48635)
2023-12-04 737941+loic-sharma@users.noreply.github.com [Windows] Decouple the GL context from the view (flutter/engine#48636)
2023-12-04 dkwingsmt@users.noreply.github.com Multiview ExternalViewEmbedder (flutter/engine#46169)
2023-12-04 skia-flutter-autoroll@skia.org Roll Dart SDK from 67f7a2c2559a to a1b67665b3a3 (1 revision) (flutter/engine#48637)
2023-12-04 skia-flutter-autoroll@skia.org Roll Skia from db4a29e0689e to 0fe76d9ce79e (5 revisions) (flutter/engine#48634)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1567a9d6

Bump actions/labeler from 4.3.0 to 5.0.0 (#139506) · bbe980cf

dependabot[bot] authored Dec 04, 2023

Bumps [actions/labeler](https://github.com/actions/labeler) from 4.3.0 to 5.0.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/labeler/releases">actions/labeler's releases</a>.</em></p>
<blockquote>
<h2>v5.0.0</h2>
<h2>What's Changed</h2>
<p>This release contains the following breaking changes:</p>
<ol>
<li>
<p>The ability to apply labels based on the names of base and/or head branches was added (<a href="https://redirect.github.com/actions/labeler/issues/186">#186</a> and <a href="https://redirect.github.com/actions/labeler/issues/54">#54</a>). The match object for changed files was expanded with new combinations in order to make it more intuitive and flexible (<a href="https://redirect.github.com/actions/labeler/issues/423">#423</a> and <a href="https://redirect.github.com/actions/labeler/issues/101">#101</a>). As a result, the configuration file structure was significantly redesigned and is not compatible with the structure of the previous version. Please read the <a href="https://github.com/actions/labeler/tree/main#pull-request-labeler">action documentation</a> to find out how to adapt your configuration files for use with the new action version.</p>
</li>
<li>
<p>The bug related to the <code>sync-labels</code> input was fixed (<a href="https://redirect.github.com/actions/labeler/issues/112">#112</a>). Now the input value is read correctly.</p>
</li>
<li>
<p>By default, <code>dot</code> input is set to <code>true</code>. Now, paths starting with a dot (e.g. <code>.github</code>) are matched by default.</p>
</li>
<li>
<p>Version 5 of this action updated the <a href="https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#runs-for-javascript-actions">runtime to Node.js 20</a>. All scripts are now run with Node.js 20 instead of Node.js 16 and are affected by any breaking changes between Node.js 16 and 20.</p>
</li>
</ol>
<p>For more information, please read the <a href="https://github.com/actions/labeler/tree/main#pull-request-labeler">action documentation</a>.</p>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/joshdales"><code>@âjoshdales</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/203">actions/labeler#203</a></li>
<li><a href="https://github.com/dusan-trickovic"><code>@âdusan-trickovic</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/626">actions/labeler#626</a></li>
<li><a href="https://github.com/sungh0lim"><code>@âsungh0lim</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/630">actions/labeler#630</a></li>
<li><a href="https://github.com/TrianguloY"><code>@âTrianguloY</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/629">actions/labeler#629</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/labeler/compare/v4...v5.0.0">https://github.com/actions/labeler/compare/v4...v5.0.0</a></p>
<h2>v5.0.0-beta.1</h2>
<h2>What's Changed</h2>
<p>In scope of this beta release, the structure of the configuration file (<code>.github/labeler.yml</code>) was changed from</p>
<pre lang="yml"><code>LabelName:
- any:
  - changed-files: ['list', 'of', 'globs']
  - base-branch: ['list', 'of', 'regexps']
  - head-branch: ['list', 'of', 'regexps']
- all:
  - changed-files: ['list', 'of', 'globs']
  - base-branch: ['list', 'of', 'regexps']
  - head-branch: ['list', 'of', 'regexps']
</code></pre>
<p>to</p>
<pre lang="yml"><code>LabelName:
- any:
  - changed-files: 
    - AnyGlobToAnyFile: ['list', 'of', 'globs']
    - AnyGlobToAllFiles: ['list', 'of', 'globs']
    - AllGlobsToAnyFile: ['list', 'of', 'globs']
    - AllGlobsToAllFiles: ['list', 'of', 'globs']
  - base-branch: ['list', 'of', 'regexps']
  - head-branch: ['list', 'of', 'regexps']
- all:
  - changed-files:
    - AnyGlobToAnyFile: ['list', 'of', 'globs']
    - AnyGlobToAllFiles: ['list', 'of', 'globs']
    - AllGlobsToAnyFile: ['list', 'of', 'globs']
&lt;/tr&gt;&lt;/table&gt; 
</code></pre>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/actions/labeler/commit/8558fd74291d67161a8a78ce36a881fa63b766a9"><code>8558fd7</code></a> Merge pull request <a href="https://redirect.github.com/actions/labeler/issues/709">#709</a> from actions/v5.0.0-beta</li>
<li><a href="https://github.com/actions/labeler/commit/000ca75fe6c5838c790ca73b764419065c1594a6"><code>000ca75</code></a> Merge pull request <a href="https://redirect.github.com/actions/labeler/issues/700">#700</a> from MaksimZhukov/apply-suggestions-and-update-docume...</li>
<li><a href="https://github.com/actions/labeler/commit/cb66c2f0788d382da1dabd06a094c0bc6ed3e26a"><code>cb66c2f</code></a> Update dist</li>
<li><a href="https://github.com/actions/labeler/commit/9181355e36dc8e434c93ba5aaa33f699c4162f38"><code>9181355</code></a> Apply suggestions for the beta vesrion and update the documentation</li>
<li><a href="https://github.com/actions/labeler/commit/efe4c1c90edf0ec238b5ee13e66e1abcbbe7446e"><code>efe4c1c</code></a> Merge pull request <a href="https://redirect.github.com/actions/labeler/issues/699">#699</a> from MaksimZhukov/update-node-runtime-and-dependencies</li>
<li><a href="https://github.com/actions/labeler/commit/c0957ad7c30fb0638e275122d51df2330459854a"><code>c0957ad</code></a> Run Prettier</li>
<li><a href="https://github.com/actions/labeler/commit/8dc8d1842f2f3ed1cf6f4190490ad02e0a755f0c"><code>8dc8d18</code></a> Update Node.js version in reusable workflows</li>
<li><a href="https://github.com/actions/labeler/commit/d0d0bbebfbe119c8403a0e2724c5fa5b555c78b9"><code>d0d0bbe</code></a> Update documentation</li>
<li><a href="https://github.com/actions/labeler/commit/1375c42512e0b855687040307d6dcaf403da9a4e"><code>1375c42</code></a> 5.0.0</li>
<li><a href="https://github.com/actions/labeler/commit/ab7411ec21ea67102994adc0fa01b3f5cf63509f"><code>ab7411e</code></a> Change version of Node.js runtime to node20</li>
<li>Additional commits viewable in <a href="https://github.com/actions/labeler/compare/ac9175f8a1f3625fd0d4fb234536d26811351594...8558fd74291d67161a8a78ce36a881fa63b766a9">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/labeler&package-manager=github_actions&previous-version=4.3.0&new-version=5.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

bbe980cf

Added support for vscode and vscode-insiders installed via Flatpak (#137123) · 77503bdb

Kristijan Žic authored Dec 04, 2023

Closes #137122

<b>Before</b>
VS Code and VS Code Insiders installed via Flatpak aren't detected

<b>After</b>
```sh
[â] VS Code (version 1.82.2)
    â¢ VS Code at /var/lib/flatpak/app/com.visualstudio.code/x86_64/stable/active/files/extra/vscode
    â¢ Flutter extension version 3.74.0

[â] VS Code (version 1.84.0-insider)
    â¢ VS Code at /var/lib/flatpak/app/com.visualstudio.code.insiders/x86_64/beta/active/files/extra/vscode-insiders
    â¢ Flutter extension version 3.75.20231002
```

77503bdb

Convert some usage of `RawKeyEvent`, et al to `KeyEvent` (#139329) · 909e529e

Greg Spencer authored Dec 04, 2023

## Description

This converts some uses of `RawKeyEvent` to `KeyEvent` in preparation for deprecating `RawKeyEvent`.

## Related Issues
 - https://github.com/flutter/flutter/issues/136419

909e529e

[Reland] Migration for the `sendTiming` events for `package:unified_analytics` (#139299) · 2d60241d

Elias Yishak authored Dec 04, 2023

Relanding based on this comment:
- https://github.com/flutter/flutter/pull/139278#issuecomment-1832951108

Related to tracker issue:
- https://github.com/flutter/flutter/issues/128251

<img width="278" alt="image" src="https://github.com/flutter/flutter/assets/42216813/cee7b9be-48d6-48e5-8c39-de28d0a1f0de">

The image above shows all of the instances where we have `sendTiming`. All of the call sites have been updated to use the new `Event.timing` event from `package:unified_analytics`.

2d60241d

Roll Flutter Engine from eee8aeb953df to c6395d920786 (2 revisions) (#139497) · 7be25c89

engine-flutter-autoroll authored Dec 04, 2023

https://github.com/flutter/engine/compare/eee8aeb953df...c6395d920786

2023-12-04 barpac02@gmail.com Add support for exposing accessibility identifier as resource-id on Android (flutter/engine#47961)
2023-12-04 skia-flutter-autoroll@skia.org Roll Skia from 540d76ea74f8 to db4a29e0689e (2 revisions) (flutter/engine#48633)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7be25c89

Optimize the display of the Overlay on the Slider (#139021) · 5530c106

hgraceb authored Dec 04, 2023

## Description

Automatic focus request on Slider value change prevents Overlay from correctly handling hover events.

Fixes #139281

### Before

![slider3](https://github.com/flutter/flutter/assets/38378650/815e12a4-ccaf-4b99-8480-6cbdc97a91bd)

### After

![slider4](https://github.com/flutter/flutter/assets/38378650/473eca22-0308-4964-8368-b0c158ae30eb)

5530c106

Enable TapRegion to detect all mouse button click (#136799) · 3f1f0aa5

Anindya Chatterjee authored Dec 04, 2023

With this PR, TapRegion would be able to detect any kind of mouse button
events. Earlier, TapRegion used to detect only left mouse button event.

Fixes #136706

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

3f1f0aa5

[flutter_tools] build ios-frameworks: option to exclude plugin frameworks from the build (#129739) · 0f67c992

Pavel Mazhnik authored Dec 04, 2023

A lot of details are written in the feature request: https://github.com/flutter/flutter/issues/114692.

tl;dr: Options B & C from the add2app iOS guide have a limitation (build error) in case the Flutter plugin and native iOS app have a shared dependency. We can use a workaround to avoid the issue, but in this case we don't need to build frameworks for plugins.

Closes https://github.com/flutter/flutter/issues/114692
Part of https://github.com/flutter/flutter/issues/130220

0f67c992

Roll Flutter Engine from b87c1b32d55f to eee8aeb953df (1 revision) (#139495) · f387b77f

engine-flutter-autoroll authored Dec 04, 2023

https://github.com/flutter/engine/compare/b87c1b32d55f...eee8aeb953df

2023-12-04 chillers@google.com Only run firebase tests on HEAD (flutter/engine#48548)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f387b77f

Add Impeller complex layout impeller benchmarks. (#139490) · c421f65b

Jonah Williams authored Dec 04, 2023

These benchmarks do a nice job of showing CPU overhead, which is useful for many of the microoptimizations we've been doing.

c421f65b

Roll Flutter Engine from cf122461e94a to b87c1b32d55f (3 revisions) (#139491) · 8fe4e35a

engine-flutter-autoroll authored Dec 04, 2023

https://github.com/flutter/engine/compare/cf122461e94a...b87c1b32d55f

2023-12-04 skia-flutter-autoroll@skia.org Roll Skia from 0ef49914a9f0 to 540d76ea74f8 (4 revisions) (flutter/engine#48627)
2023-12-04 skia-flutter-autoroll@skia.org Roll Skia from 00fc70025788 to 0ef49914a9f0 (2 revisions) (flutter/engine#48626)
2023-12-04 skia-flutter-autoroll@skia.org Roll Dart SDK from 0f7c94ba9f51 to 67f7a2c2559a (1 revision) (flutter/engine#48625)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8fe4e35a

Remove InkSparkle.constantTurbulenceSeedSplashFactory usage (#139481) · bd505f4b

Bruno Leroux authored Dec 04, 2023

This PR removes the call to `InkSparkle.constantTurbulenceSeedSplashFactory` which was introduced in https://github.com/flutter/flutter/pull/137998.

This is now obsolete since https://github.com/flutter/flutter/pull/138757 was merged and InkSparkle randomness is no more active in tests.

bd505f4b

Roll Packages from bc72d15c95a5 to 5d9874f69bce (9 revisions) (#139480) · df88e3a5

engine-flutter-autoroll authored Dec 04, 2023

https://github.com/flutter/packages/compare/bc72d15c95a5...5d9874f69bce

2023-12-02 engine-flutter-autoroll@skia.org Roll Flutter from 918e3360 to d861ce49 (29 revisions) (flutter/packages#5542)
2023-12-02 ditman@gmail.com [gsi_web] Do not initialize CodeClient if scopes are empty. (flutter/packages#5537)
2023-12-01 15619084+vashworth@users.noreply.github.com Reenable macOS 13 tests (flutter/packages#5494)
2023-12-01 mikemcguiness@protonmail.com [flutter_image] Adopt code excerpts in README (flutter/packages#5498)
2023-11-30 kevmoo@users.noreply.github.com [cross_file] Migrate to pkg:web, bump min SDK to Dart 3.2 (flutter/packages#5520)
2023-11-30 stuartmorgan@google.com [google_maps_flutter] Add support for version 8 of the iOS SDK (flutter/packages#5528)
2023-11-30 stuartmorgan@google.com [pointer_interceptor] Re-land: Add platform interface (flutter/packages#5525)
2023-11-30 61667947+T-P-F@users.noreply.github.com [google_sign_in] Add server auth code retrieval to gis_client (flutter/packages#5358)
2023-11-30 engine-flutter-autoroll@skia.org Roll Flutter from 5e5b5292 to 918e3360 (14 revisions) (flutter/packages#5526)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

df88e3a5

Roll Flutter Engine from cc9a72b692fc to cf122461e94a (1 revision) (#139468) · f35d049e

engine-flutter-autoroll authored Dec 04, 2023

https://github.com/flutter/engine/compare/cc9a72b692fc...cf122461e94a

2023-12-04 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from UXMnwzl-9_YZaE_aV... to CGyrUgA1M1yFx5N5C... (flutter/engine#48620)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from UXMnwzl-9_YZ to CGyrUgA1M1yF

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f35d049e

Roll Flutter Engine from 69cbf87f33c9 to cc9a72b692fc (1 revision) (#139466) · 50cd2399

engine-flutter-autoroll authored Dec 04, 2023

https://github.com/flutter/engine/compare/69cbf87f33c9...cc9a72b692fc

2023-12-04 skia-flutter-autoroll@skia.org Roll Dart SDK from 58ff03f2c17f to 0f7c94ba9f51 (1 revision) (flutter/engine#48619)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

50cd2399

03 Dec, 2023 4 commits

Roll Flutter Engine from 05e7f462048b to 69cbf87f33c9 (1 revision) (#139453) · 18f365d6

engine-flutter-autoroll authored Dec 03, 2023

https://github.com/flutter/engine/compare/05e7f462048b...69cbf87f33c9

2023-12-03 skia-flutter-autoroll@skia.org Roll Dart SDK from a5d2b197c872 to 58ff03f2c17f (1 revision) (flutter/engine#48615)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

18f365d6

Roll Flutter Engine from e782ab139ef2 to 05e7f462048b (1 revision) (#139439) · 1153c514

engine-flutter-autoroll authored Dec 03, 2023

https://github.com/flutter/engine/compare/e782ab139ef2...05e7f462048b

2023-12-03 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 4BVJFrqacT5kBTO2S... to UXMnwzl-9_YZaE_aV... (flutter/engine#48613)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 4BVJFrqacT5k to UXMnwzl-9_YZ

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1153c514

Roll Flutter Engine from 80a2fd76fd64 to e782ab139ef2 (1 revision) (#139437) · fad4285c

engine-flutter-autoroll authored Dec 03, 2023

https://github.com/flutter/engine/compare/80a2fd76fd64...e782ab139ef2

2023-12-03 skia-flutter-autoroll@skia.org Roll Dart SDK from c7f18da440ab to a5d2b197c872 (1 revision) (flutter/engine#48611)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fad4285c

Roll Flutter Engine from 7ff24be43a36 to 80a2fd76fd64 (1 revision) (#139436) · 9cd4012d

engine-flutter-autoroll authored Dec 03, 2023

https://github.com/flutter/engine/compare/7ff24be43a36...80a2fd76fd64

2023-12-03 skia-flutter-autoroll@skia.org Roll Dart SDK from f5216bb23cc3 to c7f18da440ab (1 revision) (flutter/engine#48608)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9cd4012d

02 Dec, 2023 10 commits

Roll Flutter Engine from cfabe42bc0c6 to 7ff24be43a36 (1 revision) (#139433) · ff62f1ee

engine-flutter-autoroll authored Dec 02, 2023

https://github.com/flutter/engine/compare/cfabe42bc0c6...7ff24be43a36

2023-12-02 skia-flutter-autoroll@skia.org Roll Dart SDK from 3a44776466d6 to f5216bb23cc3 (1 revision) (flutter/engine#48605)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ff62f1ee

Roll Flutter Engine from f0122c32c5cc to cfabe42bc0c6 (1 revision) (#139423) · d861ce49

engine-flutter-autoroll authored Dec 02, 2023

https://github.com/flutter/engine/compare/f0122c32c5cc...cfabe42bc0c6

2023-12-02 skia-flutter-autoroll@skia.org Roll Dart SDK from 286ef89d1875 to 3a44776466d6 (1 revision) (flutter/engine#48603)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d861ce49

Roll Flutter Engine from f23c33f3831c to f0122c32c5cc (1 revision) (#139422) · e9ed81ae

engine-flutter-autoroll authored Dec 02, 2023

https://github.com/flutter/engine/compare/f23c33f3831c...f0122c32c5cc

2023-12-02 skia-flutter-autoroll@skia.org Roll Dart SDK from aea874a703a2 to 286ef89d1875 (1 revision) (flutter/engine#48602)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e9ed81ae

Roll Flutter Engine from d441f087052c to f23c33f3831c (2 revisions) (#139421) · e153fb68

engine-flutter-autoroll authored Dec 02, 2023

https://github.com/flutter/engine/compare/d441f087052c...f23c33f3831c

2023-12-02 skia-flutter-autoroll@skia.org Roll Skia from e0768dea5832 to 00fc70025788 (1 revision) (flutter/engine#48599)
2023-12-02 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from oPdJSBgOI25vZ9Jby... to 4BVJFrqacT5kBTO2S... (flutter/engine#48600)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from oPdJSBgOI25v to 4BVJFrqacT5k

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e153fb68

Roll Flutter Engine from 27d37db84b8e to d441f087052c (1 revision) (#139419) · 12dfd99a

engine-flutter-autoroll authored Dec 02, 2023

https://github.com/flutter/engine/compare/27d37db84b8e...d441f087052c

2023-12-02 yjbanov@google.com [web] remove ulimit and add -i to felt (flutter/engine#47414)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

12dfd99a

Roll Flutter Engine from 5a9f33e3a41e to 27d37db84b8e (1 revision) (#139418) · 4a1fa34e

engine-flutter-autoroll authored Dec 02, 2023

https://github.com/flutter/engine/compare/5a9f33e3a41e...27d37db84b8e

2023-12-02 skia-flutter-autoroll@skia.org Roll Skia from 5ea9dd4abfd7 to e0768dea5832 (1 revision) (flutter/engine#48597)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4a1fa34e

Roll Flutter Engine from 9f8502c4e255 to 5a9f33e3a41e (1 revision) (#139416) · d2fd542f

engine-flutter-autoroll authored Dec 02, 2023

https://github.com/flutter/engine/compare/9f8502c4e255...5a9f33e3a41e

2023-12-02 skia-flutter-autoroll@skia.org Roll Dart SDK from 8d76eae70fa9 to aea874a703a2 (1 revision) (flutter/engine#48594)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d2fd542f

Roll Flutter Engine from 43a1598713bb to 9f8502c4e255 (1 revision) (#139414) · 351d2865

engine-flutter-autoroll authored Dec 02, 2023

https://github.com/flutter/engine/compare/43a1598713bb...9f8502c4e255

2023-12-02 skia-flutter-autoroll@skia.org Roll Skia from 9277bdf97d06 to 5ea9dd4abfd7 (1 revision) (flutter/engine#48595)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

351d2865

Roll Flutter Engine from 039439c1ffe8 to 43a1598713bb (1 revision) (#139412) · 1e191138

engine-flutter-autoroll authored Dec 02, 2023

https://github.com/flutter/engine/compare/039439c1ffe8...43a1598713bb

2023-12-02 flar@google.com [Impeller] Directly tessellate stroked circles. (flutter/engine#48586)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1e191138

Roll Flutter Engine from 4d19fedb7617 to 039439c1ffe8 (1 revision) (#139410) · ce937ed8

engine-flutter-autoroll authored Dec 02, 2023

https://github.com/flutter/engine/compare/4d19fedb7617...039439c1ffe8

2023-12-01 skia-flutter-autoroll@skia.org Roll Dart SDK from a419c7050dcb to 8d76eae70fa9 (1 revision) (flutter/engine#48588)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ce937ed8