1. 12 Mar, 2019 1 commit
  2. 11 Mar, 2019 9 commits
  3. 10 Mar, 2019 6 commits
  4. 09 Mar, 2019 15 commits
  5. 08 Mar, 2019 9 commits
    • Yuqian Li's avatar
      Update docs · cb1b6502
      Yuqian Li authored
      cb1b6502
    • Jonah Williams's avatar
      Revert "Lazily download artifacts (III) (#27903)" (#29064) · 8c0cf1dd
      Jonah Williams authored
      This reverts commit 3fd36200.
      8c0cf1dd
    • Jonah Williams's avatar
      Lazily download artifacts (III) (#27903) · 3fd36200
      Jonah Williams authored
      3fd36200
    • Jonah Williams's avatar
      Add integration to all targets (#29020) · d4a441a0
      Jonah Williams authored
      d4a441a0
    • Justin McCandless's avatar
      Fix TextField height issues (#27205) · 9e9f48da
      Justin McCandless authored
      * Create new TextField attribute to control maxLength behaviour
      
      * Create test case for maxLinesIncrementalHeight
      
      * fix maxLinesIncrementalHeight set method
      
      * fix editable_test.dart
      
      * Just introducing some proposed API additions, renaming to expands
      
      * Pass minLines and expands through to child widgets and validate
      
      * minLines can't be null, and expands can't be true when maxLines is 1
      
      * Implement minLines and maxLines height sizing logic
      
      * Simplify minLines validation logic
      
      * expands parameter proof of concept
      
      * min/max mixup bug fix, and tests work with expands false
      
      * Test expands=true cases, and fix textPainter.height being out of date
      
      * Test all behavior matrix cases
      
      * min/max assertion more strict, can't be equal
      
      * Tests work that were missing expands serialization
      
      * Action sheet tests no longer fail due to rounding error
      
      * TextFieldFocus test no longer mysteriously fails
      
      * TODOs for making expands nullable. Will depend on how Expanded wrapping works
      
      * Expanded growth happens when expanded is true and maxLines is null
      
      * Test Expanded wrapper
      
      * No more overflow when wrapped in Expanded
      
      * Docs improvements
      
      * expands can be null
      
      * Simplify error cases to support existing behavior
      
      * Docs examples and other docs cleanup
      
      * Expansion up to perfectly meet the parent size
      
      * Fix analyze null error
      
      * Fix test after move to nullable expands
      
      * minLines defaults to null
      
      * expands is now exclusively for expanding to parent height and not growth between min and max
      
      * _layout rewritten to handle max height. Need to fix prefix tests and
      reenable expands
      
      * Tests for textfield overflowing parent
      
      * layoutLineBox is documented and private
      
      * expands works in new _layout
      
      * _layout return numbers seem to perfectly match original _layout
      
      * inputWidth comment after trying it out and failing tests
      
      * Fix analyze errors
      
      * WIP prefix/suffix do affect height
      
      * Prefix/suffix and icons affect height, tests pass, but I'm still visually verifying identical to original
      
      * Tall prefix test that verifies pixel perfect layout
      
      * Fix overflowing edge case and test it
      
      * Clean up comments, old code, and todos
      
      * Changing _expands causes relayout. Wasnt able to figure out how to test though...
      
      * Clean up code review comments
      
      * Fix misalignment when tall prefix and border, and clean up related test
      
      * Simple code review cleanup
      
      * Bring back inputWidth to _layout method
      
      * Fix rounding errors showing up in mac tests
      
      * Fix flake by reordering tests. Without this, the dreaded intrinsicwidth flake is reproducible 50% of the time on my machine.
      
      * Fix more rounding error mac tests
      9e9f48da
    • Greg Spencer's avatar
      Remove references to obsolete SemanticsSortOrder (#29012) · 80082ac4
      Greg Spencer authored
      This removes references to SemanticsSortOrder, which was removed a long time ago.
      80082ac4
    • Greg Spencer's avatar
      Add/rewrite tests for FocusScope. (#28169) · 89512e46
      Greg Spencer authored
      In anticipation of changing a lot of the focus code, I'm adding some tests for the FocusScope.
      
      As a result, I was able to find and fix a bug where there was an incorrect assert.
      
      I also added some more documentation.
      
      Several of the tests enforce what I think is incorrect behavior related to passing focus off when the widget tree gets rebuilt without focus nodes that were previously there, but I'm not going to change that behavior in this PR.
      
      I also renamed focus_test.dart to focus_scope_test.dart to be more in line with our naming conventions.
      89512e46
    • Dan Field's avatar
      update readme for LUCI (#29023) · 4be4830c
      Dan Field authored
      * update readme for LUCI
      
      * Update README.md
      4be4830c
    • engine-flutter-autoroll's avatar
      Roll engine a48cd16e0777..60314077846c (2 commits) (#29049) · da764958
      engine-flutter-autoroll authored
      
      https://github.com/flutter/engine/compare/a48cd16e0777...60314077846c
      
      git log a48cd16e077778a7aa5908e4faa4da07714260f2..60314077846c123f45c5aaef911c5ea48343d569 --no-merges --oneline
      603140778 Roll src/third_party/skia 88b8d1124b72..3d1b941f3a7d (27 commits) (flutter/engine#8082)
      95ef58cf4 Add script to help generate PR messages (flutter/engine#8074)
      
      The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      
      If the roll is causing failures, please contact the current sheriff (mklim@google.com), and stop
      the roller if necessary.
      da764958