Commits · 74f8b4f777bd3a17163cf7ccbda8b5358b7259b5 · abdullh.alsoleman / Front-End

07 Oct, 2023 9 commits

Allow leaks around tap down/up, while flackiness is not fixed. (#136133) · 74f8b4f7
Polina Cherkasova authored Oct 07, 2023

74f8b4f7

Roll Flutter Engine from 40024059b09e to 8711c1fd2191 (1 revision) (#136110) · 5207a309

engine-flutter-autoroll authored Oct 07, 2023

https://github.com/flutter/engine/compare/40024059b09e...8711c1fd2191

2023-10-07 skia-flutter-autoroll@skia.org Roll Dart SDK from 46bad70d0f7e to 7ba556c43d35 (1 revision) (flutter/engine#46645)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5207a309

Roll Flutter Engine from eaac056b63a4 to 40024059b09e (1 revision) (#136108) · 2e90a247

engine-flutter-autoroll authored Oct 07, 2023

https://github.com/flutter/engine/compare/eaac056b63a4...40024059b09e

2023-10-07 skia-flutter-autoroll@skia.org Roll Skia from 2f67f1f18562 to 15de5cc6a095 (1 revision) (flutter/engine#46644)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2e90a247

Roll Flutter Engine from f71778651333 to eaac056b63a4 (1 revision) (#136107) · 50f1afe5

engine-flutter-autoroll authored Oct 07, 2023

https://github.com/flutter/engine/compare/f71778651333...eaac056b63a4

2023-10-07 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from K7K76tME-CSGhYlFm... to a-BbzDtY3w8UXYgbK... (flutter/engine#46641)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from K7K76tME-CSG to a-BbzDtY3w8U

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

50f1afe5

bottom_sheet: Clarify doc about behavior when useSafeArea is false (#134793) · a88a2503

Chris Bobbe authored Oct 07, 2023

As discussed at https://github.com/flutter/flutter/pull/122225#issuecomment-1690729628, this is a docs change meant to help people in the absence of a fix for #121752, which is being closed as WONTFIX.

a88a2503

Roll Flutter Engine from 356ab2a54862 to f71778651333 (1 revision) (#136106) · 77779d36

engine-flutter-autoroll authored Oct 07, 2023

https://github.com/flutter/engine/compare/356ab2a54862...f71778651333

2023-10-07 skia-flutter-autoroll@skia.org Roll Dart SDK from 368fd3846df0 to 46bad70d0f7e (7 revisions) (flutter/engine#46639)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

77779d36

Roll Flutter Engine from 1f79667fb860 to 356ab2a54862 (1 revision) (#136104) · 8b9d52bb

engine-flutter-autoroll authored Oct 07, 2023

https://github.com/flutter/engine/compare/1f79667fb860...356ab2a54862

2023-10-06 skia-flutter-autoroll@skia.org Roll Skia from d86da2a029d8 to 2f67f1f18562 (36 revisions) (flutter/engine#46636)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8b9d52bb

Simplify assertion in `AsyncSnapshot` (#135899) · dcd24ef0
Mateus Felipe C. C. Pinto authored Oct 07, 2023
```
Simplify assertion in `AsyncSnapshot`.

Fixes #135731.
```
dcd24ef0

Roll Flutter Engine from b28032c157ee to 1f79667fb860 (1 revision) (#136103) · 90ea6eef

engine-flutter-autoroll authored Oct 07, 2023

https://github.com/flutter/engine/compare/b28032c157ee...1f79667fb860

2023-10-06 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 14dOVccxXOO5RPJJB... to GXgrnmetc14RPdheo... (flutter/engine#46634)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 14dOVccxXOO5 to GXgrnmetc14R

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

90ea6eef

06 Oct, 2023 16 commits

Roll Flutter Engine from 7bf93bb919d9 to b28032c157ee (1 revision) (#136101) · e3ef94bc

engine-flutter-autoroll authored Oct 06, 2023

https://github.com/flutter/engine/compare/7bf93bb919d9...b28032c157ee

2023-10-06 skia-flutter-autoroll@skia.org Roll Skia from 0f2af25f15ee to d86da2a029d8 (7 revisions) (flutter/engine#46587)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e3ef94bc

Roll Flutter Engine from eb5d5c66a83e to 7bf93bb919d9 (2 revisions) (#136098) · 58b47f92

engine-flutter-autoroll authored Oct 06, 2023

https://github.com/flutter/engine/compare/eb5d5c66a83e...7bf93bb919d9

2023-10-06 aam@google.com [fuchsia] Remove hardcoded fuchsia-imported packages 2.12 sdk version (flutter/engine#46629)
2023-10-06 kjlubick@users.noreply.github.com Add Base64::EncodedSize to tidy up allocations (flutter/engine#46624)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

58b47f92

[Windows] Add first Arm64 plugin tests (#135512) · 39b9d8fd

Loïc Sharma authored Oct 06, 2023

Part of: https://github.com/flutter/flutter/issues/129806

Test runs kicked off using `led`:
* â [plugin_test_windows](https://ci.chromium.org/raw/build/logs.chromium.org/flutter/led/loicsharma_google.com/277ffb2c7bdaad579b7598706ebc4009797211bea6b3fd175f0a2e9ad8fe03b1/+/build.proto?server=chromium-swarm.appspot.com)
* â ï¸ [plugin_test](https://ci.chromium.org/raw/build/logs.chromium.org/flutter/led/loicsharma_google.com/c9daccd5b3c6b33763fdb36da30cd55949c7e98539041726bd659d19e1d49112/+/build.proto?server=chromium-swarm.appspot.com) - This test fails as no existing Windows Arm64 builder install the `android_sdk` and `open_jdk` dependencies

I will add `plugin_dependencies_test` and `gradle_plugin_bundle_test` in a follow-up pull request. These tests also depend on `android_sdk` and `open_jdk`, I'll be able to test them manually using the new `plugin_test` builder added by this pull request. 

/cc @pbo-linaro

39b9d8fd

Roll Flutter Engine from 1bb228dfedfa to eb5d5c66a83e (2 revisions) (#136094) · e1308e1f

engine-flutter-autoroll authored Oct 06, 2023

https://github.com/flutter/engine/compare/1bb228dfedfa...eb5d5c66a83e

2023-10-06 jonahwilliams@google.com [Impeller] Ensure known geometry has simple bounds computation. (flutter/engine#46623)
2023-10-06 jonahwilliams@google.com [Impeller] Refactor CapabilitiesGLES into a Capabilties. (flutter/engine#46621)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e1308e1f

Bump github/codeql-action from 2.21.6 to 2.22.0 (#136095) · bc315144

dependabot[bot] authored Oct 06, 2023

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.21.6 to 2.22.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>2.22.0 - 06 Oct 2023</h2>
<ul>
<li>The CodeQL Action now requires CodeQL version 2.10.5 or later. For more information, see the corresponding changelog entry for CodeQL Action version 2.21.8. <a href="https://redirect.github.com/github/codeql-action/pull/1907">#1907</a></li>
<li>The CodeQL Action no longer runs ML-powered queries. For more information, including details on our investment in AI-powered security technology, see <a href="https://github.blog/changelog/2023-09-29-codeql-code-scanning-deprecates-ml-powered-alerts/">&quot;CodeQL code scanning deprecates ML-powered alerts.&quot;</a> <a href="https://redirect.github.com/github/codeql-action/pull/1910">#1910</a></li>
<li>Fix a bug which prevented tracing of projects using Go 1.21 and above on Linux. <a href="https://redirect.github.com/github/codeql-action/pull/1909">#1909</a></li>
</ul>
<h2>2.21.9 - 27 Sep 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.14.6. <a href="https://redirect.github.com/github/codeql-action/pull/1897">#1897</a></li>
<li>We are rolling out a feature in October 2023 that will improve the success rate of C/C++ autobuild. <a href="https://redirect.github.com/github/codeql-action/pull/1889">#1889</a></li>
<li>We are rolling out a feature in October 2023 that will provide specific file coverage information for C and C++, Java and Kotlin, and JavaScript and TypeScript. Currently file coverage information for each of these pairs of languages is grouped together. <a href="https://redirect.github.com/github/codeql-action/pull/1903">#1903</a></li>
<li>Add a warning to help customers avoid inadvertently analyzing the same CodeQL language in multiple matrix jobs. <a href="https://redirect.github.com/github/codeql-action/pull/1901">#1901</a></li>
</ul>
<h2>2.21.8 - 19 Sep 2023</h2>
<ul>
<li>Add a deprecation warning for customers using CodeQL version 2.10.4 and earlier. These versions of CodeQL were discontinued on 12 September 2023 alongside GitHub Enterprise Server 3.6, and will be unsupported by the next minor release of the CodeQL Action. <a href="https://redirect.github.com/github/codeql-action/pull/1884">#1884</a>
<ul>
<li>If you are using one of these versions, please update to CodeQL CLI version 2.10.5 or later. For instance, if you have specified a custom version of the CLI using the 'tools' input to the 'init' Action, you can remove this input to use the default version.</li>
<li>Alternatively, if you want to continue using a version of the CodeQL CLI between 2.9.5 and 2.10.4, you can replace <code>github/codeql-action/*@v2</code> by <code>github/codeql-action/*@v2.21.7</code> in your code scanning workflow to ensure you continue using this version of the CodeQL Action.</li>
</ul>
</li>
<li>Enable the following language aliases when using CodeQL 2.14.4 and later: <code>c-cpp</code> for C/C++ analysis, <code>java-kotlin</code> for Java/Kotlin analysis, and <code>javascript-typescript</code> for JavaScript/TypeScript analysis. <a href="https://redirect.github.com/github/codeql-action/pull/1883">#1883</a></li>
</ul>
<h2>2.21.7 - 14 Sep 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.14.5. <a href="https://redirect.github.com/github/codeql-action/pull/1882">#1882</a></li>
</ul>
<h2>2.21.6 - 13 Sep 2023</h2>
<ul>
<li>Better error message when there is a failure to determine the merge base of the code to analysis. <a href="https://redirect.github.com/github/codeql-action/pull/1860">#1860</a></li>
<li>Improve the calculation of default amount of RAM used for query execution on GitHub Enterprise Server. This now reduces in proportion to the runner's total memory to better account for system memory usage, helping to avoid out-of-memory failures on larger runners. This feature is already available to GitHub.com users. <a href="https://redirect.github.com/github/codeql-action/pull/1866">#1866</a></li>
<li>Enable improved file coverage information for GitHub Enterprise Server users. This feature is already available to GitHub.com users. <a href="https://redirect.github.com/github/codeql-action/pull/1867">#1867</a></li>
<li>Update default CodeQL bundle version to 2.14.4. <a href="https://redirect.github.com/github/codeql-action/pull/1873">#1873</a></li>
</ul>
<h2>2.21.5 - 28 Aug 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.14.3. <a href="https://redirect.github.com/github/codeql-action/pull/1845">#1845</a></li>
<li>Fixed a bug in CodeQL Action 2.21.3 onwards that affected beta support for <a href="https://projectlombok.org/">Project Lombok</a> when analyzing Java. The environment variable <code>CODEQL_EXTRACTOR_JAVA_RUN_ANNOTATION_PROCESSORS</code> will now be respected if it was manually configured in the workflow. <a href="https://redirect.github.com/github/codeql-action/pull/1844">#1844</a></li>
<li>Enable support for Kotlin 1.9.20 when running with CodeQL CLI v2.13.4 through v2.14.3. <a href="https://redirect.github.com/github/codeql-action/pull/1853">#1853</a></li>
</ul>
<h2>2.21.4 - 14 Aug 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.14.2. <a href="https://redirect.github.com/github/codeql-action/pull/1831">#1831</a></li>
<li>Log a warning if the amount of available disk space runs low during a code scanning run. <a href="https://redirect.github.com/github/codeql-action/pull/1825">#1825</a></li>
<li>When downloading CodeQL bundle version 2.13.4 and later, cache these bundles in the Actions tool cache using a simpler version number. <a href="https://redirect.github.com/github/codeql-action/pull/1832">#1832</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/2cb752a87e96af96708ab57187ab6372ee1973ab"><code>2cb752a</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1924">#1924</a> from github/update-v2.22.0-3f7850a17</li>
<li><a href="https://github.com/github/codeql-action/commit/e50f53baa18da7571fefe4e56edeba46be9f183b"><code>e50f53b</code></a> Add changelog note for tracing Go 1.21</li>
<li><a href="https://github.com/github/codeql-action/commit/0a65c007f6b702f7d53f89a44248406aae709942"><code>0a65c00</code></a> Update changelog for v2.22.0</li>
<li><a href="https://github.com/github/codeql-action/commit/3f7850a17964ee76fbc058c4cf3360bfd6840486"><code>3f7850a</code></a> Improve downloading log message (<a href="https://redirect.github.com/github/codeql-action/issues/1920">#1920</a>)</li>
<li><a href="https://github.com/github/codeql-action/commit/27235304e07da3d62be5a72ef5df0f30d8a4e137"><code>2723530</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1923">#1923</a> from github/henrymercer/fix-resolve-environment-aliases</li>
<li><a href="https://github.com/github/codeql-action/commit/8f0e8b0890952ad94f9d4f1a44170b0f27723054"><code>8f0e8b0</code></a> Tweak language parsing to improve clarity</li>
<li><a href="https://github.com/github/codeql-action/commit/f243294ab74b285a547a838884ca660a740ce2a6"><code>f243294</code></a> Extend PR check to test <code>resolve-environment</code> works with language alias</li>
<li><a href="https://github.com/github/codeql-action/commit/1ea6a10947dbce58fd4e0ff685cdec23e7f50145"><code>1ea6a10</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1909">#1909</a> from github/mbg/go-1.21-workaround</li>
<li><a href="https://github.com/github/codeql-action/commit/e26ed57a228512338332f937ef0f121a739d548c"><code>e26ed57</code></a> Defer language aliasing to CLI when appropriate</li>
<li><a href="https://github.com/github/codeql-action/commit/0ac7669167fa236dc2e1eec93d82674b1a265327"><code>0ac7669</code></a> Fix using <code>resolve-environment</code> Action with language aliases</li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/701f152f28d4350ad289a5e31435e9ab6169a7ca...2cb752a87e96af96708ab57187ab6372ee1973ab">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=2.21.6&new-version=2.22.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

bc315144

Call `markNeedsPaint` when adding overlayChild to `Overlay` (#135941) · ebe72d3f

LongCatIsLooong authored Oct 06, 2023

Fixes https://github.com/flutter/flutter/issues/134656

`_skipMarkNeesLayout` was meant to only skip `markNeedsLayout` calls. Re-painting is still needed when a child gets added/removed from the `Overlay`.

ebe72d3f

Revert "Marks Linux_samsung_a02 new_gallery__transition_perf to be unflaky" (#136097) · 68d47e55
Zachary Anderson authored Oct 06, 2023
```
Reverts flutter/flutter#135566
```
68d47e55

Marks Linux_samsung_a02 new_gallery__transition_perf to be unflaky (#135566) · 420ec92e

Flutter GitHub Bot authored Oct 06, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_samsung_a02 new_gallery__transition_perf"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_samsung_a02%20new_gallery__transition_perf%22).
This test can be marked as unflaky.

420ec92e

Roll Flutter Engine from 59b6b94e1a51 to 1bb228dfedfa (1 revision) (#136082) · 4779e499

engine-flutter-autoroll authored Oct 06, 2023

https://github.com/flutter/engine/compare/59b6b94e1a51...1bb228dfedfa

2023-10-06 bdero@google.com [Impeller] Track clip coverage per-pass when not collapsing. (flutter/engine#46597)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4779e499

RenderEditable should dispose created layers. (#135942) · f0970365
Polina Cherkasova authored Oct 06, 2023

f0970365

Marks Windows module_custom_host_app_name_test to be unflaky (#135961) · 8796955e

Flutter GitHub Bot authored Oct 06, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows module_custom_host_app_name_test"
}
-->
The issue https://github.com/flutter/flutter/issues/134644 has been
closed, and the test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20module_custom_host_app_name_test%22).
This test can be marked as unflaky.

8796955e

Roll Packages from 6714d5099ad5 to e578a16580c7 (2 revisions) (#136074) · a3fb4a18

engine-flutter-autoroll authored Oct 06, 2023

https://github.com/flutter/packages/compare/6714d5099ad5...e578a16580c7

2023-10-05 stuartmorgan@google.com [image_picker] Fix XCTests in Xcode 15 (flutter/packages#5074)
2023-10-05 engine-flutter-autoroll@skia.org Roll Flutter from 51229911 to fe0275f9 (35 revisions) (flutter/packages#5076)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a3fb4a18

Roll Flutter Engine from cc9bc9e2c0d3 to 59b6b94e1a51 (1 revision) (#136066) · ad200896

engine-flutter-autoroll authored Oct 06, 2023

https://github.com/flutter/engine/compare/cc9bc9e2c0d3...59b6b94e1a51

2023-10-06 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from eI_FBTaRgvoBQaK5n... to K7K76tME-CSGhYlFm... (flutter/engine#46614)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from eI_FBTaRgvoB to K7K76tME-CSG

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ad200896

Fix memory leaks in DateRangePickerDialog. (#136034) · d76e3abf

Kostia Sokolovskyi authored Oct 06, 2023

This PR mainly fixes several memory leaks in the `DateRangePickerDialog`.

### Description
- Fixes https://github.com/flutter/flutter/issues/136033 by:
    1) adding a disposal of several `RestorableValue`;
    2) creating a separate `_DayItem` stateful widget that creates/updates/disposes internal `MaterialStatesController`.
- Marks https://github.com/flutter/flutter/issues/136036.

### Tests
- Updates `test/material/date_picker_theme_test.dart` to use `testWidgetsWithLeakTracking`;
- Updates `test/material/date_range_picker_test.dart` to use `testWidgetsWithLeakTracking`.

d76e3abf

Roll Flutter Engine from 6492e1f8c315 to cc9bc9e2c0d3 (1 revision) (#136062) · 670e6ba1

engine-flutter-autoroll authored Oct 06, 2023

https://github.com/flutter/engine/compare/6492e1f8c315...cc9bc9e2c0d3

2023-10-06 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from th0Ks2IEZYh6fe8G5... to 14dOVccxXOO5RPJJB... (flutter/engine#46611)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from th0Ks2IEZYh6 to 14dOVccxXOO5

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

670e6ba1

Tiny improve code style by using records instead of lists (#135886) · 7b0293d6
fzyzcjy authored Oct 06, 2023

7b0293d6

05 Oct, 2023 15 commits

Roll Flutter Engine from 27a674466094 to 6492e1f8c315 (1 revision) (#136052) · bf1cdb15

engine-flutter-autoroll authored Oct 05, 2023

https://github.com/flutter/engine/compare/27a674466094...6492e1f8c315

2023-10-05 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from bnd4FFub2R9Q4mlAC... to eI_FBTaRgvoBQaK5n... (flutter/engine#46599)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from bnd4FFub2R9Q to eI_FBTaRgvoB

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bf1cdb15

Upload frame_request_pending_latency [attempt #2] (#135890) · 2925525e

Callum Moffat authored Oct 05, 2023

These values are generated since https://github.com/flutter/flutter/pull/135279, but I didn't know to add the new keys to this list to get them to upload.

Failed to do so in #135645, I believe the mistake there was putting them in `_kCommonScoreKeys`, which is also used in "E2E" tests, that don't get full trace data, only high level `FrameTiming` packets.

Part of https://github.com/flutter/flutter/issues/129150

2925525e

Roll Flutter Engine from 0ff05464f42f to 27a674466094 (1 revision) (#136050) · 32bd280d

engine-flutter-autoroll authored Oct 05, 2023

https://github.com/flutter/engine/compare/0ff05464f42f...27a674466094

2023-10-05 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from -RGP9v0n9shWn5yg1... to th0Ks2IEZYh6fe8G5... (flutter/engine#46593)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from -RGP9v0n9shW to th0Ks2IEZYh6

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

32bd280d

Roll Flutter Engine from ad83202a59a6 to 0ff05464f42f (1 revision) (#136047) · 53333d0c

engine-flutter-autoroll authored Oct 05, 2023

https://github.com/flutter/engine/compare/ad83202a59a6...0ff05464f42f

2023-10-05 skia-flutter-autoroll@skia.org Roll Skia from 09c71755bc6c to 0f2af25f15ee (2 revisions) (flutter/engine#46586)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

53333d0c

Roll Flutter Engine from f8d53c5fe9f2 to ad83202a59a6 (2 revisions) (#136040) · 83b49199

engine-flutter-autoroll authored Oct 05, 2023

https://github.com/flutter/engine/compare/f8d53c5fe9f2...ad83202a59a6

2023-10-05 kjlubick@users.noreply.github.com Replace use of Skia's Base64 Encoding/Decoding logic with a copy of the equivalent code (flutter/engine#46543)
2023-10-05 skia-flutter-autoroll@skia.org Roll Skia from 2be211c972d5 to 09c71755bc6c (1 revision) (flutter/engine#46584)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

83b49199

Roll Packages from d654f7597fb1 to 6714d5099ad5 (3 revisions) (#136039) · 5934c9f9

engine-flutter-autoroll authored Oct 05, 2023

https://github.com/flutter/packages/compare/d654f7597fb1...6714d5099ad5

2023-10-04 stuartmorgan@google.com [webview_flutter] Fix XCUITest in Xcode 15 (flutter/packages#5071)
2023-10-04 stuartmorgan@google.com [path_provider] Fix integration tests (flutter/packages#5075)
2023-10-04 dawidope@gmail.com [flutter_markdown] Footnote support (flutter/packages#5058)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5934c9f9

Roll Flutter Engine from 4987e5468152 to f8d53c5fe9f2 (1 revision) (#136024) · fe0275f9

engine-flutter-autoroll authored Oct 05, 2023

https://github.com/flutter/engine/compare/4987e5468152...f8d53c5fe9f2

2023-10-05 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from z_GRSMyHRsHjrpY48... to bnd4FFub2R9Q4mlAC... (flutter/engine#46580)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from z_GRSMyHRsHj to bnd4FFub2R9Q

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fe0275f9

Roll Flutter Engine from a9fe88e09131 to 4987e5468152 (2 revisions) (#136022) · 0822d604

engine-flutter-autoroll authored Oct 05, 2023

https://github.com/flutter/engine/compare/a9fe88e09131...4987e5468152

2023-10-05 skia-flutter-autoroll@skia.org Roll Skia from f0cbcb892b2b to 2be211c972d5 (1 revision) (flutter/engine#46579)
2023-10-05 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Q0h8rkXPNpWBnlAnS... to -RGP9v0n9shWn5yg1... (flutter/engine#46578)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from Q0h8rkXPNpWB to -RGP9v0n9shW

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0822d604

Roll Flutter Engine from dba8e8d9e6cf to a9fe88e09131 (1 revision) (#136019) · 9bc65341

engine-flutter-autoroll authored Oct 05, 2023

https://github.com/flutter/engine/compare/dba8e8d9e6cf...a9fe88e09131

2023-10-05 skia-flutter-autoroll@skia.org Roll Skia from e9b5e455ff8d to f0cbcb892b2b (1 revision) (flutter/engine#46577)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9bc65341

Roll Flutter Engine from 0ed225c3cc03 to dba8e8d9e6cf (1 revision) (#136017) · 76b8f01a

engine-flutter-autoroll authored Oct 05, 2023

https://github.com/flutter/engine/compare/0ed225c3cc03...dba8e8d9e6cf

2023-10-05 skia-flutter-autoroll@skia.org Roll Skia from 7e025304e846 to e9b5e455ff8d (1 revision) (flutter/engine#46575)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

76b8f01a

Roll Flutter Engine from 44287139573c to 0ed225c3cc03 (1 revision) (#136015) · b75f5edb

engine-flutter-autoroll authored Oct 05, 2023

https://github.com/flutter/engine/compare/44287139573c...0ed225c3cc03

2023-10-05 skia-flutter-autoroll@skia.org Roll Skia from 0206ca4badc0 to 7e025304e846 (1 revision) (flutter/engine#46574)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b75f5edb

Roll Flutter Engine from 3fea9117be79 to 44287139573c (1 revision) (#136013) · 758cab3f

engine-flutter-autoroll authored Oct 05, 2023

https://github.com/flutter/engine/compare/3fea9117be79...44287139573c

2023-10-05 skia-flutter-autoroll@skia.org Roll Skia from 10b86aa8d8b7 to 0206ca4badc0 (1 revision) (flutter/engine#46572)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

758cab3f

Roll Flutter Engine from 4d1f8ff52903 to 3fea9117be79 (2 revisions) (#136012) · a6fc4d28

engine-flutter-autoroll authored Oct 05, 2023

https://github.com/flutter/engine/compare/4d1f8ff52903...3fea9117be79

2023-10-05 skia-flutter-autoroll@skia.org Roll Dart SDK from b8fceaea291c to 368fd3846df0 (1 revision) (flutter/engine#46571)
2023-10-05 skia-flutter-autoroll@skia.org Roll Skia from 073737b7f4ab to 10b86aa8d8b7 (1 revision) (flutter/engine#46570)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a6fc4d28

Roll Flutter Engine from 8e3a05c9878e to 4d1f8ff52903 (1 revision) (#136009) · 7ad6a09d

engine-flutter-autoroll authored Oct 05, 2023

https://github.com/flutter/engine/compare/8e3a05c9878e...4d1f8ff52903

2023-10-05 robert.ancell@canonical.com Use GdkEvent methods to access values, direct access is removed in GTK4. (flutter/engine#46526)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7ad6a09d

Roll Flutter Engine from 8e6dd239fb1a to 8e3a05c9878e (3 revisions) (#136007) · 7dbdf819

engine-flutter-autoroll authored Oct 05, 2023

https://github.com/flutter/engine/compare/8e6dd239fb1a...8e3a05c9878e

2023-10-04 chinmaygarde@google.com Update buildroot to 5d60bd2. (flutter/engine#46564)
2023-10-04 ychris@google.com [ios] Link PlatformView back to semantics tree (flutter/engine#46471)
2023-10-04 skia-flutter-autoroll@skia.org Roll Skia from d061d21eed0d to 073737b7f4ab (2 revisions) (flutter/engine#46563)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7dbdf819