1. 02 Feb, 2024 10 commits
    • Bartek Pacia's avatar
      Reland "Add support for Gradle Kotlin DSL (#140744)" (#142752) · 6facb969
      Bartek Pacia authored
      This PR attempts to:
      - reland #140744
      - reland #141541 (which is also in #142300 - I will close it once this PR is merged)
      6facb969
    • Justin McCandless's avatar
      Support navigation during a Cupertino back gesture (#142248) · 3280be93
      Justin McCandless authored
      Fixes a bug where programmatically navigating during an iOS back gesture caused the app to enter an unstable state.
      3280be93
    • Lau Ching Jun's avatar
      Avoid depending on files from build_system/targets other than from top level... · ac7879e2
      Lau Ching Jun authored
      Avoid depending on files from build_system/targets other than from top level entrypoints in flutter_tools. (#142760)
      
      Add a new `BuildTargets` class that provides commonly used build targets. And avoid importing files from `build_system/targets` except from the top level entrypoints or from top level commands.
      
      Also move `scene_importer.dart` and `shader_compiler.dart` into `build_system/tools` because they are not `Target` classes, but wrapper for certain tools.
      
      With this change, we can ignore all files in `build_system/targets` internally and make PR #142709 easier to land internally. See cl/603434066 for the corresponding internal change.
      
      Related to:
      https://github.com/flutter/flutter/pull/142709
      https://github.com/flutter/flutter/issues/142041
      
      Also note that I have opted to add a new variable in `globals.dart` for `BuildTargets` in this PR, but I know that we are trying to get rid of globals. Several alternatives that I was considering:
      
      1. Add a new field in `BuildSystem` that returns a `BuildTargets` instance. Since `BuildSystem` is already in `globals`, we can access build targets using `globals.buildSystem.buildTargets` without adding a new global variable.
      2. Properly inject the `BuildTargetsImpl` instance from the top level `executable.dart` and top level commands.
      
      Let me know if you want me to do one of the above instead. Thanks!
      ac7879e2
    • engine-flutter-autoroll's avatar
      Roll Packages from 5b48c446976f to d37fb0a716e7 (14 revisions) (#142812) · b209125d
      engine-flutter-autoroll authored
      https://github.com/flutter/packages/compare/5b48c446976f...d37fb0a716e7
      
      2024-02-02 32242716+ricardoamador@users.noreply.github.com Add a link the different possible Android virtual device configs (flutter/packages#6033)
      2024-02-01 32242716+ricardoamador@users.noreply.github.com Update the emulator versions and expose cipd. (flutter/packages#6025)
      2024-02-01 stuartmorgan@google.com [tool] Add details to missing gradle coverage error (flutter/packages#6029)
      2024-02-01 stuartmorgan@google.com [file_selector] Fix comment typo (flutter/packages#6027)
      2024-02-01 43054281+camsim99@users.noreply.github.com [camerax] Change `buildPreview` to return `Texture` versus `FutureBuilder` (flutter/packages#6021)
      2024-02-01 engine-flutter-autoroll@skia.org Manual roll Flutter from c65ab4d5 to e02e2079 (38 revisions) (flutter/packages#6028)
      2024-02-01 engine-flutter-autoroll@skia.org Manual roll Flutter from 75a2e5b4 to c65ab4d5 (22 revisions) (flutter/packages#6026)
      2024-02-01 engine-flutter-autoroll@skia.org Roll Flutter from ace91811 to 75a2e5b4 (16 revisions) (flutter/packages#6017)
      2024-02-01 JeroenWeener@users.noreply.github.com [webview_flutter] Support for handling basic authentication requests (flutter/packages#5727)
      2024-01-31 stuartmorgan@google.com [tool] Extend `flutter test` workaround to other desktops (flutter/packages#6024)
      2024-01-31 katelovett@google.com [two_dimensional_scrollables] Merged cells for TableView (flutter/packages#5917)
      2024-01-31 tessertaha@gmail.com [rfw] Restore RFW to 100% coverage after `ButtonBar` update (flutter/packages#6020)
      2024-01-31 louisehsu@google.com [in_app_purchase] Convert storefront(), transactions(), canMakePayment(), and addPayment() to pigeon (flutter/packages#5910)
      2024-01-31 reidbaker@google.com [in_app_purchase] Add play country code api (flutter/packages#5941)
      
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
      Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
      is aware of the problem.
      
      To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
      
      To report a problem with the AutoRoller itself, please file a bug:
      https://issues.skia.org/issues/new?component=1389291&template=1850622
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
      b209125d
    • Ricardo Amador's avatar
      Add a link the different possible Android virtual device configs (#142765) · 3f30dc2e
      Ricardo Amador authored
      *Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*
      
      *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*
      
      *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
      3f30dc2e
    • Victoria Ashworth's avatar
      Allow all iOS tests to use either iOS 16 or 17 (#142714) · 822ebc48
      Victoria Ashworth authored
      Undoing https://github.com/flutter/flutter/pull/142323 to allow all iOS tests to use iOS 16 or 17.
      822ebc48
    • engine-flutter-autoroll's avatar
      Roll Flutter Engine from b35153d00b2e to e29263212bfd (2 revisions) (#142799) · 10e6f4bd
      engine-flutter-autoroll authored
      https://github.com/flutter/engine/compare/b35153d00b2e...e29263212bfd
      
      2024-02-02 cone.bart@gmail.com [Android] Fix TextInputType.none for
      devices with physical keyboard (flutter/engine#49980)
      2024-02-02 98614782+auto-submit[bot]@users.noreply.github.com Reverts
      "Add the focus state related methods to the platform dispatcher"
      (flutter/engine#50268)
      
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
      Please CC matanl@google.com,rmistry@google.com,zra@google.com on the
      revert to ensure that a human
      is aware of the problem.
      
      To file a bug in Flutter:
      https://github.com/flutter/flutter/issues/new/choose
      
      To report a problem with the AutoRoller itself, please file a bug:
      https://issues.skia.org/issues/new?component=1389291&template=1850622
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
      10e6f4bd
    • engine-flutter-autoroll's avatar
      Roll Flutter Engine from dd4c79a6c864 to b35153d00b2e (10 revisions) (#142783) · 6cc4edb9
      engine-flutter-autoroll authored
      https://github.com/flutter/engine/compare/dd4c79a6c864...b35153d00b2e
      
      2024-02-02 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 82936dcdaf4f to 5a5d4c262200 (2 revisions) (flutter/engine#50264)
      2024-02-01 dkwingsmt@users.noreply.github.com Remove number of arguments from defining Dart FFI (flutter/engine#50153)
      2024-02-01 32242716+ricardoamador@users.noreply.github.com Refactor the linux_android targets to make use of recent changes to android virtual device params (flutter/engine#50099)
      2024-02-01 goderbauer@google.com Re-add tests deleted on accident (flutter/engine#50223)
      2024-02-01 30870216+gaaclarke@users.noreply.github.com [Impeller] updated todos from opengles golden work (flutter/engine#50218)
      2024-02-01 flar@google.com Get bounds from RTree in DLBuilder::Build() (flutter/engine#50253)
      2024-02-01 chinmaygarde@google.com [Impeller] Remove unused define. (flutter/engine#50250)
      2024-02-01 tugorez@users.noreply.github.com Add the focus state related methods to the platform dispatcher (flutter/engine#49841)
      2024-02-01 jason-simmons@users.noreply.github.com Fix the output paths of the Web esbuild GN template (flutter/engine#50188)
      2024-02-01 chinmaygarde@google.com [Impeller] Delete unnecessary special casing for Vulkan in framebuffer fetch. (flutter/engine#50251)
      
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
      Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
      is aware of the problem.
      
      To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
      
      To report a problem with the AutoRoller itself, please file a bug:
      https://issues.skia.org/issues/new?component=1389291&template=1850622
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
      6cc4edb9
    • Jackson Gardner's avatar
      Wasm/JS Dual Compile with the flutter tool (#141396) · ba626dc8
      Jackson Gardner authored
      This implements dual compile via the newly available flutter.js bootstrapping APIs for intelligent build fallback.
      * Users can now use the `FlutterLoader.load` API from flutter.js
      * Flutter tool injects build info into the `index.html` of the user so that the bootstrapper knows which build variants are available to bootstrap
      * The semantics of the `--wasm` flag for `flutter build web` have changed:
        - Instead of producing a separate `build/web_wasm` directory, the output goes to the `build/web` directory like a normal web build
        - Produces a dual build that contains two build variants: dart2wasm+skwasm and dart2js+CanvasKit. The dart2wasm+skwasm will only work on Chrome in a cross-origin isolated context, all other environments will fall back to dart2js+CanvasKit.
        - `--wasm` and `--web-renderer` are now mutually exclusive. Since there are multiple build variants with `--wasm`, the web renderer cannot be expressed via a single command-line flag. For now, we are hard coding what build variants are produced with the `--wasm` flag, but I plan on making this more customizable in the future.
      * Build targets now can optionally provide a "build key" which can uniquely identify any specific parameterization of that build target. This way, the build target can invalidate itself by changing its build key. This works a bit better than just stuffing everything into the environment defines because (a) it doesn't invalidate the entire build, just the targets which are affected and (b) settings for multiple build variants don't translate well to the flat map of environment defines.
      ba626dc8
    • Hans Muller's avatar
      Reland: Added ButtonStyle.foregroundBuilder and ButtonStyle.backgroundBuilder (#142762) · c6f2cea6
      Hans Muller authored
      Reland https://github.com/flutter/flutter/pull/141818 with a fix for a special case: If only `background` is specified for `TextButton.styleFrom` or `OutlinedButton.styleFrom` it applies the button's disabled state, i.e. as if the same value had been specified for disabledBackgroundColor.
      
      The change relative to #141818 is the indicated line below:
      ```dart
      final MaterialStateProperty<Color?>? backgroundColorProp = switch ((backgroundColor, disabledBackgroundColor)) {
        (null, null) => null,
        (_, null) => MaterialStatePropertyAll<Color?>(backgroundColor), // ADDED THIS LINE
        (_, _) => _TextButtonDefaultColor(backgroundColor, disabledBackgroundColor),
      };
        ```
      
      This backwards incompatibility cropped up in an internal test, see internal Google issue b/323399158.
      c6f2cea6
  2. 01 Feb, 2024 30 commits