Commits · 682dd3bdc848e4acd52d1894dc9f5f07cbf8ab69 · abdullh.alsoleman / Front-End

18 May, 2023 9 commits

Roll Flutter Engine from 843ce0bba356 to 237c60185ace (2 revisions) (#127122) · 682dd3bd

engine-flutter-autoroll authored May 18, 2023

https://github.com/flutter/engine/compare/843ce0bba356...237c60185ace

2023-05-18 skia-flutter-autoroll@skia.org Roll Skia from ad8fa4a38668 to 62841fa33e95 (2 revisions) (flutter/engine#42123)
2023-05-18 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from SDKw1RvH0dWiJXERo... to zqkH0qb9GQ3jO24Bh... (flutter/engine#42124)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from SDKw1RvH0dWi to zqkH0qb9GQ3j

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

682dd3bd

Revert "Handle null return from WillPopCallback" (#127112) · 5ae64381
Michael Goderbauer authored May 18, 2023
```
Reverts flutter/flutter#127039

Google3 has been fixed, so this work around is no longe necessary.
```
5ae64381

Roll Flutter Engine from a22dd6438335 to 843ce0bba356 (6 revisions) (#127116) · 2b95fa67

engine-flutter-autoroll authored May 18, 2023

https://github.com/flutter/engine/compare/a22dd6438335...843ce0bba356

2023-05-18 skia-flutter-autoroll@skia.org Roll Skia from a3a9fb5f4a31 to ad8fa4a38668 (1 revision) (flutter/engine#42121)
2023-05-18 skia-flutter-autoroll@skia.org Roll Dart SDK from 7f6fabbe9fba to 1991015ad460 (4 revisions) (flutter/engine#42120)
2023-05-18 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from wNfsef5we4l8hxEII... to jNFpQ1gTCMNbzSZCw... (flutter/engine#42118)
2023-05-18 skia-flutter-autoroll@skia.org Roll Skia from caff30d16ae7 to a3a9fb5f4a31 (1 revision) (flutter/engine#42117)
2023-05-18 skia-flutter-autoroll@skia.org Roll Skia from ffa425bacfc4 to caff30d16ae7 (29 revisions) (flutter/engine#42116)
2023-05-18 chris@bracken.jp [macOS] Clean up PlatformView mutator scaling (flutter/engine#42110)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from wNfsef5we4l8 to jNFpQ1gTCMNb

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2b95fa67

mark windows build tests non-bringup (#127059) · 344c9c6a

Christopher Fujino authored May 18, 2023

This is a follow-up to https://github.com/flutter/flutter/commit/aa0a1a7ae1467f54e962a5616e5bf4385fbf1daf. I was forced to mark these targets bringup in that PR because the targets were technically new (since each name changed 3 -> 4), so this is marking them non-bringup.

344c9c6a

Roll Flutter Engine from d97037077963 to a22dd6438335 (1 revision) (#127071) · 4245883c

engine-flutter-autoroll authored May 18, 2023

https://github.com/flutter/engine/compare/d97037077963...a22dd6438335

2023-05-17 xilaizhang@google.com [g3 roll] Revert "add non-rendering
operation culling to DisplayListBuilder" (flutter/engine#42097)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4245883c

Roll Packages from 5c6991400e91 to b31a12861905 (9 revisions) (#127109) · 5381e82a

engine-flutter-autoroll authored May 18, 2023

https://github.com/flutter/packages/compare/5c6991400e91...b31a12861905

2023-05-18 stuartmorgan@google.com [flutter_plugin_android_lifecycle] Fix lints (flutter/packages#4030)
2023-05-18 ian@hixie.ch [rfw] Fix a typo in the API documentation (flutter/packages#4023)
2023-05-18 ditman@gmail.com [ci] Manual flutter roll (flutter/packages#4033)
2023-05-17 4195507+fmt-Println-MKO@users.noreply.github.com [flutter_adaptive_scaffold] exchange BottomNavigationBar with NavigationBar (flutter/packages#3746)
2023-05-17 stuartmorgan@google.com [tools] Ignore comments in federated safety check (flutter/packages#4028)
2023-05-17 reidbaker@google.com Revert "[url_launcher] Set broadcast reciever visability as required by target api 34" (flutter/packages#4027)
2023-05-17 stuartmorgan@google.com [camera] Fix Java lints in camerax version (flutter/packages#3966)
2023-05-17 34871572+gmackall@users.noreply.github.com [image_picker] Upgrade androidx.activity to 1.7.0 and add a dependency on kotlin-bom to align kotlin transitive dependencies (flutter/packages#3968)
2023-05-17 49699333+dependabot[bot]@users.noreply.github.com [espresso]: Bump com.squareup.okhttp3:okhttp from 4.10.0 to 4.11.0 in /packages/espresso/android (flutter/packages#3804)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5381e82a

Revert "Remove obsolete drawShadow bounds workaround" (#127110) · 6071f149

Justin McCandless authored May 18, 2023

Reverts flutter/flutter#127052, which seems to be breaking the build
because of a goldens failure.

```
The following TestFailure was thrown running a test:
Expected: one widget whose rasterized image matches golden image "shadow.PhysicalModel.enabled.png"
  Actual: _WidgetTypeFinder:<exactly one widget with type "Container" (ignoring offstage widgets):
Container(bg: Color(0xfffff59d), margin: EdgeInsets.all(150.0))>
```

See
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_tests_6/11051/overview

6071f149

Clip search view content during animation (#126975) · f31dae2a

Qun Cheng authored May 18, 2023

Fixes #126590

This PR is to clip the view content when the view size is not big enough, such as during animation.
Also removes some unused properties in `_ViewContent` class: `getRect` and `viewConstraints`

f31dae2a

Remove obsolete drawShadow bounds workaround (#127052) · 8089a309

Jim Graham authored May 18, 2023

This workaround was created 6 years ago with no links to bug databases to track. As best we can determine, the issue is no longer present in SkPicture or DisplayList and is most likely obsolete. More importantly, though, non-rendering primitives are ignored by the DisplayList construction and so this workaround will just be ignored anyway. If a problem surfaces about this issue that we haven't discovered by a thorough code search of the current code base, then workarounds should be installed within the relevant implementation modules rather than in the framework (and documented with bugs filed in either or both of Flutter's github repos, and/or the Skia issue database).

Workaround originally created in this PR: https://github.com/flutter/flutter/pull/9654

8089a309

17 May, 2023 24 commits

[Windows] Improve version migration message (#127048) · 718f444b
Loïc Sharma authored May 17, 2023
```
This also migrates the platform channel example to stamp version information on Windows.
```
718f444b

Bump actions/labeler from 9471598e3b7ff22b2fa181bd79addf94cb3e0847 to... · a3a0ef03

dependabot[bot] authored May 17, 2023

Bump actions/labeler from 9471598e3b7ff22b2fa181bd79addf94cb3e0847 to 6b107e7a7ee5e054e0bcce60de5181d21e2f00fb (#127056)

Bumps [actions/labeler](https://github.com/actions/labeler) from 9471598e3b7ff22b2fa181bd79addf94cb3e0847 to 6b107e7a7ee5e054e0bcce60de5181d21e2f00fb.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/actions/labeler/commit/6b107e7a7ee5e054e0bcce60de5181d21e2f00fb"><code>6b107e7</code></a> Bump <code>@âtypescript-eslint/parser</code> from 5.59.5 to 5.59.6 (<a href="https://redirect.github.com/actions/labeler/issues/565">#565</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/d93c73a681c099c55b461e5ef853f84b8335eebf"><code>d93c73a</code></a> Bump <code>@âtypescript-eslint/eslint-plugin</code> from 5.59.5 to 5.59.6 (<a href="https://redirect.github.com/actions/labeler/issues/566">#566</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/b6f708799c1101ee9adc1388b397da244f9dec1c"><code>b6f7087</code></a> Bump <code>@âtypescript-eslint/eslint-plugin</code> from 5.59.2 to 5.59.5 (<a href="https://redirect.github.com/actions/labeler/issues/559">#559</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/2d89bd50598cb5288ebd91402d368ebb889ebdc6"><code>2d89bd5</code></a> Bump <code>@âtypescript-eslint/parser</code> from 5.59.2 to 5.59.5 (<a href="https://redirect.github.com/actions/labeler/issues/560">#560</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/581d1100aad5e840ecddbe532d475ab7b2e3b823"><code>581d110</code></a> Bump eslint from 8.39.0 to 8.40.0 (<a href="https://redirect.github.com/actions/labeler/issues/558">#558</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/8bb487275077addd935ff34fd81cda8dc53b6cbe"><code>8bb4872</code></a> Bump eslint from 8.38.0 to 8.39.0 (<a href="https://redirect.github.com/actions/labeler/issues/543">#543</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/9c4ae1e1124d78f7b1e31d451ea2c8b2199df4f9"><code>9c4ae1e</code></a> Bump <code>@âtypescript-eslint/eslint-plugin</code> from 5.58.0 to 5.59.2 (<a href="https://redirect.github.com/actions/labeler/issues/553">#553</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/228fdad71d6ca2122f78183ba915be56c28ba970"><code>228fdad</code></a> Bump prettier from 2.8.7 to 2.8.8 (<a href="https://redirect.github.com/actions/labeler/issues/544">#544</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/377691d3d6bba411b0050ded8b41e9d6732a4c49"><code>377691d</code></a> Bump <code>@âtypescript-eslint/parser</code> from 5.58.0 to 5.59.2 (<a href="https://redirect.github.com/actions/labeler/issues/554">#554</a>)</li>
<li>See full diff in <a href="https://github.com/actions/labeler/compare/9471598e3b7ff22b2fa181bd79addf94cb3e0847...6b107e7a7ee5e054e0bcce60de5181d21e2f00fb">compare view</a></li>
</ul>
</details>
<br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

a3a0ef03

Remove deprecated fixTextFieldOutlineLabel (#125893) · d44d657a

Renzo Olivares authored May 17, 2023

The deprecation period has elapsed. The method was made obsolete in https://github.com/flutter/flutter/pull/87281.

d44d657a

Roll Flutter Engine from 331c5769e291 to d97037077963 (3 revisions) (#127053) · 45179a62

engine-flutter-autoroll authored May 17, 2023

https://github.com/flutter/engine/compare/331c5769e291...d97037077963

2023-05-17 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from YrEDYUB9NKhirgo5s... to SDKw1RvH0dWiJXERo... (flutter/engine#42100)
2023-05-17 jonahwilliams@google.com [Impelller] fix flickering due to synchronization issues in compute tessellator. (flutter/engine#42076)
2023-05-17 rmolivares@renzo-olivares.dev [Android] Do not collapse text selection on shift key up (flutter/engine#42075)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from YrEDYUB9NKhi to SDKw1RvH0dWi

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

45179a62

shard windows build tests 3 -> 4 (#127057) · aa0a1a7a

Christopher Fujino authored May 17, 2023

Time outs are currently making the tree red.

Fixes https://github.com/flutter/flutter/issues/127004

aa0a1a7a

Roll Flutter Engine from 0ae3719d7043 to 331c5769e291 (1 revision) (#127049) · dad561f4

engine-flutter-autoroll authored May 17, 2023

https://github.com/flutter/engine/compare/0ae3719d7043...331c5769e291

2023-05-17 mdebbar@google.com [web] Simplify handling of custom url strategy (flutter/engine#42043)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

dad561f4

Ignore unused_element_parameter (#126926) · 7a325045

Sam Rawlins authored May 17, 2023

When the analyzer detects an unused parameter, it reports `unused_element` which can be ignored with an inline ignore like `// ignore: unused_element`. The analyzer will start reporting instead, `unused_element_parameter`. There are ignores in flutter/flutter that need to be updated to the new code. In order to incrementally migrate, they can be changed to `// ignore: unused_element, unused_element_parameter`.

After flutter/flutter is using a new enough analyzer, we can then change those to `// ignore: unused_element_parameter`.

Work towards https://github.com/flutter/flutter/issues/126924

7a325045

Roll Flutter Engine from 47fd496c6f8d to 0ae3719d7043 (2 revisions) (#127043) · 9657289f

engine-flutter-autoroll authored May 17, 2023

https://github.com/flutter/engine/compare/47fd496c6f8d...0ae3719d7043

2023-05-17 dnfield@google.com Report displays for macOS (flutter/engine#41998)
2023-05-17 dnfield@google.com Fix bounds when painting style is stroke width for image shaders (flutter/engine#42052)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9657289f

Roll Flutter Engine from 400a26ad8343 to 47fd496c6f8d (3 revisions) (#127041) · 1f09a866

engine-flutter-autoroll authored May 17, 2023

https://github.com/flutter/engine/compare/400a26ad8343...47fd496c6f8d

2023-05-17 103135467+sealesj@users.noreply.github.com Re-Enable Vulnerability 3p Scanning Workflow (flutter/engine#42049)
2023-05-17 skia-flutter-autoroll@skia.org Roll Skia from c3473c32bb35 to ffa425bacfc4 (14 revisions) (flutter/engine#42095)
2023-05-17 30870216+gaaclarke@users.noreply.github.com [Impeller] Turned on wide gamut support by default. (#39801) (flutter/engine#41965)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1f09a866

[flutter_tools] unpin and roll camera_android (#126945) · 05af4607

Christopher Fujino authored May 17, 2023

camera_android was pinned because of https://github.com/flutter/flutter/issues/126710, which was fixed upstream in release 0.10.8+1.

05af4607

Handle null return from WillPopCallback (#127039) · acbfb40f

Michael Goderbauer authored May 17, 2023

Partial revert of https://github.com/flutter/flutter/pull/126647 to work around issue in google3.

See b/283046390

acbfb40f

Roll Flutter Engine from 6048360c1837 to 400a26ad8343 (1 revision) (#127036) · c08b9acc

engine-flutter-autoroll authored May 17, 2023

https://github.com/flutter/engine/compare/6048360c1837...400a26ad8343

2023-05-17 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from dIATtSiPf8KE25MMF... to wNfsef5we4l8hxEII... (flutter/engine#42094)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from dIATtSiPf8KE to wNfsef5we4l8

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c08b9acc

Remove unused (and untested) parameters from private _MasterDetailFlow (#126935) · 0bd275fe
Michael Goderbauer authored May 17, 2023
```
Follow-up to https://github.com/flutter/flutter/pull/126926.
```
0bd275fe
Autocomplete async examples (#126283) · 9d882983
Justin McCandless authored May 17, 2023
```
Added examples clarifying how to fetch Autocomplete options asynchronously.
```
9d882983
Expose callback that allows focus traversal customization (#120235) · 561169ec
JellyO1 authored May 17, 2023
```
This PR exposes a requestFocusCallback on `FocusTraversalPolicy` and it's inheritors.

Fixes #83175.
```
561169ec

Roll Packages from b9718302b30f to 5c6991400e91 (5 revisions) (#127034) · 1a76859c

engine-flutter-autoroll authored May 17, 2023

https://github.com/flutter/packages/compare/b9718302b30f...5c6991400e91

2023-05-17 49699333+dependabot[bot]@users.noreply.github.com [video_player]: Bump exoplayer_version from 2.18.5 to 2.18.6 in /packages/video_player/video_player_android/android (flutter/packages#3770)
2023-05-17 JeroenWeener@users.noreply.github.com [in_app_purchase] Fully migrate to BillingClient V5 (flutter/packages#3752)
2023-05-17 stuartmorgan@google.com [ci] Re-enable Windows repo tool tests (flutter/packages#4007)
2023-05-16 stuartmorgan@google.com [ci] Allow simctl shutdown to fail (flutter/packages#4024)
2023-05-16 stuartmorgan@google.com [ci] Move Linux repo tool tests to LUCI (flutter/packages#4006)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1a76859c

Roll Flutter Engine from ea3f27383acc to 6048360c1837 (2 revisions) (#127032) · 05390851

engine-flutter-autoroll authored May 17, 2023

https://github.com/flutter/engine/compare/ea3f27383acc...6048360c1837

2023-05-17 skia-flutter-autoroll@skia.org Roll Skia from 88d7a68694d9 to c3473c32bb35 (2 revisions) (flutter/engine#42093)
2023-05-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 2fc9f4dd9623 to 7f6fabbe9fba (1 revision) (flutter/engine#42090)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

05390851

Add missing `Switch.onFocusChange` test (#126685) · 160618b1
Taha Tesser authored May 17, 2023

160618b1
Remove 'url_launcher' from pubspec.yaml. (#126939) · d021109d
joshualitt authored May 17, 2023

d021109d

Roll Flutter Engine from 4b7c37532ea4 to ea3f27383acc (1 revision) (#126994) · e2aafd45

engine-flutter-autoroll authored May 17, 2023

https://github.com/flutter/engine/compare/4b7c37532ea4...ea3f27383acc

2023-05-17 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
D_EOM3rJ8AMk3-Wex... to YrEDYUB9NKhirgo5s... (flutter/engine#42086)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from D_EOM3rJ8AMk to YrEDYUB9NKhi

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e2aafd45

Roll Flutter Engine from 170b45bae571 to 4b7c37532ea4 (1 revision) (#126985) · 45e3039a

engine-flutter-autoroll authored May 17, 2023

https://github.com/flutter/engine/compare/170b45bae571...4b7c37532ea4

2023-05-17 skia-flutter-autoroll@skia.org Roll Dart SDK from dbbb8a6d79a3 to 2fc9f4dd9623 (1 revision) (flutter/engine#42085)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

45e3039a

Roll Flutter Engine from 28b9dc993c30 to 170b45bae571 (1 revision) (#126981) · 4be65314

engine-flutter-autoroll authored May 17, 2023

https://github.com/flutter/engine/compare/28b9dc993c30...170b45bae571

2023-05-17 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from N4LwCRxg0oIevhQ_O... to dIATtSiPf8KE25MMF... (flutter/engine#42084)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from N4LwCRxg0oIe to dIATtSiPf8KE

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4be65314

Roll Flutter Engine from 87a03e107df7 to 28b9dc993c30 (1 revision) (#126974) · abdf1f46

engine-flutter-autoroll authored May 17, 2023

https://github.com/flutter/engine/compare/87a03e107df7...28b9dc993c30

2023-05-16 skia-flutter-autoroll@skia.org Roll Dart SDK from d2b2ac829842 to dbbb8a6d79a3 (3 revisions) (flutter/engine#42082)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

abdf1f46

Roll Flutter Engine from 1c775e34e2d5 to 87a03e107df7 (3 revisions) (#126968) · 790897c6

engine-flutter-autoroll authored May 17, 2023

https://github.com/flutter/engine/compare/1c775e34e2d5...87a03e107df7

2023-05-16 bdero@google.com [Impeller] Use 32 bit Gaussian function in the 2-pass blur (flutter/engine#42069)
2023-05-16 skia-flutter-autoroll@skia.org Roll Skia from 9b0e912a1cb9 to 88d7a68694d9 (13 revisions) (flutter/engine#42081)
2023-05-16 jacksongardner@google.com Use client ICU data with skwasm. (flutter/engine#42018)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

790897c6

16 May, 2023 7 commits

Fix style issues (#122586) · 788ceb34

Sigurd Meldgaard authored May 16, 2023

Follow-up to https://github.com/flutter/flutter/pull/121802 resolving some style issues.

788ceb34

Manual roll Flutter Engine from fe2476743b59 to 1c775e34e2d5 (10 revisions) (#126961) · 5df903a0

engine-flutter-autoroll authored May 16, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/fe2476743b59...1c775e34e2d5

2023-05-16 zanderso@users.noreply.github.com Revert "[ios_platform_view]
only recycle maskView when the view is applying mutators"
(flutter/engine#42080)
2023-05-16 gspencergoog@users.noreply.github.com [macOS] Wait for
binding to be ready before requesting exits from framework
(flutter/engine#41753)
2023-05-16 gspencergoog@users.noreply.github.com [linux] Wait for
binding to be ready before requesting exits from framework
(flutter/engine#41782)
2023-05-16 jacksongardner@google.com Initial support for images in
Skwasm (flutter/engine#42019)
2023-05-16 jacksongardner@google.com Use new `unresolvedCodePoints` API
from skia. (flutter/engine#41991)
2023-05-16 jason-simmons@users.noreply.github.com Convert public API
NativeFieldWrapper classes to abstract interfaces (flutter/engine#41945)
2023-05-16 737941+loic-sharma@users.noreply.github.com [Windows] Add
force redraw to the C++ client wrapper (flutter/engine#42061)
2023-05-16 godofredoc@google.com Fix drone_dimension
host_engine_builder. (flutter/engine#42068)
2023-05-16 godofredoc@google.com Add linux_clang_tidy builder.
(flutter/engine#41990)
2023-05-16 ychris@google.com [ios_platform_view] only recycle maskView
when the view is applying mutators (flutter/engine#41573)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5df903a0

Make SlottedMultiChildRenderObjectWidgetMixin a concrete class (#126108) · 027bb844

Ian Hickson authored May 16, 2023

This is a proof of concept for renaming SlottedMultiChildRenderObjectWidgetMixin to SlottedMultiChildRenderObjectWidget and making it a concrete class.

I also made SlottedContainerRenderObjectMixin generic instead of being specialized to RenderBox.

I don't think this is something we can easily automigrate, but we may not need to, I don't know how common this is...

027bb844

Add ScrollMetrics.extentTotal for completeness (#126607) · 5235a0f0

Ian Hickson authored May 16, 2023

When implementing scrollbars, I found that it would be useful and idiomatic to be able to do `m.extentInside / m.extentTotal` to get the scrollbar thumb size.

5235a0f0

Fix drone_dimensions. (#126953) · 25a9efe9

godofredoc authored May 16, 2023

Use drone_dimensions instead of dimensions for builds running on dart-internal. This is required for those builders to select the correct drone type.

25a9efe9

Add checkmark style to CupertinoRadio (#126480) · 678f40cf

Mitchell Goodwin authored May 16, 2023

Fixes: #102813

Adds a checkmark style to the Cupertino Radio. Also allows the Radio.adaptive and RadioListTile.adaptive widgets to control whether they use the checkmark style for their Cupertino widgets or not.

This is how it looks in action:

https://github.com/flutter/flutter/assets/58190796/b409b270-42dd-404a-9350-d2c3e1d7fa4e

678f40cf

Move `Mac_build_test flutter_gallery__transition_perf_e2e_ios` to prod (#126941) · 3f01c7e0

keyonghan authored May 16, 2023

Target `Mac_build_test flutter_gallery__transition_perf_e2e_ios` was enabled in staging: https://github.com/flutter/flutter/pull/111164, and it has passed more than 50 runs: https://ci.chromium.org/p/flutter/builders/staging/Mac_build_test%20flutter_gallery__transition_perf_e2e_ios?limit=50.

Manually enabling it in prod and removing the old `Mac_ios flutter_gallery__transition_perf_e2e_ios`.

The `Mac_build_test` one does the same thing as `Mac_ios` one, but separating build and test steps in separate targets.

Context: https://github.com/flutter/flutter/issues/103542

3f01c7e0