Commits · 678f40cf04f40c6ac47da5524b42da45ef956496 · abdullh.alsoleman / Front-End

16 May, 2023 20 commits

Add checkmark style to CupertinoRadio (#126480) · 678f40cf

Mitchell Goodwin authored May 16, 2023

Fixes: #102813

Adds a checkmark style to the Cupertino Radio. Also allows the Radio.adaptive and RadioListTile.adaptive widgets to control whether they use the checkmark style for their Cupertino widgets or not.

This is how it looks in action:

https://github.com/flutter/flutter/assets/58190796/b409b270-42dd-404a-9350-d2c3e1d7fa4e

678f40cf

Move `Mac_build_test flutter_gallery__transition_perf_e2e_ios` to prod (#126941) · 3f01c7e0

keyonghan authored May 16, 2023

Target `Mac_build_test flutter_gallery__transition_perf_e2e_ios` was enabled in staging: https://github.com/flutter/flutter/pull/111164, and it has passed more than 50 runs: https://ci.chromium.org/p/flutter/builders/staging/Mac_build_test%20flutter_gallery__transition_perf_e2e_ios?limit=50.

Manually enabling it in prod and removing the old `Mac_ios flutter_gallery__transition_perf_e2e_ios`.

The `Mac_build_test` one does the same thing as `Mac_ios` one, but separating build and test steps in separate targets.

Context: https://github.com/flutter/flutter/issues/103542

3f01c7e0

Fix DataTableThemeData.copyWith handling of dataRowHeight (#126943) · e24c64d8
Jason Simmons authored May 16, 2023
```
Fixes https://github.com/flutter/flutter/issues/126676
```
e24c64d8

Fix copyWith method of ActionIconThemeData (#126763) · 60751ca5

Mushaheed Syed authored May 16, 2023

Fixes copyWith method of ActionIconThemeData, now using blank copyWith on [ActionIconThemeData] object that isn't `const ActionIconThemeData()` returns object with same values.

*List which issues are fixed by this PR.*
Fixes https://github.com/flutter/flutter/issues/126762

60751ca5

Revert "Roll Flutter Engine from fe2476743b59 to 5cf141f7c03c (2 revisions)" (#126954) · 99464341
Zachary Anderson authored May 16, 2023
```
Reverts flutter/flutter#126934

Bad Engine roll.
```
99464341

Roll Flutter Engine from fe2476743b59 to 5cf141f7c03c (2 revisions) (#126934) · d0d1feb6

engine-flutter-autoroll authored May 16, 2023

https://github.com/flutter/engine/compare/fe2476743b59...5cf141f7c03c

2023-05-16 godofredoc@google.com Add linux_clang_tidy builder. (flutter/engine#41990)
2023-05-16 ychris@google.com [ios_platform_view] only recycle maskView when the view is applying mutators (flutter/engine#41573)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d0d1feb6

Remove outdated comment (#126927) · 1ca183d5
Michael Goderbauer authored May 16, 2023
```
Follow-up to https://github.com/flutter/flutter/pull/126647#discussion_r1195417860.
```
1ca183d5

Alert engine upon registering ServiceBinding (#126075) · 130944e7

yaakovschectman authored May 16, 2023

Send a platform message to the engine when the `ServiceBinding` is
registered. Framework side of
https://github.com/flutter/engine/pull/41733

Addresses https://github.com/flutter/flutter/issues/126033

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

---------
Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>

130944e7

Roll Flutter Engine from 525a53eb58ed to fe2476743b59 (1 revision) (#126925) · cc44359b

engine-flutter-autoroll authored May 16, 2023

https://github.com/flutter/engine/compare/525a53eb58ed...fe2476743b59

2023-05-16 skia-flutter-autoroll@skia.org Roll Skia from 24bebce2d9a1 to 9b0e912a1cb9 (12 revisions) (flutter/engine#42072)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cc44359b

Replace rsync when unzipping artifacts on a Mac (#126703) · 2b3cd7f4

Victoria Ashworth authored May 16, 2023

Instead of using rsync, which has caused errors in the past (https://github.com/flutter/flutter/issues/99785), delete the file/directory/link prior to moving it.

Hopefully should let us stop double zipping the FlutterMacOS.framework in the engine: https://github.com/flutter/engine/pull/41306/files

Part of https://github.com/flutter/flutter/issues/126016.

2b3cd7f4

Update SemanticsUpdateBuilderSpy for the conversion of SemanticsUpdateBuilder... · a3b38aa8

Jason Simmons authored May 16, 2023

Update SemanticsUpdateBuilderSpy for the conversion of SemanticsUpdateBuilder into a base class (#126570)

See https://github.com/flutter/flutter/issues/123756

a3b38aa8

expose `CupertinoDatePicker` and `CupertinoTimerPicker` `itemExtent` … (#125852) · 6753a852

st merlhin authored May 16, 2023

â¦property

This PR expose `CupertinoDatePicker` and `CupertinoTimerPicker` `itemExtent` property to allow setting custom one depending on `tMediaQuery.of(context).textScaleFactor`.
Fixes: #125127

6753a852

Roll Flutter Engine from d7a5de672d1e to 525a53eb58ed (1 revision) (#126923) · 856fcc30

engine-flutter-autoroll authored May 16, 2023

https://github.com/flutter/engine/compare/d7a5de672d1e...525a53eb58ed

2023-05-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
38Oyy28qgYCdt7fEV... to D_EOM3rJ8AMk3-Wex... (flutter/engine#42071)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 38Oyy28qgYCd to D_EOM3rJ8AMk

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

856fcc30

enable no_literal_bool_comparisons lint (#126647) · 5e1ba701
Michael Goderbauer authored May 16, 2023

5e1ba701

Roll Packages from 6608b604b0e7 to b9718302b30f (2 revisions) (#126921) · b45f9b36

engine-flutter-autoroll authored May 16, 2023

https://github.com/flutter/packages/compare/6608b604b0e7...b9718302b30f

2023-05-16 stuartmorgan@google.com [camera] Fix Android lint issues (flutter/packages#3993)
2023-05-15 stuartmorgan@google.com [various] Update min macOS versions (flutter/packages#3987)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b45f9b36

Updated the `Drawer` API doc to link to `NavigationDrawer` (#126915) · 2f5ed339
Taha Tesser authored May 16, 2023
```
fixes https://github.com/flutter/flutter/issues/124887
```
2f5ed339

Roll Flutter Engine from c4d4b40c6596 to d7a5de672d1e (4 revisions) (#126919) · e62e5c41

engine-flutter-autoroll authored May 16, 2023

https://github.com/flutter/engine/compare/c4d4b40c6596...d7a5de672d1e

2023-05-16 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
JCoP2Fekj3MBIqskE... to N4LwCRxg0oIevhQ_O... (flutter/engine#42070)
2023-05-16 zhangzhijian.123@bytedance.com [Impeller] Fix issue about
saveLayer ignoring opacity of paint with advanced blend mode
(flutter/engine#41972)
2023-05-16 ychris@google.com [ios_platform_view] Only remove platform
views from flutter view in reset. (flutter/engine#41709)
2023-05-16 godofredoc@google.com Add drone_dimensions as top level
target property. (flutter/engine#42064)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from JCoP2Fekj3MB to N4LwCRxg0oIe

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e62e5c41

Upgrade leak_tracker to 5.0.0 (#126367) · ea5eddb5

Polina Cherkasova authored May 16, 2023

Fixes https://github.com/flutter/flutter/issues/126259

Updated pubspec:
https://github.com/flutter/flutter/blob/345f0bffbfda31fab7d4a740f65b3d1610d20a99/packages/flutter/pubspec.yaml

ea5eddb5

Minor documentation fixes (#126609) · 2919572f
Ian Hickson authored May 16, 2023
```
Fixes for grammar, tone, and clarity.
```
2919572f

Roll Flutter Engine from 027ca797985f to c4d4b40c6596 (6 revisions) (#126894) · 6b6c4bdb

engine-flutter-autoroll authored May 16, 2023

https://github.com/flutter/engine/compare/027ca797985f...c4d4b40c6596

2023-05-15 ychris@google.com Fix upload xcresult script in run_tests.py (flutter/engine#42056)
2023-05-15 jonahwilliams@google.com [Impeller] set stencil attachment descriptor for runtime effect. (flutter/engine#42054)
2023-05-15 skia-flutter-autoroll@skia.org Roll Skia from 4becb53e3c21 to 24bebce2d9a1 (20 revisions) (flutter/engine#42058)
2023-05-15 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from EweLgJoiYUDok2vyU... to 38Oyy28qgYCdt7fEV... (flutter/engine#42057)
2023-05-15 bdero@google.com [Impeller] Remove debug print statement from EntityPass (flutter/engine#42055)
2023-05-15 jacksongardner@google.com Compile skwasm at -Oz. (flutter/engine#42002)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from EweLgJoiYUDo to 38Oyy28qgYCd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6b6c4bdb

15 May, 2023 20 commits

Adds drawn image wide gamut test (#126715) · 63800755

gaaclarke authored May 15, 2023

integration test for https://github.com/flutter/engine/pull/41994
issue https://github.com/flutter/flutter/issues/126620

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

63800755

Change testowners for deferred_components_test and android_views (#126872) · cec4f9c0

gmackall authored May 15, 2023

Changing to make @gmackall the owner of these tests. 

@reidbaker or @camsim99 let me know if either of you would prefer to take over, but I see both of you are already owners of some of these tests and I'm happy to take these ones on (I've already spent a little time looking into how they work for the ongoing debug signing key flake).

cec4f9c0

Roll Flutter Engine from 00f20fbab038 to 027ca797985f (5 revisions) (#126876) · 87b2ac5c

engine-flutter-autoroll authored May 15, 2023

https://github.com/flutter/engine/compare/00f20fbab038...027ca797985f

2023-05-15 godofredoc@google.com Use release_build and os dimension consistently. (flutter/engine#42012)
2023-05-15 bdero@google.com [Impeller] Add interactive DrawPaint blend test (flutter/engine#42031)
2023-05-15 bdero@google.com [Impeller] Limit subpass textures and backdrop blurs to the current clip (flutter/engine#42039)
2023-05-15 skia-flutter-autoroll@skia.org Roll Dart SDK from c302a0252785 to d2b2ac829842 (1 revision) (flutter/engine#42051)
2023-05-15 ychris@google.com Upload xcresults to LUCI cloud storage (flutter/engine#41647)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

87b2ac5c

Add ScrollController.onAttach & onDetach, samples/docs on listening/getting... · 27caa7fe

Kate Lovett authored May 15, 2023

Add ScrollController.onAttach & onDetach, samples/docs on listening/getting scrolling info (#124823)

This PR does a couple of things!

https://user-images.githubusercontent.com/16964204/231897483-416287f9-50ce-468d-a714-2a4bc0f2e011.mov

![Screenshot 2023-04-13 at 3 24 28 PM](https://user-images.githubusercontent.com/16964204/231897497-f5bee17d-43ed-46e5-acd7-e1bd64768274.png)

Fixes #20819 
Fixes #41910 
Fixes #121419

### Adds ScrollController.onAttach and ScrollController.onDetach

This resolves a long held pain point for developers. When using a scroll controller, there is not scroll position until the scrollable widget is built, and almost all methods of notification are only triggered when scrolling happens. Adding these two methods will help developers gain access to the scroll position when it is created. A common workaround for this was using a post frame callback to access controller.position after the first frame, but this is ripe for issues such as having multiple positions attached to the controller, or the scrollable no longer existing after that post frame callback. I think this can also be helpful for folks to debug cases when the scroll controller has multiple positions attached.

In particular, this also resolves this commented case: https://github.com/flutter/flutter/issues/20819#issuecomment-417784218
The isScrollingNotifier is hard for developers to access.

### Docs & samples

I was surprised we did not have samples on scroll notification or scroll controller, so I overhauled it and added a lot of docs on all the different ways to access scrolling information, when it is available and how they differ.

27caa7fe

Roll Flutter Engine from dffc480a2bbf to 00f20fbab038 (1 revision) (#126871) · dda7d28d

engine-flutter-autoroll authored May 15, 2023

https://github.com/flutter/engine/compare/dffc480a2bbf...00f20fbab038

2023-05-15 30870216+gaaclarke@users.noreply.github.com Include SkRect in rtree. (flutter/engine#42050)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

dda7d28d

Add more to error message of RestorationScope.of (#126444) · 76a9f683
Kate Lovett authored May 15, 2023
```
Fixes https://github.com/flutter/flutter/issues/126443
```
76a9f683
[devicelab] add drawPoints benchmark (#126728) · 41abe998
Jonah Williams authored May 15, 2023
```
Add a benchmark that measures the improvements from https://github.com/flutter/engine/pull/41803
```
41abe998
Remove obsolete iOS benchmark (#126862) · 674b1ad0
Zachary Anderson authored May 15, 2023
```
Fixes https://github.com/flutter/flutter/issues/126861
```
674b1ad0

Roll Packages from 6328cfbd2a46 to 6608b604b0e7 (22 revisions) (#126865) · 96580f50

engine-flutter-autoroll authored May 15, 2023

https://github.com/flutter/packages/compare/6328cfbd2a46...6608b604b0e7

2023-05-15 stuartmorgan@google.com [ci] Remove unnecessary Linux libraries (flutter/packages#3975)
2023-05-15 stuartmorgan@google.com [ci] Enforce a minimum Kotlin version in examples (flutter/packages#3979)
2023-05-15 stuartmorgan@google.com [ci] Disable Windows repo tool tests (flutter/packages#3980)
2023-05-12 stuartmorgan@google.com [ci] Add LUCI repo tool tests (flutter/packages#3964)
2023-05-12 reidbaker@google.com [url_launcher] Set broadcast reciever visability as required by target api 34 (flutter/packages#3973)
2023-05-12 reidbaker@google.com Update build.gradle with a comment explaining version (flutter/packages#3972)
2023-05-12 engine-flutter-autoroll@skia.org Roll Flutter from 8c5a1ea7 to a76dbe44 (12 revisions) (flutter/packages#3958)
2023-05-12 stuartmorgan@google.com [image_picker] Fix Android lints (flutter/packages#3887)
2023-05-12 stuartmorgan@google.com [various] Update minimum Flutter version to 3.3 (flutter/packages#3967)
2023-05-12 stuartmorgan@google.com [tool] Target specific Android unit tests (flutter/packages#3955)
2023-05-12 34871572+gmackall@users.noreply.github.com [camerax] Add a dependency on kotlin-bom to align versions of kotlin-stdlib (flutter/packages#3960)
2023-05-12 stuartmorgan@google.com [local_auth] Improve iOS test DI (flutter/packages#3959)
2023-05-12 stuartmorgan@google.com [ci] Ensure scripts fail if a command fails (flutter/packages#3963)
2023-05-11 stuartmorgan@google.com [ci] Pin the Flutter version for `release` (flutter/packages#3965)
2023-05-11 tarrinneal@gmail.com [video_player] foundation - reduce seek accuracy to fix seek to end bug (flutter/packages#3784)
2023-05-11 stuartmorgan@google.com [image_picker] Fix use_build_context_synchronously violations (flutter/packages#3969)
2023-05-11 stuartmorgan@google.com [tool] Ensure that publish credential path is available (flutter/packages#3970)
2023-05-11 63286031+ahmednfwela@users.noreply.github.com [go_router] change `fix_data.yaml` uris to be absolute to fix lints (flutter/packages#3877)
2023-05-11 stuartmorgan@google.com [tool] Use new pub cache location for publish (flutter/packages#3962)
2023-05-10 engine-flutter-autoroll@skia.org Roll Flutter (stable) from f72efea43c30 to 84a1e904f44f (1920 revisions) (flutter/packages#3961)
2023-05-10 andrelvsousa@gmail.com [image_picker_android] Improved Bitmap resize on Android (flutter/packages#3423)
2023-05-10 43054281+camsim99@users.noreply.github.com [camerax] Add Kotlin duplicate classes known error to README.md (flutter/packages#3957)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

96580f50

Roll Flutter Engine from f074fd3b2d7f to dffc480a2bbf (2 revisions) (#126863) · 0526e940

engine-flutter-autoroll authored May 15, 2023

https://github.com/flutter/engine/compare/f074fd3b2d7f...dffc480a2bbf

2023-05-15 30870216+gaaclarke@users.noreply.github.com [Impeller] switches the wide gamut surface to f16 (flutter/engine#41994)
2023-05-15 kjlubick@users.noreply.github.com Migrate uses of SkSurface factories (flutter/engine#41978)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0526e940

Mark no longer flakey tests as bringup:false (#126281) · 159ebf73

Reid Baker authored May 15, 2023

This is a result of auditing the ci.yaml tests marked as bringup true and determining which ones were still flakey. 
Each commit markes one tests as non flakey along with a link of proof of the lack of flakes. 

- Mark new_gallery_impeller__transition_perf as not flakey, #124699 closed, not recent flakes
- No failures in 500 runs for Staging_build_linux analyze https://ci.chromium.org/p/flutter/builders/staging/Staging_build_linux%20analyze\?cursor\=id%3E8782771663962116337\&limit\=200
- No flakes in 600 builds https://ci.chromium.org/p/flutter/builders/staging/Linux%20flutter_packaging_test\?cursor\=id%3E8787892377160059793\&limit\=200
- No flakes in 600 builds https://ci.chromium.org/p/flutter/builders/staging/Mac%20flutter_packaging_test\?cursor\=id%3E8787870631931126673\&limit\=200
- No flakes in 600 builds https://ci.chromium.org/p/flutter/builders/staging/Mac_arm64%20flutter_packaging_test\?cursor\=id%3E8787809799161254193\&limit\=200

#124699 is the only closed bug that was linked for a test that is no longer flakey. Closed status helps the case that flakes are no longer an issue.

159ebf73

Revert "i125138 abstract method smoke agp update (#125139)" (#126274) · c5b31e7f

Reid Baker authored May 15, 2023

This reverts commit 64591356.

#125331 
https://ci.chromium.org/p/flutter/builders/staging/Linux%20firebase_abstract_method_smoke_test?cursor=id%3E8783275059678311409&limit=200

- [ x I signed the [CLA].

c5b31e7f

Remove duplicate plugin tests (#126582) · d3c3dde1

stuartmorgan authored May 15, 2023

Removes two plugin tests that aren't actually doing anything useful.

When they were added they were testing v2-embedding plugins in a v1-embedding app, but support for creating v1-embedding apps--and the environment variable that these tests were using to, in theory, trigger them--was removed several years ago in #61203. That means that these tests are in practice exact duplicates of the copies just above without the ennvironment variables.

Fixes https://github.com/flutter/flutter/issues/122200

d3c3dde1

Add debugging for Dart VM timeout flake (#126437) · 5d113256

Victoria Ashworth authored May 15, 2023

Check what is available in the device's iOS DeviceSupport folder to check if symbols were properly fetched. Also, add some logging to track what status the debugger is in.

Debugging for https://github.com/flutter/flutter/issues/121231.

5d113256

Roll Flutter Engine from 7bd748207171 to f074fd3b2d7f (2 revisions) (#126852) · 0636f5e0

engine-flutter-autoroll authored May 15, 2023

https://github.com/flutter/engine/compare/7bd748207171...f074fd3b2d7f

2023-05-15 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from A3thcPNgxVcKzR-da... to JCoP2Fekj3MBIqskE... (flutter/engine#42041)
2023-05-15 skia-flutter-autoroll@skia.org Roll Dart SDK from c777d54743e1 to c302a0252785 (1 revision) (flutter/engine#42040)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from A3thcPNgxVcK to JCoP2Fekj3MB

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0636f5e0

Adds support for f16 surfaces to wide gamut unit tests. (#126712) · 658a1a25

gaaclarke authored May 15, 2023

issue: https://github.com/flutter/flutter/issues/126620

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

658a1a25

rename AssetManifest.bin (#126077) · d3e0e03e

Andrew Kolos authored May 15, 2023

Fixes #124883. Will require a g3fix.

Renames `AssetManifest.bin` to `AssetManifest.smcbin` (madeup extension for "Standard Message Codec binary").

d3e0e03e

Roll Flutter Engine from d6855205df29 to 7bd748207171 (8 revisions) (#126819) · fae99c5a

engine-flutter-autoroll authored May 15, 2023

https://github.com/flutter/engine/compare/d6855205df29...7bd748207171

2023-05-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 7d6324d5488b to c777d54743e1 (1 revision) (flutter/engine#42038)
2023-05-15 bdero@google.com [Impeller] Fix DrawPaint advanced blends on iOS. (flutter/engine#42032)
2023-05-15 49699333+dependabot[bot]@users.noreply.github.com Bump google/mirror-branch-action from 1.0 to 2.0 (flutter/engine#42037)
2023-05-15 skia-flutter-autoroll@skia.org Roll Skia from 0c2083a60b66 to 4becb53e3c21 (2 revisions) (flutter/engine#42036)
2023-05-15 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from jXrn0SP_MnSmhkz_P... to EweLgJoiYUDok2vyU... (flutter/engine#42035)
2023-05-15 skia-flutter-autoroll@skia.org Roll Skia from 0410e5d9ec03 to 0c2083a60b66 (1 revision) (flutter/engine#42034)
2023-05-15 chillers@google.com [Impeller] Include AndroidSurfaceVulkanImpeller behind a flag (flutter/engine#42033)
2023-05-15 chillers@google.com Reland "Remove GN staging flag for save layer bounds" (flutter/engine#42029)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from jXrn0SP_MnSm to EweLgJoiYUDo

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fae99c5a

Add spaces after flow control statements (#126320) · 99c7e9f0
Tomasz Gucio authored May 15, 2023

99c7e9f0

Roll Flutter Engine from 326de1d849dd to d6855205df29 (1 revision) (#126794) · 231e00d2

engine-flutter-autoroll authored May 15, 2023

https://github.com/flutter/engine/compare/326de1d849dd...d6855205df29

2023-05-15 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from qnNU5eQaox06ejpSE... to A3thcPNgxVcKzR-da... (flutter/engine#42030)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from qnNU5eQaox06 to A3thcPNgxVcK

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

231e00d2