Commits · 62cf7cfabde87d876a96aa629645e4fceced16ac · abdullh.alsoleman / Front-End

29 Feb, 2024 10 commits

Roll Flutter Engine from 232217f39c3c to d068d980f952 (1 revision) (#144369) · 62cf7cfa

engine-flutter-autoroll authored Feb 29, 2024

https://github.com/flutter/engine/compare/232217f39c3c...d068d980f952

2024-02-29 skia-flutter-autoroll@skia.org Roll Skia from f0a60bfe98e0 to ef2511b0a6f2 (2 revisions) (flutter/engine#51075)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

62cf7cfa

Roll Flutter Engine from 9e1876141be8 to 232217f39c3c (1 revision) (#144366) · 2ccf375c

engine-flutter-autoroll authored Feb 29, 2024

https://github.com/flutter/engine/compare/9e1876141be8...232217f39c3c

2024-02-29 robert.ancell@canonical.com Update Linux embedder to latest semantics API (flutter/engine#51030)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2ccf375c

Roll Flutter Engine from 61510db94a1c to 9e1876141be8 (1 revision) (#144362) · 71bb9125

engine-flutter-autoroll authored Feb 29, 2024

https://github.com/flutter/engine/compare/61510db94a1c...9e1876141be8

2024-02-29 jonahwilliams@google.com [Impeller] switch fallback default from ImpellerVulkan to SkiaOpenGLES (flutter/engine#51071)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

71bb9125

Roll Flutter Engine from 10331db8f748 to 61510db94a1c (5 revisions) (#144355) · 52d45c41

engine-flutter-autoroll authored Feb 29, 2024

https://github.com/flutter/engine/compare/10331db8f748...61510db94a1c

2024-02-28 skia-flutter-autoroll@skia.org Roll Skia from 27171d6a9205 to f0a60bfe98e0 (4 revisions) (flutter/engine#51068)
2024-02-28 chillers@google.com Prefix flutter in flutter_vma.h import (flutter/engine#51065)
2024-02-28 jonahwilliams@google.com [Impeller] Cache entire render target and not just allocations. (flutter/engine#50990)
2024-02-28 matanlurey@users.noreply.github.com Test the `SurfaceTextureSurfaceProducer`-branch in the Android `scenario_app` (flutter/engine#51061)
2024-02-28 jacksongardner@google.com Revert "[skwasm] Clip pictures if they go beyond the bounds of the window. (#50887)" (flutter/engine#51067)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

52d45c41

Docs on the interaction between Shortcuts and text input (#144328) · ac66b295

Justin McCandless authored Feb 29, 2024

I was talking with @tvolkert about the complex behavior of Shortcuts when a text field is focused.  I created [this dartpad](https://dartpad.dev/?id=0b5c08fa85637422baa84927b7f1ee5f) to illustrate the problem, which shows a key being stolen from a text field by Shortcuts, and how to prevent that using DoNothingAndStopPropagationIntent.

This PR adds a section in the docs explaining how all of this works and how to override this "stealing" problem.

ac66b295

Use robolectric/AndroidJUnit4 for integration test tests (#144348) · 835112de

Dan Field authored Feb 29, 2024

This allows relanding https://github.com/flutter/engine/pull/51056. The patch introduced a change where a static member is initialized from `View.generateViewId()` instead of conditionally using that API. Without an implementation for that in android.jar, the test will fail. The test in here currently is using a fake implementation that creates errors seen below.

See https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8754827734484522225/+/u/run_plugin_test/stdout#L46564_2 for failure. More detailed failure information is available locally in the `build` folder:

```
Mockito cannot mock this class: class io.flutter.embedding.android.FlutterActivity.

If you're not sure why you're getting this error, please open an issue on GitHub.

Java : 17
JVM vendor name : JetBrains s.r.o.
JVM vendor version : 17.0.7+0-17.0.7b1000.6-10550314
JVM name : OpenJDK 64-Bit Server VM
JVM version : 17.0.7+0-17.0.7b1000.6-10550314
JVM info : mixed mode
OS name : Mac OS X
OS version : 14.3.1

You are seeing this disclaimer because Mockito is configured to create inlined mocks.
You can learn about inline mocks and their limitations under item #39 of the Mockito class javadoc.

Underlying exception : org.mockito.exceptions.base.MockitoException: Cannot instrument class io.flutter.embedding.android.FlutterActivity because it or one of its supertypes could not be initialized
at app//dev.flutter.plugins.integration_test.FlutterDeviceScreenshotTest.getFlutterView_returnsFlutterViewForFlutterActivity(FlutterDeviceScreenshotTest.java:32)
at java.base@17.0.7/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base@17.0.7/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at java.base@17.0.7/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.base@17.0.7/java.lang.reflect.Method.invoke(Unknown Source)
at app//org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at app//org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at app//org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at app//org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at app//org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at app//org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at app//org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at app//org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at app//org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at app//org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at app//org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at app//org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at app//org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at app//org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at app//org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at app//org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.runTestClass(JUnitTestClassExecutor.java:110)
at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:58)
at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:38)
at org.gradle.api.internal.tasks.testing.junit.AbstractJUnitTestClassProcessor.processTestClass(AbstractJUnitTestClassProcessor.java:62)
at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
at java.base@17.0.7/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base@17.0.7/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at java.base@17.0.7/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.base@17.0.7/java.lang.reflect.Method.invoke(Unknown Source)
at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36)
at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:33)
at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:94)
at jdk.proxy1/jdk.proxy1.$Proxy2.processTestClass(Unknown Source)
at org.gradle.api.internal.tasks.testing.worker.TestWorker$2.run(TestWorker.java:176)
at org.gradle.api.internal.tasks.testing.worker.TestWorker.executeAndMaintainThreadName(TestWorker.java:129)
at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:100)
at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:60)
at org.gradle.process.internal.worker.child.ActionExecutionWorker.execute(ActionExecutionWorker.java:56)
at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:133)
at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:71)
at app//worker.org.gradle.process.internal.worker.GradleWorkerMain.run(GradleWorkerMain.java:69)
at app//worker.org.gradle.process.internal.worker.GradleWorkerMain.main(GradleWorkerMain.java:74)
Caused by: org.mockito.exceptions.base.MockitoException: Cannot instrument class io.flutter.embedding.android.FlutterActivity because it or one of its supertypes could not be initialized
at app//net.bytebuddy.TypeCache.findOrInsert(TypeCache.java:168)
at app//net.bytebuddy.TypeCache$WithInlineExpunction.findOrInsert(TypeCache.java:399)
at app//net.bytebuddy.TypeCache.findOrInsert(TypeCache.java:190)
at app//net.bytebuddy.TypeCache$WithInlineExpunction.findOrInsert(TypeCache.java:410)
... 44 more
Caused by: java.lang.RuntimeException: Method generateViewId in android.view.View not mocked. See http://g.co/androidstudio/not-mocked for details.
at android.view.View.generateViewId(View.java)
at io.flutter.embedding.android.FlutterActivity.<clinit>(FlutterActivity.java:218)
at java.base/java.lang.Class.forName0(Native Method)
at java.base/java.lang.Class.forName(Unknown Source)
at org.mockito.internal.creation.bytebuddy.InlineBytecodeGenerator.assureInitialization(InlineBytecodeGenerator.java:236)
at org.mockito.internal.creation.bytebuddy.InlineBytecodeGenerator.triggerRetransformation(InlineBytecodeGenerator.java:261)
at org.mockito.internal.creation.bytebuddy.InlineBytecodeGenerator.mockClass(InlineBytecodeGenerator.java:218)
at org.mockito.internal.creation.bytebuddy.TypeCachingBytecodeGenerator.lambda$mockClass$0(TypeCachingBytecodeGenerator.java:47)
at net.bytebuddy.TypeCache.findOrInsert(TypeCache.java:168)
at net.bytebuddy.TypeCache$WithInlineExpunction.findOrInsert(TypeCache.java:399)
at net.bytebuddy.TypeCache.findOrInsert(TypeCache.java:190)
at net.bytebuddy.TypeCache$WithInlineExpunction.findOrInsert(TypeCache.java:410)
at org.mockito.internal.creation.bytebuddy.TypeCachingBytecodeGenerator.mockClass(TypeCachingBytecodeGenerator.java:40)
at org.mockito.internal.creation.bytebuddy.InlineDelegateByteBuddyMockMaker.createMockType(InlineDelegateByteBuddyMockMaker.java:396)
at org.mockito.internal.creation.bytebuddy.InlineDelegateByteBuddyMockMaker.doCreateMock(InlineDelegateByteBuddyMockMaker.java:355)
at org.mockito.internal.creation.bytebuddy.InlineDelegateByteBuddyMockMaker.createMock(InlineDelegateByteBuddyMockMaker.java:334)
at org.mockito.internal.creation.bytebuddy.InlineByteBuddyMockMaker.createMock(InlineByteBuddyMockMaker.java:56)
at org.mockito.internal.util.MockUtil.createMock(MockUtil.java:99)
at org.mockito.internal.MockitoCore.mock(MockitoCore.java:88)
at org.mockito.Mockito.mock(Mockito.java:2087)
at org.mockito.Mockito.mock(Mockito.java:2002)
... 44 more
```

835112de

Reland "Cache FocusNode.enclosingScope, clean up descendantsAreFocusable (#144207)" (#144330) · dddbd047

LongCatIsLooong authored Feb 29, 2024

The [internal test failure](https://github.com/flutter/flutter/pull/144207#issuecomment-1968236339) was caused by `Focus.withExternalFocusNode` modifying the external node's attributes. The extra changes are in this commit:  https://github.com/flutter/flutter/commit/e53d98b06c6e2ae65271681c4b40b28b2d02ad04

CL with (almost) passing TGP: cl/611157582

dddbd047

Roll Flutter Engine from 455c814fe5de to 10331db8f748 (7 revisions) (#144345) · 7f65c9ef

engine-flutter-autoroll authored Feb 29, 2024

https://github.com/flutter/engine/compare/455c814fe5de...10331db8f748

2024-02-28 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from T1xAi_ww_mWEiDkVN... to ujOkbeYbrC8loPbfR... (flutter/engine#51066)
2024-02-28 chris@bracken.jp Roll abseil-cpp to 1db3bdd4eb208bef55c77f22aa94991e52225230 (flutter/engine#51062)
2024-02-28 skia-flutter-autoroll@skia.org Roll Dart SDK from 7896a944fe67 to fdf4a62bd07b (1 revision) (flutter/engine#51064)
2024-02-28 jason-simmons@users.noreply.github.com [Impeller] Mark subpass framebuffer fetch tests as unsupported on GLES (flutter/engine#50982)
2024-02-28 skia-flutter-autoroll@skia.org Roll Skia from 93f245da0097 to 27171d6a9205 (1 revision) (flutter/engine#51063)
2024-02-28 jonahwilliams@google.com [Impeller] fix render pass depth descriptor. (flutter/engine#51031)
2024-02-28 flar@google.com Make Skia object ostream operators work with unit tests (flutter/engine#51041)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from T1xAi_ww_mWE to ujOkbeYbrC8l

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7f65c9ef

ReportTiming callback should record the sendFrameToEngine when it was scheduled (#144212) · e3160222
Tong Mu authored Feb 29, 2024
```
Fixes https://github.com/flutter/flutter/issues/144261
```
e3160222

Disable flaky golden file test (#144351) · a185ff90

Kate Lovett authored Feb 29, 2024

Filed https://github.com/flutter/flutter/issues/144350 for follow up.
This test has become flaky and is breaking the tree.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes

a185ff90

28 Feb, 2024 20 commits

Mention SelectionArea in SelectableText docs (#143784) · e6a6a473

Justin McCandless authored Feb 28, 2024

Most users should be using SelectionArea over SelectableText, so this makes that more clear/discoverable in the docs.

e6a6a473

Bump peter-evans/create-pull-request from 6.0.0 to 6.0.1 (#144344) · 3095c116

dependabot[bot] authored Feb 28, 2024

Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 6.0.0 to 6.0.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/peter-evans/create-pull-request/releases">peter-evans/create-pull-request's releases</a>.</em></p>
<blockquote>
<h2>Create Pull Request v6.0.1</h2>
<p>âï¸ Fixes <a href="https://redirect.github.com/peter-evans/create-pull-request/issues/2790">an issue</a> where updating a pull request leads to the error <code>Cannot read properties of undefined (reading 'number')</code>. This was likely caused by GitHub fixing a long standing bug with an API endpoint, resulting in a breaking change.</p>
<h2>What's Changed</h2>
<ul>
<li>build(deps-dev): bump <code>@âtypes/jest</code> from 29.5.11 to 29.5.12 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2730">peter-evans/create-pull-request#2730</a></li>
<li>build(deps-dev): bump prettier from 3.2.4 to 3.2.5 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2731">peter-evans/create-pull-request#2731</a></li>
<li>build(deps-dev): bump <code>@âtypes/node</code> from 18.19.10 to 18.19.14 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2732">peter-evans/create-pull-request#2732</a></li>
<li>build(deps): bump peter-evans/slash-command-dispatch from 3 to 4 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2748">peter-evans/create-pull-request#2748</a></li>
<li>build(deps): bump peter-evans/create-pull-request from 5 to 6 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2747">peter-evans/create-pull-request#2747</a></li>
<li>build(deps-dev): bump <code>@âtypes/node</code> from 18.19.14 to 18.19.15 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2759">peter-evans/create-pull-request#2759</a></li>
<li>build(deps-dev): bump eslint-plugin-jest from 27.6.3 to 27.9.0 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2769">peter-evans/create-pull-request#2769</a></li>
<li>build(deps-dev): bump <code>@âtypes/node</code> from 18.19.15 to 18.19.17 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2768">peter-evans/create-pull-request#2768</a></li>
<li>build(deps-dev): bump <code>@âtypes/node</code> from 18.19.17 to 18.19.18 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2780">peter-evans/create-pull-request#2780</a></li>
<li>build(deps-dev): bump eslint from 8.56.0 to 8.57.0 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2781">peter-evans/create-pull-request#2781</a></li>
<li>fix: list pulls using the correct head format by <a href="https://github.com/peter-evans"><code>@âpeter-evans</code></a> in <a href="https://redirect.github.com/peter-evans/create-pull-request/pull/2792">peter-evans/create-pull-request#2792</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/peter-evans/create-pull-request/compare/v6.0.0...v6.0.1">https://github.com/peter-evans/create-pull-request/compare/v6.0.0...v6.0.1</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/peter-evans/create-pull-request/commit/a4f52f8033a6168103c2538976c07b467e8163bc"><code>a4f52f8</code></a> fix: list pulls using the correct head format (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/2792">#2792</a>)</li>
<li><a href="https://github.com/peter-evans/create-pull-request/commit/853c071bcf61c8762f57e59c1576d97418f495ad"><code>853c071</code></a> build(deps-dev): bump eslint from 8.56.0 to 8.57.0 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/2781">#2781</a>)</li>
<li><a href="https://github.com/peter-evans/create-pull-request/commit/d2c126edc79e6a215930e9a6adc95b7686b84f78"><code>d2c126e</code></a> build(deps-dev): bump <code>@âtypes/node</code> from 18.19.17 to 18.19.18 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/2780">#2780</a>)</li>
<li><a href="https://github.com/peter-evans/create-pull-request/commit/43d39c683601267cd565ea6bd727a4e92aa00852"><code>43d39c6</code></a> build(deps-dev): bump <code>@âtypes/node</code> from 18.19.15 to 18.19.17 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/2768">#2768</a>)</li>
<li><a href="https://github.com/peter-evans/create-pull-request/commit/5a9d206da2b6452cd63eb84e2e5116ff3213e8cb"><code>5a9d206</code></a> build(deps-dev): bump eslint-plugin-jest from 27.6.3 to 27.9.0 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/2769">#2769</a>)</li>
<li><a href="https://github.com/peter-evans/create-pull-request/commit/e0743ed96cb63913cf4be3cd1f5492df2ae1c6a4"><code>e0743ed</code></a> build(deps-dev): bump <code>@âtypes/node</code> from 18.19.14 to 18.19.15 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/2759">#2759</a>)</li>
<li><a href="https://github.com/peter-evans/create-pull-request/commit/e1529cb8abb50dd7240e4276b5c4e705d97be7e7"><code>e1529cb</code></a> build(deps): bump peter-evans/create-pull-request from 5 to 6 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/2747">#2747</a>)</li>
<li><a href="https://github.com/peter-evans/create-pull-request/commit/aad52e87e709ba797765001128cf194c946a457b"><code>aad52e8</code></a> build(deps): bump peter-evans/slash-command-dispatch from 3 to 4 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/2748">#2748</a>)</li>
<li><a href="https://github.com/peter-evans/create-pull-request/commit/a64ebdd73452502a4dd07379ce8f3640dcc0d987"><code>a64ebdd</code></a> build(deps-dev): bump <code>@âtypes/node</code> from 18.19.10 to 18.19.14 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/2732">#2732</a>)</li>
<li><a href="https://github.com/peter-evans/create-pull-request/commit/51b40aff5f23f35e5211017631b0bc1d2746beab"><code>51b40af</code></a> build(deps-dev): bump prettier from 3.2.4 to 3.2.5 (<a href="https://redirect.github.com/peter-evans/create-pull-request/issues/2731">#2731</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/peter-evans/create-pull-request/compare/b1ddad2c994a25fbc81a28b3ec0e368bb2021c50...a4f52f8033a6168103c2538976c07b467e8163bc">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=peter-evans/create-pull-request&package-manager=github_actions&previous-version=6.0.0&new-version=6.0.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

3095c116

Reland "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2" (#144273) · 0d8eafb0
Qun Cheng authored Feb 28, 2024

0d8eafb0

Remove irrelevant comment in TextPainter (#144308) · 88f75712

Tomasz Gucio authored Feb 28, 2024

This PR removes an irrelevant comment in `TextPainter` for `_computePaintOffsetFraction`. Also some typos are corrected and missing spaces/newlines added.

test-exempt: no functional change

88f75712

Roll Flutter Engine from c9381fb8ef4c to 455c814fe5de (1 revision) (#144340) · d00bfe82

engine-flutter-autoroll authored Feb 28, 2024

https://github.com/flutter/engine/compare/c9381fb8ef4c...455c814fe5de

2024-02-28 zanderso@users.noreply.github.com Revert to goma on mac_clang_tidy builder (flutter/engine#51060)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d00bfe82

Roll Flutter Engine from 91898e397261 to c9381fb8ef4c (11 revisions) (#144338) · 82034b9a

engine-flutter-autoroll authored Feb 28, 2024

https://github.com/flutter/engine/compare/91898e397261...c9381fb8ef4c

2024-02-28 dnfield@google.com Revert "Bump everything to Android 21" (flutter/engine#51056)
2024-02-28 skia-flutter-autoroll@skia.org Roll Skia from 0c294ee206e8 to 93f245da0097 (2 revisions) (flutter/engine#51055)
2024-02-28 jonahwilliams@google.com [Android] update fallback and rendering state to combine impeller + android backend. (flutter/engine#51008)
2024-02-28 bdero@google.com [Impeller] Fix GL depth state. (flutter/engine#51040)
2024-02-28 chris@bracken.jp Roll buildroot to 7b537de78ac2239982ace130d1845374e5dcf113 (flutter/engine#51053)
2024-02-28 skia-flutter-autoroll@skia.org Roll Skia from d935943bedcd to 0c294ee206e8 (3 revisions) (flutter/engine#51051)
2024-02-28 zanderso@users.noreply.github.com When run_tests.py is in --quiet mode, write verbose logs to a file (flutter/engine#51029)
2024-02-28 skia-flutter-autoroll@skia.org Roll Skia from fe34002ee826 to d935943bedcd (1 revision) (flutter/engine#51049)
2024-02-28 dnfield@google.com Bump everything to Android 21 (flutter/engine#51032)
2024-02-28 jiahaog@users.noreply.github.com Add flutter prefix to import (flutter/engine#51042)
2024-02-28 skia-flutter-autoroll@skia.org Roll Skia from d591703635b0 to fe34002ee826 (1 revision) (flutter/engine#51048)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

82034b9a

Reland "Add FlutterMacOS.xcframework artifact (#143244)" (#144275) · 39a13539

Victoria Ashworth authored Feb 28, 2024

Reland https://github.com/flutter/flutter/pull/143244. It was reverted due to https://github.com/flutter/flutter/issues/144251, which is fixed by https://github.com/flutter/engine/pull/51023.

39a13539

[flutter_tools] Catch rpc error in render frame with raster stats (#144190) · f89b4f15

Christopher Fujino authored Feb 28, 2024

Fixes https://github.com/flutter/flutter/issues/143010. This is intended to be cherrypicked into the 3.19 and 3.20 releases.

Long-term, we should deprecate this feature: https://github.com/flutter/flutter/issues/144191

f89b4f15

🛡

️ Guard Flutter Android app by disallow task affinity by default (#144018) · 47b0ef81

Alex Li authored Feb 28, 2024

Partial resolution for #63559

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes

47b0ef81

Manual roll Flutter Engine 8acc96d405d0 to 91898e397261 (#144316) · d6758070

Zachary Anderson authored Feb 28, 2024

91898e3972 Process FlutterMacOS.framework before creating xcframework
(https://github.com/flutter/engine/pull/51023)
c873ade1f1 Roll Skia from a55a65d65378 to d591703635b0 (1 revision)
(https://github.com/flutter/engine/pull/51046)
3feed45f0b Roll Skia from cce35b54379c to a55a65d65378 (3 revisions)
(https://github.com/flutter/engine/pull/51045)
886ff23042 Roll Dart SDK from 44af84628b90 to 7896a944fe67 (1 revision)
(https://github.com/flutter/engine/pull/51043)
fa691b8cee Roll Skia from a673ab63fccc to cce35b54379c (3 revisions)
(https://github.com/flutter/engine/pull/51036)

d6758070

Manual roll Flutter Engine 64a375de9c8f to 8acc96d405d0 (#144296) · 82ffde7d

Zachary Anderson authored Feb 28, 2024

8acc96d405 Roll Dart SDK from 1e6b559fae88 to 44af84628b90 (1 revision) (https://github.com/flutter/engine/pull/51035)
632f9d742d Roll Skia from 84c60d70fbbd to a673ab63fccc (1 revision) (https://github.com/flutter/engine/pull/51034)
5c09604bd6 Null-assert the value given to a Completer expecting a non-null value (https://github.com/flutter/engine/pull/49053)
055ede728c Roll Dart SDK from a0e3c16eea3e to 1e6b559fae88 (1 revision) (https://github.com/flutter/engine/pull/51025)
d6bca2a382 [Windows] Reduce log level of unsupported accessibility event message (https://github.com/flutter/engine/pull/51024)
8fa1141b46 Roll Skia from c8703c91675e to 84c60d70fbbd (4 revisions) (https://github.com/flutter/engine/pull/51021)

82ffde7d

Manual roll Flutter Engine c79117b706e9 to 64a375de9c8f (#144293) · 95fdcbb8

Zachary Anderson authored Feb 28, 2024

64a375de9c [Windows] Make the engine own a map of views (https://github.com/flutter/engine/pull/51017)
73480bf11d Rename some classes in the engine_build_configs package (https://github.com/flutter/engine/pull/51016)
2756f14a46 Remove rewrapper prefix from compiler commands for clang-tidy (https://github.com/flutter/engine/pull/51001)
0f727a5b31 Improve, test, and fix a bug related to `adb logcat` filtering. (https://github.com/flutter/engine/pull/51012)
ab4d6db3f1 Move vulkan-deps to //flutter/third_party/vulkan-deps (https://github.com/flutter/engine/pull/51013)

95fdcbb8

Reverts "Cache `FocusNode.enclosingScope`, clean up `descendantsAreFocusable` (#144207)" (#144292) · 45050686

auto-submit[bot] authored Feb 28, 2024

Reverts flutter/flutter#144207

Initiated by: CaseyHillers

Reason for reverting: b/327301206 - Breaking a customer test

Original PR Author: LongCatIsLooong

Reviewed By: {gspencergoog}

This change reverts the following previous change:
Original Description:
`FocusNode.canRequestFocus` was doing a double traversal if no ancestor disallows focus. The last for loop only has to reach as far as the enclosing scope.

Also this caches the `FocusNode.enclosingScope` since the getter access happens much more frequently than node reparenting.

45050686

Manual roll Flutter Engine 2461280c38b7 to c79117b706e9 (#144290) · 96a390a9

Zachary Anderson authored Feb 28, 2024

c79117b706 [Windows] Remove TODONE (https://github.com/flutter/engine/pull/51005)
24c7b03ef0 [Windows] Introduce an accessibility plugin (https://github.com/flutter/engine/pull/50975)
c805e43957 Roll Skia from 1beae57ea0dd to c8703c91675e (1 revision) (https://github.com/flutter/engine/pull/51014)
17dff87ef3 [Impeller] various StC fixes for GPU -> CPU readback plus BufferBindingGLES error (https://github.com/flutter/engine/pull/50951)
8457d10473 Roll Dart SDK from be6be2b9ba6e to a0e3c16eea3e (3 revisions) (https://github.com/flutter/engine/pull/51015)

96a390a9

Manual roll Flutter Engine 5e0d9ba35dd5 to 2461280c38b7 (#144288) · fa322eb2

Zachary Anderson authored Feb 28, 2024

2461280c38 Roll Fuchsia Linux SDK from JCdhkDSFXzHyPuP4I... to T1xAi_ww_mWEiDkVN... (https://github.com/flutter/engine/pull/51011)
8940ea0887 Code consistency fixes in FlScrollingManager (https://github.com/flutter/engine/pull/50959)
21474ee4a4 [macOS] Use CVDisplayLink to drive repaint (https://github.com/flutter/engine/pull/49159)
6f7b939568 Fail lazily when 1+ Skia gold comparions fail. (https://github.com/flutter/engine/pull/51010)
249daf5512 Adjust Android emulator test timeouts (https://github.com/flutter/engine/pull/51004)

fa322eb2

Manual roll Flutter Engine fe7ea6d9c34f to 5e0d9ba35dd5 (#144285) · 1a435d95

Zachary Anderson authored Feb 28, 2024

5e0d9ba35d Roll Skia from 636e136b0da9 to 1beae57ea0dd (3 revisions)
(https://github.com/flutter/engine/pull/51007)
63b6117514 [skwasm] Clip pictures if they go beyond the bounds of the
window. (https://github.com/flutter/engine/pull/50887)
cd57dc9b4c GLES for scenario_app tests using Impeller
(https://github.com/flutter/engine/pull/51000)
ef4c205239 Roll Skia from d5ca52bc7739 to 636e136b0da9 (8 revisions)
(https://github.com/flutter/engine/pull/51006)
8b240244ef [Fuchsia] Use shared gn-sdk from chromium
(https://github.com/flutter/engine/pull/50855)

1a435d95

Manual roll Flutter Engine 0bc21ea7bc92 to fe7ea6d9c34f (#144283) · 71fd015d

Zachary Anderson authored Feb 28, 2024

fe7ea6d9c3 Reland "Implement Frame Timing callbacks in Skwasm" (#50987)
1a5c26421b Move protobuf to //flutter/third_party (#50997)
1f9224056c Roll Skia from 2f2a718b27f7 to d5ca52bc7739 (3 revisions)
(#51003)
5403c24990 Roll Dart SDK from 67b2a250747b to be6be2b9ba6e (1 revision)
(#51002)
4addb6a07c Actually use Impeller in scenario_app tests (#50977)

71fd015d

Use const route for notAnnounced. (#144050) · 42b02d0a
Polina Cherkasova authored Feb 28, 2024

42b02d0a

Add `tabs_utils.dart` class (#143937) · 55173169

Taha Tesser authored Feb 28, 2024

This a test utility class for `tabs_test.dart` to prepare the class for Material 3 tests updates.

More info in https://github.com/flutter/flutter/issues/139076

55173169

Remove `bottomAppBarColor` from `ThemeData` (#144080) · e707f0de

Qun Cheng authored Feb 28, 2024

This PR is to remove deprecated ThemeData.bottomAppBarColor.

These parameters are made obsolete in https://github.com/flutter/flutter/pull/110162.
Part of https://github.com/flutter/flutter/pull/111080

e707f0de

27 Feb, 2024 10 commits

fix: unexpected chinese punctuation (#143678) · d0fb2929
ufolux authored Feb 27, 2024
```
*Fixed the issue with abnormal Chinese punctuation marks.*
```
d0fb2929

Clean up lint ignores (#144229) · d3b60d46

Elias Yishak authored Feb 27, 2024

Fixes:
- https://github.com/dart-lang/tools/issues/234

Bumps the version for package:unified_analytics and removes TODOs and lint ignores

d3b60d46

Reland [a11y] Add isEnabled semantics flag to text field (#143601) · fdb17ab0
hangyu authored Feb 27, 2024
```
Reland #143334
```
fdb17ab0

Remove deprecated `CupertinoContextMenu.previewBuilder` (#143990) · 2c2fed1d

LongCatIsLooong authored Feb 27, 2024

It was deprecated in https://github.com/flutter/flutter/pull/110616.

Deprecated in https://github.com/flutter/flutter/pull/110616

2c2fed1d

[iOS] Fix naming in platform_view example (#144247) · 2e4bbb75

Chris Bracken authored Feb 27, 2024

This applies minor cosmetic cleanups noticed while landing fix/tests in another patch. Renames `incrementLabel` to `countLabel` and `setIncrementLabel` to `updateCountLabel`, since it's not setting it to a specific value but rather updating itself based on the current state of the `count` ivar.

No tests since this patch introduces no semantic changes.

Related: https://github.com/flutter/flutter/pull/132028

2e4bbb75

Reverts "Reland - Introduce tone-based surfaces and accent color add-ons -... · 2eee0b57

auto-submit[bot] authored Feb 27, 2024

Reverts "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2 (#144001)" (#144262)

Reverts flutter/flutter#144001

Initiated by: Piinks

Reason for reverting: Failing goldens at the tip of tree

Original PR Author: QuncCccccc

Reviewed By: {HansMuller}

This change reverts the following previous change:
Original Description:
Reverts flutter/flutter#143973

This is a reland for #138521 with an updated g3fix(cl/605555997). Local test: cl/609608958.

2eee0b57

Reverts "Add FlutterMacOS.xcframework artifact (#143244)" (#144253) · 7f2b238c

auto-submit[bot] authored Feb 27, 2024

Reverts flutter/flutter#143244

Initiated by: vashworth

Reason for reverting: Increased `flutter_framework_uncompressed_bytes` - see https://github.com/flutter/flutter/issues/144251

Original PR Author: vashworth

Reviewed By: {jmagman}

This change reverts the following previous change:
Original Description:
Replace `FlutterMacOS.framework` cached artifact with `FlutterMacOS.xcframework`. Also, update usage of `FlutterMacOS.framework` to use `FlutterMacOS.xcframework`.

Part of https://github.com/flutter/flutter/issues/126016.

7f2b238c

[web] Make flutter web profile builds always keep wasm symbols (#144130) · 616a0260

Martin Kustermann authored Feb 27, 2024

So far `flutter build web --wasm` was always stripping wasm symbols
except if `--no-strip-wasm` is passed.

=> Ensure that in profile mode we also keep the symbols

616a0260

Reland - Introduce tone-based surfaces and accent color add-ons - Part 2 (#144001) · 871d5922
Qun Cheng authored Feb 27, 2024
```
Reverts flutter/flutter#143973

This is a reland for #138521 with an updated g3fix(cl/605555997). Local test: cl/609608958.
```
871d5922

bind missing add icon in platform_view example (#132028) · 609d30fe

Roger authored Feb 27, 2024

In the `examples/platform_view` example, which demonstrates
transitioning from a Flutter view to a general iOS UIView and back, as
well as using channels to communicate between the two, the Flutter view
renders correctly, but in the iOS UIView, the FAB equivalent button in
the lower-right corner is rendered without the '+' icon. This is because
no binding as declared for the add icon in the storyboard. This adds the
missing binding.

Further, this eliminates the use of the deprecated
[UIButtonTypeRoundedRect](https://developer.apple.com/documentation/uikit/uibuttontype/uibuttontyperoundedrect?language=objc),
falling back to the default instead.

---------
Co-authored-by: Chris Bracken <chris@bracken.jp>

609d30fe