- 29 Nov, 2023 22 commits
-
-
Greg Spencer authored
Part of https://github.com/flutter/flutter/issues/139243 ## Description This removes the `PlatformMenuBar.body` attribute and constructor parameter, since its deprecation period has elapsed. ## Tests - No tests were using the deprecated attribute, so no tests were removed. #FlutterDeprecations
-
Elias Yishak authored
Related to tracker issue: - https://github.com/flutter/flutter/issues/128251 <img width="278" alt="image" src="https://github.com/flutter/flutter/assets/42216813/cee7b9be-48d6-48e5-8c39-de28d0a1f0de"> The image above shows all of the instances where we have `sendTiming`. All of the call sites have been updated to use the new `Event.timing` event from `package:unified_analytics`.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/60b963930202...222beb28a8eb 2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from b9e2514a6fb6 to 8931060e9ab5 (1 revision) (flutter/engine#48498) 2023-11-29 34871572+gmackall@users.noreply.github.com Fix new lint from android 14 upgrade, and remove it from the baseline (flutter/engine#47817) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/eebbe7e15c7d...60b963930202 2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from ca84147b3e4e to b9e2514a6fb6 (1 revision) (flutter/engine#48497) 2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from 19fbbf73fa33 to ca84147b3e4e (1 revision) (flutter/engine#48496) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/3c054661a3a6...e4aaba833261 2023-11-28 ian@hixie.ch [rfw, flutter_markdown] Prepare for removing dart:ui imports. (flutter/packages#5471) 2023-11-28 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.9.20 to 1.9.21 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#5483) 2023-11-28 70025277+Nitin-Poojary@users.noreply.github.com [flutter image] Changed image link to use image within package (flutter/packages#5326) 2023-11-28 PROGrand@users.noreply.github.com camera_android: Camera.java pausePreview null check (flutter/packages#5265) 2023-11-28 ltv.luongthevinh@gmail.com [webview_flutter] Add listener for content offset (Platform Interface) (flutter/packages#5427) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Kate Lovett authored
This updates the implementation to use the stopwatch from the Clock object and pipes it through to the TestWidgetsFlutterBinding so it will be kept in sync with FakeAsync. Relands https://github.com/flutter/flutter/pull/138843 attempted to reland https://github.com/flutter/flutter/pull/137381 which attempted to reland #132291 Fixes https://github.com/flutter/flutter/issues/97761 1. The original change was reverted due to flakiness it introduced in tests that use fling gestures. * Using a mocked clock through the test binding fixes this now 2. It was reverted a second time because a change at tip of tree broke it, exposing memory leaks, but it was not rebased before landing. * These leaks are now fixed 3. It was reverted a third time, because we were so excellently quick to revert those other times, that we did not notice the broken benchmark that only runs in postsubmit. * The benchmark is now fixed
-
Kate Lovett authored
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/ecc9c7b6be7d...eebbe7e15c7d 2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from 89e844f3fc87 to 19fbbf73fa33 (1 revision) (flutter/engine#48494) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/28aae2d29822...ecc9c7b6be7d 2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from 8489b2c37f73 to 89e844f3fc87 (1 revision) (flutter/engine#48490) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Fré Dumazy authored
The previous documentation did not point out the difference between the default corner radius for Material 2 and Material 3. Fixes: https://github.com/flutter/flutter/issues/139093
-
Ian Hickson authored
- fix https://github.com/flutter/flutter/issues/53707 by having the test not expect a timeout but instead actually look for the retry message - simplify the `--task` option to only accept task names rather than also accepting paths - remove some obsolete options that referred to the manifest which no longer seems to exist
-
Veli Bacik authored
Before:  After:   Fixed #136164
-
Renzo Olivares authored
This change adds support for a `MaterialStatesController` in `TextField` and `TextFormField`. With this change a user can listen to `MaterialState` changes in an input field by passing a `MaterialStatesController` to `TextField` or `TextFormField`. Fixes #133273
-
Mateus Felipe C. C. Pinto authored
Provide parameter to Icon and IconThemeData for they to consider the context's text scaler (#135708) Provide a parameter `applyTextScaling` to both `Icon` and `IconDataTheme`. When `true`, the context's `TextScaler` will apply it's `scale` method to the icon size. Fixes #115466
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/be4d7c8b760c...28aae2d29822 2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from 539aba7d8539 to 8489b2c37f73 (1 revision) (flutter/engine#48489) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
LongCatIsLooong authored
Update `ButtonStyleButton.scaledPadding` documentation. Migrate callers in flutter/flutter (#139014) Fixes https://github.com/flutter/flutter/issues/138547. It makes more sense to me for the default padding values to use the scaled font sizes instead of the `textScaleFactor`.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/de99c71c598f...be4d7c8b760c 2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from fa5d6165e4d8 to 539aba7d8539 (1 revision) (flutter/engine#48486) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/9a840e8dba40...de99c71c598f 2023-11-29 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Vqcs_2rbtDfbmu3WX... to 8wu5EgBh1yJPNOd5W... (flutter/engine#48485) 2023-11-29 skia-flutter-autoroll@skia.org Roll Skia from 6ad886e9593a to fa5d6165e4d8 (2 revisions) (flutter/engine#48484) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from Vqcs_2rbtDfb to 8wu5EgBh1yJP If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/fbb2b1e880fa...9a840e8dba40 2023-11-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "binary_messenger missing cstdint" (flutter/engine#48483) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/4beaa1195b74...fbb2b1e880fa 2023-11-29 joel.winarske@gmail.com binary_messenger missing cstdint (flutter/engine#48481) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/570fec4fa92c...4beaa1195b74 2023-11-29 jonahwilliams@google.com [Impeller] fix descriptor pool recycler test flake. (flutter/engine#48479) 2023-11-29 robert.ancell@canonical.com Fix the application not disposing by breaking circular references on quit (flutter/engine#47684) 2023-11-28 dnfield@google.com Fix CanonicalizeURL for file schema (flutter/engine#48466) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
auto-submit[bot] authored
Reverts flutter/flutter#139101 Initiated by: jonahwilliams This change reverts the following previous change: Original Description: Reland of https://github.com/flutter/flutter/pull/138837 I reverted too many config files, the app needed the pbx project file in order to find the new class I added. Instead, just put the new platform view in the app delegate so it builds.
-
- 28 Nov, 2023 18 commits
-
-
godofredoc authored
This is part of the effort to deprecated adhoc tests. Bug: https://github.com/flutter/flutter/issues/139153
-
Tirth authored
Write Tests for API Examples of `snack_bar.0`, `elevated_button.0`, `stepper.0`, `radio.0`, `filled_button.0`, `outlined_button.0` & `card.0` (#138987) Write Tests for API Examples of `snack_bar.0`, `elevated_button.0`, `stepper.0`, `radio.0`, `filled_button.0`, `outlined_button.0` & `card.0` Part of #130459
-
Nate authored
I previously made a PR (#136140) that used `switch` expressions to make some parts of the Flutter codebase easier to understand. It was assigned to the framework team, and @christopherfujino let me know that it was too large to effectively review and recommended breaking it up into smaller pull requests. Here's a PR that only targets files in the `dev/` directory. Hopefully this will be easier to work with! (solves issue https://github.com/flutter/flutter/issues/136139)
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/01fcec7214db...570fec4fa92c 2023-11-28 skia-flutter-autoroll@skia.org Roll Skia from f07025afd712 to 6ad886e9593a (5 revisions) (flutter/engine#48469) 2023-11-28 jason-simmons@users.noreply.github.com Remove use of variable length arrays (flutter/engine#48232) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Gregor Zurowski authored
A documentation tiny fix of the comment for `WidgetsBindingObserver`.
-
yim authored
Fixes: #138836 Adds some comments to OverlayPortal to clarify its behavior.
-
Gabriel Tavares authored
**What has been done?** ---------------------- Added new enumeration in `TableCellVerticalAlignment`, which sets the cell size to the same as the topmost cell. There are no noticeable problems in using it in all cells together, as there are in `TableCellVerticalAlignment.fill` which is made not to be used in all cells together because it has another purpose. **Explanation of the logic** ---------------------- An assignment was made (which already existed in `TableCellVerticalAlignment.top; middle and bottom`) that assigns `rowHeight` the maximum double between the initialized height and the height of its child.  Basically, defining a minimum cell height based on its child, and letting each table row have its own height stipulated from the largest element, creating an `IntrinsicHeight` for TableCell automatically.  As the `TableCellVerticalAlignment` logic already provides for the use of the height of the largest cell in the row, it was possible to reuse this logic, and just not make the break statement that exists to fill in the calculation for `intrinsicHeight`. Real example in an Android application after added enumeration ----------------------  Opened issue ---------------------- FIX: #130261
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/97ede154dcd8...01fcec7214db 2023-11-28 15619084+vashworth@users.noreply.github.com Skip unexpected events in MultiPlatformViewBackgroundForegroundScenario (flutter/engine#48456) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
LongCatIsLooong authored
Fixes https://github.com/flutter/flutter/issues/138592. In an `Icon` widget if the icon font's body (ascender + descender) is larger than the font's units per em, the icon height reported by the text layout library will be larger than the specified font size. When that happens the icon glyph gets pushed towards the bottom because the `Icon` widget is wrapped in a fontSize x fontSize SizedBox and thus has a fixed height of fontSize px. This wasn't a problem for material icons because its UPEM == body.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/fd3a33f8b239...97ede154dcd8 2023-11-28 jonahwilliams@google.com [Impeller] Skip mask blur with 0 sigma. (flutter/engine#48457) 2023-11-28 jonahwilliams@google.com [Impeller] match sigma scaling to Skia scaling. (flutter/engine#48434) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/d375d5b95d59...fd3a33f8b239 2023-11-28 skia-flutter-autoroll@skia.org Roll Skia from 8752700a2565 to f07025afd712 (1 revision) (flutter/engine#48462) 2023-11-28 30870216+gaaclarke@users.noreply.github.com [Impeller] implements incorporating the gaussian blur snapshot transform (flutter/engine#48426) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/e4b18fa3661e...d375d5b95d59 2023-11-28 jonahwilliams@google.com [Impeller] Recycle descriptor sets. (flutter/engine#48343) 2023-11-28 skia-flutter-autoroll@skia.org Roll Skia from 88443909711b to 8752700a2565 (3 revisions) (flutter/engine#48460) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Tirth authored
Added `keyboardType` & `textInputAction` props to `SearchBar`, `SearchAnchor` & `SearchAnchor.bar` Fixes #138483
-
Jim Kalafut authored
I believe this was intended (in #128351) to be a heading, but currently in the [published docs](https://api.flutter.dev/flutter/material/PopupMenuButton-class.html) it is rendered as: ``` /// ## Updating to MenuAnchor ```
-
Kate Lovett authored
Fixes https://github.com/flutter/flutter/issues/138753 This makes sure that InkSparkles are always fixed for testing rather than random.
-
Victoria Ashworth authored
A workaround was added for https://github.com/flutter/flutter/issues/138238, so let's re-enable macOS 13 tests
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/8715e9b9119d...e4b18fa3661e 2023-11-28 skia-flutter-autoroll@skia.org Roll Skia from 259041aed940 to 88443909711b (1 revision) (flutter/engine#48449) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/e774e8887ce2...3c054661a3a6 2023-11-28 engine-flutter-autoroll@skia.org Manual roll Flutter from b5f163a6 to 6bf3ccd4 (20 revisions) (flutter/packages#5495) 2023-11-27 43054281+camsim99@users.noreply.github.com [quick_actions_android] Run tests on AVDs running Android 34 (flutter/packages#5220) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
![auto-submit[bot]'s avatar](https://secure.gravatar.com/avatar/266ceac20512ae5366aafb5e5452ef8b?s=80&d=identicon "auto-submit[bot]")
