- 02 Jun, 2023 4 commits
-
-
Michael Goderbauer authored
Syncs our lints with https://github.com/dart-lang/linter/blob/master/example/all.yaml: * removed the deprecated `iterable_contains_unrelated_type` and `list_remove_unrelated_type` lints (their replacement `collection_methods_unrelated_type` was already enabled for us) * enabled the new `no_self_assignments` and fixed one issue triggered by the lint.
-
Hans Muller authored
Updated the ToggleButtons example and test to M3. Updated the nested tabs test to avoid warnings like: ``` Warning: A call to tap() with finder "exactly one widget with type "Tab" which is an ancestor of text "Explore": Tab(text: "Explore", icon: Icon)" derived an Offset (Offset(666.7, 92.0)) that would not hit test on the specified widget. ```
-
Qun Cheng authored
Fixes #127092 This fix can solve the alignment issue in `SearchBar` but we still need to investigate the root cause for the `TextField`. The text baseline of `TextField` doesn't change when the height is less than 48 and greater than 40. The problem should be related to the `minContainerHeight` which is 48 by default but the `contentHeight` has become smaller than this min value already. Setting `isDense`/`isCollapsed` to true gives the `minContainerHeight` a smaller number which is 0.0: https://github.com/flutter/flutter/blob/ff33555b239de4c17e7149db17eb70bcf5dee215/packages/flutter/lib/src/material/input_decorator.dart#L1086 Since [`isDense`](https://github.com/flutter/flutter/blob/ff33555b239de4c17e7149db17eb70bcf5dee215/packages/flutter/lib/src/material/input_decorator.dart#L3907) is used for the case where the text field has less vertical space, I just use this property in SearchBar. https://github.com/flutter/flutter/assets/36861262/6ddc8e90-1b47-4dd5-9a57-59b86cafec6d This is a demo to show the text baseline that doesn't change when we set the text field height under 48. https://github.com/flutter/flutter/assets/36861262/ce2ee815-f1f5-493a-930e-0540a627bec8
-
Flutter GitHub Bot authored
This PR was generated by `flutter update-packages --force-upgrade`.
-
- 01 Jun, 2023 30 commits
-
-
Taha Tesser authored
-
Hans Muller authored
-
Ben Konyi authored
Service extensions are unable to handle requests when the isolate they were registered on is paused. The DevTools launcher logic was waiting for some service extension invocations to complete before advertising the already active DevTools instance, but when --start-paused was provided these requests would never complete, preventing users from using DevTools to resume the paused isolate. Fixes https://github.com/flutter/flutter/issues/126691
-
Kate Lovett authored
Adds an error message where we previously would crash without any help. Came across this while working on https://github.com/flutter/flutter/pull/127718 Fixes https://github.com/flutter/flutter/issues/128074
-
Hans Muller authored
-
fzyzcjy authored
Closes https://github.com/flutter/flutter/issues/125920 I will add tests, polish code, etc, if this change looks generally OK!
-
-
Hans Muller authored
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/7c0a639efd0a...3a453f2ccb77 2023-06-01 flar@google.com Reland "add non-rendering operation culling to DisplayListBuilder" (#41463) (flutter/engine#42330) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
-
Hans Muller authored
Of the original 4 examples, the first 3 mostly covered the same API features and occupied quite a bit of real-estate at the top of https://api.flutter.dev/flutter/material/FloatingActionButton-class.html. Additionally the illustrations and the code samples didn't match in some cases. Replaced examples 0,1,2 with one example that changes attributes of the FAB when it's pushed. Fixes https://github.com/flutter/flutter/issues/128048
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/fdd39c421fb9...7c0a639efd0a 2023-06-01 skia-flutter-autoroll@skia.org Roll Skia from 934d90ab7370 to f5bc3d12f0eb (1 revision) (flutter/engine#42482) 2023-06-01 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from htio0wC3kDb9tB1Wd... to X4Pkixxtt3BkjRW9P... (flutter/engine#42481) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from htio0wC3kDb9 to X4Pkixxtt3Bk If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/c8e1a8d6fb57...fdd39c421fb9 2023-06-01 skia-flutter-autoroll@skia.org Roll ICU from a2961dc659b4 to 1eea59cabae0 (2 revisions) (flutter/engine#42479) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
-
Jonah Williams authored
Shaders are supported everywhere but HTML backend. We missed this doc update.
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/95bb7930e12b...f0513ae199e1 2023-05-31 54558023+keyonghan@users.noreply.github.com Remove legacy xcode properties and dependencies (flutter/packages#4093) 2023-05-31 43054281+camsim99@users.noreply.github.com [camerax] Correct missing features list in `README` (flutter/packages#4123) 2023-05-31 JeroenWeener@users.noreply.github.com [image_picker] Move disk accesses to background thread (flutter/packages#4058) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Vasiliy Ditsyak authored
This PR adds an ability to specify `fallbackFont` for `Icon` class via `IconData` props. Read detailed description here https://github.com/flutter/flutter/issues/126670
-
Mouad Debbar authored
To avoid confusion and unpredictable errors (e.g. https://github.com/flutter/flutter/issues/127462), I'm adding this assert to disallow this pattern. Fixes https://github.com/flutter/flutter/issues/127462
-
Andrew Kolos authored
Fixes #122081. When validating an Android Studio installation, add a warning validation message when we are unable to detect the version. This is because we have logic throughout the tool (JDK/JRE-searching) that is at higher risk of failing when we don't know the version.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/8339c71a963c...c8e1a8d6fb57 2023-06-01 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from WbvKb2sKXw0MUnSsC... to yqJfBsLdfLP4_vbFu... (flutter/engine#42478) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from WbvKb2sKXw0M to yqJfBsLdfLP4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/bc81133892a6...8339c71a963c 2023-06-01 skia-flutter-autoroll@skia.org Roll Skia from 6c7e1bccb539 to 934d90ab7370 (1 revision) (flutter/engine#42477) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/e235f47164fa...bc81133892a6 2023-06-01 skia-flutter-autoroll@skia.org Roll Dart SDK from 78d09b5874fa to 0d3c310fd6d9 (1 revision) (flutter/engine#42476) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Tomasz Gucio authored
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/a9ed2dec45ff...e235f47164fa 2023-06-01 skia-flutter-autoroll@skia.org Roll Skia from 1573bd65a399 to 6c7e1bccb539 (2 revisions) (flutter/engine#42475) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/65938065a118...a9ed2dec45ff 2023-06-01 skia-flutter-autoroll@skia.org Roll Skia from a83c633d39ba to 1573bd65a399 (1 revision) (flutter/engine#42474) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/ec321ba0740b...65938065a118 2023-06-01 skia-flutter-autoroll@skia.org Roll Skia from f4f569aa5236 to a83c633d39ba (1 revision) (flutter/engine#42472) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Andrew Kolos authored
Fixes #124252, finishing work on the umbrella tracking issue, #126126. Essentially, after this PR, no (non-test) code should be be referencing/invoking the java home or binary paths.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/6db2f3e9857c...ec321ba0740b 2023-06-01 skia-flutter-autoroll@skia.org Roll Skia from d9f959926dad to f4f569aa5236 (7 revisions) (flutter/engine#42470) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/f9bc342c84e2...6db2f3e9857c 2023-06-01 jonahwilliams@google.com Revert "[web] Remove the JS API for url strategy" (flutter/engine#42468) 2023-06-01 skia-flutter-autoroll@skia.org Roll Dart SDK from e0caea366989 to 78d09b5874fa (4 revisions) (flutter/engine#42465) 2023-06-01 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from lSKDoGVypQfTMYUZe... to htio0wC3kDb9tB1Wd... (flutter/engine#42463) 2023-05-31 mdebbar@google.com [web] Remove the JS API for url strategy (flutter/engine#42134) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from lSKDoGVypQfT to htio0wC3kDb9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Ian Hickson authored
-
- 31 May, 2023 6 commits
-
-
Loïc Sharma authored
Address Tong's feedback here: https://github.com/flutter/flutter/issues/127695#issuecomment-1564884872 Follow-up to: https://github.com/flutter/flutter/pull/127046
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/e817c3b128a4...f9bc342c84e2 2023-05-31 skia-flutter-autoroll@skia.org Roll Skia from cb883f64681b to d9f959926dad (11 revisions) (flutter/engine#42458) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Tae Hyung Kim authored
-
Greg Spencer authored
## Description This fixes the parsing of `AppLifecycleState` in the services binding so that it knows what it is. ## Related Issues - Fixes https://github.com/flutter/flutter/issues/127974 ## Tests - Added a test that causes parsing of all the different app lifecycle states.
-
Tae Hyung Kim authored
This PR fixes `SliverCrossAxisGroup` so that once we calculate the total `scrollExtent` of the `SliverCrossAxisGroup`, we ensure that any child sliver is not painted outside of the "scroll extent" of the sliver group. https://github.com/flutter/flutter/assets/2004742/670dc6f9-a3c6-4bcc-85d3-576cf7f33c6a https://github.com/flutter/flutter/assets/2004742/0c9cd951-c133-4a8b-9e5e-89d0a69a4f59 Fixes #126958. Fixes #126957.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/b9860dcc8ddd...e817c3b128a4 2023-05-31 kjlubick@users.noreply.github.com Register codecs with Skia explicitly (flutter/engine#42320) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
