Commits · 5c424aa87fab58181a6cd8e4d85ea795ffd40fc2 · abdullh.alsoleman / Front-End

01 Aug, 2023 15 commits

Roll Flutter Engine from 1aadc75dd5a7 to 10a1f9cb74c9 (1 revision) (#131696) · 5c424aa8

engine-flutter-autoroll authored Aug 01, 2023

https://github.com/flutter/engine/compare/1aadc75dd5a7...10a1f9cb74c9

2023-08-01 30870216+gaaclarke@users.noreply.github.com [Impeller] Started using a pool for HostBuffers. (flutter/engine#44081)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5c424aa8

Roll Flutter Engine from e3f817ce9953 to 1aadc75dd5a7 (2 revisions) (#131691) · de004293

engine-flutter-autoroll authored Aug 01, 2023

https://github.com/flutter/engine/compare/e3f817ce9953...1aadc75dd5a7

2023-08-01 zanderso@users.noreply.github.com Manual clang roll to ebd0b8a0472b865b7eb6e1a32af97ae31d829033 (flutter/engine#44220)
2023-08-01 30870216+gaaclarke@users.noreply.github.com [Impeller] Made the clear optimization handle backdrop filters. (flutter/engine#44192)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

de004293

Roll Packages from 60e9a542f94e to 3dc00c1a32f6 (5 revisions) (#131692) · abb1e4c7

engine-flutter-autoroll authored Aug 01, 2023

https://github.com/flutter/packages/compare/60e9a542f94e...3dc00c1a32f6

2023-08-01 engine-flutter-autoroll@skia.org Manual roll Flutter from 1d44fbd8 to 1d59196b (18 revisions) (flutter/packages#4621)
2023-07-31 32242716+ricardoamador@users.noreply.github.com Update the cirrus key jul-31-2023 (flutter/packages#4618)
2023-07-31 jpnurmi@gmail.com [path_provider_platform_interface] Add getApplicationCachePath() (flutter/packages#4614)
2023-07-31 elitree@gmail.com [google_maps_flutter_web] Initial support for custom overlays (flutter/packages#3538)
2023-07-31 34410554+maciejbrzezinski@users.noreply.github.com [camera] Removed the microphone permission request from availableCameras on Web (flutter/packages#4263)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

abb1e4c7

Avoid concurrent modification of persistent frame callbacks (#131677) · c5716983

Dan Field authored Aug 01, 2023

Fixes https://github.com/flutter/flutter/issues/131415

We should do an audit of all such cases though, filed https://github.com/flutter/flutter/issues/131678

c5716983

Roll Flutter Engine from ae535c024146 to e3f817ce9953 (1 revision) (#131687) · b9c3f1f7

engine-flutter-autoroll authored Aug 01, 2023

https://github.com/flutter/engine/compare/ae535c024146...e3f817ce9953

2023-08-01 30870216+gaaclarke@users.noreply.github.com [Impeller] moved to one staging buffer pool (flutter/engine#44172)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b9c3f1f7

Roll Flutter Engine from 703d45539059 to ae535c024146 (4 revisions) (#131679) · 5d2c9d09

engine-flutter-autoroll authored Aug 01, 2023

https://github.com/flutter/engine/compare/703d45539059...ae535c024146

2023-08-01 skia-flutter-autoroll@skia.org Roll Dart SDK from 45405dd4ea87 to 197fc0d7fea2 (1 revision) (flutter/engine#44217)
2023-08-01 skia-flutter-autoroll@skia.org Roll Skia from 45290179e017 to a7a3646c2c8a (1 revision) (flutter/engine#44216)
2023-08-01 skia-flutter-autoroll@skia.org Roll Skia from bddb07184f88 to 45290179e017 (1 revision) (flutter/engine#44215)
2023-08-01 skia-flutter-autoroll@skia.org Manual roll Dart SDK from aca45d2e133c to 45405dd4ea87 (2 revisions) (flutter/engine#44204)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5d2c9d09

Roll Flutter Engine from f1c80ce98499 to 703d45539059 (1 revision) (#131668) · bd64bf5f

engine-flutter-autoroll authored Aug 01, 2023

https://github.com/flutter/engine/compare/f1c80ce98499...703d45539059

2023-08-01 skia-flutter-autoroll@skia.org Roll Skia from c74c10128334 to bddb07184f88 (1 revision) (flutter/engine#44214)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bd64bf5f

Roll Flutter Engine from 2583c07f6a69 to f1c80ce98499 (1 revision) (#131663) · de5b9670

engine-flutter-autoroll authored Aug 01, 2023

https://github.com/flutter/engine/compare/2583c07f6a69...f1c80ce98499

2023-08-01 skia-flutter-autoroll@skia.org Roll Skia from 177897b13a89 to c74c10128334 (4 revisions) (flutter/engine#44213)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

de5b9670

Roll Flutter Engine from 25b9d1088d09 to 2583c07f6a69 (1 revision) (#131661) · 3ec088c1

engine-flutter-autoroll authored Aug 01, 2023

https://github.com/flutter/engine/compare/25b9d1088d09...2583c07f6a69

2023-08-01 skia-flutter-autoroll@skia.org Roll ICU from e8c3bc9ea97d to de4ce0071eb4 (3 revisions) (flutter/engine#44212)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3ec088c1

Roll Flutter Engine from 7651b3cba6ba to 25b9d1088d09 (4 revisions) (#131655) · fcd5a6c4

engine-flutter-autoroll authored Aug 01, 2023

https://github.com/flutter/engine/compare/7651b3cba6ba...25b9d1088d09

2023-08-01 skia-flutter-autoroll@skia.org Roll ANGLE from 6dc0c9d62755 to b53d99d87e6a (1 revision) (flutter/engine#44211)
2023-08-01 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Dd4To9QyMtoPGPIpl... to g0dgOL2IlZQJCK4El... (flutter/engine#44210)
2023-08-01 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from wIpcCOc0TtDYasQbl... to lwCo6le6r0X-Srvx3... (flutter/engine#44208)
2023-08-01 skia-flutter-autoroll@skia.org Manual roll Dart SDK from a58ca112af1c to aca45d2e133c (2 revisions) (flutter/engine#44203)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from wIpcCOc0TtDY to lwCo6le6r0X-
fuchsia/sdk/core/mac-amd64 from Dd4To9QyMtoP to g0dgOL2IlZQJ

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fcd5a6c4

Roll Flutter Engine from 1433e23c8a3d to 7651b3cba6ba (2 revisions) (#131648) · 8bd985f1

engine-flutter-autoroll authored Aug 01, 2023

https://github.com/flutter/engine/compare/1433e23c8a3d...7651b3cba6ba

2023-08-01 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 0e02245635ea to a58ca112af1c (1 revision) (flutter/engine#44197)
2023-08-01 dworsham@google.com [fuchsia] Only use upstream vulkan headers (flutter/engine#44157)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8bd985f1

Roll Flutter Engine from 791f505c8c6e to 1433e23c8a3d (1 revision) (#131647) · 5d028a28

engine-flutter-autoroll authored Aug 01, 2023

https://github.com/flutter/engine/compare/791f505c8c6e...1433e23c8a3d

2023-08-01 matanlurey@users.noreply.github.com [Impeller] Implement, non user-facing, dithering for LinearGradients. (flutter/engine#44181)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5d028a28

Roll Flutter Engine from bb2a903c934c to 791f505c8c6e (4 revisions) (#131645) · c851efaa

engine-flutter-autoroll authored Aug 01, 2023

https://github.com/flutter/engine/compare/bb2a903c934c...791f505c8c6e

2023-08-01 skia-flutter-autoroll@skia.org Roll Skia from 2e5f08012a92 to 177897b13a89 (1 revision) (flutter/engine#44199)
2023-08-01 skia-flutter-autoroll@skia.org Roll ANGLE from cb4b1f3641ae to 6dc0c9d62755 (2 revisions) (flutter/engine#44198)
2023-08-01 chinmaygarde@google.com [Impeller] Document the fiddly bits about setting up Metal shader source debugging. (flutter/engine#44195)
2023-07-31 chinmaygarde@google.com [Impeller] Add documentation on how to enable Metal Profiling HUD without Xcode. (flutter/engine#44196)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c851efaa

🐛 Treat empty ARB content as empty map when decoding (#131242) · f2db93df
Alex Li authored Aug 01, 2023
```
Fixes #128932.
```
f2db93df

Roll Flutter Engine from fe2369565f59 to bb2a903c934c (3 revisions) (#131639) · d250fa62

engine-flutter-autoroll authored Aug 01, 2023

https://github.com/flutter/engine/compare/fe2369565f59...bb2a903c934c

2023-07-31 skia-flutter-autoroll@skia.org Roll ANGLE from 196713767078 to cb4b1f3641ae (1 revision) (flutter/engine#44193)
2023-07-31 a-siva@users.noreply.github.com Manual roll of Dart with fixups to zircon system.dart (flutter/engine#44185)
2023-07-31 chinmaygarde@google.com [Impeller] Update guidance on how to run with Metal validation without Xcode. (flutter/engine#44190)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d250fa62

31 Jul, 2023 19 commits

Roll Flutter Engine from b83172a4e995 to fe2369565f59 (12 revisions) (#131638) · 40a9d3f1

engine-flutter-autoroll authored Jul 31, 2023

https://github.com/flutter/engine/compare/b83172a4e995...fe2369565f59

2023-07-31 skia-flutter-autoroll@skia.org Roll ANGLE from faca95f7e81b to 196713767078 (7 revisions) (flutter/engine#44191)
2023-07-31 ian@hixie.ch Mention the point of BlendMode.plus and advise on using it. (flutter/engine#44189)
2023-07-31 skia-flutter-autoroll@skia.org Roll Skia from db813f4043fe to 2e5f08012a92 (1 revision) (flutter/engine#44187)
2023-07-31 chinmaygarde@google.com [Impeller] Update guidance on how to try Impeller on macOS Desktop. (flutter/engine#44186)
2023-07-31 chinmaygarde@google.com [Impeller] Add a descriptive blurb about newer Impeller components and fix links. (flutter/engine#44183)
2023-07-31 skia-flutter-autoroll@skia.org Roll Skia from 06174bc8f4d5 to db813f4043fe (1 revision) (flutter/engine#44182)
2023-07-31 jason-simmons@users.noreply.github.com [Impeller] Create a wrapper Impeller context for each Vulkan surface and its swapchain (flutter/engine#44171)
2023-07-31 skia-flutter-autoroll@skia.org Roll Skia from ea0c9c0935ae to 06174bc8f4d5 (2 revisions) (flutter/engine#44179)
2023-07-31 skia-flutter-autoroll@skia.org Roll ANGLE from 2755f73a3461 to faca95f7e81b (1 revision) (flutter/engine#44178)
2023-07-31 skia-flutter-autoroll@skia.org Roll Skia from 9c12eb0e158a to ea0c9c0935ae (4 revisions) (flutter/engine#44177)
2023-07-31 skia-flutter-autoroll@skia.org Roll Skia from 685e29df6704 to 9c12eb0e158a (2 revisions) (flutter/engine#44173)
2023-07-31 skia-flutter-autoroll@skia.org Roll Skia from cb61dd4af8a5 to 685e29df6704 (2 revisions) (flutter/engine#44170)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

40a9d3f1

Appended period remove & Uri parsing fix. (#131293) · 1d59196b

Sumit Bikram Maity authored Jul 31, 2023

Fixed code for the Uri as it includes the period at the end as the part of Uri parsing previously.

As for example:
```
A crash report has been written to /Users/andrewkolos/Desktop/asset_transformers_test/flutter_03.log.
``` 

Many terminals are unable to follow the link because it includes the period in the end as part of it. This PR simply removes the period in the end so that it is clickable in many systems (e.g. by `alt` -clicking on it in an embedded bash terminal, VSCode).

```
A crash report has been written to /Users/andrewkolos/Desktop/asset_transformers_test/flutter_03.log
``` 

Fixes:  #131166

1d59196b

Fixed regex to show missing assets file error (#131160) · efc9e16e

Jay Mehta authored Jul 31, 2023

Added Regex to match error message from verbos build as suggested by @stuartmorgan [here](https://github.com/flutter/flutter/pull/98137#discussion_r810559589).
Modified Windows Build Test

Fixes #97065

efc9e16e

Update `CheckboxListTile` and `CalendarDatePicker` tests for M2/M3 (#131363) · 3cf206ba
Qun Cheng authored Jul 31, 2023

3cf206ba

Reland --omit-type-checks for benchmarks. (#131493) · b928b3c1

Jackson Gardner authored Jul 31, 2023

Because the cost of type checks dominate our dart2wasm benchmarks, we've
decided to pass `--omit-type-checks` for now.

This was previously reverted because the skwasm benchmarks were broken
in general for a separate reason, and my getting rid of `bringup: true`
broke the tree. I ended up fixing the benchmarks and getting rid of
`bringup: true` in a separate commit, so this just adds the flag only.

b928b3c1

Update the cirrus key jul-31-2023 (#131624) · d5ebf539

Ricardo Amador authored Jul 31, 2023

Updating the cirrus key.

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

d5ebf539

Add Expanded/Collapsed State for Semantics (#131233) · 71d96ddf
Qun Cheng authored Jul 31, 2023

71d96ddf

Reland - "Update Unit Tests for M2/M3" (#131504) · e0b6b6c4

Qun Cheng authored Jul 31, 2023

Reverts flutter/flutter#131368
Original PR: https://github.com/flutter/flutter/pull/131292 . The
flutter mirror was out of date and tree was closed, so the original PR
was reverted. Now should be safe to have a reland.

e0b6b6c4

Roll Flutter Engine from ae6d1d60df95 to b83172a4e995 (4 revisions) (#131614) · 544c0408

engine-flutter-autoroll authored Jul 31, 2023

https://github.com/flutter/engine/compare/ae6d1d60df95...b83172a4e995

2023-07-31 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from c0Pr9uG-46yC83ZVy... to Dd4To9QyMtoPGPIpl... (flutter/engine#44168)
2023-07-31 skia-flutter-autoroll@skia.org Roll ANGLE from fb37e0542c7c to 2755f73a3461 (1 revision) (flutter/engine#44167)
2023-07-31 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from SqCbKBft29XeD2Qvw... to wIpcCOc0TtDYasQbl... (flutter/engine#44166)
2023-07-31 skia-flutter-autoroll@skia.org Roll Skia from 6ee21fa70879 to cb61dd4af8a5 (1 revision) (flutter/engine#44165)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from SqCbKBft29Xe to wIpcCOc0TtDY
fuchsia/sdk/core/mac-amd64 from c0Pr9uG-46yC to Dd4To9QyMtoP

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

544c0408

Upgrade compile and target sdk versions in tests and benchmarks (#131428) · ae750e57
gmackall authored Jul 31, 2023
```
Partially fixes/related to: https://github.com/flutter/flutter/issues/131425
```
ae750e57

Roll Flutter Engine from b11a832ea7d4 to ae6d1d60df95 (1 revision) (#131611) · 972d36c4

engine-flutter-autoroll authored Jul 31, 2023

https://github.com/flutter/engine/compare/b11a832ea7d4...ae6d1d60df95

2023-07-31 skia-flutter-autoroll@skia.org Roll ANGLE from 143fa68f50b7 to fb37e0542c7c (1 revision) (flutter/engine#44161)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

972d36c4

Roll Packages from 10aab445d985 to 60e9a542f94e (6 revisions) (#131607) · 0881d07e

engine-flutter-autoroll authored Jul 31, 2023

https://github.com/flutter/packages/compare/10aab445d985...60e9a542f94e

2023-07-30 engine-flutter-autoroll@skia.org Manual roll Flutter from c2b40ca7 to 1d44fbd8 (7 revisions) (flutter/packages#4592)
2023-07-29 engine-flutter-autoroll@skia.org Roll Flutter from e81907e0 to c2b40ca7 (24 revisions) (flutter/packages#4588)
2023-07-28 stuartmorgan@google.com [ci] Switch FTL to LUCI (flutter/packages#4583)
2023-07-28 jhy03261997@gmail.com [go_router_builder] support v10.0.0 go_router (flutter/packages#4578)
2023-07-28 engine-flutter-autoroll@skia.org Roll Flutter from dd9764ec to e81907e0 (21 revisions) (flutter/packages#4582)
2023-07-28 stuartmorgan@google.com [ci] Add LUCI version of Android FTL tests in bringup mode (flutter/packages#4571)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0881d07e

Fix dartdoc for `ButtonSegment` constructor (#131400) · 28ee5581
Pierre-Louis authored Jul 31, 2023
```
https://github.com/flutter/flutter/issues/103529
```
28ee5581

[flutter_tools/dap] Improve rendering of structured errors via DAP (#131251) · 0386f910

Danny Tuppeny authored Jul 31, 2023

In the legacy VS Code DAP, we would deserialise the Flutter.Error event
and provide some basic colouring (eg. stack frames are faded if not from
user code and the text is split between stdout/stderr to allow the
client to colour it).

In the new DAPs we originally used `renderedErrorText` which didn't
support either of these. This change adds changes to use the structured
data (with some basic parsing because the source classes are in
package:flutter and not accessible here) to provide a similar
experience.

It would be nicer if we could use the real underlying Flutter classes
for this deserialisation, but extracting them from `package:flutter` and
removing all dependencies on Flutter is a much larger job and I don't
think should hold up providing improved error formatting for the new
DAPs.

Some comparisons:


![1_comparison](https://github.com/flutter/flutter/assets/1078012/74e7e6d6-c8d0-471f-b584-37ae148b0ce7)


![2_comparison](https://github.com/flutter/flutter/assets/1078012/21888934-6f2f-4048-86d7-bdf92d5c7301)

0386f910

[doc] Fix module_test_ios comments (#131470) · fceaa005
Daco Harkes authored Jul 31, 2023

fceaa005

Use Flutter app project's NDK version from FFI plugin (#131141) · c05c3d39

Donghyun Kim authored Jul 31, 2023

<img width="1119" alt="image" src="https://github.com/flutter/flutter/assets/66480156/e2e8eed1-3bef-436c-b21f-3891bdbe05bb">

In most cases, a FFI plugin doesn't need its own specific Android NDK version. Just following the Flutter app project's NDK version is enough.

If a Flutter app project depends on multiple FFI plugins that use different Android NDK versions, it can be quite wasteful and use excessive disk space due to multiple NDK installations.

Using Flutter app project's NDK version is also less error-prone because upgrading the Flutter SDK would be enough when upgrading FFI plugins(If project's `ndkVersion` is `flutter.ndkVersion`), without messing with Android NDK installations.

This problem was discussed in some actual FFI plugin repositories, and they are striving to find their own solutions:
- https://github.com/superlistapp/super_native_extensions/issues/143#issuecomment-1646207706
- https://github.com/cunarist/rust-in-flutter/discussions/60#discussioncomment-6484218
- https://github.com/rive-app/rive-flutter/issues/320
- https://github.com/juicycleff/flutter-unity-view-widget/issues/832

c05c3d39

Roll Flutter Engine from 22f9aad5aba5 to b11a832ea7d4 (2 revisions) (#131597) · f43755d3

engine-flutter-autoroll authored Jul 31, 2023

https://github.com/flutter/engine/compare/22f9aad5aba5...b11a832ea7d4

2023-07-31 skia-flutter-autoroll@skia.org Roll Skia from 91b838fe533d to 6ee21fa70879 (1 revision) (flutter/engine#44160)
2023-07-31 skia-flutter-autoroll@skia.org Roll Skia from 1146dd2212ba to 91b838fe533d (1 revision) (flutter/engine#44159)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f43755d3

Roll Flutter Engine from b84c93601684 to 22f9aad5aba5 (3 revisions) (#131592) · af5d9c19

engine-flutter-autoroll authored Jul 31, 2023

https://github.com/flutter/engine/compare/b84c93601684...22f9aad5aba5

2023-07-31 skia-flutter-autoroll@skia.org Roll Skia from 3febb7d97cb0 to 1146dd2212ba (1 revision) (flutter/engine#44158)
2023-07-31 skia-flutter-autoroll@skia.org Roll Skia from 0e62d11175aa to 3febb7d97cb0 (1 revision) (flutter/engine#44156)
2023-07-31 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 5tPeR3pmLZVAbR1iy... to SqCbKBft29XeD2Qvw... (flutter/engine#44155)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 5tPeR3pmLZVA to SqCbKBft29Xe

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

af5d9c19

Roll Flutter Engine from d95adb9c8bc6 to b84c93601684 (1 revision) (#131585) · 46f83ce6

engine-flutter-autoroll authored Jul 31, 2023

https://github.com/flutter/engine/compare/d95adb9c8bc6...b84c93601684

2023-07-30 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 17au0GOALWDVfQnwu... to c0Pr9uG-46yC83ZVy... (flutter/engine#44154)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 17au0GOALWDV to c0Pr9uG-46yC

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

46f83ce6

30 Jul, 2023 5 commits

Roll Flutter Engine from 0ccff9a2bad3 to d95adb9c8bc6 (1 revision) (#131578) · 1d44fbd8

engine-flutter-autoroll authored Jul 30, 2023

https://github.com/flutter/engine/compare/0ccff9a2bad3...d95adb9c8bc6

2023-07-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 38hspwoyzrqU6GbsM... to 5tPeR3pmLZVAbR1iy... (flutter/engine#44152)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 38hspwoyzrqU to 5tPeR3pmLZVA

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1d44fbd8

Roll Flutter Engine from f3d1e004f7b1 to 0ccff9a2bad3 (1 revision) (#131571) · 063d68b1

engine-flutter-autoroll authored Jul 30, 2023

https://github.com/flutter/engine/compare/f3d1e004f7b1...0ccff9a2bad3

2023-07-30 skia-flutter-autoroll@skia.org Roll Skia from 01451297ae1b to 0e62d11175aa (1 revision) (flutter/engine#44151)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

063d68b1

Roll Flutter Engine from 9d4bf38f987f to f3d1e004f7b1 (1 revision) (#131569) · 7d258cb4

engine-flutter-autoroll authored Jul 30, 2023

https://github.com/flutter/engine/compare/9d4bf38f987f...f3d1e004f7b1

2023-07-30 skia-flutter-autoroll@skia.org Roll Skia from c33c0619b892 to 01451297ae1b (1 revision) (flutter/engine#44150)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7d258cb4

Roll Flutter Engine from 12ce9f013cef to 9d4bf38f987f (1 revision) (#131564) · 9758d773

engine-flutter-autoroll authored Jul 30, 2023

https://github.com/flutter/engine/compare/12ce9f013cef...9d4bf38f987f

2023-07-30 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from VIjw2bdybUo-rgC0t... to 17au0GOALWDVfQnwu... (flutter/engine#44148)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from VIjw2bdybUo- to 17au0GOALWDV

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9758d773

Roll Flutter Engine from 590ff28649eb to 12ce9f013cef (2 revisions) (#131562) · 4d245a84

engine-flutter-autoroll authored Jul 30, 2023

https://github.com/flutter/engine/compare/590ff28649eb...12ce9f013cef

2023-07-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from -5L2wI7BjRNgnccfl... to 38hspwoyzrqU6GbsM... (flutter/engine#44145)
2023-07-30 skia-flutter-autoroll@skia.org Roll ANGLE from 0abd6f549ff1 to 143fa68f50b7 (1 revision) (flutter/engine#44144)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from -5L2wI7BjRNg to 38hspwoyzrqU

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4d245a84

29 Jul, 2023 1 commit

Roll Flutter Engine from 2b1af6df4e7c to 590ff28649eb (1 revision) (#131561) · 068efb3a

engine-flutter-autoroll authored Jul 29, 2023

https://github.com/flutter/engine/compare/2b1af6df4e7c...590ff28649eb

2023-07-29 chinmaygarde@google.com [Impeller] Update documentation on RenderDoc frame capture. (flutter/engine#44124)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

068efb3a