Commits · 5b3c21681639058a35cb74b50298068353a8a5a1 · abdullh.alsoleman / Front-End

23 Feb, 2024 20 commits

Bump codecov/codecov-action from 4.0.1 to 4.0.2 (#144060) · 5b3c2168

dependabot[bot] authored Feb 23, 2024

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.0.1 to 4.0.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/codecov/codecov-action/releases">codecov/codecov-action's releases</a>.</em></p>
<blockquote>
<h2>v4.0.2</h2>
<h2>What's Changed</h2>
<ul>
<li>Update README.md by <a href="https://github.com/thomasrockhu-codecov"><code>@âthomasrockhu-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1251">codecov/codecov-action#1251</a></li>
<li>build(deps-dev): bump <code>@âtypes/jest</code> from 29.5.11 to 29.5.12 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1257">codecov/codecov-action#1257</a></li>
<li>build(deps): bump github/codeql-action from 3.23.2 to 3.24.0 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1266">codecov/codecov-action#1266</a></li>
<li>Escape pipes in table of arguments by <a href="https://github.com/jwodder"><code>@âjwodder</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1265">codecov/codecov-action#1265</a></li>
<li>Add link to docs on Dependabot secrets by <a href="https://github.com/ianlewis"><code>@âianlewis</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1260">codecov/codecov-action#1260</a></li>
<li>fix: working-directory input for all stages by <a href="https://github.com/Bo98"><code>@âBo98</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1272">codecov/codecov-action#1272</a></li>
<li>build(deps-dev): bump <code>@âtypescript-eslint/parser</code> from 6.20.0 to 6.21.0 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1271">codecov/codecov-action#1271</a></li>
<li>build(deps-dev): bump <code>@âtypescript-eslint/eslint-plugin</code> from 6.20.0 to 6.21.0 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1269">codecov/codecov-action#1269</a></li>
<li>build(deps): bump github/codeql-action from 3.24.0 to 3.24.3 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1298">codecov/codecov-action#1298</a></li>
<li>Use updated syntax for GitHub Markdown notes by <a href="https://github.com/jamacku"><code>@âjamacku</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1300">codecov/codecov-action#1300</a></li>
<li>build(deps-dev): bump <code>@âtypescript-eslint/eslint-plugin</code> from 6.21.0 to 7.0.0 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1290">codecov/codecov-action#1290</a></li>
<li>build(deps): bump actions/upload-artifact from 4.3.0 to 4.3.1 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1286">codecov/codecov-action#1286</a></li>
<li>chore(release): bump to 4.0.2 by <a href="https://github.com/thomasrockhu-codecov"><code>@âthomasrockhu-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1302">codecov/codecov-action#1302</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/jwodder"><code>@âjwodder</code></a> made their first contribution in <a href="https://redirect.github.com/codecov/codecov-action/pull/1265">codecov/codecov-action#1265</a></li>
<li><a href="https://github.com/ianlewis"><code>@âianlewis</code></a> made their first contribution in <a href="https://redirect.github.com/codecov/codecov-action/pull/1260">codecov/codecov-action#1260</a></li>
<li><a href="https://github.com/Bo98"><code>@âBo98</code></a> made their first contribution in <a href="https://redirect.github.com/codecov/codecov-action/pull/1272">codecov/codecov-action#1272</a></li>
<li><a href="https://github.com/jamacku"><code>@âjamacku</code></a> made their first contribution in <a href="https://redirect.github.com/codecov/codecov-action/pull/1300">codecov/codecov-action#1300</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/codecov/codecov-action/compare/v4.0.1...v4.0.2">https://github.com/codecov/codecov-action/compare/v4.0.1...v4.0.2</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/codecov/codecov-action/commit/0cfda1dd0a4ad9efc75517f399d859cd1ea4ced1"><code>0cfda1d</code></a> chore(release): bump to 4.0.2 (<a href="https://redirect.github.com/codecov/codecov-action/issues/1302">#1302</a>)</li>
<li><a href="https://github.com/codecov/codecov-action/commit/7d3a55eb5ecdfe4abc7d47043c527908f5f9ae09"><code>7d3a55e</code></a> build(deps): bump actions/upload-artifact from 4.3.0 to 4.3.1 (<a href="https://redirect.github.com/codecov/codecov-action/issues/1286">#1286</a>)</li>
<li><a href="https://github.com/codecov/codecov-action/commit/fe84a0b3c07e94ba49e9c87299d78d0116594782"><code>fe84a0b</code></a> build(deps-dev): bump <code>@âtypescript-eslint/eslint-plugin</code> from 6.21.0 to 7.0.0 (...</li>
<li><a href="https://github.com/codecov/codecov-action/commit/e12c9402c4274f2ab3fd378ebbd6d68109363a55"><code>e12c940</code></a> Use updated syntax for GitHub Markdown notes (<a href="https://redirect.github.com/codecov/codecov-action/issues/1300">#1300</a>)</li>
<li><a href="https://github.com/codecov/codecov-action/commit/ef7f8a5d3c2b37427f931fd83cab3237e2b4958a"><code>ef7f8a5</code></a> build(deps): bump github/codeql-action from 3.24.0 to 3.24.3 (<a href="https://redirect.github.com/codecov/codecov-action/issues/1298">#1298</a>)</li>
<li><a href="https://github.com/codecov/codecov-action/commit/b8a1d6a4243f1ff280a5533872c4d80179cc5b4a"><code>b8a1d6a</code></a> build(deps-dev): bump <code>@âtypescript-eslint/eslint-plugin</code> from 6.20.0 to 6.21.0 ...</li>
<li><a href="https://github.com/codecov/codecov-action/commit/6ef7ea4c746b6a6025ef6fbb8dfeaa546bc46794"><code>6ef7ea4</code></a> build(deps-dev): bump <code>@âtypescript-eslint/parser</code> from 6.20.0 to 6.21.0 (<a href="https://redirect.github.com/codecov/codecov-action/issues/1271">#1271</a>)</li>
<li><a href="https://github.com/codecov/codecov-action/commit/f62c5eebfe9df5cfe9d56fd86ec925442fe3c214"><code>f62c5ee</code></a> fix: working-directory input for all stages (<a href="https://redirect.github.com/codecov/codecov-action/issues/1272">#1272</a>)</li>
<li><a href="https://github.com/codecov/codecov-action/commit/fdbfa4b8899ee1f727543c9079e8ca54d1133a0f"><code>fdbfa4b</code></a> Add link to docs on Dependabot secrets (<a href="https://redirect.github.com/codecov/codecov-action/issues/1260">#1260</a>)</li>
<li><a href="https://github.com/codecov/codecov-action/commit/9855cf7bd15a633568e00a5c51e9e8aee7e40529"><code>9855cf7</code></a> Escape pipes in table of arguments (<a href="https://redirect.github.com/codecov/codecov-action/issues/1265">#1265</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/codecov/codecov-action/compare/e0b68c6749509c5f83f984dd99a76a1c1a231044...0cfda1dd0a4ad9efc75517f399d859cd1ea4ced1">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=codecov/codecov-action&package-manager=github_actions&previous-version=4.0.1&new-version=4.0.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

5b3c2168

Render the warm up frame in a proper rendering process (#143290) · be2544ab

Tong Mu authored Feb 23, 2024

_This PR requires https://github.com/flutter/engine/pull/50570._

This PR uses the new `PlatformDispatcher.scheduleWarmUpFrame` API to render warm up frames.

For why the warm up frame must involve the engine to render, see https://github.com/flutter/flutter/issues/142851.

be2544ab

Roll Flutter Engine from fbc9b889aee9 to 5d1c0d4dc327 (2 revisions) (#144049) · 01963ea2

engine-flutter-autoroll authored Feb 23, 2024

https://github.com/flutter/engine/compare/fbc9b889aee9...5d1c0d4dc327

2024-02-23 flar@google.com [Impeller] Compute UV coordinates lazily in PositionUVWriter (flutter/engine#50879)
2024-02-23 skia-flutter-autoroll@skia.org Roll Skia from 49dd7ed24bec to fde4d63c5e61 (3 revisions) (flutter/engine#50917)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

01963ea2

Roll Flutter Engine from b5bebfe43d29 to fbc9b889aee9 (3 revisions) (#144041) · 7785c690

engine-flutter-autoroll authored Feb 23, 2024

https://github.com/flutter/engine/compare/b5bebfe43d29...fbc9b889aee9

2024-02-23 skia-flutter-autoroll@skia.org Roll Skia from 037e08e92598 to 49dd7ed24bec (3 revisions) (flutter/engine#50916)
2024-02-23 john@johnmccutchan.com Add an initial 'build' command to engine_tool (flutter/engine#50681)
2024-02-23 skia-flutter-autoroll@skia.org Roll Dart SDK from 7f6eccd65255 to 9849ca5fcaec (1 revision) (flutter/engine#50915)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7785c690

disable debug banner in m3 page test apps. (#143857) · 895406c6
Jonah Williams authored Feb 23, 2024
```
This one flakes but rarely.

Part of https://github.com/flutter/flutter/issues/143616
```
895406c6

Relands "Changing `TextPainter.getOffsetForCaret` implementation to remove the... · a0a854a7

LongCatIsLooong authored Feb 23, 2024

Relands "Changing `TextPainter.getOffsetForCaret` implementation to remove the logarithmic search (#143281)" (reverted in #143801) (#143954)

The original PR was reverted because the new caret positioning callpath triggered a skparagraph assert. The assert has been removed. Relanding the PR with no changes applied.

a0a854a7

Roll Flutter Engine from 5f99a6c3289e to b5bebfe43d29 (1 revision) (#144035) · c84565a6

engine-flutter-autoroll authored Feb 23, 2024

https://github.com/flutter/engine/compare/5f99a6c3289e...b5bebfe43d29

2024-02-23 skia-flutter-autoroll@skia.org Roll Skia from c7f8e0e6f3c2 to 037e08e92598 (8 revisions) (flutter/engine#50914)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c84565a6

Implementing null-aware operators throughout the repository (#143804) · c53a18f4

Nate authored Feb 23, 2024

This pull request fixes #143803 by taking advantage of Dart's null-aware operators.

And unlike `switch` expressions ([9 PRs](https://github.com/flutter/flutter/pull/143634) and counting), the Flutter codebase is already fantastic when it comes to null-aware coding. After refactoring the entire repo, all the changes involving `?.` and `??` can fit into a single pull request.

c53a18f4

Re-enable Impeller goldens blocking. (#144023) · 39585e66

Jonah Williams authored Feb 23, 2024

Part of https://github.com/flutter/flutter/issues/143616

Without this these tests only run on postsubmit which means we can't get gold results on PRs.

This was reverted because it landed after an engine change that broke flutter tester. That change has since been reverted.

39585e66

Roll Flutter Engine from 0f3ad23b84ed to 5f99a6c3289e (16 revisions) (#144028) · eac71cee

engine-flutter-autoroll authored Feb 23, 2024

https://github.com/flutter/engine/compare/0f3ad23b84ed...5f99a6c3289e

2024-02-23 skia-flutter-autoroll@skia.org Roll Skia from bb8a7832a6f4 to c7f8e0e6f3c2 (3 revisions) (flutter/engine#50911)
2024-02-23 brianosman@google.com Replace SkColorSpace::filterColor with filterColor4f (flutter/engine#50821)
2024-02-23 skia-flutter-autoroll@skia.org Roll Dart SDK from 52111952d91b to 7f6eccd65255 (1 revision) (flutter/engine#50910)
2024-02-23 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from j9cJ94K-T1i3u5xGh... to sO-oG6KoeFlPK2WLR... (flutter/engine#50907)
2024-02-23 bdero@google.com [Impeller] Make StC work for Position+UV buffers. (flutter/engine#50900)
2024-02-23 skia-flutter-autoroll@skia.org Roll Dart SDK from 957130770e7d to 52111952d91b (1 revision) (flutter/engine#50906)
2024-02-23 skia-flutter-autoroll@skia.org Roll Skia from 14b5c1a4627a to bb8a7832a6f4 (1 revision) (flutter/engine#50905)
2024-02-23 skia-flutter-autoroll@skia.org Roll Skia from 5a0a82af7796 to 14b5c1a4627a (1 revision) (flutter/engine#50904)
2024-02-23 skia-flutter-autoroll@skia.org Roll Dart SDK from e2f2d9b464e9 to 957130770e7d (2 revisions) (flutter/engine#50903)
2024-02-23 skia-flutter-autoroll@skia.org Roll Skia from 254b27e90e3c to 5a0a82af7796 (1 revision) (flutter/engine#50902)
2024-02-23 matanlurey@users.noreply.github.com Move ban-plugin-java script into separate file and improve testing. (flutter/engine#50875)
2024-02-23 matanlurey@users.noreply.github.com Provide a subset of `adb logcat` logs streaming during scenario_app testing (flutter/engine#50886)
2024-02-23 54558023+keyonghan@users.noreply.github.com Remove obsolete `cache_root` property (flutter/engine#50894)
2024-02-23 skia-flutter-autoroll@skia.org Roll Skia from 58772db6bc46 to 254b27e90e3c (1 revision) (flutter/engine#50896)
2024-02-23 54558023+keyonghan@users.noreply.github.com Remove unused drone_dimension field (flutter/engine#50893)
2024-02-22 54558023+keyonghan@users.noreply.github.com Remove unused property from `Linux Web Framework tests` (flutter/engine#50891)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from j9cJ94K-T1i3 to sO-oG6KoeFlP

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

eac71cee

Roll Packages from 078c2a304a01 to 7df2085c80e2 (3 revisions) (#144030) · bab5f85d

engine-flutter-autoroll authored Feb 23, 2024

https://github.com/flutter/packages/compare/078c2a304a01...7df2085c80e2

2024-02-22 ditman@gmail.com [web] Removes a few deprecated API usages. (flutter/packages#6177)
2024-02-22 katelovett@google.com [two_dimensional_scrollables] Fix layout offset of merged pinned cells (flutter/packages#6178)
2024-02-22 engine-flutter-autoroll@skia.org Roll Flutter from efee280c to 41581c9a (1 revision) (flutter/packages#6181)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bab5f85d

Run tests on iOS 17 exclusively (#144022) · bb856079

Victoria Ashworth authored Feb 23, 2024

Almost all of our devicelab devices are on iOS 17 now, so let's use them exclusively so we can verify that tests pass consistently on iOS 17.

Fixes https://github.com/flutter/flutter/issues/144020.

bb856079

Retry button tap in [FlutterUITests testFlutterViewWarm] (#143967) · 00229827
Victoria Ashworth authored Feb 23, 2024
```
Attempting to fix https://github.com/flutter/flutter/issues/142125.
```
00229827
Remove deprecated `InteractiveViewer.alignPanAxis` (#142500) · fcd154bd
LongCatIsLooong authored Feb 23, 2024

fcd154bd

Remove deprecated `KeepAliveHandle.release` (#143961) · 59da873e

LongCatIsLooong authored Feb 23, 2024

https://github.com/flutter/flutter/issues/143956

I still did not include a dartfix since a dartfix that replaces `release` with `dispose` would change the semantics and may cause a runtime crash instead of a build error.

@Piinks  does setting `bulkApply` to false force the user to apply the fix to every occurrence one by one in their IDE? If so then it seems that would be the way to go for this deprecation?

59da873e

Remove deprecated AnimatedListItemBuilder, AnimatedListRemovedItemBuilder (#143974) · 10a50bcc
Michael Goderbauer authored Feb 23, 2024
```
https://github.com/flutter/flutter/issues/143956
```
10a50bcc

Manual roll Flutter Engine from 06448ee8165f to 0f3ad23b84ed (16 revisions) (#143989) · ce100cd3

engine-flutter-autoroll authored Feb 23, 2024

Manual roll requested by goderbauer@google.com

https://github.com/flutter/engine/compare/06448ee8165f...0f3ad23b84ed

2024-02-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Implement frame timing callbacks in Skwasm. (#50737)" (flutter/engine#50895)
2024-02-22 skia-flutter-autoroll@skia.org Roll Dart SDK from 0f0f7400c38a to e2f2d9b464e9 (4 revisions) (flutter/engine#50881)
2024-02-22 skia-flutter-autoroll@skia.org Roll Skia from a285cd79614c to 58772db6bc46 (3 revisions) (flutter/engine#50884)
2024-02-22 30870216+gaaclarke@users.noreply.github.com [Impeller] moved the kernel size assert to a more appropriate location. (flutter/engine#50880)
2024-02-22 15619084+vashworth@users.noreply.github.com Build macOS engine as an xcframework (flutter/engine#50300)
2024-02-22 skia-flutter-autoroll@skia.org Roll Skia from dd8cd405d145 to a285cd79614c (3 revisions) (flutter/engine#50878)
2024-02-22 dnfield@google.com Avoid generated plugin registrant warnings for scenario_app (flutter/engine#50874)
2024-02-22 15619084+vashworth@users.noreply.github.com Delete and create iOS simulator before running Scenario app test (flutter/engine#50835)
2024-02-22 skia-flutter-autoroll@skia.org Roll Skia from b9c16065b76d to dd8cd405d145 (2 revisions) (flutter/engine#50872)
2024-02-22 zanderso@users.noreply.github.com Remove 'bringup: true' from 'Mac mac_unopt' (flutter/engine#50865)
2024-02-22 31859944+LongCatIsLooong@users.noreply.github.com Pass the missing strut half leading flag over to skia paragraph builder (flutter/engine#50385)
2024-02-22 jacksongardner@google.com Implement frame timing callbacks in Skwasm. (flutter/engine#50737)
2024-02-22 flar@google.com [Impeller] Add stroke benchmarks that create UVs with no transform (flutter/engine#50847)
2024-02-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove WindowManager reflection in SingleViewPresentation.java (#49996)" (flutter/engine#50873)
2024-02-22 zanderso@users.noreply.github.com Use RBE on more Windows builders (flutter/engine#50866)
2024-02-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] cache onscreen render targets. (#50751)" (flutter/engine#50871)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC goderbauer@google.com,jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ce100cd3

Remove deprecated TimelineSummary.writeSummaryToFile (#143983) · 20078f89
Kate Lovett authored Feb 23, 2024
```
https://github.com/flutter/flutter/issues/143956
```
20078f89

Remove unused drone_dimension field (#143984) · 91a6ec9a

keyonghan authored Feb 23, 2024

The drone_dimensions is expected to be defined under property only. The field level definition has never been used.

part of https://github.com/flutter/flutter/issues/143671

91a6ec9a

Remove deprecated MediaQuery.boldTextOverride (#143960) · ccf9c150
Michael Goderbauer authored Feb 23, 2024
```
https://github.com/flutter/flutter/issues/143956
```
ccf9c150

22 Feb, 2024 20 commits

Revert engine back to 06448ee8165f4ff6579ef9510ac69322eda896ac (#143986) · 94855a96
Michael Goderbauer authored Feb 22, 2024
```
https://github.com/flutter/engine/pull/50737 broke the tree
```
94855a96
Remove deprecated FlutterDriver.enableAccessibility (#143979) · cbab555d
Kate Lovett authored Feb 22, 2024
```
https://github.com/flutter/flutter/issues/143956
```
cbab555d

Roll Flutter Engine from cb6115d3a6ab to c5d2e011652b (3 revisions) (#143980) · a8861fb8

engine-flutter-autoroll authored Feb 22, 2024

https://github.com/flutter/engine/compare/cb6115d3a6ab...c5d2e011652b

2024-02-22 30870216+gaaclarke@users.noreply.github.com [Impeller] moved the kernel size assert to a more appropriate location. (flutter/engine#50880)
2024-02-22 15619084+vashworth@users.noreply.github.com Build macOS engine as an xcframework (flutter/engine#50300)
2024-02-22 skia-flutter-autoroll@skia.org Roll Skia from dd8cd405d145 to a285cd79614c (3 revisions) (flutter/engine#50878)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a8861fb8

Revert "Introduce tone-based surfaces and accent color add-ons - Part 2" (#143973) · 4715216c
Qun Cheng authored Feb 22, 2024
```
Reverts flutter/flutter#138521
```
4715216c

Add CloseButtonTooltip to the 'X' button on a SnackBar (#143934) · 16535924

dsanagustin authored Feb 22, 2024

Adds a localized Close Button tooltip to the 'X' Button on a SnackBar, making it readable by screen readers.

Github Issue #143793 

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

16535924

Bump github/codeql-action from 3.24.3 to 3.24.4 (#143971) · b476e967

dependabot[bot] authored Feb 22, 2024

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.24.3 to 3.24.4.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<p>Note that the only difference between <code>v2</code> and <code>v3</code> of the CodeQL Action is the node version they support, with <code>v3</code> running on node 20 while we continue to release <code>v2</code> to support running on node 16. For example <code>3.22.11</code> was the first <code>v3</code> release and is functionally identical to <code>2.22.11</code>. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>3.24.4 - 21 Feb 2024</h2>
<ul>
<li>Fix an issue where an existing, but empty, <code>/sys/fs/cgroup/cpuset.cpus</code> file always resulted in a single-threaded run. <a href="https://redirect.github.com/github/codeql-action/pull/2151">#2151</a></li>
<li>Update default CodeQL bundle version to 2.16.3. <a href="https://redirect.github.com/github/codeql-action/pull/2156">#2156</a></li>
</ul>
<h2>3.24.3 - 15 Feb 2024</h2>
<ul>
<li>Fix an issue where the CodeQL Action would fail to load a configuration specified by the <code>config</code> input to the <code>init</code> Action. <a href="https://redirect.github.com/github/codeql-action/pull/2147">#2147</a></li>
</ul>
<h2>3.24.2 - 15 Feb 2024</h2>
<ul>
<li>Enable improved multi-threaded performance on larger runners for GitHub Enterprise Server users. This feature is already available to GitHub.com users. <a href="https://redirect.github.com/github/codeql-action/pull/2141">#2141</a></li>
</ul>
<h2>3.24.1 - 13 Feb 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.16.2. <a href="https://redirect.github.com/github/codeql-action/pull/2124">#2124</a></li>
<li>The CodeQL action no longer fails if it can't write to the telemetry api endpoint. <a href="https://redirect.github.com/github/codeql-action/pull/2121">#2121</a></li>
</ul>
<h2>3.24.0 - 02 Feb 2024</h2>
<ul>
<li>CodeQL Python analysis will no longer install dependencies on GitHub Enterprise Server, as is already the case for GitHub.com. See <a href="https://github.com/github/codeql-action/blob/main/#3230---08-jan-2024">release notes for 3.23.0</a> for more details. <a href="https://redirect.github.com/github/codeql-action/pull/2106">#2106</a></li>
</ul>
<h2>3.23.2 - 26 Jan 2024</h2>
<ul>
<li>On Linux, the maximum possible value for the <code>--threads</code> option now respects the CPU count as specified in <code>cgroup</code> files to more accurately reflect the number of available cores when running in containers. <a href="https://redirect.github.com/github/codeql-action/pull/2083">#2083</a></li>
<li>Update default CodeQL bundle version to 2.16.1. <a href="https://redirect.github.com/github/codeql-action/pull/2096">#2096</a></li>
</ul>
<h2>3.23.1 - 17 Jan 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.16.0. <a href="https://redirect.github.com/github/codeql-action/pull/2073">#2073</a></li>
<li>Change the retention period for uploaded debug artifacts to 7 days. Previously, this was whatever the repository default was. <a href="https://redirect.github.com/github/codeql-action/pull/2079">#2079</a></li>
</ul>
<h2>3.23.0 - 08 Jan 2024</h2>
<ul>
<li>We are rolling out a feature in January 2024 that will disable Python dependency installation by default for all users. This improves the speed of analysis while having only a very minor impact on results. You can override this behavior by setting <code>CODEQL_ACTION_DISABLE_PYTHON_DEPENDENCY_INSTALLATION=false</code> in your workflow, however we plan to remove this ability in future versions of the CodeQL Action. <a href="https://redirect.github.com/github/codeql-action/pull/2031">#2031</a></li>
<li>The CodeQL Action now requires CodeQL version 2.11.6 or later. For more information, see <a href="https://github.com/github/codeql-action/blob/main/#2227---16-nov-2023">the corresponding changelog entry for CodeQL Action version 2.22.7</a>. <a href="https://redirect.github.com/github/codeql-action/pull/2009">#2009</a></li>
</ul>
<h2>3.22.12 - 22 Dec 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.5. <a href="https://redirect.github.com/github/codeql-action/pull/2047">#2047</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/e2e140ad1441662206e8f97754b166877dfa1c73"><code>e2e140a</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2157">#2157</a> from github/update-v3.24.4-982d9346a</li>
<li><a href="https://github.com/github/codeql-action/commit/5b1ae298f9e2aa0908205f904ebeebebdc74685f"><code>5b1ae29</code></a> Update changelog for v3.24.4</li>
<li><a href="https://github.com/github/codeql-action/commit/982d9346add1ff0ac9db3b764aa5d1007496e9f8"><code>982d934</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2111">#2111</a> from github/nickfyson/first-or-third-party</li>
<li><a href="https://github.com/github/codeql-action/commit/ebda17e8597cc970bf2442f27c6f2a429d14826f"><code>ebda17e</code></a> respond to review comments</li>
<li><a href="https://github.com/github/codeql-action/commit/cca1ddefc0a060bc9070bbddd3a1330c965f7d4f"><code>cca1dde</code></a> Merge branch 'main' into nickfyson/first-or-third-party</li>
<li><a href="https://github.com/github/codeql-action/commit/f32f0bf8e4be601057cf2b42bd296510931d5a6e"><code>f32f0bf</code></a> ensure only the upload-sarif action can submit a status report with first_par...</li>
<li><a href="https://github.com/github/codeql-action/commit/bf8c75ee37169a266fa6b795e1fd1fd9b4a32110"><code>bf8c75e</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2153">#2153</a> from github/aeisenberg/add-permissions-doc</li>
<li><a href="https://github.com/github/codeql-action/commit/36c51ac2b5abbdffd22f44a746f1882962308885"><code>36c51ac</code></a> Capitalize Code Scanning</li>
<li><a href="https://github.com/github/codeql-action/commit/a7dc22949666ca49b1add57eb421b6d550ef80d2"><code>a7dc229</code></a> add first_party_analysis boolean to all status reports</li>
<li><a href="https://github.com/github/codeql-action/commit/592977e6ae857384aa79bb31e7a1d62d63449ec5"><code>592977e</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2151">#2151</a> from angelapwen/fix-cpu-group-bug</li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/379614612a29c9e28f31f39a59013eb8012a51f0...e2e140ad1441662206e8f97754b166877dfa1c73">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=3.24.3&new-version=3.24.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

b476e967

Roll Flutter Engine from 06448ee8165f to cb6115d3a6ab (10 revisions) (#143972) · 0387f62a

engine-flutter-autoroll authored Feb 22, 2024

https://github.com/flutter/engine/compare/06448ee8165f...cb6115d3a6ab

2024-02-22 dnfield@google.com Avoid generated plugin registrant warnings for scenario_app (flutter/engine#50874)
2024-02-22 15619084+vashworth@users.noreply.github.com Delete and create iOS simulator before running Scenario app test (flutter/engine#50835)
2024-02-22 skia-flutter-autoroll@skia.org Roll Skia from b9c16065b76d to dd8cd405d145 (2 revisions) (flutter/engine#50872)
2024-02-22 zanderso@users.noreply.github.com Remove 'bringup: true' from 'Mac mac_unopt' (flutter/engine#50865)
2024-02-22 31859944+LongCatIsLooong@users.noreply.github.com Pass the missing strut half leading flag over to skia paragraph builder (flutter/engine#50385)
2024-02-22 jacksongardner@google.com Implement frame timing callbacks in Skwasm. (flutter/engine#50737)
2024-02-22 flar@google.com [Impeller] Add stroke benchmarks that create UVs with no transform (flutter/engine#50847)
2024-02-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove WindowManager reflection in SingleViewPresentation.java (#49996)" (flutter/engine#50873)
2024-02-22 zanderso@users.noreply.github.com Use RBE on more Windows builders (flutter/engine#50866)
2024-02-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] cache onscreen render targets. (#50751)" (flutter/engine#50871)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0387f62a

Use inlining annotations on important methods for all targets (#143923) · b09ca497
Martin Kustermann authored Feb 22, 2024

b09ca497

Add missing `TextPainter.strutStyle` to paragraph style (#143771) · 44e440ae

LongCatIsLooong authored Feb 22, 2024

Fixes an issue where if the `TextSpan` doesn't have a text style, the specified strutStyle is not applied.

Additionally, adds a migration flag for https://github.com/flutter/engine/pull/50385, for internal golden changes. It's only going to exist for a week.

44e440ae

Shift Moto G4 staging tests to A02s (#143957) · d13bc10a
Zachary Anderson authored Feb 22, 2024
```
https://github.com/flutter/flutter/issues/143915

cc @yusuf-goog
```
d13bc10a

Add CurvedAnimation disposals in some widgets (#143790) · f0205354

Kostia Sokolovskyi authored Feb 22, 2024

Contributes to https://github.com/flutter/flutter/issues/141198

### Description
- Adds `CurvedAnimation` disposals to `material/chip.dart`, `material/input_decorator.dart`, `material/toggleable.dart`, `widgets/animated_switcher.dart`, `widgets/overscroll_indicator.dart`.

f0205354

Fix documentation typo in basic.dart (#143887) · 9176f7b6
Andrew authored Feb 22, 2024
```
Fixes a small documentation typo.
```
9176f7b6

Fixed Small Typo in Emulators Test Name (#143578) · 3053b6ce

Tirth authored Feb 22, 2024

Fixed Small Typo in Emulators Test Name. I filed #140656 and it was fixed in #142853. I noticed this one there and decided to send a fix.

3053b6ce

Support using lightweight Flutter Engines to run tests (#141726) · dfb5888e

Derek Xu authored Feb 22, 2024

This PR implements the functionality described above and hides it behind
the `--experimental-faster-testing` flag of `flutter test`.

### The following are some performance measurements from test runs
conducted on GitHub Actions

run 1 logs:
https://github.com/derekxu16/flutter_test_ci/actions/runs/8008029772/attempts/1
run 2 logs:
https://github.com/derekxu16/flutter_test_ci/actions/runs/8008029772/attempts/2
run 3 logs:
https://github.com/derekxu16/flutter_test_ci/actions/runs/8008029772/attempts/3

**length of `flutter test --reporter=expanded test/animation
test/foundation` step**

run 1: 54s
run 2: 52s
run 3: 56s

average: 54s

**length of `flutter test --experimental-faster-testing
--reporter=expanded test/animation test/foundation` step**

run 1: 27s
run 2: 27s
run 3: 29s

average: 27.67s (~48.77% shorter than 54s)

**length of `flutter test --reporter=expanded test/animation
test/foundation test/gestures test/painting test/physics test/rendering
test/scheduler test/semantics test/services` step**

run 1: 260s
run 2: 270s
run 3: 305s

average: 278.33s


**length of `flutter test --experimental-faster-testing
--reporter=expanded test/animation test/foundation test/gestures
test/painting test/physics test/rendering test/scheduler test/semantics
test/services` step**

from a clean build (right after deleting the build folder):

run 1: 215s
run 2: 227s
run 3: 245s

average: 229s (~17.72% shorter than 278.33s)

Note that in reality, `test/material` was not passed to `flutter test`
in the trials below. All of the test files under `test/material` except
for `test/material/icons_test.dart` were listed out individually

**length of `flutter test --reporter=expanded test/material` step**

run 1: 408s
run 2: 421s
run 3: 451s

average: 426.67s

**length of `flutter test --experimental-faster-testing
--reporter=expanded test/material` step**

run 1: 382s
run 2: 373s
run 3: 400s

average: 385s (~9.77% shorter than 426.67s)

---------
Co-authored-by: Dan Field <dnfield@google.com>

dfb5888e

Roll Flutter Engine from 9250bfdb38c5 to 06448ee8165f (1 revision) (#143943) · 44bcc9ce

engine-flutter-autoroll authored Feb 22, 2024

https://github.com/flutter/engine/compare/9250bfdb38c5...06448ee8165f

2024-02-22 zanderso@users.noreply.github.com Change "Linux mac_unopt" to "Mac mac_unopt" (flutter/engine#50863)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

44bcc9ce

Reverts "Reland Add UI Benchmarks (#143542) (#143799)" (#143946) · f655f592

auto-submit[bot] authored Feb 22, 2024

Reverts flutter/flutter#143799

Initiated by: goderbauer

Reason for reverting: The microbenchmark failed two run two times in a row after this was committed (see https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8755379171959141089/+/u/run_microbenchmarks/stdout).

Original PR Author: bernaferrari

Reviewed By: {goderbauer}

This change reverts the following previous change:
Original Description:
Re-lands https://github.com/flutter/flutter/pull/143542 (which is part 1 of https://github.com/flutter/flutter/pull/138481)

The filename was wrong 🫠

f655f592

Roll Packages from 48048f6bc779 to 078c2a304a01 (11 revisions) (#143935) · b48ae314

engine-flutter-autoroll authored Feb 22, 2024

https://github.com/flutter/packages/compare/48048f6bc779...078c2a304a01

2024-02-22 engine-flutter-autoroll@skia.org Manual roll Flutter from 5129806e to efee280c (47 revisions) (flutter/packages#6180)
2024-02-22 engine-flutter-autoroll@skia.org Manual roll Flutter (stable) from bae5e49bc2a8 to abb292a07e20 (1 revision) (flutter/packages#6179)
2024-02-21 louisehsu@google.com [in_app_purchase] Convert refreshReceipt(), startObservingPaymentQueue(), stopObservingPaymentQueue(), registerPaymentQueueDelegate(), removePaymentQueueDelegate(), showPriceConsentIfNeeded() to Pigeon (flutter/packages#6165)
2024-02-21 43054281+camsim99@users.noreply.github.com [camerax] Modifies initialized camera info to reflect default AF/AE modes and the ability to set focus points for each (flutter/packages#6109)
2024-02-21 43054281+camsim99@users.noreply.github.com [camerax] Implements `setFocusPoint`, `setExposurePoint`, `setExposureOffset` (flutter/packages#6059)
2024-02-21 stuartmorgan@google.com [various] Commit Windows build migrations (flutter/packages#6175)
2024-02-21 kevmoo@users.noreply.github.com [flutter_markdown] Support wasm (flutter/packages#6168)
2024-02-21 737941+loic-sharma@users.noreply.github.com [ci] Run Windows Arm64 build tests post-submit (flutter/packages#6166)
2024-02-21 stuartmorgan@google.com [url_launcher] Remove `renderView` usage (flutter/packages#6137)
2024-02-21 b@sdevaan.nl [camera_android_camerax] Fix typo in readme (flutter/packages#6143)
2024-02-21 stuartmorgan@google.com [local_auth] Switch iOS endorsement to `local_auth_darwin` (flutter/packages#6107)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b48ae314

Roll Flutter Engine from 7777480eb94d to 9250bfdb38c5 (8 revisions) (#143933) · 1710a84e

engine-flutter-autoroll authored Feb 22, 2024

https://github.com/flutter/engine/compare/7777480eb94d...9250bfdb38c5

2024-02-22 skia-flutter-autoroll@skia.org Roll Skia from 0b55d78d32f9 to b9c16065b76d (1 revision) (flutter/engine#50861)
2024-02-22 skia-flutter-autoroll@skia.org Roll Skia from cbdbcf9bebe6 to 0b55d78d32f9 (1 revision) (flutter/engine#50860)
2024-02-22 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from dLhvv964txwnSlvNw... to j9cJ94K-T1i3u5xGh... (flutter/engine#50858)
2024-02-22 skia-flutter-autoroll@skia.org Roll Skia from ec119f44e6b9 to cbdbcf9bebe6 (2 revisions) (flutter/engine#50857)
2024-02-22 skia-flutter-autoroll@skia.org Roll Skia from 4aa97aca087c to ec119f44e6b9 (1 revision) (flutter/engine#50849)
2024-02-22 bdero@google.com [Impeller] Add StC color source/clip behavior + constexpr flag for enabling StC. (flutter/engine#50817)
2024-02-22 skia-flutter-autoroll@skia.org Roll Skia from 3fd1a5a7c7c1 to 4aa97aca087c (2 revisions) (flutter/engine#50848)
2024-02-22 matanlurey@users.noreply.github.com Minor non-semantic refactors of `ExternalTexturesFlutterActivity` (flutter/engine#50845)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from dLhvv964txwn to j9cJ94K-T1i3

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1710a84e

Reland Add UI Benchmarks (#143542) (#143799) · 063f59fb

Bernardo Ferrari authored Feb 22, 2024

Re-lands https://github.com/flutter/flutter/pull/143542 (which is part 1 of https://github.com/flutter/flutter/pull/138481)

The filename was wrong ð«

063f59fb

Roll Flutter Engine from 7eeb697687d5 to 7777480eb94d (1 revision) (#143913) · 41581c9a

engine-flutter-autoroll authored Feb 22, 2024

https://github.com/flutter/engine/compare/7eeb697687d5...7777480eb94d

2024-02-22 skia-flutter-autoroll@skia.org Roll Skia from 57490c8d257e to 3fd1a5a7c7c1 (9 revisions) (flutter/engine#50842)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

41581c9a