Commits · 536de5ed9168117310286d4056d4588278dab94d · abdullh.alsoleman / Front-End

09 Jan, 2024 21 commits

Update `RouteObserver` example and fix an error thrown (#141166) · 536de5ed

Taha Tesser authored Jan 09, 2024

fixes [`RouteObserver` example throws an error](https://github.com/flutter/flutter/issues/141078)

### Description
This updates the `RouteObserver` example from snippet to Dartpad example and fixes the error when running the code snippet

536de5ed

Upgrade leak_tracker. (#141153) · 1f3103e5
Polina Cherkasova authored Jan 09, 2024

1f3103e5

[ci.yaml] Do not run packaging test on presubmit (#141192) · 51af82d3

Casey Hillers authored Jan 09, 2024

This test doesn't support presubmit as runs a separate git clone, which won't contain the presubmit hash.

Fixes https://github.com/flutter/flutter/issues/141188

51af82d3

Roll Flutter Engine from 036b39fa47fa to a35e3b026e1d (6 revisions) (#141191) · 88341867

engine-flutter-autoroll authored Jan 09, 2024

https://github.com/flutter/engine/compare/036b39fa47fa...a35e3b026e1d

2024-01-09 john@johnmccutchan.com Simplify PlatformViewRenderTarget interface (flutter/engine#49639)
2024-01-09 skia-flutter-autoroll@skia.org Roll Skia from 05039d6ed8d8 to 8c8be76a62c0 (3 revisions) (flutter/engine#49638)
2024-01-09 zanderso@users.noreply.github.com Skip flaky test on mac in http_disallow_http_connections_test.dart (flutter/engine#49635)
2024-01-09 john@johnmccutchan.com Resize the RenderTarget before creating and passing its Surface to the VirtualDisplay (flutter/engine#49619)
2024-01-09 103135467+sealesj@users.noreply.github.com Migrate to Flutter mirrors for Google-owned Github repositories (flutter/engine#49203)
2024-01-09 skia-flutter-autoroll@skia.org Roll Skia from ee263c34e03d to 05039d6ed8d8 (2 revisions) (flutter/engine#49636)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

88341867

Run tests on iOS 16 or iOS 17 (#141178) · 1ec9daa9
Victoria Ashworth authored Jan 09, 2024
```
Fixes https://github.com/flutter/flutter/issues/141177
```
1ec9daa9
Remove conditions that depend on order. (#141183) · 188d4d1f
Polina Cherkasova authored Jan 09, 2024

188d4d1f

Roll Flutter Engine from b3c8597df0e2 to 036b39fa47fa (1 revision) (#141179) · 7bf375b5

engine-flutter-autoroll authored Jan 09, 2024

https://github.com/flutter/engine/compare/b3c8597df0e2...036b39fa47fa

2024-01-09 skia-flutter-autoroll@skia.org Roll Skia from f9f73082740e to ee263c34e03d (3 revisions) (flutter/engine#49631)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7bf375b5

resolved the issue of indeterminate CircularProgressIndicator.adaptive on Darwin (#140947) · 83cf44ed
Nishant Kumar authored Jan 09, 2024
```
Fixes #140574

Passes the value from `CircularProgressIndicator` to the Cupertino version so that functionality is not lost on Apple devices.
```
83cf44ed

Roll Flutter Engine from 820645dbcc69 to b3c8597df0e2 (5 revisions) (#141175) · 126302df

engine-flutter-autoroll authored Jan 09, 2024

https://github.com/flutter/engine/compare/820645dbcc69...b3c8597df0e2

2024-01-09 skia-flutter-autoroll@skia.org Roll Skia from 665f7d51ef25 to f9f73082740e (1 revision) (flutter/engine#49630)
2024-01-09 skia-flutter-autoroll@skia.org Roll Skia from 360944e3175f to 665f7d51ef25 (2 revisions) (flutter/engine#49628)
2024-01-09 skia-flutter-autoroll@skia.org Roll Skia from 92b84715ba73 to 360944e3175f (2 revisions) (flutter/engine#49622)
2024-01-09 skia-flutter-autoroll@skia.org Roll Skia from 06404ed554e7 to 92b84715ba73 (1 revision) (flutter/engine#49620)
2024-01-09 skia-flutter-autoroll@skia.org Roll Dart SDK from e8aa66f435ae to 721fccffc708 (5 revisions) (flutter/engine#49616)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

126302df

Roll Packages from 5aef49b1c1d8 to 09205ca19bd2 (2 revisions) (#141173) · d2d32b58

engine-flutter-autoroll authored Jan 09, 2024

https://github.com/flutter/packages/compare/5aef49b1c1d8...09205ca19bd2

2024-01-09 stuartmorgan@google.com Re-land: Enable prefer_mixin and bump plugin_platform_interface to 2.1.7 (flutter/packages#5841)
2024-01-09 stuartmorgan@google.com [ci] Exclude quick_actions from Android emulators (flutter/packages#5847)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d2d32b58

[Android] Add custom system-wide text selection toolbar buttons for SelectableRegion (#141103) · 5f17badf

Bruno Leroux authored Jan 09, 2024

## Description

This PR adds custom system-wide text selection toolbar buttons on Android for `SelectableRegion` and `SelectionArea`.

https://github.com/flutter/flutter/pull/139738 adds those buttons for `EditableText` (which is used by `TextField` and `SelectableText` but not by `SelectionArea`).

## Related Issue

Step 5 for https://github.com/flutter/flutter/issues/139361

## Tests

Adds 2 tests.

5f17badf

Update Chips and `ChipTheme` tests and for Material 3 (#141022) · f7f437ce
Taha Tesser authored Jan 09, 2024
```
Updated unit tests for `Tooltip` to have M2 and M3 versions.

More info in #139076
```
f7f437ce
Update `chip_test.dart` tests for Material 3 (#140964) · 649877d2
Taha Tesser authored Jan 09, 2024
```
Updated unit tests for `Tooltip` to have M2 and M3 versions.

More info in #139076
```
649877d2

Fix spell check throws when text contains regex reserved characters (#140384) · 2e6aac6e

Bruno Leroux authored Jan 09, 2024

## Description

This PR fixes an issue related to the spell check implementation usage of Regex (searched text should be escaped).

## Related Issue

Fixes https://github.com/flutter/flutter/issues/136032.

## Tests

Adds 1 test.

2e6aac6e

Native assets support for Android Add2app (#140802) · b2ef2802

Daco Harkes authored Jan 09, 2024

Support for FFI calls with @Native external functions through Native assets on Android add to app. This enables bundling native code without any build-system boilerplate code.

For more info see:

*  https://github.com/flutter/flutter/issues/129757

## Implementation details for Android add2app

The `.so` files are bundled with the same mechanism that bundles `libapp.so`.

b2ef2802

Roll Flutter Engine from d13479968b8f to 820645dbcc69 (3 revisions) (#141152) · 29db9dbd

engine-flutter-autoroll authored Jan 09, 2024

https://github.com/flutter/engine/compare/d13479968b8f...820645dbcc69

2024-01-09 skia-flutter-autoroll@skia.org Roll Skia from e3af4a11007d to 06404ed554e7 (1 revision) (flutter/engine#49614)
2024-01-09 magder@google.com Roll buildroot to pick up iOS 12 (flutter/engine#49542)
2024-01-09 skia-flutter-autoroll@skia.org Roll Skia from f4626a2e3293 to e3af4a11007d (1 revision) (flutter/engine#49613)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

29db9dbd

Bump github/codeql-action from 3.22.11 to 3.23.0 (#141132) · a18ca800

dependabot[bot] authored Jan 09, 2024

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.22.11 to 3.23.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<p>Note that the only difference between <code>v2</code> and <code>v3</code> of the CodeQL Action is the node version they support, with <code>v3</code> running on node 20 while we continue to release <code>v2</code> to support running on node 16. For example <code>3.22.11</code> was the first <code>v3</code> release and is functionally identical to <code>2.22.11</code>. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>3.23.0 - 08 Jan 2024</h2>
<ul>
<li>We are rolling out a feature in January 2024 that will disable Python dependency installation by default for all users. This improves the speed of analysis while having only a very minor impact on results. You can override this behavior by setting <code>CODEQL_ACTION_DISABLE_PYTHON_DEPENDENCY_INSTALLATION=false</code> in your workflow, however we plan to remove this ability in future versions of the CodeQL Action. <a href="https://redirect.github.com/github/codeql-action/pull/2031">#2031</a></li>
<li>The CodeQL Action now requires CodeQL version 2.11.6 or later. For more information, see <a href="https://github.com/github/codeql-action/blob/main/#2227---16-nov-2023">the corresponding changelog entry for CodeQL Action version 2.22.7</a>. <a href="https://redirect.github.com/github/codeql-action/pull/2009">#2009</a></li>
</ul>
<h2>3.22.12 - 22 Dec 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.5. <a href="https://redirect.github.com/github/codeql-action/pull/2047">#2047</a></li>
</ul>
<h2>3.22.11 - 13 Dec 2023</h2>
<ul>
<li>[v3+ only] The CodeQL Action now runs on Node.js v20. <a href="https://redirect.github.com/github/codeql-action/pull/2006">#2006</a></li>
</ul>
<h2>2.22.10 - 12 Dec 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.4. <a href="https://redirect.github.com/github/codeql-action/pull/2016">#2016</a></li>
</ul>
<h2>2.22.9 - 07 Dec 2023</h2>
<p>No user facing changes.</p>
<h2>2.22.8 - 23 Nov 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.3. <a href="https://redirect.github.com/github/codeql-action/pull/2001">#2001</a></li>
</ul>
<h2>2.22.7 - 16 Nov 2023</h2>
<ul>
<li>Add a deprecation warning for customers using CodeQL version 2.11.5 and earlier. These versions of CodeQL were discontinued on 8 November 2023 alongside GitHub Enterprise Server 3.7, and will be unsupported by CodeQL Action v2.23.0 and later. <a href="https://redirect.github.com/github/codeql-action/pull/1993">#1993</a>
<ul>
<li>If you are using one of these versions, please update to CodeQL CLI version 2.11.6 or later. For instance, if you have specified a custom version of the CLI using the 'tools' input to the 'init' Action, you can remove this input to use the default version.</li>
<li>Alternatively, if you want to continue using a version of the CodeQL CLI between 2.10.5 and 2.11.5, you can replace <code>github/codeql-action/*@v2</code> by <code>github/codeql-action/*@v2.22.7</code> in your code scanning workflow to ensure you continue using this version of the CodeQL Action.</li>
</ul>
</li>
</ul>
<h2>2.22.6 - 14 Nov 2023</h2>
<ul>
<li>Customers running Python analysis on macOS using version 2.14.6 or earlier of the CodeQL CLI should upgrade to CodeQL CLI version 2.15.0 or later. If you do not wish to upgrade the CodeQL CLI, ensure that you are using Python version 3.11 or earlier, as CodeQL version 2.14.6 and earlier do not support Python 3.12. You can achieve this by adding a <a href="https://github.com/actions/setup-python"><code>setup-python</code></a> step to your code scanning workflow before the step that invokes <code>github/codeql-action/init</code>.</li>
<li>Update default CodeQL bundle version to 2.15.2. <a href="https://redirect.github.com/github/codeql-action/pull/1978">#1978</a></li>
</ul>
<h2>2.22.5 - 27 Oct 2023</h2>
<p>No user facing changes.</p>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/e5f05b81d5b6ff8cfa111c80c22c5fd02a384118"><code>e5f05b8</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2066">#2066</a> from github/update-v3.23.0-fd55bb0b0</li>
<li><a href="https://github.com/github/codeql-action/commit/48e7b8b751b457ccde050d587c85ce3defc30555"><code>48e7b8b</code></a> Update changelog for v3.23.0</li>
<li><a href="https://github.com/github/codeql-action/commit/fd55bb0b00b5802fdceb93f76b498f105e0edbe1"><code>fd55bb0</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2065">#2065</a> from github/henrymercer/further-run-queries-cleanup</li>
<li><a href="https://github.com/github/codeql-action/commit/838a0229829cd641a4a60fc3c95e12a673b5fcdb"><code>838a022</code></a> Clean up running queries workflow now that the queries are determined by the CLI</li>
<li><a href="https://github.com/github/codeql-action/commit/8516954d603e47049b34f3da4dfac83009fcd450"><code>8516954</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2062">#2062</a> from github/henrymercer/remove-action-config-parsing</li>
<li><a href="https://github.com/github/codeql-action/commit/a533ec62b3aeb59c7467569705b9edaca021df43"><code>a533ec6</code></a> Merge branch 'main' into henrymercer/remove-action-config-parsing</li>
<li><a href="https://github.com/github/codeql-action/commit/08ae9bf4d0d441bd9dcf6c2d80742c9fd2bf3cf0"><code>08ae9bf</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2063">#2063</a> from github/henrymercer/remove-ml-powered-queries-repo</li>
<li><a href="https://github.com/github/codeql-action/commit/58ff74adc38e087ca7f6670dfe24cd319aea5f11"><code>58ff74a</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2031">#2031</a> from github/rasmuswl/no-dep-inst-default</li>
<li><a href="https://github.com/github/codeql-action/commit/9926570d4c48228ba780bd02a18a4e05dbb1bbe7"><code>9926570</code></a> Generate JS</li>
<li><a href="https://github.com/github/codeql-action/commit/2e27b3c56bdb1864f5dd58da25fee61f6cd7bb81"><code>2e27b3c</code></a> Create helper <code>isPythonDependencyInstallationDisabled</code></li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/b374143c1149a9115d881581d29b8390bbcbb59c...e5f05b81d5b6ff8cfa111c80c22c5fd02a384118">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=3.22.11&new-version=3.23.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

a18ca800

Shift mac Pixel 7 Pro tests to prod (#141142) · e94a2c04
Zachary Anderson authored Jan 09, 2024
```
Related https://github.com/flutter/flutter/issues/140893
```
e94a2c04

Roll Flutter Engine from 3f0f8913169e to d13479968b8f (2 revisions) (#141147) · 7a5cc2a0

engine-flutter-autoroll authored Jan 09, 2024

https://github.com/flutter/engine/compare/3f0f8913169e...d13479968b8f

2024-01-09 skia-flutter-autoroll@skia.org Roll Skia from cb8e8fa79132 to f4626a2e3293 (3 revisions) (flutter/engine#49610)
2024-01-09 bdero@google.com [Impeller] Document mip bias. (flutter/engine#49602)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7a5cc2a0

Roll Flutter Engine from 09a74a08c819 to 3f0f8913169e (2 revisions) (#141146) · cc0c88f2

engine-flutter-autoroll authored Jan 09, 2024

https://github.com/flutter/engine/compare/09a74a08c819...3f0f8913169e

2024-01-08 skia-flutter-autoroll@skia.org Roll Skia from 5497d5a53ae2 to cb8e8fa79132 (5 revisions) (flutter/engine#49608)
2024-01-08 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 7f2523c2fa9a to e8aa66f435ae (5 revisions) (flutter/engine#49604)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cc0c88f2

Roll Flutter Engine from ee1ded6d1c44 to 09a74a08c819 (3 revisions) (#141144) · 8e7dfac9

engine-flutter-autoroll authored Jan 09, 2024

https://github.com/flutter/engine/compare/ee1ded6d1c44...09a74a08c819

2024-01-08 jason-simmons@users.noreply.github.com When building clang-tidy commands, filter out the sed command that may be appended to each compile command (flutter/engine#49605)
2024-01-08 skia-flutter-autoroll@skia.org Roll Skia from af845097acae to 5497d5a53ae2 (6 revisions) (flutter/engine#49606)
2024-01-08 skia-flutter-autoroll@skia.org Roll Skia from a0aba842460c to af845097acae (3 revisions) (flutter/engine#49601)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8e7dfac9

08 Jan, 2024 10 commits

[docs] Add document content related to chip shape (#140015) · 3b7ed000

asci authored Jan 08, 2024

(#139572)  I would like to request an update to the document to resolve confusion.
I actually modified the code by applying priority as in the comment in [#139572](https://github.com/flutter/flutter/issues/139572) as shown below, but I thought that if 'OutlinedBorder' was used for 'shape', the default value of side for 'OutlinedBorder' was also the developer's intention.

```
OutlinedBorder _getShape(ThemeData theme, ChipThemeData chipTheme, ChipThemeData chipDefaults) {
  final BorderSide? resolvedSide =
      MaterialStateProperty.resolveAs<BorderSide?>(widget.side, materialStates)
          ?? MaterialStateProperty.resolveAs<BorderSide?>(chipTheme.side, materialStates);
  final BorderSide? resolvedShapeSide =
      MaterialStateProperty.resolveAs<BorderSide?>(widget.shape?.side, materialStates)
          ?? MaterialStateProperty.resolveAs<BorderSide?>(chipTheme.shape?.side, materialStates);
  final OutlinedBorder resolvedShape =
      MaterialStateProperty.resolveAs<OutlinedBorder?>(widget.shape, materialStates)
          ?? MaterialStateProperty.resolveAs<OutlinedBorder?>( chipTheme.shape, materialStates)
          ?? MaterialStateProperty.resolveAs<OutlinedBorder?>(chipDefaults.shape, materialStates)
          // TODO(tahatesser): Remove this fallback when Material 2 is deprecated.
          ?? const StadiumBorder();
  // If the side is provided, shape uses the provided side.

  if (resolvedSide != null) {
    return resolvedShape.copyWith(side: resolvedSide);
  }
  if (resolvedShapeSide != null) {
    return resolvedShape.copyWith(side: resolvedShapeSide);
  }
  // If the side is not provided
  // then the shape's side is used. Otherwise, the default side is used.
  return resolvedShape.copyWith(side: chipDefaults.side);
}
```
(in `chip.dart`)

However, (#133856)  PR seems to be intended to ignore this and use the aspect of `chipDefault.side` even if the developer specifies `shape.side` as [Border.none] without explicitly applying `side` .
This is probably because the default value of OutlinedBorder is [Border.none].
I think this is an area that can cause enough confusion, but there are a lot of things that need to be modified to reduce confusion through code changes, and the impact on existing code is likely to be significant.
I also confirmed that this is not accurately explained in the API Docs.
So rather than modifying the code, I decided to add additional explanation to the `shape` comment.
If the results are different from what you intended or the updated content is strange, please review. ð

3b7ed000

Roll Flutter Engine from 00ff33274fc0 to ee1ded6d1c44 (2 revisions) (#141133) · 1e871427

engine-flutter-autoroll authored Jan 08, 2024

https://github.com/flutter/engine/compare/00ff33274fc0...ee1ded6d1c44

2024-01-08 jason-simmons@users.noreply.github.com Fix memory leaks in some embedder unit tests that send key events (flutter/engine#49548)
2024-01-08 jason-simmons@users.noreply.github.com [Impeller] Start and end a frame in the RenderTargetCache for each rendering of an entity in the playgrounds (flutter/engine#49576)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1e871427

Roll Flutter Engine from 70c45157c60a to 00ff33274fc0 (2 revisions) (#141128) · a7aca4b9

engine-flutter-autoroll authored Jan 08, 2024

https://github.com/flutter/engine/compare/70c45157c60a...00ff33274fc0

2024-01-08 bdero@google.com [Flutter GPU] Shader bundle improvements: Uniform structs & member offset reflection, GLES metadata, separate from runtime stage. (flutter/engine#49485)
2024-01-08 skia-flutter-autoroll@skia.org Roll Skia from 88b7612add02 to a0aba842460c (4 revisions) (flutter/engine#49600)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a7aca4b9

Roll Flutter Engine from b57c899aefd7 to 70c45157c60a (1 revision) (#141125) · 501071bc

engine-flutter-autoroll authored Jan 08, 2024

https://github.com/flutter/engine/compare/b57c899aefd7...70c45157c60a

2024-01-08 30870216+gaaclarke@users.noreply.github.com [Impeller] new blur: chop off blur extremities (flutter/engine#49574)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

501071bc

Roll Flutter Engine from db564ffb3549 to b57c899aefd7 (1 revision) (#141114) · f6f4ba4f

engine-flutter-autoroll authored Jan 08, 2024

https://github.com/flutter/engine/compare/db564ffb3549...b57c899aefd7

2024-01-08 skia-flutter-autoroll@skia.org Roll Skia from 4b7cab157b50 to 88b7612add02 (2 revisions) (flutter/engine#49595)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f6f4ba4f

Roll Packages from b9b6d38e012b to 5aef49b1c1d8 (2 revisions) (#141117) · 18b362cf

engine-flutter-autoroll authored Jan 08, 2024

https://github.com/flutter/packages/compare/b9b6d38e012b...5aef49b1c1d8

2024-01-06 ditman@gmail.com [ci] Revert #5793 + Manual flutter roll to c6ddb73f (flutter/packages#5812)
2024-01-05 goderbauer@google.com Enable prefer_mixin and bump plugin_platform_interface to 2.1.7 (flutter/packages#5793)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

18b362cf

Roll Flutter Engine from bbebee146508 to db564ffb3549 (5 revisions) (#141112) · b3b5d89c

engine-flutter-autoroll authored Jan 08, 2024

https://github.com/flutter/engine/compare/bbebee146508...db564ffb3549

2024-01-08 skia-flutter-autoroll@skia.org Roll Skia from 272281e56cdc to 4b7cab157b50 (1 revision) (flutter/engine#49594)
2024-01-08 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from I-3hiLjX2DDy6mu22... to 6z4cZ6HUidtgmhvdk... (flutter/engine#49592)
2024-01-08 matej.knopp@gmail.com Enforce consistent stack size for Flutter threads (flutter/engine#49111)
2024-01-08 skia-flutter-autoroll@skia.org Roll Skia from 384e08e5fbbe to 272281e56cdc (1 revision) (flutter/engine#49588)
2024-01-08 skia-flutter-autoroll@skia.org Roll Skia from e2621f417ff5 to 384e08e5fbbe (1 revision) (flutter/engine#49587)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from I-3hiLjX2DDy to 6z4cZ6HUidtg

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b3b5d89c

Disable test shuffling in widget_tester_leaks_test.dart (#141110) · 7859fe3b

Zachary Anderson authored Jan 08, 2024

Fails with `flutter test --test-randomize-ordering-seed=20240108`

https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20framework_tests_misc/15044/overview

cc @polina-c

7859fe3b

Roll Flutter Engine from 702ae19c0026 to bbebee146508 (1 revision) (#141088) · 12720f0e

engine-flutter-autoroll authored Jan 08, 2024

https://github.com/flutter/engine/compare/702ae19c0026...bbebee146508

2024-01-08 skia-flutter-autoroll@skia.org Roll Skia from 7314a34ea888 to e2621f417ff5 (1 revision) (flutter/engine#49586)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

12720f0e

Roll Flutter Engine from 5e1d18bb51d1 to 702ae19c0026 (1 revision) (#141084) · 65fae87f

engine-flutter-autoroll authored Jan 08, 2024

https://github.com/flutter/engine/compare/5e1d18bb51d1...702ae19c0026

2024-01-08 skia-flutter-autoroll@skia.org Roll Skia from 8e517817b30b to 7314a34ea888 (1 revision) (flutter/engine#49585)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

65fae87f

07 Jan, 2024 3 commits

Roll Flutter Engine from 845ffd16d228 to 5e1d18bb51d1 (1 revision) (#141076) · 7c6ba1f7

engine-flutter-autoroll authored Jan 07, 2024

https://github.com/flutter/engine/compare/845ffd16d228...5e1d18bb51d1

2024-01-07 skia-flutter-autoroll@skia.org Roll Skia from e2bc77be480c to 8e517817b30b (1 revision) (flutter/engine#49584)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7c6ba1f7

Roll Flutter Engine from ffc84af47827 to 845ffd16d228 (1 revision) (#141075) · af50f5c0

engine-flutter-autoroll authored Jan 07, 2024

https://github.com/flutter/engine/compare/ffc84af47827...845ffd16d228

2024-01-07 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from KC2scOJmW9oBJh4ts... to I-3hiLjX2DDy6mu22... (flutter/engine#49583)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from KC2scOJmW9oB to I-3hiLjX2DDy

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

af50f5c0

Roll Flutter Engine from cc9362752996 to ffc84af47827 (2 revisions) (#141074) · 29a37460

engine-flutter-autoroll authored Jan 07, 2024

https://github.com/flutter/engine/compare/cc9362752996...ffc84af47827

2024-01-07 skia-flutter-autoroll@skia.org Roll Skia from 98240694c57d to e2bc77be480c (1 revision) (flutter/engine#49582)
2024-01-07 skia-flutter-autoroll@skia.org Roll Skia from 388ef1be2bb8 to 98240694c57d (1 revision) (flutter/engine#49581)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

29a37460

06 Jan, 2024 6 commits

Roll Flutter Engine from a5173fe3a912 to cc9362752996 (1 revision) (#141066) · 5246bcbb

engine-flutter-autoroll authored Jan 06, 2024

https://github.com/flutter/engine/compare/a5173fe3a912...cc9362752996

2024-01-06 jonahwilliams@google.com [Impeller] remove SamplerLibrary forward declare. (flutter/engine#49573)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5246bcbb

Roll Flutter Engine from 1dfcb6967dd1 to a5173fe3a912 (1 revision) (#141063) · 0809b60a

engine-flutter-autoroll authored Jan 06, 2024

https://github.com/flutter/engine/compare/1dfcb6967dd1...a5173fe3a912

2024-01-06 skia-flutter-autoroll@skia.org Roll Skia from a6e0b4c6a916 to 388ef1be2bb8 (1 revision) (flutter/engine#49580)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0809b60a

Roll Flutter Engine from 2fd75c06e0bd to 1dfcb6967dd1 (1 revision) (#141062) · 95dfde83

engine-flutter-autoroll authored Jan 06, 2024

https://github.com/flutter/engine/compare/2fd75c06e0bd...1dfcb6967dd1

2024-01-06 skia-flutter-autoroll@skia.org Roll Skia from 3547cf9793f4 to a6e0b4c6a916 (2 revisions) (flutter/engine#49579)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

95dfde83

Roll Flutter Engine from 7f872b265733 to 2fd75c06e0bd (1 revision) (#141059) · ffacacf9

engine-flutter-autoroll authored Jan 06, 2024

https://github.com/flutter/engine/compare/7f872b265733...2fd75c06e0bd

2024-01-06 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from l0zn1BQFRjNyaZb-v... to KC2scOJmW9oBJh4ts... (flutter/engine#49578)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from l0zn1BQFRjNy to KC2scOJmW9oB

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ffacacf9

Roll Flutter Engine from 8d1789a43319 to 7f872b265733 (1 revision) (#141056) · d0482116

engine-flutter-autoroll authored Jan 06, 2024

https://github.com/flutter/engine/compare/8d1789a43319...7f872b265733

2024-01-06 skia-flutter-autoroll@skia.org Roll Skia from 514dd58cabfc to 3547cf9793f4 (1 revision) (flutter/engine#49577)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d0482116

Roll Flutter Engine from fcb40168f159 to 8d1789a43319 (1 revision) (#141053) · e0f94412

engine-flutter-autoroll authored Jan 06, 2024

https://github.com/flutter/engine/compare/fcb40168f159...8d1789a43319

2024-01-06 skia-flutter-autoroll@skia.org Roll Skia from 38c029ddd665 to 514dd58cabfc (1 revision) (flutter/engine#49575)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e0f94412