Commits · 4b74232a7062cd09ad137f2f1991cdfd7143730d · abdullh.alsoleman / Front-End

30 Apr, 2023 5 commits

Roll Flutter Engine from f234d5e1dd26 to d76a22e67eea (1 revision) (#125776) · 4b74232a

engine-flutter-autoroll authored Apr 30, 2023

https://github.com/flutter/engine/compare/f234d5e1dd26...d76a22e67eea

2023-04-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from RzN-C9ZpB2ZsMq9Sn... to FV1Uu3faXL2llmvaU... (flutter/engine#41624)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from RzN-C9ZpB2Zs to FV1Uu3faXL2l

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4b74232a

Roll Flutter Engine from c796390d14cb to f234d5e1dd26 (1 revision) (#125773) · e9b9d0fb

engine-flutter-autoroll authored Apr 30, 2023

https://github.com/flutter/engine/compare/c796390d14cb...f234d5e1dd26

2023-04-30 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from R1rpDA1v0caZl5BFC... to uU98Ene2OeSVt21X_... (flutter/engine#41623)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from R1rpDA1v0caZ to uU98Ene2OeSV

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e9b9d0fb

Roll Flutter Engine from e99f31f4437d to c796390d14cb (1 revision) (#125762) · 9241329b

engine-flutter-autoroll authored Apr 30, 2023

https://github.com/flutter/engine/compare/e99f31f4437d...c796390d14cb

2023-04-30 skia-flutter-autoroll@skia.org Roll Skia from e98b3f40fbf2 to 5a7d7da47c10 (1 revision) (flutter/engine#41622)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9241329b

Roll Flutter Engine from 1942b0c2cd9a to e99f31f4437d (1 revision) (#125758) · 3ed5f512

engine-flutter-autoroll authored Apr 30, 2023

https://github.com/flutter/engine/compare/1942b0c2cd9a...e99f31f4437d

2023-04-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from uapMevjPUC6e5zepp... to RzN-C9ZpB2ZsMq9Sn... (flutter/engine#41621)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from uapMevjPUC6e to RzN-C9ZpB2Zs

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3ed5f512

Roll Flutter Engine from 7806f8a4fb4c to 1942b0c2cd9a (1 revision) (#125757) · 9fa34e82

engine-flutter-autoroll authored Apr 30, 2023

https://github.com/flutter/engine/compare/7806f8a4fb4c...1942b0c2cd9a

2023-04-30 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from tz8A3SWVI56hqwnzp... to R1rpDA1v0caZl5BFC... (flutter/engine#41620)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from tz8A3SWVI56h to R1rpDA1v0caZ

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9fa34e82

29 Apr, 2023 13 commits

Roll Flutter Engine from 8167f909bc8d to 7806f8a4fb4c (2 revisions) (#125750) · 845c12fb

engine-flutter-autoroll authored Apr 29, 2023

https://github.com/flutter/engine/compare/8167f909bc8d...7806f8a4fb4c

2023-04-29 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from FUOS_QWwsi0RMumuZ... to uapMevjPUC6e5zepp... (flutter/engine#41618)
2023-04-29 skia-flutter-autoroll@skia.org Roll Skia from 3a037528ab83 to e98b3f40fbf2 (2 revisions) (flutter/engine#41619)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from FUOS_QWwsi0R to uapMevjPUC6e

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

845c12fb

Roll Flutter Engine from 900b8a89b73b to 8167f909bc8d (1 revision) (#125748) · b319b141

engine-flutter-autoroll authored Apr 29, 2023

https://github.com/flutter/engine/compare/900b8a89b73b...8167f909bc8d

2023-04-29 jason-simmons@users.noreply.github.com Exclude Skia's Vello directory from the license crawl (flutter/engine#41617)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b319b141

Roll Flutter Engine from c56ea398b0dc to 900b8a89b73b (1 revision) (#125747) · 29b3e66e

engine-flutter-autoroll authored Apr 29, 2023

https://github.com/flutter/engine/compare/c56ea398b0dc...900b8a89b73b

2023-04-29 jason-simmons@users.noreply.github.com Manual roll of Dart SDK from e8b86b073413 to 823a69e2a34d (flutter/engine#41614)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

29b3e66e

Roll Flutter Engine from 0834c886f06a to c56ea398b0dc (1 revision) (#125746) · 807c55c6

engine-flutter-autoroll authored Apr 29, 2023

https://github.com/flutter/engine/compare/0834c886f06a...c56ea398b0dc

2023-04-29 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from XeUTCh70VOPbIFXdz... to tz8A3SWVI56hqwnzp... (flutter/engine#41615)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from XeUTCh70VOPb to tz8A3SWVI56h

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

807c55c6

Roll Flutter Engine from 68f2ed0a1db5 to 0834c886f06a (1 revision) (#125736) · 14981ffc

engine-flutter-autoroll authored Apr 29, 2023

https://github.com/flutter/engine/compare/68f2ed0a1db5...0834c886f06a

2023-04-29 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from xfKYQ2vkoLvxhBHIf... to FUOS_QWwsi0RMumuZ... (flutter/engine#41611)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from xfKYQ2vkoLvx to FUOS_QWwsi0R

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

14981ffc

Roll Flutter Engine from 0079bb4a20d0 to 68f2ed0a1db5 (1 revision) (#125735) · b5a1d9c5

engine-flutter-autoroll authored Apr 29, 2023

https://github.com/flutter/engine/compare/0079bb4a20d0...68f2ed0a1db5

2023-04-29 skia-flutter-autoroll@skia.org Roll Skia from c7b3371bcd48 to 3a037528ab83 (2 revisions) (flutter/engine#41609)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b5a1d9c5

Fix crasher in DragableScrollableSheet when controller is animating and switching widgets (#125721) · e1e8ad80

Dan Field authored Apr 29, 2023

We were failing to dispose of animation controllers created by `animateTo` when `didUpdateWidget` happens and we null out the `_attachedController`. This would cause the listener added here to fail on a null assertion:

https://github.com/flutter/flutter/blob/fef41cfce0e3582907f6846cf2385470bb17ecd1/packages/flutter/lib/src/widgets/draggable_scrollable_sheet.dart#L135

Without the code change, the test ends up throwing exceptions related to that line. I don't have a great way to verify what this does visually though, hoping for help on that from internal customer.

b/279930163

See cl/527868355 as well.

Fixes https://github.com/flutter/flutter/issues/125709

e1e8ad80

Roll Flutter Engine from 8f04b29c1b98 to 0079bb4a20d0 (2 revisions) (#125734) · 9417b2a4

engine-flutter-autoroll authored Apr 29, 2023

https://github.com/flutter/engine/compare/8f04b29c1b98...0079bb4a20d0

2023-04-29 737941+loic-sharma@users.noreply.github.com Remove single view assumption from pointer events (flutter/engine#41602)
2023-04-29 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from kNDuhglIFq_xEt5n3... to XeUTCh70VOPbIFXdz... (flutter/engine#41608)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from kNDuhglIFq_x to XeUTCh70VOPb

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9417b2a4

Roll Flutter Engine from 788d0ed5ed06 to 8f04b29c1b98 (1 revision) (#125731) · bd85177d

engine-flutter-autoroll authored Apr 29, 2023

https://github.com/flutter/engine/compare/788d0ed5ed06...8f04b29c1b98

2023-04-29 bdero@google.com [Impeller] Remove destructive blend mode check from Contents::ShouldRender (flutter/engine#41600)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bd85177d

Roll Flutter Engine from 89a8affdced0 to 788d0ed5ed06 (1 revision) (#125729) · 0ff36a1e

engine-flutter-autoroll authored Apr 29, 2023

https://github.com/flutter/engine/compare/89a8affdced0...788d0ed5ed06

2023-04-29 skia-flutter-autoroll@skia.org Roll Skia from 49412cbee072 to c7b3371bcd48 (7 revisions) (flutter/engine#41603)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0ff36a1e

Roll Flutter Engine from 3835d975c8b0 to 89a8affdced0 (2 revisions) (#125725) · 47f4d1a9

engine-flutter-autoroll authored Apr 29, 2023

https://github.com/flutter/engine/compare/3835d975c8b0...89a8affdced0

2023-04-28 skia-flutter-autoroll@skia.org Roll Skia from 9867fa253064 to 49412cbee072 (13 revisions) (flutter/engine#41597)
2023-04-28 godofredoc@google.com Migrate desktop artifacts to engine v2. (flutter/engine#41599)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

47f4d1a9

Roll Flutter Engine from 1ae848ce6b55 to 3835d975c8b0 (1 revision) (#125722) · 6f85ff6b

engine-flutter-autoroll authored Apr 29, 2023

https://github.com/flutter/engine/compare/1ae848ce6b55...3835d975c8b0

2023-04-28 jason-simmons@users.noreply.github.com [Impeller] Ensure that embedded blobs are placed at aligned addresses. (flutter/engine#41526)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6f85ff6b

fix package template create platform folders (#125292) · 512e2c3f

Anas authored Apr 29, 2023

`package` template should not create platform folders. This happen cause by default all platforms are supported and tools didn't distinguish between package and other template, which makes all platforms are true for below code,
https://github.com/flutter/flutter/blob/d186792c00f61149916f685e2975300342f64749/packages/flutter_tools/lib/src/project.dart#L374-L380

fixes: #119844 which make #116320 makes invalid. As for why tools created deprecated `Android Embedding`, `appManifestFile` does not exist for `package` template, which make below code to trigger,
https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/project.dart#L768-L770

This does not happen with `module` and `plugin` as it have specific condition check for them. I try to reproduce it with `app` template but didn't succeed

512e2c3f

28 Apr, 2023 17 commits

Sliver Cross Axis Group (#123862) · 1a0b03cb

Tae Hyung Kim authored Apr 28, 2023

This widget implements the ability to place slivers side by side in a single ScrollView so that they scroll together. The design document for `SliverCrossAxisGroup` can be found [here](https://docs.google.com/document/d/1e2bdLSYV_Dq2h8aHpF8mda67aOmZocPiMyjCcTTZhTg/edit?resourcekey=0-Xj2X2XA3CAFae22Sv3hAiA).

Fixes #56756.

1a0b03cb

Roll Flutter Engine from 2a84ea55e4ef to 1ae848ce6b55 (1 revision) (#125718) · 2282eb36

engine-flutter-autoroll authored Apr 28, 2023

https://github.com/flutter/engine/compare/2a84ea55e4ef...1ae848ce6b55

2023-04-28 skia-flutter-autoroll@skia.org Roll Dart SDK from 8e9bf2bb9878 to e8b86b073413 (1 revision) (flutter/engine#41594)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2282eb36

Remove bringup from new_gallery_skia_ios__transition_perf (#125715) · fef41cfc
Zachary Anderson authored Apr 28, 2023
```
Final step of https://github.com/flutter/flutter/pull/125663
```
fef41cfc

Roll Flutter Engine from 98b6fabc66bb to 2a84ea55e4ef (10 revisions) (#125714) · 63b7fa5d

engine-flutter-autoroll authored Apr 28, 2023

https://github.com/flutter/engine/compare/98b6fabc66bb...2a84ea55e4ef

2023-04-28 zanderso@users.noreply.github.com Revert "Replace deprecated and internal Skia EncodedImage calls with public versions" (flutter/engine#41595)
2023-04-28 maruel@gmail.com Roll buildroot to c96c9d4641714301fab450a5f3b0f3c42712e1e3 (flutter/engine#41589)
2023-04-28 ychris@google.com [platform_view] Only dispose view when it is removed from the composition order (flutter/engine#41521)
2023-04-28 gspencergoog@users.noreply.github.com Determine lifecycle by looking at window focus also (flutter/engine#41094)
2023-04-28 zanderso@users.noreply.github.com Increase timeout for clang-tidy on mac (flutter/engine#41588)
2023-04-28 bdero@google.com [Impeller] Always enable validation for goldens (flutter/engine#41574)
2023-04-28 maruel@gmail.com fuchsia: do not read version_history.json (flutter/engine#41585)
2023-04-28 skia-flutter-autoroll@skia.org Roll Dart SDK from c7160d4ea0b7 to 8e9bf2bb9878 (5 revisions) (flutter/engine#41586)
2023-04-28 kjlubick@users.noreply.github.com Replace deprecated and internal Skia EncodedImage calls with public versions (flutter/engine#41368)
2023-04-28 skia-flutter-autoroll@skia.org Roll Skia from 05d09f28250a to 9867fa253064 (18 revisions) (flutter/engine#41584)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

63b7fa5d

Opt into CMake policy CMP0135 (#125502) · 7d37f2a6

yaakovschectman authored Apr 28, 2023

~Update the windows app template and migration to use `CMP0135` when
cmake version is >= 3.24.~

Update app templates' and examples' CMakeLists.txt to use
`cmake_policy(VERSION`. https://github.com/flutter/packages/pull/3828
should obviate the need for a migration.

Addresses https://github.com/flutter/flutter/issues/116866

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

7d37f2a6

Add a channel to query the engine keyboard state (#122885) · af050d95

Bruno Leroux authored Apr 28, 2023

## Description

This PR adds a new channel to query the engine keyboard state.
See https://github.com/flutter/flutter/issues/87391#issuecomment-1228975571 for motivation. 

## Related Issue

Framework side implementation for https://github.com/flutter/flutter/issues/87391.

Once approved the framework will try to query the initial keyboard state from the engine. PRs will be needed on the engine side to answer the framework query.

## Tests

Adds 1 test.

af050d95

Roll pub packages (#125698) · 73a343f1
Flutter GitHub Bot authored Apr 28, 2023
```
This PR was generated by `flutter update-packages --force-upgrade`.
```
73a343f1
`Checkbox.fillColor` should be applied to checkbox's background color when it... · a433f88d
Qun Cheng authored Apr 28, 2023
```
`Checkbox.fillColor` should be applied to checkbox's background color when it is unchecked. (#125643)
```
a433f88d
Add back one Skia test on iOS (#125663) · 50f83fc2
Zachary Anderson authored Apr 28, 2023
```
Fixes https://github.com/flutter/flutter/issues/125648
```
50f83fc2
Roll pub packages (#125447) · 888b208d
Flutter GitHub Bot authored Apr 28, 2023
```
This PR was generated by `flutter update-packages --force-upgrade`.
```
888b208d

Nit: grammar in documentation (#125462) · 69af9343

Phlippie Bosman authored Apr 28, 2023

Fixes a [grocer's apostrophe](https://www.grammar-monster.com/lessons/apostrophe_error_with_plurals.htm). 

Apostrophes are not used to indicate plurals, and this incorrect usage in the documentation tripped me up, so I figured I could submit a quick correction :)

69af9343

Roll Flutter Engine from 1d25906b4cf0 to 98b6fabc66bb (4 revisions) (#125690) · a698da60

engine-flutter-autoroll authored Apr 28, 2023

https://github.com/flutter/engine/compare/1d25906b4cf0...98b6fabc66bb

2023-04-28 godofredoc@google.com Migrate Linux Arm Host Engine to engine v2. (flutter/engine#41555)
2023-04-28 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Rk2iPE0_H1vjuGV4e... to kNDuhglIFq_xEt5n3... (flutter/engine#41582)
2023-04-28 bdero@google.com [Impeller] Manage the onscreen stencil in EntityPass (flutter/engine#41563)
2023-04-28 bdero@google.com Revert "Reland: [Impeller] Use a device buffer for SkBitmap allocation, use Linear texture on Metal backend. " (flutter/engine#41567)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from Rk2iPE0_H1vj to kNDuhglIFq_x

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a698da60

Allow users to provide route settings to `showMenu` (#124935) · 00bbf543

fzyzcjy authored Apr 28, 2023

Background: I am adding logging to things like dialogs, bottom sheets and menus. Then I realized that, showMenu does not allow users to provide RouteSettings, while showDialog and showModalBottomSheet both allow. Therefore, IMHO a consistent API design may need to add this to showMenu.

I will add tests if this proposal looks OK :)

00bbf543

enhances OverlayEntry docs (#124478) · 5a1ef73d
Viren Khatri authored Apr 28, 2023
```
Fixes https://github.com/flutter/flutter/issues/123218
```
5a1ef73d

Smallest change required to support host apps using agp 8.0 (#125657) · 3a6c4eb1

Reid Baker authored Apr 28, 2023

Testing AGP 8.0 is not possible with the existing infra because of the java version on CI machines. See https://github.com/flutter/flutter/issues/125325 for more details.

https://github.com/flutter/flutter/issues/125181

3a6c4eb1

fix RangeSlider, with no overlayShape shifts to the left (#125483) · f87d2087
arvin authored Apr 28, 2023

f87d2087

Roll Flutter Engine from 3d61e293cb96 to 1d25906b4cf0 (1 revision) (#125658) · 55c988fb

engine-flutter-autoroll authored Apr 28, 2023

https://github.com/flutter/engine/compare/3d61e293cb96...1d25906b4cf0

2023-04-27 skia-flutter-autoroll@skia.org Roll Skia from f7c8a58c2127 to 05d09f28250a (4 revisions) (flutter/engine#41557)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

55c988fb

27 Apr, 2023 5 commits

Increase Xcode minimum version to 14 (#125639) · 6b73885e

Jenn Magder authored Apr 27, 2023

Looks like CocoaPods 1.12.1 is incompatible with < Xcode 14 due to https://github.com/CocoaPods/CocoaPods/pull/11828 (see https://github.com/flutter/flutter/issues/123890 for context).

Bump the minimum Xcode version allowed by tooling to 14, released September 2022.

```
[!] Xcode - develop for iOS and macOS (Xcode 13.4)
    â Flutter requires Xcode 14 or higher.
      Download the latest version or update via the Mac App Store.
```

Fixes https://github.com/flutter/flutter/issues/125286.
Previous bump at #97746.

6b73885e

Add migrator to upgrade gradle version when conflict with Android Studio... · eba2a520

gmackall authored Apr 27, 2023

Add migrator to upgrade gradle version when conflict with Android Studio bundled Java version is detected (#124085)

This PR adds an android project migrator that checks the version of android studio and the version of gradle for conflicts, and upgrades to 7.4 if a conflict is detected. For more detail about the particular conflict, see https://github.com/flutter/flutter/issues/122376.

The PR also upgrades older gradle versions being used in integration testing to 7.4.

Fixes/related to: https://github.com/flutter/flutter/issues/122376 and https://github.com/flutter/flutter/issues/123636

eba2a520

Update dartdoc to v6.2.2. (#125650) · fb36bba3

Janice Collins authored Apr 27, 2023

This PR updates the dartdoc version to v6.2.2.

Release notes:  https://github.com/dart-lang/dartdoc/releases/tag/v6.2.2

The main impact for Flutter is to update dartdoc to add chips to class and/or mixin pages for class modifiers.  See dart-lang/dartdoc#3391, dart-lang/dartdoc#3402.   This will also be a cherry-pick candidate for 3.1 if it can land in time.

- [ test-exempt ] I added new tests to check the change I am making, or this PR is [test-exempt].

fb36bba3

Add `slider_perf_android` task to `ci.yaml` (#125540) · 746cacc5

Taha Tesser authored Apr 27, 2023

This adds `devicelab` task `slider_perf_android` to `.ci.yaml`, which was added in https://github.com/flutter/flutter/pull/125296

746cacc5

Roll Flutter Engine from 883bb7d5cb28 to 3d61e293cb96 (1 revision) (#125645) · 215fa355

engine-flutter-autoroll authored Apr 27, 2023

https://github.com/flutter/engine/compare/883bb7d5cb28...3d61e293cb96

2023-04-27 skia-flutter-autoroll@skia.org Roll Skia from 8441d7a93942 to f7c8a58c2127 (10 revisions) (flutter/engine#41556)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

215fa355