Commits · 48c1c2313abfe1a550d563ca9fca2bb54ce87b6e · abdullh.alsoleman / Front-End

16 Mar, 2024 12 commits

Reverts "Reland #128236 "Improve build output for all platforms" (#143166)" (#145261) · 48c1c231

auto-submit[bot] authored Mar 16, 2024

Reverts: flutter/flutter#143166
Initiated by: guidezpl
Reason for reverting: breaks devicelab windows tests
Original PR Author: guidezpl

Reviewed By: {loic-sharma}

This change reverts the following previous change:
Reland #128236, reverted in https://github.com/flutter/flutter/pull/143125.

This PR contains [one additional commit](https://github.com/flutter/flutter/pull/143166/commits/199baea9a99bc905e72d2b069259498dd8f7defd), fixing the 2 failed tests.

## Original description

Improves the build output:

1. Gives confirmation that the build succeeded, in green
1. Gives the path to the built executable, without a trailing period to make it slightly easier to cmd/ctrl+open
1. Gives the size of the built executable (when the built executable is self contained) 

### `apk`, `appbundle` 

<img width="607" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ecc52abe-cd2e-4116-b22a-8385ae3e980d">

<img width="634" alt="image" src="https://github.com/flutter/flutter/assets/6655696/8af8bd33-c0bd-4215-9a06-9652ee019436">

### `macos`, `ios`, `ipa`
Build executables are self-contained and use a newly introduced `OperatingSystemUtils.getDirectorySize`.

<img width="514" alt="image" src="https://github.com/flutter/flutter/assets/6655696/b5918a69-3959-4417-9205-4f501d185257">

<img width="581" alt="image" src="https://github.com/flutter/flutter/assets/6655696/d72fd420-18cf-4470-9e4b-b6ac10fbcd50">

<img width="616" alt="image" src="https://github.com/flutter/flutter/assets/6655696/5f235ce1-252a-4c13-898f-139f6c7bc698">

### `windows`, `linux`, and `web`
Build executables aren't self-contained, and folder size can sometimes overestimate distribution size, therefore their size isn't mentioned (see discussion below).

<img width="647" alt="image" src="https://github.com/flutter/flutter/assets/6655696/7179e771-1eb7-48f6-b770-975bc073437b">

<img width="658" alt="image" src="https://github.com/flutter/flutter/assets/6655696/a6801cab-7b5a-4975-a406-f4c9fa44d7a2">

<img width="608" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ee7c4125-a273-4a65-95d7-ab441edf8ac5">

### Size reporting
When applicable, the printed size matches the OS reported size.

- macOS
    <img width="391" alt="image" src="https://github.com/flutter/flutter/assets/6655696/881cbfb1-d355-444b-ab44-c1a6343190ce">
- Windows
    <img width="338" alt="image" src="https://github.com/flutter/flutter/assets/6655696/3b806def-3d15-48a9-8a25-df200d6feef7">
- Linux   
    <img width="320" alt="image" src="https://github.com/flutter/flutter/assets/6655696/89a4aa3d-2148-4f3b-b231-f93a057fee2b">

## Related issues
Part of #120127
Fixes https://github.com/flutter/flutter/issues/121401

48c1c231

Reland #128236 "Improve build output for all platforms" (#143166) · 2fc76c78

Pierre-Louis authored Mar 16, 2024

Reland #128236, reverted in https://github.com/flutter/flutter/pull/143125.

This PR contains [one additional commit](https://github.com/flutter/flutter/pull/143166/commits/199baea9a99bc905e72d2b069259498dd8f7defd), fixing the 2 failed tests.

## Original description

Improves the build output:

1. Gives confirmation that the build succeeded, in green
1. Gives the path to the built executable, without a trailing period to make it slightly easier to cmd/ctrl+open
1. Gives the size of the built executable (when the built executable is self contained) 

### `apk`, `appbundle` 

<img width="607" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ecc52abe-cd2e-4116-b22a-8385ae3e980d">

<img width="634" alt="image" src="https://github.com/flutter/flutter/assets/6655696/8af8bd33-c0bd-4215-9a06-9652ee019436">

### `macos`, `ios`, `ipa`
Build executables are self-contained and use a newly introduced `OperatingSystemUtils.getDirectorySize`.

<img width="514" alt="image" src="https://github.com/flutter/flutter/assets/6655696/b5918a69-3959-4417-9205-4f501d185257">

<img width="581" alt="image" src="https://github.com/flutter/flutter/assets/6655696/d72fd420-18cf-4470-9e4b-b6ac10fbcd50">

<img width="616" alt="image" src="https://github.com/flutter/flutter/assets/6655696/5f235ce1-252a-4c13-898f-139f6c7bc698">

### `windows`, `linux`, and `web`
Build executables aren't self-contained, and folder size can sometimes overestimate distribution size, therefore their size isn't mentioned (see discussion below).

<img width="647" alt="image" src="https://github.com/flutter/flutter/assets/6655696/7179e771-1eb7-48f6-b770-975bc073437b">

<img width="658" alt="image" src="https://github.com/flutter/flutter/assets/6655696/a6801cab-7b5a-4975-a406-f4c9fa44d7a2">

<img width="608" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ee7c4125-a273-4a65-95d7-ab441edf8ac5">

### Size reporting
When applicable, the printed size matches the OS reported size.

- macOS
    <img width="391" alt="image" src="https://github.com/flutter/flutter/assets/6655696/881cbfb1-d355-444b-ab44-c1a6343190ce">
- Windows
    <img width="338" alt="image" src="https://github.com/flutter/flutter/assets/6655696/3b806def-3d15-48a9-8a25-df200d6feef7">
- Linux   
    <img width="320" alt="image" src="https://github.com/flutter/flutter/assets/6655696/89a4aa3d-2148-4f3b-b231-f93a057fee2b">

## Related issues
Part of #120127
Fixes https://github.com/flutter/flutter/issues/121401

2fc76c78

Introduce `Split` curve (#143130) · 3109b111

Pierre-Louis authored Mar 16, 2024

`Split` is a curve that progresses according to `beginCurve` until
`split`, then according to `endCurve`.

This curve is used with bottom sheets to allow linear finger dragging
and non-linear enter/exit animations. This PR cleans up a previously
private class I introduced and replaces it with the more customisable
`Split`.

Fixes https://github.com/flutter/flutter/issues/51627

Diagram to be added with
https://github.com/flutter/assets-for-api-docs/pull/239

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

3109b111

Roll Flutter Engine from 120e52b8a1c2 to 91b9cf24d328 (1 revision) (#145256) · 988bee80

engine-flutter-autoroll authored Mar 16, 2024

https://github.com/flutter/engine/compare/120e52b8a1c2...91b9cf24d328

2024-03-16 skia-flutter-autoroll@skia.org Roll Skia from 05e1b6675da4 to 28701a2820eb (1 revision) (flutter/engine#51468)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

988bee80

Roll Flutter Engine from 3abc25139959 to 120e52b8a1c2 (1 revision) (#145254) · 360d46fa

engine-flutter-autoroll authored Mar 16, 2024

https://github.com/flutter/engine/compare/3abc25139959...120e52b8a1c2

2024-03-16 skia-flutter-autoroll@skia.org Roll Skia from 2d46a81facd8 to 05e1b6675da4 (1 revision) (flutter/engine#51467)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

360d46fa

Roll Flutter Engine from 6f180615e6ac to 3abc25139959 (1 revision) (#145253) · 483aa35c

engine-flutter-autoroll authored Mar 16, 2024

https://github.com/flutter/engine/compare/6f180615e6ac...3abc25139959

2024-03-16 skia-flutter-autoroll@skia.org Roll Dart SDK from 2241333f69f3 to 934c41c1c18e (1 revision) (flutter/engine#51465)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

483aa35c

Platform view devicelab ad banner scroll list real ads (#145239) · a2678be7

Jenn Magder authored Mar 16, 2024

Reland https://github.com/flutter/flutter/pull/144745, which was reverted due to a the Android app ads not being set up correctly, crashing on launch: https://github.com/flutter/flutter/pull/145228

Add the missing [`com.google.android.gms.ads.APPLICATION_ID` `meta-data` tag](https://developers.google.com/admob/android/quick-start#import_the_mobile_ads_sdk) to the manifest.

Validated both `platform_views_scroll_perf__timeline_summary` and `platform_views_scroll_perf_impeller__timeline_summary` ran locally on an Android emulator.

Successful presubmit runs:
https://ci.chromium.org/ui/p/flutter/builders/try/Linux_pixel_7pro%20platform_views_scroll_perf__timeline_summary/4/overview
https://ci.chromium.org/ui/p/flutter/builders/try/Linux_pixel_7pro%20platform_views_scroll_perf_impeller__timeline_summary/4/overview

Original commit message:
_________
This benchmark is to measure the platform view performance improvement. 

It is similar to https://github.com/lucalooz/flutter_ads_list_perf

There's still a pending issue https://github.com/flutter/flutter/issues/144339

Fixes https://github.com/flutter/flutter/issues/143534
Fixes https://github.com/flutter/flutter/issues/143257

a2678be7

Roll Flutter Engine from 6ddaa40bf1a6 to 6f180615e6ac (1 revision) (#145251) · 75996665

engine-flutter-autoroll authored Mar 16, 2024

https://github.com/flutter/engine/compare/6ddaa40bf1a6...6f180615e6ac

2024-03-16 flar@google.com Silence gn warning about unused Skia flag (flutter/engine#51464)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

75996665

Roll Flutter Engine from d46c1fa17dda to 6ddaa40bf1a6 (1 revision) (#145250) · 33bf4757

engine-flutter-autoroll authored Mar 16, 2024

https://github.com/flutter/engine/compare/d46c1fa17dda...6ddaa40bf1a6

2024-03-16 flar@google.com Reland "Add DisplayList Region and Transform benchmarks to CI" (flutter/engine#51458)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

33bf4757

Roll Flutter Engine from 7f15dc1200bc to d46c1fa17dda (2 revisions) (#145248) · 2ac7b95a

engine-flutter-autoroll authored Mar 16, 2024

https://github.com/flutter/engine/compare/7f15dc1200bc...d46c1fa17dda

2024-03-16 skia-flutter-autoroll@skia.org Roll Dart SDK from 03cc4d817056 to 2241333f69f3 (2 revisions) (flutter/engine#51461)
2024-03-16 chinmaygarde@google.com Re-land "[Impeller] A toolkit for managed handles to Android NDK vended objects." (flutter/engine#51460)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2ac7b95a

Use a separate `TextPainter` for intrinsics calculation in `RenderEditable`... · cc017017

LongCatIsLooong authored Mar 16, 2024

Use a separate `TextPainter` for intrinsics calculation in `RenderEditable` and `RenderParagraph` (#144577)

Use a dedicated `TextPainter` for intrinsic size calculation in `RenderEditable` and `RenderParagraph`.

This is an implementation detail so the change should be covered by existing tests. Performance wise this shouldn't be significantly slower since SkParagraph [caches the result of slower operations across different paragraphs](https://github.com/google/skia/blob/9c62e7b382cf387195ef82895530c97ccceda690/modules/skparagraph/src/ParagraphCache.cpp#L254-L272). Existing benchmarks should be able to catch potential regressions (??).

The reason for making this change is to make sure that intrinsic size computations don't destroy text layout artifacts, so I can expose the text layout as a stream of immutable `TextLayout` objects, to signify other render objects that text-layout-dependent-cache (such as caches for `getBoxesForRange` which can be relatively slow to compute) should be invalidated and `markNeedsPaint` needs to be called if the painting logic depended on text layout.
Without this change, the intrinsics/dry layout calculations will add additional events to the text layout stream, which violates the "dry"/non-destructive contract.

cc017017

Roll Flutter Engine from 2db915c64e6e to 7f15dc1200bc (1 revision) (#145245) · 15e90ad2

engine-flutter-autoroll authored Mar 16, 2024

https://github.com/flutter/engine/compare/2db915c64e6e...7f15dc1200bc

2024-03-15 skia-flutter-autoroll@skia.org Roll Skia from 11b1a958c2ac to 2d46a81facd8 (11 revisions) (flutter/engine#51459)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

15e90ad2

15 Mar, 2024 16 commits

Roll Flutter Engine from ba1115c30381 to 2db915c64e6e (2 revisions) (#145240) · 20105db1

engine-flutter-autoroll authored Mar 15, 2024

https://github.com/flutter/engine/compare/ba1115c30381...2db915c64e6e

2024-03-15 737941+loic-sharma@users.noreply.github.com [Windows] Move to new present callback (flutter/engine#51293)
2024-03-15 matanlurey@users.noreply.github.com Log messages when an image successfully uploads to Skia Gold (flutter/engine#51455)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

20105db1

Roll Flutter Engine from c2fd5333a5d2 to ba1115c30381 (3 revisions) (#145237) · 55d8b20d

engine-flutter-autoroll authored Mar 15, 2024

https://github.com/flutter/engine/compare/c2fd5333a5d2...ba1115c30381

2024-03-15 matanlurey@users.noreply.github.com Add more explicit logging (just to `stderr`) if a try-job detects an untriaged image (flutter/engine#51454)
2024-03-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] A toolkit for managed handles to Android NDK vended objects. (#51334)" (flutter/engine#51457)
2024-03-15 chinmaygarde@google.com [Impeller] A toolkit for managed handles to Android NDK vended objects. (flutter/engine#51334)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

55d8b20d

Renaming the virtual device Nexus5 name to Nexus5.gce_x86 (#145225) · 1c153c38

yusuf-goog authored Mar 15, 2024

This is required to match a rename being made for the devices in firebase lab.

Also removed `version=24` entry, since thats not supported on Nexus5x, per the firebase team.

Bug:b/322830672

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

1c153c38

Roll Flutter Engine from d107f65a8ee6 to c2fd5333a5d2 (4 revisions) (#145226) · 71606af8

engine-flutter-autoroll authored Mar 15, 2024

https://github.com/flutter/engine/compare/d107f65a8ee6...c2fd5333a5d2

2024-03-15 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Fix backdrop filter with platform views as children (flutter/engine#51442)
2024-03-15 skia-flutter-autoroll@skia.org Roll Skia from 54ecc23acf31 to 11b1a958c2ac (1 revision) (flutter/engine#51440)
2024-03-15 flar@google.com [DisplayList] Pre-Compute saveLayer bounds in DLBuilder (flutter/engine#50935)
2024-03-15 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from da-siZ7wPDA0Z0wXJ... to nTth7xxzAfENAJjMH... (flutter/engine#51446)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from da-siZ7wPDA0 to nTth7xxzAfEN

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

71606af8

Reverts "Reland: "Platform view devicelab ad banner scroll list real ads" (#145224)" (#145228) · ca2d4865

auto-submit[bot] authored Mar 15, 2024

Reverts: flutter/flutter#145224
Initiated by: hellohuanlin
Reason for reverting: breaks the tree
Original PR Author: hellohuanlin

Reviewed By: {gmackall, jmagman}

This change reverts the following previous change:
Reland https://github.com/flutter/flutter/pull/144745, which got reverted due to Android lockfile. Fixed by `dart dev/tools/bin/generate_gradle_lockfiles.dart`

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

Fixes https://github.com/flutter/flutter/issues/143534
Fixes https://github.com/flutter/flutter/issues/143257

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

ca2d4865

Roll Flutter Engine from 76f33eb0eced to d107f65a8ee6 (3 revisions) (#145223) · c770ca7e

engine-flutter-autoroll authored Mar 15, 2024

https://github.com/flutter/engine/compare/76f33eb0eced...d107f65a8ee6

2024-03-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 406955fe6950 to 03cc4d817056 (1 revision) (flutter/engine#51441)
2024-03-15 dnfield@google.com Add a pixel test to cover multiple clips with a BDF (flutter/engine#51431)
2024-03-15 72562119+tgucio@users.noreply.github.com Add missing baseline check in text layout tests (flutter/engine#51444)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c770ca7e

Reland: "Platform view devicelab ad banner scroll list real ads" (#145224) · da4d0e4f

hellohuanlin authored Mar 15, 2024

Reland https://github.com/flutter/flutter/pull/144745, which got reverted due to Android lockfile. Fixed by `dart dev/tools/bin/generate_gradle_lockfiles.dart`

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

Fixes https://github.com/flutter/flutter/issues/143534
Fixes https://github.com/flutter/flutter/issues/143257

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

da4d0e4f

Roll Flutter Engine from 1e199ce6239d to 76f33eb0eced (3 revisions) (#145221) · d113ee4c

engine-flutter-autoroll authored Mar 15, 2024

https://github.com/flutter/engine/compare/1e199ce6239d...76f33eb0eced

2024-03-15 skia-flutter-autoroll@skia.org Roll Skia from 52bb1539c5cf to 54ecc23acf31 (11 revisions) (flutter/engine#51438)
2024-03-15 matanlurey@users.noreply.github.com Add `android_debug_unopt_arm64` to `local_engine.json`. (flutter/engine#51427)
2024-03-15 matanlurey@users.noreply.github.com Remove the Android-drawn surface rendering from scenario_app. (flutter/engine#51433)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d113ee4c

Run gradle_plugin_*_apk_test on presubmit on flutter_tool changes. (#142090) · a97af209

Jackson Gardner authored Mar 15, 2024

These tests were failing in postsubmit after a change to `packages/flutter_tools`. We should run these in presubmit when `packages/flutter_tools` changes.

a97af209

Update a11y for SliverAppBar (#144437) · 58eb0e8a

hangyu authored Mar 15, 2024

1. Set cacheExtent for sliverAppBar so it's not dropped from the
semantics tree.
2. Update its toolbarOpacity in a11y mode to 1.0. When scrolling in a11y
mode and the focus is back to the sliverAppBar, the content should be
visible.
fixes: https://github.com/flutter/flutter/issues/143437


## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes

58eb0e8a

Roll Packages from b21c5424783a to 756dcc11180b (6 revisions) (#145214) · eeff96d4

engine-flutter-autoroll authored Mar 15, 2024

https://github.com/flutter/packages/compare/b21c5424783a...756dcc11180b

2024-03-15 32538273+ValentinVignal@users.noreply.github.com [go_router] Use `leak_tracker_flutter_testing` (flutter/packages#6210)
2024-03-15 10687576+bparrishMines@users.noreply.github.com [camera_web][google_maps_flutter] Fix tests throwing errors after test completion with manual roll (flutter/packages#6318)
2024-03-14 10687576+bparrishMines@users.noreply.github.com [pigeon] Fixes double prefixes added to enum names for Objc HostApis and FlutterApis (flutter/packages#6263)
2024-03-14 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android][webview_flutter_wkwebview] Adds platform implementations for onHttpError (flutter/packages#6149)
2024-03-14 34871572+gmackall@users.noreply.github.com [image_picker_android] Fix deprecation warnings by branching based on build version, and suppressing only when needed (flutter/packages#6233)
2024-03-14 30870216+gaaclarke@users.noreply.github.com [google_maps_flutter] Started dispatching platform messages from platform thread (flutter/packages#6069)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

eeff96d4

Roll pub packages manually (#145170) · 8d54abfc

Loïc Sharma authored Mar 15, 2024

The automated roll failed as a test needs to be updated: https://github.com/flutter/flutter/pull/145167

Fixes: https://github.com/flutter/flutter/issues/139861

8d54abfc

Roll Flutter Engine from 995d8903e074 to 1e199ce6239d (1 revision) (#145196) · 985576db

engine-flutter-autoroll authored Mar 15, 2024

https://github.com/flutter/engine/compare/995d8903e074...1e199ce6239d

2024-03-15 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Remove the use of //build/ in fuchsia (flutter/engine#51072)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

985576db

Roll Flutter Engine from 622b37282f20 to 995d8903e074 (8 revisions) (#145191) · 9b276be7

engine-flutter-autoroll authored Mar 15, 2024

https://github.com/flutter/engine/compare/622b37282f20...995d8903e074

2024-03-14 matanlurey@users.noreply.github.com Add some header-goodies for et. (flutter/engine#51434)
2024-03-14 jonahwilliams@google.com [Impeller] revert glyph atlas texture recycling. (flutter/engine#51428)
2024-03-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add DisplayList Region and Transform benchmarks to CI (#51429)" (flutter/engine#51432)
2024-03-14 flar@google.com Add DisplayList Region and Transform benchmarks to CI (flutter/engine#51429)
2024-03-14 skia-flutter-autoroll@skia.org Roll Dart SDK from 2bc8b222d01f to 70ca2323a702 (1 revision) (flutter/engine#51430)
2024-03-14 matanlurey@users.noreply.github.com Reduce code-duplication a bit and add more error context across `SkiaGoldClient`. (flutter/engine#51426)
2024-03-14 zanderso@users.noreply.github.com [et] build and run commands disable RBE with a flag or when not available (flutter/engine#51404)
2024-03-14 matej.knopp@gmail.com Fix flakiness in FlutterVSyncWaiterTest.VSyncWorks and FlutterDisplayLinkTest.WorkaroundForFB13482573 (flutter/engine#51405)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9b276be7

Roll Flutter Engine from 7b49dc9dd073 to 622b37282f20 (2 revisions) (#145179) · 60674fa3

engine-flutter-autoroll authored Mar 15, 2024

https://github.com/flutter/engine/compare/7b49dc9dd073...622b37282f20

2024-03-14 jonahwilliams@google.com [Impeller] revert round out. (flutter/engine#51395)
2024-03-14 kjlubick@users.noreply.github.com Remove always-true skia_enable_flutter_defines (flutter/engine#51423)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

60674fa3

Reverts "Platform view devicelab ad banner scroll list real ads (#144745)" (#145189) · 7f1c93d7

auto-submit[bot] authored Mar 15, 2024

Reverts: flutter/flutter#144745
Initiated by: gspencergoog
Reason for reverting: appears to have broken the build.

Original PR Author: hellohuanlin

Reviewed By: {jmagman, jonahwilliams}

This change reverts the following previous change:
This benchmark is to measure the platform view performance improvement. 

It is similar to https://github.com/lucalooz/flutter_ads_list_perf

There's still a pending issue https://github.com/flutter/flutter/issues/144339

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

Fixes https://github.com/flutter/flutter/issues/143534
Fixes https://github.com/flutter/flutter/issues/143257

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

7f1c93d7

14 Mar, 2024 12 commits

Platform view devicelab ad banner scroll list real ads (#144745) · be78542d

hellohuanlin authored Mar 14, 2024

This benchmark is to measure the platform view performance improvement. 

It is similar to https://github.com/lucalooz/flutter_ads_list_perf

There's still a pending issue https://github.com/flutter/flutter/issues/144339

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

Fixes https://github.com/flutter/flutter/issues/143534
Fixes https://github.com/flutter/flutter/issues/143257

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

be78542d

Implementing switch expressions in `flutter/test/` (#144580) · 17a27358
Nate authored Mar 14, 2024
```
Migrates test code to new `switch` syntax.
```
17a27358

Remove autofocus from the a11y_assessments app (#145117) · dff03432

Yegor authored Mar 14, 2024

As of https://github.com/flutter/engine/pull/47727 the web engine is able to find a default widget to focus on when a new route it pushed. The mobile engine already did that for some time. So `autofocus` is no longer necessary.

dff03432

Roll Flutter Engine from cc1e7d145067 to 7b49dc9dd073 (3 revisions) (#145176) · 5fb96272

engine-flutter-autoroll authored Mar 14, 2024

https://github.com/flutter/engine/compare/cc1e7d145067...7b49dc9dd073

2024-03-14 skia-flutter-autoroll@skia.org Roll Dart SDK from 749988e4d748 to 2bc8b222d01f (1 revision) (flutter/engine#51421)
2024-03-14 110993981+htoor3@users.noreply.github.com [web] - fix text editing IME composition interruption on geometry updates (flutter/engine#51323)
2024-03-14 flar@google.com Avoid unnecessary transform resets for pixel snapping (flutter/engine#51337)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5fb96272

Roll Flutter Engine from 41fce3f010c9 to cc1e7d145067 (1 revision) (#145164) · 2c5d3b05

engine-flutter-autoroll authored Mar 14, 2024

https://github.com/flutter/engine/compare/41fce3f010c9...cc1e7d145067

2024-03-14 30870216+gaaclarke@users.noreply.github.com [Impeller] started asserting golden test runner has fatal impeller validations (flutter/engine#51357)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2c5d3b05

Reverts "Fix TextField helper top padding on M3 (#145087)" (#145168) · bc611f56

auto-submit[bot] authored Mar 14, 2024

Reverts: flutter/flutter#145087
Initiated by: Jasguerrero
Reason for reverting: failing on accessibility checks b/329548765
Original PR Author: bleroux

Reviewed By: {justinmc}

This change reverts the following previous change:
## Description

`InputDecorator` adds a 8.0 gap beetween the container and the helper text.
From the Material 3 specification, this gap should be 4.0.
See https://m3.material.io/components/text-fields/specs#0c5c8d6d-2169-4d42-960c-51f6ee42eb57.

This PR sets the correct values for M3 without changing the value for M2.

| Before | After | M3 Spec |
|--------|--------|--------|
| ![image](https://github.com/flutter/flutter/assets/840911/9947f334-d98f-4f7e-9da7-ca6d5c0770ac) | ![image](https://github.com/flutter/flutter/assets/840911/081dec4b-eb9f-4eee-a7dc-2538e7110ff0)| ![image](https://github.com/flutter/flutter/assets/840911/c8c8f045-3b79-43a5-a1a3-cc6d5460644f) |

If this change is accepted, a future step will be to make this value configurable, probably by `InputDecorationTheme`.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/144984

## Tests

Updates a value used by several existing tests.

bc611f56

Roll Flutter Engine from 46993c1bf5bb to 41fce3f010c9 (1 revision) (#145160) · 20889dd8

engine-flutter-autoroll authored Mar 14, 2024

https://github.com/flutter/engine/compare/46993c1bf5bb...41fce3f010c9

2024-03-14 matanlurey@users.noreply.github.com Remove or replaced unused or duplicate code in `SkiaGoldClient`. (flutter/engine#51399)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

20889dd8

[framework] fix incorrect chinese localizations for Search Web and Share in... · 9f5fd75e

LouiseHsu authored Mar 14, 2024

[framework] fix incorrect chinese localizations for Search Web and Share in selection controls (#144857)

Fixes https://github.com/flutter/flutter/issues/144825

Corresponding translation suggestions:

https://tc.corp.google.com/btviewer/edittranslation?project=Flutter&msgId=7417055026368500447&language=zh-TW
(I accidentally pressed submit 3 times :( )

https://tc.corp.google.com/btviewer/edittranslation?project=Flutter&msgId=7417055026368500447&language=zh-HK

https://tc.corp.google.com/btviewer/edittranslation?project=Flutter&msgId=7417055026368500447&language=zh-CN

https://tc.corp.google.com/btviewer/edittranslation?project=Flutter&msgId=8883913494819754382&language=zh-CN

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [relevant style guides] and ran the
auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages
repo does use `dart format`.)
- [x] I signed the [CLA].
- [x] The title of the PR starts with the name of the package surrounded
by square brackets, e.g. `[shared_preferences]`
- [x] I [linked to at least one issue that this PR fixes] in the
description above.
- [x] I updated `pubspec.yaml` with an appropriate new version according
to the [pub versioning philosophy], or this PR is [exempt from version
changes].
- [x] I updated `CHANGELOG.md` to add a description of the change,
[following repository CHANGELOG style].
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

9f5fd75e

Asserts if a `TextPainter` gets disposed more than once (#145124) · a69567a3
LongCatIsLooong authored Mar 14, 2024
```
The overflow indicator was sharing the same `TextPainter`.
```
a69567a3

Roll Flutter Engine from 562d7a6e2861 to 46993c1bf5bb (2 revisions) (#145154) · 51d59a7d

engine-flutter-autoroll authored Mar 14, 2024

https://github.com/flutter/engine/compare/562d7a6e2861...46993c1bf5bb

2024-03-14 skia-flutter-autoroll@skia.org Roll Skia from f4ce9fc2ec45 to 52bb1539c5cf (1 revision) (flutter/engine#51415)
2024-03-14 skia-flutter-autoroll@skia.org Roll Dart SDK from d006b668dcb2 to 749988e4d748 (1 revision) (flutter/engine#51414)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

51d59a7d

Roll Packages from 38711aca66fa to b21c5424783a (5 revisions) (#145152) · 5b7d5cad

engine-flutter-autoroll authored Mar 14, 2024

https://github.com/flutter/packages/compare/38711aca66fa...b21c5424783a

2024-03-14 pageli328@gmail.com Support overriding `ErrorWidget.builder` (flutter/packages#6302)
2024-03-13 engine-flutter-autoroll@skia.org Manual roll Flutter from 61812ca3 to 394269f9 (6 revisions) (flutter/packages#6320)
2024-03-13 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.1 to 4.1.2 (flutter/packages#6309)
2024-03-13 magder@google.com Replace deprecated UIGraphicsBeginImageContextWithOptions with UIGraphicsImageRenderer (flutter/packages#6285)
2024-03-13 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.6 to 3.24.7 (flutter/packages#6310)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5b7d5cad

Roll Flutter Engine from 8fcff7b44480 to 562d7a6e2861 (1 revision) (#145148) · 3d5f7864

engine-flutter-autoroll authored Mar 14, 2024

https://github.com/flutter/engine/compare/8fcff7b44480...562d7a6e2861

2024-03-14 skia-flutter-autoroll@skia.org Roll Skia from 21186e265c39 to f4ce9fc2ec45 (1 revision) (flutter/engine#51413)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3d5f7864