https://github.com/flutter/engine/compare/453a04dbf891...f2ec263cebf9

2023-10-27 zanderso@users.noreply.github.com Move flatbuffers to flutter/third_party (flutter/engine#47387)
2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from ba3e1db468d0 to ebb2a3d4699b (10 revisions) (flutter/engine#47390)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

## Description

This PR adds a `nonce` parameter to flutter.js' `loadEntrypoint` method.

When set, loadEntrypoint will add a `nonce` attribute to the `main.dart.js` script tag, which allows Flutter to run in environments slightly more restricted by CSP; those that don't add `'self'` as a valid source for `script-src`.

----

### CSP directive

After this change, the CSP directive for a Flutter Web index.html can be:

```
script-src 'nonce-YOUR_NONCE_VALUE' 'wasm-unsafe-eval';
font-src https://fonts.gstatic.com;
style-src 'nonce-YOUR_NONCE_VALUE';
```

When CSP is set via a `meta` tag (like in the test accompanying this change), and to use a service worker, the CSP needs an additional directive: [`worker-src 'self';`](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/worker-src)

When CSP set via response headers, the CSP that applies to `flutter_service_worker.js` is determined by its response headers. See **Web Workers API > [Content security policy](https://developer.mozilla.org/en-US/docs/Web/API/Web_Workers_API/Using_web_workers#content_security_policy)** in MDN.)

----

### Initialization

If the CSP is set to disallow `script-src 'self'`, a nonce needs to also be passed to `loadEntrypoint`:

```javascript
  _flutter.loader.loadEntrypoint({
    nonce: 'SOME_NONCE',
    onEntrypointLoaded: (engineInitializer) async {
      const appRunner = await engineInitializer.initializeEngine({
        nonce: 'SOME_NONCE',
      });
      appRunner.runApp();
    },
  });
```

(`nonce` shows twice for now, because the entrypoint loader script doesn't have direct access to the `initializeEngine` call.)

----

## Tests

* Added a smoke test to ensure an app configured as described above starts.

## Issues

* Fixes https://github.com/flutter/flutter/issues/126977

https://github.com/flutter/engine/compare/1e66c0ae7bda...453a04dbf891

2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from fe9959acc5e0 to ba3e1db468d0 (1 revision) (flutter/engine#47382)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Latest example of an issue about a typo: https://github.com/flutter/flutter/issues/137080. I don't think these are helpful, so we shouldn't be encouraging people to file these in order to submit a PR to fix 'em.

https://github.com/flutter/engine/compare/0bba9eeb8f5d...1e66c0ae7bda

2023-10-27 30870216+gaaclarke@users.noreply.github.com Made FlutterTaskQueue visible for Swift. (flutter/engine#47348)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://github.com/flutter/engine/compare/a198ad4e740d...0bba9eeb8f5d

2023-10-27 zanderso@users.noreply.github.com Move shaderc to flutter/third_party (flutter/engine#47383)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Related to https://github.com/flutter/flutter/issues/137177

## Description

Adds some convenience methods to `KeyEvent` that allow testing to see if a logical or physical key is pressed from the event object. These are similar to the ones already on `RawKeyEvent`, and will make migration the to `KeyEvent` easier (so it could more easily be a `flutter fix` migration).

Added:

- `bool isLogicalKeyPressed(LogicalKeyboardKey key)`
- `bool isPhysicalKeyPressed(PhysicalKeyboardKey key)`
- `bool get isControlPressed`
- `bool get isShiftPressed`
- `bool get isAltPressed`
- `bool get isMetaPressed`

## Related Issues
 - https://github.com/flutter/flutter/issues/136419

## Tests
 - Added tests for the new methods.

Reverts flutter/flutter#136880
Initiated by: camsim99
This change reverts the following previous change:
Original Description:
Since the original PR that supposedly enabled proguard, it was using the android proguard rules that disable optimizations. See initial PR in [0]

This PR changes the flutter gradle plugin to use the `proguard-android-optimize.txt` (instead of `proguard-android.txt`) which will enable optimizations/shrinking of platform code (i.e. java/kotlin).

For a simple flutter hello world this results in a 25% reduction in the resulting DEX file (`classes.dex` of the APK).

[0] f098de1f

Fixes https://github.com/flutter/flutter/issues/136879

https://github.com/flutter/engine/compare/bedc49efc85c...a198ad4e740d

2023-10-27 jonahwilliams@google.com [Impeller] Add present wait latch. (flutter/engine#47311)
2023-10-27 zanderso@users.noreply.github.com Move rapidjson to flutter/third_party (flutter/engine#47354)
2023-10-27 jason-simmons@users.noreply.github.com [Impeller] Enable GLES MSAA only if the multisampled_render_to_texture2 extension is available (flutter/engine#47364)
2023-10-27 jason-simmons@users.noreply.github.com [Impeller] Fix leak of framebuffers used in GLES MSAA rendering (flutter/engine#47362)
2023-10-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual roll Dart SDK from 360370ff93b0 to 18678a3eddb7 (9 revisions)" (flutter/engine#47380)
2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from 0122c0e18d26 to fe9959acc5e0 (1 revision) (flutter/engine#47379)
2023-10-27 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 1ngqKBnmTtmFM6aBD... to fw9lcUvz8S07_zaAj... (flutter/engine#47377)
2023-10-27 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 37VxdxlPfdkek7mwC... to gPQSfYJVLOgXjxQce... (flutter/engine#47375)
2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from 22f5419438c4 to 0122c0e18d26 (1 revision) (flutter/engine#47373)
2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from 5262cbff56b1 to 22f5419438c4 (1 revision) (flutter/engine#47372)
2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from fe61b3467547 to 5262cbff56b1 (1 revision) (flutter/engine#47371)
2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from fbdd7d97b26e to fe61b3467547 (1 revision) (flutter/engine#47370)
2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from 2246f3473053 to fbdd7d97b26e (2 revisions) (flutter/engine#47369)
2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from ec4c6b3a6690 to 2246f3473053 (1 revision) (flutter/engine#47366)
2023-10-27 flar@google.com [Impeller] Add FilterContents::GetSourceCoverage to enable filtered saveLayer clipping. (flutter/engine#47183)
2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from bc8ca57868d2 to ec4c6b3a6690 (1 revision) (flutter/engine#47365)
2023-10-27 john@johnmccutchan.com Don't re-initialize the default RenderSurface when returning from hybrid composition mode (flutter/engine#47358)
2023-10-27 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 360370ff93b0 to 18678a3eddb7 (9 revisions) (flutter/engine#47357)
2023-10-26 skia-flutter-autoroll@skia.org Roll Skia from 93a0ad4d7ca6 to bc8ca57868d2 (2 revisions) (flutter/engine#47359)
2023-10-26 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from YSn00b0Trsu2vdhIq... to 1ngqKBnmTtmFM6aBD... (flutter/engine#47363)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 37VxdxlPfdke to gPQSfYJVLOgX
  fuchsia/sdk/core/mac-amd64 from YSn00b0Trsu2 to fw9lcUvz8S07

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Fixes https://github.com/flutter/flutter/issues/54665

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/bedc49efc85c...71e1a0430232

2023-10-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"Manual roll Dart SDK from 360370ff93b0 to 18678a3eddb7 (9 revisions)"
(flutter/engine#47380)
2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from 0122c0e18d26 to
fe9959acc5e0 (1 revision) (flutter/engine#47379)
2023-10-27 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
1ngqKBnmTtmFM6aBD... to fw9lcUvz8S07_zaAj... (flutter/engine#47377)
2023-10-27 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
37VxdxlPfdkek7mwC... to gPQSfYJVLOgXjxQce... (flutter/engine#47375)
2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from 22f5419438c4 to
0122c0e18d26 (1 revision) (flutter/engine#47373)
2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from 5262cbff56b1 to
22f5419438c4 (1 revision) (flutter/engine#47372)
2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from fe61b3467547 to
5262cbff56b1 (1 revision) (flutter/engine#47371)
2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from fbdd7d97b26e to
fe61b3467547 (1 revision) (flutter/engine#47370)
2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from 2246f3473053 to
fbdd7d97b26e (2 revisions) (flutter/engine#47369)
2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from ec4c6b3a6690 to
2246f3473053 (1 revision) (flutter/engine#47366)
2023-10-27 flar@google.com [Impeller] Add
FilterContents::GetSourceCoverage to enable filtered saveLayer clipping.
(flutter/engine#47183)
2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from bc8ca57868d2 to
ec4c6b3a6690 (1 revision) (flutter/engine#47365)
2023-10-27 john@johnmccutchan.com Don't re-initialize the default
RenderSurface when returning from hybrid composition mode
(flutter/engine#47358)
2023-10-27 skia-flutter-autoroll@skia.org Manual roll Dart SDK from
360370ff93b0 to 18678a3eddb7 (9 revisions) (flutter/engine#47357)
2023-10-26 skia-flutter-autoroll@skia.org Roll Skia from 93a0ad4d7ca6 to
bc8ca57868d2 (2 revisions) (flutter/engine#47359)
2023-10-26 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
YSn00b0Trsu2vdhIq... to 1ngqKBnmTtmFM6aBD... (flutter/engine#47363)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 37VxdxlPfdke to gPQSfYJVLOgX
  fuchsia/sdk/core/mac-amd64 from YSn00b0Trsu2 to fw9lcUvz8S07

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://github.com/flutter/packages/compare/fea24c5b93b4...2af69541a214

2023-10-26 katelovett@google.com [two_dimensional_scrollables] Add TableSpanPadding (flutter/packages#5039)
2023-10-26 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 6c4930c4ac86 to d211f4286035 (1 revision) (flutter/packages#5238)
2023-10-26 chrislangham@rightnow.org [url_launcher] migrating objc plugin to swift (flutter/packages#4753)
2023-10-26 ybz975218925@live.com [go_router_builder]Avoid losing NullabilitySuffix for typeArguments (flutter/packages#5215)
2023-10-26 engine-flutter-autoroll@skia.org Roll Flutter from 5dd2a4e0 to c555599f (14 revisions) (flutter/packages#5237)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

In preparation for migrating our fleet to macOS 13, we're updating tests to run on either macOS 12 or macOS 13.

I have run all tests on macOS 13: https://docs.google.com/spreadsheets/d/1-KOSOSF7uVA4KuqSMn9xz3IIJW78u8SXLYK2OAfe_Qg/edit?usp=sharing&resourcekey=0-df8Bj5PRS1IPBccPDdvRCQ

This reverts commit 64f31b2f.

*Replace this paragraph with a description of what this PR is changing
or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one
issue.*

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

…9) (#137247)"

This reverts commit 008a10f1.

*Replace this paragraph with a description of what this PR is changing
or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one
issue.*

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

Since the original PR that supposedly enabled proguard, it was using the
android proguard rules that disable optimizations. See initial PR in [0]

This PR changes the flutter gradle plugin to use the
`proguard-android-optimize.txt` (instead of `proguard-android.txt`)
which will enable optimizations/shrinking of platform code (i.e.
java/kotlin).

For a simple flutter hello world this results in a 25% reduction in the
resulting DEX file (`classes.dex` of the APK).

Note for users:

For some users this may result in issues because their java/kotlin code is
now better optimized & tree shaken and thereby symbols may be no longer
available or being obfuscated.

To fix those issues it's best to craft precise proguard rules describing the
extra symbols that are needed by the app (see [1]). But it's also possible to
opt out entirely of optimizations by using the unoptimized proguard rules.

To add custom proguard rules or use the unoptimized android rules, one can
update `android/app/build.gradle`:
```
android {
    ...
    buildTypes {
        release {
            ...
+            proguardFiles(
+                // Not ideal: Disables optimizations by using unoptimized android rules.
+                getDefaultProguardFile("proguard-android.txt"),
+
+                // Better: Have precise keep rules to only keep things that are needed.
+                "custom-rules.pro",
+            )
        }
    }
}
```


[0] f098de1f
[1] https://developer.android.com/build/shrink-code

Fixes https://github.com/flutter/flutter/issues/136879

This updates one of them M3 test to use golden test from https://github.com/flutter/flutter/pull/135901
Keeping it consistent with this [update](https://github.com/flutter/flutter/pull/136809#discussion_r1365053630)

This relands https://github.com/flutter/flutter/pull/136809 (it was reverted in https://github.com/flutter/flutter/pull/137242)
---

Updated unit tests for `CircleOutlinedButton` to have M2 and M3 versions.

More info in #127064

This also gets rid of unnecessary `fromSwatch` usage (part of https://github.com/flutter/flutter/issues/132584 documentation and test cleanup)

Closes https://github.com/flutter/flutter/issues/130455.

Updates the name `WebServiceWorker` uses to reference the asset manifest file to the name of the new file generated since   https://github.com/flutter/flutter/pull/131382. This will make Flutter web apps correctly prefetch the asset manifest file.

Fixes https://github.com/flutter/flutter/issues/136698.

Alters how `throwToolExit` creates its matcher. This results is an improved description of the matcher.

The mismatch description isn't improved by this, but I writing an entirely custom matcher to fix this isn't ideal either. We can instead mitigate the issue by augmenting the `toString` implementation of `ToolExit` to include the exit code, if it is non-null.

With these changes, the first few lines of output from a test would look like this:

```
Expected: throws <Instance of 'ToolExit'> with `exitCode`: <42> and `message`: contains 'message'
  Actual: <Closure: () => Never>
   Which: threw ToolExit:<Exit code: 41232. Error: message>
```

This method controls whether the builder needs to be called again again even if the layout constraints are the same.

By default, the builder will always be called when the widget is updated because the logic in the callback might have changed. However, there are cases where subclasses of ConstrainedLayoutBuilder know that certain property updates only affect paint and not build. In these cases, we lack a way of expressing that the builder callback is not needed -- and we end up doing superfluous work.

This PR gives subclasses the ability to know exactly when the callback needs to be called and when it can be skipped.

## Description

This PR fixes typos in 
- `actions.dart`
- `app_bar.dart`
- `basic.dart`
- `button_bar_theme.dart`

https://github.com/flutter/engine/compare/87f384c2d70b...bedc49efc85c

2023-10-26 dkwingsmt@users.noreply.github.com Skip invalid renders in Dart (flutter/engine#47323)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Fix Small Typos.

https://github.com/flutter/engine/compare/9788bb9ff83e...87f384c2d70b

2023-10-26 chris@bracken.jp [macOS] Reuse NSWindow instance across unit tests (flutter/engine#47350)
2023-10-26 skia-flutter-autoroll@skia.org Roll Skia from fb72136c9325 to 93a0ad4d7ca6 (1 revision) (flutter/engine#47352)
2023-10-26 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from akT2HxdLNPWSG-gbV... to 37VxdxlPfdkek7mwC... (flutter/engine#47351)
2023-10-26 johnoneil@users.noreply.github.com Fix for undefined `uint8_t` seen on Clang-15+GCC13 (flutter/engine#47288)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from akT2HxdLNPWS to 37VxdxlPfdke

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://github.com/flutter/engine/compare/ce1c1ee54107...9788bb9ff83e

2023-10-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Disable layer tree screenshots." (flutter/engine#47356)
2023-10-26 737941+loic-sharma@users.noreply.github.com [Windows] Refactor high contrast mode detection (flutter/engine#47314)
2023-10-26 jonahwilliams@google.com [Impeller] Disable layer tree screenshots. (flutter/engine#46171)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows_arm64 windows_startup_test"
}
-->
The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20windows_startup_test%22).
This test can be marked as unflaky.

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows_arm64 flutter_tool_startup__windows"
}
-->
The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20flutter_tool_startup__windows%22).
This test can be marked as unflaky.

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows_arm64 windows_home_scroll_perf__timeline_summary"
}
-->
The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20windows_home_scroll_perf__timeline_summary%22).
This test can be marked as unflaky.

Fixes https://github.com/flutter/flutter/issues/129471.

Does so by doing a very similar thing that is done by https://github.com/flutter/flutter/pull/121958, but for a task that is specific to the add to app build process.

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows_arm64 complex_layout_win_desktop__start_up"
}
-->
The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20complex_layout_win_desktop__start_up%22).
This test can be marked as unflaky.

https://github.com/flutter/engine/compare/394744d2c4d0...ce1c1ee54107

2023-10-26 jason-simmons@users.noreply.github.com [Impeller] Fix the transform and geometry criteria for an optimization in TiledTextureContents (flutter/engine#47341)
2023-10-26 jason-simmons@users.noreply.github.com Roll HarfBuzz to 8.2.2 (flutter/engine#47284)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows_arm64 hot_mode_dev_cycle_win_target__benchmark"
}
-->
The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20hot_mode_dev_cycle_win_target__benchmark%22).
This test can be marked as unflaky.

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows_arm64 flutter_view_win_desktop__start_up"
}
-->
The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20flutter_view_win_desktop__start_up%22).
This test can be marked as unflaky.

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows_arm64 platform_view_win_desktop__start_up"
}
-->
The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20platform_view_win_desktop__start_up%22).
This test can be marked as unflaky.

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows_arm64 flutter_gallery_win_desktop__start_up"
}
-->
The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20flutter_gallery_win_desktop__start_up%22).
This test can be marked as unflaky.

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows_arm64 hello_world_win_desktop__compile"
}
-->
The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20hello_world_win_desktop__compile%22).
This test can be marked as unflaky.

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows_arm64 flutter_gallery_win_desktop__compile"
}
-->
The issue https://github.com/flutter/flutter/issues/134083 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_arm64%20flutter_gallery_win_desktop__compile%22).
This test can be marked as unflaky.