Commits · 3f76be54495ad32e407a6746a8284288c74a8e8d · abdullh.alsoleman / Front-End

13 Sep, 2023 12 commits

Roll Flutter Engine from 19cfb4ca29bf to a8d7d8125382 (1 revision) (#134648) · 3f76be54

engine-flutter-autoroll authored Sep 13, 2023

https://github.com/flutter/engine/compare/19cfb4ca29bf...a8d7d8125382

2023-09-13 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from UCa49z8fu0hD9cypj... to gHhOd3d6V3Zv6CzK2... (flutter/engine#45764)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from UCa49z8fu0hD to gHhOd3d6V3Zv

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3f76be54

Roll Flutter Engine from c2224989356f to 19cfb4ca29bf (1 revision) (#134646) · e0160cb4

engine-flutter-autoroll authored Sep 13, 2023

https://github.com/flutter/engine/compare/c2224989356f...19cfb4ca29bf

2023-09-13 skia-flutter-autoroll@skia.org Roll Skia from 0d6b0aadb065 to 3ff43577d04b (1 revision) (flutter/engine#45763)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e0160cb4

Roll Flutter Engine from 8611cb0ce32d to c2224989356f (2 revisions) (#134612) · f7997c54

engine-flutter-autoroll authored Sep 13, 2023

https://github.com/flutter/engine/compare/8611cb0ce32d...c2224989356f

2023-09-13 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from MWWrSP9mSVlGIOaDo... to ftcEc93bjtc0q2a6s... (flutter/engine#45760)
2023-09-13 skia-flutter-autoroll@skia.org Roll Skia from 2ec12c767ec7 to 0d6b0aadb065 (1 revision) (flutter/engine#45759)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from MWWrSP9mSVlG to ftcEc93bjtc0

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f7997c54

Roll Flutter Engine from fb60ecf44c22 to 8611cb0ce32d (1 revision) (#134610) · d3bc7977

engine-flutter-autoroll authored Sep 13, 2023

https://github.com/flutter/engine/compare/fb60ecf44c22...8611cb0ce32d

2023-09-13 skia-flutter-autoroll@skia.org Roll Skia from 29e7723e1f8c to 2ec12c767ec7 (1 revision) (flutter/engine#45758)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d3bc7977

Roll Flutter Engine from 1273bfaa70c6 to fb60ecf44c22 (1 revision) (#134606) · 3bd62948

engine-flutter-autoroll authored Sep 13, 2023

https://github.com/flutter/engine/compare/1273bfaa70c6...fb60ecf44c22

2023-09-13 skia-flutter-autoroll@skia.org Roll Skia from b7d77eb2a9d3 to 29e7723e1f8c (2 revisions) (flutter/engine#45755)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3bd62948

Roll Flutter Engine from 7c78ea210c19 to 1273bfaa70c6 (1 revision) (#134602) · 9ec7ce63

engine-flutter-autoroll authored Sep 13, 2023

https://github.com/flutter/engine/compare/7c78ea210c19...1273bfaa70c6

2023-09-13 skia-flutter-autoroll@skia.org Roll Skia from 2d295711337c to b7d77eb2a9d3 (2 revisions) (flutter/engine#45753)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9ec7ce63

Roll Flutter Engine from c90fadf45d44 to 7c78ea210c19 (10 revisions) (#134597) · 68ce499e

engine-flutter-autoroll authored Sep 13, 2023

https://github.com/flutter/engine/compare/c90fadf45d44...7c78ea210c19

2023-09-12 zanderso@users.noreply.github.com Revert "Lazily allocate RasterCacheItems only when caching is enabled" (flutter/engine#45734)
2023-09-12 1961493+harryterkelsen@users.noreply.github.com Revert "Use a single OffscreenCanvas for rendering in CanvasKit" (flutter/engine#45744)
2023-09-12 chinmaygarde@google.com [Impeller] Patch the compiler to account for subpass inputs and PSO metadata. (flutter/engine#45739)
2023-09-12 chinmaygarde@google.com [Impeller] Fix swapchain recreation for non-polling cases. (flutter/engine#45740)
2023-09-12 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from QgAHx3BtJfN3TmodS... to UCa49z8fu0hD9cypj... (flutter/engine#45738)
2023-09-12 ychris@google.com [ios] upload extension safe artifacts (flutter/engine#45664)
2023-09-12 30870216+gaaclarke@users.noreply.github.com Added test to assert the vulkan embedder threadsafe vkqueue usage (flutter/engine#45732)
2023-09-12 chinmaygarde@google.com [Impeller] If validations are enabled but not found, still create the VK context. (flutter/engine#45674)
2023-09-12 skia-flutter-autoroll@skia.org Roll Skia from 211d63b1e1f5 to 2d295711337c (7 revisions) (flutter/engine#45729)
2023-09-12 1961493+harryterkelsen@users.noreply.github.com Use a single OffscreenCanvas for rendering in CanvasKit (flutter/engine#42672)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from QgAHx3BtJfN3 to UCa49z8fu0hD

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

68ce499e

removed unused variable in the example code of semantic event (#134551) · 15b00bf6

chrisdlangham authored Sep 13, 2023

removes unused variable in the example code of semantic events

https://api.flutter.dev/flutter/semantics/FocusSemanticEvent-class.html

15b00bf6

Update BottomSheetTest (#134562) · 6c7ddb85
hangyu authored Sep 13, 2023

6c7ddb85

Manual roll Flutter Engine from 496ef6a9c277 to c90fadf45d44 (6 revisions) (#134589) · 57d2bad7

engine-flutter-autoroll authored Sep 13, 2023

Manual roll requested by bdero@google.com

https://github.com/flutter/engine/compare/496ef6a9c277...c90fadf45d44

2023-09-12 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 43d4b1373788 to 1ee7ef8bbc65 (6 revisions) (flutter/engine#45726)
2023-09-12 ychris@google.com Reland "Build iOS unittest target in unopt builds" (#44356)"" (#45346)" (flutter/engine#45519)
2023-09-12 skia-flutter-autoroll@skia.org Roll Skia from a4f8f5177c8b to 211d63b1e1f5 (2 revisions) (flutter/engine#45724)
2023-09-12 jacksongardner@google.com Fix JS interop signatures to use only JS types. (flutter/engine#45668)
2023-09-12 ychris@google.com [ios] Fix testDeallocated failing locally. (flutter/engine#45663)
2023-09-12 ychris@google.com [iOS] move arm64 builds to arm machines (flutter/engine#45721)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

57d2bad7

_YearPicker should dispose ScrollController and MaterialSatesController. (#134393) · cef737c4
Polina Cherkasova authored Sep 13, 2023

cef737c4
Cover more test/widgets tests with leak tracking (#134387) · 7d0c9b72
Kostia Sokolovskyi authored Sep 13, 2023

7d0c9b72

12 Sep, 2023 28 commits

Fix TabBarView desynchronized after animation interruption (#132748) · 083ac65c
Bruno Leroux authored Sep 12, 2023

083ac65c
Clean up analytics opt in/out flags (#132588) · e9beaea0
Elias Yishak authored Sep 12, 2023
```
Fixes:
- #132258
```
e9beaea0

Ensure OverlayPortal.overlayChild's renderObject is reachable via treewalk (#134497) · dc8377b1

LongCatIsLooong authored Sep 12, 2023

Fixes https://github.com/flutter/flutter/issues/133545

` child._layoutSurrogate.markNeedsLayout();` was called when `_skipMarkNeedsLayout` is set true so when there's no relayout boundary between the layout surrogate and the RenderTheater, no dirty render objects will be added to the PipelineOwner's dirty list.

It's ok to mark the RenderTheater dirty when there's no layout boundary between it and the layout surrogate.

dc8377b1

Fix SliverList example descriptions (#134483) · fcba7b3d

Kate Lovett authored Sep 12, 2023

Fixes https://github.com/flutter/flutter/issues/134142

The description for the SliverList.list example was just wrong, describing something other than the sample. ð
Tweaked some of the language on the others while I was here.

fcba7b3d

Revert "Retry Linux web tests 1 time on roll presubmit" (#134586) · 3e1e869a
keyonghan authored Sep 12, 2023
```
Reverts flutter/flutter#134552
```
3e1e869a

Enable private field promotion for other packages (#134475) · 983ecf06

Michael Goderbauer authored Sep 12, 2023

New feature in upcoming Dart 3.2. See https://github.com/dart-lang/language/issues/2020. Feature is enabled by bumping the min SDK version to 3.2.

Part of https://github.com/flutter/flutter/issues/134476.

983ecf06

Roll Flutter Engine from d4698c65aa8d to 496ef6a9c277 (6 revisions) (#134569) · 93103b42

engine-flutter-autoroll authored Sep 12, 2023

https://github.com/flutter/engine/compare/d4698c65aa8d...496ef6a9c277

2023-09-12 skia-flutter-autoroll@skia.org Roll Skia from 7cafb622ee7f to a4f8f5177c8b (1 revision) (flutter/engine#45719)
2023-09-12 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from vGleXqh2SRUNJM7JN... to MWWrSP9mSVlGIOaDo... (flutter/engine#45718)
2023-09-12 skia-flutter-autoroll@skia.org Roll Skia from 438ec87ea2be to 7cafb622ee7f (1 revision) (flutter/engine#45716)
2023-09-12 matanlurey@users.noreply.github.com [Impeller] Make `CreateMockVulkanContext()` thread-safe (flutter/engine#45687)
2023-09-12 30870216+gaaclarke@users.noreply.github.com [Impeller] moved validation layers on by default logic to gni scripts (flutter/engine#45682)
2023-09-12 skia-flutter-autoroll@skia.org Roll Skia from f3f0cab7efd0 to 438ec87ea2be (1 revision) (flutter/engine#45714)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from vGleXqh2SRUN to MWWrSP9mSVlG

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

93103b42

Enable private field promotion for flutter_tools (#134474) · 240825a5

Michael Goderbauer authored Sep 12, 2023

New feature in upcoming Dart 3.2. See https://github.com/dart-lang/language/issues/2020. Feature is enabled by bumping the min SDK version to 3.2.

Part of https://github.com/flutter/flutter/issues/134476.

240825a5

Enable private field promotion for examples (#134478) · 05733402

Michael Goderbauer authored Sep 12, 2023

New feature in upcoming Dart 3.2. See https://github.com/dart-lang/language/issues/2020. Feature is enabled by bumping the min SDK version to 3.2.

In these packages, no private fields were found to be promotable.

Part of https://github.com/flutter/flutter/issues/134476.

05733402

Retry Linux web tests 1 time on roll presubmit (#134552) · 64c1223b
Zachary Anderson authored Sep 12, 2023
```
A flake in this shard caused an engine roll to fail here https://github.com/flutter/flutter/pull/134526
```
64c1223b

Enable private field promotion for dev (#134480) · b966b2be

Michael Goderbauer authored Sep 12, 2023

New feature in upcoming Dart 3.2. See https://github.com/dart-lang/language/issues/2020. Feature is enabled by bumping the min SDK version to 3.2.

Part of https://github.com/flutter/flutter/issues/134476.

b966b2be

Remove chip tooltip deprecations (#134486) · 4e7a07af

Kate Lovett authored Sep 12, 2023

Part of https://github.com/flutter/flutter/issues/133171

These deprecations were introduced in https://github.com/flutter/flutter/pull/96174
The replacement is to use `deleteButtonTooltipMessage`.
This migration is supported by dart fix. â

4e7a07af

Roll Flutter Engine from 8a8ddaeecf8a to d4698c65aa8d (2 revisions) (#134553) · cba7daf3

engine-flutter-autoroll authored Sep 12, 2023

https://github.com/flutter/engine/compare/8a8ddaeecf8a...d4698c65aa8d

2023-09-12 skia-flutter-autoroll@skia.org Roll Skia from 7e9b94634911 to f3f0cab7efd0 (1 revision) (flutter/engine#45710)
2023-09-12 derekx@google.com Add trace-to-file switch (flutter/engine#45553)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cba7daf3

Remove deprecated TextSelectionOverlay.fadeDuration (#134485) · 90ae98f5

Kate Lovett authored Sep 12, 2023

Part of https://github.com/flutter/flutter/issues/133171

This was deprecated in https://github.com/flutter/flutter/pull/100381
Th replacement is to use `SelectionOverlay.fadeDuration` instead.
This migration is supported by dart fix. â

90ae98f5

Roll Flutter Engine from 25be03186d82 to 8a8ddaeecf8a (1 revision) (#134545) · ce39d01d

engine-flutter-autoroll authored Sep 12, 2023

https://github.com/flutter/engine/compare/25be03186d82...8a8ddaeecf8a

2023-09-12 skia-flutter-autoroll@skia.org Roll Skia from a1ff98bebf89 to 7e9b94634911 (2 revisions) (flutter/engine#45707)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ce39d01d

Roll Packages from ef0c65ea4ccd to e04ba886a85e (5 revisions) (#134546) · f9aef4f2

engine-flutter-autoroll authored Sep 12, 2023

https://github.com/flutter/packages/compare/ef0c65ea4ccd...e04ba886a85e

2023-09-12 stuartmorgan@google.com [tool] Add a package inclusion filter (flutter/packages#4904)
2023-09-12 me@nils.re [flutter_markdown] Fix changelog regarding minimum supported SDK version (flutter/packages#4851)
2023-09-12 stuartmorgan@google.com [ios_platform_images] Add integration tests (flutter/packages#4899)
2023-09-12 robert@odrowaz.dev [image_picker] Copy exif tags in categories II and III (flutter/packages#4738)
2023-09-11 233583+mossmana@users.noreply.github.com [google_maps_flutter_android] Fix for testToggleInfoWindow persistently flaky (flutter/packages#4768)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f9aef4f2

Revert "Adds a parent scope TraversalEdgeBehavior and fixes modal rou… (#134550) · 5900c4ba

chunhtai authored Sep 12, 2023

…te to no… (#130841)"

This reverts commit 0f3bd90d.

Internal test needs migration

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

5900c4ba

Marks Windows_android channels_integration_test_win to be unflaky (#133129) · bdd96032

Flutter GitHub Bot authored Sep 12, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows_android channels_integration_test_win"
}
-->
The issue https://github.com/flutter/flutter/issues/130732 has been closed, and the test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows_android%20channels_integration_test_win%22).
This test can be marked as unflaky.

bdd96032

Roll Flutter Engine from 4091167e402d to 25be03186d82 (1 revision) (#134536) · 9e891f2d

engine-flutter-autoroll authored Sep 12, 2023

https://github.com/flutter/engine/compare/4091167e402d...25be03186d82

2023-09-12 skia-flutter-autoroll@skia.org Roll Skia from 55c9c377f0b0 to a1ff98bebf89 (1 revision) (flutter/engine#45706)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9e891f2d

Roll Flutter Engine from 54175da7ba90 to 4091167e402d (1 revision) (#134532) · 127c76b9

engine-flutter-autoroll authored Sep 12, 2023

https://github.com/flutter/engine/compare/54175da7ba90...4091167e402d

2023-09-12 skia-flutter-autoroll@skia.org Roll Skia from 8d11fcb3068a to 55c9c377f0b0 (1 revision) (flutter/engine#45705)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

127c76b9

Roll Flutter Engine from 85f3f02e5c37 to 54175da7ba90 (2 revisions) (#134531) · 278b145a

engine-flutter-autoroll authored Sep 12, 2023

https://github.com/flutter/engine/compare/85f3f02e5c37...54175da7ba90

2023-09-12 skia-flutter-autoroll@skia.org Roll Skia from 5b94fc73a36e to 8d11fcb3068a (1 revision) (flutter/engine#45703)
2023-09-12 skia-flutter-autoroll@skia.org Roll Skia from 72e5b5c8d5f0 to 5b94fc73a36e (1 revision) (flutter/engine#45701)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

278b145a

Roll Flutter Engine from 1369ab35aaa7 to 85f3f02e5c37 (1 revision) (#134519) · ac79c846

engine-flutter-autoroll authored Sep 12, 2023

https://github.com/flutter/engine/compare/1369ab35aaa7...85f3f02e5c37

2023-09-12 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from fSmVaZwp41ZGp5hKn... to QgAHx3BtJfN3TmodS... (flutter/engine#45700)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from fSmVaZwp41ZG to QgAHx3BtJfN3

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ac79c846

Roll Flutter Engine from 2f1efe5967f3 to 1369ab35aaa7 (1 revision) (#134512) · bb079949

engine-flutter-autoroll authored Sep 12, 2023

https://github.com/flutter/engine/compare/2f1efe5967f3...1369ab35aaa7

2023-09-12 skia-flutter-autoroll@skia.org Roll Skia from 9f92b15074a6 to 72e5b5c8d5f0 (1 revision) (flutter/engine#45696)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bb079949

Roll Flutter Engine from 4d8265cbc133 to 2f1efe5967f3 (3 revisions) (#134511) · 6f96d5eb

engine-flutter-autoroll authored Sep 12, 2023

https://github.com/flutter/engine/compare/4d8265cbc133...2f1efe5967f3

2023-09-12 skia-flutter-autoroll@skia.org Roll Skia from ba5d081cd448 to 9f92b15074a6 (1 revision) (flutter/engine#45695)
2023-09-12 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 3.1.2 to 3.1.3 (flutter/engine#45694)
2023-09-12 skia-flutter-autoroll@skia.org Roll Skia from 62aa41ee8135 to ba5d081cd448 (3 revisions) (flutter/engine#45692)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6f96d5eb

Roll Flutter Engine from ee7215553deb to 4d8265cbc133 (1 revision) (#134506) · c7f38599

engine-flutter-autoroll authored Sep 12, 2023

https://github.com/flutter/engine/compare/ee7215553deb...4d8265cbc133

2023-09-12 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from cUKimo52R-2EIfHh5... to vGleXqh2SRUNJM7JN... (flutter/engine#45691)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from cUKimo52R-2E to vGleXqh2SRUN

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c7f38599

Roll Flutter Engine from 6ddee4423d2c to ee7215553deb (2 revisions) (#134505) · e95c745b

engine-flutter-autoroll authored Sep 12, 2023

https://github.com/flutter/engine/compare/6ddee4423d2c...ee7215553deb

2023-09-12 skia-flutter-autoroll@skia.org Roll Skia from c4e94d5febdc to 62aa41ee8135 (2 revisions) (flutter/engine#45690)
2023-09-12 matanlurey@users.noreply.github.com [Impeller] Fix thread leak in ResourceManagerVK. (flutter/engine#45686)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e95c745b

Roll Flutter Engine from a98348946d61 to 6ddee4423d2c (1 revision) (#134490) · bc594bd4

engine-flutter-autoroll authored Sep 12, 2023

https://github.com/flutter/engine/compare/a98348946d61...6ddee4423d2c

2023-09-12 matej.knopp@gmail.com [Web] Properly report inverted selection (flutter/engine#44806)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bc594bd4

[New feature] Allowing the `ListView` slivers to have different extents while... · a9fac733

xubaolin authored Sep 12, 2023

[New feature] Allowing the `ListView` slivers to have different extents while still having scrolling performance (#131393)

Fixes https://github.com/flutter/flutter/issues/113431

Currently we only support specifying all slivers to have the same extent.
This patch introduces an `itemExtentBuilder` property for `ListView`, allowing the slivers to have different extents while still having scrolling performance, especially when the scroll position changes drastically(such as scrolling by the scrollbar or controller.jumpTo()).

@Piinks Hi, Any thoughts about this?  :)

a9fac733