Commits · 397fd25be105e927cda4dd35e95664fc536a7d86 · abdullh.alsoleman / Front-End

27 Nov, 2023 16 commits

Add ability to customize `NavigationBar` indicator overlay and fix indicator... · 397fd25b

Taha Tesser authored Nov 27, 2023

Add ability to customize `NavigationBar` indicator overlay and fix indicator shape for the overlay (#138901)

fixes [Provide ability to override `NavigationBar` indicator ink response overlay](https://github.com/flutter/flutter/issues/138850)
fixes [`NavigationBar.indicatorShape` is ignored, `NavigationBarThemeData.indicatorShape` is applied to the indicator inkwell](https://github.com/flutter/flutter/issues/138900)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Scaffold(
        bottomNavigationBar: NavigationBarExample(),
      ),
    );
  }
}

class NavigationBarExample extends StatefulWidget {
  const NavigationBarExample({super.key});

  @override
  State<NavigationBarExample> createState() => _NavigationBarExampleState();
}

class _NavigationBarExampleState extends State<NavigationBarExample> {
  int index = 0;

  @override
  Widget build(BuildContext context) {
    return NavigationBar(
      elevation: 0,
      overlayColor: const MaterialStatePropertyAll<Color>(Colors.transparent),
      // indicatorShape: RoundedRectangleBorder(
      //   borderRadius: BorderRadius.circular(4.0),
      // ),
      indicatorColor: Colors.transparent,
      selectedIndex: index,
      onDestinationSelected: (int index) {
        setState(() {
          this.index = index;
        });
      },
      destinations: const <Widget>[
        NavigationDestination(
          selectedIcon: Icon(Icons.home_filled),
          icon: Icon(Icons.home_outlined),
          label: 'Home',
        ),
        NavigationDestination(
          selectedIcon: Icon(Icons.favorite),
          icon: Icon(Icons.favorite_outline),
          label: 'Favorites',
        ),
      ],
    );
  }
}

```

</details>

### Before

#### Cannot override `NavigationBar` Indicator ink well overlay

![Screenshot 2023-11-22 at 18 22 48](https://github.com/flutter/flutter/assets/48603081/06f54335-71ee-4882-afb0-53b614933c38)

#### Indicator shape is ignored for the indicator overlay

![Screenshot 2023-11-22 at 15 29 52](https://github.com/flutter/flutter/assets/48603081/913e0f77-48f4-4c6e-87f3-52c81b78f3d9)

### After

#### Can use `NavigationBar.overlayColor` or `NavigationBarThemeData.NavigationBar` to override default indicator overlay

`overlayColor: MaterialStatePropertyAll<Color>(Colors.red.withOpacity(0.33)),`

![Screenshot 2023-11-22 at 18 22 08](https://github.com/flutter/flutter/assets/48603081/28badae4-a7c7-4bf0-8bcc-278a1f84729d)

`overlayColor: MaterialStatePropertyAll<Color>(Colors.transparent),`

![Screenshot 2023-11-22 at 18 22 25](https://github.com/flutter/flutter/assets/48603081/674b48b1-f66a-4d91-9f10-ad307416ac32)

#### Indicator shape is respected for the indicator overlay

![Screenshot 2023-11-22 at 15 30 36](https://github.com/flutter/flutter/assets/48603081/ae9a3627-787e-45ac-9319-2ea8ea1e6ae6)

397fd25b

Roll Flutter Engine from cc57ace8e2e7 to 9fe149249957 (1 revision) (#139077) · 7b80797d

engine-flutter-autoroll authored Nov 27, 2023

https://github.com/flutter/engine/compare/cc57ace8e2e7...9fe149249957

2023-11-27 skia-flutter-autoroll@skia.org Manual roll Dart SDK from f1fd14505782 to c9bdb5884670 (10 revisions) (flutter/engine#48402)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7b80797d

Add type validation to non-template .arb file parsing logic (#139035) · 1952a6c8

Andrew Kolos authored Nov 27, 2023

Resolves https://github.com/flutter/flutter/issues/138297.

When reading from a .arb file (which contains localizations of strings in the form of a user-defined JSON string-string map), validate the type of values that we read.

See [this comment of mine on #138297](https://github.com/flutter/flutter/issues/138297#issuecomment-1827043260) to see how I arrived at this fix.

1952a6c8

Update Android app project template to apply Kotlin Gradle plugin declaratively (#139006) · e8282edf

Bartek Pacia authored Nov 27, 2023

This PR updates the app templates generated by `flutter create` to use declarative `plugins {}` syntax for applying the Kotlin Gradle Plugin.

I realized this is missing while writing [#9857.](https://github.com/flutter/website/pull/9857)

e8282edf

Prepare for dynamically sized views - pt. 2 (#139079) · 9147a1c1

Michael Goderbauer authored Nov 27, 2023

Towards https://github.com/flutter/flutter/issues/134501.

Required to roll https://github.com/flutter/engine/pull/48090 into the framework.

Two new subclasses of FlutterView were added recently for testing (in https://github.com/flutter/flutter/pull/138849) that I missed in my previous PR (https://github.com/flutter/flutter/pull/138565).

9147a1c1

Prepare for dynamically sized views (#138565) · bf5d2b87

Michael Goderbauer authored Nov 27, 2023

Towards https://github.com/flutter/flutter/issues/134501.

Required to roll https://github.com/flutter/engine/pull/48090 into the framework.

**DO NOT SUBMIT until https://github.com/flutter/flutter/pull/138648 and https://github.com/flutter/engine/pull/48090 are ready.**

bf5d2b87

Write tests for API examples of BottomNavigationBar and IconButton (#138188) · ec639f35

Jasper van Riet authored Nov 27, 2023

This PR writes tests for a few of the API examples (not all), as requested in #130459. For the test names, I used the existing tests in the `api` folder as guide.

ec639f35

Roll Flutter Engine from 9b610ecda771 to cc57ace8e2e7 (2 revisions) (#139072) · 9a930dd6

engine-flutter-autoroll authored Nov 27, 2023

https://github.com/flutter/engine/compare/9b610ecda771...cc57ace8e2e7

2023-11-27 skia-flutter-autoroll@skia.org Roll Skia from 5f0832787d0f to b0d81aba3f78 (1 revision) (flutter/engine#48401)
2023-11-27 skia-flutter-autoroll@skia.org Roll Skia from 9fa62ccefe59 to 5f0832787d0f (1 revision) (flutter/engine#48400)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9a930dd6

Give an actionable error message when a Pod requires a higher minimum OS version (#138097) · d628a6ff

stuartmorgan authored Nov 27, 2023

Checks `pod install` output for the case where a pod requires a higher minimum OS deployment target version than the app is set to use, and attempts to turn it into a more actionable error message. This isn't foolproof since we are parsing the Ruby rather than actually executing it, but I would expect that the vast majority of cases would end up in the most useful version (and even those that don't are still much clearer with this as the final error message text than without it).

Fixes https://github.com/flutter/flutter/issues/113762

d628a6ff

Edge case on flutter/flutter/issues/135402 with test (#138814) · 311193d3

Reid Baker authored Nov 27, 2023

fixes flutter/flutter/issues/135402
Edge case that was reported by a user along with a test case specifically covering their output.

311193d3

Roll Packages from 97f0a4049d0b to e774e8887ce2 (4 revisions) (#139066) · 23289958

engine-flutter-autoroll authored Nov 27, 2023

https://github.com/flutter/packages/compare/97f0a4049d0b...e774e8887ce2

2023-11-27 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.5 to 2.22.8 (flutter/packages#5472)
2023-11-27 engine-flutter-autoroll@skia.org Roll Flutter from cf05f3c4 to b5f163a6 (3 revisions) (flutter/packages#5477)
2023-11-27 43054281+camsim99@users.noreply.github.com [camerax] Adds proxy class for testing detached/mock objects and method calls (flutter/packages#5423)
2023-11-24 engine-flutter-autoroll@skia.org Roll Flutter from 106667eb to cf05f3c4 (10 revisions) (flutter/packages#5474)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

23289958

Roll Flutter Engine from 6f499ecea657 to 9b610ecda771 (1 revision) (#139063) · 422287b7

engine-flutter-autoroll authored Nov 27, 2023

https://github.com/flutter/engine/compare/6f499ecea657...9b610ecda771

2023-11-27 matej.knopp@gmail.com Reduce number of surfaces required when presenting platform views (flutter/engine#43301)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

422287b7

Roll Flutter Engine from 61233cde4bb3 to 6f499ecea657 (2 revisions) (#139051) · 754d6082

engine-flutter-autoroll authored Nov 27, 2023

https://github.com/flutter/engine/compare/61233cde4bb3...6f499ecea657

2023-11-27 skia-flutter-autoroll@skia.org Roll Skia from 2bf9afca2bc1 to 9fa62ccefe59 (1 revision) (flutter/engine#48393)
2023-11-27 skia-flutter-autoroll@skia.org Roll Skia from b3e896c2f9bf to 2bf9afca2bc1 (1 revision) (flutter/engine#48392)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

754d6082

Roll Flutter Engine from 292a92166a94 to 61233cde4bb3 (1 revision) (#139041) · 9130ac78

engine-flutter-autoroll authored Nov 27, 2023

https://github.com/flutter/engine/compare/292a92166a94...61233cde4bb3

2023-11-27 skia-flutter-autoroll@skia.org Roll Skia from 0eea0b277d7d to b3e896c2f9bf (2 revisions) (flutter/engine#48391)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9130ac78

Roll Flutter Engine from ebebb25aaa46 to 292a92166a94 (3 revisions) (#139037) · c45f5837

engine-flutter-autoroll authored Nov 27, 2023

https://github.com/flutter/engine/compare/ebebb25aaa46...292a92166a94

2023-11-27 bdero@google.com [Flutter GPU] Texture binding, index binding, attachments, depth state. (flutter/engine#48386)
2023-11-27 jonahwilliams@google.com [Impeller] use spec constant for decal support in morph filter. (flutter/engine#48288)
2023-11-27 jonahwilliams@google.com [Impeller] OES extension does not apply to regular textures for decal support (flutter/engine#48388)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c45f5837

Roll Flutter Engine from eb18add9ebc5 to ebebb25aaa46 (2 revisions) (#139034) · 2949638e

engine-flutter-autoroll authored Nov 27, 2023

https://github.com/flutter/engine/compare/eb18add9ebc5...ebebb25aaa46

2023-11-26 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from zHKuNuXtMPLbovc0j... to qyRH6zYfUEjo9L1x2... (flutter/engine#48389)
2023-11-26 skia-flutter-autoroll@skia.org Roll Skia from b18b594b230d to 0eea0b277d7d (7 revisions) (flutter/engine#48387)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from zHKuNuXtMPLb to qyRH6zYfUEjo

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2949638e

26 Nov, 2023 1 commit

Roll Flutter Engine from 77432202f766 to eb18add9ebc5 (1 revision) (#139007) · 984dc194

engine-flutter-autoroll authored Nov 26, 2023

https://github.com/flutter/engine/compare/77432202f766...eb18add9ebc5

2023-11-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from P3HXI8K3eIeoBYhdX... to zHKuNuXtMPLbovc0j... (flutter/engine#48376)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from P3HXI8K3eIeo to zHKuNuXtMPLb

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

984dc194

25 Nov, 2023 1 commit

Roll Flutter Engine from b50fc4ad6820 to 77432202f766 (1 revision) (#138995) · b5f163a6

engine-flutter-autoroll authored Nov 25, 2023

https://github.com/flutter/engine/compare/b50fc4ad6820...77432202f766

2023-11-25 bdero@google.com [Flutter GPU] Raster encoding. First triangle! (flutter/engine#48314)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b5f163a6

24 Nov, 2023 5 commits

Roll Flutter Engine from b1e0bf62fa35 to b50fc4ad6820 (1 revision) (#138990) · 92a08bf5

engine-flutter-autoroll authored Nov 24, 2023

https://github.com/flutter/engine/compare/b1e0bf62fa35...b50fc4ad6820

2023-11-24 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 4CZFCL5oL042nQihC... to P3HXI8K3eIeoBYhdX... (flutter/engine#48365)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 4CZFCL5oL042 to P3HXI8K3eIeo

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

92a08bf5

Roll Packages from 6c5ad9ee1a0b to 97f0a4049d0b (1 revision) (#138982) · a3e3270f

engine-flutter-autoroll authored Nov 24, 2023

https://github.com/flutter/packages/compare/6c5ad9ee1a0b...97f0a4049d0b

2023-11-23 engine-flutter-autoroll@skia.org Manual roll Flutter from 14549b38 to 106667eb (3 revisions) (flutter/packages#5470)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a3e3270f

Roll Flutter Engine from 7e640faa6adf to b1e0bf62fa35 (1 revision) (#138979) · cf05f3c4

engine-flutter-autoroll authored Nov 24, 2023

https://github.com/flutter/engine/compare/7e640faa6adf...b1e0bf62fa35

2023-11-24 skia-flutter-autoroll@skia.org Roll Skia from 201d0c8d83f0 to b18b594b230d (1 revision) (flutter/engine#48356)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cf05f3c4

Roll Flutter Engine from d67ac2c561ca to 7e640faa6adf (2 revisions) (#138969) · 6b56d492

engine-flutter-autoroll authored Nov 24, 2023

https://github.com/flutter/engine/compare/d67ac2c561ca...7e640faa6adf

2023-11-24 skia-flutter-autoroll@skia.org Roll Skia from de1673ed1618 to 201d0c8d83f0 (1 revision) (flutter/engine#48352)
2023-11-24 skia-flutter-autoroll@skia.org Roll Skia from b3d947126fd2 to de1673ed1618 (1 revision) (flutter/engine#48350)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6b56d492

Roll Flutter Engine from 152790b5811b to d67ac2c561ca (1 revision) (#138965) · 82d456db

engine-flutter-autoroll authored Nov 24, 2023

https://github.com/flutter/engine/compare/152790b5811b...d67ac2c561ca

2023-11-24 skia-flutter-autoroll@skia.org Roll Skia from 2c89bb28860b to b3d947126fd2 (1 revision) (flutter/engine#48349)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

82d456db

23 Nov, 2023 7 commits

Roll Flutter Engine from 4a344e050401 to 152790b5811b (1 revision) (#138959) · 4d75edb3

engine-flutter-autoroll authored Nov 23, 2023

https://github.com/flutter/engine/compare/4a344e050401...152790b5811b

2023-11-23 skia-flutter-autoroll@skia.org Roll Skia from 094c3d963ba0 to 2c89bb28860b (1 revision) (flutter/engine#48341)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4d75edb3

Roll Flutter Engine from 6e71c3642abf to 4a344e050401 (1 revision) (#138958) · a14d7214

engine-flutter-autoroll authored Nov 23, 2023

https://github.com/flutter/engine/compare/6e71c3642abf...4a344e050401

2023-11-23 skia-flutter-autoroll@skia.org Roll Skia from fc9c5337e568 to 094c3d963ba0 (6 revisions) (flutter/engine#48340)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a14d7214

Roll Flutter Engine from bec0dacaae41 to 6e71c3642abf (2 revisions) (#138956) · ba6d8749

engine-flutter-autoroll authored Nov 23, 2023

https://github.com/flutter/engine/compare/bec0dacaae41...6e71c3642abf

2023-11-23 skia-flutter-autoroll@skia.org Roll Skia from 5606ef899116 to fc9c5337e568 (1 revision) (flutter/engine#48339)
2023-11-23 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from IK4xyRtZkDwqT6pXA... to 4CZFCL5oL042nQihC... (flutter/engine#48338)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from IK4xyRtZkDwq to 4CZFCL5oL042

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ba6d8749

[flutter_tools] Fix bad state future already completed in flutter logs (#138517) · 4c978efe
Christopher Fujino authored Nov 23, 2023
```
Fixes https://github.com/flutter/flutter/issues/138436
```
4c978efe

Fix SliverGrid garbage collection issue (#138915) · d92d2c12

chunhtai authored Nov 23, 2023

The code doesn't consider indices of children may not be continuous after rebuild.

fixes https://github.com/flutter/flutter/issues/138749

d92d2c12

Roll Flutter Engine from f331e0afaf2e to bec0dacaae41 (6 revisions) (#138954) · 2663e50a

engine-flutter-autoroll authored Nov 23, 2023

https://github.com/flutter/engine/compare/f331e0afaf2e...bec0dacaae41

2023-11-23 linxunfeng@yeah.net Fix not being able to hide iOS status bar via setEnabledSystemUIMode (flutter/engine#48271)
2023-11-22 mdebbar@google.com [web] Hook the new JS API to the FlutterViewManager (flutter/engine#48283)
2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from 3a79d7a618aa to 5606ef899116 (1 revision) (flutter/engine#48331)
2023-11-22 louiseh0313@gmail.com Fix Share Screen Crash on iPad (flutter/engine#48220)
2023-11-22 dnfield@google.com Delete unused/test only code from FML (flutter/engine#48327)
2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from 30ecaac60b47 to 3a79d7a618aa (1 revision) (flutter/engine#48328)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2663e50a

Roll Packages from 2102327ab9f2 to 6c5ad9ee1a0b (1 revision) (#138950) · 791470b1

engine-flutter-autoroll authored Nov 23, 2023

https://github.com/flutter/packages/compare/2102327ab9f2...6c5ad9ee1a0b

2023-11-22 engine-flutter-autoroll@skia.org Manual roll Flutter from ab721f93 to 14549b38 (20 revisions) (flutter/packages#5466)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

791470b1

22 Nov, 2023 10 commits

Bump dessant/lock-threads from 5.0.0 to 5.0.1 (#138921) · 106667eb

dependabot[bot] authored Nov 22, 2023

Bumps [dessant/lock-threads](https://github.com/dessant/lock-threads) from 5.0.0 to 5.0.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/dessant/lock-threads/releases">dessant/lock-threads's releases</a>.</em></p>
<blockquote>
<h2>v5.0.1</h2>
<p>Learn more about this release from the <a href="https://github.com/dessant/lock-threads/blob/main/CHANGELOG.md#changelog">changelog</a>.</p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/dessant/lock-threads/blob/main/CHANGELOG.md">dessant/lock-threads's changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<p>All notable changes to this project will be documented in this file. See <a href="https://github.com/absolute-version/commit-and-tag-version">commit-and-tag-version</a> for commit guidelines.</p>
<h2><a href="https://github.com/dessant/lock-threads/compare/v5.0.0...v5.0.1">5.0.1</a> (2023-11-22)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>support filtering threads by labels with spaces (<a href="https://github.com/dessant/lock-threads/commit/0a6367823273242f373440ac6d682e4f368a347f">0a63678</a>), closes <a href="https://redirect.github.com/dessant/lock-threads/issues/40">#40</a></li>
</ul>
<h2><a href="https://github.com/dessant/lock-threads/compare/v4.0.1...v5.0.0">5.0.0</a> (2023-11-14)</h2>
<h3>â  BREAKING CHANGES</h3>
<ul>
<li>Discussions are also processed by default,
set the <code>process-only</code> input parameter to preserve the old behavior</li>
</ul>
<pre lang="yaml"><code>    steps:
      - uses: dessant/lock-threads@v5
        with:
          process-only: 'issues, prs'
</code></pre>
<ul>
<li>the action now requires Node.js 20</li>
</ul>
<h3>Features</h3>
<ul>
<li>lock discussions (<a href="https://github.com/dessant/lock-threads/commit/0a0976f3ded51c88c6128dd96dd115c9f14fa764">0a0976f</a>), closes <a href="https://redirect.github.com/dessant/lock-threads/issues/25">#25</a></li>
</ul>
<h3>Bug Fixes</h3>
<ul>
<li>update dependencies (<a href="https://github.com/dessant/lock-threads/commit/5a25b54eae3e7a5580d09ef0f7cbc5b18376db67">5a25b54</a>)</li>
</ul>
<h3><a href="https://github.com/dessant/lock-threads/compare/v4.0.0...v4.0.1">4.0.1</a> (2023-06-12)</h3>
<h3>Bug Fixes</h3>
<ul>
<li>retry and throttle GitHub API requests (<a href="https://github.com/dessant/lock-threads/commit/1618e91da69b9fe614fb9837ac673ea4600eb529">1618e91</a>), closes <a href="https://redirect.github.com/dessant/lock-threads/issues/35">#35</a></li>
</ul>
<h2><a href="https://github.com/dessant/lock-threads/compare/v3.0.0...v4.0.0">4.0.0</a> (2022-12-04)</h2>
<h3>â  BREAKING CHANGES</h3>
<ul>
<li>the action now requires Node.js 16</li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/dessant/lock-threads/commit/1bf7ec25051fe7c00bdd17e6a7cf3d7bfb7dc771"><code>1bf7ec2</code></a> chore(release): 5.0.1</li>
<li><a href="https://github.com/dessant/lock-threads/commit/adf4aa5f8a0d18d97dd60dd54220a9df27170c75"><code>adf4aa5</code></a> chore: update package</li>
<li><a href="https://github.com/dessant/lock-threads/commit/0a6367823273242f373440ac6d682e4f368a347f"><code>0a63678</code></a> fix: support filtering threads by labels with spaces</li>
<li>See full diff in <a href="https://github.com/dessant/lock-threads/compare/d42e5f49803f3c4e14ffee0378e31481265dda22...1bf7ec25051fe7c00bdd17e6a7cf3d7bfb7dc771">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=dessant/lock-threads&package-manager=github_actions&previous-version=5.0.0&new-version=5.0.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

106667eb

Manual roll Flutter Engine from 342fb003b11f to f331e0afaf2e (9 revisions) (#138918) · ce1231d6

engine-flutter-autoroll authored Nov 22, 2023

Manual roll requested by jacksongardner@google.com

https://github.com/flutter/engine/compare/342fb003b11f...f331e0afaf2e

2023-11-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] pass const ref to binding helpers." (flutter/engine#48330)
2023-11-22 jacksongardner@google.com Revert "Manual roll Dart SDK from f1fd14505782 to df958dc1ca7b (6 revisions)" (flutter/engine#48325)
2023-11-22 jonahwilliams@google.com [Impeller] cache render target properties on Render Pass. (flutter/engine#48323)
2023-11-22 jonahwilliams@google.com [Impeller] pass const ref to binding helpers. (flutter/engine#48318)
2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from 994558cd1fae to 30ecaac60b47 (1 revision) (flutter/engine#48324)
2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from 9086788fc341 to 994558cd1fae (1 revision) (flutter/engine#48322)
2023-11-22 31859944+LongCatIsLooong@users.noreply.github.com Expose a few more glyph apis from `ui.Paragraph` (flutter/engine#47698)
2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from efdec1f459ce to 9086788fc341 (2 revisions) (flutter/engine#48317)
2023-11-22 skia-flutter-autoroll@skia.org Manual roll Dart SDK from f1fd14505782 to df958dc1ca7b (6 revisions) (flutter/engine#48316)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ce1231d6

Fix team-infra label in dependabot (#138917) · 094f529b

Michael Goderbauer authored Nov 22, 2023

As part of the new triage process (https://flutter.dev/go/triage-2023-rfc) the "team: infra" label was replaced by "team-infra"

094f529b

make FakeView not send Scene and semantics to the engine (#138849) · 14549b38

Yegor authored Nov 22, 2023

`FakeView` wraps the same underlying `FlutterView`. Sending semantics updates and Scene objects from multiple fake views into the same engine `FlutterView` violates contracts with the engine. This PR stubs out `render` and `updateSemantics` methods in `FakeView` classes to prevent that.

This unblocks https://github.com/flutter/engine/pull/48251, which implements multi-view semantics for web.

14549b38

Update the default outline color for `OutlinedButton` (#138768) · c7d4b32f

Qun Cheng authored Nov 22, 2023

Fix b/311343182

This is to update the default outline for `OutlinedButton`. When the button is focused, the outline color should be primary color.

c7d4b32f

Roll Flutter Engine from c954a64c509b to 342fb003b11f (1 revision) (#138903) · 843074c5

engine-flutter-autoroll authored Nov 22, 2023

https://github.com/flutter/engine/compare/c954a64c509b...342fb003b11f

2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from 2c68a803f497 to efdec1f459ce (2 revisions) (flutter/engine#48315)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

843074c5

Roll Packages from c9933fc09a0b to 2102327ab9f2 (3 revisions) (#138895) · 721ee574

engine-flutter-autoroll authored Nov 22, 2023

https://github.com/flutter/packages/compare/c9933fc09a0b...2102327ab9f2

2023-11-22 mikemcguiness@protonmail.com [cross_file] adopt code excerpts in README (flutter/packages#5347)
2023-11-21 engine-flutter-autoroll@skia.org Manual roll Flutter from 9c9e0617 to ab721f93 (16 revisions) (flutter/packages#5461)
2023-11-21 kevmoo@users.noreply.github.com [url_launcher_web] migrate to pkg:web (flutter/packages#5451)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

721ee574

Marks Mac_build_test flutter_gallery__transition_perf_e2e_ios to be unflaky (#138886) · 29c95cda

Flutter GitHub Bot authored Nov 22, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_build_test flutter_gallery__transition_perf_e2e_ios"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_build_test%20flutter_gallery__transition_perf_e2e_ios%22).
This test can be marked as unflaky.

29c95cda

Roll Flutter Engine from d55b673f895c to c954a64c509b (1 revision) (#138894) · 35a53b0b

engine-flutter-autoroll authored Nov 22, 2023

https://github.com/flutter/engine/compare/d55b673f895c...c954a64c509b

2023-11-22 skia-flutter-autoroll@skia.org Roll Skia from af2bd26a3a5e to 2c68a803f497 (1 revision) (flutter/engine#48311)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

35a53b0b

Add `commandHasTerminal` parameter + apple usage event + `sendException`... · 48187028

Elias Yishak authored Nov 22, 2023

Add `commandHasTerminal` parameter + apple usage event + `sendException` events for `package:unified_analytics` (#138806)

Relates to tracker issue:
- https://github.com/flutter/flutter/issues/128251

This PR includes 3 major updates:
- Adding the `commandHasTerminal` parameter for `Event.flutterCommandResult`
  - In `packages/flutter_tools/lib/src/runner/flutter_command.dart`
- Adding the new event for `sendException` from package:usage to be `Event.exception` (this event can be used by all dash tools)
  - In `packages/flutter_tools/lib/runner.dart`
- Migrating the generic `UsageEvent` which was only used for Apple related workflows for iOS and macOS. I did an initial analysis in this [sheet](https://docs.google.com/spreadsheets/d/11KJLkHXFpECMX7tw-trNkYSr5MHDG15XNGv6TgLjfQs/edit?resourcekey=0-j4qdvsOEEg3wQW79YlY1-g#gid=0) to identify all the call sites
  - Found in several files, highlighted in the sheet above

48187028