1. 16 Aug, 2021 3 commits
    • Tong Mu's avatar
      Revert "Revert "Revert "Restores surface size in the postTest of test binding... · 31d0787d
      Tong Mu authored
      Revert "Revert "Revert "Restores surface size in the postTest of test binding (#87240)" (#87258)" (#87297)" (#88293)
      
      This reverts commit 91f8b6be.
      31d0787d
    • Swiftaxe's avatar
      Removed no-shuffle tag and fixed leak in debug_test.dart (#88268) · e7f9bcba
      Swiftaxe authored
      Co-authored-by: 's avatarAlexander Dahlberg <alexander.dahlberg@sigma.se>
      
      The TapGestureRecognizer in the test named 'TapGestureRecognizer _sentTapDown toString' was not disposed, which was breaking a couple of other tests.
      This worked fine when not shuffling the tests as the test was executed last.
      e7f9bcba
    • Swiftaxe's avatar
      Animation controller test (#88251) · fe337dca
      Swiftaxe authored
      Co-authored-by: 's avatarAlexander Dahlberg <alexander.dahlberg@sigma.se>
      
      Fixes test/animation/animation_controller_test.dart in #85160
      
      Problem:
      The test 'animateTo can deal with duration == Duration.Zero' was failing with the following error:
      
      Expected: <0>
      Actual: <5>
      Expected no animation.
      package:test_api expect
      package:flutter_test/src/widget_tester.dart 484:3 expect
      test/animation/animation_controller_test.dart 511:5 main.
      
      Following line finds 5 transientCallbacks scheduled, while expecting zero, if shuffled with seed 123:
      
      expect(SchedulerBinding.instance!.transientCallbackCount, equals(0), reason: 'Expected no animation.');
      
      This is caused by some other test leaving transientCallbacks scheduled.
      
      Fix:
      By disposing the AnimationController after each test, the transientCallbacks get cleaned up.
      I chose to dispose all controllers in every test, to make sure there is no risk of leaks.
      fe337dca
  2. 15 Aug, 2021 2 commits
  3. 14 Aug, 2021 11 commits
  4. 13 Aug, 2021 9 commits
  5. 12 Aug, 2021 15 commits