Commits · 31a16f342e4612d6df02c76212fc5d5a14dff8a1 · abdullh.alsoleman / Front-End

19 May, 2023 21 commits

Roll goldctl to f808dcff91b221ae313e540c09d79696cd08b8de (#127218) · 31a16f34

Zachary Anderson authored May 19, 2023

goldctl hasn't been updated in about a year, and an update may be needed to reland https://github.com/flutter/flutter/pull/127110.

31a16f34

Roll Packages from b31a12861905 to 1e214d716ed4 (3 revisions) (#127217) · c7b898b1

engine-flutter-autoroll authored May 19, 2023

https://github.com/flutter/packages/compare/b31a12861905...1e214d716ed4

2023-05-18 engine-flutter-autoroll@skia.org Roll Flutter from d0d1feb6 to 5ae64381 (42 revisions) (flutter/packages#4038)
2023-05-18 stuartmorgan@google.com [ci] Lower iOS LUCI timeouts (flutter/packages#4035)
2023-05-18 stuartmorgan@google.com [ci] Increase Android sharding (flutter/packages#4029)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c7b898b1

Roll Flutter Engine from a0ea4d2d9ea5 to f471b37a2146 (1 revision) (#127212) · 4f6f1887

engine-flutter-autoroll authored May 19, 2023

https://github.com/flutter/engine/compare/a0ea4d2d9ea5...f471b37a2146

2023-05-19 41930132+hellohuanlin@users.noreply.github.com [floating_cursor_selection]add some comments on the tricky part (flutter/engine#42136)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4f6f1887

Revert "Migrate benchmarks to package:web" (#127207) · 3001d6ab

joshualitt authored May 19, 2023

Reverts flutter/flutter#126848

Triggered some kind of measuring discrepancy / performance regression.

3001d6ab

[tool] delete xcresult bundle file before each xcode retry. (#127144) · 972b4474

Chris Yang authored May 19, 2023

xcodebuild command generates a xcresult bundle file on each run, however, it doesn't delete the file generated from previous run and will throw an error if the exact file already exists.

In tool, we manually delete the file after each `flutter build` or `flutter run` command. However, there are some internal logic where xcodebuild retries multiple times.

This PR deletes the xcresult bundle file at the start of each retry if it exists.

Fixes https://github.com/flutter/flutter/issues/127119

972b4474

[iOS] Dispose of log readers and port forwarders if launch fails (#127140) · b9e8b0a8

Victoria Ashworth authored May 19, 2023

When tests run in our CI using `flutter drive`, if there is a failure it will loop and try again.

https://github.com/flutter/flutter/blob/434b81f1a58b8528299a63ae7c3ded2aa519e3c9/packages/flutter_tools/lib/src/drive/drive_service.dart#L177-L186

However, it's using the same `device` instance for each iteration. So what was happening was when it would fail to launch, it would tell its listeners that it was cancelled.
https://github.com/flutter/flutter/blob/434b81f1a58b8528299a63ae7c3ded2aa519e3c9/packages/flutter_tools/lib/src/ios/ios_deploy.dart#L486-L489

Then when the next iteration started, the `vmServiceDiscovery` would immediately return with null because the `deviceLogReader` would be cached from the previous iteration and would already be cancelled. Therefore, bypassing and cancelling the timer.

https://github.com/flutter/flutter/blob/434b81f1a58b8528299a63ae7c3ded2aa519e3c9/packages/flutter_tools/lib/src/ios/devices.dart#L585-L591

https://github.com/flutter/flutter/blob/434b81f1a58b8528299a63ae7c3ded2aa519e3c9/packages/flutter_tools/lib/src/ios/devices.dart#L627

In addition, it seems like sometimes the stop would fail and therefore the the drain would never get the signal that it was done and therefore would hang forever. There was no indication that the stop had failed though because the logs were going to the stream that had no listeners since `deviceLogReader` was already cancelled.
https://github.com/flutter/flutter/blob/434b81f1a58b8528299a63ae7c3ded2aa519e3c9/packages/flutter_tools/lib/src/ios/ios_deploy.dart#L563-L576

Fixes https://github.com/flutter/flutter/issues/127141

b9e8b0a8

Roll Flutter Engine from 2e6b1e6c3458 to a0ea4d2d9ea5 (1 revision) (#127203) · 077d644b

engine-flutter-autoroll authored May 19, 2023

https://github.com/flutter/engine/compare/2e6b1e6c3458...a0ea4d2d9ea5

2023-05-19 skia-flutter-autoroll@skia.org Roll Skia from 9cc604b2c3ed to 0a63dbe8cd15 (1 revision) (flutter/engine#42159)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

077d644b

Roll Flutter Engine from e9178e115f14 to 2e6b1e6c3458 (1 revision) (#127196) · 54ac355d

engine-flutter-autoroll authored May 19, 2023

https://github.com/flutter/engine/compare/e9178e115f14...2e6b1e6c3458

2023-05-19 mdebbar@google.com [web] Cleanup Vector3 (flutter/engine#42096)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

54ac355d

fix(flutter_tools): `findBundleFile` w/multiple flavor dimensions (#127133) · 3af7f9be

Felix Angelov authored May 19, 2023

Fixes the `findBundleFile` method in `gradle.dart` to correctly locate app bundles generated from multiple flavor dimensions.

- closes https://github.com/flutter/flutter/issues/92316
- closes https://github.com/flutter/flutter/issues/65264

3af7f9be

Roll Flutter Engine from 2e8875870f52 to e9178e115f14 (1 revision) (#127188) · 0d67c7e1

engine-flutter-autoroll authored May 19, 2023

https://github.com/flutter/engine/compare/2e8875870f52...e9178e115f14

2023-05-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 4a2e45ecfc50 to f5716102efe8 (2 revisions) (flutter/engine#42156)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0d67c7e1

Roll Flutter Engine from c7a209cc40c1 to 2e8875870f52 (1 revision) (#127185) · 3d69e1f3

engine-flutter-autoroll authored May 19, 2023

https://github.com/flutter/engine/compare/c7a209cc40c1...2e8875870f52

2023-05-19 skia-flutter-autoroll@skia.org Roll Skia from aac83f59bbba to 9cc604b2c3ed (1 revision) (flutter/engine#42152)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3d69e1f3

Roll Flutter Engine from 5a57ff52f0f7 to c7a209cc40c1 (2 revisions) (#127175) · 6456d603

engine-flutter-autoroll authored May 19, 2023

https://github.com/flutter/engine/compare/5a57ff52f0f7...c7a209cc40c1

2023-05-19 skia-flutter-autoroll@skia.org Roll Skia from 9e38597c3757 to aac83f59bbba (1 revision) (flutter/engine#42150)
2023-05-19 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from zqkH0qb9GQ3jO24Bh... to eal6a4HeaQon_Y4ml... (flutter/engine#42149)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from zqkH0qb9GQ3j to eal6a4HeaQon

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6456d603

Roll Flutter Engine from bfbd2e1dafb0 to 5a57ff52f0f7 (1 revision) (#127172) · 2f299f2a

engine-flutter-autoroll authored May 19, 2023

https://github.com/flutter/engine/compare/bfbd2e1dafb0...5a57ff52f0f7

2023-05-19 skia-flutter-autoroll@skia.org Roll Skia from 37e853069c04 to 9e38597c3757 (1 revision) (flutter/engine#42148)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2f299f2a

Roll Flutter Engine from e64084596182 to bfbd2e1dafb0 (2 revisions) (#127167) · b50ec64b

engine-flutter-autoroll authored May 19, 2023

https://github.com/flutter/engine/compare/e64084596182...bfbd2e1dafb0

2023-05-19 skia-flutter-autoroll@skia.org Roll Skia from 09d8a47a1f65 to 37e853069c04 (1 revision) (flutter/engine#42147)
2023-05-19 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Tl371NrGBEHFYPxHQ... to IGeTvUK2wkajmQQ2k... (flutter/engine#42145)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from Tl371NrGBEHF to IGeTvUK2wkaj

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b50ec64b

Roll Flutter Engine from 6bc60c8a9877 to e64084596182 (2 revisions) (#127163) · 47f3532d

engine-flutter-autoroll authored May 19, 2023

https://github.com/flutter/engine/compare/6bc60c8a9877...e64084596182

2023-05-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 95b96a9f498a to 4a2e45ecfc50 (1 revision) (flutter/engine#42143)
2023-05-19 skia-flutter-autoroll@skia.org Roll Skia from 8931359a74f1 to 09d8a47a1f65 (1 revision) (flutter/engine#42141)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

47f3532d

Roll Flutter Engine from bca11a423f9c to 6bc60c8a9877 (1 revision) (#127162) · fcba066b

engine-flutter-autoroll authored May 19, 2023

https://github.com/flutter/engine/compare/bca11a423f9c...6bc60c8a9877

2023-05-19 leroux_bruno@yahoo.fr [Android] Fix BasicMessageChannel.resizeChannelBuffer (flutter/engine#41982)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fcba066b

Roll Flutter Engine from 9039c2dfb74c to bca11a423f9c (2 revisions) (#127156) · e49d35d3

engine-flutter-autoroll authored May 19, 2023

https://github.com/flutter/engine/compare/9039c2dfb74c...bca11a423f9c

2023-05-19 yjbanov@google.com [web:a11y] support dialogs described by descendants (flutter/engine#42108)
2023-05-18 47866232+chunhtai@users.noreply.github.com Makes android embedding to send full uri (flutter/engine#41836)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e49d35d3

Roll Flutter Engine from 3c23ddae1d2a to 9039c2dfb74c (2 revisions) (#127154) · 8135a4be

engine-flutter-autoroll authored May 19, 2023

https://github.com/flutter/engine/compare/3c23ddae1d2a...9039c2dfb74c

2023-05-18 skia-flutter-autoroll@skia.org Roll Skia from 2ffed2e4c6f8 to 8931359a74f1 (4 revisions) (flutter/engine#42139)
2023-05-18 skia-flutter-autoroll@skia.org Roll Dart SDK from 7bc022c51215 to 95b96a9f498a (2 revisions) (flutter/engine#42138)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8135a4be

Properly cleans up routes (#126453) · ea5cfe09
chunhtai authored May 19, 2023
```
fixes https://github.com/flutter/flutter/issues/126100
```
ea5cfe09

Remove deprecated `primaryVariant` and `secondaryVariant` from `ColorScheme` (#127124) · af83c767

Qun Cheng authored May 19, 2023

This PR is to remove deprecated `primaryVariant` and `secondaryVariant` from framework. These two apis are made obsolete in #93427

Part of https://github.com/flutter/flutter/issues/127042

af83c767

Roll Flutter Engine from 17227c16ca58 to 3c23ddae1d2a (2 revisions) (#127147) · 25d2d4dd

engine-flutter-autoroll authored May 19, 2023

https://github.com/flutter/engine/compare/17227c16ca58...3c23ddae1d2a

2023-05-18 skia-flutter-autoroll@skia.org Roll Skia from ac47a05bf253 to 2ffed2e4c6f8 (8 revisions) (flutter/engine#42137)
2023-05-18 chris@bracken.jp [macOS] Refactor PlatformView mutators (flutter/engine#42130)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

25d2d4dd

18 May, 2023 16 commits

Update `useMaterial3` api doc (#127142) · be409910
Qun Cheng authored May 18, 2023
```
This is to update the components section for `useMaterial3` api doc.
```
be409910

Roll Flutter Engine from c7c679d6d411 to 17227c16ca58 (1 revision) (#127143) · 45808c28

engine-flutter-autoroll authored May 18, 2023

https://github.com/flutter/engine/compare/c7c679d6d411...17227c16ca58

2023-05-18 leroux_bruno@yahoo.fr [Android] Return keyboard pressed state (flutter/engine#41695)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

45808c28

Roll Flutter Engine from 2c77c8011d45 to c7c679d6d411 (1 revision) (#127139) · 0b8c226a

engine-flutter-autoroll authored May 18, 2023

https://github.com/flutter/engine/compare/2c77c8011d45...c7c679d6d411

2023-05-18 47866232+chunhtai@users.noreply.github.com Make iOS embedding to send full uri for deeplinks (flutter/engine#41992)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0b8c226a

Roll Flutter Engine from 5fb3179a19c3 to 2c77c8011d45 (2 revisions) (#127131) · affba75f

engine-flutter-autoroll authored May 18, 2023

https://github.com/flutter/engine/compare/5fb3179a19c3...2c77c8011d45

2023-05-18 kevinjchisholm@gmail.com Add configuration for automating release notes (flutter/engine#42132)
2023-05-18 skia-flutter-autoroll@skia.org Roll Skia from 62841fa33e95 to ac47a05bf253 (9 revisions) (flutter/engine#42131)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

affba75f

Migrate benchmarks to package:web (#126848) · 4fea3ef5
joshualitt authored May 18, 2023

4fea3ef5

Roll Flutter Engine from 237c60185ace to 5fb3179a19c3 (3 revisions) (#127126) · 2d6c67f4

engine-flutter-autoroll authored May 18, 2023

https://github.com/flutter/engine/compare/237c60185ace...5fb3179a19c3

2023-05-18 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from jNFpQ1gTCMNbzSZCw... to Tl371NrGBEHFYPxHQ... (flutter/engine#42128)
2023-05-18 103135467+sealesj@users.noreply.github.com Vuln scan github actions permissions (flutter/engine#42099)
2023-05-18 skia-flutter-autoroll@skia.org Roll Dart SDK from 1991015ad460 to 7bc022c51215 (1 revision) (flutter/engine#42125)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from jNFpQ1gTCMNb to Tl371NrGBEHF

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2d6c67f4

Fixing richMessage gesture recognizer in tooltip widget (#126207) · 434b81f1

Mahdi Bagheri authored May 18, 2023

Fixing #126206 and #113388 issues

*The IgnorePointer is preventing the richMessage touch events being recognized. Just removing that from*

*Solves #126206 and #113388*

434b81f1

Roll Flutter Engine from 843ce0bba356 to 237c60185ace (2 revisions) (#127122) · 682dd3bd

engine-flutter-autoroll authored May 18, 2023

https://github.com/flutter/engine/compare/843ce0bba356...237c60185ace

2023-05-18 skia-flutter-autoroll@skia.org Roll Skia from ad8fa4a38668 to 62841fa33e95 (2 revisions) (flutter/engine#42123)
2023-05-18 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from SDKw1RvH0dWiJXERo... to zqkH0qb9GQ3jO24Bh... (flutter/engine#42124)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from SDKw1RvH0dWi to zqkH0qb9GQ3j

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

682dd3bd

Revert "Handle null return from WillPopCallback" (#127112) · 5ae64381
Michael Goderbauer authored May 18, 2023
```
Reverts flutter/flutter#127039

Google3 has been fixed, so this work around is no longe necessary.
```
5ae64381

Roll Flutter Engine from a22dd6438335 to 843ce0bba356 (6 revisions) (#127116) · 2b95fa67

engine-flutter-autoroll authored May 18, 2023

https://github.com/flutter/engine/compare/a22dd6438335...843ce0bba356

2023-05-18 skia-flutter-autoroll@skia.org Roll Skia from a3a9fb5f4a31 to ad8fa4a38668 (1 revision) (flutter/engine#42121)
2023-05-18 skia-flutter-autoroll@skia.org Roll Dart SDK from 7f6fabbe9fba to 1991015ad460 (4 revisions) (flutter/engine#42120)
2023-05-18 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from wNfsef5we4l8hxEII... to jNFpQ1gTCMNbzSZCw... (flutter/engine#42118)
2023-05-18 skia-flutter-autoroll@skia.org Roll Skia from caff30d16ae7 to a3a9fb5f4a31 (1 revision) (flutter/engine#42117)
2023-05-18 skia-flutter-autoroll@skia.org Roll Skia from ffa425bacfc4 to caff30d16ae7 (29 revisions) (flutter/engine#42116)
2023-05-18 chris@bracken.jp [macOS] Clean up PlatformView mutator scaling (flutter/engine#42110)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from wNfsef5we4l8 to jNFpQ1gTCMNb

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2b95fa67

mark windows build tests non-bringup (#127059) · 344c9c6a

Christopher Fujino authored May 18, 2023

This is a follow-up to https://github.com/flutter/flutter/commit/aa0a1a7ae1467f54e962a5616e5bf4385fbf1daf. I was forced to mark these targets bringup in that PR because the targets were technically new (since each name changed 3 -> 4), so this is marking them non-bringup.

344c9c6a

Roll Flutter Engine from d97037077963 to a22dd6438335 (1 revision) (#127071) · 4245883c

engine-flutter-autoroll authored May 18, 2023

https://github.com/flutter/engine/compare/d97037077963...a22dd6438335

2023-05-17 xilaizhang@google.com [g3 roll] Revert "add non-rendering
operation culling to DisplayListBuilder" (flutter/engine#42097)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4245883c

Roll Packages from 5c6991400e91 to b31a12861905 (9 revisions) (#127109) · 5381e82a

engine-flutter-autoroll authored May 18, 2023

https://github.com/flutter/packages/compare/5c6991400e91...b31a12861905

2023-05-18 stuartmorgan@google.com [flutter_plugin_android_lifecycle] Fix lints (flutter/packages#4030)
2023-05-18 ian@hixie.ch [rfw] Fix a typo in the API documentation (flutter/packages#4023)
2023-05-18 ditman@gmail.com [ci] Manual flutter roll (flutter/packages#4033)
2023-05-17 4195507+fmt-Println-MKO@users.noreply.github.com [flutter_adaptive_scaffold] exchange BottomNavigationBar with NavigationBar (flutter/packages#3746)
2023-05-17 stuartmorgan@google.com [tools] Ignore comments in federated safety check (flutter/packages#4028)
2023-05-17 reidbaker@google.com Revert "[url_launcher] Set broadcast reciever visability as required by target api 34" (flutter/packages#4027)
2023-05-17 stuartmorgan@google.com [camera] Fix Java lints in camerax version (flutter/packages#3966)
2023-05-17 34871572+gmackall@users.noreply.github.com [image_picker] Upgrade androidx.activity to 1.7.0 and add a dependency on kotlin-bom to align kotlin transitive dependencies (flutter/packages#3968)
2023-05-17 49699333+dependabot[bot]@users.noreply.github.com [espresso]: Bump com.squareup.okhttp3:okhttp from 4.10.0 to 4.11.0 in /packages/espresso/android (flutter/packages#3804)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5381e82a

Revert "Remove obsolete drawShadow bounds workaround" (#127110) · 6071f149

Justin McCandless authored May 18, 2023

Reverts flutter/flutter#127052, which seems to be breaking the build
because of a goldens failure.

```
The following TestFailure was thrown running a test:
Expected: one widget whose rasterized image matches golden image "shadow.PhysicalModel.enabled.png"
  Actual: _WidgetTypeFinder:<exactly one widget with type "Container" (ignoring offstage widgets):
Container(bg: Color(0xfffff59d), margin: EdgeInsets.all(150.0))>
```

See
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_tests_6/11051/overview

6071f149

Clip search view content during animation (#126975) · f31dae2a

Qun Cheng authored May 18, 2023

Fixes #126590

This PR is to clip the view content when the view size is not big enough, such as during animation.
Also removes some unused properties in `_ViewContent` class: `getRect` and `viewConstraints`

f31dae2a

Remove obsolete drawShadow bounds workaround (#127052) · 8089a309

Jim Graham authored May 18, 2023

This workaround was created 6 years ago with no links to bug databases to track. As best we can determine, the issue is no longer present in SkPicture or DisplayList and is most likely obsolete. More importantly, though, non-rendering primitives are ignored by the DisplayList construction and so this workaround will just be ignored anyway. If a problem surfaces about this issue that we haven't discovered by a thorough code search of the current code base, then workarounds should be installed within the relevant implementation modules rather than in the framework (and documented with bugs filed in either or both of Flutter's github repos, and/or the Skia issue database).

Workaround originally created in this PR: https://github.com/flutter/flutter/pull/9654

8089a309

17 May, 2023 3 commits

[Windows] Improve version migration message (#127048) · 718f444b
Loïc Sharma authored May 17, 2023
```
This also migrates the platform channel example to stamp version information on Windows.
```
718f444b

Bump actions/labeler from 9471598e3b7ff22b2fa181bd79addf94cb3e0847 to... · a3a0ef03

dependabot[bot] authored May 17, 2023

Bump actions/labeler from 9471598e3b7ff22b2fa181bd79addf94cb3e0847 to 6b107e7a7ee5e054e0bcce60de5181d21e2f00fb (#127056)

Bumps [actions/labeler](https://github.com/actions/labeler) from 9471598e3b7ff22b2fa181bd79addf94cb3e0847 to 6b107e7a7ee5e054e0bcce60de5181d21e2f00fb.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/actions/labeler/commit/6b107e7a7ee5e054e0bcce60de5181d21e2f00fb"><code>6b107e7</code></a> Bump <code>@âtypescript-eslint/parser</code> from 5.59.5 to 5.59.6 (<a href="https://redirect.github.com/actions/labeler/issues/565">#565</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/d93c73a681c099c55b461e5ef853f84b8335eebf"><code>d93c73a</code></a> Bump <code>@âtypescript-eslint/eslint-plugin</code> from 5.59.5 to 5.59.6 (<a href="https://redirect.github.com/actions/labeler/issues/566">#566</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/b6f708799c1101ee9adc1388b397da244f9dec1c"><code>b6f7087</code></a> Bump <code>@âtypescript-eslint/eslint-plugin</code> from 5.59.2 to 5.59.5 (<a href="https://redirect.github.com/actions/labeler/issues/559">#559</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/2d89bd50598cb5288ebd91402d368ebb889ebdc6"><code>2d89bd5</code></a> Bump <code>@âtypescript-eslint/parser</code> from 5.59.2 to 5.59.5 (<a href="https://redirect.github.com/actions/labeler/issues/560">#560</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/581d1100aad5e840ecddbe532d475ab7b2e3b823"><code>581d110</code></a> Bump eslint from 8.39.0 to 8.40.0 (<a href="https://redirect.github.com/actions/labeler/issues/558">#558</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/8bb487275077addd935ff34fd81cda8dc53b6cbe"><code>8bb4872</code></a> Bump eslint from 8.38.0 to 8.39.0 (<a href="https://redirect.github.com/actions/labeler/issues/543">#543</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/9c4ae1e1124d78f7b1e31d451ea2c8b2199df4f9"><code>9c4ae1e</code></a> Bump <code>@âtypescript-eslint/eslint-plugin</code> from 5.58.0 to 5.59.2 (<a href="https://redirect.github.com/actions/labeler/issues/553">#553</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/228fdad71d6ca2122f78183ba915be56c28ba970"><code>228fdad</code></a> Bump prettier from 2.8.7 to 2.8.8 (<a href="https://redirect.github.com/actions/labeler/issues/544">#544</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/377691d3d6bba411b0050ded8b41e9d6732a4c49"><code>377691d</code></a> Bump <code>@âtypescript-eslint/parser</code> from 5.58.0 to 5.59.2 (<a href="https://redirect.github.com/actions/labeler/issues/554">#554</a>)</li>
<li>See full diff in <a href="https://github.com/actions/labeler/compare/9471598e3b7ff22b2fa181bd79addf94cb3e0847...6b107e7a7ee5e054e0bcce60de5181d21e2f00fb">compare view</a></li>
</ul>
</details>
<br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

a3a0ef03

Remove deprecated fixTextFieldOutlineLabel (#125893) · d44d657a

Renzo Olivares authored May 17, 2023

The deprecation period has elapsed. The method was made obsolete in https://github.com/flutter/flutter/pull/87281.

d44d657a