1. 12 Jul, 2018 6 commits
    • Danny Tuppeny's avatar
      Align expressions better (#19256) · 2e215fdf
      Danny Tuppeny authored
      2e215fdf
    • Hans Muller's avatar
    • Alexander Aprelev's avatar
      Revert "Roll engine to fed2ea458ed49088d33eddabc546ba56d600c717 (includes dart... · cc122f16
      Alexander Aprelev authored
      Revert "Roll engine to fed2ea458ed49088d33eddabc546ba56d600c717 (includes dart roll) again (#19277)" (#19295)
      
      This reverts commit 700cb767 as it
      breaks Windows tests.
      cc122f16
    • Alexander Aprelev's avatar
      Roll engine to fed2ea458ed49088d33eddabc546ba56d600c717 (includes dart roll) again (#19277) · 700cb767
      Alexander Aprelev authored
      * Revert "Revert "Roll engine to fed2ea458ed49088d33eddabc546ba56d600c717 (includes dart roll) (#19044)" (#19276)"
      
      This reverts commit cf932490 as it also
      includes fix for type error that broke tests.
      
      * Add type cast for dart2 type checks.
      
      * Move up to latest goldens
      
      * Make inDirectory() type-parameterized.
      
      * Add typecasting to transitions_perf_test.dart and microbenchmarks.
      
      * Add boolean flag initialization in save_catalog_screenshots.dart
      
      * Add type conversion to gallery transition test
      700cb767
    • Chris Bracken's avatar
      Push /usr/bin to front of PATH for ios-deploy runs (#19281) · 379a2d56
      Chris Bracken authored
      ios-deploy relies on LLDB.framework, which relies on /usr/bin/python and
      the 'six' module that's installed on the system. However, it appears to
      use the first version of Python on PATH, rather than explicitly
      specifying the system install.  If a user has a custom install of Python
      (e.g., via Homebrew or MacPorts) ahead of the system Python on their
      PATH, LLDB.framework will pick up that version instead. If the user
      hasn't installed the 'six' module, ios-deploy will fail with a
      relatively cryptic error message.
      
      This patch pushes /usr/bin to the front of PATH for the duration of the
      ios-deploy run to avoid this scenario.
      
      This patch also removes checks for package six.
      
      Neither Flutter nor any of its direct dependencies/tooling relies on
      package six. ios-deploy depends on LLDB.framework (included with Xcode),
      which relies on a Python script that imports this package but uses
      whichever Python is at the front of the path. Flutter now invokes
      ios-deploy with a PATH with /usr/bin forced to the front in order to
      avoid this problem.
      
      We could have retained the check out of paranoia, but this seems
      unnecessary since it's entirely possible LLDB.framework may one day drop
      this dependency, in which case I'd expect the base system install of
      Python would likely drop it as well.
      379a2d56
    • xster's avatar
  2. 11 Jul, 2018 9 commits
  3. 10 Jul, 2018 13 commits
    • Chris Bracken's avatar
      Revert "Roll engine to 4466d61a993fdbde2cb092b4da9bbef33d1962fe (#192… (#19233) · 02f4f32b
      Chris Bracken authored
      …30)"
      
      Causes microbenchmarks to start failing. This included the following
      engine PR, which appears to be the culprit:
      * Remove vmservice_io.main from entry points. (flutter/engine#5625)
      
      This reverts commit 36437904.
      02f4f32b
    • Ian Hickson's avatar
      Remove hacks that make macOs, Linux, and Windows not fail. (#19187) · b3a6eda2
      Ian Hickson authored
      They should fail, because we don't have real support yet.
      
      Also, make the debug override work in release builds, so that people
      on those platforms have a workaround.
      b3a6eda2
    • Chris Bracken's avatar
      Roll engine to 4466d61a993fdbde2cb092b4da9bbef33d1962fe (#19230) · 36437904
      Chris Bracken authored
      Includes:
      * Remove vmservice_io.main from entry points. (flutter/engine#5625)
      * Roll src/third_party/skia 7e2327b133db..723b1f6ef941 (1 commits) (flutter/engine#5642)
      * Roll src/third_party/skia 24d18ced1ad7..7e2327b133db (6 commits) (flutter/engine#5641)
      * Roll src/third_party/skia a1e5630183c1..24d18ced1ad7 (7 commits) (flutter/engine#5639)
      36437904
    • liyuqian's avatar
      Increase image cache to 100MB (#19220) · 160d92e3
      liyuqian authored
      This should fix #18952 and #813
      160d92e3
    • Chris Bracken's avatar
      Roll engine to ce06bbac58d7c68487dd09616864c904e2f71a72 (#19213) · 59d6527f
      Chris Bracken authored
      * ensure a11y state is communicated back to flutter (flutter/engine#5631)
      * Roll src/third_party/skia b1b87d9df81e..a1e5630183c1 (10 commits) (flutter/engine#5637)
      * Roll src/third_party/skia 385804514edf..b1b87d9df81e (6 commits) (flutter/engine#5636)
      * Roll src/third_party/skia e97bb26893a1..385804514edf (1 commits) (flutter/engine#5635)
      * Roll src/third_party/skia e2e52e46ca63..e97bb26893a1 (1 commits) (flutter/engine#5634)
      * Roll src/third_party/skia 14de25dfc7c4..e2e52e46ca63 (2 commits) (flutter/engine#5633)
      * Roll src/third_party/skia 551dc3e91143..14de25dfc7c4 (2 commits) (flutter/engine#5630)
      * libtxt: apply an offset to drawing operations instead of translating the canvas (flutter/engine#5628)
      * Roll src/third_party/skia 059a9ab4bcd0..551dc3e91143 (5 commits) (flutter/engine#5629)
      * Roll src/third_party/skia 45c9dab4c3ec..059a9ab4bcd0 (8 commits) (flutter/engine#5627)
      * Remove some unused code from the Android host (flutter/engine#5619)
      * Roll src/third_party/skia 37b7e4714558..45c9dab4c3ec (1 commits) (flutter/engine#5626)
      * Roll src/third_party/skia c421ca1d6e41..37b7e4714558 (2 commits) (flutter/engine#5624)
      * Roll src/third_party/skia 5b201e3b0ba8..c421ca1d6e41 (3 commits) (flutter/engine#5623)
      * Roll src/third_party/skia d47fe095cf88..5b201e3b0ba8 (6 commits) (flutter/engine#5622)
      * Roll src/third_party/skia 9c0ce41cf711..d47fe095cf88 (12 commits) (flutter/engine#5618
      * Roll src/third_party/skia d4b2adeaa929..9c0ce41cf711 (7 commits) (flutter/engine#5617)
      * Roll src/third_party/skia f46710802ad5..d4b2adeaa929 (1 commits) (flutter/engine#5616)
      59d6527f
    • Chris Bracken's avatar
      Revert "Add segmented control to gallery (#19192)" (#19227) · 32af1699
      Chris Bracken authored
      This appears to trigger an error during AOT snapshot of the gallery as
      follows:
      
      ```
      stdout: [   +6 ms] Building AOT snapshot in release mode (ios-release)...
      stdout: [  +15 ms] Extra gen_snapshot options: [--print_snapshot_sizes]
      stdout: [   +7 ms] /usr/bin/arch -x86_64 /Users/flutter/.cocoon/flutter/bin/cache/artifacts/engine/ios-release/gen_snapshot --await_is_keyword --causal_async_stacks --packages=.packages --url_mapping=dart:ui,/Users/flutter/.cocoon/flutter/bin/cache/pkg/sky_engine/lib/ui/ui.dart --url_mapping=dart:vmservice_io,/Users/flutter/.cocoon/flutter/bin/cache/pkg/sky_engine/sdk_ext/vmservice_io.dart --embedder_entry_points_manifest=/Users/flutter/.cocoon/flutter/bin/cache/artifacts/engine/ios-release/dart_vm_entry_points.txt --embedder_entry_points_manifest=/Users/flutter/.cocoon/flutter/bin/cache/artifacts/engine/ios-release/dart_io_entries.txt --print_snapshot_sizes --snapshot_kind=app-aot-assembly --assembly=build/aot/arm64/snapshot_assembly.S /Users/flutter/.cocoon/flutter/examples/flutter_gallery/lib/main.dart
      stderr: [+9324 ms] Error: 'file:///Users/flutter/.cocoon/flutter/examples/flutter_gallery/lib/demo/cupertino/cupertino_segmented_control_demo.dart': error: line 19 pos 1: circular dependency for function _CupertinoSegmentedControlDemoState
      stderr: [        ] class _CupertinoSegmentedControlDemoState extends State {
      stderr: [        ] ^
      stderr: [  +33 ms] Dart snapshot generator failed with exit code 254
      stderr: [        ] Snapshotting (IOSArch.arm64) exited with non-zero exit code: 254
      stdout: [        ] Built to build/aot/.
      stdout: [  +10 ms] "flutter aot" took 9,485ms.
      ```
      
      This reverts commit 9d49ee3b.
      32af1699
    • Natalie Sampsell's avatar
      Add segmented control to gallery (#19192) · 9d49ee3b
      Natalie Sampsell authored
      * Adding segmented control to gallery
      9d49ee3b
    • Leaf Petersen's avatar
      Fix use of Future<void> as a Future<bool> (#18843) · 3397338c
      Leaf Petersen authored
      * Fix use of Future<void> as a Future<bool>
      3397338c
    • Danny Tuppeny's avatar
      Improve error message in microbenchmarks when flutter run lives too long (#19200) · 127d1f85
      Danny Tuppeny authored
      This should make it more obvious from the error what's gone wrong if we see a repeat of #19096 (previously the error was something like "Bad state: future already completed").
      127d1f85
    • Danny Tuppeny's avatar
      Improve flutter tools integration tests (#18865) · b931640c
      Danny Tuppeny authored
      * Rename util -> test_utils
      
      * Rename flutter_test_driver -> test_driver
      
      * Switch testWithContext -> test
      
      * Remove unused import
      
      * Move test project into a class to make it easier to have multiple of these
      
      Each "TestProject" class can contain its files and things like named breakpoint locations.
      
      * Split expression evaluation tests into own file
      
      * Include last response in error messages
      
      * Update expectations based on current bugs
      
      * Fix async-ness in tests
      
      * Fix incorrect expectation in test
      
      * Fix incorrect evaluations
      
      * Remove skips for tests that are now passing on master
      
      * Expect pass on Linux
      
      🤷‍♂️
      
      * Call the code
      
      * Skip expression evaluation tests on Windows
      
      * Skip whole group, not just one test
      
      * Remove duplicated method from merge
      
      * Fix misplaced close of group
      
      * Remove code that was duplicated from test we copied
      
      Not sure how this ended up in here?
      
      * Re-fix typo
      b931640c
    • Natalie Sampsell's avatar
      Segmented control animation (#18811) · 236acb52
      Natalie Sampsell authored
      Added animation to segmented control widget.
      236acb52
    • Ian Hickson's avatar
      Remove bogus SDK constraint lines. (#19013) · 03a1f4ac
      Ian Hickson authored
      03a1f4ac
    • Jonah Williams's avatar
  4. 09 Jul, 2018 12 commits